[Bug 53066] New: Wireshark shows black rectangle on various places if light theme is enabled
https://bugs.winehq.org/show_bug.cgi?id=53066 Bug ID: 53066 Summary: Wireshark shows black rectangle on various places if light theme is enabled Product: Wine Version: 7.9 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: uxtheme Assignee: wine-bugs(a)winehq.org Reporter: rpisl(a)seznam.cz Distribution: --- Created attachment 72469 --> https://bugs.winehq.org/attachment.cgi?id=72469 Black rectangle in main window Wireshark shows black rectangles on various places if light theme is enabled. Wireshark uses Qt5 and these visual bugs are common for various other applications that use this library. These messages appear in the log: 00fc:fixme:uxtheme:GetThemeBackgroundRegion Unknown background type ... (wireshark:248) 11:07:18.427038 [GUI CRITICAL] -- OpenThemeData() failed for theme 11 (TASKDIALOG). (There are also other visual bugs visible: menu item is not highlighted under mouse cursor and incorrect button rendering.) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53066 --- Comment #1 from Roman Pišl <rpisl(a)seznam.cz> --- Created attachment 72470 --> https://bugs.winehq.org/attachment.cgi?id=72470 Black rectangle in message window -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53066 --- Comment #2 from Roman Pišl <rpisl(a)seznam.cz> --- Created attachment 72471 --> https://bugs.winehq.org/attachment.cgi?id=72471 Black rectangles in scrollbars -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53066 Roman Pišl <rpisl(a)seznam.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://1.eu.dl.wireshark.o | |rg/win64/Wireshark-win64-3. | |6.5.exe Keywords| |download -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53066 Zhiyi Zhang <zzhang(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zzhang(a)codeweavers.com --- Comment #3 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- I will take a look. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53066 Zhiyi Zhang <zzhang(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #4 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- Confirmed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53066 --- Comment #5 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- Created attachment 72499 --> https://bugs.winehq.org/attachment.cgi?id=72499 patch 1/3 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53066 --- Comment #6 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- Created attachment 72500 --> https://bugs.winehq.org/attachment.cgi?id=72500 patch 2/3 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53066 --- Comment #7 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- Created attachment 72501 --> https://bugs.winehq.org/attachment.cgi?id=72501 patch 3/3 Please test these patches and see if they fix all of the issues. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53066 --- Comment #8 from Roman Pišl <rpisl(a)seznam.cz> --- It looks good! I just caught a few glitches and the bug from comment 1 is still present (just double click on any interface from the main window). -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53066 --- Comment #9 from Roman Pišl <rpisl(a)seznam.cz> --- Created attachment 72502 --> https://bugs.winehq.org/attachment.cgi?id=72502 Minor glitches 1 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53066 --- Comment #10 from Roman Pišl <rpisl(a)seznam.cz> --- Created attachment 72503 --> https://bugs.winehq.org/attachment.cgi?id=72503 Minor glitches 2 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53066 --- Comment #11 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- (In reply to Roman Pišl from comment #10)
Created attachment 72503 [details] Minor glitches 2
What's wrong with this? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53066 --- Comment #12 from Roman Pišl <rpisl(a)seznam.cz> --- (In reply to Zhiyi Zhang from comment #11)
(In reply to Roman Pišl from comment #10)
Created attachment 72503 [details] Minor glitches 2
What's wrong with this?
You are right, this is correct. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53066 Roman Pišl <rpisl(a)seznam.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72503|0 |1 is obsolete| | -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53066 --- Comment #13 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- Please test this branch. It should fix the aforementioned issues. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53066 --- Comment #14 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- (In reply to Zhiyi Zhang from comment #13)
Please test this branch. It should fix the aforementioned issues.
https://github.com/zzhiyi/wine/commits/wireshark-theming -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53066 --- Comment #15 from Roman Pišl <rpisl(a)seznam.cz> --- Created attachment 72519 --> https://bugs.winehq.org/attachment.cgi?id=72519 Vertical scrollbar glitch Vertical scrollbar buttons have incorrect direction on mouse-over. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53066 --- Comment #16 from Roman Pišl <rpisl(a)seznam.cz> --- Created attachment 72520 --> https://bugs.winehq.org/attachment.cgi?id=72520 Horizontal scrollbar glitch Horizontal scrollbar button has incorrect direction on mouse-over. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53066 --- Comment #17 from Roman Pišl <rpisl(a)seznam.cz> --- Created attachment 72521 --> https://bugs.winehq.org/attachment.cgi?id=72521 Edit box glitch Edit box has visual glitches on buttons on mouse-over. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53066 --- Comment #18 from Roman Pišl <rpisl(a)seznam.cz> --- I also use a custom Qt application with no other bugs observable which spams console with "OpenThemeData() failed for theme 16 (WINDOW). (Element not found.)". That is probably for another bug report.. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53066 --- Comment #19 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- (In reply to Roman Pišl from comment #18)
I also use a custom Qt application with no other bugs observable which spams console with "OpenThemeData() failed for theme 16 (WINDOW). (Element not found.)". That is probably for another bug report..
Could you provide this application? The problem with Qt5 applications is that they are querying a lot of Vista+ theme properties. However, Wine's Light theme originally only uses XP theme properties so a lot of the properties needed are not present and applications end up using the wrong parts or states. So I have to add support for all these Vista+ theme properties to get Qt5 applications working properly, which will take quite some time. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53066 --- Comment #20 from Roman Pišl <rpisl(a)seznam.cz> --- (In reply to Zhiyi Zhang from comment #19)
(In reply to Roman Pišl from comment #18)
I also use a custom Qt application with no other bugs observable which spams console with "OpenThemeData() failed for theme 16 (WINDOW). (Element not found.)". That is probably for another bug report..
Could you provide this application?
Yes, I will prepare a minimal example in a new bug report. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53066 --- Comment #21 from Roman Pišl <rpisl(a)seznam.cz> --- (In reply to Zhiyi Zhang from comment #19)
(In reply to Roman Pišl from comment #18)
I also use a custom Qt application with no other bugs observable which spams console with "OpenThemeData() failed for theme 16 (WINDOW). (Element not found.)". That is probably for another bug report..
Could you provide this application?
This problem can be reproduced with LibreCAD (https://github.com/LibreCAD/LibreCAD/releases) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53066 James Beddek <telans(a)posteo.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |telans(a)posteo.de -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53066 --- Comment #22 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- Please test this branch https://github.com/zzhiyi/wine/commits/wireshark-theming -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53066 --- Comment #23 from Roman Pišl <rpisl(a)seznam.cz> --- (In reply to Zhiyi Zhang from comment #22)
Please test this branch https://github.com/zzhiyi/wine/commits/wireshark-theming
I see everything is fixed. I'll keep it in my local repo for further testing. Nice work! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53066 Zhiyi Zhang <zzhang(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #24 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- Fixed on master. 914b1246d372ebc94eb4e877f1d183fca48f641b marks the last commit that add the parts required for Qt5 applications. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53066 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #25 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 7.12. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla