[Bug 33489] New: WinRAR 5.0 beta 1 help causes HH crash
http://bugs.winehq.org/show_bug.cgi?id=33489 Bug #: 33489 Summary: WinRAR 5.0 beta 1 help causes HH crash Product: Wine Version: 1.5.29 Platform: x86 URL: http://www.rarlabs.com/rar/wrar50b1.exe OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: hhctrl.ocx AssignedTo: wine-bugs(a)winehq.org ReportedBy: t.artem(a)mailcity.com Classification: Unclassified Created attachment 44328 --> http://bugs.winehq.org/attachment.cgi?id=44328 `wine start WinRAR.chm` backtrace That's it. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33489 Artem S. Tashkinov <t.artem(a)mailcity.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33489 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #1 from Nikolay Sivov <bunglehead(a)gmail.com> 2013-04-29 10:32:16 CDT --- It fails on attribute value that contains '>': --- 0024:trace:htmlhelp:parse_hhindex <LI> 0024:trace:htmlhelp:parse_li <OBJECT type="text/sitemap"> 0024:trace:htmlhelp:parse_index_sitemap_object <param name="Name" value=""-oi[-][:<minsize> 0024:warn:htmlhelp:parse_index_obj_node_param value attr not found --- so <minsize> misinterpreted as end of 'param' element and later it fails to get 'value' attribute value cause there's no closing quotation mark. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33489 Fabian Ebner <f.ebner94(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |f.ebner94(a)gmail.com --- Comment #2 from Fabian Ebner <f.ebner94(a)gmail.com> 2013-05-01 06:38:33 CDT --- The failing function is next_node in hhctrl.ocx/stream.c ... if(!stream_chr(stream, NULL, '<')) return FALSE; if(!stream_chr(stream, buf, '>')) return FALSE; ... -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33489 Erich Hoover <ehoover(a)mines.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ehoover(a)mines.edu --- Comment #3 from Erich Hoover <ehoover(a)mines.edu> 2013-05-01 19:36:30 CDT --- Wow, I'm surprised that HTML Help will let you get away with not using ">" and "<" there. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33489 --- Comment #4 from Erich Hoover <ehoover(a)mines.edu> 2013-05-02 14:03:18 CDT --- Created attachment 44355 --> http://bugs.winehq.org/attachment.cgi?id=44355 Fix node detection Please try the attached patch. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33489 --- Comment #5 from Nikolay Sivov <bunglehead(a)gmail.com> 2013-05-02 14:52:10 CDT --- I feel like it should be a specialized version of next_node() that expects a node to contain attributes and that these attributes could potentially have mark-up symbols in their values. For this approach it should just scan forward and parse attributes and values, and it's possibly a duplication of what we already have in other helpers. So yeah, using existing code it will look messy anyway. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33489 --- Comment #6 from Fabian Ebner <f.ebner94(a)gmail.com> 2013-05-03 09:59:19 CDT --- For WinRAR the patch works. But if a node like <param name="tagstart" value="<"> appeared, it would still fail (If such a node is valid?) So the real problem is the quotes (and ' is too possible, or am I wrong)? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33489 Erich Hoover <ehoover(a)mines.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44355|0 |1 is obsolete| | AssignedTo|wine-bugs(a)winehq.org |ehoover(a)mines.edu --- Comment #7 from Erich Hoover <ehoover(a)mines.edu> 2013-05-11 17:00:28 CDT --- Created attachment 44443 --> http://bugs.winehq.org/attachment.cgi?id=44443 Fix node detection [v2] The attached patch should provide a better fix, the other one I just tried to whip up as quickly as possible. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33489 --- Comment #8 from Fabian Ebner <f.ebner94(a)gmail.com> 2013-05-16 13:37:02 CDT --- Thanks, the patch works fine. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33489 Jerome Leclanche <adys.wh(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33489 --- Comment #9 from Artem S. Tashkinov <t.artem(a)mailcity.com> 2013-08-13 15:20:00 CDT --- Why the patch hasn't yet been merged? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33489 --- Comment #10 from Erich Hoover <erich.e.hoover(a)gmail.com> 2013-08-13 15:24:48 CDT --- (In reply to comment #9)
Why the patch hasn't yet been merged?
I was hoping to hear back from nsivov on his thoughts about the revised patch. Also, I'm frequently working on other patches :) -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33489 --- Comment #11 from Erich Hoover <erich.e.hoover(a)gmail.com> --- This issue should now be fixed by commit ee484b3140ee7637f297ed8ed4af86dd1e626416. Please give it a try and let me know if you have any problems/resolve the bug :) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33489 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |ee484b3140ee7637f297ed8ed4a | |f86dd1e626416 Status|NEW |RESOLVED URL|http://www.rarlabs.com/rar/ |http://www.filehippo.com/do |wrar50b1.exe |wnload_winrar_32/tech/14965 | |/ CC| |focht(a)gmx.net Resolution|--- |FIXED --- Comment #12 from Anastasius Focht <focht(a)gmx.net> --- Hello folks, this is indeed fixed by commit http://source.winehq.org/git/wine.git/commitdiff/ee484b3140ee7637f297ed8ed4a... The help displays correctly now. Thanks Erich. $ sha1sum wrar50b1.exe 9c7e833798c7540e7a4bb809ea25caebf10f9165 wrar50b1.exe $ du -sh wrar50b1.exe 1.7M wrar50b1.exe $ wine --version wine-1.7.13-118-g0eb6265 Regards -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33489 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #13 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 1.7.14. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33489 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- URL|http://www.filehippo.com/do |https://web.archive.org/web |wnload_winrar_32/tech/14965 |/20130620035602/http://www. |/ |rarlab.com/rar/wrar50b1.exe -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
wine-bugs＠winehq.org -
WineHQ Bugzilla