[Bug 28313] New: Steam client installer (MSI) crashes at the end of installation
http://bugs.winehq.org/show_bug.cgi?id=28313 Summary: Steam client installer (MSI) crashes at the end of installation Product: Wine Version: 1.3.27 Platform: x86 URL: http://cdn.steampowered.com/download/SteamInstall.msi OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: msi AssignedTo: wine-bugs(a)winehq.org ReportedBy: gyebro69(a)gmail.com CC: marcus(a)jet.franken.de Regression SHA1: ac0a7b644fa464fa640e06a6e26b2191b5a29a92 Created an attachment (id=36281) --> (http://bugs.winehq.org/attachment.cgi?id=36281) terminal output In wine-1.3.27-357-gac0a7b6 several, if not all MSI-based application installer crash (usually at the end of installation). The problem can be reproduced by downloading and installing the Steam client (it has a reasonable download size, 1.5 MB). This is due to the following commit: ac0a7b644fa464fa640e06a6e26b2191b5a29a92 is the first bad commit commit ac0a7b644fa464fa640e06a6e26b2191b5a29a92 Author: Marcus Meissner <meissner(a)suse.de> Date: Wed Sep 7 15:48:23 2011 +0200 msi: Check for return value of GetUserName (Coverity). :040000 040000 57680d5a0196f95c2079d6d9668be2acfec0af68 9db4b0c261fe0b19526e608b357f2700b086f436 M dlls Reverting the patch on wine-1.3.27-357-gac0a7b6 fixed the problem. Author of the patch added to CC. Fedora 15 x86 gcc version 4.6.0 20110603 (Red Hat 4.6.0-10) (GCC) -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=28313 --- Comment #1 from GyB <gyebro69(a)gmail.com> 2011-09-07 22:12:30 CDT --- Created an attachment (id=36282) --> (http://bugs.winehq.org/attachment.cgi?id=36282) 7zipped +tid,+msi,+msiexec log (uncompressed 1.7 MB) -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=28313 GyB <gyebro69(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, Installer, | |regression -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=28313 Marcus Meissner <marcus(a)jet.franken.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #2 from Marcus Meissner <marcus(a)jet.franken.de> 2011-09-08 00:53:03 CDT --- you are right, with size 0 GetUserName is supposed to return 0. I sent a reverted patch to wine-patches. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=28313 Dmitry Timoshkov <dmitry(a)baikal.ru> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |UNCONFIRMED Resolution|FIXED | --- Comment #3 from Dmitry Timoshkov <dmitry(a)baikal.ru> 2011-09-08 01:37:51 CDT --- Nothing is fixed yet. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=28313 Dan Kegel <dank(a)kegel.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dank(a)kegel.com --- Comment #4 from Dan Kegel <dank(a)kegel.com> 2011-09-08 03:14:03 CDT --- That might explain the odd test failure I saw today in 1 out of 100 runs: ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so install.c && touch install.ok ... err:msi:set_installer_properties Failed to set the UserSID property install.c:5389: Test failed: Directory not created ... -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=28313 Marcus Meissner <marcus(a)jet.franken.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #5 from Marcus Meissner <marcus(a)jet.franken.de> 2011-09-08 15:38:20 CDT --- git commit 6d1ec3517dfe6ee315bfda8bdccbfec00854738a -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=28313 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #6 from Alexandre Julliard <julliard(a)winehq.org> 2011-09-09 12:55:34 CDT --- Closing bugs fixed in 1.3.28. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=28313 Hans Leidekker <hans(a)meelstraat.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |6d1ec3517dfe6ee315bfda8bdcc | |bfec00854738a -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org