[Bug 47813] New: Itch.io: Warning or error when launching a game (GetFileInformationByHandleEx for FileAttributeTagInfo unimplemented)
https://bugs.winehq.org/show_bug.cgi?id=47813 Bug ID: 47813 Summary: Itch.io: Warning or error when launching a game (GetFileInformationByHandleEx for FileAttributeTagInfo unimplemented) Product: Wine Version: 4.16 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: ntdll Assignee: wine-bugs(a)winehq.org Reporter: theristhewolf(a)gmail.com Distribution: --- The Windows version of the Itch.io desktop app (which can be downloaded as itch-windows-amd64.zip from https://fasterthanlime.itch.io/itch ) generates a warning message such as the following when launching most titles: "An error occurred while launching [APP]. The message we got was: While doing auto prereqs: GetFileInformationByHandleEx [BINARY_LOCATION_IN_VIRTUAL_C_DRIVE]: Call not implemented." With these titles, the game can be launched normally by clicking the "Continue" button. However, with at least one Itch game (and, presumably, any Itch game that only works if launched via the Itch client), the error message instead reads as follows: "An error occurred while launching [APP]. GetFileInformationByHandleEx [BINARY_LOCATION_IN_VIRTUAL_C_DRIVE]: Call not implemented." In this case, there is no "Continue" button to click (the bottom right corner of the window instead has an "OK" button, which dismisses the message and proceeds to a Itch bug submission window if a checkbox is enabled, as well as an "Open folder in explorer" button). This issue was originally reported as a bug for the Itch desktop client (see https://github.com/itchio/itch/issues/2324 ), and a developer for that project has stated that the described behavior occurs due to Wine's partial implementation of the GetFileInformationByHandleEx function (specifically, for the case when the class passed into the function is FileAttributeTagInfo). Since this is the function call that Go generates when compiling an os.Stat function call performed on a file returned by os.Open, the responding Itch developer expressed a preference for the missing functionality in Wine to be implemented due to this issue's potential impact on other Windows applications that were written in Go. To that end, said developer has generated a short Go code snippet (viewable at https://gist.github.com/fasterthanlime/ec8177b114fa9f711d90b95b49a0e236 ) that tests the os.Stat and os.Open functions. This issue has been originally produced in Lutris's variant of Wine version 4.12.1-x86_64. I have attempted to reproduce the issue on a system-wide install of Wine 4.16 (as installed on Linux Mint 19.1 via the winehq-devel package), but I have not been able to get the Itch client's window to display anything other than a blank black box when running Itch this way (presumably, there's either a mistake that I've been overlooking, a setup step that Lutris does that I'm missing, a workaround that Lutris does that I'm not aware of, or a bugfix in Lutris's flavor of Wine that isn't mainlined). I'm hoping, due to the specificity of the bug's identification and the verification of the fact that GetFileInformationByHandle remains a stub in the main Wine project's master branch, that the lack of reproduction in the development version of vanilla Wine will be tolerated for this report. If not, I can continue trying to flail at my efforts to reproduce the bug without the use of Lutris. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47813 theristhewolf(a)gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |theristhewolf(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47813 Zebediah Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://fasterthanlime.itch | |.io/itch CC| |z.figura12(a)gmail.com Ever confirmed|0 |1 Keywords| |download Status|UNCONFIRMED |NEW --- Comment #1 from Zebediah Figura <z.figura12(a)gmail.com> --- Thanks for the detailed report. (In reply to theristhewolf from comment #0)
This issue has been originally produced in Lutris's variant of Wine version 4.12.1-x86_64. I have attempted to reproduce the issue on a system-wide install of Wine 4.16 (as installed on Linux Mint 19.1 via the winehq-devel package), but I have not been able to get the Itch client's window to display anything other than a blank black box when running Itch this way (presumably, there's either a mistake that I've been overlooking, a setup step that Lutris does that I'm missing, a workaround that Lutris does that I'm not aware of, or a bugfix in Lutris's flavor of Wine that isn't mainlined).
Confirming this part at least; it works for me after `winetricks -q corefonts`. I've sent patches for the reported problem, <https://source.winehq.org/patches/data/170484> and <https://source.winehq.org/patches/data/170485>. However, that's still not enough to get it to work for me. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47813 Louis Lenders <xerox.xerox2000x(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xerox.xerox2000x(a)gmail.com --- Comment #2 from Louis Lenders <xerox.xerox2000x(a)gmail.com> --- (In reply to Zebediah Figura from comment #1)
I've sent patches for the reported problem, <https://source.winehq.org/patches/data/170484> and <https://source.winehq.org/patches/data/170485>. However, that's still not enough to get it to work for me.
I gave it a quick test and for me the error-message is gone, and i started a game (Run Kenney) and that played for me (bit trouble with input/focus but that is other issue) @Reporter of bug, could you try too and report back please? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47813 Vijay Kamuju <infyquest(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |1669956966fd1af9e8195576089 | |ef9af3368be72 Status|NEW |RESOLVED CC| |infyquest(a)gmail.com Resolution|--- |FIXED --- Comment #3 from Vijay Kamuju <infyquest(a)gmail.com> --- Fixed in Wine 4.17, the patches committed -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47813 --- Comment #4 from theristhewolf(a)gmail.com --- Sorry for the slow response; I've been busy the past few days. I can confirm that using winetricks as described earlier in the discussion fixes the issue I was facing in trying to reproduce the described bug in a vanilla version of wine. I can also confirm that the bug desçribed in the opening post is not present in winehq-devel 4.17; games now successfully launch from the Itch client without producing a warning or an error. Thanks for the patch and the prompt fix. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47813 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #5 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 4.18. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla