[Bug 33051] New: Ctrl+]/[ does not work in gvim
http://bugs.winehq.org/show_bug.cgi?id=33051 Bug #: 33051 Summary: Ctrl+]/[ does not work in gvim Product: Wine Version: 1.5.24 Platform: x86-64 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: winex11.drv AssignedTo: wine-bugs(a)winehq.org ReportedBy: chenjh_06(a)hotmail.com Classification: Unclassified Ctrl+[ should be ESC in gvim and Ctrl+] should jump to the definition of the keyword under the cursor. But they are not working correctly in Wine. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33051 --- Comment #1 from Jinhui Chen <chenjh_06(a)hotmail.com> 2013-02-24 00:35:10 CST --- Created attachment 43691 --> http://bugs.winehq.org/attachment.cgi?id=43691 make Ctrl+]/[ work The two keys is block by X11DRV_ToUnicodeEx. This patch make them work correctly. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33051 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch --- Comment #2 from Austin English <austinenglish(a)gmail.com> 2013-02-24 14:29:13 CST --- Please send the patch to wine-patches(a)winehq.org -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33051 --- Comment #3 from Jinhui Chen <chenjh_06(a)hotmail.com> 2013-02-25 07:45:13 CST --- OK. Patch is sent: http://www.winehq.org/pipermail/wine-patches/2013-February/122430.html -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33051 Jinhui Chen <chenjh_06(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|1.5.24 |1.7.4 --- Comment #4 from Jinhui Chen <chenjh_06(a)hotmail.com> 2013-10-24 04:31:39 CDT --- Still issue in Wine 1.7.4 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33051 Qian Hong <fracting(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fracting(a)gmail.com -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33051 Qian Hong <fracting(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #5 from Qian Hong <fracting(a)gmail.com> 2013-10-27 14:50:17 CDT --- Confirming the bug, but the patch doesn't looks correct or good enough to me. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33051 --- Comment #6 from Jinhui Chen <chenjh_06(a)hotmail.com> 2013-10-28 02:16:40 CDT --- What's the problem then? It works quite well for me. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33051 --- Comment #7 from Qian Hong <fracting(a)gmail.com> 2013-10-28 04:06:28 CDT --- (In reply to comment #6)
What's the problem then? It works quite well for me.
Works well for something is the easy part, the hard part is to clearly understand the original code and make sure not to break anything :) I would suggest to add some test case in dlls/user32/tests/input.c:1541:test_ToUnicode() ,to approve your change is correct. It would be great to also test for some other case such as Ctrl+\, Ctrl+^, Ctrl+_ and Ctrl+`, which satisfy the expression "(keysym > 'Z') && (keysym < 'a')", then we can get an idea if they works the same as Ctrl+]/[. If they works the same, we could have a more general patch. The more tests the better. You can cross compile the test case and run on a Windows machine. If you don't have Windows you can submit either the patch or the compiled binary to our Wine testbot, see http://wiki.winehq.org/WineTestBot and http://wiki.winehq.org/CompilingDLLsUsingMingw If you have trouble getting a testbot account please let me know. Thanks for the work. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33051 Qian Hong <fracting(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|1.7.4 |1.5.24 --- Comment #8 from Qian Hong <fracting(a)gmail.com> 2013-10-28 04:08:45 CDT --- Please don't change the 'Version' field, see http://wiki.winehq.org/Bugs#head-7d25a6ac5869da856040cf9ef7e302f34295158a Thanks! -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33051 --- Comment #9 from Jinhui Chen <chenjh_06(a)hotmail.com> 2013-10-29 06:19:27 CDT --- (In reply to comment #7)
(In reply to comment #6)
What's the problem then? It works quite well for me.
Works well for something is the easy part, the hard part is to clearly understand the original code and make sure not to break anything :)
I would suggest to add some test case in dlls/user32/tests/input.c:1541:test_ToUnicode() ,to approve your change is correct. It would be great to also test for some other case such as Ctrl+\, Ctrl+^, Ctrl+_ and Ctrl+`, which satisfy the expression "(keysym > 'Z') && (keysym < 'a')", then we can get an idea if they works the same as Ctrl+]/[. If they works the same, we could have a more general patch. The more tests the better.
You can cross compile the test case and run on a Windows machine. If you don't have Windows you can submit either the patch or the compiled binary to our Wine testbot, see http://wiki.winehq.org/WineTestBot and http://wiki.winehq.org/CompilingDLLsUsingMingw
If you have trouble getting a testbot account please let me know.
Thanks for the work.
Hi Qian Hong, I am sorry but I have no idea of what to test or how to do the tests. Can you give me some test case or would you please do the test yourself? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33051 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download URL| |http://www.vim.org/download | |.php#pc --- Comment #10 from Austin English <austinenglish(a)gmail.com> --- Is this still an issue in 1.7.36? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org