[Bug 22813] New: wine's loader does not check invalid image size
http://bugs.winehq.org/show_bug.cgi?id=22813 Summary: wine's loader does not check invalid image size Product: Wine Version: 1.1.44 Platform: x86 URL: http://ghostscript.com/~hintak/wine-debug/ OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: loader AssignedTo: wine-bugs(a)winehq.org ReportedBy: htl10(a)users.sourceforge.net +++ This bug was initially created as a clone of Bug #22812 +++ (#22812 against the compilation - this bug is about the loader not complaining) part of ghostscript's building process runs: mt -nologo -manifest psi/dwsetup_x86.manifest -outputresource:setupgs.exe;#1 mt -nologo -manifest psi/dwuninst_x86.manifest -outputresource:uninstgs.exe;#1 This step corrupts executables under wine and they gain a wrong image size; both vista and win7 then complains they are not valid win32 applications. See discussion on wine-devel mailing list. But wine would happily load them, so wine is not checking for validity. Here are two such broken executables: http://ghostscript.com/~hintak/wine-debug/setupgs-wine.exe http://ghostscript.com/~hintak/wine-debug/uninstgs-wine.exe -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22813 Dmitry Timoshkov <dmitry(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|loader |-unknown --- Comment #1 from Dmitry Timoshkov <dmitry(a)codeweavers.com> 2010-05-22 03:42:41 --- Do XP and win2000 also not accept that PE image? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22813 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22813 --- Comment #2 from Hin-Tak Leung <htl10(a)users.sourceforge.net> 2010-05-22 03:54:15 --- (In reply to comment #1)
Do XP and win2000 also not accept that PE image?
I don't have those systems to check - but both of them looks for some extra input files or arguments, so running on their own (if they are valid) would give a pop-up msg box saying missing args, etc, instead of '... is not a valid win32 application'. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22813 --- Comment #3 from Hin-Tak Leung <htl10(a)users.sourceforge.net> 2010-05-24 15:04:30 --- Created an attachment (id=28252) --> (http://bugs.winehq.org/attachment.cgi?id=28252) loaddll log result of: cp -p bin/setupgs.exe.bak bin/setupgsbak.exe WINEDEBUG=+tid,+process,+loaddll '/home/Hin-Tak/.wine/drive_c/Program Files/Microsoft SDKs/Windows/v7.0/Bin/mt.exe' -nologo -manifest psi/dwsetup_x86.manifest '-outputresource:bin/setupgsbak.exe;#1' >& wine-loaddll.log I had 'winetrick vrun6' after the wine-devel discussion, so it is using native msvcrt currently. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22813 --- Comment #4 from Saulius K. <saulius2(a)gmail.com> 2010-05-31 10:39:56 --- In reply to comment #1:
Do XP and win2000 also not accept that PE image?
Well, XP Home Ed. (SP2) says it "is not a valid Win32 application". -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22813 --- Comment #5 from Saulius K. <saulius2(a)gmail.com> 2010-05-31 11:44:58 --- Created an attachment (id=28454) --> (http://bugs.winehq.org/attachment.cgi?id=28454) list of loaded DLLs In reply to comment #3:
I had 'winetrick vrun6' after the wine-devel discussion, so it is using native msvcrt currently.
Hin-Tak, my idea was to override as many DLLs to native, as possible. And seeing how does it help. I've attached list of all dlls loaded during your test. For me, the most suspiciously looking builtin dll here is Imagehlp.dll (which I already have mentioned at the start of discussion on Wine-devel@). "winetricks" doesn't handle it yet (but can be easily modified to do so from the verb "riched30"). In a while you could just download the binary [3] and use "cabextract" to get the DLL (to do your test). Plus don't forget to override "imagehlp" to "n" manually :) [3]http://download.microsoft.com/download/WindowsInstaller/Install/2.0/W9XMe/EN... -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22813 --- Comment #6 from Hin-Tak Leung <htl10(a)users.sourceforge.net> 2010-05-31 19:22:21 --- (In reply to comment #5)
Plus don't forget to override "imagehlp" to "n" manually :)
Thanks for the tips - I have tried imagehlp=n (http://bugs.winehq.org/show_bug.cgi?id=22812#c10) . am going to try the other dependencies - one day. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22813 Saulius K. <saulius2(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |saulius2(a)gmail.com --- Comment #7 from Saulius K. <saulius2(a)gmail.com> 2010-06-01 13:37:17 --- Oh, I am sorry for choosing slightly wrong report. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22813 Bruno Jesus <00cpxxx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|download | CC| |00cpxxx(a)gmail.com --- Comment #8 from Bruno Jesus <00cpxxx(a)gmail.com> 2012-07-18 19:48:36 CDT --- Is this still an issue in wine 1.5.9? Can anyone provide new links for the bad exe files? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22813 --- Comment #9 from Saulius K. <saulius2(a)gmail.com> 2012-07-18 23:50:50 CDT --- I have only first of these two. Here it is: http://193.219.43.130/~winetester/bin/win32/hintak_wine-debug/setupgs-wine.e... -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22813 Bruno Jesus <00cpxxx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #10 from Bruno Jesus <00cpxxx(a)gmail.com> 2012-07-19 00:12:37 CDT --- (In reply to comment #9)
I have only first of these two. Here it is: http://193.219.43.130/~winetester/bin/win32/hintak_wine-debug/setupgs-wine.e...
Thanks. Win98, NT4 and XP says the exe is invalid while wine 1.5.9 runs it. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22813 --- Comment #11 from Hin-Tak Leung <htl10(a)users.sourceforge.net> 2012-07-20 21:41:47 CDT --- Created attachment 41083 --> http://bugs.winehq.org/attachment.cgi?id=41083 tar ball of what was in the /wine-debug/ directory (In reply to comment #8)
Is this still an issue in wine 1.5.9? Can anyone provide new links for the bad exe files?
tgz file of the whole /wine-debug/ directory, including those bad exe files. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22813 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |austinenglish(a)gmail.com -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=22813 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download --- Comment #12 from Austin English <austinenglish(a)gmail.com> --- (In reply to Bruno Jesus from comment #10)
(In reply to comment #9)
I have only first of these two. Here it is: http://193.219.43.130/~winetester/bin/win32/hintak_wine-debug/setupgs-wine.e...
Thanks. Win98, NT4 and XP says the exe is invalid while wine 1.5.9 runs it.
Wine runs it in 1.7.25 as well. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=22813 --- Comment #13 from Hin-Tak Leung <htl10(a)users.sourceforge.net> --- (In reply to Austin English from comment #12)
(In reply to Bruno Jesus from comment #10)
(In reply to comment #9)
I have only first of these two. Here it is: http://193.219.43.130/~winetester/bin/win32/hintak_wine-debug/setupgs-wine.e...
Thanks. Win98, NT4 and XP says the exe is invalid while wine 1.5.9 runs it.
Wine runs it in 1.7.25 as well.
just a reminder that the two exes were in the attachment as in comment 11. Created attachment 41083 [details] tar ball of what was in the /wine-debug/ directory Hope this helps. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org