[Bug 48090] New: Add support for .com programs
https://bugs.winehq.org/show_bug.cgi?id=48090 Bug ID: 48090 Summary: Add support for .com programs Product: Wine-Testbot Version: unspecified Hardware: x86 OS: Linux Status: NEW Severity: normal Priority: P2 Component: unknown Assignee: wine-bugs(a)winehq.org Reporter: fgouget(a)codeweavers.com Distribution: --- The TestBot assumes that if a patch touches a directory in programs, then it must append .exe to the program's name. But Wine could also get .com programs, see for instance chcp.com: https://www.winehq.org/pipermail/wine-devel/2019-November/154371.html And in fact we already have other programs with non-standard extensions, for instance winhelp.exe16 and winoldap.mod16. So if the program's directory already has an extension the TestBot should not add one. Another option would be to use the MODULE setting in the directory's Makefile.in file. But the TestBot server does not have access to the Wine source. It would also make it harder to deal with patches adding test directories and it would be quite ugly to have to read them every time anyway. It would make it harder to deal with patches adding dlls/programs as it would require parsing the patch to retrieve the MODULE value. Another option may be to never add an extension, though then there's the risk of getting collisions between the dll and program names, and maybe it impacts other parts of the TestBot anyway. _CreateTestInfo() in testbot/lib/WineTestBot/PatchUtils.pm needs to be patched but there are impacts elsewhere. The WTBS (Wine TestBot test Suite) will also need to be updated. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48090 --- Comment #1 from François Gouget <fgouget(a)codeweavers.com> --- I added a test for this to the WTBS (Wine TestBot test Suite): https://github.com/fgouget/wine/commits/wtbsuite -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48090 François Gouget <fgouget(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from François Gouget <fgouget(a)codeweavers.com> --- This is fixed: commit deed0b3912a23a72cbd6379870c2f02a6153f39b Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Fri Jan 8 02:57:04 2021 +0100 testbot/PatchUtils: Add support for .com program tests. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=48090 Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> commit 42543d50a3c1ba313c781e0c1959df6ae93f5c96 Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Tue Feb 2 15:17:23 2021 +0100 testbot/PatchUtils: Add support for .com program tests in _LoadWineFiles(). _LoadWineFiles() must use the correct module name so that the lookups succeed in _CreateTestInfo(). Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=48090 Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> A regression test will also be added to ReportTest soon. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48090 François Gouget <fgouget(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #3 from François Gouget <fgouget(a)codeweavers.com> --- ReportTest has been updated with the .com test: commit c7dd6b544792852396b5d6afd7f840cf077ea4d7 Author: Francois Gouget <fgouget(a)codeweavers.com> AuthorDate: Fri Feb 19 01:43:05 2021 +0100 testbot/reporttest: Add more tests from the wtbsuite. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> Closing. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla