[Bug 52610] New: Memory corruption in PE build, when using FIXME in krnl386.exe __wine_vxd_open() function
https://bugs.winehq.org/show_bug.cgi?id=52610 Bug ID: 52610 Summary: Memory corruption in PE build, when using FIXME in krnl386.exe __wine_vxd_open() function Product: Wine Version: 7.3 Hardware: x86-64 OS: FreeBSD Status: NEW Severity: normal Priority: P2 Component: build-env Assignee: wine-bugs(a)winehq.org Reporter: damjan.jov(a)gmail.com In the PE build (only), calling FIXME("anything\n") in the krnl386.exe __wine_vxd_open() function causes the contents of the filename parameter to get overwritten with "l.dll". This is a recent regression, bisected to: 6ebcc54a5c2c4b5724571f37ab41e99ee9e49acb is the first bad commit commit 6ebcc54a5c2c4b5724571f37ab41e99ee9e49acb Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Nov 11 11:38:31 2021 +0100 makefiles: Explicitly import all the needed libraries. Don't rely on winegcc adding any default libraries. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> dlls/krnl386.exe16/Makefile.in | 3 +- tools/makedep.c | 162 +++++++++++++++++++++-------------------- tools/winegcc/winegcc.c | 4 - 3 files changed, 85 insertions(+), 84 deletions(-) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52610 Damjan Jovanovic <damjan.jov(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |6ebcc54a5c2c4b5724571f37ab4 | |1e99ee9e49acb Keywords| |regression CC| |julliard(a)winehq.org --- Comment #1 from Damjan Jovanovic <damjan.jov(a)gmail.com> --- Adding author to CC. The calling app does: hCVxD = CreateFileA(argv[1], 0,0,0, CREATE_NEW, FILE_FLAG_DELETE_ON_CLOSE, 0); Possibly because CreateFileA() calls file_name_AtoW() with alloc==FALSE, which uses NtCurrentTeb()->StaticUnicodeString, which FIXME() might use too? But then why is the ELF build unaffected? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52610 --- Comment #2 from Alexandre Julliard <julliard(a)winehq.org> --- This may be fixed by 7c6f6d27756687c3e2a3b8ca743f886e694142a2. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52610 Damjan Jovanovic <damjan.jov(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED Fixed by SHA1| |7c6f6d27756687c3e2a3b8ca743 | |f886e694142a2 --- Comment #3 from Damjan Jovanovic <damjan.jov(a)gmail.com> --- Yes it was fixed by 7c6f6d27756687c3e2a3b8ca743f886e694142a2, and first released in Wine 7.8. Thank you :). Resolving fixed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52610 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #4 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 7.15. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla