[Bug 43368] New: HashMyFiles: Drag & Drop from native File Managers ( Dolphin, Nautilus, ...) does not work
https://bugs.winehq.org/show_bug.cgi?id=43368 Bug ID: 43368 Summary: HashMyFiles: Drag & Drop from native File Managers (Dolphin, Nautilus, ...) does not work Product: Wine Version: 2.12 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: winex11.drv Assignee: wine-bugs(a)winehq.org Reporter: bob.mt.wya(a)gmail.com Distribution: --- Created attachment 58732 --> https://bugs.winehq.org/attachment.cgi?id=58732 wine_hashmyfiles_console_log HashMyFiles generates hashes of file handles dropped into the main Window. Currently Wine only supports copy and paste of files - from a native File Manager - into the main HashMyFiles Window. Attempting to drag-n-drop files from a native File Manager into the HashMyFiles Window - has no affect. See attached console log. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43368 Robert Walker <bob.mt.wya(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |http://www.nirsoft.net/util | |s/hash_my_files.html -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43368 --- Comment #1 from Robert Walker <bob.mt.wya(a)gmail.com> --- Created attachment 58733 --> https://bugs.winehq.org/attachment.cgi?id=58733 wine-allow_dnd_with_any_object.patch Simple (hacky) patch - that illustrates that the Wine xdnd needs support for more than the "content aspect" - to better support HashMyFiles. With this patch the HashMyFiles application supports drag-n-drop of files from native Linux File Managers. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43368 Damjan Jovanovic <damjan.jov(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |damjan.jov(a)gmail.com Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #2 from Damjan Jovanovic <damjan.jov(a)gmail.com> --- Confirming. Still happens in Wine 5.0-rc2. With WINEDEBUG='+xdnd': 0009:trace:xdnd:XDNDDATAOBJECT_GetData (0x63f46958, 0x31b4f8, 0x31b50c) 0009:trace:xdnd:XDNDDATAOBJECT_GetData application is looking for CF_HDROP 0009:trace:xdnd:XDNDDATAOBJECT_QueryGetData (0x63f46958, 0x31b4f8={.tymed=0x1, .dwAspect=0, .cfFormat=15} 0009:fixme:xdnd:XDNDDATAOBJECT_QueryGetData only the content aspect is supported right now .dwAspect=0 is invalid, the valid values start from 1: include/wtypes.idl: DVASPECT_CONTENT = 1, include/wtypes.idl: DVASPECT_THUMBNAIL = 2, include/wtypes.idl: DVASPECT_ICON = 4, include/wtypes.idl: DVASPECT_DOCPRINT = 8 It is surprising that Windows allows this. I wonder how it's implemented. Is 0 always taken to mean DVASPECT_CONTENT? Does it depend on the clipboard format, eg. does only CF_HDROP ignore .dwAspect, or do others? The drop still succeeds despite GetData() failing, but with no file, which is potentially dangerous, as if the operation was "Move" instead of "Copy", the file manager could delete the file: 0009:trace:xdnd:X11DRV_XDND_DropEvent drop succeeded 0009:trace:xdnd:X11DRV_XDND_DropEvent effectRequested(0x1) accept(1) performed(0x1) at x(815),y(417) 0009:trace:xdnd:X11DRV_XDND_FreeDragDropOp -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43368 Damjan Jovanovic <damjan.jov(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Fixed by SHA1| |523fb9496c7758be9626d3d5b6a | |07014f867f640 Status|NEW |RESOLVED --- Comment #3 from Damjan Jovanovic <damjan.jov(a)gmail.com> --- We now no longer check FORMATETC.dwAspect for drag and drop from XDND. Resolving fixed. Thank you for your bug report! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43368 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #4 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 5.0-rc3. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43368 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |4.0.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43368 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|4.0.x |--- --- Comment #5 from Michael Stefaniuc <mstefani(a)winehq.org> --- Removing the 4.0.x milestone from bug fixes included in 4.0.4. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
wine-bugs＠winehq.org -
WineHQ Bugzilla