[Bug 44147] New: regression in ole2 datacache
https://bugs.winehq.org/show_bug.cgi?id=44147 Bug ID: 44147 Summary: regression in ole2 datacache Product: Wine Version: 3.0-rc1 Hardware: x86 OS: Linux Status: NEW Severity: normal Priority: P2 Component: ole32 Assignee: wine-bugs(a)winehq.org Reporter: marcus(a)jet.franken.de Distribution: --- there is a new testcase crash in ole2 datacache test. http://test.winehq.org/data/5a7ce7ccb1f9e5c958ba1b7e6dfdaa0cd697f9b1/linux_m... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44147 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44147 --- Comment #1 from Marcus Meissner <marcus(a)jet.franken.de> --- i bisected only dlls/ole32: 51c8fa65740ce9b3c041493fba052500d0f82e7d is the first bad commit commit 51c8fa65740ce9b3c041493fba052500d0f82e7d Author: Sergio Gómez Del Real <sergio.g.delreal(a)gmail.com> Date: Tue Nov 28 13:01:06 2017 -0500 ole32: Add DIB saving in data cache, and relevant tests. Signed-off-by: Sergio Gómez Del Real <sdelreal(a)codeweavers.com> Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> :040000 040000 4c5b27902e0a3f5e55541993c7ebc329a414bc97 a7a346ee17ff6bb2f59a1a2d1ca7824e3c6f9536 M dlls -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44147 Marcus Meissner <marcus(a)jet.franken.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |51c8fa65740ce9b3c041493fba0 | |52500d0f82e7d -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44147 Sergio Gómez Del Real <sdelreal(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sdelreal(a)codeweavers.com --- Comment #2 from Sergio Gómez Del Real <sdelreal(a)codeweavers.com> --- Hi. So the error is in calling GlobalSize with an invalid handle. According to MSDN: "If the specified handle is not valid or if the object has been discarded, the return value is zero. To get extended error information, call GetLastError." I relied on this specification to use the function unconditionally. I could just wrap the call with the result of GlobalLock, which returns NULL in case of invalid handle, but I'm not sure if we should instead look into GlobalSize and see why 0 is not being returned in case of invalid handle. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44147 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, source, testcase -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44147 Gijs Vermeulen <gijsvrm(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gijsvrm(a)gmail.com --- Comment #3 from Gijs Vermeulen <gijsvrm(a)gmail.com> --- Should be fixed with: https://source.winehq.org/git/wine.git/commit/179daf67a82945ee41f45f24d4bbf8... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44147 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Fixed by SHA1| |179daf67a82945ee41f45f24d4b | |bf8f31fc2d7d1 Resolution|--- |FIXED --- Comment #4 from Alexandre Julliard <julliard(a)winehq.org> --- Fixed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44147 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #5 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 3.0-rc2. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org