[Bug 6801] gpstrack help windows are empty

http://bugs.winehq.org/show_bug.cgi?id=6801





--- Comment #15 from Tefnet developers <developers(a)tefnet.pl>  2008-04-08 08:29:15 ---
(In reply to comment #14)
> (In reply to comment #11)
> > Created an attachment (id=11905)
> >  --> (http://bugs.winehq.org/attachment.cgi?id=11905) [details] [details]
> > htmlhelp trace with 0.9.59
> >
> > Proper file
>
> Your trace said wine has crashed in the middle of trying to read the Chm file!

No, it look like it's while reading chm file because trace is only for
htmlhelp.. 

The app crashes during help window creation (adding toolbar icons... to be
specific)

In function HH_AddToolbar in file (dlls/hhctrl.ocx/help.c) in line 578:

        szBuf[dwLen + 2] = 0; /* Double-null terminate */

i think it's outside allocated memory because memory is allocated for size of
an icon caption + 2 extra for null terminators and:

szBuf[dwLen - 1] is last character of toolbar icon caption

szBuf[dwLen] is first null terminate

so second null terminate should be szBuf[dwLen+1], not szBuf[dwLen + 2]

I found out that it only occurs with Polish locale turned on, so if you want to
replicate my environment you have to change LC_ALL and LANG to pl_PL.utf8 or
copy
dlls/hhctrl.ocx/Pl.rc to dlls/hhctrl.ocx/En.rc


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.