[Bug 39764] New: An attempt to do automatic authentication unexpectedly drops the payload from server response
https://bugs.winehq.org/show_bug.cgi?id=39764 Bug ID: 39764 Summary: An attempt to do automatic authentication unexpectedly drops the payload from server response Product: Wine Version: 1.8-rc3 Hardware: x86-64 OS: Linux Status: NEW Keywords: download, regression, source, testcase Severity: normal Priority: P2 Component: winhttp Assignee: wine-bugs(a)winehq.org Reporter: dmitry(a)baikal.ru CC: hans(a)meelstraat.net Regression SHA1: 1eb86e1fca71f634b54bf105703c1247d87b39ee Distribution: --- I have an application that fails to gracefully handle a failed connection to the server and provide a meaningful explanation. This turned out to be a regression: 1eb86e1fca71f634b54bf105703c1247d87b39ee is the first bad commit commit 1eb86e1fca71f634b54bf105703c1247d87b39ee Author: Hans Leidekker <hans(a)codeweavers.com> Date: Tue Dec 9 12:45:46 2014 +0100 winhttp: Enable automatic authentication by default in the request object. :040000 040000 d1dd9fe95bdf0f575eb6ed85767eec41ce80593d 9df16820020c8da18fedcd7869b29aff2fe0ba36 M dlls The above commit can be cleanly reverted (it's just 1 line changed), and after the revert the application works again, and behaves exactly like it does under Windows: it outputs the server response. A test case that reproduces the problem was sent to wine-patches. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39764 --- Comment #1 from Hans Leidekker <hans(a)meelstraat.net> --- (In reply to Dmitry Timoshkov from comment #0)
A test case that reproduces the problem was sent to wine-patches.
Do you mean http://source.winehq.org/patches/data/117171 ? Reverting this commit doesn't fix the todo tests in that patch. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39764 --- Comment #2 from Dmitry Timoshkov <dmitry(a)baikal.ru> --- (In reply to Hans Leidekker from comment #1)
A test case that reproduces the problem was sent to wine-patches.
Do you mean http://source.winehq.org/patches/data/117171 ? Reverting this commit doesn't fix the todo tests in that patch.
Looks like the test didn't really replicate what the application is doing, but reverting that commit does fix the application that I have here. The application uses the IWinHttpRequest::get_ResponseText() to get the server response, I'll add another test. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39764 --- Comment #3 from Dmitry Timoshkov <dmitry(a)baikal.ru> --- I've added another test that replicates what an application does, and reproduces the regression: http://source.winehq.org/patches/data/117223 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39764 --- Comment #4 from Hans Leidekker <hans(a)meelstraat.net> --- Created attachment 53057 --> https://bugs.winehq.org/attachment.cgi?id=53057 patch This patch fixes the tests you added. I added another test with valid username and password which returns status 200 on Windows. This means that the commit reported here is not a regression (automatic authentication is enabled by default), it just uncovers a different bug. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39764 --- Comment #5 from Dmitry Timoshkov <dmitry(a)baikal.ru> --- (In reply to Hans Leidekker from comment #4)
Created attachment 53057 [details] patch
This patch fixes the tests you added.
Thanks, the patch fixes the application as well.
I added another test with valid username and password which returns status 200 on Windows. This means that the commit reported here is not a regression (automatic authentication is enabled by default), it just uncovers a different bug.
Well, if something worked before and is broken after a specific commit that's a regression IMO. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39764 Dmitry Timoshkov <dmitry(a)baikal.ru> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |d3f7519035966dc07d71599262f | |27e2775411fe4 Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #6 from Dmitry Timoshkov <dmitry(a)baikal.ru> --- (In reply to Hans Leidekker from comment #4)
Created attachment 53057 [details] patch
This patch fixes the tests you added.
The patch was committed, thanks Hans.
I added another test with valid username and password which returns status 200 on Windows.
Are you planning to send the test for inclusion? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39764 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #7 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 1.9.0. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org