[Bug 27663] New: 32bit gcc fails to compile WINE
http://bugs.winehq.org/show_bug.cgi?id=27663 Summary: 32bit gcc fails to compile WINE Product: Wine Version: unspecified Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs(a)winehq.org ReportedBy: vincas.miliunas(a)gmail.com Created an attachment (id=35379) --> (http://bugs.winehq.org/attachment.cgi?id=35379) A test-case that fails to compile As discovered by Wylda and posted on wine-devel mailing list, 32bit gcc fails to compile a certain include statement sequence I used for my raw input patch. Message confirming test-case failure - http://www.winehq.org/pipermail/wine-devel/2011-June/090886.html I fixed it by applying the following modification: -#include <stdlib.h> +#include "config.h" +#include "wine/port.h" + +#include <assert.h> +#include <stdarg.h> #include <stdio.h> #include "ntstatus.h" #define WIN32_NO_STATUS #include "windef.h" -#include "winnt.h" -#include "winternl.h" #include "winbase.h" #include "winuser.h" +#include "winternl.h" Looks like including "winternl.h" before "winbase.h" and "winuser.h" is implicitly incorrect. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27663 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, source CC| |austinenglish(a)gmail.com -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27663 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID --- Comment #1 from Alexandre Julliard <julliard(a)winehq.org> 2011-07-01 07:34:45 CDT --- You need stdarg.h before Windows headers. Your code is broken. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27663 Wylda <wylda(a)volny.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wylda(a)volny.cz --- Comment #2 from Wylda <wylda(a)volny.cz> 2011-07-01 07:51:22 CDT ---
You need stdarg.h before Windows headers. Your code is broken.
Interesting, that 64bit gcc does not have such problem. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27663 --- Comment #3 from Vincas Miliūnas <vincas.miliunas(a)gmail.com> 2011-07-01 08:10:34 CDT --- (In reply to comment #1)
You need stdarg.h before Windows headers. Your code is broken.
My goal was to remove unused include statements for compiling (using 64bit gcc), I was not aware that stdarg.h was an implicit dependency for windows include files on 32bit gcc. The recent submitted version has this fixed. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27663 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #4 from Austin English <austinenglish(a)gmail.com> 2011-07-07 16:16:14 CDT --- Closing. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org