[Bug 12680] New: jack driver produces buffer underruns (regression)

http://bugs.winehq.org/show_bug.cgi?id=12680

           Summary: jack driver produces buffer underruns (regression)
           Product: Wine
           Version: 0.9.59.
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: critical
          Priority: P2
         Component: -unknown
        AssignedTo: wine-bugs(a)winehq.org
        ReportedBy: webmaster(a)tonstube.de


This is a regression introduced by the patch for winejack.drv by Andrew Talbot.
After this patch, wine produces buffer underruns with the following error
output:
err:wave:JACK_callback_wwo buffer underrun of 1024 frames
(where '1024' my differ from system to system depending on the jack
configuration).

When winejack.drv is substituted by the one from 0.9.58 everything is fine.

To reproduce, just use the jack driver in winecfg.


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.

[Bug 12680] jack driver produces buffer underruns (regression)

http://bugs.winehq.org/show_bug.cgi?id=12680


Matthias Derer <webmaster(a)tonstube.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|critical                    |normal




-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.

[Bug 12680] jack driver produces buffer underruns (regression)

http://bugs.winehq.org/show_bug.cgi?id=12680





--- Comment #1 from Matthias Derer <webmaster(a)tonstube.de>  2008-04-21 15:37:16 ---
Created an attachment (id=12373)
 --> (http://bugs.winehq.org/attachment.cgi?id=12373)
Proposed patch

(re-)added line, which obviously has been accidently deleted, when switching
from memcpy to structs in 0.9.59


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.

[Bug 12680] jack driver produces buffer underruns (regression)

http://bugs.winehq.org/show_bug.cgi?id=12680





--- Comment #2 from Matthias Derer <webmaster(a)tonstube.de>  2008-04-21 15:38:28 ---
(From update of attachment 12373)
In version 0.9.59, a patch by Andrew Talbot introduced the use of structs
instead of memcpy.
In the patch for dlls/winejack.drv/audio.c he obviously deleted a line which
shouldn't have been deleted
resulting in buffer underruns when using the jack driver in wine.
I just "undeleted" the line (assigning wFlags to the output).


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.

[Bug 12680] jack driver produces buffer underruns (regression)

http://bugs.winehq.org/show_bug.cgi?id=12680


Lei Zhang <thestig(a)google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
           Keywords|                            |patch




--- Comment #3 from Lei Zhang <thestig(a)google.com>  2008-04-21 23:10:05 ---
Please send the patch to the wine-patches mailing list.


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.

[Bug 12680] jack driver produces buffer underruns (regression)

http://bugs.winehq.org/show_bug.cgi?id=12680





--- Comment #4 from Matthias Derer <webmaster(a)tonstube.de>  2008-04-23 05:10:55 ---
I have sent the patch to the mailing list.


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.

[Bug 12680] jack driver produces buffer underruns (regression)

http://bugs.winehq.org/show_bug.cgi?id=12680


Matthias Derer <webmaster(a)tonstube.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #5 from Matthias Derer <webmaster(a)tonstube.de>  2008-05-03 16:40:27 ---
The patch has been applied and is available in wine 0.9.61.
Fixed.


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.

[Bug 12680] jack driver produces buffer underruns (regression)

http://bugs.winehq.org/show_bug.cgi?id=12680


Alexandre Julliard <julliard(a)winehq.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED




--- Comment #6 from Alexandre Julliard <julliard(a)winehq.org>  2008-05-09 12:55:04 ---
Closing bugs fixed in 1.0-rc1.


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.