[Bug 50559] New: widl-winrt-support patchset breaks compilation with clang
https://bugs.winehq.org/show_bug.cgi?id=50559 Bug ID: 50559 Summary: widl-winrt-support patchset breaks compilation with clang Product: Wine-staging Version: 6.0 Hardware: x86-64 OS: Linux Status: NEW Severity: blocker Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: dmitry(a)baikal.ru CC: leslie_alistair(a)hotmail.com, z.figura12(a)gmail.com Distribution: --- clang -c -o dlls/windows.media.speech.dll/windows.media.speech_main.cross.o dlls/windows.media.speech.dll/windows.media.speech_main.c \ -Idlls/windows.media.speech.dll -Iinclude -Iinclude/msvcrt -D__WINESRC__ -D_UCRT -DWINE_CROSS_PE \ -Wall -target i686-windows -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body \ -Wignored-qualifiers -Wno-pragma-pack -Wstrict-prototypes -Wtype-limits -Wvla -Wwrite-strings \ -Wpointer-arith -Wabsolute-value -fno-omit-frame-pointer -gdwarf-2 -gstrict-dwarf -g -O2 In file included from dlls/windows.media.speech.dll/windows.media.speech_main.c:18: include/windows.media.speechsynthesis.h:574:14: error: 'selectany' can only be applied to data items with external linkage static const DECLSPEC_SELECTANY WCHAR RuntimeClass_Windows_Media_SpeechSynthesis_VoiceInformation[] = {'W','i','n','d','o','w','s','.','M','e','d','i','a','.','S','p','e','e','c','h','S','y','n','t','h','e','s','i','s','.','V','o','i','c','e','I','n','f','o','r','m','a','t','i','o','n',0}; ^ include/winnt.h:112:39: note: expanded from macro 'DECLSPEC_SELECTANY' #define DECLSPEC_SELECTANY __declspec(selectany) ^ 1 error generated. Source of the breakage is this patch: https://github.com/wine-staging/wine-staging/blob/master/patches/widl-winrt-... It even mentions that: https://github.com/wine-staging/wine-staging/blob/master/patches/widl-winrt-... + /* MIDL generates extern const here */ + fprintf(header, "static const DECLSPEC_SELECTANY WCHAR RuntimeClass_%s[] = {", c_name); -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50559 Rémi Bernon <rbernon(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rbernon(a)codeweavers.com --- Comment #1 from Rémi Bernon <rbernon(a)codeweavers.com> --- I'm currently upstreaming the patches and this is a known issue that I'll fix. I will update the patch series in https://bugs.winehq.org/show_bug.cgi?id=49998 when appropriate. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50559 --- Comment #2 from Rémi Bernon <rbernon(a)codeweavers.com> --- The staging patch series have been updated with 5c5a8f3b2cf49b5aefcc8f63061e8030e8ca0294, and they include a fix for this. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50559 Dmitry Timoshkov <dmitry(a)baikal.ru> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Dmitry Timoshkov <dmitry(a)baikal.ru> --- (In reply to Rémi Bernon from comment #2)
The staging patch series have been updated with 5c5a8f3b2cf49b5aefcc8f63061e8030e8ca0294, and they include a fix for this.
Thanks, with the updated patchset wine-staging compiles with clang. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50559 Zebediah Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |5c5a8f3b2cf49b5aefcc8f63061 | |e8030e8ca0294 --- Comment #4 from Zebediah Figura <z.figura12(a)gmail.com> --- Closing bugs fixed in wine-staging 6.1. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50559 Zebediah Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|blocker |normal Status|RESOLVED |CLOSED --- Comment #5 from Zebediah Figura <z.figura12(a)gmail.com> --- Actually closing. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla