[Bug 151] New - dialog focus handling is not correct (e.g. in installers)

http://bugs.winehq.com/show_bug.cgi?id=151

*** shadow/151	Sat May 25 14:12:56 2002
--- shadow/151.tmp.23045	Sat May 25 14:12:56 2002
***************
*** 0 ****
--- 1,61 ----
+ +============================================================================+
+ | dialog focus handling is not correct (e.g. in installers)                  |
+ +----------------------------------------------------------------------------+
+ |        Bug #: 151                         Product: Wine                    |
+ |       Status: NEW                         Version: unspecified             |
+ |   Resolution:                            Platform:                         |
+ |     Severity: normal                   OS/Version: All                     |
+ |     Priority: P1                        Component: wine-user               |
+ +----------------------------------------------------------------------------+
+ |  Assigned To: wine-bugs(a)winehq.com                                         |
+ |  Reported By: andi(a)rhlx01.fht-esslingen.de                                 |
+ |      CC list: Cc:                                                          |
+ +----------------------------------------------------------------------------+
+ |    Milestone: TargetMilestone: ---                                         |
+ |          URL:                                                              |
+ +============================================================================+
+ |                              DESCRIPTION                                   |
+ Many installers seem to have problems with their initial dialog
+ (no focus, ...)
+ 
+ Roger Wilco's configuration wizard (property sheet imitation)
+ doesn't have a focus at all.
+ this configuration wizard has one dialog (cancel, back, next button, main area)
+ encapsulating
+ *another* dialog. This seems to get messed up somehow, and we end up with no
+ focus at all.
+ The key area to that clearly is the focus handling after WM_INITDIALOG in
+ DIALOG_CreateIndirect().
+ Note that Roger Wilco always returns FALSE for a WM_INITDIALOG, indicating its
+ own focus
+ handling (which it obviously doesn't do).
+ Thus Wine jumps in and messes it up :)
+ 
+ Oh well, after having spent some hours on this without a real solution (i.e. one
+ that doesn't just look
+ perfect in *this* case, but apart from that busts any other program out there),
+ I think I'll just submit
+ Roger Wilco as one "problem case".
+ 
+ If you get hold of some installer that has focus problems or other programs,
+ then add them here please
+ in order to have a real collection of problem cases.
+ 
+ ------- Additional Comments From andi(a)rhlx01.fht-esslingen.de  2001-01-04 15:22 -------
+ Created an attachment (id=15)
+ Roger Wilco (version Mark Ic, 430kb)
+ 
+ 
+ ------- Additional Comments From andi(a)rhlx01.fht-esslingen.de  2002-05-25 14:12 -------
+ Also, many installers have e.g. their "license agreement" text completely selected
+ (blue selection), which is wrong.
+ This happens because in DEFDLG_SetFocus, we select the whole edit control text
+ in case WM_GETDLGCODE returned DLGC_HASSETSEL, which is the default of any edit
+ control (see controls/edit.c/WM_GETDLGCODE; if you want to get rid of this flag,
+ you even have to explicitly subclass the edit control, according to MSDN !).
+ Thus both DLGC_HASSETSEL and DEFDLG_SetFocus aren't wrong, it seems,
+ but instead the edit control of the dialog should not have the focus in the
+ first place (instead it should probably be one of its buttons).
+ Somehow our criteria for selecting initial dialog focus seems to be wrong.
+ Experienced with the installer for WinMX 3.10, second license dialog
+ (huh, why have they got two !? :-).
\ No newline at end of file