[Bug 45266] New: SHFileOperation FO_MOVE fails to move files to target directory
https://bugs.winehq.org/show_bug.cgi?id=45266 Bug ID: 45266 Summary: SHFileOperation FO_MOVE fails to move files to target directory Product: Wine Version: 2.0 Hardware: x86 OS: Mac OS X Status: UNCONFIRMED Severity: normal Priority: P2 Component: shell32 Assignee: wine-bugs(a)winehq.org Reporter: fheidenreich(a)gmail.com When moving multiple files to one target directory, the SHFileOperation is aborted with ERROR_CANCELLED. I think it's caused by an erroneous check at https://source.winehq.org/git/wine.git/blob/HEAD:/dlls/shell32/shlfileop.c#l... if (!(lpFileOp->fFlags & FOF_MULTIDESTFILES) && !flFrom->bAnyDirectories && flFrom->dwNumFiles > flTo->dwNumFiles) { return ERROR_CANCELLED; } If the target is one single directory, FOF_MULTIDESTFILES is not set. flFrom->bAnyDirectories is false, since no directories are moved. And flFrom->dwNumFiles > flTo->dwNumFiles since we move multiple files to one target directory. I'm not sure what's the reasoning behind !flFrom->bAnyDirectories anyway. Maybe it's just a typo and should read !flTo->bAnyDirectories -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45266 Florian Heidenreich <fheidenreich(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fheidenreich(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45266 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dark.shadow4(a)web.de -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45266 --- Comment #1 from Florian Heidenreich <fheidenreich(a)gmail.com> --- The issue can be reproduced using Mp3tag v2.88a from https://download.mp3tag.de/mp3tagv288asetup.exe 1.) Load a directory with some MP3 files via Ctrl+D 2.) Select multiple files 3.) Choose 'Edit > Move...' As a result, the files are not moved due to the issue described above. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=45266 Ziqing Hui <zhui(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zhui(a)codeweavers.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=45266 Ken Sharp <imwellcushtymelike(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download URL| |https://download.mp3tag.de/ | |mp3tagv288asetup.exe -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=45266 --- Comment #2 from Ziqing Hui <zhui(a)codeweavers.com> --- I'm working on rewritting move_files(). -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=45266 --- Comment #3 from Ziqing Hui <zhui(a)codeweavers.com> --- Submitted MR: https://gitlab.winehq.org/wine/wine/-/merge_requests/8209 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=45266 Janne <janne.kekkonen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janne.kekkonen(a)gmail.com --- Comment #4 from Janne <janne.kekkonen(a)gmail.com> --- Tested with Wine 10.13 on Ubuntu 22.04 running on VMware. Downloaded application from here: https://download.mp3tag.de/versions/mp3tagv288asetup.exe Created new 32bit prefix and installed application. Moving files seems to be working. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=45266 Janne <janne.kekkonen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|janne.kekkonen(a)gmail.com | -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
wine-bugs＠winehq.org -
WineHQ Bugzilla