[Bug 19813] New: Voddler needs GetSystemTimes to run
http://bugs.winehq.org/show_bug.cgi?id=19813 Summary: Voddler needs GetSystemTimes to run Product: Wine Version: 1.1.27 Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs(a)winehq.org ReportedBy: martin(a)startwars.org Created an attachment (id=23212) --> (http://bugs.winehq.org/attachment.cgi?id=23212) terminal output from voddler I tried to run the Voddler client for Windows (www.voddler.com) A black window is shown and some terminal output shows many fixme:time:GetSystemTimes (0x32fc84,0x32fc7c,0x32fc74): Stub! See attachment for the full output Then the application "hangs" -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19813 reinejoh(a)gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #1 from reinejoh(a)gmail.com 2009-12-21 13:47:05 --- *** This bug has been confirmed by popular vote. *** -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19813 --- Comment #2 from reinejoh(a)gmail.com 2009-12-22 07:31:45 --- Created an attachment (id=25369) --> (http://bugs.winehq.org/attachment.cgi?id=25369) GetSystemTimes() implementation Found this patch at http://freevoddler.forumotion.com/voddler-f1/voddler-wine-t5.htm. I haven't tested it myself. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19813 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19813 --- Comment #3 from Thomas A <thomasa88+winebug(a)gmail.com> 2010-01-30 12:55:12 --- Created an attachment (id=25967) --> (http://bugs.winehq.org/attachment.cgi?id=25967) GetSystemTimes() patch with correct whitespacing The patch lost some white spaces when it was posted on freevoddler. I applied it manually against 3ed5df1e and created a new patch file. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19813 reinejoh(a)gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |reinejoh(a)gmail.com --- Comment #4 from reinejoh(a)gmail.com 2010-02-07 08:50:20 --- (In reply to comment #3)
The patch lost some white spaces when it was posted on freevoddler. I applied it manually against 3ed5df1e and created a new patch file.
Your patch file does not remove the "return FALSE" statement. Another thing, maybe GetSystemTimes() should return a BOOL, as MSDN has documented? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19813 Thomas A <thomasa88+winebug(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thomasa88+winebug(a)gmail.com --- Comment #5 from Thomas A <thomasa88+winebug(a)gmail.com> 2010-02-16 12:15:07 --- (In reply to comment #4)
(In reply to comment #3)
The patch lost some white spaces when it was posted on freevoddler. I applied it manually against 3ed5df1e and created a new patch file.
Your patch file does not remove the "return FALSE" statement.
Another thing, maybe GetSystemTimes() should return a BOOL, as MSDN has documented?
I just took the pre-made patch and applied it manually to get the correct formatting. I am not the author of the patch itself. You are right that I missed the "return FALSE", but I now feel that this whole topic can be closed as voddler never will release the latest source and are dropping the xbmc client in favor of an adobe air client. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19813 EA Durbin <ead1234(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ead1234(a)hotmail.com --- Comment #6 from EA Durbin <ead1234(a)hotmail.com> 2010-08-28 18:52:42 CDT --- As mentioned this affects XBMC. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19813 --- Comment #7 from Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> 2010-12-08 14:28:03 CST --- Created an attachment (id=32416) --> (http://bugs.winehq.org/attachment.cgi?id=32416) tests for GetSystemTimes I wrote some tests for GetSystemTimes, to show it returns same user/idle/kerneltime as NtQuerySystemInformation. Still needs a bit of polish. Implementation using NtQuerySystemInformation is then rather trivial I'll send patches soon -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19813 Jörg Höhle <hoehle(a)users.sourceforge.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |ntdll -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19813 Jerome Leclanche <adys.wh(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |adys.wh(a)gmail.com --- Comment #8 from Jerome Leclanche <adys.wh(a)gmail.com> 2013-01-21 08:08:42 CST --- Louis any update? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19813 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download URL| |http://www.voddler.com/en/h | |elp/download/ CC| |focht(a)gmx.net --- Comment #9 from Anastasius Focht <focht(a)gmx.net> 2013-09-29 15:31:48 CDT --- Hello folks, the stub is obviously still present. Source: http://source.winehq.org/git/wine.git/blob/debd62cf9fbd63c04599c77696c8fa603... --- snip --- 1065 /********************************************************************* 1066 * GetSystemTimes (KERNEL32.@) 1067 * 1068 * Retrieves system timing information 1069 * 1070 * PARAMS 1071 * lpIdleTime [O] Destination for idle time. 1072 * lpKernelTime [O] Destination for kernel time. 1073 * lpUserTime [O] Destination for user time. 1074 * 1075 * RETURNS 1076 * TRUE if success, FALSE otherwise. 1077 */ 1078 BOOL WINAPI GetSystemTimes(LPFILETIME lpIdleTime, LPFILETIME lpKernelTime, LPFILETIME lpUserTime) 1079 { 1080 FIXME("(%p,%p,%p): Stub!\n", lpIdleTime, lpKernelTime, lpUserTime); 1081 1082 return FALSE; 1083 } --- snip --- There is another attempt to implement it here: http://source.winehq.org/patches/data/99225 Hint: GetSystemTimes() should be implemented on top of NtQuerySystemInformation( SystemProcessorPerformanceInformation ...), it's not very hard ... $ wine --version wine-1.7.3 Regards -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=19813 Sebastian Lackner <sebastian(a)fds-team.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sebastian(a)fds-team.de --- Comment #10 from Sebastian Lackner <sebastian(a)fds-team.de> --- Erich wrote an implementation based on NtQuerySystemInformation some time ago, you can find it here: https://github.com/compholio/wine-compholio/blob/master/patches/kernel32-Get... https://github.com/compholio/wine-compholio/blob/master/patches/kernel32-Get... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=19813 Sebastian Lackner <sebastian(a)fds-team.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |erich.e.hoover(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=19813 André H. <nerv(a)dawncrow.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nerv(a)dawncrow.de --- Comment #11 from André H. <nerv(a)dawncrow.de> --- WAPT is also affected, but maybe it's only its python enginge simply returning TRUE in the stub was enough to get around it. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=19813 --- Comment #12 from André H. <nerv(a)dawncrow.de> --- Sorry for the noise... with WAPT i mean apt-get for windows: http://dev.tranquil.it/wiki/WAPT_-_apt-get_pour_Windows -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=19813 Jerome Leclanche <adys.wh(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |source -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=19813 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|ntdll |kernel32 Summary|Voddler needs |Voddler client hangs on |GetSystemTimes to run |startup | |(kernel32.GetSystemTimes is | |a stub) --- Comment #13 from Anastasius Focht <focht(a)gmx.net> --- Hello folks, obviously still present as of Wine 1.7.44 Regards -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=19813 --- Comment #14 from Erich E. Hoover <erich.e.hoover(a)wine-staging.com> --- (In reply to Anastasius Focht from comment #13)
Hello folks,
obviously still present as of Wine 1.7.44
Regards
Thank you for the reminder message. Sorry for the delay in submission, I've been out of town for a while. [1/2] http://source.winehq.org/patches/data/111884 [2/2] http://source.winehq.org/patches/data/111885 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=19813 André H. <nerv(a)dawncrow.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |5e817e93dedad99741a0637e595 | |2e6f18590c866 Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #15 from André H. <nerv(a)dawncrow.de> --- Should be fixed by: https://source.winehq.org/git/wine.git/commitdiff/305a73bcb5a619079a65292aa8... https://source.winehq.org/git/wine.git/commitdiff/5e817e93dedad99741a0637e59... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=19813 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #16 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 1.7.45. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org