[Bug 38363] New: tab control ignores click after changing selected tab by arrow key.

https://bugs.winehq.org/show_bug.cgi?id=38363

            Bug ID: 38363
           Summary: tab control ignores click after changing selected tab
                    by arrow key.
           Product: Wine
           Version: 1.7.39
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: comctl32
          Assignee: wine-bugs(a)winehq.org
          Reporter: ktmizugaki+wine(a)gmail.com
      Distribution: ---

tab control ignores click after changing selected tab by arrow key.

steps to reproduce:
1. open app which uses tab control (e.g. winecfg).
2. click tab to change tab.
3. press right arrow key to change tab. 
4. click another tab to change tab.
  expected: clicked tab is selected.
  actual: nothing happens.

if i select tab clicked in step 2 using arrow key, cliking tab works again.

i investigated and found that it related TCIS_BUTTONPRESSED state in tab
control.

in step 2, TCIS_BUTTONPRESSED state is set to the clicked tab in funciton
TAB_SetCurSel called from function TAB_LButtonDown.
in step 3, selected tab is changed but TCIS_BUTTONPRESSED state is not updated
in function TAB_SetCurFocus called from function TAB_KeyDown.
in step 4, function TAB_LButtonDown checks for the tab with TCIS_BUTTONPRESSED
and prevents it from changing tab.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 38363] tab control ignores click after changing selected tab by arrow key.

https://bugs.winehq.org/show_bug.cgi?id=38363

--- Comment #1 from Nikolay Sivov <bunglehead(a)gmail.com> ---
Unfortunately it's more complicated than that. TCIS_BUTTONPRESSED works
differently with comctl32 version 5 and version 6. Version 5 only uses this
state when TCS_BUTTONS is used, and it matches documentation. Version 6 uses it
for all styles it seems.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 38363] tab control ignores click after changing selected tab by arrow key.

https://bugs.winehq.org/show_bug.cgi?id=38363

--- Comment #2 from teru <ktmizugaki+wine(a)gmail.com> ---
Created attachment 51251
  --> https://bugs.winehq.org/attachment.cgi?id=51251
update TCIS_BUTTONPRESSED state in TAB_SetCurFocus

since TCIS_BUTTONPRESSED state is set in TAB_SetCurSel anyway, i suppose it
wouldn't hurt to change TCIS_BUTTONPRESSED state in TAB_SetCurFocus.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 38363] tab control ignores click after changing selected tab by arrow key.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=38363

Fabian Maurer <dark.shadow4(a)web.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
                 CC|                            |dark.shadow4(a)web.de
             Status|UNCONFIRMED                 |NEW

--- Comment #3 from Fabian Maurer <dark.shadow4(a)web.de> ---
Still present as of wine-5.16

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.