October 2006 - Wine-commits

Rob Shearman : ole32: Fix a memory leak on the error path of dispatch_rpc.
by Alexandre Julliard 27 Oct '06

27 Oct '06

Module: wine Branch: master Commit: b1bfad067bbc8a0a274281c028a773d0725d12bb URL: http://source.winehq.org/git/wine.git/?a=commit;h=b1bfad067bbc8a0a274281c02… Author: Rob Shearman <rob(a)codeweavers.com> Date: Thu Oct 26 12:38:54 2006 +0100 ole32: Fix a memory leak on the error path of dispatch_rpc. --- dlls/ole32/rpc.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/dlls/ole32/rpc.c b/dlls/ole32/rpc.c index 7bb6e9f..368a6ba 100644 --- a/dlls/ole32/rpc.c +++ b/dlls/ole32/rpc.c @@ -547,6 +547,7 @@ static void __RPC_STUB dispatch_rpc(RPC_ if (hr != S_OK) { ERR("no apartment found for ipid %s\n", debugstr_guid(&ipid)); + HeapFree(GetProcessHeap(), 0, params); return RpcRaiseException(hr); }

1 0

Rob Shearman : rpcrt4: Fix RPCRT4_Receive to accept authentication verifier data on any packets, not just bind packets.
by Alexandre Julliard 27 Oct '06

27 Oct '06

Module: wine Branch: master Commit: 28d3bd3e42fcd9388416efde0e9c5d2aa9b5886c URL: http://source.winehq.org/git/wine.git/?a=commit;h=28d3bd3e42fcd9388416efde0… Author: Rob Shearman <rob(a)codeweavers.com> Date: Thu Oct 26 23:15:00 2006 +0100 rpcrt4: Fix RPCRT4_Receive to accept authentication verifier data on any packets, not just bind packets. --- dlls/rpcrt4/rpc_defs.h | 3 ++ dlls/rpcrt4/rpc_message.c | 59 ++++++++++++++++++++++++++++++++++++++------ 2 files changed, 54 insertions(+), 8 deletions(-) diff --git a/dlls/rpcrt4/rpc_defs.h b/dlls/rpcrt4/rpc_defs.h index 1bc8f5b..4ee840c 100644 --- a/dlls/rpcrt4/rpc_defs.h +++ b/dlls/rpcrt4/rpc_defs.h @@ -143,6 +143,9 @@ typedef struct unsigned long auth_context_id; /* unique value for the authenticated connection */ } RpcAuthVerifier; +#define RPC_AUTH_VERIFIER_LEN(common_hdr) \ + ((common_hdr)->auth_len ? (common_hdr)->auth_len + sizeof(RpcAuthVerifier) : 0) + #define RPC_VER_MAJOR 5 #define RPC_VER_MINOR 0 diff --git a/dlls/rpcrt4/rpc_message.c b/dlls/rpcrt4/rpc_message.c index 0120bf6..f102cf6 100644 --- a/dlls/rpcrt4/rpc_message.c +++ b/dlls/rpcrt4/rpc_message.c @@ -475,7 +475,9 @@ RPC_STATUS RPCRT4_Receive(RpcConnection unsigned short first_flag; unsigned long data_length; unsigned long buffer_length; + unsigned long auth_length; unsigned char *buffer_ptr; + unsigned char *auth_data = NULL; RpcPktCommonHdr common_hdr; *Header = NULL; @@ -525,7 +527,7 @@ RPC_STATUS RPCRT4_Receive(RpcConnection pMsg->BufferLength = (*Header)->request.alloc_hint; break; default: - pMsg->BufferLength = common_hdr.frag_len - hdr_length; + pMsg->BufferLength = common_hdr.frag_len - hdr_length - RPC_AUTH_VERIFIER_LEN(&common_hdr); } TRACE("buffer length = %u\n", pMsg->BufferLength); @@ -534,11 +536,38 @@ RPC_STATUS RPCRT4_Receive(RpcConnection if (status != RPC_S_OK) goto fail; first_flag = RPC_FLG_FIRST; + auth_length = common_hdr.auth_len; + if (auth_length) { + auth_data = HeapAlloc(GetProcessHeap(), 0, RPC_AUTH_VERIFIER_LEN(&common_hdr)); + if (!auth_data) { + status = RPC_S_PROTOCOL_ERROR; + goto fail; + } + } buffer_length = 0; buffer_ptr = pMsg->Buffer; while (buffer_length < pMsg->BufferLength) { - data_length = (*Header)->common.frag_len - hdr_length; + unsigned int header_auth_len = RPC_AUTH_VERIFIER_LEN(&(*Header)->common); + + /* verify header fields */ + + if (((*Header)->common.frag_len < hdr_length) || + ((*Header)->common.frag_len - hdr_length < header_auth_len)) { + WARN("frag_len %d too small for hdr_length %ld and auth_len %d\n", + common_hdr.frag_len, hdr_length, common_hdr.auth_len); + status = RPC_S_PROTOCOL_ERROR; + goto fail; + } + + if ((*Header)->common.auth_len != auth_length) { + WARN("auth_len header field changed from %ld to %d\n", + auth_length, (*Header)->common.auth_len); + status = RPC_S_PROTOCOL_ERROR; + goto fail; + } + + data_length = (*Header)->common.frag_len - hdr_length - header_auth_len; if (((*Header)->common.flags & RPC_FLG_FIRST) != first_flag || data_length + buffer_length > pMsg->BufferLength) { TRACE("invalid packet flags or buffer length\n"); @@ -554,6 +583,21 @@ RPC_STATUS RPCRT4_Receive(RpcConnection goto fail; } + if (header_auth_len) { + /* FIXME: we should accumulate authentication data for the bind, + * bind_ack, alter_context and alter_context_response if necessary. + * however, the details of how this is done is very sketchy in the + * DCE/RPC spec. for all other packet types that have authentication + * verifier data then it is just duplicated in all the fragments */ + dwRead = rpcrt4_conn_read(Connection, auth_data, header_auth_len); + if (dwRead != header_auth_len) { + WARN("bad authentication data length, %ld/%d\n", dwRead, + header_auth_len); + status = RPC_S_PROTOCOL_ERROR; + goto fail; + } + } + /* when there is no more data left, it should be the last packet */ if (buffer_length == pMsg->BufferLength && ((*Header)->common.flags & RPC_FLG_LAST) == 0) { @@ -580,13 +624,11 @@ RPC_STATUS RPCRT4_Receive(RpcConnection } /* respond to authorization request */ - if (common_hdr.ptype == PKT_BIND_ACK && common_hdr.auth_len > 8) + if (common_hdr.ptype == PKT_BIND_ACK && auth_length > sizeof(RpcAuthVerifier)) { - unsigned int offset; - - offset = common_hdr.frag_len - hdr_length - common_hdr.auth_len; - status = RPCRT_AuthorizeConnection(Connection, (LPBYTE)pMsg->Buffer + offset, - common_hdr.auth_len); + status = RPCRT_AuthorizeConnection(Connection, + auth_data + sizeof(RpcAuthVerifier), + auth_length); if (status) goto fail; } @@ -599,6 +641,7 @@ fail: RPCRT4_FreeHeader(*Header); *Header = NULL; } + HeapFree(GetProcessHeap(), 0, auth_data); return status; }

1 0

Rob Shearman : rpcrt4: The allocation hint in request and response packets is just that - a hint.
by Alexandre Julliard 27 Oct '06

27 Oct '06

Module: wine Branch: master Commit: 709b536f0c35e6d3d6eb12eb1cc3c53af0686307 URL: http://source.winehq.org/git/wine.git/?a=commit;h=709b536f0c35e6d3d6eb12eb1… Author: Rob Shearman <rob(a)codeweavers.com> Date: Thu Oct 26 23:16:25 2006 +0100 rpcrt4: The allocation hint in request and response packets is just that - a hint. It is not an error if the stub data exceeds this size, so reallocate the buffer with the newly calculated size and continue. --- dlls/rpcrt4/rpc_message.c | 35 +++++++++++++++++++++++++++-------- 1 files changed, 27 insertions(+), 8 deletions(-) diff --git a/dlls/rpcrt4/rpc_message.c b/dlls/rpcrt4/rpc_message.c index 6d434c0..80fbcc0 100644 --- a/dlls/rpcrt4/rpc_message.c +++ b/dlls/rpcrt4/rpc_message.c @@ -50,6 +50,8 @@ #define AUTH_ALIGNMENT 16 #define ROUND_UP_AMOUNT(value, alignment) \ (((alignment) - (((value) % (alignment)))) % (alignment)) +static RPC_STATUS I_RpcReAllocateBuffer(PRPC_MESSAGE pMsg); + static DWORD RPCRT4_GetHeaderSize(RpcPktHdr *Header) { static const DWORD header_sizes[] = { @@ -476,7 +478,6 @@ RPC_STATUS RPCRT4_Receive(RpcConnection unsigned long data_length; unsigned long buffer_length; unsigned long auth_length; - unsigned char *buffer_ptr; unsigned char *auth_data = NULL; RpcPktCommonHdr common_hdr; @@ -545,7 +546,6 @@ RPC_STATUS RPCRT4_Receive(RpcConnection } } buffer_length = 0; - buffer_ptr = pMsg->Buffer; while (TRUE) { unsigned int header_auth_len = RPC_AUTH_VERIFIER_LEN(&(*Header)->common); @@ -567,16 +567,24 @@ RPC_STATUS RPCRT4_Receive(RpcConnection goto fail; } - data_length = (*Header)->common.frag_len - hdr_length - header_auth_len; - if (((*Header)->common.flags & RPC_FLG_FIRST) != first_flag || - data_length + buffer_length > pMsg->BufferLength) { - TRACE("invalid packet flags or buffer length\n"); + if (((*Header)->common.flags & RPC_FLG_FIRST) != first_flag) { + TRACE("invalid packet flags\n"); status = RPC_S_PROTOCOL_ERROR; goto fail; } + data_length = (*Header)->common.frag_len - hdr_length - header_auth_len; + if (data_length + buffer_length > pMsg->BufferLength) { + TRACE("allocation hint exceeded, new buffer length = %ld\n", + data_length + buffer_length); + pMsg->BufferLength = data_length + buffer_length; + status = I_RpcReAllocateBuffer(pMsg); + if (status != RPC_S_OK) goto fail; + } + if (data_length == 0) dwRead = 0; else - dwRead = rpcrt4_conn_read(Connection, buffer_ptr, data_length); + dwRead = rpcrt4_conn_read(Connection, + (unsigned char *)pMsg->Buffer + buffer_length, data_length); if (dwRead != data_length) { WARN("bad data length, %ld/%ld\n", dwRead, data_length); status = RPC_S_PROTOCOL_ERROR; @@ -610,7 +618,6 @@ RPC_STATUS RPCRT4_Receive(RpcConnection goto fail; } - buffer_ptr += data_length; first_flag = 0; } else { break; @@ -655,6 +662,18 @@ RPC_STATUS WINAPI I_RpcGetBuffer(PRPC_ME } /*********************************************************************** + * I_RpcReAllocateBuffer (internal) + */ +static RPC_STATUS I_RpcReAllocateBuffer(PRPC_MESSAGE pMsg) +{ + TRACE("(%p): BufferLength=%d\n", pMsg, pMsg->BufferLength); + pMsg->Buffer = HeapReAlloc(GetProcessHeap(), 0, pMsg->Buffer, pMsg->BufferLength); + + TRACE("Buffer=%p\n", pMsg->Buffer); + return pMsg->Buffer ? RPC_S_OK : RPC_S_OUT_OF_RESOURCES; +} + +/*********************************************************************** * I_RpcFreeBuffer [RPCRT4.@] */ RPC_STATUS WINAPI I_RpcFreeBuffer(PRPC_MESSAGE pMsg)

1 0

Rob Shearman : rpcrt4: Don' t terminate the loop on the buffer becoming filled, but when we receive a packet with the RPC_FLG_LAST flag set.
by Alexandre Julliard 27 Oct '06

27 Oct '06

Module: wine Branch: master Commit: fbe829cbb1c89771c0115e1196c167be73506612 URL: http://source.winehq.org/git/wine.git/?a=commit;h=fbe829cbb1c89771c0115e119… Author: Rob Shearman <rob(a)codeweavers.com> Date: Thu Oct 26 23:15:11 2006 +0100 rpcrt4: Don't terminate the loop on the buffer becoming filled, but when we receive a packet with the RPC_FLG_LAST flag set. This matches what is mentioned in the DCE/RPC specification. --- dlls/rpcrt4/rpc_message.c | 15 +++++---------- 1 files changed, 5 insertions(+), 10 deletions(-) diff --git a/dlls/rpcrt4/rpc_message.c b/dlls/rpcrt4/rpc_message.c index f102cf6..6d434c0 100644 --- a/dlls/rpcrt4/rpc_message.c +++ b/dlls/rpcrt4/rpc_message.c @@ -546,7 +546,7 @@ RPC_STATUS RPCRT4_Receive(RpcConnection } buffer_length = 0; buffer_ptr = pMsg->Buffer; - while (buffer_length < pMsg->BufferLength) + while (TRUE) { unsigned int header_auth_len = RPC_AUTH_VERIFIER_LEN(&(*Header)->common); @@ -598,16 +598,8 @@ RPC_STATUS RPCRT4_Receive(RpcConnection } } - /* when there is no more data left, it should be the last packet */ - if (buffer_length == pMsg->BufferLength && - ((*Header)->common.flags & RPC_FLG_LAST) == 0) { - WARN("no more data left, but not last packet\n"); - status = RPC_S_PROTOCOL_ERROR; - goto fail; - } - buffer_length += data_length; - if (buffer_length < pMsg->BufferLength) { + if (!((*Header)->common.flags & RPC_FLG_LAST)) { TRACE("next header\n"); /* read the header of next packet */ @@ -620,8 +612,11 @@ RPC_STATUS RPCRT4_Receive(RpcConnection buffer_ptr += data_length; first_flag = 0; + } else { + break; } } + pMsg->BufferLength = buffer_length; /* respond to authorization request */ if (common_hdr.ptype == PKT_BIND_ACK && auth_length > sizeof(RpcAuthVerifier))

1 0

Rob Shearman : ole32: Always call IRpcChannelBuffer_GetBuffer in the class factory stub.
by Alexandre Julliard 27 Oct '06

27 Oct '06

Module: wine Branch: master Commit: 7cbafd4f74ab63bb4518af65ea3ddbe120dcf5b2 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7cbafd4f74ab63bb4518af65e… Author: Rob Shearman <rob(a)codeweavers.com> Date: Thu Oct 26 12:38:09 2006 +0100 ole32: Always call IRpcChannelBuffer_GetBuffer in the class factory stub. --- dlls/ole32/oleproxy.c | 14 +++++++------- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/dlls/ole32/oleproxy.c b/dlls/ole32/oleproxy.c index ad2960d..9a35b85 100644 --- a/dlls/ole32/oleproxy.c +++ b/dlls/ole32/oleproxy.c @@ -171,31 +171,31 @@ CFStub_Invoke( } hres = IClassFactory_CreateInstance(classfac,NULL,&iid,(LPVOID*)&ppv); IClassFactory_Release(classfac); + msg->cbBuffer = 0; if (hres) { - msg->cbBuffer = 0; FIXME("Failed to create an instance of %s\n",debugstr_guid(&iid)); - return hres; + goto getbuffer; } hres = CreateStreamOnHGlobal(0,TRUE,&pStm); if (hres) { FIXME("Failed to create stream on hglobal\n"); - return hres; + goto getbuffer; } hres = CoMarshalInterface(pStm,&iid,ppv,0,NULL,0); IUnknown_Release((IUnknown*)ppv); if (hres) { - FIXME("CoMarshalInterface failed, %x!\n",hres); - msg->cbBuffer = 0; - return hres; + FIXME("CoMarshalInterface failed, %x!\n",hres); + goto getbuffer; } hres = IStream_Stat(pStm,&ststg,0); if (hres) { FIXME("Stat failed.\n"); - return hres; + goto getbuffer; } msg->cbBuffer = ststg.cbSize.u.LowPart; +getbuffer: IRpcChannelBuffer_GetBuffer(chanbuf, msg, &IID_IClassFactory); if (hres) return hres;

1 0

Rob Shearman : ole32: Fix some memory leaks in the class factory proxy.
by Alexandre Julliard 27 Oct '06

27 Oct '06

Module: wine Branch: master Commit: 93dfdf7a3f4c29308fbfebc85f58bcea51b2efb4 URL: http://source.winehq.org/git/wine.git/?a=commit;h=93dfdf7a3f4c29308fbfebc85… Author: Rob Shearman <rob(a)codeweavers.com> Date: Thu Oct 26 12:38:27 2006 +0100 ole32: Fix some memory leaks in the class factory proxy. --- dlls/ole32/oleproxy.c | 9 ++++++++- 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/dlls/ole32/oleproxy.c b/dlls/ole32/oleproxy.c index 9a35b85..889e03c 100644 --- a/dlls/ole32/oleproxy.c +++ b/dlls/ole32/oleproxy.c @@ -382,11 +382,14 @@ static HRESULT WINAPI CFProxy_CreateInst hres = IRpcChannelBuffer_SendReceive(This->chanbuf,&msg,&srstatus); if (hres) { FIXME("IRpcChannelBuffer_SendReceive failed with %x?\n",hres); + IRpcChannelBuffer_FreeBuffer(This->chanbuf,&msg); return hres; } - if (!msg.cbBuffer) /* interface not found on remote */ + if (!msg.cbBuffer) { /* interface not found on remote */ + IRpcChannelBuffer_FreeBuffer(This->chanbuf,&msg); return srstatus; + } /* We got back: [Marshalled Interface data] */ TRACE("got %d bytes data.\n",msg.cbBuffer); @@ -395,6 +398,7 @@ static HRESULT WINAPI CFProxy_CreateInst hres = CreateStreamOnHGlobal(hGlobal,TRUE,&pStream); if (hres) { FIXME("CreateStreamOnHGlobal failed with %x\n",hres); + IRpcChannelBuffer_FreeBuffer(This->chanbuf,&msg); return hres; } hres = CoUnmarshalInterface( @@ -403,6 +407,9 @@ static HRESULT WINAPI CFProxy_CreateInst ppv ); IStream_Release(pStream); /* Does GlobalFree hGlobal too. */ + + IRpcChannelBuffer_FreeBuffer(This->chanbuf,&msg); + if (hres) { FIXME("CoMarshalInterface failed, %x\n",hres); return hres;

1 0

lostwages/news 2006091701.xml 2006100201.xml
by Jeremy Newman 26 Oct '06

26 Oct '06

ChangeSet ID: 29294 CVSROOT: /opt/cvs-commit Module name: lostwages Changes by: jnewman(a)winehq.org 2006/10/26 14:41:04 Modified files: news : 2006091701.xml 2006100201.xml Log message: clean up and validation fixes Patch: http://cvs.winehq.org/patch.py?id=29294 Old revision New revision Changes Path 1.1 1.2 +7 -5 lostwages/news/2006091701.xml 1.1 1.2 +2 -3 lostwages/news/2006100201.xml Index: lostwages/news/2006091701.xml diff -u -p lostwages/news/2006091701.xml:1.1 lostwages/news/2006091701.xml:1.2 --- lostwages/news/2006091701.xml:1.1 26 Oct 2006 19:41: 4 -0000 +++ lostwages/news/2006091701.xml 26 Oct 2006 19:41: 4 -0000 @@ -2,16 +2,18 @@ <date>September 17, 2006</date> <title>WineConf 2006</title> <body> - -<center> -<a href="/images/wineconf06_grp.jpg"><img src="/images/wineconf06_grp_thmb.jpg" /></a> -</center> + +<a href="{$root}/images/wineconf06_grp.jpg"><img src="{$root}/images/wineconf06_grp_thmb.jpg" width="145" height="109" alt="WineConf 2006 Group Photo" /></a> + + WineConf 2006 has just about wrapped up. Approximately 35 developers convened in Reading, England for the event. A summary will follow, but for now you can check out this year's -<a href="/images/wineconf06_grp.jpg">group photo</a> (1MB). +<a href="{$root}/images/wineconf06_grp.jpg">group photo</a> (1MB). + + The Wine team would especially like to thank Lars Mathiassen and the members of the <a href="http://www.tightpoker.com/">Party Poker Strategy Guide</a> for their Index: lostwages/news/2006100201.xml diff -u -p lostwages/news/2006100201.xml:1.1 lostwages/news/2006100201.xml:1.2 --- lostwages/news/2006100201.xml:1.1 26 Oct 2006 19:41: 4 -0000 +++ lostwages/news/2006100201.xml 26 Oct 2006 19:41: 4 -0000 @@ -2,8 +2,7 @@ <date>September 28, 2006</date> <title>Wine 0.9.22 Released</title> <body> - -Wine 0.9.22 came out last week with these changes: +Wine 0.9.22 came out last week with these changes: <ul> <li> The usual assortment of MSI improvements.</li> @@ -11,7 +10,7 @@ Wine 0.9.22 came out last week with thes <li> Pixel shaders enabled by default in D3D.</li> <li> Various improvements to the build process.</li> <li> Many translation updates.</li> -</ul> +</ul> Binary packages are in the process of being built and it may take a few days

1 0

lostwages/news 2006102501.xml
by Jeremy Newman 26 Oct '06

26 Oct '06

ChangeSet ID: 29293 CVSROOT: /opt/cvs-commit Module name: lostwages Changes by: jnewman(a)winehq.org 2006/10/26 14:40:51 Added files: news : 2006102501.xml Log message: Tom Wickline <twickline(a)gmail.com> News Wine 0.9.23 release Patch: http://cvs.winehq.org/patch.py?id=29293 Old revision New revision Changes Path Added 1.1 +0 -0 lostwages/news/2006102501.xml Index: lostwages/news/2006102501.xml diff -u -p /dev/null lostwages/news/2006102501.xml:1.1 --- /dev/null 26 Oct 2006 19:40:51 -0000 +++ lostwages/news/2006102501.xml 26 Oct 2006 19:40:51 -0000 @@ -0,0 +1,25 @@ +<news> + <date>October 25, 2006</date> + <title>Wine 0.9.23 Released</title> + <body> +Wine 0.9.23 came out last week with these changes: + +<ul> +<li> Massive update of printf formats for Win64 compatibility.</li> +<li> Dynamic drive support on MacOSX.</li> +<li> Still more MSI fixes and improvements.</li> +<li> Lots of bug fixes.</li> +</ul> + + + Binary packages are in the process of being built and it may take a few days + for them to appear, but the source is + <a href="http://prdownloads.sourceforge.net/wine/wine-0.9.23.tar.bz2">available + now</a>. You can find out more about this release in the + <a href="?announce=1.127">announcement</a>. Check out our + <a href="/site/download">download page</a> for packages for your favorite + distribution. + + + </body> +</news>

1 0

lostwages/ include/html.php wwn/wn20000410_38. ...
by Jeremy Newman 26 Oct '06

26 Oct '06

ChangeSet ID: 29292 CVSROOT: /opt/cvs-commit Module name: lostwages Changes by: jnewman(a)winehq.org 2006/10/26 14:26:31 Modified files: include : html.php wwn : wn20000410_38.xml wn20000508_42.xml wn20001113_69.xml wn20010506_94.xml wn20010802_101.xml wn20020129_114.xml wn20020213_115.xml wn20020530_124.xml wn20020927_137.xml wn20030124_154.xml wn20031121_197.xml wn20040514_222.xml wn20040709_230.xml wn20040827_237.xml wn20050325_267.xml wn20050401_268.xml wn20050415_270.xml wn20050506_273.xml wn20050722_284.xml wn20050729_285.xml wn20050805_286.xml wn20051211_301.xml wn20060313_308.xml wn20060810_319.xml wwn/interviews : interview_3.xml interview_8.xml Log message: Francois Gouget <fgouget(a)free.fr> Assorted spelling and duplicates fixes Patch: http://cvs.winehq.org/patch.py?id=29292 Old revision New revision Changes Path 1.16 1.17 +1 -1 lostwages/include/html.php 1.3 1.4 +2 -2 lostwages/wwn/wn20000410_38.xml 1.4 1.5 +1 -1 lostwages/wwn/wn20000508_42.xml 1.3 1.4 +1 -1 lostwages/wwn/wn20001113_69.xml 1.12 1.13 +1 -1 lostwages/wwn/wn20010506_94.xml 1.7 1.8 +1 -1 lostwages/wwn/wn20010802_101.xml 1.6 1.7 +1 -1 lostwages/wwn/wn20020129_114.xml 1.10 1.11 +1 -1 lostwages/wwn/wn20020213_115.xml 1.8 1.9 +1 -1 lostwages/wwn/wn20020530_124.xml 1.4 1.5 +1 -1 lostwages/wwn/wn20020927_137.xml 1.9 1.10 +1 -1 lostwages/wwn/wn20030124_154.xml 1.8 1.9 +1 -1 lostwages/wwn/wn20031121_197.xml 1.6 1.7 +1 -1 lostwages/wwn/wn20040514_222.xml 1.3 1.4 +1 -1 lostwages/wwn/wn20040709_230.xml 1.4 1.5 +1 -1 lostwages/wwn/wn20040827_237.xml 1.5 1.6 +1 -1 lostwages/wwn/wn20050325_267.xml 1.5 1.6 +1 -1 lostwages/wwn/wn20050401_268.xml 1.2 1.3 +1 -1 lostwages/wwn/wn20050415_270.xml 1.2 1.3 +1 -1 lostwages/wwn/wn20050506_273.xml 1.4 1.5 +1 -1 lostwages/wwn/wn20050722_284.xml 1.2 1.3 +1 -1 lostwages/wwn/wn20050729_285.xml 1.4 1.5 +1 -1 lostwages/wwn/wn20050805_286.xml 1.4 1.5 +1 -1 lostwages/wwn/wn20051211_301.xml 1.3 1.4 +1 -1 lostwages/wwn/wn20060313_308.xml 1.2 1.3 +1 -1 lostwages/wwn/wn20060810_319.xml 1.5 1.6 +3 -3 lostwages/wwn/interviews/interview_3.xml 1.2 1.3 +1 -1 lostwages/wwn/interviews/interview_8.xml

1 0

lostwages/templates/en sending_patches.template
by Jeremy Newman 26 Oct '06

26 Oct '06

ChangeSet ID: 29291 CVSROOT: /opt/cvs-commit Module name: lostwages Changes by: jnewman(a)winehq.org 2006/10/26 14:25:39 Modified files: templates/en : sending_patches.template Log message: Jan Zerebecki <jan.wine(a)zerebecki.de> sending_patches: Add usual response time and rearrange some sentences. Patch: http://cvs.winehq.org/patch.py?id=29291 Old revision New revision Changes Path 1.17 1.18 +15 -9 lostwages/templates/en/sending_patches.template Index: lostwages/templates/en/sending_patches.template diff -u -p lostwages/templates/en/sending_patches.template:1.17 lostwages/templates/en/sending_patches.template:1.18 --- lostwages/templates/en/sending_patches.template:1.17 26 Oct 2006 19:25:39 -0000 +++ lostwages/templates/en/sending_patches.template 26 Oct 2006 19:25:39 -0000 @@ -11,7 +11,10 @@ chapter in our online documentation. <a href="mailto:wine-patches(a)winehq.org">wine-patches(a)winehq.org</a>. (Note that if you're not <a href="{$root}/site/forums">subscribed</a> to the mailing list, the mailing list administrators must first check your submission -to make sure it's not spam before they can let it through.) +to make sure it's not spam before they can let it through. +There is no attempt to apply patches that appear in the newsgroup +or anywhere else to the Git tree.) + When submitting patches, please: <ul> @@ -51,15 +54,22 @@ to make sure it's not spam before they c <li> Write a mail to wine-devel, explain your patch and request it be reviewed by anybody that cares to review it. + <li> Ask for advice about your patch on #winehackers. + <li> Unless one already exists, open a bug in bugzilla describing the problem you are trying to solve (eg. ./configure fails on Solaris, etc) and attach your patch. - - <li> Ask for advice about your patch on #winehackers. </ul> - You may find it difficult to solicit feedback, - so think carefully about the comments you receive. + + If your patch didn't receive a response for 3 days of WineHQ Git commits + your patch has a high chance of being in this category. + + You may find it difficult to solicit feedback, + so think carefully about the comments you receive. + + Just do not give up! + <hr> @@ -98,8 +108,4 @@ if you have setup the mail headers in th That should generate a number of txt files, which you can send manually. -There is no attempt to apply patches that appears in the newsgroup -to the Git tree. Please send patches to -<a href="mailto:wine-patches(a)winehq.org">wine-patches(a)winehq.org</a>. -

1 0