February 2006 - Wine-commits

Juan Lang : crypt32: Implement CertRDNValueToStrW and CertNameToStrW, with tests.
by Alexandre Julliard 02 Feb '06

02 Feb '06

Module: wine Branch: refs/heads/master Commit: ede2e24a6af7677217486cc2f213dfebac15314a URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=ede2e24a6af7677217486cc… Author: Juan Lang <juan(a)codeweavers.com> Date: Thu Feb 2 13:19:30 2006 +0100 crypt32: Implement CertRDNValueToStrW and CertNameToStrW, with tests. --- dlls/crypt32/str.c | 139 +++++++++++++++++++++++++++++- dlls/crypt32/tests/str.c | 211 ++++++++++++++++++++++++++++++++++++++++++++-- 2 files changed, 335 insertions(+), 15 deletions(-) Diff: http://source.winehq.org/git/?p=wine.git;a=commitdiff;h=ede2e24a6af76772174…

1 0

Juan Lang : crypt32: Support external providers.
by Alexandre Julliard 02 Feb '06

02 Feb '06

Module: wine Branch: refs/heads/master Commit: 66a303d107befb6d9af1fcad924713d3402df015 URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=66a303d107befb6d9af1fca… Author: Juan Lang <juan_lang(a)yahoo.com> Date: Thu Feb 2 13:19:39 2006 +0100 crypt32: Support external providers. - add support for external store providers - rewrite registry stores as a provider - fix a memory leak --- dlls/crypt32/cert.c | 461 +++++++++++++++++++++++++++++++++++---------------- 1 files changed, 317 insertions(+), 144 deletions(-) Diff: http://source.winehq.org/git/?p=wine.git;a=commitdiff;h=66a303d107befb6d9af…

1 0

Kevin Koltzau : riched20: Handle context menu.
by Alexandre Julliard 02 Feb '06

02 Feb '06

Module: wine Branch: refs/heads/master Commit: fc2ce6779eaf8bcda42be384a93daacd0cdfdb19 URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=fc2ce6779eaf8bcda42be38… Author: Kevin Koltzau <kevin(a)plop.org> Date: Thu Feb 2 13:18:20 2006 +0100 riched20: Handle context menu. --- dlls/riched20/editor.c | 26 ++++++++++++++++++++++++++ 1 files changed, 26 insertions(+), 0 deletions(-) diff --git a/dlls/riched20/editor.c b/dlls/riched20/editor.c index 9b741a8..5111807 100644 --- a/dlls/riched20/editor.c +++ b/dlls/riched20/editor.c @@ -852,6 +852,29 @@ ME_KeyDown(ME_TextEditor *editor, WORD n return FALSE; } +static void ME_ShowContextMenu(ME_TextEditor *editor, int x, int y) +{ + CHARRANGE selrange; + HMENU menu; + int seltype = 0; + if(!editor->lpOleCallback) + return; + ME_GetSelection(editor, (int *)&selrange.cpMin, (int *)&selrange.cpMax); + if(selrange.cpMin == selrange.cpMax) + seltype |= SEL_EMPTY; + else + { + /* FIXME: Handle objects */ + seltype |= SEL_TEXT; + if(selrange.cpMax-selrange.cpMin > 1) + seltype |= SEL_MULTICHAR; + } + if(SUCCEEDED(IRichEditOleCallback_GetContextMenu(editor->lpOleCallback, seltype, NULL, &selrange, &menu))) + { + TrackPopupMenu(menu, TPM_LEFTALIGN | TPM_RIGHTBUTTON, x, y, 0, GetParent(editor->hWnd), NULL); + DestroyMenu(menu); + } +} ME_TextEditor *ME_MakeEditor(HWND hWnd) { ME_TextEditor *ed = ALLOC_OBJ(ME_TextEditor); @@ -1842,6 +1865,9 @@ LRESULT WINAPI RichEditANSIWndProc(HWND case WM_LBUTTONDBLCLK: ME_SelectWord(editor); break; + case WM_CONTEXTMENU: + ME_ShowContextMenu(editor, (short)LOWORD(lParam), (short)HIWORD(lParam)); + break; case WM_PAINT: if (editor->bRedraw) {

1 0

Fatih Aşıcı : start.exe: build_args now returns the correct string when no parameter
by Alexandre Julliard 01 Feb '06

01 Feb '06

Module: wine Branch: refs/heads/master Commit: 1c9e1f3473c7f29998d03c42e88c0fab6d5c69cb URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=1c9e1f3473c7f29998d03c4… Author: Fatih Aşıcı <fasici(a)linux-sevenler.org> Date: Wed Feb 1 13:50:52 2006 +0100 start.exe: build_args now returns the correct string when no parameter is passed. --- programs/start/start.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/programs/start/start.c b/programs/start/start.c index 3effed6..0aee916 100644 --- a/programs/start/start.c +++ b/programs/start/start.c @@ -109,6 +109,7 @@ static char *build_args( int argc, char for (i = 0; i < argc; i++ ) len += strlen(argv[i]) + 1; ret = HeapAlloc( GetProcessHeap(), 0, len ); + ret[0] = 0; for (i = 0, p = ret; i < argc; i++ ) p += sprintf(p, " %s", argv[i]);

1 0

Fatih Aşıcı : x11drv: Added Turkish F keyboard layout.
by Alexandre Julliard 01 Feb '06

01 Feb '06

Module: wine Branch: refs/heads/master Commit: a8ef244b89d37d2cfd084f07ce56460706a48725 URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=a8ef244b89d37d2cfd084f0… Author: Fatih Aşıcı <fasici(a)linux-sevenler.org> Date: Wed Feb 1 13:50:37 2006 +0100 x11drv: Added Turkish F keyboard layout. --- dlls/x11drv/keyboard.c | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/dlls/x11drv/keyboard.c b/dlls/x11drv/keyboard.c index 3df4162..f645b70 100644 --- a/dlls/x11drv/keyboard.c +++ b/dlls/x11drv/keyboard.c @@ -799,6 +799,16 @@ static const char main_key_TR[MAIN_LEN][ "<>" }; +/*** Turkish F keyboard layout (setxkbmap trf) */ +static const char main_key_TR_F[MAIN_LEN][4] = +{ +"+*","1!","2\"","3^#","4$","5%","6&","7'","8(","9)","0=","/?","-_", +"fF","gG","��","�I","oO","dD","rR","nN","hH","pP","qQ","wW", +"uU","i�","eE","aA","��","tT","kK","mM","lL","yY","��","xX", +"jJ","��","vV","cC","��","zZ","sS","bB",".:",",;", +"<>" +}; + /*** Israelian keyboard layout (setxkbmap us,il) */ static const char main_key_IL[MAIN_LEN][4] = { @@ -948,6 +958,7 @@ static const struct { {0x0427, "Lithuanian (Baltic) keyboard layout", &main_key_LT_B, &main_key_scan_qwerty, &main_key_vkey_qwerty}, {0x041f, "Turkish keyboard layout", &main_key_TK, &main_key_scan_qwerty, &main_key_vkey_qwerty}, {0x041f, "Turkish keyboard layout tr", &main_key_TR, &main_key_scan_qwerty, &main_key_vkey_qwerty}, + {0x041f, "Turkish keyboard layout trf", &main_key_TR_F, &main_key_scan_qwerty, &main_key_vkey_qwerty}, {0x040d, "Israelian keyboard layout", &main_key_IL, &main_key_scan_qwerty, &main_key_vkey_qwerty}, {0x040d, "Israelian phonetic keyboard layout", &main_key_IL_phonetic, &main_key_scan_qwerty, &main_key_vkey_qwerty}, {0x040d, "Israelian Saharon keyboard layout", &main_key_IL_saharon, &main_key_scan_qwerty, &main_key_vkey_qwerty},

1 0

Juan Lang : crypt32: Implement CertRDNValueToStrA and CertNameToStrA, with tests.
by Alexandre Julliard 01 Feb '06

01 Feb '06

Module: wine Branch: refs/heads/master Commit: 6a3b3f8635669ddf6fdae8d2d6a1b7c1a9ab3771 URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=6a3b3f8635669ddf6fdae8d… Author: Juan Lang <juan(a)codeweavers.com> Date: Wed Feb 1 13:50:18 2006 +0100 crypt32: Implement CertRDNValueToStrA and CertNameToStrA, with tests. --- dlls/crypt32/Makefile.in | 1 dlls/crypt32/crypt32.spec | 8 + dlls/crypt32/str.c | 176 +++++++++++++++++++++++++++++ dlls/crypt32/tests/.gitignore | 1 dlls/crypt32/tests/Makefile.in | 3 dlls/crypt32/tests/str.c | 245 ++++++++++++++++++++++++++++++++++++++++ 6 files changed, 429 insertions(+), 5 deletions(-) create mode 100644 dlls/crypt32/str.c create mode 100644 dlls/crypt32/tests/str.c Diff: http://source.winehq.org/git/?p=wine.git;a=commitdiff;h=6a3b3f8635669ddf6fd…

1 0

Kevin Koltzau : riched20: Implement EM_SETOLECALLBACK.
by Alexandre Julliard 01 Feb '06

01 Feb '06

Module: wine Branch: refs/heads/master Commit: 7f84cc48f3c6b12cc64416a28e35577e3db405df URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=7f84cc48f3c6b12cc64416a… Author: Kevin Koltzau <kevin(a)plop.org> Date: Wed Feb 1 13:05:40 2006 +0100 riched20: Implement EM_SETOLECALLBACK. --- dlls/riched20/editor.c | 13 ++++++++++--- dlls/riched20/editstr.h | 4 ++++ 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/dlls/riched20/editor.c b/dlls/riched20/editor.c index 19c7b3f..9b741a8 100644 --- a/dlls/riched20/editor.c +++ b/dlls/riched20/editor.c @@ -223,8 +223,6 @@ #include "editor.h" #include "commdlg.h" -#include "ole2.h" -#include "richole.h" #include "winreg.h" #define NO_SHLWAPI_STREAM #include "shlwapi.h" @@ -889,6 +887,7 @@ ME_TextEditor *ME_MakeEditor(HWND hWnd) ed->bRedraw = TRUE; ed->nInvalidOfs = -1; ed->pfnWordBreak = NULL; + ed->lpOleCallback = NULL; GetClientRect(hWnd, &ed->rcFormat); for (i=0; i<HFONT_CACHE_SIZE; i++) { @@ -985,6 +984,8 @@ void ME_DestroyEditor(ME_TextEditor *edi DeleteObject(editor->pFontCache[i].hFont); } DeleteObject(editor->hbrBackground); + if(editor->lpOleCallback) + IUnknown_Release(editor->lpOleCallback); FREE_OBJ(editor); } @@ -1206,7 +1207,6 @@ LRESULT WINAPI RichEditANSIWndProc(HWND UNSUPPORTED_MSG(EM_SETEDITSTYLE) UNSUPPORTED_MSG(EM_SETFONTSIZE) UNSUPPORTED_MSG(EM_SETLANGOPTIONS) - UNSUPPORTED_MSG(EM_SETOLECALLBACK) UNSUPPORTED_MSG(EM_SETOPTIONS) UNSUPPORTED_MSG(EM_SETPALETTE) UNSUPPORTED_MSG(EM_SETPASSWORDCHAR) @@ -2043,6 +2043,13 @@ LRESULT WINAPI RichEditANSIWndProc(HWND FIXME("EM_GETOLEINTERFACE %p: stub\n", ppvObj); return CreateIRichEditOle(ppvObj); } + case EM_SETOLECALLBACK: + if(editor->lpOleCallback) + IUnknown_Release(editor->lpOleCallback); + editor->lpOleCallback = (LPRICHEDITOLECALLBACK)lParam; + if(editor->lpOleCallback) + IUnknown_AddRef(editor->lpOleCallback); + return TRUE; case EM_GETWORDBREAKPROC: return (LRESULT)editor->pfnWordBreak; case EM_SETWORDBREAKPROC: diff --git a/dlls/riched20/editstr.h b/dlls/riched20/editstr.h index 919dd02..d27eab9 100644 --- a/dlls/riched20/editstr.h +++ b/dlls/riched20/editstr.h @@ -38,6 +38,9 @@ #include <winuser.h> #include <richedit.h> #include <commctrl.h> +#define COBJMACROS +#include <ole2.h> +#include <richole.h> #include "wine/debug.h" @@ -289,6 +292,7 @@ typedef struct tagME_TextEditor BOOL bRedraw; int nInvalidOfs; EDITWORDBREAKPROCW pfnWordBreak; + LPRICHEDITOLECALLBACK lpOleCallback; } ME_TextEditor; typedef struct tagME_Context

1 0

Dmitry Timoshkov : wine.inf: Remove %1 from [http|htmlfile]\shell\open\command.
by Alexandre Julliard 01 Feb '06

01 Feb '06

Module: wine Branch: refs/heads/master Commit: f03c86a27387cd1dc27c371d52a7c72d83b70481 URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=f03c86a27387cd1dc27c371… Author: Dmitry Timoshkov <dmitry(a)codeweavers.com> Date: Wed Feb 1 12:32:21 2006 +0100 wine.inf: Remove %1 from [http|htmlfile]\shell\open\command. --- tools/wine.inf | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/wine.inf b/tools/wine.inf index 5b6e8d6..8a81989 100644 --- a/tools/wine.inf +++ b/tools/wine.inf @@ -97,7 +97,7 @@ HKCR,exefile\shell\open\command,,,"""%1" HKCR,folder\shell\open\ddeexec,,,"[ViewFolder("%l", %I, %S)]" HKCR,folder\shell\open\ddeexec,"NoActivateHandler",,"" HKCR,folder\shell\open\ddeexec\application,,,"Folders" -HKCR,htmlfile\shell\open\command,,,"winebrowser %1" +HKCR,htmlfile\shell\open\command,,,"winebrowser" HKCR,lnkfile,"NeverShowExt",,"" HKCR,lnkfile,"IsShortcut",,"yes" HKCR,lnkfile\CLSID,,,"{00021401-0000-0000-C000-000000000046}" @@ -109,7 +109,7 @@ HKCR,Msi.Package\shell\Repair\command,,, HKCR,Msi.Package\shell\Uninstall\command,,,"msiexec /x %1" HKCR,txtfile\shell\open\command,,,"%11%\notepad.exe %1" HKCR,txtfile\shell\print\command,,,"%11%\notepad.exe /p %1" -HKCR,http\shell\open\command,,,"winebrowser %1" +HKCR,http\shell\open\command,,,"winebrowser" HKCR,mailto\shell\open\command,,,"winebrowser %1" ; FIXME: the following should be done by the dll registration HKCR,AVIFile\Compressors\auds,,,"{0002000F-0000-0000-C000-000000000046}"

1 0

Detlef Riekenberg : winspool: Empty string as environment is valid, with tests.
by Alexandre Julliard 01 Feb '06

01 Feb '06

Module: wine Branch: refs/heads/master Commit: 366f452b91e9399217e90a3a441aa91e50fd4c61 URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=366f452b91e9399217e90a3… Author: Detlef Riekenberg <wine.dev(a)web.de> Date: Wed Feb 1 12:32:10 2006 +0100 winspool: Empty string as environment is valid, with tests. --- dlls/winspool/info.c | 9 ++++----- dlls/winspool/tests/info.c | 28 +++++++++++++++++++++------- 2 files changed, 25 insertions(+), 12 deletions(-) diff --git a/dlls/winspool/info.c b/dlls/winspool/info.c index d0f51aa..15f0c48 100644 --- a/dlls/winspool/info.c +++ b/dlls/winspool/info.c @@ -204,6 +204,7 @@ static DWORD WINSPOOL_GetOpenedPrinterRe * Success: PTR to printenv_t * * NOTES + * An empty string is handled the same way as NULL. * SetLastEror(ERROR_INVALID_ENVIRONMENT) is called on Failure * */ @@ -218,7 +219,7 @@ static const printenv_t * validate_envW unsigned int i; TRACE("testing %s\n", debugstr_w(env)); - if (env) + if (env && env[0]) { for (i = 0; i < sizeof(all_printenv)/sizeof(all_printenv[0]); i++) { @@ -3399,9 +3400,7 @@ BOOL WINAPI GetPrinterDriverW(HANDLE hPr * "%winsysdir%" is the Value from GetSystemDirectoryW() * * FIXME - *- pName != NULL not supported - *- pEnvironment != NULL not supported - *- Current Implementation returns always "%winsysdir%" + *- Only NULL or "" is supported for pName * */ BOOL WINAPI GetPrinterDriverDirectoryW(LPWSTR pName, LPWSTR pEnvironment, @@ -3413,7 +3412,7 @@ BOOL WINAPI GetPrinterDriverDirectoryW(L TRACE("(%s, %s, %ld, %p, %ld, %p)\n", debugstr_w(pName), debugstr_w(pEnvironment), Level, pDriverDirectory, cbBuf, pcbNeeded); - if(pName != NULL) { + if(pName != NULL && pName[0]) { FIXME("pName unsupported: %s\n", debugstr_w(pName)); SetLastError(ERROR_INVALID_PARAMETER); return FALSE; diff --git a/dlls/winspool/tests/info.c b/dlls/winspool/tests/info.c index 4b11829..8041f5c 100644 --- a/dlls/winspool/tests/info.c +++ b/dlls/winspool/tests/info.c @@ -94,7 +94,7 @@ static LPSTR find_default_printer(VOID) } -static void test_default_printer(void) +static void test_GetDefaultPrinter(void) { BOOL retval; DWORD exact = DEFAULT_PRINTER_SIZE; @@ -171,8 +171,9 @@ static void test_default_printer(void) exact, size); } -static void test_printer_directory(void) -{ LPBYTE buffer = NULL; +static void test_GetPrinterDriverDirectory(void) +{ + LPBYTE buffer = NULL; DWORD cbBuf = 0, pcbNeeded = 0; BOOL res; @@ -305,10 +306,23 @@ static void test_printer_directory(void) "'len > 0' or '0' with ERROR_INVALID_ENVIRONMENT)\n", res, GetLastError(), lstrlenA((char *)buffer)); + /* A Setup-Programm (PDFCreator_0.8.0) use empty strings */ + SetLastError(MAGIC_DEAD); + res = GetPrinterDriverDirectoryA("", "", 1, buffer, cbBuf*2, &pcbNeeded); + ok(res, "returned %d with %ld (expected '!=0')\n", res, GetLastError() ); + + SetLastError(MAGIC_DEAD); + res = GetPrinterDriverDirectoryA(NULL, "", 1, buffer, cbBuf*2, &pcbNeeded); + ok(res, "returned %d with %ld (expected '!=0')\n", res, GetLastError() ); + + SetLastError(MAGIC_DEAD); + res = GetPrinterDriverDirectoryA("", NULL, 1, buffer, cbBuf*2, &pcbNeeded); + ok(res, "returned %d with %ld (expected '!=0')\n", res, GetLastError() ); + HeapFree( GetProcessHeap(), 0, buffer); } -static void test_openprinter(void) +static void test_OpenPrinter(void) { PRINTER_DEFAULTSA defaults; HANDLE hprinter; @@ -458,7 +472,7 @@ START_TEST(info) find_default_printer(); - test_default_printer(); - test_printer_directory(); - test_openprinter(); + test_GetDefaultPrinter(); + test_GetPrinterDriverDirectory(); + test_OpenPrinter(); }

1 0

Phil Krylov : riched20: Fixed font cache corruption.
by Alexandre Julliard 01 Feb '06

01 Feb '06

Module: wine Branch: refs/heads/master Commit: 1db48180f2bb36901a6a05d86f0f0d00e70c538e URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=1db48180f2bb36901a6a05d… Author: Phil Krylov <phil(a)newstar.rinet.ru> Date: Wed Feb 1 12:30:26 2006 +0100 riched20: Fixed font cache corruption. --- dlls/riched20/style.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/riched20/style.c b/dlls/riched20/style.c index 56f9842..804cc16 100644 --- a/dlls/riched20/style.c +++ b/dlls/riched20/style.c @@ -317,7 +317,7 @@ HFONT ME_SelectStyleFont(ME_TextEditor * if (item->nAge > nAge) nEmpty = i, nAge = item->nAge; } - if (ME_IsFontEqual(&item->lfSpecs, &lf)) + if (item->hFont && ME_IsFontEqual(&item->lfSpecs, &lf)) break; } if (i < HFONT_CACHE_SIZE) /* found */ @@ -372,7 +372,7 @@ void ME_UnselectStyleFont(ME_TextEditor assert(0 == "UnselectStyleFont without SelectStyleFont"); } -void ME_DestroyStyle(ME_Style *s) { +static void ME_DestroyStyle(ME_Style *s) { if (s->hFont) { DeleteObject(s->hFont);

1 0