April 2006 - Wine-commits - list.winehq.org

Mike McCormack : rpcrt4: Stub implementation for rpcrt4. RpcMgmtEpEltInqBegin().
by Alexandre Julliard 19 Apr '06

19 Apr '06

Module: wine Branch: refs/heads/master Commit: a0f8623e2e4551214df4ac044210051833dcdae1 URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=a0f8623e2e4551214df4ac0… Author: Mike McCormack <mike(a)codeweavers.com> Date: Wed Apr 19 17:25:21 2006 +0900 rpcrt4: Stub implementation for rpcrt4.RpcMgmtEpEltInqBegin(). --- dlls/rpcrt4/rpc_server.c | 14 ++++++++++++++ dlls/rpcrt4/rpcrt4.spec | 2 +- include/rpcdce.h | 17 +++++++++++++++++ 3 files changed, 32 insertions(+), 1 deletions(-) diff --git a/dlls/rpcrt4/rpc_server.c b/dlls/rpcrt4/rpc_server.c index 45d0dff..d8eaa6b 100644 --- a/dlls/rpcrt4/rpc_server.c +++ b/dlls/rpcrt4/rpc_server.c @@ -1051,8 +1051,22 @@ UINT WINAPI I_RpcWindowProc( void *hWnd, return 0; } +/*********************************************************************** + * RpcMgmtInqIfIds (RPCRT4.@) + */ RPC_STATUS WINAPI RpcMgmtInqIfIds(RPC_BINDING_HANDLE Binding, RPC_IF_ID_VECTOR **IfIdVector) { FIXME("(%p,%p): stub\n", Binding, IfIdVector); return RPC_S_INVALID_BINDING; } + +/*********************************************************************** + * RpcMgmtEpEltInqBegin (RPCRT4.@) + */ +RPC_STATUS WINAPI RpcMgmtEpEltInqBegin(RPC_BINDING_HANDLE Binding, unsigned long InquiryType, + RPC_IF_ID *IfId, unsigned long VersOption, UUID *ObjectUuid, RPC_EP_INQ_HANDLE* InquiryContext) +{ + FIXME("(%p,%lu,%p,%lu,%p,%p): stub\n", + Binding, InquiryType, IfId, VersOption, ObjectUuid, InquiryContext); + return RPC_S_INVALID_BINDING; +} diff --git a/dlls/rpcrt4/rpcrt4.spec b/dlls/rpcrt4/rpcrt4.spec index d5d8f52..d2618a9 100644 --- a/dlls/rpcrt4/rpcrt4.spec +++ b/dlls/rpcrt4/rpcrt4.spec @@ -424,7 +424,7 @@ # 9x version of I_RpcBindingSetAsync has @ stub RpcMgmtBindingInqParameter # win9x @ stub RpcMgmtBindingSetParameter # win9x @ stub RpcMgmtEnableIdleCleanup -@ stub RpcMgmtEpEltInqBegin +@ stdcall RpcMgmtEpEltInqBegin(ptr long ptr long ptr ptr) @ stub RpcMgmtEpEltInqDone @ stub RpcMgmtEpEltInqNextA @ stub RpcMgmtEpEltInqNextW diff --git a/include/rpcdce.h b/include/rpcdce.h index 77a5c2f..68cc7ad 100644 --- a/include/rpcdce.h +++ b/include/rpcdce.h @@ -77,6 +77,19 @@ typedef struct RPC_IF_ID *IfId[1]; } RPC_IF_ID_VECTOR; +typedef I_RPC_HANDLE *RPC_EP_INQ_HANDLE; + +#define RPC_C_EP_ALL_ELTS 0 +#define RPC_C_EP_MATCH_BY_IF 1 +#define RPC_C_EP_MATCH_BY_OBJ 2 +#define RPC_C_EP_MATCH_BY_BOTH 3 + +#define RPC_C_VERS_ALL 1 +#define RPC_C_VERS_COMPATIBLE 2 +#define RPC_C_VERS_EXACT 3 +#define RPC_C_VERS_MAJOR_ONLY 4 +#define RPC_C_VERS_UPTO 5 + #define RPC_C_BINDING_INFINITE_TIMEOUT 10 #define RPC_C_BINDING_MIN_TIMEOUT 0 #define RPC_C_BINDING_DEFAULT_TIMEOUT 5 @@ -241,6 +254,10 @@ RPCRTAPI RPC_STATUS RPC_ENTRY RpcMgmtInqIfIds( RPC_BINDING_HANDLE Binding, RPC_IF_ID_VECTOR** IfIdVector ); RPCRTAPI RPC_STATUS RPC_ENTRY + RpcMgmtEpEltInqBegin( RPC_BINDING_HANDLE EpBinding, unsigned long InquiryType, RPC_IF_ID *IfId, + unsigned long VersOption, UUID *ObjectUuid, RPC_EP_INQ_HANDLE *InquiryContext); + +RPCRTAPI RPC_STATUS RPC_ENTRY RpcServerRegisterIf( RPC_IF_HANDLE IfSpec, UUID* MgrTypeUuid, RPC_MGR_EPV* MgrEpv ); RPCRTAPI RPC_STATUS RPC_ENTRY

1 0

James Hawkins : advpack: Put function declarations in advpack_private.h.
by Alexandre Julliard 19 Apr '06

19 Apr '06

Module: wine Branch: refs/heads/master Commit: b2a3ffd893413726cdff14df5c6dac2360b4ecf2 URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=b2a3ffd893413726cdff14d… Author: James Hawkins <truiken(a)gmail.com> Date: Tue Apr 18 16:13:26 2006 -0500 advpack: Put function declarations in advpack_private.h. --- dlls/advpack/advpack.c | 3 +-- dlls/advpack/advpack_private.h | 29 +++++++++++++++++++++++++++++ dlls/advpack/files.c | 3 +-- dlls/advpack/install.c | 1 + 4 files changed, 32 insertions(+), 4 deletions(-) create mode 100644 dlls/advpack/advpack_private.h diff --git a/dlls/advpack/advpack.c b/dlls/advpack/advpack.c index f68ab2b..297dfca 100644 --- a/dlls/advpack/advpack.c +++ b/dlls/advpack/advpack.c @@ -32,6 +32,7 @@ #include "setupapi.h" #include "advpub.h" #include "wine/unicode.h" #include "wine/debug.h" +#include "advpack_private.h" WINE_DEFAULT_DEBUG_CHANNEL(advpack); @@ -40,8 +41,6 @@ typedef HRESULT (WINAPI *DLLREGISTER) (v #define MAX_FIELD_LENGTH 512 #define PREFIX_LEN 5 -HRESULT launch_exe(LPCWSTR cmd, LPCWSTR dir, HANDLE *phEXE); - /* registry path of the Installed Components key for per-user stubs */ static const WCHAR setup_key[] = { 'S','O','F','T','W','A','R','E','\\', diff --git a/dlls/advpack/advpack_private.h b/dlls/advpack/advpack_private.h new file mode 100644 index 0000000..a36b32b --- /dev/null +++ b/dlls/advpack/advpack_private.h @@ -0,0 +1,29 @@ +/* + * Advpack private header + * + * Copyright 2006 James Hawkins + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + */ + +#ifndef __ADVPACK_PRIVATE_H +#define __ADVPACK_PRIVATE_H + +LPWSTR get_parameter(LPWSTR *params, WCHAR separator); + +HRESULT launch_exe(LPCWSTR cmd, LPCWSTR dir, HANDLE *phEXE); +HRESULT do_ocx_reg(HMODULE hocx, BOOL do_reg); + +#endif /* __ADVPACK_PRIVATE_H */ diff --git a/dlls/advpack/files.c b/dlls/advpack/files.c index 90ba6cd..7e0706e 100644 --- a/dlls/advpack/files.c +++ b/dlls/advpack/files.c @@ -31,11 +31,10 @@ #include "setupapi.h" #include "advpub.h" #include "wine/debug.h" #include "wine/unicode.h" +#include "advpack_private.h" WINE_DEFAULT_DEBUG_CHANNEL(advpack); -LPWSTR get_parameter(LPWSTR *params, WCHAR separator); - /* converts an ansi double null-terminated list to a unicode list */ static LPWSTR ansi_to_unicode_list(LPCSTR ansi_list) { diff --git a/dlls/advpack/install.c b/dlls/advpack/install.c index aeae7cd..eeffa9e 100644 --- a/dlls/advpack/install.c +++ b/dlls/advpack/install.c @@ -32,6 +32,7 @@ #include "setupapi.h" #include "advpub.h" #include "wine/debug.h" #include "wine/unicode.h" +#include "advpack_private.h" WINE_DEFAULT_DEBUG_CHANNEL(advpack);

1 0

Huw Davies : gdi32: Fix {Bit,Stretch}Blt fallbacks to StretchDIBits.
by Alexandre Julliard 18 Apr '06

18 Apr '06

Module: wine Branch: refs/heads/master Commit: bf23ad0da7430afe69d2aff2a2b0549c05458db9 URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=bf23ad0da7430afe69d2aff… Author: Huw Davies <huw(a)codeweavers.com> Date: Tue Apr 18 20:00:13 2006 +0100 gdi32: Fix {Bit,Stretch}Blt fallbacks to StretchDIBits. --- dlls/gdi/bitblt.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dlls/gdi/bitblt.c b/dlls/gdi/bitblt.c index 221fc6d..25053e6 100644 --- a/dlls/gdi/bitblt.c +++ b/dlls/gdi/bitblt.c @@ -108,8 +108,8 @@ BOOL WINAPI BitBlt( HDC hdcDst, INT xDst GetDIBits(hdcSrc, hbm, 0, bm.bmHeight, bits, (BITMAPINFO*)&info_hdr, DIB_RGB_COLORS); SelectObject(hdcSrc, hbm); - lines = StretchDIBits(hdcDst, xDst, yDst, width, height, xSrc, ySrc, width, height, - bits, (BITMAPINFO*)&info_hdr, DIB_RGB_COLORS, rop); + lines = StretchDIBits(hdcDst, xDst, yDst, width, height, xSrc, bm.bmHeight - height - ySrc, + width, height, bits, (BITMAPINFO*)&info_hdr, DIB_RGB_COLORS, rop); HeapFree(GetProcessHeap(), 0, bits); return (lines == bm.bmHeight); @@ -186,8 +186,8 @@ BOOL WINAPI StretchBlt( HDC hdcDst, INT GetDIBits(hdcSrc, hbm, 0, bm.bmHeight, bits, (BITMAPINFO*)&info_hdr, DIB_RGB_COLORS); SelectObject(hdcSrc, hbm); - lines = StretchDIBits(hdcDst, xDst, yDst, widthDst, heightDst, xSrc, ySrc, widthSrc, heightSrc, - bits, (BITMAPINFO*)&info_hdr, DIB_RGB_COLORS, rop); + lines = StretchDIBits(hdcDst, xDst, yDst, widthDst, heightDst, xSrc, bm.bmHeight - heightSrc - ySrc, + widthSrc, heightSrc, bits, (BITMAPINFO*)&info_hdr, DIB_RGB_COLORS, rop); HeapFree(GetProcessHeap(), 0, bits); return (lines == bm.bmHeight);

1 0

Mikołaj Zalewski : comctl32: header: Remove the unused bUnicode.
by Alexandre Julliard 18 Apr '06

18 Apr '06

Module: wine Branch: refs/heads/master Commit: a49da0b719740f48f30b69602d2bced4cb8154a0 URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=a49da0b719740f48f30b696… Author: Mikołaj Zalewski <mikolaj(a)zalewski.pl> Date: Tue Apr 18 19:45:29 2006 +0200 comctl32: header: Remove the unused bUnicode. --- dlls/comctl32/header.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/dlls/comctl32/header.c b/dlls/comctl32/header.c index d80441b..9f856cf 100644 --- a/dlls/comctl32/header.c +++ b/dlls/comctl32/header.c @@ -77,7 +77,6 @@ typedef struct BOOL bCaptured; /* Is the mouse captured? */ BOOL bPressed; /* Is a header item pressed (down)? */ BOOL bTracking; /* Is in tracking mode? */ - BOOL bUnicode; /* Unicode flag */ INT iMoveItem; /* index of tracked item. (Tracking mode) */ INT xTrackOffset; /* distance between the right side of the tracked item and the cursor */ INT xOldTrack; /* track offset (see above) after the last WM_MOUSEMOVE */ @@ -170,7 +169,7 @@ HEADER_DrawItem (HWND hwnd, HDC hdc, INT HTHEME theme = GetWindowTheme (hwnd); NMCUSTOMDRAW nmcd; - TRACE("DrawItem(iItem %d bHotTrack %d unicode flag %d)\n", iItem, bHotTrack, infoPtr->bUnicode); + TRACE("DrawItem(iItem %d bHotTrack %d unicode flag %d)\n", iItem, bHotTrack, (infoPtr->nNotifyFormat == NFR_UNICODE)); if (!infoPtr->bRectsValid) HEADER_SetItemBounds(hwnd); @@ -1292,7 +1291,6 @@ HEADER_Create (HWND hwnd, WPARAM wParam, infoPtr->iMoveItem = 0; infoPtr->himl = 0; infoPtr->iHotItem = -1; - infoPtr->bUnicode = IsWindowUnicode (hwnd); infoPtr->iMargin = 3*GetSystemMetrics(SM_CXEDGE); infoPtr->nNotifyFormat = SendMessageW (infoPtr->hwndNotify, WM_NOTIFYFORMAT, (WPARAM)hwnd, NF_QUERY);

1 0

Mikołaj Zalewski : comctl32: header: Correct WM_[GS] ETUNICODEFORMAT.
by Alexandre Julliard 18 Apr '06

18 Apr '06

Module: wine Branch: refs/heads/master Commit: 7a7f80e9d100bb3e7837c7cac8b45740c16098a1 URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=7a7f80e9d100bb3e7837c7c… Author: Mikołaj Zalewski <mikolaj(a)zalewski.pl> Date: Tue Apr 18 19:44:09 2006 +0200 comctl32: header: Correct WM_[GS]ETUNICODEFORMAT. --- dlls/comctl32/header.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/comctl32/header.c b/dlls/comctl32/header.c index ed235e8..d80441b 100644 --- a/dlls/comctl32/header.c +++ b/dlls/comctl32/header.c @@ -947,7 +947,7 @@ inline static LRESULT HEADER_GetUnicodeFormat (HWND hwnd) { HEADER_INFO *infoPtr = HEADER_GetInfoPtr (hwnd); - return infoPtr->bUnicode; + return (infoPtr->nNotifyFormat == NFR_UNICODE); } @@ -1259,9 +1259,9 @@ inline static LRESULT HEADER_SetUnicodeFormat (HWND hwnd, WPARAM wParam) { HEADER_INFO *infoPtr = HEADER_GetInfoPtr (hwnd); - BOOL bTemp = infoPtr->bUnicode; + BOOL bTemp = (infoPtr->nNotifyFormat == NFR_UNICODE); - infoPtr->bUnicode = (BOOL)wParam; + infoPtr->nNotifyFormat = ((BOOL)wParam ? NFR_UNICODE : NFR_ANSI); return bTemp; }

1 0

Mike McCormack : msi: Clean up memset usage.
by Alexandre Julliard 18 Apr '06

18 Apr '06

Module: wine Branch: refs/heads/master Commit: 3a94011ab65fc87dc7f8d6788bfec4bc4d6c3d7f URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=3a94011ab65fc87dc7f8d67… Author: Mike McCormack <mike(a)codeweavers.com> Date: Wed Apr 19 02:29:03 2006 +0900 msi: Clean up memset usage. --- dlls/msi/action.c | 11 ++++------- dlls/msi/classes.c | 3 +-- dlls/msi/msi.c | 22 +++++++++++----------- 3 files changed, 16 insertions(+), 20 deletions(-) diff --git a/dlls/msi/action.c b/dlls/msi/action.c index 66d75f9..270e9ae 100644 --- a/dlls/msi/action.c +++ b/dlls/msi/action.c @@ -573,8 +573,7 @@ UINT MSI_InstallPackage( MSIPACKAGE *pac MSI_SetPropertyW(package, szAction, szInstall); - package->script = msi_alloc(sizeof(MSISCRIPT)); - memset(package->script,0,sizeof(MSISCRIPT)); + package->script = msi_alloc_zero(sizeof(MSISCRIPT)); package->script->InWhatSequence = SEQUENCE_INSTALL; @@ -3383,7 +3382,7 @@ static UINT ACTION_PublishFeatures(MSIPA MSICOMPONENT* component = cl->component; WCHAR buf[21]; - memset(buf,0,sizeof(buf)); + buf[0] = 0; if (component->ComponentId) { TRACE("From %s\n",debugstr_w(component->ComponentId)); @@ -3914,8 +3913,7 @@ static LPWSTR load_ttfname_from(LPCWSTR ttRecord.uStringOffset + ttNTHeader.uStorageOffset, NULL, FILE_BEGIN); - buf = msi_alloc( ttRecord.uStringLength + 1 + strlen(tt) ); - memset(buf, 0, ttRecord.uStringLength + 1 + strlen(tt)); + buf = msi_alloc_zero( ttRecord.uStringLength + 1 + strlen(tt) ); ReadFile(handle, buf, ttRecord.uStringLength, &dwRead, NULL); if (strlen(buf) > 0) { @@ -4080,8 +4078,7 @@ static UINT ITERATE_PublishComponent(MSI sz+=3; sz *= sizeof(WCHAR); - output = msi_alloc(sz); - memset(output,0,sz); + output = msi_alloc_zero(sz); strcpyW(output,advertise); msi_free(advertise); diff --git a/dlls/msi/classes.c b/dlls/msi/classes.c index 45bd616..743ac86 100644 --- a/dlls/msi/classes.c +++ b/dlls/msi/classes.c @@ -1160,8 +1160,7 @@ static UINT register_verb(MSIPACKAGE *pa size += strlenW(verb->Argument); size += 4; - command = msi_alloc(size * sizeof (WCHAR)); - memset(command,0,size*sizeof(WCHAR)); + command = msi_alloc_zero(size * sizeof (WCHAR)); strcpyW(command,advertise); if (verb->Argument) diff --git a/dlls/msi/msi.c b/dlls/msi/msi.c index b2038a1..1c22ac3 100644 --- a/dlls/msi/msi.c +++ b/dlls/msi/msi.c @@ -1891,29 +1891,29 @@ UINT WINAPI MsiReinstallFeatureW( LPCWST FIXME("%s %s %li\n", debugstr_w(szProduct), debugstr_w(szFeature), dwReinstallMode); - memset(reinstallmode,0,sizeof(reinstallmode)); ptr = reinstallmode; if (dwReinstallMode & REINSTALLMODE_FILEMISSING) - { *ptr = 'p'; ptr++; } + *ptr++ = 'p'; if (dwReinstallMode & REINSTALLMODE_FILEOLDERVERSION) - { *ptr = 'o'; ptr++; } + *ptr++ = 'o'; if (dwReinstallMode & REINSTALLMODE_FILEEQUALVERSION) - { *ptr = 'w'; ptr++; } + *ptr++ = 'w'; if (dwReinstallMode & REINSTALLMODE_FILEEXACT) - { *ptr = 'd'; ptr++; } + *ptr++ = 'd'; if (dwReinstallMode & REINSTALLMODE_FILEVERIFY) - { *ptr = 'c'; ptr++; } + *ptr++ = 'c'; if (dwReinstallMode & REINSTALLMODE_FILEREPLACE) - { *ptr = 'a'; ptr++; } + *ptr++ = 'a'; if (dwReinstallMode & REINSTALLMODE_USERDATA) - { *ptr = 'u'; ptr++; } + *ptr++ = 'u'; if (dwReinstallMode & REINSTALLMODE_MACHINEDATA) - { *ptr = 'm'; ptr++; } + *ptr++ = 'm'; if (dwReinstallMode & REINSTALLMODE_SHORTCUT) - { *ptr = 's'; ptr++; } + *ptr++ = 's'; if (dwReinstallMode & REINSTALLMODE_PACKAGE) - { *ptr = 'v'; ptr++; } + *ptr++ = 'v'; + *ptr = 0; sz = sizeof(sourcepath); MsiSourceListGetInfoW(szProduct, NULL, MSIINSTALLCONTEXT_USERMANAGED,

1 0

Mike McCormack : msi: Fix a regression caused by some bad logic.
by Alexandre Julliard 18 Apr '06

18 Apr '06

Module: wine Branch: refs/heads/master Commit: edb58a6d0588b05307d187ae4155224d72814be6 URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=edb58a6d0588b05307d187a… Author: Mike McCormack <mike(a)codeweavers.com> Date: Wed Apr 19 02:29:33 2006 +0900 msi: Fix a regression caused by some bad logic. --- dlls/msi/classes.c | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/dlls/msi/classes.c b/dlls/msi/classes.c index 75a0ffa..45bd616 100644 --- a/dlls/msi/classes.c +++ b/dlls/msi/classes.c @@ -832,7 +832,6 @@ UINT ACTION_RegisterClassInfo(MSIPACKAGE static const WCHAR szInprocServer32[] = {'I','n','p','r','o','c','S','e','r','v','e','r','3','2',0}; static const WCHAR szFileType_fmt[] = {'F','i','l','e','T','y','p','e','\\','%','s','\\','%','i',0}; HKEY hkey,hkey2,hkey3; - BOOL install_on_demand = FALSE; MSICLASS *cls; load_classes_and_such(package); @@ -863,9 +862,9 @@ UINT ACTION_RegisterClassInfo(MSIPACKAGE * yes. MSDN says that these are based on _Feature_ not on * Component. So verify the feature is to be installed */ - if (!ACTION_VerifyFeatureForAction( feature, INSTALLSTATE_LOCAL ) || - !(install_on_demand && - ACTION_VerifyFeatureForAction( feature, INSTALLSTATE_ADVERTISED ))) + if (!ACTION_VerifyFeatureForAction( feature, INSTALLSTATE_LOCAL )) + /* && !(install_on_demand && + ACTION_VerifyFeatureForAction( feature, INSTALLSTATE_ADVERTISED ))) */ { TRACE("Skipping class %s reg due to disabled feature %s\n", debugstr_w(cls->clsid),

1 0

Mike McCormack : msi: Don't fall back to the folder' s parent if the folder doesn't exist.
by Alexandre Julliard 18 Apr '06

18 Apr '06

Module: wine Branch: refs/heads/master Commit: 1da2fbce95fde8c2fffd099430ce746b9d59c468 URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=1da2fbce95fde8c2fffd099… Author: Mike McCormack <mike(a)codeweavers.com> Date: Wed Apr 19 02:28:05 2006 +0900 msi: Don't fall back to the folder's parent if the folder doesn't exist. --- dlls/msi/helpers.c | 11 ----------- 1 files changed, 0 insertions(+), 11 deletions(-) diff --git a/dlls/msi/helpers.c b/dlls/msi/helpers.c index 9eadcfd..6d3d7e3 100644 --- a/dlls/msi/helpers.c +++ b/dlls/msi/helpers.c @@ -380,17 +380,6 @@ LPWSTR resolve_folder(MSIPACKAGE *packag } } - /* try the parent folder's path */ - if (!path) - { - path = strdupW(p); - if (INVALID_FILE_ATTRIBUTES == GetFileAttributesW( path )) - { - msi_free( path ); - path = NULL; - } - } - /* try the root of the install */ if (!path) path = get_source_root( package );

1 0

Alexandre Julliard : explorer: Reuse drives that point to the same device to avoid memory leaks.
by Alexandre Julliard 18 Apr '06

18 Apr '06

Module: wine Branch: refs/heads/master Commit: 67394207a9af5429758b53bd22ad0dbf6664f433 URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=67394207a9af5429758b53b… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Apr 18 21:12:43 2006 +0200 explorer: Reuse drives that point to the same device to avoid memory leaks. Also print a warning if HAL support is not compiled in. --- programs/explorer/hal.c | 95 ++++++++++++++++++++++++++--------------------- 1 files changed, 53 insertions(+), 42 deletions(-) diff --git a/programs/explorer/hal.c b/programs/explorer/hal.c index e2e7233..f604a8a 100644 --- a/programs/explorer/hal.c +++ b/programs/explorer/hal.c @@ -21,14 +21,11 @@ #include "config.h" #include "wine/port.h" -#ifdef HAVE_LIBHAL - #include <assert.h> #include <errno.h> #include <stdarg.h> +#include <stdio.h> #include <sys/time.h> -#include <dbus/dbus.h> -#include <hal/libhal.h> #include "windef.h" #include "winbase.h" @@ -44,6 +41,11 @@ WINE_DEFAULT_DEBUG_CHANNEL(explorer); +#ifdef HAVE_LIBHAL + +#include <dbus/dbus.h> +#include <hal/libhal.h> + struct dos_drive { struct list entry; @@ -142,7 +144,7 @@ static char *get_dosdevices_path(void) } /* find or create a DOS drive for the corresponding device */ -static int add_drive( const char *device, const char *mount_point, const char *type ) +static int add_drive( const char *device, const char *type ) { char *path, *p; char in_use[26]; @@ -189,7 +191,7 @@ static int add_drive( const char *device { in_use[drive] = 1; if (!S_ISBLK( drive_st.st_mode )) continue; - if (dev_st.st_rdev == drive_st.st_rdev) goto update_mount_point; + if (dev_st.st_rdev == drive_st.st_rdev) goto done; } } if (avail != -1) @@ -197,33 +199,39 @@ static int add_drive( const char *device /* try to use the one we found */ drive = avail; *p = 'a' + drive; - if (symlink( device, path ) != -1) goto update_mount_point; + if (symlink( device, path ) != -1) goto done; /* failed, retry the search */ } } - HeapFree( GetProcessHeap(), 0, path ); - return -1; + drive = -1; -update_mount_point: - p[2] = 0; - unlink( path ); - if (mount_point[0]) symlink( mount_point, path ); - WINE_TRACE( "added drive %c: dev %s at %s\n", - 'a' + drive, wine_dbgstr_a(device), wine_dbgstr_a(mount_point) ); +done: HeapFree( GetProcessHeap(), 0, path ); return drive; } -static void remove_drive( int drive ) +static void set_mount_point( struct dos_drive *drive, const char *mount_point ) { char *path, *p; + struct stat path_st, mnt_st; + if (drive->drive == -1) return; if (!(path = get_dosdevices_path())) return; p = path + strlen(path) - 3; - *p = 'a' + drive; + *p = 'a' + drive->drive; p[2] = 0; - unlink( path ); - /* we keep the device link around in case the device gets mounted again */ + + if (mount_point[0]) + { + /* try to avoid unlinking if already set correctly */ + if (stat( path, &path_st ) == -1 || stat( mount_point, &mnt_st ) == -1 || + path_st.st_dev != mnt_st.st_dev || path_st.st_ino != mnt_st.st_ino) + { + unlink( path ); + symlink( mount_point, path ); + } + } + else unlink( path ); HeapFree( GetProcessHeap(), 0, path ); } @@ -233,6 +241,12 @@ static void add_dos_device( const char * { struct dos_drive *drive; + /* first check if it already exists */ + LIST_FOR_EACH_ENTRY( drive, &drives_list, struct dos_drive, entry ) + { + if (!strcmp( udi, drive->udi )) goto found; + } + if (!(drive = HeapAlloc( GetProcessHeap(), 0, sizeof(*drive) ))) return; if (!(drive->udi = HeapAlloc( GetProcessHeap(), 0, strlen(udi)+1 ))) { @@ -240,24 +254,20 @@ static void add_dos_device( const char * return; } strcpy( drive->udi, udi ); + list_add_tail( &drives_list, &drive->entry ); - drive->drive = add_drive( device, mount_point, type ); - - if (drive->drive == -1) - { - HeapFree( GetProcessHeap(), 0, drive->udi ); - HeapFree( GetProcessHeap(), 0, drive ); - } - else +found: + drive->drive = add_drive( device, type ); + if (drive->drive != -1) { HKEY hkey; + set_mount_point( drive, mount_point ); + WINE_TRACE( "added device %c: udi %s for %s on %s type %s\n", 'a' + drive->drive, wine_dbgstr_a(udi), wine_dbgstr_a(device), wine_dbgstr_a(mount_point), wine_dbgstr_a(type) ); - list_add_tail( &drives_list, &drive->entry ); - /* hack: force the drive type in the registry */ if (!RegCreateKeyA( HKEY_LOCAL_MACHINE, "Software\\Wine\\Drives", &hkey )) { @@ -276,18 +286,21 @@ static void remove_dos_device( struct do { HKEY hkey; - remove_drive( drive->drive ); - - /* clear the registry key too */ - if (!RegOpenKeyA( HKEY_LOCAL_MACHINE, "Software\\Wine\\Drives", &hkey )) + if (drive->drive != -1) { - char name[3] = "a:"; - name[0] += drive->drive; - RegDeleteValueA( hkey, name ); - RegCloseKey( hkey ); - } + set_mount_point( drive, "" ); - send_notify( drive->drive, DBT_DEVICEREMOVECOMPLETE ); + /* clear the registry key too */ + if (!RegOpenKeyA( HKEY_LOCAL_MACHINE, "Software\\Wine\\Drives", &hkey )) + { + char name[3] = "a:"; + name[0] += drive->drive; + RegDeleteValueA( hkey, name ); + RegCloseKey( hkey ); + } + + send_notify( drive->drive, DBT_DEVICEREMOVECOMPLETE ); + } list_remove( &drive->entry ); HeapFree( GetProcessHeap(), 0, drive->udi ); @@ -302,9 +315,6 @@ static void new_device( LibHalContext *c p_dbus_error_init( &error ); - if (!(mount_point = p_libhal_device_get_property_string( ctx, udi, "volume.mount_point", &error ))) - goto done; - if (!(device = p_libhal_device_get_property_string( ctx, udi, "block.device", &error ))) goto done; @@ -433,6 +443,7 @@ void initialize_hal(void) void initialize_hal(void) { + WINE_WARN( "HAL support not compiled in\n" ); } #endif /* HAVE_LIBHAL */

1 0

Alexandre Julliard : winebuild: Disable linking to external symbols by default.
by Alexandre Julliard 18 Apr '06

18 Apr '06

Module: wine Branch: refs/heads/master Commit: 88bf4d61c3588753dd7741b8a851bd4d0f3ccde1 URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=88bf4d61c3588753dd7741b… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Apr 18 20:49:29 2006 +0200 winebuild: Disable linking to external symbols by default. --- tools/winebuild/build.h | 2 ++ tools/winebuild/import.c | 21 +++++++++++++++++++-- tools/winebuild/main.c | 34 +++++++++++++++++++++------------- tools/winebuild/winebuild.man.in | 8 ++++++++ 4 files changed, 50 insertions(+), 15 deletions(-) diff --git a/tools/winebuild/build.h b/tools/winebuild/build.h index c100b2c..a899a1e 100644 --- a/tools/winebuild/build.h +++ b/tools/winebuild/build.h @@ -85,6 +85,7 @@ typedef struct typedef struct { + char *src_name; /* file name of the source spec file */ char *file_name; /* file name of the dll */ char *dll_name; /* internal name of the dll */ char *init_func; /* initialization routine */ @@ -214,6 +215,7 @@ extern int display_warnings; extern int kill_at; extern int verbose; extern int save_temps; +extern int link_ext_symbols; extern char *input_file_name; extern char *spec_file_name; diff --git a/tools/winebuild/import.c b/tools/winebuild/import.c index 7eafe47..7f228e5 100644 --- a/tools/winebuild/import.c +++ b/tools/winebuild/import.c @@ -440,8 +440,25 @@ static void check_undefined_exports( DLL if (odp->flags & FLAG_FORWARD) continue; if (find_name( odp->link_name, &undef_symbols )) { - odp->flags |= FLAG_EXT_LINK; - add_name( &ext_link_imports, odp->link_name ); + switch(odp->type) + { + case TYPE_PASCAL: + case TYPE_STDCALL: + case TYPE_CDECL: + case TYPE_VARARGS: + if (link_ext_symbols) + { + odp->flags |= FLAG_EXT_LINK; + add_name( &ext_link_imports, odp->link_name ); + } + else error( "%s:%d: function '%s' not defined\n", + spec->src_name, odp->lineno, odp->link_name ); + break; + default: + error( "%s:%d: external symbol '%s' is not a function\n", + spec->src_name, odp->lineno, odp->link_name ); + break; + } } } } diff --git a/tools/winebuild/main.c b/tools/winebuild/main.c index 98da643..87625e9 100644 --- a/tools/winebuild/main.c +++ b/tools/winebuild/main.c @@ -47,6 +47,7 @@ int display_warnings = 0; int kill_at = 0; int verbose = 0; int save_temps = 0; +int link_ext_symbols = 0; #ifdef __i386__ enum target_cpu target_cpu = CPU_x86; @@ -246,8 +247,9 @@ static const char usage_str[] = " --as-cmd=AS Command to use for assembling (default: as)\n" " -d, --delay-lib=LIB Import the specified library in delayed mode\n" " -D SYM Ignored for C flags compatibility\n" -" -E, --export=FILE Export the symbols defined in the .spec or .def file\n" " -e, --entry=FUNC Set the DLL entry point function (default: DllMain)\n" +" -E, --export=FILE Export the symbols defined in the .spec or .def file\n" +" --external-symbols Allow linking to external symbols\n" " -f FLAGS Compiler flags (only -fPIC is supported)\n" " -F, --filename=DLLFILE Set the DLL filename (default: from input file name)\n" " -h, --help Display this help message\n" @@ -285,6 +287,7 @@ enum long_options_values LONG_OPT_DEF, LONG_OPT_EXE, LONG_OPT_ASCMD, + LONG_OPT_EXTERNAL_SYMS, LONG_OPT_LDCMD, LONG_OPT_NMCMD, LONG_OPT_RELAY16, @@ -299,18 +302,19 @@ static const char short_options[] = "C:D static const struct option long_options[] = { - { "dll", 0, 0, LONG_OPT_DLL }, - { "def", 0, 0, LONG_OPT_DEF }, - { "exe", 0, 0, LONG_OPT_EXE }, - { "as-cmd", 1, 0, LONG_OPT_ASCMD }, - { "ld-cmd", 1, 0, LONG_OPT_LDCMD }, - { "nm-cmd", 1, 0, LONG_OPT_NMCMD }, - { "relay16", 0, 0, LONG_OPT_RELAY16 }, - { "relay32", 0, 0, LONG_OPT_RELAY32 }, - { "save-temps",0, 0, LONG_OPT_SAVE_TEMPS }, - { "subsystem",1, 0, LONG_OPT_SUBSYSTEM }, - { "target", 1, 0, LONG_OPT_TARGET }, - { "version", 0, 0, LONG_OPT_VERSION }, + { "dll", 0, 0, LONG_OPT_DLL }, + { "def", 0, 0, LONG_OPT_DEF }, + { "exe", 0, 0, LONG_OPT_EXE }, + { "as-cmd", 1, 0, LONG_OPT_ASCMD }, + { "external-symbols", 0, 0, LONG_OPT_EXTERNAL_SYMS }, + { "ld-cmd", 1, 0, LONG_OPT_LDCMD }, + { "nm-cmd", 1, 0, LONG_OPT_NMCMD }, + { "relay16", 0, 0, LONG_OPT_RELAY16 }, + { "relay32", 0, 0, LONG_OPT_RELAY32 }, + { "save-temps", 0, 0, LONG_OPT_SAVE_TEMPS }, + { "subsystem", 1, 0, LONG_OPT_SUBSYSTEM }, + { "target", 1, 0, LONG_OPT_TARGET }, + { "version", 0, 0, LONG_OPT_VERSION }, /* aliases for short options */ { "delay-lib", 1, 0, 'd' }, { "export", 1, 0, 'E' }, @@ -466,6 +470,9 @@ static char **parse_options( int argc, c case LONG_OPT_ASCMD: as_command = xstrdup( optarg ); break; + case LONG_OPT_EXTERNAL_SYMS: + link_ext_symbols = 1; + break; case LONG_OPT_LDCMD: ld_command = xstrdup( optarg ); break; @@ -554,6 +561,7 @@ static int parse_input_file( DLLSPEC *sp char *extension = strrchr( spec_file_name, '.' ); int result; + spec->src_name = xstrdup( input_file_name ); if (extension && !strcmp( extension, ".def" )) result = parse_def_file( input_file, spec ); else diff --git a/tools/winebuild/winebuild.man.in b/tools/winebuild/winebuild.man.in index 78e10a2..3b6d0c7 100644 --- a/tools/winebuild/winebuild.man.in +++ b/tools/winebuild/winebuild.man.in @@ -85,6 +85,14 @@ Specify a .spec file (see \fBSPEC FILE S or a standard Windows .def file that defines the exports of the DLL or executable that is being built. .TP +.B \--external-symbols +Allow linking to external symbols directly from the spec +file. Normally symbols exported by a dll have to be defined in the dll +itself; this option makes it possible to use symbols defined in +another Unix library (for symbols defined in another dll, a +.I forward +specification must be used instead). +.TP .BI \-f\ flags Ignored for compatibility with the C compiler. .TP

1 0