January 2007 - Wine-commits

Reinhard Karcher : ntdll: Fix NtQueryDirectoryFile handling of short names on vfat filesystems.
by Alexandre Julliard 02 Jan '07

02 Jan '07

Module: wine Branch: master Commit: a736ac3f3e00a2355e634de1418df4da485aa015 URL: http://source.winehq.org/git/wine.git/?a=commit;h=a736ac3f3e00a2355e634de14… Author: Reinhard Karcher <rkarcher(a)frey.de> Date: Sat Dec 30 09:36:06 2006 +0100 ntdll: Fix NtQueryDirectoryFile handling of short names on vfat filesystems. --- dlls/ntdll/directory.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/ntdll/directory.c b/dlls/ntdll/directory.c index 3786b91..c0933bc 100644 --- a/dlls/ntdll/directory.c +++ b/dlls/ntdll/directory.c @@ -1513,13 +1513,13 @@ NTSTATUS WINAPI NtQueryDirectoryFile( HA if ((cwd = open(".", O_RDONLY)) != -1 && fchdir( fd ) != -1) { - if (mask && !mempbrkW( mask->Buffer, wszWildcards, mask->Length / sizeof(WCHAR) ) && - read_directory_stat( fd, io, buffer, length, single_entry, mask, restart_scan ) != -1) - goto done; #ifdef VFAT_IOCTL_READDIR_BOTH if ((read_directory_vfat( fd, io, buffer, length, single_entry, mask, restart_scan )) != -1) goto done; #endif + if (mask && !mempbrkW( mask->Buffer, wszWildcards, mask->Length / sizeof(WCHAR) ) && + read_directory_stat( fd, io, buffer, length, single_entry, mask, restart_scan ) != -1) + goto done; #ifdef USE_GETDENTS if ((read_directory_getdents( fd, io, buffer, length, single_entry, mask, restart_scan )) != -1) goto done;

1 0

Dmitry Timoshkov : kernel32: Make the locale test pass without errors under XP SP2.
by Alexandre Julliard 02 Jan '07

02 Jan '07

Module: wine Branch: master Commit: ebd57713aa316a1f7f759cab6d61db557beb807e URL: http://source.winehq.org/git/wine.git/?a=commit;h=ebd57713aa316a1f7f759cab6… Author: Dmitry Timoshkov <dmitry(a)codeweavers.com> Date: Sun Dec 31 21:11:50 2006 +0800 kernel32: Make the locale test pass without errors under XP SP2. --- dlls/kernel32/tests/locale.c | 51 ++++++++++++++++++++++++++++++++---------- 1 files changed, 39 insertions(+), 12 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=ebd57713aa316a1f7f759…

1 0

Paul Vriens : kernel32/tests: Moved ok-statement to the appropriate place.
by Alexandre Julliard 02 Jan '07

02 Jan '07

Module: wine Branch: master Commit: 85b52e5693c5ee6508c06bcbc14f67e091aeb7e3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=85b52e5693c5ee6508c06bcbc… Author: Paul Vriens <paul.vriens.wine(a)gmail.com> Date: Sat Dec 30 20:19:07 2006 +0100 kernel32/tests: Moved ok-statement to the appropriate place. --- dlls/kernel32/tests/thread.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/dlls/kernel32/tests/thread.c b/dlls/kernel32/tests/thread.c index b51bb57..42e649b 100644 --- a/dlls/kernel32/tests/thread.c +++ b/dlls/kernel32/tests/thread.c @@ -469,6 +469,9 @@ static VOID test_thread_priority(void) if (rc==0 && GetLastError()==ERROR_CALL_NOT_IMPLEMENTED) return; /* WinME */ + todo_wine + ok(rc!=0,"error=%d\n",GetLastError()); + /* check that access control is obeyed */ access_thread=pOpenThread(THREAD_ALL_ACCESS & (~THREAD_QUERY_INFORMATION) & (~THREAD_SET_INFORMATION), @@ -481,8 +484,6 @@ static VOID test_thread_priority(void) } todo_wine { - ok(rc!=0,"error=%d\n",GetLastError()); - rc = pSetThreadPriorityBoost(curthread,1); ok( rc != 0, "error=%d\n",GetLastError()); rc=pGetThreadPriorityBoost(curthread,&disabled);

1 0

Paul Vriens : kernel32/tests: Run tests on NT4 again.
by Alexandre Julliard 02 Jan '07

02 Jan '07

Module: wine Branch: master Commit: bafefecaa21725c59fdd5d744c27eafc8c24ac60 URL: http://source.winehq.org/git/wine.git/?a=commit;h=bafefecaa21725c59fdd5d744… Author: Paul Vriens <paul.vriens.wine(a)gmail.com> Date: Sat Dec 30 20:19:24 2006 +0100 kernel32/tests: Run tests on NT4 again. --- dlls/kernel32/tests/thread.c | 18 ++++++++++-------- 1 files changed, 10 insertions(+), 8 deletions(-) diff --git a/dlls/kernel32/tests/thread.c b/dlls/kernel32/tests/thread.c index 42e649b..9e873c4 100644 --- a/dlls/kernel32/tests/thread.c +++ b/dlls/kernel32/tests/thread.c @@ -472,15 +472,17 @@ static VOID test_thread_priority(void) todo_wine ok(rc!=0,"error=%d\n",GetLastError()); + if (pOpenThread) { /* check that access control is obeyed */ - access_thread=pOpenThread(THREAD_ALL_ACCESS & - (~THREAD_QUERY_INFORMATION) & (~THREAD_SET_INFORMATION), - 0,curthreadId); - ok(access_thread!=NULL,"OpenThread returned an invalid handle\n"); - if (access_thread!=NULL) { - obey_ar(pSetThreadPriorityBoost(access_thread,1)==0); - obey_ar(pGetThreadPriorityBoost(access_thread,&disabled)==0); - ok(CloseHandle(access_thread),"Error Closing thread handle\n"); + access_thread=pOpenThread(THREAD_ALL_ACCESS & + (~THREAD_QUERY_INFORMATION) & (~THREAD_SET_INFORMATION), + 0,curthreadId); + ok(access_thread!=NULL,"OpenThread returned an invalid handle\n"); + if (access_thread!=NULL) { + obey_ar(pSetThreadPriorityBoost(access_thread,1)==0); + obey_ar(pGetThreadPriorityBoost(access_thread,&disabled)==0); + ok(CloseHandle(access_thread),"Error Closing thread handle\n"); + } } todo_wine {

1 0

Paul Vriens : msi/tests: Remove test directory after the files have been deleted.
by Alexandre Julliard 02 Jan '07

02 Jan '07

Module: wine Branch: master Commit: 4d0232e504a5c7c9d347d219a92a9cee1728efb9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=4d0232e504a5c7c9d347d219a… Author: Paul Vriens <paul.vriens.wine(a)gmail.com> Date: Sun Dec 31 15:19:35 2006 +0100 msi/tests: Remove test directory after the files have been deleted. --- dlls/msi/tests/install.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/msi/tests/install.c b/dlls/msi/tests/install.c index d044436..1c0fb6a 100644 --- a/dlls/msi/tests/install.c +++ b/dlls/msi/tests/install.c @@ -872,13 +872,13 @@ static void test_continuouscabs(void) r = MsiInstallProductA(msifile, NULL); ok(delete_pf("msitest\\maximus", TRUE), "File not installed\n"); - ok(delete_pf("msitest", FALSE), "File not installed\n"); todo_wine { ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %u\n", r); ok(delete_pf("msitest\\augustus", TRUE), "File not installed\n"); ok(delete_pf("msitest\\caesar", TRUE), "File not installed\n"); } + ok(delete_pf("msitest", FALSE), "File not installed\n"); delete_cab_files(); DeleteFile(msifile);

1 0

Dmitry Timoshkov : ntdll: Map ESPIPE to STATUS_ILLEGAL_FUNCTION.
by Alexandre Julliard 02 Jan '07

02 Jan '07

Module: wine Branch: master Commit: b5cce1e52552152bcb694c5116c4c8364c396abe URL: http://source.winehq.org/git/wine.git/?a=commit;h=b5cce1e52552152bcb694c511… Author: Dmitry Timoshkov <dmitry(a)codeweavers.com> Date: Sun Dec 31 17:28:23 2006 +0800 ntdll: Map ESPIPE to STATUS_ILLEGAL_FUNCTION. --- dlls/ntdll/file.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/ntdll/file.c b/dlls/ntdll/file.c index 0d9e7df..038b755 100644 --- a/dlls/ntdll/file.c +++ b/dlls/ntdll/file.c @@ -371,8 +371,8 @@ NTSTATUS FILE_GetNtStatus(void) case EOPNOTSUPP:return STATUS_NOT_SUPPORTED; case ECONNRESET:return STATUS_PIPE_DISCONNECTED; case EFAULT: return STATUS_ACCESS_VIOLATION; + case ESPIPE: return STATUS_ILLEGAL_FUNCTION; case ENOEXEC: /* ?? */ - case ESPIPE: /* ?? */ case EEXIST: /* ?? */ default: FIXME( "Converting errno %d to STATUS_UNSUCCESSFUL\n", err );

1 0

Dmitry Timoshkov : winex11.drv: Fix the regression caused by a previous change.
by Alexandre Julliard 02 Jan '07

02 Jan '07

Module: wine Branch: master Commit: 0995a6ea434cd9e1a4f8c7ea3fba54f1ff0f2794 URL: http://source.winehq.org/git/wine.git/?a=commit;h=0995a6ea434cd9e1a4f8c7ea3… Author: Dmitry Timoshkov <dmitry(a)codeweavers.com> Date: Sat Dec 30 22:03:36 2006 +0800 winex11.drv: Fix the regression caused by a previous change. --- dlls/winex11.drv/winpos.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/winex11.drv/winpos.c b/dlls/winex11.drv/winpos.c index 3c41b65..317500d 100644 --- a/dlls/winex11.drv/winpos.c +++ b/dlls/winex11.drv/winpos.c @@ -623,6 +623,7 @@ BOOL X11DRV_ShowWindow( HWND hwnd, INT c /* fall through */ case SW_SHOWNORMAL: /* same as SW_NORMAL: */ case SW_SHOWDEFAULT: /* FIXME: should have its own handler */ + if (!wasVisible) swp |= SWP_SHOWWINDOW; if (style & (WS_MINIMIZE | WS_MAXIMIZE)) { swp |= SWP_FRAMECHANGED; @@ -630,7 +631,6 @@ BOOL X11DRV_ShowWindow( HWND hwnd, INT c } else { - if (!wasVisible) swp |= SWP_SHOWWINDOW; swp |= SWP_NOSIZE | SWP_NOMOVE; } if (style & WS_CHILD && !(swp & SWP_STATECHANGED)) swp |= SWP_NOACTIVATE | SWP_NOZORDER;

1 0

Paul Vriens : winspool.drv/tests: Skip EnumPrintersW tests when not implemented.
by Alexandre Julliard 02 Jan '07

02 Jan '07

Module: wine Branch: master Commit: f5ecb721274f58e8341a4edead9602abbe716893 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f5ecb721274f58e8341a4edea… Author: Paul Vriens <paul.vriens.wine(a)gmail.com> Date: Sat Dec 30 18:13:08 2006 +0100 winspool.drv/tests: Skip EnumPrintersW tests when not implemented. --- dlls/winspool.drv/tests/info.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/dlls/winspool.drv/tests/info.c b/dlls/winspool.drv/tests/info.c index c7f6634..3bf59aa 100644 --- a/dlls/winspool.drv/tests/info.c +++ b/dlls/winspool.drv/tests/info.c @@ -1670,6 +1670,13 @@ static void test_EnumPrinters(void) SetLastError(0xdeadbeef); neededW = -1; ret = EnumPrintersW(PRINTER_ENUM_LOCAL, NULL, 2, NULL, 0, &neededW, &num); + /* EnumPrintersW is not supported on all platforms */ + if (!ret && (GetLastError() == ERROR_CALL_NOT_IMPLEMENTED)) + { + trace("EnumPrintersW is not implemented, skipping some tests\n"); + return; + } + if (!ret) { /* We have 1 or more printers */

1 0

Paul Vriens : kernel32/tests: Move USE_EXTENDED_PRIORITIES outside the if-statement.
by Alexandre Julliard 02 Jan '07

02 Jan '07

Module: wine Branch: master Commit: 83f071cf7b3bca1e3814c101d766222a620efce3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=83f071cf7b3bca1e3814c101d… Author: Paul Vriens <paul.vriens.wine(a)gmail.com> Date: Sat Dec 30 20:18:58 2006 +0100 kernel32/tests: Move USE_EXTENDED_PRIORITIES outside the if-statement. --- dlls/kernel32/tests/thread.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/kernel32/tests/thread.c b/dlls/kernel32/tests/thread.c index 763d9e6..b51bb57 100644 --- a/dlls/kernel32/tests/thread.c +++ b/dlls/kernel32/tests/thread.c @@ -440,10 +440,10 @@ static VOID test_thread_priority(void) obey_ar(GetExitCodeThread(access_thread,&exitCode)==0); ok(CloseHandle(access_thread),"Error Closing thread handle\n"); } + } #if USE_EXTENDED_PRIORITIES - min_priority=-7; max_priority=6; + min_priority=-7; max_priority=6; #endif - } for(i=min_priority;i<=max_priority;i++) { ok(SetThreadPriority(curthread,i)!=0, "SetThreadPriority Failed for priority: %d\n",i);

1 0

Alexandre Julliard : configure: Use the correct ar tool when building Mingw import libraries.
by Alexandre Julliard 02 Jan '07

02 Jan '07

Module: wine Branch: master Commit: 2ffc7e2c2d9fd1a5384fc7d5705fe7ec8991c552 URL: http://source.winehq.org/git/wine.git/?a=commit;h=2ffc7e2c2d9fd1a5384fc7d57… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Jan 1 13:44:45 2007 +0100 configure: Use the correct ar tool when building Mingw import libraries. --- configure | 143 ++++++++++++++++++++++++++++++++++++++++++++++++- configure.ac | 2 + dlls/Makedll.rules.in | 4 +- 3 files changed, 146 insertions(+), 3 deletions(-) diff --git a/configure b/configure index a68d2d1..2bcd9ea 100755 --- a/configure +++ b/configure @@ -754,6 +754,7 @@ IMPLIBEXT LIBWINE_LDFLAGS DLLTOOL DLLWRAP +MINGWAR COREFOUNDATIONLIB IOKITLIB LDEXECFLAGS @@ -13437,6 +13438,102 @@ else DLLWRAP="$ac_cv_prog_DLLWRAP" fi + if test -n "$ac_tool_prefix"; then + # Extract the first word of "${ac_tool_prefix}ar", so it can be a program name with args. +set dummy ${ac_tool_prefix}ar; ac_word=$2 +{ echo "$as_me:$LINENO: checking for $ac_word" >&5 +echo $ECHO_N "checking for $ac_word... $ECHO_C" >&6; } +if test "${ac_cv_prog_MINGWAR+set}" = set; then + echo $ECHO_N "(cached) $ECHO_C" >&6 +else + if test -n "$MINGWAR"; then + ac_cv_prog_MINGWAR="$MINGWAR" # Let the user override the test. +else +as_save_IFS=$IFS; IFS=$PATH_SEPARATOR +for as_dir in $PATH +do + IFS=$as_save_IFS + test -z "$as_dir" && as_dir=. + for ac_exec_ext in '' $ac_executable_extensions; do + if { test -f "$as_dir/$ac_word$ac_exec_ext" && $as_test_x "$as_dir/$ac_word$ac_exec_ext"; }; then + ac_cv_prog_MINGWAR="${ac_tool_prefix}ar" + echo "$as_me:$LINENO: found $as_dir/$ac_word$ac_exec_ext" >&5 + break 2 + fi +done +done +IFS=$as_save_IFS + +fi +fi +MINGWAR=$ac_cv_prog_MINGWAR +if test -n "$MINGWAR"; then + { echo "$as_me:$LINENO: result: $MINGWAR" >&5 +echo "${ECHO_T}$MINGWAR" >&6; } +else + { echo "$as_me:$LINENO: result: no" >&5 +echo "${ECHO_T}no" >&6; } +fi + + +fi +if test -z "$ac_cv_prog_MINGWAR"; then + ac_ct_MINGWAR=$MINGWAR + # Extract the first word of "ar", so it can be a program name with args. +set dummy ar; ac_word=$2 +{ echo "$as_me:$LINENO: checking for $ac_word" >&5 +echo $ECHO_N "checking for $ac_word... $ECHO_C" >&6; } +if test "${ac_cv_prog_ac_ct_MINGWAR+set}" = set; then + echo $ECHO_N "(cached) $ECHO_C" >&6 +else + if test -n "$ac_ct_MINGWAR"; then + ac_cv_prog_ac_ct_MINGWAR="$ac_ct_MINGWAR" # Let the user override the test. +else +as_save_IFS=$IFS; IFS=$PATH_SEPARATOR +for as_dir in $PATH +do + IFS=$as_save_IFS + test -z "$as_dir" && as_dir=. + for ac_exec_ext in '' $ac_executable_extensions; do + if { test -f "$as_dir/$ac_word$ac_exec_ext" && $as_test_x "$as_dir/$ac_word$ac_exec_ext"; }; then + ac_cv_prog_ac_ct_MINGWAR="ar" + echo "$as_me:$LINENO: found $as_dir/$ac_word$ac_exec_ext" >&5 + break 2 + fi +done +done +IFS=$as_save_IFS + +fi +fi +ac_ct_MINGWAR=$ac_cv_prog_ac_ct_MINGWAR +if test -n "$ac_ct_MINGWAR"; then + { echo "$as_me:$LINENO: result: $ac_ct_MINGWAR" >&5 +echo "${ECHO_T}$ac_ct_MINGWAR" >&6; } +else + { echo "$as_me:$LINENO: result: no" >&5 +echo "${ECHO_T}no" >&6; } +fi + + if test "x$ac_ct_MINGWAR" = x; then + MINGWAR="false" + else + case $cross_compiling:$ac_tool_warned in +yes:) +{ echo "$as_me:$LINENO: WARNING: In the future, Autoconf will not detect cross-tools +whose name does not start with the host triplet. If you think this +configuration is useful to you, please write to autoconf(a)gnu.org." >&5 +echo "$as_me: WARNING: In the future, Autoconf will not detect cross-tools +whose name does not start with the host triplet. If you think this +configuration is useful to you, please write to autoconf(a)gnu.org." >&2;} +ac_tool_warned=yes ;; +esac + MINGWAR=$ac_ct_MINGWAR + fi +else + MINGWAR="$ac_cv_prog_MINGWAR" +fi + if test "$DLLWRAP" = "false"; then LIBEXT="a" else @@ -14245,6 +14342,49 @@ fi done test -n "$CROSSWINDRES" || CROSSWINDRES="false" + for ac_prog in i586-mingw32msvc-ar i386-mingw32msvc-ar i386-mingw32-ar mingw32-ar mingw-ar +do + # Extract the first word of "$ac_prog", so it can be a program name with args. +set dummy $ac_prog; ac_word=$2 +{ echo "$as_me:$LINENO: checking for $ac_word" >&5 +echo $ECHO_N "checking for $ac_word... $ECHO_C" >&6; } +if test "${ac_cv_prog_MINGWAR+set}" = set; then + echo $ECHO_N "(cached) $ECHO_C" >&6 +else + if test -n "$MINGWAR"; then + ac_cv_prog_MINGWAR="$MINGWAR" # Let the user override the test. +else +as_save_IFS=$IFS; IFS=$PATH_SEPARATOR +for as_dir in $PATH +do + IFS=$as_save_IFS + test -z "$as_dir" && as_dir=. + for ac_exec_ext in '' $ac_executable_extensions; do + if { test -f "$as_dir/$ac_word$ac_exec_ext" && $as_test_x "$as_dir/$ac_word$ac_exec_ext"; }; then + ac_cv_prog_MINGWAR="$ac_prog" + echo "$as_me:$LINENO: found $as_dir/$ac_word$ac_exec_ext" >&5 + break 2 + fi +done +done +IFS=$as_save_IFS + +fi +fi +MINGWAR=$ac_cv_prog_MINGWAR +if test -n "$MINGWAR"; then + { echo "$as_me:$LINENO: result: $MINGWAR" >&5 +echo "${ECHO_T}$MINGWAR" >&6; } +else + { echo "$as_me:$LINENO: result: no" >&5 +echo "${ECHO_T}no" >&6; } +fi + + + test -n "$MINGWAR" && break +done +test -n "$MINGWAR" || MINGWAR="false" + if test "$CROSSCC" != "false"; then CROSSTEST="\$(CROSSTEST)"; fi fi ;; @@ -21438,6 +21578,7 @@ IMPLIBEXT!$IMPLIBEXT$ac_delim LIBWINE_LDFLAGS!$LIBWINE_LDFLAGS$ac_delim DLLTOOL!$DLLTOOL$ac_delim DLLWRAP!$DLLWRAP$ac_delim +MINGWAR!$MINGWAR$ac_delim COREFOUNDATIONLIB!$COREFOUNDATIONLIB$ac_delim IOKITLIB!$IOKITLIB$ac_delim LDEXECFLAGS!$LDEXECFLAGS$ac_delim @@ -21460,7 +21601,7 @@ LIBOBJS!$LIBOBJS$ac_delim LTLIBOBJS!$LTLIBOBJS$ac_delim _ACEOF - if test `sed -n "s/.*$ac_delim\$/X/p" conf$$subs.sed | grep -c X` = 77; then + if test `sed -n "s/.*$ac_delim\$/X/p" conf$$subs.sed | grep -c X` = 78; then break elif $ac_last_try; then { { echo "$as_me:$LINENO: error: could not make $CONFIG_STATUS" >&5 diff --git a/configure.ac b/configure.ac index 92552d3..6fad99e 100644 --- a/configure.ac +++ b/configure.ac @@ -992,6 +992,7 @@ case $host_os in cygwin*|mingw32*) AC_CHECK_TOOL(DLLTOOL,dlltool,false) AC_CHECK_TOOL(DLLWRAP,dllwrap,false) + AC_CHECK_TOOL(MINGWAR,ar,false) if test "$DLLWRAP" = "false"; then LIBEXT="a" else @@ -1104,6 +1105,7 @@ case $host_os in WINE_CHECK_MINGW_PROG(CROSSCC,gcc,false) WINE_CHECK_MINGW_PROG(DLLTOOL,dlltool,false) WINE_CHECK_MINGW_PROG(CROSSWINDRES,windres,false) + WINE_CHECK_MINGW_PROG(MINGWAR,ar,false) if test "$CROSSCC" != "false"; then CROSSTEST="\$(CROSSTEST)"; fi fi ;; diff --git a/dlls/Makedll.rules.in b/dlls/Makedll.rules.in index 632730f..fe77784 100644 --- a/dlls/Makedll.rules.in +++ b/dlls/Makedll.rules.in @@ -12,6 +12,7 @@ DLLFLAGS = @DLLFLAGS@ DLLEXT = @DLLEXT@ IMPLIBEXT = @IMPLIBEXT@ +MINGWAR = @MINGWAR@ DEFS = -D__WINESRC__ $(EXTRADEFS) BASEMODULE = $(MODULE:%.dll=%) MAINSPEC = $(BASEMODULE).spec @@ -56,8 +57,7 @@ lib$(BASEMODULE).def.a: $(IMPLIB_OBJS) lib$(BASEMODULE).a: $(SPEC_DEF) $(IMPLIB_OBJS) $(DLLTOOL) -k -l $@ -d $(SPEC_DEF) - $(AR) $@ $(IMPLIB_OBJS) - $(RANLIB) $@ + $(MINGWAR) rs $@ $(IMPLIB_OBJS) $(SUBDIRS): implib

1 0