October 2007 - Wine-commits

Maarten Lankhorst : wineoss: Seperate wave-in and wave-outs shared use of a single OSS_DEVICE struct.
by Alexandre Julliard 01 Oct '07

01 Oct '07

Module: wine Branch: master Commit: 58e26451dbed69e3ad3a4256333b81a2d5320c01 URL: http://source.winehq.org/git/wine.git/?a=commit;h=58e26451dbed69e3ad3a42563… Author: Maarten Lankhorst <maarten(a)codeweavers.com> Date: Mon Oct 1 09:16:59 2007 +0200 wineoss: Seperate wave-in and wave-outs shared use of a single OSS_DEVICE struct. --- dlls/wineoss.drv/audio.c | 231 +++++++++++++++++++++--------------------- dlls/wineoss.drv/audio.h | 5 +- dlls/wineoss.drv/dscapture.c | 70 +++++++------- dlls/wineoss.drv/dsrender.c | 66 ++++++------ 4 files changed, 184 insertions(+), 188 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=58e26451dbed69e3ad3a4…

1 0

Roderick Colenbrander : wined3d: WINAPI compile fixes.
by Alexandre Julliard 01 Oct '07

01 Oct '07

Module: wine Branch: master Commit: dac5e5ff1ec08507eabe02f302475a4465c6d24b URL: http://source.winehq.org/git/wine.git/?a=commit;h=dac5e5ff1ec08507eabe02f30… Author: Roderick Colenbrander <thunderbird2k(a)gmx.net> Date: Sun Sep 30 15:38:16 2007 +0200 wined3d: WINAPI compile fixes. --- include/wine/wined3d_interface.h | 16 ++++++++-------- 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/include/wine/wined3d_interface.h b/include/wine/wined3d_interface.h index 603eeb5..895ba66 100644 --- a/include/wine/wined3d_interface.h +++ b/include/wine/wined3d_interface.h @@ -196,7 +196,7 @@ DEFINE_GUID(IID_IWineD3DClipper, /***************************************************************************** * Callback functions required for predefining surfaces / stencils */ -typedef HRESULT WINAPI (*D3DCB_CREATERENDERTARGETFN) (IUnknown *pDevice, +typedef HRESULT (WINAPI *D3DCB_CREATERENDERTARGETFN) (IUnknown *pDevice, IUnknown *pSuperior, UINT Width, UINT Height, @@ -207,7 +207,7 @@ typedef HRESULT WINAPI (*D3DCB_CREATERENDERTARGETFN) (IUnknown *pDevice, struct IWineD3DSurface **ppSurface, HANDLE *pSharedHandle); -typedef HRESULT WINAPI (*D3DCB_CREATESURFACEFN) (IUnknown *pDevice, +typedef HRESULT (WINAPI *D3DCB_CREATESURFACEFN) (IUnknown *pDevice, IUnknown *pSuperior, UINT Width, UINT Height, @@ -219,7 +219,7 @@ typedef HRESULT WINAPI (*D3DCB_CREATESURFACEFN) (IUnknown *pDevice, struct IWineD3DSurface **ppSurface, HANDLE *pSharedHandle); -typedef HRESULT WINAPI (*D3DCB_CREATEDEPTHSTENCILSURFACEFN) (IUnknown *pDevice, +typedef HRESULT (WINAPI *D3DCB_CREATEDEPTHSTENCILSURFACEFN) (IUnknown *pDevice, IUnknown *pSuperior, UINT Width, UINT Height, @@ -231,7 +231,7 @@ typedef HRESULT WINAPI (*D3DCB_CREATEDEPTHSTENCILSURFACEFN) (IUnknown *pDevice, HANDLE *pSharedHandle); -typedef HRESULT WINAPI (*D3DCB_CREATEVOLUMEFN) (IUnknown *pDevice, +typedef HRESULT (WINAPI *D3DCB_CREATEVOLUMEFN) (IUnknown *pDevice, IUnknown *pSuperior, UINT Width, UINT Height, @@ -242,7 +242,7 @@ typedef HRESULT WINAPI (*D3DCB_CREATEVOLUMEFN) (IUnknown *pDevice, struct IWineD3DVolume **ppVolume, HANDLE *pSharedHandle); -typedef HRESULT WINAPI (*D3DCB_CREATEADDITIONALSWAPCHAIN) (IUnknown *pDevice, +typedef HRESULT (WINAPI *D3DCB_CREATEADDITIONALSWAPCHAIN) (IUnknown *pDevice, WINED3DPRESENT_PARAMETERS *pPresentationParameters, struct IWineD3DSwapChain **pSwapChain ); @@ -250,11 +250,11 @@ typedef HRESULT WINAPI (*D3DCB_CREATEADDITIONALSWAPCHAIN) (IUnknown *pDevice, /***************************************************************************** * Callback functions for custom implicit object destruction. */ -typedef ULONG WINAPI (*D3DCB_DESTROYSWAPCHAINFN) (struct IWineD3DSwapChain *pSwapChain); +typedef ULONG (WINAPI *D3DCB_DESTROYSWAPCHAINFN) (struct IWineD3DSwapChain *pSwapChain); -typedef ULONG WINAPI (*D3DCB_DESTROYSURFACEFN) (struct IWineD3DSurface *pSurface); +typedef ULONG (WINAPI *D3DCB_DESTROYSURFACEFN) (struct IWineD3DSurface *pSurface); -typedef ULONG WINAPI (*D3DCB_DESTROYVOLUMEFN) (struct IWineD3DVolume *pVolume); +typedef ULONG (WINAPI *D3DCB_DESTROYVOLUMEFN) (struct IWineD3DVolume *pVolume); /***************************************************************************** * IWineD3DBase interface

1 0

Rob Shearman : user32: Add tests for DefWindowProc processing the undocumented 0x3B message.
by Alexandre Julliard 01 Oct '07

01 Oct '07

Module: wine Branch: master Commit: dbfb6b04148e5884c6accfc589b9e0fa9104e3bf URL: http://source.winehq.org/git/wine.git/?a=commit;h=dbfb6b04148e5884c6accfc58… Author: Rob Shearman <rob(a)codeweavers.com> Date: Sun Sep 30 17:56:08 2007 +0100 user32: Add tests for DefWindowProc processing the undocumented 0x3B message. --- dlls/user32/tests/msg.c | 71 +++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 71 insertions(+), 0 deletions(-) diff --git a/dlls/user32/tests/msg.c b/dlls/user32/tests/msg.c index 88c5228..0d47262 100644 --- a/dlls/user32/tests/msg.c +++ b/dlls/user32/tests/msg.c @@ -3852,6 +3852,41 @@ static const struct message WmSetIcon_2[] = { { 0 } }; +/* Sending undocumented 0x3B message with wparam = 0x8000000b */ +static const struct message WmInitEndSession[] = { + { 0x003B, sent }, + { WM_QUERYENDSESSION, sent|defwinproc|wparam|lparam, 0, ENDSESSION_LOGOFF }, + { 0 } +}; + +/* Sending undocumented 0x3B message with wparam = 0x0000000b */ +static const struct message WmInitEndSession_2[] = { + { 0x003B, sent }, + { WM_QUERYENDSESSION, sent|defwinproc|wparam|lparam, 0, 0 }, + { 0 } +}; + +/* Sending undocumented 0x3B message with wparam = 0x80000008 */ +static const struct message WmInitEndSession_3[] = { + { 0x003B, sent }, + { WM_ENDSESSION, sent|defwinproc|wparam|lparam, 0, ENDSESSION_LOGOFF }, + { 0 } +}; + +/* Sending undocumented 0x3B message with wparam = 0x00000008 */ +static const struct message WmInitEndSession_4[] = { + { 0x003B, sent }, + { WM_ENDSESSION, sent|defwinproc|wparam|lparam, 0, 0 }, + { 0 } +}; + +/* Sending undocumented 0x3B message with wparam = 0x80000001 */ +static const struct message WmInitEndSession_5[] = { + { 0x003B, sent }, + { WM_ENDSESSION, sent|defwinproc|wparam|lparam, 1, ENDSESSION_LOGOFF }, + { 0 } +}; + static void test_MsgWaitForMultipleObjects(HWND hwnd) { DWORD ret; @@ -3902,6 +3937,7 @@ static void test_messages(void) HWND hchild2, hbutton; HMENU hmenu; MSG msg; + LRESULT res; flush_sequence(); @@ -4275,6 +4311,41 @@ static void test_messages(void) flush_sequence(); SendMessage(hwnd, WM_SETICON, ICON_SMALL, (LPARAM)LoadIcon(0, IDI_APPLICATION)); ok_sequence(WmSetIcon_2, "WM_SETICON for hidden window without caption", FALSE); + + flush_sequence(); + res = SendMessage(hwnd, 0x3B, 0x8000000b, 0); + ok_sequence(WmInitEndSession, "Handling of undocumented 0x3B message by DefWindowProc wparam=0x8000000b", TRUE); + todo_wine + ok(res == 1, "SendMessage(hwnd, 0x3B, 0x8000000b, 0) should have returned 1 instead of %ld\n", res); + res = SendMessage(hwnd, 0x3B, 0x0000000b, 0); + ok_sequence(WmInitEndSession_2, "Handling of undocumented 0x3B message by DefWindowProc wparam=0x0000000b", TRUE); + todo_wine + ok(res == 1, "SendMessage(hwnd, 0x3B, 0x0000000b, 0) should have returned 1 instead of %ld\n", res); + res = SendMessage(hwnd, 0x3B, 0x0000000f, 0); + ok_sequence(WmInitEndSession_2, "Handling of undocumented 0x3B message by DefWindowProc wparam=0x0000000f", TRUE); + todo_wine + ok(res == 1, "SendMessage(hwnd, 0x3B, 0x0000000f, 0) should have returned 1 instead of %ld\n", res); + + flush_sequence(); + res = SendMessage(hwnd, 0x3B, 0x80000008, 0); + ok_sequence(WmInitEndSession_3, "Handling of undocumented 0x3B message by DefWindowProc wparam=0x80000008", TRUE); + todo_wine + ok(res == 2, "SendMessage(hwnd, 0x3B, 0x80000008, 0) should have returned 2 instead of %ld\n", res); + res = SendMessage(hwnd, 0x3B, 0x00000008, 0); + ok_sequence(WmInitEndSession_4, "Handling of undocumented 0x3B message by DefWindowProc wparam=0x00000008", TRUE); + todo_wine + ok(res == 2, "SendMessage(hwnd, 0x3B, 0x00000008, 0) should have returned 2 instead of %ld\n", res); + + res = SendMessage(hwnd, 0x3B, 0x80000004, 0); + ok_sequence(WmInitEndSession_3, "Handling of undocumented 0x3B message by DefWindowProc wparam=0x80000004", TRUE); + todo_wine + ok(res == 2, "SendMessage(hwnd, 0x3B, 0x80000004, 0) should have returned 2 instead of %ld\n", res); + + res = SendMessage(hwnd, 0x3B, 0x80000001, 0); + ok_sequence(WmInitEndSession_5, "Handling of undocumented 0x3B message by DefWindowProc wparam=0x80000001", TRUE); + todo_wine + ok(res == 2, "SendMessage(hwnd, 0x3B, 0x80000001, 0) should have returned 2 instead of %ld\n", res); + DestroyWindow(hwnd); flush_sequence(); }

1 0

Stefan Dösinger : wined3d: Add texreg2rgb support to arb shaders.
by Alexandre Julliard 01 Oct '07

01 Oct '07

Module: wine Branch: master Commit: 66447040396dfecbcd8f2b1510d65c900424f46a URL: http://source.winehq.org/git/wine.git/?a=commit;h=66447040396dfecbcd8f2b151… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Wed Sep 5 17:05:58 2007 +0200 wined3d: Add texreg2rgb support to arb shaders. --- dlls/wined3d/arb_program_shader.c | 16 ++++++++++++++++ dlls/wined3d/pixelshader.c | 2 +- dlls/wined3d/wined3d_private.h | 1 + 3 files changed, 18 insertions(+), 1 deletions(-) diff --git a/dlls/wined3d/arb_program_shader.c b/dlls/wined3d/arb_program_shader.c index b4d1426..1fc3338 100644 --- a/dlls/wined3d/arb_program_shader.c +++ b/dlls/wined3d/arb_program_shader.c @@ -1118,6 +1118,22 @@ void pshader_hw_texreg2gb(SHADER_OPCODE_ARG* arg) { shader_hw_sample(arg, reg1, dst_str, "TMP", FALSE, FALSE); } +void pshader_hw_texreg2rgb(SHADER_OPCODE_ARG* arg) { + + SHADER_BUFFER* buffer = arg->buffer; + IWineD3DPixelShaderImpl* This = (IWineD3DPixelShaderImpl*) arg->shader; + IWineD3DDeviceImpl* deviceImpl = (IWineD3DDeviceImpl*) This->baseShader.device; + DWORD flags; + DWORD reg1 = arg->dst & WINED3DSP_REGNUM_MASK; + char dst_str[8]; + char src_str[50]; + + sprintf(dst_str, "T%u", reg1); + pshader_gen_input_modifier_line(buffer, arg->src[0], 0, src_str); + flags = reg1 < MAX_TEXTURES ? deviceImpl->stateBlock->textureState[reg1][WINED3DTSS_TEXTURETRANSFORMFLAGS] : 0; + shader_hw_sample(arg, reg1, dst_str, src_str, FALSE, FALSE); +} + void pshader_hw_texbem(SHADER_OPCODE_ARG* arg) { IWineD3DPixelShaderImpl* This = (IWineD3DPixelShaderImpl*) arg->shader; diff --git a/dlls/wined3d/pixelshader.c b/dlls/wined3d/pixelshader.c index ad9b11d..512badc 100644 --- a/dlls/wined3d/pixelshader.c +++ b/dlls/wined3d/pixelshader.c @@ -220,7 +220,7 @@ CONST SHADER_OPCODE IWineD3DPixelShaderImpl_shader_ins[] = { {WINED3DSIO_TEXBEML, "texbeml", GLNAME_REQUIRE_GLSL, 1, 2, pshader_hw_texbem, pshader_glsl_texbem, WINED3DPS_VERSION(1,0), WINED3DPS_VERSION(1,3)}, {WINED3DSIO_TEXREG2AR,"texreg2ar","undefined", 1, 2, pshader_hw_texreg2ar, pshader_glsl_texreg2ar, WINED3DPS_VERSION(1,0), WINED3DPS_VERSION(1,3)}, {WINED3DSIO_TEXREG2GB,"texreg2gb","undefined", 1, 2, pshader_hw_texreg2gb, pshader_glsl_texreg2gb, WINED3DPS_VERSION(1,0), WINED3DPS_VERSION(1,3)}, - {WINED3DSIO_TEXREG2RGB, "texreg2rgb", GLNAME_REQUIRE_GLSL, 1, 2, NULL, pshader_glsl_texreg2rgb, WINED3DPS_VERSION(1,2), WINED3DPS_VERSION(1,3)}, + {WINED3DSIO_TEXREG2RGB, "texreg2rgb", "undefined", 1, 2, pshader_hw_texreg2rgb, pshader_glsl_texreg2rgb, WINED3DPS_VERSION(1,2), WINED3DPS_VERSION(1,3)}, {WINED3DSIO_TEXM3x2PAD, "texm3x2pad", "undefined", 1, 2, pshader_hw_texm3x2pad, pshader_glsl_texm3x2pad, WINED3DPS_VERSION(1,0), WINED3DPS_VERSION(1,3)}, {WINED3DSIO_TEXM3x2TEX, "texm3x2tex", "undefined", 1, 2, pshader_hw_texm3x2tex, pshader_glsl_texm3x2tex, WINED3DPS_VERSION(1,0), WINED3DPS_VERSION(1,3)}, {WINED3DSIO_TEXM3x3PAD, "texm3x3pad", "undefined", 1, 2, pshader_hw_texm3x3pad, pshader_glsl_texm3x3pad, WINED3DPS_VERSION(1,0), WINED3DPS_VERSION(1,3)}, diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h index 86fd2dc..ddea219 100644 --- a/dlls/wined3d/wined3d_private.h +++ b/dlls/wined3d/wined3d_private.h @@ -1788,6 +1788,7 @@ extern void pshader_hw_texdp3(SHADER_OPCODE_ARG* arg); extern void pshader_hw_texm3x3(SHADER_OPCODE_ARG* arg); extern void pshader_hw_texm3x2depth(SHADER_OPCODE_ARG* arg); extern void pshader_hw_dp2add(SHADER_OPCODE_ARG* arg); +extern void pshader_hw_texreg2rgb(SHADER_OPCODE_ARG* arg); /* ARB vertex / pixel shader common prototypes */ extern void shader_hw_nrm(SHADER_OPCODE_ARG* arg);

1 0

Hans Leidekker : pdh: Fix parameter handling in PdhAddEnglishCounter{A, W} and PdhCollectQueryDataWithTime.
by Alexandre Julliard 01 Oct '07

01 Oct '07

Module: wine Branch: master Commit: cf8b16bc9ec8b427ed330869060532681cdf5329 URL: http://source.winehq.org/git/wine.git/?a=commit;h=cf8b16bc9ec8b427ed3308690… Author: Hans Leidekker <hans(a)it.vu.nl> Date: Sat Sep 29 21:07:01 2007 +0200 pdh: Fix parameter handling in PdhAddEnglishCounter{A, W} and PdhCollectQueryDataWithTime. --- dlls/pdh/pdh_main.c | 20 ++++++++++++++------ dlls/pdh/tests/pdh.c | 17 +++++++++++++---- 2 files changed, 27 insertions(+), 10 deletions(-) diff --git a/dlls/pdh/pdh_main.c b/dlls/pdh/pdh_main.c index a97ee9b..c5117bf 100644 --- a/dlls/pdh/pdh_main.c +++ b/dlls/pdh/pdh_main.c @@ -304,6 +304,9 @@ PDH_STATUS WINAPI PdhAddCounterW( PDH_HQUERY hquery, LPCWSTR path, PDH_STATUS WINAPI PdhAddEnglishCounterA( PDH_HQUERY query, LPCSTR path, DWORD_PTR userdata, PDH_HCOUNTER *counter ) { + TRACE("%p %s %lx %p\n", query, debugstr_a(path), userdata, counter); + + if (!query) return PDH_INVALID_ARGUMENT; return PdhAddCounterA( query, path, userdata, counter ); } @@ -313,6 +316,9 @@ PDH_STATUS WINAPI PdhAddEnglishCounterA( PDH_HQUERY query, LPCSTR path, PDH_STATUS WINAPI PdhAddEnglishCounterW( PDH_HQUERY query, LPCWSTR path, DWORD_PTR userdata, PDH_HCOUNTER *counter ) { + TRACE("%p %s %lx %p\n", query, debugstr_w(path), userdata, counter); + + if (!query) return PDH_INVALID_ARGUMENT; return PdhAddCounterW( query, path, userdata, counter ); } @@ -543,9 +549,13 @@ PDH_STATUS WINAPI PdhCollectQueryDataEx( PDH_HQUERY handle, DWORD interval, HAND PDH_STATUS WINAPI PdhCollectQueryDataWithTime( PDH_HQUERY handle, LONGLONG *timestamp ) { struct query *query = handle; + struct counter *counter; + struct list *item; TRACE("%p %p\n", handle, timestamp); + if (!timestamp) return PDH_INVALID_ARGUMENT; + EnterCriticalSection( &pdh_handle_cs ); if (!query || query->magic != PDH_MAGIC_QUERY) { @@ -560,13 +570,11 @@ PDH_STATUS WINAPI PdhCollectQueryDataWithTime( PDH_HQUERY handle, LONGLONG *time collect_query_data( query ); - if (timestamp) - { - struct list *item = list_head( &query->counters ); - struct counter *counter = LIST_ENTRY( item, struct counter, entry ); + item = list_head( &query->counters ); + counter = LIST_ENTRY( item, struct counter, entry ); + + *timestamp = ((LONGLONG)counter->stamp.dwHighDateTime << 32) | counter->stamp.dwLowDateTime; - *timestamp = ((LONGLONG)counter->stamp.dwHighDateTime << 32) | counter->stamp.dwLowDateTime; - } LeaveCriticalSection( &pdh_handle_cs ); return ERROR_SUCCESS; } diff --git a/dlls/pdh/tests/pdh.c b/dlls/pdh/tests/pdh.c index 2853f8b..0cfdff3 100644 --- a/dlls/pdh/tests/pdh.c +++ b/dlls/pdh/tests/pdh.c @@ -211,11 +211,14 @@ static void test_PdhAddEnglishCounterA( void ) ret = PdhOpenQueryA( NULL, 0, &query ); ok(ret == ERROR_SUCCESS, "PdhOpenQueryA failed 0x%08x\n", ret); + ret = PdhCollectQueryData( query ); + ok(ret == PDH_NO_DATA, "PdhCollectQueryData failed 0x%08x\n", ret); + ret = pPdhAddEnglishCounterA( NULL, "\\System\\System Up Time", 0, NULL ); ok(ret == PDH_INVALID_ARGUMENT, "PdhAddEnglishCounterA failed 0x%08x\n", ret); ret = pPdhAddEnglishCounterA( NULL, "\\System\\System Up Time", 0, &counter ); - ok(ret == PDH_INVALID_HANDLE, "PdhAddEnglishCounterA failed 0x%08x\n", ret); + ok(ret == PDH_INVALID_ARGUMENT, "PdhAddEnglishCounterA failed 0x%08x\n", ret); ret = pPdhAddEnglishCounterA( query, NULL, 0, &counter ); ok(ret == PDH_INVALID_ARGUMENT, "PdhAddEnglishCounterA failed 0x%08x\n", ret); @@ -249,11 +252,14 @@ static void test_PdhAddEnglishCounterW( void ) ret = PdhOpenQueryW( NULL, 0, &query ); ok(ret == ERROR_SUCCESS, "PdhOpenQueryW failed 0x%08x\n", ret); + ret = PdhCollectQueryData( query ); + ok(ret == PDH_NO_DATA, "PdhCollectQueryData failed 0x%08x\n", ret); + ret = pPdhAddEnglishCounterW( NULL, system_uptime, 0, NULL ); ok(ret == PDH_INVALID_ARGUMENT, "PdhAddEnglishCounterW failed 0x%08x\n", ret); ret = pPdhAddEnglishCounterW( NULL, system_uptime, 0, &counter ); - ok(ret == PDH_INVALID_HANDLE, "PdhAddEnglishCounterW failed 0x%08x\n", ret); + ok(ret == PDH_INVALID_ARGUMENT, "PdhAddEnglishCounterW failed 0x%08x\n", ret); ret = pPdhAddEnglishCounterW( query, NULL, 0, &counter ); ok(ret == PDH_INVALID_ARGUMENT, "PdhAddEnglishCounterW failed 0x%08x\n", ret); @@ -288,14 +294,17 @@ static void test_PdhCollectQueryDataWithTime( void ) ret = PdhOpenQueryA( NULL, 0, &query ); ok(ret == ERROR_SUCCESS, "PdhOpenQueryA failed 0x%08x\n", ret); + ret = PdhCollectQueryData( query ); + ok(ret == PDH_NO_DATA, "PdhCollectQueryData failed 0x%08x\n", ret); + ret = PdhAddCounterA( query, "\\System\\System Up Time", 0, &counter ); ok(ret == ERROR_SUCCESS, "PdhAddCounterA failed 0x%08x\n", ret); ret = pPdhCollectQueryDataWithTime( NULL, NULL ); - ok(ret == PDH_INVALID_HANDLE, "PdhCollectQueryDataWithTime failed 0x%08x\n", ret); + ok(ret == PDH_INVALID_ARGUMENT, "PdhCollectQueryDataWithTime failed 0x%08x\n", ret); ret = pPdhCollectQueryDataWithTime( query, NULL ); - ok(ret == ERROR_SUCCESS, "PdhCollectQueryDataWithTime failed 0x%08x\n", ret); + ok(ret == PDH_INVALID_ARGUMENT, "PdhCollectQueryDataWithTime failed 0x%08x\n", ret); ret = pPdhCollectQueryDataWithTime( NULL, &time ); ok(ret == PDH_INVALID_HANDLE, "PdhCollectQueryDataWithTime failed 0x%08x\n", ret);

1 0

Hans Leidekker : pdh: Skip tests when running on non-english locale.
by Alexandre Julliard 01 Oct '07

01 Oct '07

Module: wine Branch: master Commit: 290869b03d91021e4ac3999b1c556166e9cdc92c URL: http://source.winehq.org/git/wine.git/?a=commit;h=290869b03d91021e4ac3999b1… Author: Hans Leidekker <hans(a)it.vu.nl> Date: Sat Sep 29 21:07:16 2007 +0200 pdh: Skip tests when running on non-english locale. --- dlls/pdh/tests/pdh.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/dlls/pdh/tests/pdh.c b/dlls/pdh/tests/pdh.c index 0cfdff3..7a9770d 100644 --- a/dlls/pdh/tests/pdh.c +++ b/dlls/pdh/tests/pdh.c @@ -858,6 +858,11 @@ static void test_PdhCollectQueryDataEx(void) START_TEST(pdh) { + if (PRIMARYLANGID(LANGIDFROMLCID(GetThreadLocale())) != LANG_ENGLISH) + { + skip("non-english locale\n"); + return; + } init_function_ptrs(); test_PdhOpenQueryA();

1 0

Maarten Lankhorst : dsound: Use smaller buffers for wavein capture.
by Alexandre Julliard 01 Oct '07

01 Oct '07

Module: wine Branch: master Commit: 3bafbb22b80c09ff661b283d81615b5fbf2f9388 URL: http://source.winehq.org/git/wine.git/?a=commit;h=3bafbb22b80c09ff661b283d8… Author: Maarten Lankhorst <maarten(a)codeweavers.com> Date: Sat Sep 29 01:54:03 2007 +0200 dsound: Use smaller buffers for wavein capture. --- dlls/dsound/capture.c | 195 ++++++++++++++++------------------------- dlls/dsound/dsound_private.h | 2 +- dlls/dsound/primary.c | 54 +++++++----- 3 files changed, 108 insertions(+), 143 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=3bafbb22b80c09ff661b2…

1 0

Maarten Lankhorst : dsound: Call waveInUnPrepareHeader and waveInPrepareHeader when submitting new buffer .
by Alexandre Julliard 01 Oct '07

01 Oct '07

Module: wine Branch: master Commit: 847d5565fc4c78c2b127d861a046478a86b5c1cc URL: http://source.winehq.org/git/wine.git/?a=commit;h=847d5565fc4c78c2b127d861a… Author: Maarten Lankhorst <maarten(a)codeweavers.com> Date: Mon Oct 1 09:14:03 2007 +0200 dsound: Call waveInUnPrepareHeader and waveInPrepareHeader when submitting new buffer. --- dlls/dsound/capture.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/dsound/capture.c b/dlls/dsound/capture.c index a949673..f0b230d 100644 --- a/dlls/dsound/capture.c +++ b/dlls/dsound/capture.c @@ -439,6 +439,8 @@ DSOUND_capture_callback( capture_CheckNotify(Moi, 0, 0); } else { if (This->state == STATE_CAPTURING) { + waveInUnprepareHeader(hwi, &(This->pwave[index]), sizeof(WAVEHDR)); + waveInPrepareHeader(hwi, &(This->pwave[index]), sizeof(WAVEHDR)); waveInAddBuffer(hwi, &(This->pwave[index]), sizeof(WAVEHDR)); } else if (This->state == STATE_STOPPING) { TRACE("stopping\n");

1 0

Hans Leidekker : pdh: Implement PdhValidatePath{, Ex}{A, W}.
by Alexandre Julliard 01 Oct '07

01 Oct '07

Module: wine Branch: master Commit: 504e7c2ff7ec1c4e2ec648aa675460856c30ce7b URL: http://source.winehq.org/git/wine.git/?a=commit;h=504e7c2ff7ec1c4e2ec648aa6… Author: Hans Leidekker <hans(a)it.vu.nl> Date: Sat Sep 29 21:05:53 2007 +0200 pdh: Implement PdhValidatePath{, Ex}{A, W}. --- dlls/pdh/pdh.spec | 8 +++--- dlls/pdh/pdh_main.c | 74 +++++++++++++++++++++++++++++++++++++++++++++++++++ include/pdh.h | 7 +++++ include/pdhmsg.h | 1 + 4 files changed, 86 insertions(+), 4 deletions(-) diff --git a/dlls/pdh/pdh.spec b/dlls/pdh/pdh.spec index c28d2a8..795a45e 100644 --- a/dlls/pdh/pdh.spec +++ b/dlls/pdh/pdh.spec @@ -137,10 +137,10 @@ @ stub PdhUpdateLogA @ stub PdhUpdateLogFileCatalog @ stub PdhUpdateLogW -@ stub PdhValidatePathA -@ stub PdhValidatePathExA -@ stub PdhValidatePathExW -@ stub PdhValidatePathW +@ stdcall PdhValidatePathA(str) +@ stdcall PdhValidatePathExA(ptr str) +@ stdcall PdhValidatePathExW(ptr wstr) +@ stdcall PdhValidatePathW(wstr) @ stub PdhVbAddCounter @ stub PdhVbCreateCounterPathList @ stub PdhVbGetCounterPathElements diff --git a/dlls/pdh/pdh_main.c b/dlls/pdh/pdh_main.c index 5253620..e49e64e 100644 --- a/dlls/pdh/pdh_main.c +++ b/dlls/pdh/pdh_main.c @@ -700,3 +700,77 @@ PDH_STATUS WINAPI PdhSetCounterScaleFactor( PDH_HCOUNTER handle, LONG factor ) counter->scale = factor; return ERROR_SUCCESS; } + +/*********************************************************************** + * PdhValidatePathA (PDH.@) + */ +PDH_STATUS WINAPI PdhValidatePathA( LPCSTR path ) +{ + PDH_STATUS ret; + WCHAR *pathW; + + TRACE("%s\n", debugstr_a(path)); + + if (!path) return PDH_INVALID_ARGUMENT; + if (!(pathW = pdh_strdup_aw( path ))) return PDH_MEMORY_ALLOCATION_FAILURE; + + ret = PdhValidatePathW( pathW ); + + pdh_free( pathW ); + return ret; +} + +static PDH_STATUS validate_path( LPCWSTR path ) +{ + if (!path || !*path) return PDH_INVALID_ARGUMENT; + if (*path++ != '\\' || !strchrW( path, '\\' )) return PDH_CSTATUS_BAD_COUNTERNAME; + return ERROR_SUCCESS; + } + +/*********************************************************************** + * PdhValidatePathW (PDH.@) + */ +PDH_STATUS WINAPI PdhValidatePathW( LPCWSTR path ) +{ + PDH_STATUS ret; + unsigned int i; + + TRACE("%s\n", debugstr_w(path)); + + if ((ret = validate_path( path ))) return ret; + + for (i = 0; i < sizeof(counter_sources) / sizeof(counter_sources[0]); i++) + if (pdh_match_path( counter_sources[i].path, path )) return ERROR_SUCCESS; + + return PDH_CSTATUS_NO_COUNTER; +} + +/*********************************************************************** + * PdhValidatePathExA (PDH.@) + */ +PDH_STATUS WINAPI PdhValidatePathExA( PDH_HLOG source, LPCSTR path ) +{ + TRACE("%p %s\n", source, debugstr_a(path)); + + if (source) + { + FIXME("log file data source not supported\n"); + return ERROR_SUCCESS; + } + return PdhValidatePathA( path ); +} + +/*********************************************************************** + * PdhValidatePathExW (PDH.@) + */ +PDH_STATUS WINAPI PdhValidatePathExW( PDH_HLOG source, LPCWSTR path ) +{ + TRACE("%p %s\n", source, debugstr_w(path)); + + if (source) + { + FIXME("log file data source not supported\n"); + return ERROR_SUCCESS; + } + return PdhValidatePathW( path ); +} diff --git a/include/pdh.h b/include/pdh.h index a392096..3aff6db 100644 --- a/include/pdh.h +++ b/include/pdh.h @@ -35,6 +35,7 @@ extern "C" { typedef LONG PDH_STATUS; typedef HANDLE PDH_HQUERY; typedef HANDLE PDH_HCOUNTER; +typedef HANDLE PDH_HLOG; #define PDH_MAX_SCALE 7 #define PDH_MIN_SCALE (-7) @@ -190,6 +191,12 @@ PDH_STATUS WINAPI PdhOpenQueryW(LPCWSTR, DWORD_PTR, PDH_HQUERY *); #define PdhOpenQuery WINELIB_NAME_AW(PdhOpenQuery) PDH_STATUS WINAPI PdhRemoveCounter(PDH_HCOUNTER); PDH_STATUS WINAPI PdhSetCounterScaleFactor(PDH_HCOUNTER, LONG); +PDH_STATUS WINAPI PdhValidatePathA(LPCSTR); +PDH_STATUS WINAPI PdhValidatePathW(LPCWSTR); +#define PdhValidatePath WINELIB_NAME_AW(PdhValidatePath) +PDH_STATUS WINAPI PdhValidatePathExA(PDH_HLOG, LPCSTR); +PDH_STATUS WINAPI PdhValidatePathExW(PDH_HLOG, LPCWSTR); +#define PdhValidatePathEx WINELIB_NAME_AW(PdhValidatePathEx) #ifdef __cplusplus } diff --git a/include/pdhmsg.h b/include/pdhmsg.h index 00563a0..bee466e 100644 --- a/include/pdhmsg.h +++ b/include/pdhmsg.h @@ -30,6 +30,7 @@ #define PDH_MEMORY_ALLOCATION_FAILURE 0xc0000bbb #define PDH_INVALID_HANDLE 0xc0000bbc #define PDH_INVALID_ARGUMENT 0xc0000bbd +#define PDH_CSTATUS_BAD_COUNTERNAME 0xc0000bc0 #define PDH_INSUFFICIENT_BUFFER 0xc0000bc2 #define PDH_INVALID_DATA 0xc0000bc6 #define PDH_STRING_NOT_FOUND 0xc0000bd4

1 0

Hans Leidekker : pdh: Add tests for PdhValidatePath{, Ex}{A, W}.
by Alexandre Julliard 01 Oct '07

01 Oct '07

Module: wine Branch: master Commit: 9209582048edd1e60833cdb6fd183e217a019847 URL: http://source.winehq.org/git/wine.git/?a=commit;h=9209582048edd1e60833cdb6f… Author: Hans Leidekker <hans(a)it.vu.nl> Date: Sat Sep 29 21:06:07 2007 +0200 pdh: Add tests for PdhValidatePath{, Ex}{A, W}. --- dlls/pdh/tests/pdh.c | 108 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 108 insertions(+), 0 deletions(-) diff --git a/dlls/pdh/tests/pdh.c b/dlls/pdh/tests/pdh.c index 104589e..85b0853 100644 --- a/dlls/pdh/tests/pdh.c +++ b/dlls/pdh/tests/pdh.c @@ -32,6 +32,8 @@ static HMODULE pdh; static PDH_STATUS (WINAPI *pPdhAddEnglishCounterA)(PDH_HQUERY, LPCSTR, DWORD_PTR, PDH_HCOUNTER *); static PDH_STATUS (WINAPI *pPdhAddEnglishCounterW)(PDH_HQUERY, LPCWSTR, DWORD_PTR, PDH_HCOUNTER *); static PDH_STATUS (WINAPI *pPdhCollectQueryDataWithTime)(PDH_HQUERY, LONGLONG *); +static PDH_STATUS (WINAPI *pPdhValidatePathExA)(PDH_HLOG, LPCSTR); +static PDH_STATUS (WINAPI *pPdhValidatePathExW)(PDH_HLOG, LPCWSTR); #define GETFUNCPTR(func) p##func = (void *)GetProcAddress( pdh, #func ); @@ -41,6 +43,8 @@ static void init_function_ptrs( void ) GETFUNCPTR( PdhAddEnglishCounterA ) GETFUNCPTR( PdhAddEnglishCounterW ) GETFUNCPTR( PdhCollectQueryDataWithTime ) + GETFUNCPTR( PdhValidatePathExA ) + GETFUNCPTR( PdhValidatePathExW ) } static const WCHAR processor_time[] = @@ -695,6 +699,104 @@ static void test_PdhLookupPerfNameByIndexW( void ) ok(size == sizeof(uptime) / sizeof(WCHAR), "PdhLookupPerfNameByIndexW failed %d\n", size); } +static void test_PdhValidatePathA( void ) +{ + PDH_STATUS ret; + + ret = PdhValidatePathA( NULL ); + ok(ret == PDH_INVALID_ARGUMENT, "PdhValidatePathA failed 0x%08x\n", ret); + + ret = PdhValidatePathA( "" ); + ok(ret == PDH_INVALID_ARGUMENT, "PdhValidatePathA failed 0x%08x\n", ret); + + ret = PdhValidatePathA( "\\System" ); + ok(ret == PDH_CSTATUS_BAD_COUNTERNAME, "PdhValidatePathA failed 0x%08x\n", ret); + + ret = PdhValidatePathA( "System Up Time" ); + ok(ret == PDH_CSTATUS_BAD_COUNTERNAME, "PdhValidatePathA failed 0x%08x\n", ret); + + ret = PdhValidatePathA( "\\System\\System Down Time" ); + ok(ret == PDH_CSTATUS_NO_COUNTER, "PdhValidatePathA failed 0x%08x\n", ret); + + ret = PdhValidatePathA( "\\System\\System Up Time" ); + ok(ret == ERROR_SUCCESS, "PdhValidatePathA failed 0x%08x\n", ret); +} + +static void test_PdhValidatePathW( void ) +{ + PDH_STATUS ret; + + static const WCHAR empty[] = {0}; + static const WCHAR system[] = {'\\','S','y','s','t','e','m',0}; + + ret = PdhValidatePathW( NULL ); + ok(ret == PDH_INVALID_ARGUMENT, "PdhValidatePathW failed 0x%08x\n", ret); + + ret = PdhValidatePathW( empty ); + ok(ret == PDH_INVALID_ARGUMENT, "PdhValidatePathW failed 0x%08x\n", ret); + + ret = PdhValidatePathW( system ); + ok(ret == PDH_CSTATUS_BAD_COUNTERNAME, "PdhValidatePathW failed 0x%08x\n", ret); + + ret = PdhValidatePathW( uptime ); + ok(ret == PDH_CSTATUS_BAD_COUNTERNAME, "PdhValidatePathW failed 0x%08x\n", ret); + + ret = PdhValidatePathW( system_downtime ); + ok(ret == PDH_CSTATUS_NO_COUNTER, "PdhValidatePathW failed 0x%08x\n", ret); + + ret = PdhValidatePathW( system_uptime ); + ok(ret == ERROR_SUCCESS, "PdhValidatePathW failed 0x%08x\n", ret); +} + +static void test_PdhValidatePathExA( void ) +{ + PDH_STATUS ret; + + ret = pPdhValidatePathExA( NULL, NULL ); + ok(ret == PDH_INVALID_ARGUMENT, "PdhValidatePathExA failed 0x%08x\n", ret); + + ret = pPdhValidatePathExA( NULL, "" ); + ok(ret == PDH_INVALID_ARGUMENT, "PdhValidatePathExA failed 0x%08x\n", ret); + + ret = pPdhValidatePathExA( NULL, "\\System" ); + ok(ret == PDH_CSTATUS_BAD_COUNTERNAME, "PdhValidatePathExA failed 0x%08x\n", ret); + + ret = pPdhValidatePathExA( NULL, "System Up Time" ); + ok(ret == PDH_CSTATUS_BAD_COUNTERNAME, "PdhValidatePathExA failed 0x%08x\n", ret); + + ret = pPdhValidatePathExA( NULL, "\\System\\System Down Time" ); + ok(ret == PDH_CSTATUS_NO_COUNTER, "PdhValidatePathExA failed 0x%08x\n", ret); + + ret = pPdhValidatePathExA( NULL, "\\System\\System Up Time" ); + ok(ret == ERROR_SUCCESS, "PdhValidatePathExA failed 0x%08x\n", ret); +} + +static void test_PdhValidatePathExW( void ) +{ + PDH_STATUS ret; + + static const WCHAR empty[] = {0}; + static const WCHAR system[] = {'\\','S','y','s','t','e','m',0}; + + ret = pPdhValidatePathExW( NULL, NULL ); + ok(ret == PDH_INVALID_ARGUMENT, "PdhValidatePathExW failed 0x%08x\n", ret); + + ret = pPdhValidatePathExW( NULL, empty ); + ok(ret == PDH_INVALID_ARGUMENT, "PdhValidatePathExW failed 0x%08x\n", ret); + + ret = pPdhValidatePathExW( NULL, system ); + ok(ret == PDH_CSTATUS_BAD_COUNTERNAME, "PdhValidatePathExW failed 0x%08x\n", ret); + + ret = pPdhValidatePathExW( NULL, uptime ); + ok(ret == PDH_CSTATUS_BAD_COUNTERNAME, "PdhValidatePathExW failed 0x%08x\n", ret); + + ret = pPdhValidatePathExW( NULL, system_downtime ); + ok(ret == PDH_CSTATUS_NO_COUNTER, "PdhValidatePathExW failed 0x%08x\n", ret); + + ret = pPdhValidatePathExW( NULL, system_uptime ); + ok(ret == ERROR_SUCCESS, "PdhValidatePathExW failed 0x%08x\n", ret); +} + START_TEST(pdh) { init_function_ptrs(); @@ -722,4 +824,10 @@ START_TEST(pdh) test_PdhLookupPerfNameByIndexA(); test_PdhLookupPerfNameByIndexW(); + + test_PdhValidatePathA(); + test_PdhValidatePathW(); + + if (pPdhValidatePathExA) test_PdhValidatePathExA(); + if (pPdhValidatePathExW) test_PdhValidatePathExW(); }

1 0