December 2007 - Wine-commits

Rob Shearman : rpcss: Zero the memory of several variables before writing them to the pipe to silence Valgrind warnings .
by Alexandre Julliard 27 Dec '07

27 Dec '07

Module: wine Branch: master Commit: 63a74c7dd483ab12a03ba7972c15a14e74a0c0b0 URL: http://source.winehq.org/git/wine.git/?a=commit;h=63a74c7dd483ab12a03ba7972… Author: Rob Shearman <rob(a)codeweavers.com> Date: Thu Dec 27 10:01:09 2007 +0000 rpcss: Zero the memory of several variables before writing them to the pipe to silence Valgrind warnings. --- programs/rpcss/np_server.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/programs/rpcss/np_server.c b/programs/rpcss/np_server.c index 1708947..d26cf32 100644 --- a/programs/rpcss/np_server.c +++ b/programs/rpcss/np_server.c @@ -110,6 +110,7 @@ static void RPCSS_ServerProcessRESOLVEEPMessage(PRPCSS_NP_MESSAGE pMsg, static void RPCSS_ServerProcessMessage(PRPCSS_NP_MESSAGE pMsg, PRPCSS_NP_REPLY pReply, char *vardata) { WINE_TRACE("\n"); + ZeroMemory(pReply, sizeof(*pReply)); switch (pMsg->message_type) { case RPCSS_NP_MESSAGE_TYPEID_RANMSG: RPCSS_ServerProcessRANMessage(pMsg, pReply); @@ -436,6 +437,7 @@ BOOL RPCSS_BecomePipeServer(void) */ if ((client_handle = RPCSS_NPConnect()) != INVALID_HANDLE_VALUE) { + ZeroMemory(&msg, sizeof(msg)); msg.message_type = RPCSS_NP_MESSAGE_TYPEID_RANMSG; msg.message.ranmsg.timeout = 1000; msg.vardata_payload_size = 0;

1 0

Rob Shearman : explorer: Fix memory leak when one or more properties are not present on a hal device .
by Alexandre Julliard 27 Dec '07

27 Dec '07

Module: wine Branch: master Commit: 1f90e8865746eba755a0ed87051abf8ea01cec65 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1f90e8865746eba755a0ed870… Author: Rob Shearman <rob(a)codeweavers.com> Date: Thu Dec 27 10:01:13 2007 +0000 explorer: Fix memory leak when one or more properties are not present on a hal device. --- programs/explorer/hal.c | 14 ++++++++------ 1 files changed, 8 insertions(+), 6 deletions(-) diff --git a/programs/explorer/hal.c b/programs/explorer/hal.c index 6b5be46..38b0523 100644 --- a/programs/explorer/hal.c +++ b/programs/explorer/hal.c @@ -112,7 +112,10 @@ static WINE_EXCEPTION_FILTER(assert_fault) static void new_device( LibHalContext *ctx, const char *udi ) { DBusError error; - char *parent, *mount_point, *device, *type; + char *parent = NULL; + char *mount_point = NULL; + char *device = NULL; + char *type = NULL; p_dbus_error_init( &error ); @@ -133,15 +136,14 @@ static void new_device( LibHalContext *ctx, const char *udi ) add_dos_device( udi, device, mount_point, type ); - if (type) p_libhal_free_string( type ); - p_libhal_free_string( parent ); - p_libhal_free_string( device ); - p_libhal_free_string( mount_point ); - /* add property watch for mount point */ p_libhal_device_add_property_watch( ctx, udi, &error ); done: + if (type) p_libhal_free_string( type ); + if (parent) p_libhal_free_string( parent ); + if (device) p_libhal_free_string( device ); + if (mount_point) p_libhal_free_string( mount_point ); p_dbus_error_free( &error ); }

1 0

Alexander Dorofeyev : wined3d: Also update alpha test when stage texture is NULL.
by Alexandre Julliard 27 Dec '07

27 Dec '07

Module: wine Branch: master Commit: 27c98fd6287df0595842eba8d5ef507316187f7b URL: http://source.winehq.org/git/wine.git/?a=commit;h=27c98fd6287df0595842eba8d… Author: Alexander Dorofeyev <alexd4(a)inbox.lv> Date: Thu Dec 27 00:23:59 2007 -0800 wined3d: Also update alpha test when stage texture is NULL. --- dlls/wined3d/state.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/dlls/wined3d/state.c b/dlls/wined3d/state.c index 08ad5c2..8e9e19b 100644 --- a/dlls/wined3d/state.c +++ b/dlls/wined3d/state.c @@ -2421,6 +2421,13 @@ static void sampler(DWORD state, IWineD3DStateBlockImpl *stateblock, WineD3DCont if(!isStateDirty(context, STATE_TEXTURESTAGE(sampler, WINED3DTSS_COLOROP))) { activate_dimensions(sampler, stateblock, context); } + + if(stateblock->renderState[WINED3DRS_COLORKEYENABLE] && sampler == 0) { + /* If color keying is enabled update the alpha test, it depends on the existence + * of a color key in stage 0 + */ + state_alpha(WINED3DRS_COLORKEYENABLE, stateblock, context); + } } /* Otherwise tex_colorop disables the stage */ glBindTexture(GL_TEXTURE_2D, stateblock->wineD3DDevice->dummyTextureName[sampler]); checkGLcall("glBindTexture(GL_TEXTURE_2D, stateblock->wineD3DDevice->dummyTextureName[sampler])");

1 0

Gerald Pfeifer : msi: Fix error handling in encode_streamname().
by Alexandre Julliard 27 Dec '07

27 Dec '07

Module: wine Branch: master Commit: 05cf0bdf815d6883c9bce08f3c145538090cd90b URL: http://source.winehq.org/git/wine.git/?a=commit;h=05cf0bdf815d6883c9bce08f3… Author: Gerald Pfeifer <gerald(a)pfeifer.com> Date: Wed Dec 26 22:44:22 2007 +0100 msi: Fix error handling in encode_streamname(). --- dlls/msi/table.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/msi/table.c b/dlls/msi/table.c index ca6fa1b..e5ad1af 100644 --- a/dlls/msi/table.c +++ b/dlls/msi/table.c @@ -189,7 +189,7 @@ LPWSTR encode_streamname(BOOL bTable, LPCWSTR in) if( next && (next<0x80) ) { next = utf2mime(next); - if( next >= 0 ) + if( next != -1 ) { next += 0x3ffffc0; ch += (next<<6);

1 0

Stefan Dösinger : wined3d: Fix a problem in BltOverride.
by Alexandre Julliard 27 Dec '07

27 Dec '07

Module: wine Branch: master Commit: 2bec23fd7c059e0d4c90652f12d8c0675a620602 URL: http://source.winehq.org/git/wine.git/?a=commit;h=2bec23fd7c059e0d4c90652f1… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Tue Dec 25 22:57:01 2007 +0100 wined3d: Fix a problem in BltOverride. --- dlls/wined3d/surface.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c index 30d6507..f9df55e 100644 --- a/dlls/wined3d/surface.c +++ b/dlls/wined3d/surface.c @@ -2974,13 +2974,11 @@ static HRESULT IWineD3DSurfaceImpl_BltOverride(IWineD3DSurfaceImpl *This, RECT * } else if(dstSwapchain) { if(SrcSurface != myDevice->render_targets[0]) { ERR("Unexpected render target -> render target blit\n"); + return 0; } TRACE("Blit from active render target to a swapchain\n"); /* Handled with regular texture -> swapchain blit */ - } else if(srcSwapchain) { - if(This != (IWineD3DSurfaceImpl *) myDevice->render_targets[0]) { - ERR("Unexpected render target -> render target blit\n"); - } + } else if(srcSwapchain && This == (IWineD3DSurfaceImpl *) myDevice->render_targets[0]) { FIXME("Implement blit from a swapchain to the active render target\n"); return WINED3DERR_INVALIDCALL; }

1 0

Zachary Goldberg : Fix some typos
by Jeremy Newman 26 Dec '07

26 Dec '07

Module: website Branch: master Commit: e46cdf8cc788e468069d4642355a2a913805baac URL: http://source.winehq.org/git/website.git/?a=commit;h=e46cdf8cc788e468069d46… Author: Zachary Goldberg <zgs(a)seas.upenn.edu> Date: Mon Dec 24 10:14:15 2007 -0500 Fix some typos Thanks Dan Kegel --- wwn/wn20071224_336.xml | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/wwn/wn20071224_336.xml b/wwn/wn20071224_336.xml index 184be75..ae7bbd6 100644 --- a/wwn/wn20071224_336.xml +++ b/wwn/wn20071224_336.xml @@ -76,9 +76,7 @@ Picasa, Google's now famous iPhoto-style application now has a <a href="http://p <quote> Google has released a beta preview of Picasa 2.7 for Linux adding web album integration, more editing features and better RAW support. The new beta still isn't a native app (much of its code comes from the Windows version and runs via the included Wine components), but it does run considerably faster and the web album features will be welcome news for Picasa Web users. -Despite the improvements, the Linux version of Picasa lags behind its Windows counterpart in a number of areas - there's still no video support, full-screen slideshows won't work and many of the blogging features are missing. - -That said, Picasa's RAW support "just works" much better than any of the other options I've tried, and it remains (even as a beta) quite snappy and stable. +[...] Picasa's RAW support "just works" much better than any of the other options I've tried, and it remains (even as a beta) quite snappy and stable. </quote> @@ -190,7 +188,7 @@ volunteers the next day: </quote> -Of course this thread wouldn't be complete without Alex Julliard also reliving old memories: +Of course this thread wouldn't be complete without Alexandre Julliard also reliving old memories: <quote> The 0.0.2 release was on June 29, and 0.0.1 was about a week before

1 0

Jeremy Newman : add font tag support to wwn xml parser
by Jeremy Newman 26 Dec '07

26 Dec '07

Module: website Branch: master Commit: ded81c279d350b732bdd4ec0c251cc70f852ac19 URL: http://source.winehq.org/git/website.git/?a=commit;h=ded81c279d350b732bdd4e… Author: Jeremy Newman <jnewman(a)codeweavers.com> Date: Wed Dec 26 10:07:31 2007 -0600 add font tag support to wwn xml parser Author: Zachary Goldberg <zgs(a)seas.upenn.edu> --- include/wwn.php | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/wwn.php b/include/wwn.php index 0d9f8ec..14ca6b2 100644 --- a/include/wwn.php +++ b/include/wwn.php @@ -30,6 +30,7 @@ class wwn "center" => "center", "code" => "code", "div" => "div", + "font" => "font", "i" => "i", "img" => "img", "li" => "li",

1 0

Jeremy Newman : WWN Issue 336
by Jeremy Newman 26 Dec '07

26 Dec '07

Module: website Branch: master Commit: f57f31e2466b2af4b80f5f83d2fd426b4dbb47c0 URL: http://source.winehq.org/git/website.git/?a=commit;h=f57f31e2466b2af4b80f5f… Author: Jeremy Newman <jnewman(a)codeweavers.com> Date: Wed Dec 26 10:34:40 2007 -0600 WWN Issue 336 --- news/2007122401.xml | 7 + wwn/wn20071224_336.xml | 670 ++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 677 insertions(+), 0 deletions(-) Diff: http://source.winehq.org/git/website.git/?a=commitdiff;h=f57f31e2466b2af4b8…

1 0

Alexander Dorofeyev : wined3d: Add zero/near zero vertex rhw special case.
by Alexandre Julliard 26 Dec '07

26 Dec '07

Module: wine Branch: master Commit: 1e23602d4bc93ebf609c2a6d99654e2bf3996786 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1e23602d4bc93ebf609c2a6d9… Author: Alexander Dorofeyev <alexd4(a)inbox.lv> Date: Tue Dec 25 00:18:21 2007 -0800 wined3d: Add zero/near zero vertex rhw special case. --- dlls/wined3d/directx.c | 9 +++++++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/dlls/wined3d/directx.c b/dlls/wined3d/directx.c index 9e6bf33..9536b71 100644 --- a/dlls/wined3d/directx.c +++ b/dlls/wined3d/directx.c @@ -2906,9 +2906,14 @@ static void position_d3dcolor(void *data) { } static void position_float4(void *data) { GLfloat *pos = (float *) data; - float w = 1.0 / pos[3]; - glVertex4f(pos[0] * w, pos[1] * w, pos[2] * w, w); + if (pos[3] < eps && pos[3] > -eps) + glVertex3fv(pos); + else { + float w = 1.0 / pos[3]; + + glVertex4f(pos[0] * w, pos[1] * w, pos[2] * w, w); + } } static void diffuse_d3dcolor(void *data) {

1 0

Alexander Nicolaysen Sørnes : comdlg32: PageSetupDlgW: Load paper orientation in ChangePrinterW.
by Alexandre Julliard 26 Dec '07

26 Dec '07

Module: wine Branch: master Commit: 5624948c71157d2ec3c7864d5cc32d04e8ed922c URL: http://source.winehq.org/git/wine.git/?a=commit;h=5624948c71157d2ec3c7864d5… Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Date: Sun Dec 23 15:55:15 2007 +0100 comdlg32: PageSetupDlgW: Load paper orientation in ChangePrinterW. --- dlls/comdlg32/printdlg.c | 53 +++++++++++++++++++++++---------------------- 1 files changed, 27 insertions(+), 26 deletions(-) diff --git a/dlls/comdlg32/printdlg.c b/dlls/comdlg32/printdlg.c index dd290d5..6b8ed15 100644 --- a/dlls/comdlg32/printdlg.c +++ b/dlls/comdlg32/printdlg.c @@ -2684,6 +2684,23 @@ PRINTDLG_PS_ChangePrinterA(HWND hDlg, PageSetupDataA *pda) { return TRUE; } +static void PRINTDLG_PS_SetOrientationW(HWND hDlg, PageSetupDataW* pda) +{ + WCHAR PaperName[64]; + + GetDlgItemTextW(hDlg, cmb2, PaperName, sizeof(PaperName)/sizeof(WCHAR)); + PRINTDLG_PaperSizeW(&pda->pdlg, PaperName, &pda->curdlg.ptPaperSize); + pda->curdlg.ptPaperSize.x = _c_10mm2size((LPPAGESETUPDLGA)pda->dlga, pda->curdlg.ptPaperSize.x); + pda->curdlg.ptPaperSize.y = _c_10mm2size((LPPAGESETUPDLGA)pda->dlga, pda->curdlg.ptPaperSize.y); + + if(IsDlgButtonChecked(hDlg, rad2)) + { + DWORD tmp = pda->curdlg.ptPaperSize.x; + pda->curdlg.ptPaperSize.x = pda->curdlg.ptPaperSize.y; + pda->curdlg.ptPaperSize.y = tmp; + } +} + static BOOL PRINTDLG_PS_ChangePrinterW(HWND hDlg, PageSetupDataW *pda) { DEVNAMES *dn; @@ -2696,8 +2713,18 @@ PRINTDLG_PS_ChangePrinterW(HWND hDlg, PageSetupDataW *pda) { portname = ((WCHAR*)dn)+dn->wOutputOffset; PRINTDLG_SetUpPaperComboBoxW(hDlg,cmb2,devname,portname,dm); PRINTDLG_SetUpPaperComboBoxW(hDlg,cmb3,devname,portname,dm); + + /* Landscape orientation */ + if (dm->u1.s1.dmOrientation == DMORIENT_LANDSCAPE) + CheckRadioButton(hDlg, rad1, rad2, rad2); + else /* this is default if papersize is not set */ + CheckRadioButton(hDlg, rad1, rad2, rad1); + GlobalUnlock(pda->pdlg.hDevNames); GlobalUnlock(pda->pdlg.hDevMode); + + PRINTDLG_PS_SetOrientationW(hDlg, pda); + return TRUE; } @@ -3302,7 +3329,6 @@ PageDlgProcW(HWND hDlg, UINT uMsg, WPARAM wParam, LPARAM lParam) { '_', '_', 'W', 'I', 'N', 'E', '_', 'P', 'A', 'G', 'E', 'S', 'E', 'T', 'U', 'P', 'D', 'L', 'G', 'D', 'A', 'T', 'A', 0 }; PageSetupDataW *pda; - LPDEVMODEW dm; BOOL res = FALSE; if (uMsg==WM_INITDIALOG) { @@ -3332,31 +3358,6 @@ PageDlgProcW(HWND hDlg, UINT uMsg, WPARAM wParam, LPARAM lParam) PRINTDLG_PS_ChangePrinterW(hDlg,pda); - if(pda->dlga->hDevMode) - { - WCHAR PaperName[64]; - - dm = GlobalLock(pda->dlga->hDevMode); - /* Landscape orientation */ - if (dm->u1.s1.dmOrientation == DMORIENT_LANDSCAPE) - CheckRadioButton(hDlg, rad1, rad2, rad2); - else /* this is default if papersize is not set */ - CheckRadioButton(hDlg, rad1, rad2, rad1); - - GetDlgItemTextW(hDlg, cmb2, PaperName, sizeof(PaperName)/sizeof(WCHAR)); - PRINTDLG_PaperSizeW(&pda->pdlg, PaperName, &pda->curdlg.ptPaperSize); - pda->curdlg.ptPaperSize.x = _c_10mm2size((LPPAGESETUPDLGA)pda->dlga, pda->curdlg.ptPaperSize.x); - pda->curdlg.ptPaperSize.y = _c_10mm2size((LPPAGESETUPDLGA)pda->dlga, pda->curdlg.ptPaperSize.y); - GlobalUnlock(pda->dlga->hDevMode); - - if(IsDlgButtonChecked(hDlg, rad2)) - { - DWORD tmp = pda->curdlg.ptPaperSize.x; - pda->curdlg.ptPaperSize.x = pda->curdlg.ptPaperSize.y; - pda->curdlg.ptPaperSize.y = tmp; - } - } - if (pda->dlga->Flags & PSD_DISABLEORIENTATION) { EnableWindow(GetDlgItem(hDlg,rad1),FALSE); EnableWindow(GetDlgItem(hDlg,rad2),FALSE);

1 0