March 2007 - Wine-commits - list.winehq.org

Hagop Hagopian : comctl32: tab: Added message sequence tests for the tab control.
by Alexandre Julliard 19 Mar '07

19 Mar '07

Module: wine Branch: master Commit: 62d3be772ddbedc9295a4dd848b003599dc67ed1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=62d3be772ddbedc9295a4dd84… Author: Hagop Hagopian <shaitani(a)gmail.com> Date: Sat Mar 17 14:12:13 2007 -0800 comctl32: tab: Added message sequence tests for the tab control. --- dlls/comctl32/tests/tab.c | 358 ++++++++++++++++++++++++++++++++++++++++++++- 1 files changed, 352 insertions(+), 6 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=62d3be772ddbedc9295a4…

1 0

Hagop Hagopian : comctl32: tab: Minor bug fixes in the curSel and curFocus getters and setters.
by Alexandre Julliard 19 Mar '07

19 Mar '07

Module: wine Branch: master Commit: 637a6116e2bb10689a22e3d24524174cc0dfd370 URL: http://source.winehq.org/git/wine.git/?a=commit;h=637a6116e2bb10689a22e3d24… Author: Hagop Hagopian <shaitani(a)gmail.com> Date: Sat Mar 17 14:16:08 2007 -0800 comctl32: tab: Minor bug fixes in the curSel and curFocus getters and setters. --- dlls/comctl32/tab.c | 54 ++++++++++++++++++++------------------------ dlls/comctl32/tests/tab.c | 7 +----- 2 files changed, 26 insertions(+), 35 deletions(-) diff --git a/dlls/comctl32/tab.c b/dlls/comctl32/tab.c index c63b0f7..0b0712e 100644 --- a/dlls/comctl32/tab.c +++ b/dlls/comctl32/tab.c @@ -231,19 +231,10 @@ static inline LRESULT TAB_GetCurSel (const TAB_INFO *infoPtr) } /* RETURNS - * the index of the tab item that has the focus - * NOTE - * we have not to return negative value - * TODO - * test for windows */ + * the index of the tab item that has the focus. */ static inline LRESULT TAB_GetCurFocus (const TAB_INFO *infoPtr) { - if (infoPtr->uFocus<0) - { - FIXME("we have not to return negative value\n"); - return 0; - } return infoPtr->uFocus; } @@ -255,10 +246,13 @@ static inline LRESULT TAB_GetToolTips (const TAB_INFO *infoPtr) static inline LRESULT TAB_SetCurSel (TAB_INFO *infoPtr, INT iItem) { - INT prevItem = -1; + INT prevItem = infoPtr->iSelected; - if (iItem >= 0 && iItem < infoPtr->uNumItem) { - prevItem=infoPtr->iSelected; + if (iItem < 0) + infoPtr->iSelected=-1; + else if (iItem >= infoPtr->uNumItem) + return -1; + else { if (infoPtr->iSelected != iItem) { infoPtr->iSelected=iItem; TAB_EnsureSelectionVisible(infoPtr); @@ -270,23 +264,25 @@ static inline LRESULT TAB_SetCurSel (TAB_INFO *infoPtr, INT iItem) static LRESULT TAB_SetCurFocus (TAB_INFO *infoPtr, INT iItem) { - if (iItem < 0 || iItem >= infoPtr->uNumItem) return 0; - - if (GetWindowLongW(infoPtr->hwnd, GWL_STYLE) & TCS_BUTTONS) { - FIXME("Should set input focus\n"); - } else { - int oldFocus = infoPtr->uFocus; - if (infoPtr->iSelected != iItem || oldFocus == -1 ) { - infoPtr->uFocus = iItem; - if (oldFocus != -1) { - if (!TAB_SendSimpleNotify(infoPtr, TCN_SELCHANGING)) { - infoPtr->iSelected = iItem; - TAB_SendSimpleNotify(infoPtr, TCN_SELCHANGE); + if (iItem < 0) + infoPtr->uFocus = -1; + else if (iItem < infoPtr->uNumItem) { + if (GetWindowLongW(infoPtr->hwnd, GWL_STYLE) & TCS_BUTTONS) { + FIXME("Should set input focus\n"); + } else { + int oldFocus = infoPtr->uFocus; + if (infoPtr->iSelected != iItem || oldFocus == -1 ) { + infoPtr->uFocus = iItem; + if (oldFocus != -1) { + if (!TAB_SendSimpleNotify(infoPtr, TCN_SELCHANGING)) { + infoPtr->iSelected = iItem; + TAB_SendSimpleNotify(infoPtr, TCN_SELCHANGE); + } + else + infoPtr->iSelected = iItem; + TAB_EnsureSelectionVisible(infoPtr); + TAB_InvalidateTabArea(infoPtr); } - else - infoPtr->iSelected = iItem; - TAB_EnsureSelectionVisible(infoPtr); - TAB_InvalidateTabArea(infoPtr); } } } diff --git a/dlls/comctl32/tests/tab.c b/dlls/comctl32/tests/tab.c index c4fa1c3..59cd969 100644 --- a/dlls/comctl32/tests/tab.c +++ b/dlls/comctl32/tests/tab.c @@ -663,9 +663,7 @@ static void test_getters_setters(INT nTabs) /* Testing CurFocus with negative value */ SendMessage(hTab, TCM_SETCURFOCUS, -10, 0); focusIndex = SendMessage(hTab, TCM_GETCURFOCUS, 0, 0); - todo_wine{ expect(-1, focusIndex); - } /* Testing CurFocus with value larger than number of tabs */ focusIndex = SendMessage(hTab, TCM_SETCURSEL, 1, 0); @@ -697,15 +695,12 @@ static void test_getters_setters(INT nTabs) /* Testing CurSel with negative value */ SendMessage(hTab, TCM_SETCURSEL, -10, 0); selectionIndex = SendMessage(hTab, TCM_GETCURSEL, 0, 0); - todo_wine{ expect(-1, selectionIndex); - } /* Testing CurSel with value larger than number of tabs */ selectionIndex = SendMessage(hTab, TCM_SETCURSEL, 1, 0); - todo_wine{ expect(-1, selectionIndex); - } + selectionIndex = SendMessage(hTab, TCM_SETCURSEL, nTabs+1, 0); expect(-1, selectionIndex); selectionIndex = SendMessage(hTab, TCM_GETCURFOCUS, 0, 0);

1 0

Dmitry Timoshkov : winex11.drv: In the case requested glyphs do not present in the font fail gracefully instead of asserting .
by Alexandre Julliard 19 Mar '07

19 Mar '07

Module: wine Branch: master Commit: 520aa9f54848dde87a11b3adee223e3779062619 URL: http://source.winehq.org/git/wine.git/?a=commit;h=520aa9f54848dde87a11b3ade… Author: Dmitry Timoshkov <dmitry(a)codeweavers.com> Date: Sun Mar 18 22:09:34 2007 +0800 winex11.drv: In the case requested glyphs do not present in the font fail gracefully instead of asserting. --- dlls/gdi32/freetype.c | 2 +- dlls/winex11.drv/xrender.c | 9 +++++++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c index 4aa2c20..1f90a87 100644 --- a/dlls/gdi32/freetype.c +++ b/dlls/gdi32/freetype.c @@ -3398,7 +3398,7 @@ DWORD WineEngGetGlyphOutline(GdiFont *font, UINT glyph, UINT format, err = pFT_Load_Glyph(ft_face, glyph_index, load_flags); if(err) { - FIXME("FT_Load_Glyph on index %x returns %d\n", glyph_index, err); + WARN("FT_Load_Glyph on index %x returns %d\n", glyph_index, err); return GDI_ERROR; } diff --git a/dlls/winex11.drv/xrender.c b/dlls/winex11.drv/xrender.c index 9c5e274..66b3dd4 100644 --- a/dlls/winex11.drv/xrender.c +++ b/dlls/winex11.drv/xrender.c @@ -655,7 +655,7 @@ static BOOL UploadGlyph(X11DRV_PDEVICE *physDev, int glyph, AA_Type format) NULL); } if(buflen == GDI_ERROR) { - ERR("GetGlyphOutlineW failed\n"); + WARN("GetGlyphOutlineW failed\n"); return FALSE; } TRACE("Turning off antialiasing for this monochrome font\n"); @@ -1258,7 +1258,12 @@ BOOL X11DRV_XRender_ExtTextOut( X11DRV_PDEVICE *physDev, INT x, INT y, UINT flag UploadGlyph(physDev, wstr[idx], antialias); } } - assert(formatEntry); + if (!formatEntry) + { + WARN("could not upload requested glyphs\n"); + LeaveCriticalSection(&xrender_cs); + goto done_unlock; + } TRACE("Writing %s at %d,%d\n", debugstr_wn(wstr,count), physDev->dc_rect.left + x, physDev->dc_rect.top + y);

1 0

Dmitry Timoshkov : msvcrt: Print FIXME on platforms where _except_handler3 is a stub.
by Alexandre Julliard 19 Mar '07

19 Mar '07

Module: wine Branch: master Commit: 63da5f26c2c8c59f694e4c2e5f43589a6ae72abc URL: http://source.winehq.org/git/wine.git/?a=commit;h=63da5f26c2c8c59f694e4c2e5… Author: Dmitry Timoshkov <dmitry(a)codeweavers.com> Date: Sun Mar 18 22:10:07 2007 +0800 msvcrt: Print FIXME on platforms where _except_handler3 is a stub. --- dlls/msvcrt/except.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/msvcrt/except.c b/dlls/msvcrt/except.c index f204e8b..3ed3245 100644 --- a/dlls/msvcrt/except.c +++ b/dlls/msvcrt/except.c @@ -234,7 +234,7 @@ int CDECL _except_handler3(PEXCEPTION_RECORD rec, } } #else - TRACE("exception %lx flags=%lx at %p handler=%p %p %p stub\n", + FIXME("exception %lx flags=%lx at %p handler=%p %p %p stub\n", rec->ExceptionCode, rec->ExceptionFlags, rec->ExceptionAddress, frame->handler, context, dispatcher); #endif

1 0

appdb/ admin/adminTestResults.php include/side ...
by WineHQ 18 Mar '07

18 Mar '07

ChangeSet ID: 30987 CVSROOT: /opt/cvs-commit Module name: appdb Changes by: wineowner(a)winehq.org 2007/03/18 17:15:06 Modified files: admin : adminTestResults.php include : sidebar_admin.php sidebar_maintainer_admin.php testData.php Log message: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Let objectManager show testResults queue. Maintainers now get a list of queued test results for versions they maintain. Patch: http://cvs.winehq.org/patch.py?id=30987 Old revision New revision Changes Path 1.19 1.20 +0 -22 appdb/admin/adminTestResults.php 1.32 1.33 +5 -2 appdb/include/sidebar_admin.php 1.4 1.5 +3 -0 appdb/include/sidebar_maintainer_admin.php 1.22 1.23 +168 -40 appdb/include/testData.php

1 0

appdb/. testResults.php
by WineHQ 18 Mar '07

18 Mar '07

ChangeSet ID: 30986 CVSROOT: /opt/cvs-commit Module name: appdb Changes by: wineowner(a)winehq.org 2007/03/18 17:11:28 Modified files: . : testResults.php Log message: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Remove queue listing from testResults.php, the queue is displayed in admin/adminTestData.php Patch: http://cvs.winehq.org/patch.py?id=30986 Old revision New revision Changes Path 1.26 1.27 +2 -46 appdb/testResults.php Index: appdb/testResults.php diff -u -p appdb/testResults.php:1.26 appdb/testResults.php:1.27 --- appdb/testResults.php:1.26 18 Mar 2007 22:11:28 -0000 +++ appdb/testResults.php 18 Mar 2007 22:11:28 -0000 @@ -163,51 +163,7 @@ if ($aClean['sSub']) } else // if ($aClean['sSub']) is not defined, display the Testing results queue page { - apidb_header("Testing Results"); - - // Get queued testing results. - $oTest = new TestData(); - $hResult = $oTest->getTestingQueue("true"); - - if(!$hResult) - { - // no Tests in queue - echo html_frame_start("Submitted Testing Results","90%"); - echo '<p><b>The Submitted Testing Results Queue is empty.</b></p>',"\n"; - echo html_frame_end(" "); - } - else - { - // help - echo "<div align=center><table width='90%' border=0 cellpadding=3 cellspacing=0><tr><td>\n\n"; - echo "<p>This is the list of test results waiting to be accepted or deleted.</p>\n"; - echo "<p>To view a submission, click on its name. From that page you can delete or edit and\n"; - echo "re-submit it into the AppDB.<br>\n"; - echo "</td></tr></table></div>\n\n"; - - $oTest->ShowListofTests($hResult,"Submitted Testing Results"); - } - // Get rejected testing results. - $hResult = $oTest->getTestingQueue("rejected"); - - if(!$hResult || !mysql_num_rows($hResult)) - { - //no Test Results in queue - echo html_frame_start("Rejected Testing Results","90%"); - echo '<p><b>The Rejected Testing Results Queue is empty.</b></p>',"\n"; - echo html_frame_end(" "); - } - else - { - //help - echo "<div align=center><table width='90%' border=0 cellpadding=3 cellspacing=0><tr><td>\n\n"; - echo "<p>This is the list of Rejected Test Results waiting for re-submission or deletion.</p>\n"; - echo "<p>To view a submission, click on its name. From that page you can delete or edit and re-submit it into \n"; - echo "the AppDB .<br>\n"; - echo "</td></tr></table></div>\n\n"; - - $oTest->ShowListofTests($hResult,"Rejected Test Results"); - } + util_show_error_page_and_exit("No test id defined!"); } -apidb_footer(); +apidb_footer(); ?>

1 0

appdb/include objectManager.php
by WineHQ 18 Mar '07

18 Mar '07

ChangeSet ID: 30985 CVSROOT: /opt/cvs-commit Module name: appdb Changes by: wineowner(a)winehq.org 2007/03/17 19:47:14 Modified files: include : objectManager.php Log message: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Use the full AppDB url in makeLink() Patch: http://cvs.winehq.org/patch.py?id=30985 Old revision New revision Changes Path 1.6 1.7 +1 -1 appdb/include/objectManager.php Index: appdb/include/objectManager.php diff -u -p appdb/include/objectManager.php:1.6 appdb/include/objectManager.php:1.7 --- appdb/include/objectManager.php:1.6 18 Mar 2007 0:47:14 -0000 +++ appdb/include/objectManager.php 18 Mar 2007 0:47:14 -0000 @@ -313,7 +313,7 @@ class ObjectManager $sTitle = urlencode($sTitle); - return BASE."objectManager.php?bIsQueue=$sIsQueue&sClass=$this->sClass". + return APPDB_ROOT."objectManager.php?bIsQueue=$sIsQueue&sClass=$this->sClass". "&sTitle=$sTitle$sId$sAction"; }

1 0

appdb/ ./appsubmit.php admin/adminAppQueue.php ...
by WineHQ 17 Mar '07

17 Mar '07

ChangeSet ID: 30984 CVSROOT: /opt/cvs-commit Module name: appdb Changes by: wineowner(a)winehq.org 2007/03/17 18:45:54 Modified files: . : appsubmit.php admin : adminAppQueue.php include : application.php sidebar_admin.php Log message: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Let objectManager show the application queue Patch: http://cvs.winehq.org/patch.py?id=30984 Old revision New revision Changes Path 1.65 1.66 +0 -7 appdb/appsubmit.php 1.73 1.74 +0 -31 appdb/admin/adminAppQueue.php 1.92 1.93 +104 -21 appdb/include/application.php 1.31 1.32 +4 -2 appdb/include/sidebar_admin.php

1 0

appdb/include sidebar_maintainer_admin.php
by WineHQ 17 Mar '07

17 Mar '07

ChangeSet ID: 30983 CVSROOT: /opt/cvs-commit Module name: appdb Changes by: wineowner(a)winehq.org 2007/03/17 18:40:55 Modified files: include : sidebar_maintainer_admin.php Log message: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Fix version queue link text for maintainers. Should say 'version queue' instead of 'app queue' since maintainers can only view versions. Patch: http://cvs.winehq.org/patch.py?id=30983 Old revision New revision Changes Path 1.3 1.4 +1 -1 appdb/include/sidebar_maintainer_admin.php Index: appdb/include/sidebar_maintainer_admin.php diff -u -p appdb/include/sidebar_maintainer_admin.php:1.3 appdb/include/sidebar_maintainer_admin.php:1.4 --- appdb/include/sidebar_maintainer_admin.php:1.3 17 Mar 2007 23:40:55 -0000 +++ appdb/include/sidebar_maintainer_admin.php 17 Mar 2007 23:40:55 -0000 @@ -7,7 +7,7 @@ function global_maintainer_admin_menu() $g = new htmlmenu("Maintainer Admin"); - $g->add("View App Queue (".$_SESSION['current']->getQueuedVersionCount().")", + $g->add("View Version Queue (".$_SESSION['current']->getQueuedVersionCount().")", BASE."admin/adminAppQueue.php"); $g->add("View Screenshot Queue (".appData::objectGetEntriesCount("true", "screenshot").")",

1 0

appdb/ include/appData.php include/distributio ...
by WineHQ 17 Mar '07

17 Mar '07

ChangeSet ID: 30982 CVSROOT: /opt/cvs-commit Module name: appdb Changes by: wineowner(a)winehq.org 2007/03/17 16:04:43 Modified files: include : appData.php distribution.php maintainer.php objectManager.php screenshot.php vendor.php unit_test : test_om_objects.php Log message: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Let objectManager output table headers. A class returns an array of header cells and then the objectManager adds an edit column if appropriate. Patch: http://cvs.winehq.org/patch.py?id=30982 Old revision New revision Changes Path 1.10 1.11 +2 -5 appdb/include/appData.php 1.17 1.18 +2 -5 appdb/include/distribution.php 1.32 1.33 +2 -5 appdb/include/maintainer.php 1.5 1.6 +17 -4 appdb/include/objectManager.php 1.59 1.60 +2 -2 appdb/include/screenshot.php 1.16 1.17 +3 -6 appdb/include/vendor.php 1.3 1.4 +1 -1 appdb/unit_test/test_om_objects.php Index: appdb/include/appData.php diff -u -p appdb/include/appData.php:1.10 appdb/include/appData.php:1.11 --- appdb/include/appData.php:1.10 17 Mar 2007 21: 4:43 -0000 +++ appdb/include/appData.php 17 Mar 2007 21: 4:43 -0000 @@ -199,7 +199,7 @@ class appData } - function objectOutputHeader($sClass, $sType) + function objectGetHeader($sType) { $aCells = array( "Submission Date", @@ -207,10 +207,7 @@ class appData "Application", "Version"); - if(appData::canEdit($sType)) - $aCells[] = "Action"; - - echo html_tr($aCells, $sClass); + return $aCells; } function objectGetEntries($bQueued, $iRows = 0, $iStart = 0, $sType) Index: appdb/include/distribution.php diff -u -p appdb/include/distribution.php:1.17 appdb/include/distribution.php:1.18 --- appdb/include/distribution.php:1.17 17 Mar 2007 21: 4:43 -0000 +++ appdb/include/distribution.php 17 Mar 2007 21: 4:43 -0000 @@ -400,17 +400,14 @@ class distribution { echo "</select>\n"; } - function objectOutputHeader($sClass = "") + function objectGetHeader() { $aCells = array( "Distribution name", "Distribution url", array("Linked Tests", "align=\"right\"")); - if(distribution::canEdit()) - $aCells[3] = array("Action", "align=\"center\""); - - echo html_tr($aCells, $sClass); + return $aCells; } function objectGetEntries($bQueued, $iRows = 0, $iStart = 0) Index: appdb/include/maintainer.php diff -u -p appdb/include/maintainer.php:1.32 appdb/include/maintainer.php:1.33 --- appdb/include/maintainer.php:1.32 17 Mar 2007 21: 4:43 -0000 +++ appdb/include/maintainer.php 17 Mar 2007 21: 4:43 -0000 @@ -409,7 +409,7 @@ class maintainer return $aUserIds; } - function ObjectOutputHeader($sClass) + function ObjectGetHeader() { $aCells = array( "Submission Date", @@ -418,10 +418,7 @@ class maintainer "Super maintainer?", "Submitter"); - if(maintainer::canEdit()) - $aCells[sizeof($aCells)] = "Action"; - - echo html_tr($aCells, $sClass); + return $aCells; } /* arg1 = OM object, arg2 = CSS style, arg3 = text for edit link */ Index: appdb/include/objectManager.php diff -u -p appdb/include/objectManager.php:1.5 appdb/include/objectManager.php:1.6 --- appdb/include/objectManager.php:1.5 17 Mar 2007 21: 4:43 -0000 +++ appdb/include/objectManager.php 17 Mar 2007 21: 4:43 -0000 @@ -55,7 +55,7 @@ class ObjectManager /* displays the list of entries */ function display_table() { - $this->checkMethods(array("ObjectGetEntries", "ObjectOutputHeader", + $this->checkMethods(array("ObjectGetEntries", "ObjectGetHeader", "ObjectGetInstanceFromRow", "ObjectOutputTableRow", "canEdit")); @@ -85,9 +85,8 @@ class ObjectManager /* output the header */ echo '<table width="100%" border="0" cellpadding="3" cellspacing="0">'; - call_user_func(array($this->sClass, - "objectOutputHeader"), "color4"); - + /* Output header cells */ + $this->outputHeader("color4"); /* output each entry */ for($iCount = 0; $oRow = mysql_fetch_object($hResult); $iCount++) @@ -324,6 +323,20 @@ class ObjectManager $sId = "i".ucfirst($this->sClass)."Id"; return $aClean[$sId]; } + + /* Output headers for a table */ + function outputHeader($sClass) + { + $oObject = new $this->sClass(); + $aCells = $oObject->objectGetHeader(); + + /* Add an action column if the user can edit this class, or if it is a queue. + Even though a user annot process items, he can edit his queued submissions */ + if($oObject->canEdit() || $this->bIsQueue) + $aCells[] = "Action"; + + echo html_tr($aCells, $sClass); + } } ?> Index: appdb/include/screenshot.php diff -u -p appdb/include/screenshot.php:1.59 appdb/include/screenshot.php:1.60 --- appdb/include/screenshot.php:1.59 17 Mar 2007 21: 4:43 -0000 +++ appdb/include/screenshot.php 17 Mar 2007 21: 4:43 -0000 @@ -518,9 +518,9 @@ class Screenshot { return appData::objectGetEntries($bQueued, $iRows, $iStart, "screenshot"); } - function objectOutputHeader($sClass) + function objectGetHeader() { - return appData::objectOutputHeader($sClass, "screenshot"); + return appData::objectGetHeader("screenshot"); } function canEdit() Index: appdb/include/vendor.php diff -u -p appdb/include/vendor.php:1.16 appdb/include/vendor.php:1.17 --- appdb/include/vendor.php:1.16 17 Mar 2007 21: 4:43 -0000 +++ appdb/include/vendor.php 17 Mar 2007 21: 4:43 -0000 @@ -167,17 +167,14 @@ class Vendor { return $hResult; } - function objectOutputHeader($sClass = "") + function objectGetHeader() { - $sCells = array( + $aCells = array( "Name", "Website", array("Linked apps", "align=\"right\"")); - if(vendor::canEdit()) - $sCells[sizeof($sCells)] = "Action"; - - echo html_tr($sCells, $sClass); + return $aCells; } function objectGetInstanceFromRow($oRow) Index: appdb/unit_test/test_om_objects.php diff -u -p appdb/unit_test/test_om_objects.php:1.3 appdb/unit_test/test_om_objects.php:1.4 --- appdb/unit_test/test_om_objects.php:1.3 17 Mar 2007 21: 4:43 -0000 +++ appdb/unit_test/test_om_objects.php 17 Mar 2007 21: 4:43 -0000 @@ -143,7 +143,7 @@ function test_object_methods() echo "PASSED:\t\t".$sClassName."\n"; }*/ - $aTestMethods = array("objectOutputHeader", "objectOutputTableRow", + $aTestMethods = array("objectGetHeader", "objectOutputTableRow", "objectGetEntries", "display", "objectGetInstanceFromRow", "outputEditor", "canEdit", "getOutputEditorValues", "objectMakeUrl", "objectMakeLink");

1 0