June 2007 - Wine-commits - list.winehq.org

Jacek Caban : mshtml: Added more QueryInterface tests.
by Alexandre Julliard 25 Jun '07

25 Jun '07

Module: wine Branch: master Commit: d7e75747aa30bb941fa0c5c1864d11b06f773518 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d7e75747aa30bb941fa0c5c18… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Sun Jun 24 21:10:16 2007 +0200 mshtml: Added more QueryInterface tests. --- dlls/mshtml/tests/htmldoc.c | 17 ++++++++++++++--- 1 files changed, 14 insertions(+), 3 deletions(-) diff --git a/dlls/mshtml/tests/htmldoc.c b/dlls/mshtml/tests/htmldoc.c index 8d3237a..0faa66e 100644 --- a/dlls/mshtml/tests/htmldoc.c +++ b/dlls/mshtml/tests/htmldoc.c @@ -3406,12 +3406,23 @@ static void test_StreamLoad(IUnknown *unk) static void test_QueryInterface(IUnknown *unk) { - IRunnableObject *runnable = (IRunnableObject*)0xdeadbeef; + IUnknown *qi; HRESULT hres; - hres = IUnknown_QueryInterface(unk, &IID_IRunnableObject, (void**)&runnable); + qi = (void*)0xdeadbeef; + hres = IUnknown_QueryInterface(unk, &IID_IRunnableObject, (void**)&qi); ok(hres == E_NOINTERFACE, "QueryInterface returned %08x, expected E_NOINTERFACE\n", hres); - ok(runnable == NULL, "runnable=%p, ezpected NULL\n", runnable); + ok(qi == NULL, "runnable=%p, ezpected NULL\n", qi); + + qi = (void*)0xdeadbeef; + hres = IUnknown_QueryInterface(unk, &IID_IHTMLDOMNode, (void**)&qi); + ok(hres == E_NOINTERFACE, "QueryInterface returned %08x, expected E_NOINTERFACE\n", hres); + ok(qi == NULL, "runnable=%p, ezpected NULL\n", qi); + + qi = (void*)0xdeadbeef; + hres = IUnknown_QueryInterface(unk, &IID_IHTMLDOMNode2, (void**)&qi); + ok(hres == E_NOINTERFACE, "QueryInterface returned %08x, expected E_NOINTERFACE\n", hres); + ok(qi == NULL, "runnable=%p, ezpected NULL\n", qi); } static void init_test(enum load_state_t ls) {

1 0

Francois Gouget : ddraw/tests: Fix compilation on systems that don' t support nameless unions.
by Alexandre Julliard 25 Jun '07

25 Jun '07

Module: wine Branch: master Commit: 73032be74a7783b7a1d01faa9caf0cfac65ac6c5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=73032be74a7783b7a1d01faa9… Author: Francois Gouget <fgouget(a)free.fr> Date: Mon Jun 25 12:09:21 2007 +0200 ddraw/tests: Fix compilation on systems that don't support nameless unions. --- dlls/ddraw/tests/d3d.c | 8 ++++---- dlls/ddraw/tests/dsurface.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/dlls/ddraw/tests/d3d.c b/dlls/ddraw/tests/d3d.c index 35d6192..e994097 100644 --- a/dlls/ddraw/tests/d3d.c +++ b/dlls/ddraw/tests/d3d.c @@ -93,10 +93,10 @@ static BOOL CreateDirect3D(void) ddsd.dwSize = sizeof(ddsd); ddsd.dwFlags = DDSD_CAPS | DDSD_WIDTH | DDSD_HEIGHT | DDSD_PIXELFORMAT; ddsd.ddsCaps.dwCaps = DDSCAPS_ZBUFFER; - ddsd.ddpfPixelFormat.dwSize = sizeof(ddsd.ddpfPixelFormat); - ddsd.ddpfPixelFormat.dwFlags = DDPF_ZBUFFER; - ddsd.ddpfPixelFormat.dwZBufferBitDepth = 16; - ddsd.ddpfPixelFormat.dwZBitMask = 0x0000FFFF; + U4(ddsd).ddpfPixelFormat.dwSize = sizeof(U4(ddsd).ddpfPixelFormat); + U4(ddsd).ddpfPixelFormat.dwFlags = DDPF_ZBUFFER; + U1(U4(ddsd).ddpfPixelFormat).dwZBufferBitDepth = 16; + U3(U4(ddsd).ddpfPixelFormat).dwZBitMask = 0x0000FFFF; ddsd.dwWidth = 256; ddsd.dwHeight = 256; rc = IDirectDraw7_CreateSurface(lpDD, &ddsd, &lpDDSdepth, NULL); diff --git a/dlls/ddraw/tests/dsurface.c b/dlls/ddraw/tests/dsurface.c index a21a76d..b0a2195 100644 --- a/dlls/ddraw/tests/dsurface.c +++ b/dlls/ddraw/tests/dsurface.c @@ -2259,7 +2259,7 @@ static void BltParamTest(void) /* Blt(non-fast) tests */ memset(&BltFx, 0, sizeof(BltFx)); BltFx.dwSize = sizeof(BltFx); - BltFx.dwFillColor = 0xaabbccdd; + U5(BltFx).dwFillColor = 0xaabbccdd; hr = IDirectDrawSurface_Blt(surface1, &valid, NULL, NULL, DDBLT_COLORFILL, &BltFx); ok(hr == DD_OK, "IDirectDrawSurface_Blt with a valid rectangle for color fill returned %08x\n", hr);

1 0

Alexandre Julliard : shlwapi: Get rid of CharNextW/CharPrevW. Simplify some string functions.
by Alexandre Julliard 25 Jun '07

25 Jun '07

Module: wine Branch: master Commit: ae0c24fd06294c8ba6d0294c59c3a31c4327c337 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ae0c24fd06294c8ba6d0294c5… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Jun 25 14:01:28 2007 +0200 shlwapi: Get rid of CharNextW/CharPrevW. Simplify some string functions. --- dlls/shlwapi/path.c | 48 ++++------ dlls/shlwapi/string.c | 249 ++++++++++++++++--------------------------------- 2 files changed, 99 insertions(+), 198 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=ae0c24fd06294c8ba6d02…

1 0

Alexandre Julliard : shell32: Get rid of CharNextW.
by Alexandre Julliard 25 Jun '07

25 Jun '07

Module: wine Branch: master Commit: 92ceff203b419c0eb5693b1815fbefeab3ee5f83 URL: http://source.winehq.org/git/wine.git/?a=commit;h=92ceff203b419c0eb5693b181… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Jun 25 14:01:59 2007 +0200 shell32: Get rid of CharNextW. --- dlls/shell32/shlfileop.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/dlls/shell32/shlfileop.c b/dlls/shell32/shlfileop.c index 5410c97..f541b60 100644 --- a/dlls/shell32/shlfileop.c +++ b/dlls/shell32/shlfileop.c @@ -748,9 +748,7 @@ int WINAPI SHCreateDirectoryExW(HWND hWnd, LPCWSTR path, LPSECURITY_ATTRIBUTES s while (*pSlash) { - while (*pSlash && *pSlash != '\\') - pSlash = CharNextW(pSlash); - + while (*pSlash && *pSlash != '\\') pSlash++; if (*pSlash) { *pSlash = 0; /* terminate path at separator */

1 0

Jacek Caban : mshtml: Added IHTMLDOMNode::get_nodeName implementation.
by Alexandre Julliard 25 Jun '07

25 Jun '07

Module: wine Branch: master Commit: 40cfcf513cff4ab9e8d5cef0c7a5e69de42deee2 URL: http://source.winehq.org/git/wine.git/?a=commit;h=40cfcf513cff4ab9e8d5cef0c… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Sun Jun 24 21:07:23 2007 +0200 mshtml: Added IHTMLDOMNode::get_nodeName implementation. --- dlls/mshtml/htmlnode.c | 26 ++++++++++++++++++++++++-- 1 files changed, 24 insertions(+), 2 deletions(-) diff --git a/dlls/mshtml/htmlnode.c b/dlls/mshtml/htmlnode.c index d552e1c..c226db3 100644 --- a/dlls/mshtml/htmlnode.c +++ b/dlls/mshtml/htmlnode.c @@ -214,8 +214,30 @@ static HRESULT WINAPI HTMLDOMNode_appendChild(IHTMLDOMNode *iface, IHTMLDOMNode static HRESULT WINAPI HTMLDOMNode_get_nodeName(IHTMLDOMNode *iface, BSTR *p) { HTMLDOMNode *This = HTMLDOMNODE_THIS(iface); - FIXME("(%p)->(%p)\n", This, p); - return E_NOTIMPL; + + TRACE("(%p)->(%p)\n", This, p); + + *p = NULL; + + if(This->nsnode) { + nsAString name_str; + const PRUnichar *name; + nsresult nsres; + + nsAString_Init(&name_str, NULL); + nsres = nsIDOMNode_GetNodeName(This->nsnode, &name_str); + + if(NS_SUCCEEDED(nsres)) { + nsAString_GetData(&name_str, &name, NULL); + *p = SysAllocString(name); + }else { + ERR("GetNodeName failed: %08x\n", nsres); + } + + nsAString_Finish(&name_str); + } + + return S_OK; } static HRESULT WINAPI HTMLDOMNode_put_nodeValue(IHTMLDOMNode *iface, VARIANT v)

1 0

Jacek Caban : mshtml: Added beginning DOM tests.
by Alexandre Julliard 25 Jun '07

25 Jun '07

Module: wine Branch: master Commit: 1534267ba500156e7965fdc399247ca69eb7c014 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1534267ba500156e7965fdc39… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Sun Jun 24 21:09:03 2007 +0200 mshtml: Added beginning DOM tests. --- dlls/mshtml/tests/Makefile.in | 1 + dlls/mshtml/tests/dom.c | 263 +++++++++++++++++++++++++++++++++++++++++ 2 files changed, 264 insertions(+), 0 deletions(-) diff --git a/dlls/mshtml/tests/Makefile.in b/dlls/mshtml/tests/Makefile.in index 8ddcb50..0aa4645 100644 --- a/dlls/mshtml/tests/Makefile.in +++ b/dlls/mshtml/tests/Makefile.in @@ -7,6 +7,7 @@ IMPORTS = ole32 oleaut32 user32 urlmon advapi32 kernel32 EXTRALIBS = -luuid CTESTS = \ + dom.c \ htmldoc.c \ misc.c \ protocol.c diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c new file mode 100644 index 0000000..09f905a --- /dev/null +++ b/dlls/mshtml/tests/dom.c @@ -0,0 +1,263 @@ +/* + * Copyright 2007 Jacek Caban for CodeWeavers + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +#define COBJMACROS +#define CONST_VTABLE + +#include <wine/test.h> +#include <stdarg.h> +#include <stdio.h> + +#include "windef.h" +#include "winbase.h" +#include "ole2.h" +#include "mshtml.h" +#include "docobj.h" + +static const char doc_str1[] = "<html><body>test</body></html>"; + +static const char *dbgstr_w(LPCWSTR str) +{ + static char buf[512]; + WideCharToMultiByte(CP_ACP, 0, str, -1, buf, sizeof(buf), NULL, NULL); + return buf; +} + +static int strcmp_wa(LPCWSTR strw, const char *stra) +{ + WCHAR buf[512]; + MultiByteToWideChar(CP_ACP, 0, stra, -1, buf, sizeof(buf)/sizeof(WCHAR)); + return lstrcmpW(strw, buf); +} + +static IHTMLDocument2 *create_document(void) +{ + IHTMLDocument2 *doc; + HRESULT hres; + + hres = CoCreateInstance(&CLSID_HTMLDocument, NULL, CLSCTX_INPROC_SERVER|CLSCTX_INPROC_HANDLER, + &IID_IHTMLDocument2, (void**)&doc); + ok(hres == S_OK, "CoCreateInstance failed: %08x\n", hres); + + return doc; +} + +static void test_node_name(IUnknown *unk, const char *exname) +{ + IHTMLDOMNode *node; + BSTR name; + HRESULT hres; + + hres = IUnknown_QueryInterface(unk, &IID_IHTMLDOMNode, (void**)&node); + ok(hres == S_OK, "QueryInterface(IID_IHTMLNode) failed: %08x\n", hres); + + hres = IHTMLDOMNode_get_nodeName(node, &name); + IHTMLDOMNode_Release(node); + ok(hres == S_OK, "get_nodeName failed: %08x\n", hres); + ok(!strcmp_wa(name, exname), "got name: %s, expected HTML\n", dbgstr_w(name)); + + SysFreeString(name); +} + +static void test_doc_elem(IHTMLDocument2 *doc) +{ + IHTMLElement *elem; + IHTMLDocument3 *doc3; + HRESULT hres; + + hres = IHTMLDocument2_QueryInterface(doc, &IID_IHTMLDocument3, (void**)&doc3); + ok(hres == S_OK, "QueryInterface(IID_IHTMLDocument3) failed: %08x\n", hres); + + hres = IHTMLDocument3_get_documentElement(doc3, &elem); + IHTMLDocument3_Release(doc3); + ok(hres == S_OK, "get_documentElement failed: %08x\n", hres); + + test_node_name((IUnknown*)elem, "HTML"); + + IHTMLElement_Release(elem); +} + +static IHTMLDocument2 *notif_doc; +static BOOL doc_complete; + +static HRESULT WINAPI PropertyNotifySink_QueryInterface(IPropertyNotifySink *iface, + REFIID riid, void**ppv) +{ + if(IsEqualGUID(&IID_IPropertyNotifySink, riid)) { + *ppv = iface; + return S_OK; + } + + ok(0, "unexpected call\n"); + return E_NOINTERFACE; +} + +static ULONG WINAPI PropertyNotifySink_AddRef(IPropertyNotifySink *iface) +{ + return 2; +} + +static ULONG WINAPI PropertyNotifySink_Release(IPropertyNotifySink *iface) +{ + return 1; +} + +static HRESULT WINAPI PropertyNotifySink_OnChanged(IPropertyNotifySink *iface, DISPID dispID) +{ + if(dispID == DISPID_READYSTATE){ + BSTR state; + HRESULT hres; + + static const WCHAR completeW[] = {'c','o','m','p','l','e','t','e',0}; + + hres = IHTMLDocument2_get_readyState(notif_doc, &state); + ok(hres == S_OK, "get_readyState failed: %08x\n", hres); + + if(!lstrcmpW(state, completeW)) + doc_complete = TRUE; + + SysFreeString(state); + } + + return S_OK; +} + +static HRESULT WINAPI PropertyNotifySink_OnRequestEdit(IPropertyNotifySink *iface, DISPID dispID) +{ + ok(0, "unexpected call\n"); + return E_NOTIMPL; +} + +static IPropertyNotifySinkVtbl PropertyNotifySinkVtbl = { + PropertyNotifySink_QueryInterface, + PropertyNotifySink_AddRef, + PropertyNotifySink_Release, + PropertyNotifySink_OnChanged, + PropertyNotifySink_OnRequestEdit +}; + +static IPropertyNotifySink PropertyNotifySink = { &PropertyNotifySinkVtbl }; + +static IHTMLDocument2 *create_doc_with_string(const char *str) +{ + IPersistStreamInit *init; + IStream *stream; + IHTMLDocument2 *doc; + HGLOBAL mem; + SIZE_T len; + + notif_doc = doc = create_document(); + if(!doc) + return NULL; + + doc_complete = FALSE; + len = strlen(str); + mem = GlobalAlloc(0, len); + memcpy(mem, str, len); + CreateStreamOnHGlobal(mem, TRUE, &stream); + + IHTMLDocument2_QueryInterface(doc, &IID_IPersistStreamInit, (void**)&init); + + IPersistStreamInit_Load(init, stream); + IPersistStreamInit_Release(init); + IStream_Release(stream); + + return doc; +} + +static void do_advise(IUnknown *unk, REFIID riid, IUnknown *unk_advise) +{ + IConnectionPointContainer *container; + IConnectionPoint *cp; + DWORD cookie; + HRESULT hres; + + hres = IUnknown_QueryInterface(unk, &IID_IConnectionPointContainer, (void**)&container); + ok(hres == S_OK, "QueryInterface(IID_IConnectionPointContainer) failed: %08x\n", hres); + + hres = IConnectionPointContainer_FindConnectionPoint(container, riid, &cp); + IConnectionPointContainer_Release(container); + ok(hres == S_OK, "FindConnectionPoint failed: %08x\n", hres); + + hres = IConnectionPoint_Advise(cp, unk_advise, &cookie); + IConnectionPoint_Release(cp); + ok(hres == S_OK, "Advise failed: %08x\n", hres); +} + +typedef void (*domtest_t)(IHTMLDocument2*); + +static void run_domtest(const char *str, domtest_t test) +{ + IHTMLDocument2 *doc; + ULONG ref; + MSG msg; + + doc = create_doc_with_string(str); + do_advise((IUnknown*)doc, &IID_IPropertyNotifySink, (IUnknown*)&PropertyNotifySink); + + while(!doc_complete && GetMessage(&msg, NULL, 0, 0)) { + TranslateMessage(&msg); + DispatchMessage(&msg); + } + + test(doc); + + ref = IHTMLDocument2_Release(doc); + ok(!ref, "ref = %d\n", ref); +} + +static void gecko_installer_workaround(BOOL disable) +{ + HKEY hkey; + DWORD res; + + static BOOL has_url = FALSE; + static char url[2048]; + + if(!disable && !has_url) + return; + + res = RegOpenKey(HKEY_CURRENT_USER, "Software\\Wine\\MSHTML", &hkey); + if(res != ERROR_SUCCESS) + return; + + if(disable) { + DWORD type, size = sizeof(url); + + res = RegQueryValueEx(hkey, "GeckoUrl", NULL, &type, (PVOID)url, &size); + if(res == ERROR_SUCCESS && type == REG_SZ) + has_url = TRUE; + + RegDeleteValue(hkey, "GeckoUrl"); + }else { + RegSetValueEx(hkey, "GeckoUrl", 0, REG_SZ, (PVOID)url, lstrlenA(url)+1); + } + + RegCloseKey(hkey); +} + +START_TEST(dom) +{ + gecko_installer_workaround(TRUE); + CoInitialize(NULL); + + run_domtest(doc_str1, test_doc_elem); + + CoUninitialize(); + gecko_installer_workaround(FALSE); +}

1 0

Rob Shearman : mshtml: Fix HTMLDocument3_get_documentElement to get the right nsIDOMNode.
by Alexandre Julliard 25 Jun '07

25 Jun '07

Module: wine Branch: master Commit: 860d30eef269a4fd1b1ceec95b0f7570faf8f77c URL: http://source.winehq.org/git/wine.git/?a=commit;h=860d30eef269a4fd1b1ceec95… Author: Rob Shearman <rob(a)codeweavers.com> Date: Sun Jun 24 09:19:24 2007 +0100 mshtml: Fix HTMLDocument3_get_documentElement to get the right nsIDOMNode. --- dlls/mshtml/htmldoc3.c | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/dlls/mshtml/htmldoc3.c b/dlls/mshtml/htmldoc3.c index 21ee257..75c089d 100644 --- a/dlls/mshtml/htmldoc3.c +++ b/dlls/mshtml/htmldoc3.c @@ -117,6 +117,7 @@ static HRESULT WINAPI HTMLDocument3_get_documentElement(IHTMLDocument3 *iface, I HTMLDocument *This = HTMLDOC3_THIS(iface); nsIDOMDocument *nsdoc; HTMLDOMNode *node; + nsIDOMElement *nselem = NULL; nsresult nsres; TRACE("(%p)->(%p)\n", This, p); @@ -131,7 +132,12 @@ static HRESULT WINAPI HTMLDocument3_get_documentElement(IHTMLDocument3 *iface, I ERR("GetDocument failed: %08x\n", nsres); if(nsdoc) { - node = get_node(This, (nsIDOMNode*)nsdoc); + nsres = nsIDOMHTMLDocument_GetDocumentElement(nsdoc, &nselem); + if(NS_FAILED(nsres)) + ERR("GetDocumentElement failed: %08x\n", nsres); + } + if(nselem) { + node = get_node(This, (nsIDOMNode *)nselem); nsIDOMDocument_Release(nsdoc); IHTMLDOMNode_QueryInterface(HTMLDOMNODE(node), &IID_IHTMLElement, (void**)p);

1 0

Rob Shearman : mshtml: Notify the Gecko stream listener that we stopped binding, if an error occurs in start_binding.
by Alexandre Julliard 25 Jun '07

25 Jun '07

Module: wine Branch: master Commit: f6daa3485759d68754a53e39c0b17ca60ded3619 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f6daa3485759d68754a53e39c… Author: Rob Shearman <rob(a)codeweavers.com> Date: Sun Jun 24 09:23:10 2007 +0100 mshtml: Notify the Gecko stream listener that we stopped binding, if an error occurs in start_binding. --- dlls/mshtml/navigate.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/dlls/mshtml/navigate.c b/dlls/mshtml/navigate.c index 15a2f9c..3e05fdc 100644 --- a/dlls/mshtml/navigate.c +++ b/dlls/mshtml/navigate.c @@ -796,6 +796,8 @@ HRESULT start_binding(BSCallback *bscallback) hres = CreateAsyncBindCtx(0, STATUSCLB(bscallback), NULL, &bctx); if(FAILED(hres)) { WARN("CreateAsyncBindCtx failed: %08x\n", hres); + nsIStreamListener_OnStopRequest(bscallback->nslistener, (nsIRequest*)NSCHANNEL(bscallback->nschannel), + bscallback->nscontext, NS_OK); return hres; } @@ -803,6 +805,8 @@ HRESULT start_binding(BSCallback *bscallback) IBindCtx_Release(bctx); if(FAILED(hres)) { WARN("BindToStorage failed: %08x\n", hres); + nsIStreamListener_OnStopRequest(bscallback->nslistener, (nsIRequest*)NSCHANNEL(bscallback->nschannel), + bscallback->nscontext, NS_OK); return hres; }

1 0

Rob Shearman : mshtml: Implement HTMLElement_setAttribute.
by Alexandre Julliard 25 Jun '07

25 Jun '07

Module: wine Branch: master Commit: a9ebca282baeae17f5cb63c5b4ace1e22781ab1c URL: http://source.winehq.org/git/wine.git/?a=commit;h=a9ebca282baeae17f5cb63c5b… Author: Rob Shearman <rob(a)codeweavers.com> Date: Sun Jun 24 09:18:41 2007 +0100 mshtml: Implement HTMLElement_setAttribute. --- dlls/mshtml/htmlelem.c | 36 ++++++++++++++++++++++++++++++++++-- 1 files changed, 34 insertions(+), 2 deletions(-) diff --git a/dlls/mshtml/htmlelem.c b/dlls/mshtml/htmlelem.c index 516a0d0..ccdad8c 100644 --- a/dlls/mshtml/htmlelem.c +++ b/dlls/mshtml/htmlelem.c @@ -135,8 +135,40 @@ static HRESULT WINAPI HTMLElement_setAttribute(IHTMLElement *iface, BSTR strAttr VARIANT AttributeValue, LONG lFlags) { HTMLElement *This = HTMLELEM_THIS(iface); - FIXME("(%p)->(%s . %08x)\n", This, debugstr_w(strAttributeName), lFlags); - return E_NOTIMPL; + nsAString attr_str; + nsAString value_str; + nsresult nsres; + HRESULT hres; + VARIANT AttributeValueChanged; + + WARN("(%p)->(%s . %08x)\n", This, debugstr_w(strAttributeName), lFlags); + + VariantInit(&AttributeValueChanged); + + hres = VariantChangeType(&AttributeValueChanged, &AttributeValue, 0, VT_BSTR); + if (FAILED(hres)) { + WARN("couldn't convert input attribute value %d to VT_BSTR\n", V_VT(&AttributeValue)); + return hres; + } + + nsAString_Init(&attr_str, strAttributeName); + nsAString_Init(&value_str, V_BSTR(&AttributeValueChanged)); + + TRACE("setting %s to %s\n", debugstr_w(strAttributeName), + debugstr_w(V_BSTR(&AttributeValueChanged))); + + nsres = nsIDOMHTMLElement_SetAttribute(This->nselem, &attr_str, &value_str); + nsAString_Finish(&attr_str); + nsAString_Finish(&value_str); + + if(NS_SUCCEEDED(nsres)) { + hres = S_OK; + }else { + ERR("SetAttribute failed: %08x\n", nsres); + hres = E_FAIL; + } + + return hres; } static HRESULT WINAPI HTMLElement_getAttribute(IHTMLElement *iface, BSTR strAttributeName,

1 0

Rob Shearman : mshtml: The SRC value returned from HTMLElement_getAttribute should be an absolute , not relative URL.
by Alexandre Julliard 25 Jun '07

25 Jun '07

Module: wine Branch: master Commit: 6c6e4515fc2f2aec8e313602367b8a6c8f9a9b3f URL: http://source.winehq.org/git/wine.git/?a=commit;h=6c6e4515fc2f2aec8e3136023… Author: Rob Shearman <rob(a)codeweavers.com> Date: Sun Jun 24 09:17:51 2007 +0100 mshtml: The SRC value returned from HTMLElement_getAttribute should be an absolute, not relative URL. --- dlls/mshtml/htmlelem.c | 30 +++++++++++++++++++++++++++--- 1 files changed, 27 insertions(+), 3 deletions(-) diff --git a/dlls/mshtml/htmlelem.c b/dlls/mshtml/htmlelem.c index 37abb51..516a0d0 100644 --- a/dlls/mshtml/htmlelem.c +++ b/dlls/mshtml/htmlelem.c @@ -26,8 +26,10 @@ #include "windef.h" #include "winbase.h" #include "winuser.h" +#include "winreg.h" #include "winnls.h" #include "ole2.h" +#include "shlwapi.h" #include "wine/debug.h" #include "wine/unicode.h" @@ -149,6 +151,8 @@ static HRESULT WINAPI HTMLElement_getAttribute(IHTMLElement *iface, BSTR strAttr WARN("(%p)->(%s %08x %p)\n", This, debugstr_w(strAttributeName), lFlags, AttributeValue); + VariantInit(AttributeValue); + nsAString_Init(&attr_str, strAttributeName); nsAString_Init(&value_str, NULL); @@ -156,10 +160,30 @@ static HRESULT WINAPI HTMLElement_getAttribute(IHTMLElement *iface, BSTR strAttr nsAString_Finish(&attr_str); if(NS_SUCCEEDED(nsres)) { + static const WCHAR wszSRC[] = {'s','r','c',0}; nsAString_GetData(&value_str, &value, NULL); - V_VT(AttributeValue) = VT_BSTR; - V_BSTR(AttributeValue) = SysAllocString(value); - TRACE("attr_value=%s\n", debugstr_w(V_BSTR(AttributeValue))); + if(!strcmpiW(strAttributeName, wszSRC)) + { + WCHAR buffer[256]; + DWORD len; + BSTR bstrBaseUrl; + hres = IHTMLDocument2_get_URL(HTMLDOC(This->node->doc), &bstrBaseUrl); + if(SUCCEEDED(hres)) { + hres = CoInternetCombineUrl(bstrBaseUrl, value, + URL_ESCAPE_SPACES_ONLY|URL_DONT_ESCAPE_EXTRA_INFO, + buffer, sizeof(buffer)/sizeof(WCHAR), &len, 0); + SysFreeString(bstrBaseUrl); + if(SUCCEEDED(hres)) { + V_VT(AttributeValue) = VT_BSTR; + V_BSTR(AttributeValue) = SysAllocString(buffer); + TRACE("attr_value=%s\n", debugstr_w(V_BSTR(AttributeValue))); + } + } + }else { + V_VT(AttributeValue) = VT_BSTR; + V_BSTR(AttributeValue) = SysAllocString(value); + TRACE("attr_value=%s\n", debugstr_w(V_BSTR(AttributeValue))); + } }else { ERR("GetAttribute failed: %08x\n", nsres); hres = E_FAIL;

1 0