July 2007 - Wine-commits - list.winehq.org

appdb/include maintainer.php
by WineHQ 24 Jul '07

24 Jul '07

ChangeSet ID: 31276 CVSROOT: /opt/cvs-commit Module name: appdb Changes by: wineowner(a)winehq.org 2007/07/24 16:52:55 Modified files: include : maintainer.php Log message: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Add return value to maintainer::delete() Patch: http://cvs.winehq.org/patch.py?id=31276 Old revision New revision Changes Path 1.48 1.49 +6 -1 appdb/include/maintainer.php Index: appdb/include/maintainer.php diff -u -p appdb/include/maintainer.php:1.48 appdb/include/maintainer.php:1.49 --- appdb/include/maintainer.php:1.48 24 Jul 2007 21:52:55 -0000 +++ appdb/include/maintainer.php 24 Jul 2007 21:52:55 -0000 @@ -330,7 +330,12 @@ class maintainer function delete() { $sQuery = "DELETE from appMaintainers where maintainerId = '?'"; - query_parameters($sQuery, $this->iMaintainerId); + $hResult = query_parameters($sQuery, $this->iMaintainerId); + + if(!$hResult) + return FALSE; + + return TRUE; } function deleteMaintainer($oUser, $iAppId = null, $iVersionId = null)

1 0

appdb/ tables/create_tables unit_test/run_test ...
by WineHQ 24 Jul '07

24 Jul '07

ChangeSet ID: 31275 CVSROOT: /opt/cvs-commit Module name: appdb Changes by: wineowner(a)winehq.org 2007/07/24 16:49:23 Modified files: tables : create_tables unit_test : run_tests Added files: tables : create_apidb_base.sql create_user.sql Log message: Chris Morgan <cmorgan(a)alum.wpi.edu> Clean up database creation to create the mysql interface user and grant permissions. Group database setup together so the user is prompted for only a couple of times during initialization. Patch: http://cvs.winehq.org/patch.py?id=31275 Old revision New revision Changes Path 1.10 1.11 +9 -37 appdb/tables/create_tables Added 1.1 +0 -0 appdb/tables/create_apidb_base.sql Added 1.1 +0 -0 appdb/tables/create_user.sql 1.1 1.2 +1 -1 appdb/unit_test/run_tests Index: appdb/tables/create_tables diff -u -p appdb/tables/create_tables:1.10 appdb/tables/create_tables:1.11 --- appdb/tables/create_tables:1.10 24 Jul 2007 21:49:23 -0000 +++ appdb/tables/create_tables 24 Jul 2007 21:49:23 -0000 @@ -1,40 +1,12 @@ #! /bin/sh -echo Creating appdb tables -mysql -p -u root < appdb_tables.sql +echo Create the base user +mysql -p -u root < create_user.sql -echo Creating preferences list -mysql -p -u root < prefs_list.sql - -echo Creating user list -mysql -p -u root < user_list.sql - -echo Creating user preferences -mysql -p -u root < user_prefs.sql - -echo Creating user privileges -mysql -p -u root < user_privs.sql - -echo Creating session table -mysql -p -u root < session_list.sql - -echo Adding categories -mysql -p -u root < app_category.sql - -echo Adding maintainers -mysql -p -u root < maintainers.sql - -echo Adding bug links -mysql -p -u root < buglinks.sql - -echo Adding monitors -mysql -p -u root < monitors.sql - -echo Creating error logging tables -mysql -p -u root < error_log.sql - -echo Adding distributions -mysql -p -u root < distributions.sql - -echo Adding test data tables -mysql -p -u root < testResults.sql +echo Create the apidb database, and tables +cat create_apidb_base.sql appdb_tables.sql \ + prefs_list.sql user_list.sql user_prefs.sql \ + user_privs.sql session_list.sql app_category.sql \ + maintainers.sql buglinks.sql monitors.sql \ + error_log.sql distributions.sql testResults.sql \ + | mysql -p -u root Index: appdb/tables/create_apidb_base.sql diff -u -p /dev/null appdb/tables/create_apidb_base.sql:1.1 --- /dev/null 24 Jul 2007 21:49:23 -0000 +++ appdb/tables/create_apidb_base.sql 24 Jul 2007 21:49:23 -0000 @@ -0,0 +1,2 @@ +create database if not exists apidb; +grant all on apidb.* to wineowner; Index: appdb/tables/create_user.sql diff -u -p /dev/null appdb/tables/create_user.sql:1.1 --- /dev/null 24 Jul 2007 21:49:23 -0000 +++ appdb/tables/create_user.sql 24 Jul 2007 21:49:23 -0000 @@ -0,0 +1,2 @@ +create user wineowner identified by 'lemonade'; + Index: appdb/unit_test/run_tests diff -u -p appdb/unit_test/run_tests:1.1 appdb/unit_test/run_tests:1.2 --- appdb/unit_test/run_tests:1.1 24 Jul 2007 21:49:23 -0000 +++ appdb/unit_test/run_tests 24 Jul 2007 21:49:23 -0000 @@ -1 +1 @@ -php -f run_tests.php +php -dmagic_quotes_gpc=0 -f run_tests.php

1 0

appdb/include testData.php
by WineHQ 24 Jul '07

24 Jul '07

ChangeSet ID: 31274 CVSROOT: /opt/cvs-commit Module name: appdb Changes by: wineowner(a)winehq.org 2007/07/24 09:45:23 Modified files: include : testData.php Log message: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Fix rating colors in testData table, set the class, not the style. Patch: http://cvs.winehq.org/patch.py?id=31274 Old revision New revision Changes Path 1.72 1.73 +1 -1 appdb/include/testData.php Index: appdb/include/testData.php diff -u -p appdb/include/testData.php:1.72 appdb/include/testData.php:1.73 --- appdb/include/testData.php:1.72 24 Jul 2007 14:45:23 -0000 +++ appdb/include/testData.php 24 Jul 2007 14:45:23 -0000 @@ -1020,7 +1020,7 @@ class testData{ $oTableRow->AddCell(new TableCell($bHasMaintainer ? "YES" : "no")); $oTableRow->AddCell(new TableCell($this->sTestedRating)); - $oTableRow->SetStyle($this->sTestedRating); + $oTableRow->SetClass($this->sTestedRating); $oOMTableRow = new OMTableRow($oTableRow); $oOMTableRow->SetRowHasDeleteLink(true);

1 0

Stefan Dösinger : wined3d: Create the stateblock in Init3D.
by Alexandre Julliard 24 Jul '07

24 Jul '07

Module: wine Branch: master Commit: 861767f036b5ceab17f3b28c1966d3f732fa40b7 URL: http://source.winehq.org/git/wine.git/?a=commit;h=861767f036b5ceab17f3b28c1… Author: Stefan Dösinger <stefandoesinger(a)gmx.at> Date: Sun Jul 22 23:09:11 2007 +0200 wined3d: Create the stateblock in Init3D. --- dlls/wined3d/device.c | 55 ++++++++++++++++++++++++++++++++--------------- dlls/wined3d/directx.c | 44 -------------------------------------- 2 files changed, 37 insertions(+), 62 deletions(-) diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c index 520a4b3..0bdb753 100644 --- a/dlls/wined3d/device.c +++ b/dlls/wined3d/device.c @@ -202,24 +202,6 @@ static ULONG WINAPI IWineD3DDeviceImpl_Release(IWineD3DDevice *iface) { /* NOTE: You must release the parent if the object was created via a callback ** ***************************/ - /* Release the update stateblock */ - if(IWineD3DStateBlock_Release((IWineD3DStateBlock *)This->updateStateBlock) > 0){ - if(This->updateStateBlock != This->stateBlock) - FIXME("(%p) Something's still holding the Update stateblock\n",This); - } - This->updateStateBlock = NULL; - { /* because were not doing proper internal refcounts releasing the primary state block - causes recursion with the extra checks in ResourceReleased, to avoid this we have - to set this->stateBlock = NULL; first */ - IWineD3DStateBlock *stateBlock = (IWineD3DStateBlock *)This->stateBlock; - This->stateBlock = NULL; - - /* Release the stateblock */ - if(IWineD3DStateBlock_Release(stateBlock) > 0){ - FIXME("(%p) Something's still holding the Update stateblock\n",This); - } - } - if (This->resources != NULL ) { FIXME("(%p) Device released with resources still bound, acceptable but unexpected\n", This); dumpResources(This->resources); @@ -1809,6 +1791,24 @@ static HRESULT WINAPI IWineD3DDeviceImpl_Init3D(IWineD3DDevice *iface, WINED3DPR /* TODO: Test if OpenGL is compiled in and loaded */ + TRACE("(%p) : Creating stateblock\n", This); + /* Creating the startup stateBlock - Note Special Case: 0 => Don't fill in yet! */ + hr = IWineD3DDevice_CreateStateBlock(iface, + WINED3DSBT_INIT, + (IWineD3DStateBlock **)&This->stateBlock, + NULL); + if (WINED3D_OK != hr) { /* Note: No parent needed for initial internal stateblock */ + WARN("Failed to create stateblock\n"); + return hr; + } + TRACE("(%p) : Created stateblock (%p)\n", This, This->stateBlock); + This->updateStateBlock = This->stateBlock; + IWineD3DStateBlock_AddRef((IWineD3DStateBlock*)This->updateStateBlock); + + hr = allocate_shader_constants(This->updateStateBlock); + if (WINED3D_OK != hr) + return hr; + /* Initialize the texture unit mapping to a 1:1 mapping */ for (state = 0; state < MAX_COMBINED_SAMPLERS; ++state) { if (state < GL_LIMITS(fragment_samplers)) { @@ -1991,6 +1991,25 @@ static HRESULT WINAPI IWineD3DDeviceImpl_Uninit3D(IWineD3DDevice *iface, D3DCB_D This->swapchains = NULL; This->NumberOfSwapChains = 0; + /* Release the update stateblock */ + if(IWineD3DStateBlock_Release((IWineD3DStateBlock *)This->updateStateBlock) > 0){ + if(This->updateStateBlock != This->stateBlock) + FIXME("(%p) Something's still holding the Update stateblock\n",This); + } + This->updateStateBlock = NULL; + + { /* because were not doing proper internal refcounts releasing the primary state block + causes recursion with the extra checks in ResourceReleased, to avoid this we have + to set this->stateBlock = NULL; first */ + IWineD3DStateBlock *stateBlock = (IWineD3DStateBlock *)This->stateBlock; + This->stateBlock = NULL; + + /* Release the stateblock */ + if(IWineD3DStateBlock_Release(stateBlock) > 0){ + FIXME("(%p) Something's still holding the Update stateblock\n",This); + } + } + This->d3d_initialized = FALSE; return WINED3D_OK; } diff --git a/dlls/wined3d/directx.c b/dlls/wined3d/directx.c index ae924c4..ebb07bf 100644 --- a/dlls/wined3d/directx.c +++ b/dlls/wined3d/directx.c @@ -2416,7 +2416,6 @@ static HRESULT WINAPI IWineD3DImpl_CreateDevice(IWineD3D *iface, UINT Adapter, IWineD3DDeviceImpl *object = NULL; IWineD3DImpl *This = (IWineD3DImpl *)iface; HDC hDC; - HRESULT temp_result; int i; /* Validate the adapter number */ @@ -2462,20 +2461,6 @@ static HRESULT WINAPI IWineD3DImpl_CreateDevice(IWineD3D *iface, UINT Adapter, object->adapterNo = Adapter; object->devType = DeviceType; - TRACE("(%p) : Creating stateblock\n", This); - /* Creating the startup stateBlock - Note Special Case: 0 => Don't fill in yet! */ - if (WINED3D_OK != IWineD3DDevice_CreateStateBlock((IWineD3DDevice *)object, - WINED3DSBT_INIT, - (IWineD3DStateBlock **)&object->stateBlock, - NULL) || NULL == object->stateBlock) { /* Note: No parent needed for initial internal stateblock */ - WARN("Failed to create stateblock\n"); - goto create_device_error; - } - TRACE("(%p) : Created stateblock (%p)\n", This, object->stateBlock); - object->updateStateBlock = object->stateBlock; - IWineD3DStateBlock_AddRef((IWineD3DStateBlock*)object->updateStateBlock); - /* Setup surfaces for the backbuffer, frontbuffer and depthstencil buffer */ - select_shader_mode(&GLINFO_LOCATION, DeviceType, &object->ps_selected_mode, &object->vs_selected_mode); if (object->ps_selected_mode == SHADER_GLSL || object->vs_selected_mode == SHADER_GLSL) { object->shader_backend = &glsl_shader_backend; @@ -2490,10 +2475,6 @@ static HRESULT WINAPI IWineD3DImpl_CreateDevice(IWineD3D *iface, UINT Adapter, * TODO: move the functionality where it belongs */ select_shader_max_constants(object->ps_selected_mode, object->vs_selected_mode, &GLINFO_LOCATION); - temp_result = allocate_shader_constants(object->updateStateBlock); - if (WINED3D_OK != temp_result) - return temp_result; - object->render_targets = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(IWineD3DSurface *) * GL_LIMITS(buffers)); object->fbo_color_attachments = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(IWineD3DSurface *) * GL_LIMITS(buffers)); object->draw_buffers = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(GLenum) * GL_LIMITS(buffers)); @@ -2512,31 +2493,6 @@ static HRESULT WINAPI IWineD3DImpl_CreateDevice(IWineD3D *iface, UINT Adapter, list_init(&object->patches[i]); } return WINED3D_OK; -create_device_error: - - /* Set the device state to error */ - object->state = WINED3DERR_DRIVERINTERNALERROR; - - if (object->updateStateBlock != NULL) { - IWineD3DStateBlock_Release((IWineD3DStateBlock *)object->updateStateBlock); - object->updateStateBlock = NULL; - } - if (object->stateBlock != NULL) { - IWineD3DStateBlock_Release((IWineD3DStateBlock *)object->stateBlock); - object->stateBlock = NULL; - } - if (object->render_targets[0] != NULL) { - IWineD3DSurface_Release(object->render_targets[0]); - object->render_targets[0] = NULL; - } - if (object->stencilBufferTarget != NULL) { - IWineD3DSurface_Release(object->stencilBufferTarget); - object->stencilBufferTarget = NULL; - } - HeapFree(GetProcessHeap(), 0, object); - *ppReturnedDeviceInterface = NULL; - return WINED3DERR_INVALIDCALL; - } #undef GLINFO_LOCATION

1 0

Misha Koshelev : urlmon/tests: Release two objects that should be released but are not.
by Alexandre Julliard 24 Jul '07

24 Jul '07

Module: wine Branch: master Commit: 0c0285118e7d9f43c9566cd2078bc513fd31ab55 URL: http://source.winehq.org/git/wine.git/?a=commit;h=0c0285118e7d9f43c9566cd20… Author: Misha Koshelev <mk144210(a)bcm.edu> Date: Tue Jul 24 00:16:34 2007 -0500 urlmon/tests: Release two objects that should be released but are not. --- dlls/urlmon/tests/misc.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/urlmon/tests/misc.c b/dlls/urlmon/tests/misc.c index d93d94c..c93d6c2 100644 --- a/dlls/urlmon/tests/misc.c +++ b/dlls/urlmon/tests/misc.c @@ -235,6 +235,7 @@ static void test_RegisterFormatEnumerator(void) hres = IBindCtx_GetObjectParam(bctx, wszEnumFORMATETC, &unk); ok(hres == E_FAIL, "GetObjectParam failed: %08x, expected E_FAIL\n", hres); + IEnumFORMATETC_Release(format); IBindCtx_Release(bctx); } @@ -766,6 +767,7 @@ static void register_protocols(void) wszAbout, 0, NULL, 0); IClassFactory_Release(factory); + IInternetSession_Release(session); } static HRESULT WINAPI InternetProtocolInfo_QueryInterface(IInternetProtocolInfo *iface,

1 0

Stefan Dösinger : ddraw: Some d3d-only code fixes.
by Alexandre Julliard 24 Jul '07

24 Jul '07

Module: wine Branch: master Commit: 430239b470cea02cb79e6b6b83784f8e18634909 URL: http://source.winehq.org/git/wine.git/?a=commit;h=430239b470cea02cb79e6b6b8… Author: Stefan Dösinger <stefandoesinger(a)gmx.at> Date: Mon Jul 23 09:57:26 2007 +0200 ddraw: Some d3d-only code fixes. Vertex declarations are a d3d feature, thus they should be destroyed before d3d is shut down in wined3d. The surface type should be reset afterwards to prevent avoid gl surface afterwards and before a new render target is created. --- dlls/ddraw/ddraw.c | 22 ++++++++++++++-------- dlls/ddraw/main.c | 7 ------- dlls/ddraw/surface.c | 15 +++++++++++++++ 3 files changed, 29 insertions(+), 15 deletions(-) diff --git a/dlls/ddraw/ddraw.c b/dlls/ddraw/ddraw.c index ce591f1..c903ad4 100644 --- a/dlls/ddraw/ddraw.c +++ b/dlls/ddraw/ddraw.c @@ -252,14 +252,6 @@ IDirectDrawImpl_AddRef(IDirectDraw7 *iface) void IDirectDrawImpl_Destroy(IDirectDrawImpl *This) { - int i; - - for(i = 0; i < This->numConvertedDecls; i++) - { - IWineD3DVertexDeclaration_Release(This->decls[i].decl); - } - HeapFree(GetProcessHeap(), 0, This->decls); - /* Clear the cooplevel to restore window and display mode */ IDirectDraw7_SetCooperativeLevel(ICOM_INTERFACE(This, IDirectDraw7), NULL, @@ -3086,6 +3078,20 @@ IDirectDrawImpl_AttachD3DDevice(IDirectDrawImpl *This, return hr; } + This->declArraySize = 2; + This->decls = HeapAlloc(GetProcessHeap(), + HEAP_ZERO_MEMORY, + sizeof(*This->decls) * This->declArraySize); + if(!This->decls) + { + ERR("Error allocating an array for the converted vertex decls\n"); + This->declArraySize = 0; + hr = IWineD3DDevice_Uninit3D(This->wineD3DDevice, + D3D7CB_DestroyDepthStencilSurface, + D3D7CB_DestroySwapChain); + return E_OUTOFMEMORY; + } + /* Create an Index Buffer parent */ TRACE("(%p) Successfully initialized 3D\n", This); return DD_OK; diff --git a/dlls/ddraw/main.c b/dlls/ddraw/main.c index 2d28626..54b35dc 100644 --- a/dlls/ddraw/main.c +++ b/dlls/ddraw/main.c @@ -319,13 +319,6 @@ DDRAW_Create(const GUID *guid, list_init(&This->surface_list); list_add_head(&global_ddraw_list, &This->ddraw_list_entry); - This->decls = HeapAlloc(GetProcessHeap(), 0, 0); - if(!This->decls) - { - ERR("Error allocating an empty array for the converted vertex decls\n"); - goto err_out; - } - /* Call QueryInterface to get the pointer to the requested interface. This also initializes * The required refcount */ diff --git a/dlls/ddraw/surface.c b/dlls/ddraw/surface.c index 1d61530..5dc823e 100644 --- a/dlls/ddraw/surface.c +++ b/dlls/ddraw/surface.c @@ -314,6 +314,13 @@ IDirectDrawSurfaceImpl_Release(IDirectDrawSurface7 *iface) /* Unset any index buffer, just to be sure */ IWineD3DDevice_SetIndices(ddraw->wineD3DDevice, NULL); IWineD3DDevice_SetDepthStencilSurface(ddraw->wineD3DDevice, NULL); + IWineD3DDevice_SetVertexDeclaration(ddraw->wineD3DDevice, NULL); + for(i = 0; i < ddraw->numConvertedDecls; i++) + { + IWineD3DVertexDeclaration_Release(ddraw->decls[i].decl); + } + HeapFree(GetProcessHeap(), 0, ddraw->decls); + ddraw->numConvertedDecls = 0; if(IWineD3DDevice_Uninit3D(ddraw->wineD3DDevice, D3D7CB_DestroyDepthStencilSurface, D3D7CB_DestroySwapChain) != D3D_OK) { @@ -335,6 +342,14 @@ IDirectDrawSurfaceImpl_Release(IDirectDrawSurface7 *iface) ddraw->d3d_initialized = FALSE; ddraw->d3d_target = NULL; + /* Reset to the default surface implementation type. This is needed if apps use + * non render target surfaces and expect blits to work after destroying the render + * target. + * + * TODO: Recreate existing offscreen surfaces + */ + ddraw->ImplType = DefaultSurfaceType; + /* Write a trace because D3D unloading was the reason for many * crashes during development. */

1 0

Misha Koshelev : urlmon: LockModule in create_binding_protocol as we ReleaseModule when the object is released .
by Alexandre Julliard 24 Jul '07

24 Jul '07

Module: wine Branch: master Commit: f5ed5a7f48d0ee034570738890cecc33d0b3b87b URL: http://source.winehq.org/git/wine.git/?a=commit;h=f5ed5a7f48d0ee03457073889… Author: Misha Koshelev <mk144210(a)bcm.edu> Date: Tue Jul 24 00:15:19 2007 -0500 urlmon: LockModule in create_binding_protocol as we ReleaseModule when the object is released. --- dlls/urlmon/bindprot.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/urlmon/bindprot.c b/dlls/urlmon/bindprot.c index c7e62f9..6b175f6 100644 --- a/dlls/urlmon/bindprot.c +++ b/dlls/urlmon/bindprot.c @@ -493,6 +493,8 @@ HRESULT create_binding_protocol(LPCWSTR url, IInternetProtocol **protocol) ret->protocol_sink = NULL; ret->priority = 0; + URLMON_LockModule(); + *protocol = PROTOCOL(ret); return S_OK; }

1 0

Misha Koshelev : urlmon: Release IInternetProtocolInfo returned from get_protocol_info when finished with it .
by Alexandre Julliard 24 Jul '07

24 Jul '07

Module: wine Branch: master Commit: 752334c561ba865fb3e0150aca92622ec66db951 URL: http://source.winehq.org/git/wine.git/?a=commit;h=752334c561ba865fb3e0150ac… Author: Misha Koshelev <mk144210(a)bcm.edu> Date: Tue Jul 24 00:15:57 2007 -0500 urlmon: Release IInternetProtocolInfo returned from get_protocol_info when finished with it. --- dlls/urlmon/internet.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/dlls/urlmon/internet.c b/dlls/urlmon/internet.c index 68692c1..2626982 100644 --- a/dlls/urlmon/internet.c +++ b/dlls/urlmon/internet.c @@ -75,6 +75,7 @@ static HRESULT parse_canonicalize_url(LPCWSTR url, DWORD flags, LPWSTR result, if(protocol_info) { hres = IInternetProtocolInfo_ParseUrl(protocol_info, url, PARSE_CANONICALIZE, flags, result, size, rsize, 0); + IInternetProtocolInfo_Release(protocol_info); if(SUCCEEDED(hres)) return hres; } @@ -98,6 +99,7 @@ static HRESULT parse_security_url(LPCWSTR url, DWORD flags, LPWSTR result, DWORD if(protocol_info) { hres = IInternetProtocolInfo_ParseUrl(protocol_info, url, PARSE_SECURITY_URL, flags, result, size, rsize, 0); + IInternetProtocolInfo_Release(protocol_info); return hres; } @@ -117,6 +119,7 @@ static HRESULT parse_encode(LPCWSTR url, DWORD flags, LPWSTR result, DWORD size, if(protocol_info) { hres = IInternetProtocolInfo_ParseUrl(protocol_info, url, PARSE_ENCODE, flags, result, size, rsize, 0); + IInternetProtocolInfo_Release(protocol_info); if(SUCCEEDED(hres)) return hres; } @@ -143,6 +146,7 @@ static HRESULT parse_path_from_url(LPCWSTR url, DWORD flags, LPWSTR result, DWOR if(protocol_info) { hres = IInternetProtocolInfo_ParseUrl(protocol_info, url, PARSE_PATH_FROM_URL, flags, result, size, rsize, 0); + IInternetProtocolInfo_Release(protocol_info); if(SUCCEEDED(hres)) return hres; } @@ -168,6 +172,7 @@ static HRESULT parse_security_domain(LPCWSTR url, DWORD flags, LPWSTR result, if(protocol_info) { hres = IInternetProtocolInfo_ParseUrl(protocol_info, url, PARSE_SECURITY_DOMAIN, flags, result, size, rsize, 0); + IInternetProtocolInfo_Release(protocol_info); if(SUCCEEDED(hres)) return hres; } @@ -224,6 +229,7 @@ HRESULT WINAPI CoInternetCombineUrl(LPCWSTR pwzBaseUrl, LPCWSTR pwzRelativeUrl, if(protocol_info) { hres = IInternetProtocolInfo_CombineUrl(protocol_info, pwzBaseUrl, pwzRelativeUrl, dwCombineFlags, pwzResult, cchResult, pcchResult, dwReserved); + IInternetProtocolInfo_Release(protocol_info); if(SUCCEEDED(hres)) return hres; } @@ -251,6 +257,7 @@ HRESULT WINAPI CoInternetCompareUrl(LPCWSTR pwzUrl1, LPCWSTR pwzUrl2, DWORD dwCo if(protocol_info) { hres = IInternetProtocolInfo_CompareUrl(protocol_info, pwzUrl1, pwzUrl2, dwCompareFlags); + IInternetProtocolInfo_Release(protocol_info); if(SUCCEEDED(hres)) return hres; }

1 0

Misha Koshelev : urlmon: If we are using an internal protocol ClassFactory, call its AddRef as the caller must Release the object.
by Alexandre Julliard 24 Jul '07

24 Jul '07

Module: wine Branch: master Commit: 414ddfa671d586fbc4f00f63d7c99f0079cd9048 URL: http://source.winehq.org/git/wine.git/?a=commit;h=414ddfa671d586fbc4f00f63d… Author: Misha Koshelev <mk144210(a)bcm.edu> Date: Tue Jul 24 00:14:58 2007 -0500 urlmon: If we are using an internal protocol ClassFactory, call its AddRef as the caller must Release the object. --- dlls/urlmon/session.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/dlls/urlmon/session.c b/dlls/urlmon/session.c index 6e80996..a57a8dc 100644 --- a/dlls/urlmon/session.c +++ b/dlls/urlmon/session.c @@ -151,6 +151,7 @@ HRESULT get_protocol_handler(LPCWSTR url, CLSID *clsid, IClassFactory **ret) ns = find_name_space(schema); if(ns) { *ret = ns->cf; + IClassFactory_AddRef(*ret); if(clsid) *clsid = ns->clsid; return S_OK;

1 0

Evan Stade : gdiplus: Use page unit when drawing.
by Alexandre Julliard 24 Jul '07

24 Jul '07

Module: wine Branch: master Commit: d01c697eb9e721550fb20e751d7763553b4798db URL: http://source.winehq.org/git/wine.git/?a=commit;h=d01c697eb9e721550fb20e751… Author: Evan Stade <estade(a)gmail.com> Date: Mon Jul 23 20:24:53 2007 -0700 gdiplus: Use page unit when drawing. --- dlls/gdiplus/graphics.c | 305 ++++++++++++++++++++++++++++------------------- 1 files changed, 180 insertions(+), 125 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=d01c697eb9e721550fb20…

1 0