September 2007 - Wine-commits

Lionel Debroux : dplayx: Fixed memory leak in dplay.c (found by Smatch).
by Alexandre Julliard 11 Sep '07

11 Sep '07

Module: wine Branch: master Commit: cd6472f79479185669609c34d70f629e3a30f747 URL: http://source.winehq.org/git/wine.git/?a=commit;h=cd6472f79479185669609c34d… Author: Lionel Debroux <lionel_debroux(a)yahoo.fr> Date: Mon Sep 3 12:38:42 2007 +0200 dplayx: Fixed memory leak in dplay.c (found by Smatch). --- dlls/dplayx/dplay.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/dlls/dplayx/dplay.c b/dlls/dplayx/dplay.c index 17ebd00..1688614 100644 --- a/dlls/dplayx/dplay.c +++ b/dlls/dplayx/dplay.c @@ -5292,7 +5292,6 @@ static HRESULT DirectPlayEnumerateAW(LPDPENUMDPCALLBACKA lpEnumCallbackA, { HeapFree(GetProcessHeap(), 0, descriptionA); max_sizeOfDescriptionA = sizeOfDescription; - descriptionA = HeapAlloc(GetProcessHeap(), 0, max_sizeOfDescriptionA); } descriptionA = HeapAlloc(GetProcessHeap(), 0, sizeOfDescription); RegQueryValueExA(hkServiceProvider, "DescriptionA", @@ -5315,7 +5314,6 @@ static HRESULT DirectPlayEnumerateAW(LPDPENUMDPCALLBACKA lpEnumCallbackA, { HeapFree(GetProcessHeap(), 0, descriptionW); max_sizeOfDescriptionW = sizeOfDescription; - descriptionW = HeapAlloc(GetProcessHeap(), 0, max_sizeOfDescriptionW); } descriptionW = HeapAlloc(GetProcessHeap(), 0, sizeOfDescription); RegQueryValueExW(hkServiceProvider, descW,

1 0

docs/en winedev-debugger.sgml winedev-graphica ...
by Francois Gouget 11 Sep '07

11 Sep '07

ChangeSet ID: 118951144495071634424767 CVSROOT: /cvsroot/wine Module name: docs Changes by: fgouget(a)sc8-pr-cvs9.sourceforge.net 2007/09/11 04:50:44 Modified files: en : winedev-debugger.sgml winedev-graphical.sgml winedev-kernel.sgml winedev-opengl.sgml winedev-otherdebug.sgml wineusr-running.sgml Log message: Assorted spelling fixes. Old revision New revision Changes Path 1.5 1.6 +5 -5 docs/en/winedev-debugger.sgml 1.2 1.3 +2 -2 docs/en/winedev-graphical.sgml 1.2 1.3 +2 -2 docs/en/winedev-kernel.sgml 1.3 1.4 +1 -1 docs/en/winedev-opengl.sgml 1.5 1.6 +1 -1 docs/en/winedev-otherdebug.sgml 1.5 1.6 +1 -1 docs/en/wineusr-running.sgml Index: docs/en/winedev-debugger.sgml diff -u -p docs/en/winedev-debugger.sgml:1.5 docs/en/winedev-debugger.sgml:1.6 --- docs/en/winedev-debugger.sgml 11 Sep 2007 11:50:44 -0000 +++ /dev/null 11 Sep 2007 11:50:44 -0000 @@ -408,7 +408,7 @@ winedbg hl.exe -windowed <para> You can also set a breakpoint for that function. Start wine using <command>winedbg</command> instead of - <command>wine</command>. Once the debugger is is running enter + <command>wine</command>. Once the debugger is running enter <command>break</command> <parameter>KERNEL_LSTRLEN</parameter> (replace by function you want to debug, CASE IS RELEVANT) to set a breakpoint. Then @@ -617,7 +617,7 @@ call KERNEL.LSTRLEN | |temporary name ~docXXXX.tmp |Force use of Drive C:. -|Warning: GetTempFileName returns 'C:~doc9281.tmp', which doesn't seem to be writeable. +|Warning: GetTempFileName returns 'C:~doc9281.tmp', which doesn't seem to be writable. |Please check your configuration file if this generates a failure. </screen> <para> @@ -653,7 +653,7 @@ In 32 bit mode. Wine-dbg> </screen> <para> - The code seems to find a writeable harddisk and tries to create + The code seems to find a writable harddisk and tries to create a file there. To work around this bug, you can define <medialabel>C:</medialabel> as a networkdrive, which is ignored by the code above. @@ -1028,7 +1028,7 @@ winedbg myprog.exe <term>Auto</term> <listitem> <para> - if this value is zero, a message box will ask the + If this value is zero, a message box will ask the user if he/she wishes to launch the debugger when an unhandled exception occurs. Otherwise, the debugger is automatically started. @@ -1049,7 +1049,7 @@ winedbg myprog.exe <note> <title>Note 1</title> <para> - creating this key is mandatory. Not doing so will not + Creating this key is mandatory. Not doing so will not fire the debugger when an exception occurs. </para> </note> Index: docs/en/winedev-graphical.sgml diff -u -p docs/en/winedev-graphical.sgml:1.2 docs/en/winedev-graphical.sgml:1.3 --- docs/en/winedev-graphical.sgml 11 Sep 2007 11:50:44 -0000 +++ /dev/null 11 Sep 2007 11:50:44 -0000 @@ -25,8 +25,8 @@ In the past, all calls to X used to go through a wrapper called <function>TSX...()</function> (for "Thread Safe X ..."). While it is still being used in the code, it's inefficient - as the lock is potentially aquired and released unnecessarily. - New code should explicitly aquire the lock. + as the lock is potentially acquired and released unnecessarily. + New code should explicitly acquire the lock. </para> </sect2> </sect1> Index: docs/en/winedev-kernel.sgml diff -u -p docs/en/winedev-kernel.sgml:1.2 docs/en/winedev-kernel.sgml:1.3 --- docs/en/winedev-kernel.sgml 11 Sep 2007 11:50:44 -0000 +++ /dev/null 11 Sep 2007 11:50:44 -0000 @@ -929,7 +929,7 @@ if (res != ERROR_SUCCESS) return res; expect to be able to crash themselves and recover later without the user noticing, some contain buggy binary-only components from third parties and use SEH to swallow crashes, and still others execute - priviledged (kernel-level) instructions and expect it to work. In + privileged (kernel-level) instructions and expect it to work. In fact, at least one set of APIs (the <function>IsBad*Ptr()</function> series) can only be implemented by performing an operation that may crash and returning <constant>TRUE</constant> if it does, and @@ -2589,7 +2589,7 @@ if (res != ERROR_SUCCESS) return res; not possible (like when someone else is already using this area), the DOS support is not possible. Not also that by doing so, access to linear address 0 is enabled (as it's also real mode address 0 which is - valid). Hence, NULL pointer derefence faults are no longer catched. + valid). Hence, NULL pointer dereference faults are no longer caught. </para> </sect2> </sect1> Index: docs/en/winedev-opengl.sgml diff -u -p docs/en/winedev-opengl.sgml:1.3 docs/en/winedev-opengl.sgml:1.4 --- docs/en/winedev-opengl.sgml 11 Sep 2007 11:50:44 -0000 +++ /dev/null 11 Sep 2007 11:50:44 -0000 @@ -175,7 +175,7 @@ The first is the path to the OpenGL registry. Now, you will all ask 'but what is the OpenGL registry ?' :-) Well, it's part of the OpenGL sample implementation - source tree from SGI (more informations at this URL : + source tree from SGI (more information at this URL : <ulink url="http://oss.sgi.com/projects/ogl-sample/"> http://oss.sgi.com/projects/ogl-sample/</ulink>. </para> Index: docs/en/winedev-otherdebug.sgml diff -u -p docs/en/winedev-otherdebug.sgml:1.5 docs/en/winedev-otherdebug.sgml:1.6 --- docs/en/winedev-otherdebug.sgml 11 Sep 2007 11:50:44 -0000 +++ /dev/null 11 Sep 2007 11:50:44 -0000 @@ -19,7 +19,7 @@ </para> <para> Presuming that you have compiled and installed wine the first - thing to do is is to enable direct hardware access to your + thing to do is to enable direct hardware access to your parallel port. To do this edit <filename>config</filename> (usually in <filename>~/.wine/</filename>) and in the ports section add the following two lines Index: docs/en/wineusr-running.sgml diff -u -p docs/en/wineusr-running.sgml:1.5 docs/en/wineusr-running.sgml:1.6 --- docs/en/wineusr-running.sgml 11 Sep 2007 11:50:44 -0000 +++ /dev/null 11 Sep 2007 11:50:44 -0000 @@ -306,7 +306,7 @@ Path="c:\windows;c:\windows\system;e:\;e <prompt>$</prompt> <userinput>WINEDLLOVERRIDES="ole32,oleaut32,rpcrt4=n" wine <replaceable>program_name</replaceable></userinput> </screen> <para> - For more informations about DLL overrides, please refer to the <link + For more information about DLL overrides, please refer to the <link linkend="winecfg-dll-overrides">DLL overrides</link> section of this guide. </para> </sect2>

1 0

Vitaliy Margolen : bugzilla: Move "Related actions" box to under "People".
by Jeremy Newman 10 Sep '07

10 Sep '07

Module: bugzilla Branch: master Commit: f2b9b8f501bebe17b923b4c80ce324233fc903d3 URL: http://source.winehq.org/git/bugzilla.git/?a=commit;h=f2b9b8f501bebe17b923b… Author: Vitaliy Margolen <wine-patches(a)kievinfo.com> Date: Sun Sep 2 12:20:14 2007 -0600 bugzilla: Move "Related actions" box to under "People". There are enough empty space under the "People" box. Fill it up. --- template/en/default/bug/edit.html.tmpl | 59 ++++++++++++++++++-------------- 1 files changed, 33 insertions(+), 26 deletions(-) diff --git a/template/en/default/bug/edit.html.tmpl b/template/en/default/bug/edit.html.tmpl index 1236a20..5a12dd5 100644 --- a/template/en/default/bug/edit.html.tmpl +++ b/template/en/default/bug/edit.html.tmpl @@ -140,7 +140,7 @@ [%# That's the main table, which contains all editable fields. %] <table> <tr> - <td valign="top"> + <td valign="top" rowspan="2"> <fieldset> <legend>Details</legend> <table> @@ -305,6 +305,37 @@ [% END %] </td> </tr> + [%# Related actions block #%] + <tr> + <td valign="bottom"> + <fieldset> + <legend>Related actions</legend> + <ul> + <li><a href="show_activity.cgi?id=[% bug.bug_id %]">View [% terms.Bug %] Activity</a></li> + <li><a href="show_bug.cgi?format=multiple&id=[% bug.bug_id %]">Format For Printing</a></li> + <li><a href="show_bug.cgi?ctype=xml&id=[% bug.bug_id %]">XML</a></li> + <li><a href="enter_bug.cgi?cloned_bug_id=[% bug.bug_id %]">Clone This [% terms.Bug %]</a></li> + </ul> + + [% IF bug.use_votes %] + + <a href="page.cgi?id=voting.html">Votes</a>: [% bug.votes %] + <ul> + [% IF bug.votes %] + <li><a href="votes.cgi?action=show_bug&bug_id=[% bug.bug_id %]">Show + votes for this [% terms.bug %]</a></li> + [% END %] + <li><a href="votes.cgi?action=show_user&bug_id=[% bug.bug_id %]#vote_[% bug.bug_id %]">Vote + for this [% terms.bug %]</a></li> + </ul> + [% END %] + + [%# Links to more things users can do with this bug. %] + [% Hook.process("links") %] + </fieldset> + </td> + </tr> + </table> [% IF user.in_group(Param('timetrackinggroup')) %] @@ -443,31 +474,7 @@ </td> <td valign="top"> - <fieldset> - <legend>Related actions</legend> - <ul> - <li><a href="show_activity.cgi?id=[% bug.bug_id %]">View [% terms.Bug %] Activity</a></li> - <li><a href="show_bug.cgi?format=multiple&id=[% bug.bug_id %]">Format For Printing</a></li> - <li><a href="show_bug.cgi?ctype=xml&id=[% bug.bug_id %]">XML</a></li> - <li><a href="enter_bug.cgi?cloned_bug_id=[% bug.bug_id %]">Clone This [% terms.Bug %]</a></li> - </ul> - - [% IF bug.use_votes %] - - <a href="page.cgi?id=voting.html">Votes</a>: [% bug.votes %] - <ul> - [% IF bug.votes %] - <li><a href="votes.cgi?action=show_bug&bug_id=[% bug.bug_id %]">Show - votes for this [% terms.bug %]</a></li> - [% END %] - <li><a href="votes.cgi?action=show_user&bug_id=[% bug.bug_id %]#vote_[% bug.bug_id %]">Vote - for this [% terms.bug %]</a></li> - </ul> - [% END %] - - [%# Links to more things users can do with this bug. %] - [% Hook.process("links") %] - </fieldset> +   </td> </tr> </table>

1 0

Vitaliy Margolen : Move attachment table before comments into same table as other bug properties .
by Jeremy Newman 10 Sep '07

10 Sep '07

Module: bugzilla Branch: master Commit: c532c47d86cffbdd95088a6a45b3d13175b0950f URL: http://source.winehq.org/git/bugzilla.git/?a=commit;h=c532c47d86cffbdd95088… Author: Vitaliy Margolen <wine-patches(a)kievinfo.com> Date: Sun Sep 2 12:20:20 2007 -0600 Move attachment table before comments into same table as other bug properties. --- template/en/default/attachment/list.html.tmpl | 2 -- template/en/default/bug/edit.html.tmpl | 24 ++++++++++++++---------- 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/template/en/default/attachment/list.html.tmpl b/template/en/default/attachment/list.html.tmpl index b6b0431..78bd586 100644 --- a/template/en/default/attachment/list.html.tmpl +++ b/template/en/default/attachment/list.html.tmpl @@ -50,7 +50,6 @@ //--> </script> - <table id="attachment_table" cellspacing="0" cellpadding="4"> <tr> <th colspan="[% show_attachment_flags ? 3 : 2 %]" align="left"> @@ -145,4 +144,3 @@ </td> </tr> </table> - diff --git a/template/en/default/bug/edit.html.tmpl b/template/en/default/bug/edit.html.tmpl index 5a12dd5..ddc79a7 100644 --- a/template/en/default/bug/edit.html.tmpl +++ b/template/en/default/bug/edit.html.tmpl @@ -336,6 +336,20 @@ </td> </tr> + <tr> + <td colspan="2"> + + [%# *** Attachments *** %] + + [% PROCESS attachment/list.html.tmpl + attachments = bug.attachments + bugid = bug.bug_id + num_attachment_flag_types = bug.num_attachment_flag_types + show_attachment_flags = bug.show_attachment_flags + %] + </td> + </tr> + </table> [% IF user.in_group(Param('timetrackinggroup')) %] @@ -410,16 +424,6 @@ </table> [% END %] -[%# *** Attachments *** %] - - [% PROCESS attachment/list.html.tmpl - attachments = bug.attachments - bugid = bug.bug_id - num_attachment_flag_types = bug.num_attachment_flag_types - show_attachment_flags = bug.show_attachment_flags - %] - - [%# *** Comments Groups *** %]

1 0

Vitaliy Margolen : bugzilla: Make attachments box winder.
by Jeremy Newman 10 Sep '07

10 Sep '07

Module: bugzilla Branch: master Commit: 021787288045e33a2f59fce61991438e9c3395b6 URL: http://source.winehq.org/git/bugzilla.git/?a=commit;h=021787288045e33a2f59f… Author: Vitaliy Margolen <wine-patches(a)kievinfo.com> Date: Sun Sep 2 12:20:06 2007 -0600 bugzilla: Make attachments box winder. There are lots of unused room on the right of the box. Might as well use it instead of overlapping the text. --- skins/standard/global.css | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/skins/standard/global.css b/skins/standard/global.css index fc8fb8e..80c2051 100644 --- a/skins/standard/global.css +++ b/skins/standard/global.css @@ -282,7 +282,7 @@ dl dl > dt { /* Style of the attachment table */ #attachment_table { border-collapse: collapse; - width: 40em; + width: 100%; border: 1px solid #333333; }

1 0

lostwages/wwn wn20070312_325.xml
by Jeremy Newman 10 Sep '07

10 Sep '07

ChangeSet ID: 31373 CVSROOT: /opt/cvs-commit Module name: lostwages Changes by: jnewman(a)winehq.org 2007/09/10 12:21:52 Modified files: wwn : wn20070312_325.xml Log message: Francois Gouget <fgouget(a)free.fr> WWN325 spelling fixes Patch: http://cvs.winehq.org/patch.py?id=31373 Old revision New revision Changes Path 1.1 1.2 +11 -11 lostwages/wwn/wn20070312_325.xml Index: lostwages/wwn/wn20070312_325.xml diff -u -p lostwages/wwn/wn20070312_325.xml:1.1 lostwages/wwn/wn20070312_325.xml:1.2 --- lostwages/wwn/wn20070312_325.xml:1.1 10 Sep 2007 17:21:52 -0000 +++ lostwages/wwn/wn20070312_325.xml 10 Sep 2007 17:21:52 -0000 @@ -118,7 +118,7 @@ Linux), and a Mac version's on the way.< posts="9" > <topic></topic> -Microsoft's standard routine for introducing new API's is to ship +Microsoft's standard routine for introducing new APIs is to ship the new libraries with applications for a few years until they're simply shipped with the operating system. We've seen this with a lot of apps including games that install new versions of DirectX and things like @@ -235,7 +235,7 @@ later. Next problem I still have is that pdf2png and svg2png won't link now. Not sure why's that. Also note that binaries generated by winegcc are -in fact a small script calling wine to load the actualy .exe.so file +in fact a small script calling wine to load the actual .exe.so file generated. This is not much worse than what libtool already does for us, but we may be able to get to plain binaries since we don't use any native Windows binaries and so the wine loader should not be necessary. @@ -287,7 +287,7 @@ to it. From there, all the new features Stefan Dösinger proposed someone should take this up as a summer of code project and outlined the tasks that need to be done: <quote who="Stefan Dosinger"> -Thinking about SoC I though that starting a DirectX 10 implementation may be a +Thinking about SoC I thought that starting a DirectX 10 implementation may be a good summer of code project. I do not mean implementing the full d3d10 lib, that would be way to much, more starting the infrastructure. Henri disagreed with the idea, so I thought I'll write a mail for public discussion :-) . @@ -305,7 +305,7 @@ does not stick to its own COM rules</li> other methods as required to wined3d.</li> <li> Implement them as far as you feel like :-)</li> </ul> -I think the good thing about this is that there are is not much knowledge +I think the good thing about this is that there is not much knowledge about wined3d and d3d10 necessary at the start. The one who works on it can learn the d3d10 interface while writing the stubs and learn about wined3d when starting to call it. @@ -341,7 +341,7 @@ on OpenGL and included in the 2.0 spec. <a href="http://www.winehq.org/pipermail/wine-devel/2006-November/052375.html">pointed out</a> a few months ago that there's an HLSL to GLSL converter. Anyway, back to the topic at hand: DX 10. Ivan wasn't sure DX10 should -count as an SoC project: +count as a SoC project: <quote who="Ivan Gyurdiev"> Yes, I am sure wine will benefit greatly from a d3d10 stub, mapping 1-to-1 to wined3d where possible, but is it really a project that @@ -366,7 +366,7 @@ The idea is that our main Direct3D engin Direct3D versions, from Direct3D 1 to Direct3D10. Admittedly, the core functionality that is equal between d3d1 and d3d10 is comparably small, and the part that exists should work pretty well by now. But work on d3d10 games -can definitly fix bugs in d3d9 apps accidentally, in the same way the d3d7 +can definitely fix bugs in d3d9 apps accidentally, in the same way the d3d7 merge fixed bugs in wined3d that affected d3d9 apps. Also consider that d3d10 may need some architectural changes to wined3d. I @@ -377,11 +377,11 @@ that we have to turn a few core parts up Of course having one SoC project on d3d10 does not exclude someone else who wants to do something do a SoC project on d3d9 :-) . Ideas would be Overlay support for movie players or the d3dx9_xy helper DLLs (although those are -maybe out of scope for wine). Or even a completely different area of DirectX. +maybe out of the scope of wine). Or even a completely different area of DirectX. DirectSound, DirectPlay, ... One problem is nowadays that wined3d is pretty advanced already, and the -learning curve is rather hard already. D3D10 is in my eyes an oportunity of +learning curve is rather hard already. D3D10 is in my eyes an opportunity of an exciting project which allows a new developer to grow into wined3d. I personally won't start hacking on d3d10 immediately, I'll continue to work on d3d9 and below apps. The state of d3d9 does not justify that yet. @@ -417,7 +417,7 @@ work for the start. It is a long way to Regaring Vista, the nice thing is that Students get Educational licenses cheap. But the license should be checked carefully. I for example may use it only for educational purposes. As I am working for CodeWeavers my hacking on -wine isn't purely for educational purposes. No idea of SoC can be considered +wine isn't purely for educational purposes. No idea if SoC can be considered an educational thing. </quote> @@ -500,7 +500,7 @@ use snail mail/fax from their web site). <quote who="Shachar Shemesh"> Wouldn't a paper saying they keep their rights, but approve the LGPL distribution also work? Would that still require us to have a written - statement? After all, we do not require written from other people. + statement? After all, we do not require written statements from other people. </quote> James Vasile replied with: @@ -580,7 +580,7 @@ appear to be due to missing redistributa Oh, or commonly-needed registry entries. </quote> -So wait.. this makes things easier, why is it bad you ask? Well, +So wait... this makes things easier, why is it bad you ask? Well, installing native components has led to lots of problems in the past. (It's also led to millions of successful program installations.) Any time native components get installed they simply provide less of a

1 0

lostwages/wwn wn20070305_324.xml
by Jeremy Newman 10 Sep '07

10 Sep '07

ChangeSet ID: 31372 CVSROOT: /opt/cvs-commit Module name: lostwages Changes by: jnewman(a)winehq.org 2007/09/10 12:21:16 Modified files: wwn : wn20070305_324.xml Log message: Francois Gouget <fgouget(a)free.fr> WWN324 spelling fixes Patch: http://cvs.winehq.org/patch.py?id=31372 Old revision New revision Changes Path 1.1 1.2 +6 -6 lostwages/wwn/wn20070305_324.xml Index: lostwages/wwn/wn20070305_324.xml diff -u -p lostwages/wwn/wn20070305_324.xml:1.1 lostwages/wwn/wn20070305_324.xml:1.2 --- lostwages/wwn/wn20070305_324.xml:1.1 10 Sep 2007 17:21:16 -0000 +++ lostwages/wwn/wn20070305_324.xml 10 Sep 2007 17:21:16 -0000 @@ -127,7 +127,7 @@ He announced them on wine-devel and aske <quote who="Stefan Dosinger"> Here is a new patchset for testing which implements duplicating gl contexts for new threads in wined3d. Again, it does not implement any synchronisation -measures(except ENTER_GL and glFinish), so running multithreaded games is +measures (except ENTER_GL and glFinish), so running multithreaded games is still kinda a lottery. This patchset also contains a patch for offscreen rendering, which may fix the @@ -143,8 +143,8 @@ were sent by me already. <li> There are many improvments in some games like Tomb Raider Legends, GTA San Andreas, HalfLife Episode One and 3DMark 2005 or 2006</li> <li> Oblivion is still broken (same as with previous patchset)</li> -<li> With your previous Thread patchset Rainbow Six Vegas can even run into -menu, but now it hang while loading menu.</li> +<li> With your previous Thread patchset Rainbow Six Vegas can even run to the +menu, but now it hangs while the loading menu.</li> <li> I can't find any other regressions :)</li></ul> Tested with:<ul> @@ -178,10 +178,10 @@ Awesome job! Now several more games that All of them were crashing after playing intro video(s). The only finicky game is Psychonauts. I had to force multi-threaded d3d and even then it -some times crashes. Apparently it's the case of thread safety that we +sometimes crashes. Apparently it's the case of thread safety that we don't have yet. -In general it seems the good step forward allowing lots more games to +In general it seems to be a good step forward allowing lots more games to work on Wine. </quote> @@ -198,7 +198,7 @@ work on Wine. OLE automation is a rather high-level API for working with COM objects. It allows applications to talk to each other and embed functionality from one into another. It was specifically designed -with scripting languages and as a result it's very common for Visual +with scripting languages ni mind and as a result it's very common for Visual Basic apps to use it. Wine's compatibility with regards to MSI still needs a bunch of attention. Misha Koshelev announced he had done a lot of work recently in this area:

1 0

lostwages/wwn wn20070226_323.xml
by Jeremy Newman 10 Sep '07

10 Sep '07

ChangeSet ID: 31371 CVSROOT: /opt/cvs-commit Module name: lostwages Changes by: jnewman(a)winehq.org 2007/09/10 12:20:37 Modified files: wwn : wn20070226_323.xml Log message: Francois Gouget <fgouget(a)free.fr> WWN323 spelling fixes Patch: http://cvs.winehq.org/patch.py?id=31371 Old revision New revision Changes Path 1.1 1.2 +22 -22 lostwages/wwn/wn20070226_323.xml Index: lostwages/wwn/wn20070226_323.xml diff -u -p lostwages/wwn/wn20070226_323.xml:1.1 lostwages/wwn/wn20070226_323.xml:1.2 --- lostwages/wwn/wn20070226_323.xml:1.1 10 Sep 2007 17:20:37 -0000 +++ lostwages/wwn/wn20070226_323.xml 10 Sep 2007 17:20:37 -0000 @@ -118,7 +118,7 @@ aware of it: This regression is known, and it should be fixed already. It was caused by my patch which made wined3d return an error if an unsupported query is created, like windows does. Wine does not support event queries, but many apps expect -them to be supported. I have sent another patch(committed already) that +them to be supported. I have sent another patch (committed already) that re-enables the fake event queries.</quote> Stefan wasn't aware of the other issue and asked Pavel to do a bisect @@ -127,18 +127,18 @@ was a patch that contained fixes for ful ran a trace using some debug channels which Stefan diagnosed: <quote who="Stefan Dosinger"> This here seems strange. If you compare that to the good log you'll see that -IWineD3DDeviceImpl_Init3D was left way to early. As there is no ERR about a -possible reason for the abortion I think that somewhere an exception is +IWineD3DDeviceImpl_Init3D was left way too early. As there is no ERR about a +possible reason for the abort I think that somewhere an exception is thrown, caught by the game which terminates afterwards. You can do the following:<ul> <li> Run the game in winedbg and see if it catches the execption and gives a backtrace and crash position</li> -<li> Add some extra traces(or ERRs) to Init3D and its subfunctions to catch the -last line that is exectuted successfully.</li></ul></quote> +<li> Add some extra traces (or ERRs) to Init3D and its subfunctions to catch the +last line that is executed successfully.</li></ul></quote> Pavel did a lot more testing and eventually narrowed the issue down to -some calls to <code>SetWindowPos()</code>. The concensus seemed to be that +some calls to <code>SetWindowPos()</code>. The consensus seemed to be that the problem didn't actually lie with that function, but with the parameters passed to it or some such event. Thus far it doesn't appear there's a solution other than a hack by Pavel to simply comment out the SetWindowPos() @@ -157,15 +157,15 @@ calls. screenshots of Wine showing off the latest work on Direct3D: <quote who="Mirek"> Hi, i would like to say "Thanks for your work!" to all wine developers. -In past months there was realy big progress in implementation of +In the past months there was really big progress in implementation of Direct3D in wine (that part is most important for me) and other parts -such Dinput, so I would like to introduce you some more sreenshots from -latest Direct3D applications. I will try to post them on official wine +such as Dinput, so I would like to introduce you to some more sreenshots from +the latest Direct3D applications. I will try to post them on the official wine website. -To run third benchmark in 3DMark 2005 I used wined3d_3dmark05.diff.txt +To run the third benchmark in 3DMark 2005 I used the wined3d_3dmark05.diff.txt patch (from H. Verbeet) -To run Call of Dutty 2 I used cod2.diff patch (my latest modification of +To run Call of Duty 2 I used cod2.diff patch (my latest modification of a patch against current CVS) All screenshots are from today CVS 20.02.2007 without patch "[9/10] @@ -223,7 +223,7 @@ problem but no diagnosis or solution. The comctl32 controls all do theming "natively". The subclassing is done -only for control residing in user32 (the motivation was to avoid copying +only for controls residing in user32 (the motivation was to avoid copying and pasting all the control implementations from user32 to comctl32, as Microsoft supposedly did). @@ -285,19 +285,19 @@ mailing list and asked developers what t <quote who="Tom Wickline"> On February 14th I made a suggestion on the wine-conf mailing list -that we should have a annual Fund Raiser to help raise funds for our +that we should have an annual Fund Raiser to help raise funds for our annual Conference. <ul><a href="http://www.winehq.org/pipermail/wineconf/2007-February/000397.html"> http://www.winehq.org/pipermail/wineconf/2007-February/000397.html</a></ul> -Jeremy replied with his thoughts/suggestions and some back ground info +Jeremy replied with his thoughts/suggestions and some background info on how the WPF funds have helped in the past. <ul><a href="http://www.winehq.org/pipermail/wineconf/2007-February/000397.html"> http://www.winehq.org/pipermail/wineconf/2007-February/000403.html</a></ul> -From this, I cobbled together a extremely rough Donations page.. +From this, I cobbled together an extremely rough Donations page.. Keep in mind this is still very much a work in progress and the language within it needs major revisions. @@ -306,9 +306,9 @@ http://www.winehq.org/pipermail/wineconf The current discussion is now on whether or not a $1,000 donation is sufficient for a front page listing for one year since our search rank -in so high. +is so high. -Dan suggested that we join adsence, and I replied that I had already +Dan suggested that we join adsense, and I replied that I had already suggested this in the past. <ul><a href="http://www.winehq.org/pipermail/wineconf/2007-February/000397.html"> @@ -316,10 +316,10 @@ http://www.winehq.org/pipermail/wineconf At this point there are many undecided questions about the original suggestion of us having a fund raiser, as well as if we should join -adsence. +adsense. If you have a opinion on this subject we would like (even suggest) -that you to air them at this time before decisions are made. +that you air it at this time before decisions are made. <ul><a href="http://www.winehq.org/pipermail/wineconf/2007-February/000397.html"> http://www.winehq.org/pipermail/wineconf/2007-February/000440.html</a></ul> @@ -328,16 +328,16 @@ http://www.winehq.org/pipermail/wineconf Questions: Should we have a annual fundraiser to help with conference expenses? -Thus far the consciences is Yes. +Thus far the consensus is Yes. What is a realistic goal? I believe $10,000 is very doable. What amount should we receive for a front page listing 'gold sponsor'? -Is $10,000 to much or to small of a amount? If we decide on $10,000 +Is $10,000 to much or too small an amount? If we decide on $10,000 the goal should be revised to about $25,000 -Should the Wine project join the adsence network? +Should the Wine project join the adsense network? With our high google page rank we are practically guaranteed to rake in a mint :D </quote>

1 0

lostwages/wwn wn20070219_322.xml
by Jeremy Newman 10 Sep '07

10 Sep '07

ChangeSet ID: 31370 CVSROOT: /opt/cvs-commit Module name: lostwages Changes by: jnewman(a)winehq.org 2007/09/10 12:20:02 Modified files: wwn : wn20070219_322.xml Log message: Francois Gouget <fgouget(a)free.fr> WWN322 spelling fixes Patch: http://cvs.winehq.org/patch.py?id=31370 Old revision New revision Changes Path 1.2 1.3 +22 -22 lostwages/wwn/wn20070219_322.xml Index: lostwages/wwn/wn20070219_322.xml diff -u -p lostwages/wwn/wn20070219_322.xml:1.2 lostwages/wwn/wn20070219_322.xml:1.3 --- lostwages/wwn/wn20070219_322.xml:1.2 10 Sep 2007 17:20: 2 -0000 +++ lostwages/wwn/wn20070219_322.xml 10 Sep 2007 17:20: 2 -0000 @@ -215,7 +215,7 @@ of CrossOver, including the beginnings o Jeremy White's announcement to the mailing list was more interesting than the <a href="http://www.codeweavers.com/about/general/press/?id=20070109a">press release</a>. From that announcement: -<quote who="Codeweavers"> +<quote who="CodeWeavers"> Users of Intel based Mac systems can now seamlessly run many Windows applications on their Mac without needing a Windows license. Supported applications include Outlook, Visio, Project, Quicken, Steam based @@ -232,7 +232,7 @@ We are looking forward to 2007, as we pl a range of improvements to CrossOver, particularly as we get our Mac 'sea legs' underneath ourselves. This will include refinements to many of our supported applications, and will also hopefully -included expanded support for many other applications, notably games. +include expanded support for many other applications, notably games. </quote> As far as Wine development goes, we'll probably start seeing some @@ -258,7 +258,7 @@ the DIB engine would address doesn't see agree that a DIB engine would bring large performance benefits. We've covered this topic in depth many times and you can see the wiki page for <a href="http://wiki.winehq.org/DIBEngine">a description</a> of -exactly what what the issue is. The short version: we need to be able to +exactly what the issue is. The short version: we need to be able to draw things within Wine that we're currently relying on the X server to do. Besides just writing the code, there's a huge concern about how to integrate such a beast into Wine without hell breaking loose. @@ -270,7 +270,7 @@ This is getting a bit long so if you do I've looked a little more at the issue of a DIB Engine and tried to use the feedback -so far to get an idea what the possible architecture could be. +so far to get an idea of what the possible architecture could be. First I took a look at how Windows seems to do it currently (excluding Vista). There @@ -307,14 +307,14 @@ simulated by the GDI engine by calling other driver functions and if the driver didn't hook the function or didn't succeed and it is for a DIB surface then the GDI engine itself will call the -according Eng... -function. GDI32 exports most of those Eng... functions too but that are +corresponding Eng... +function. GDI32 exports most of those Eng... functions too but they are simply user space wrappers around the win32k.sys entry points for those functions. From a design view it might be interesting to separate the actual GDI engine into a subpart -that corresponds with the NtGdi... functions in win32k.sys eventhough they +that corresponds with the NtGdi... functions in win32k.sys even though they might stay inside GDI32 for the time being. The actual Eng... functions would be also placed inside that GDI @@ -326,7 +326,7 @@ mirror of the GDI API. There are lists of what APIs win32k.sys does export and how many parameters each of these functions takes, extracted from the actual win32k.sys file. -Eventhough Windows +Even though Windows keeps them in the win32k.sys kernel I think it would be a good idea to keep them all in GDI32 for the time being. If that API is at some time mostly complete and @@ -365,7 +365,7 @@ Wine is any closer to a DIB engine, at l a little earlier so there's some time to come up to speed with regards to each project. Tom Wickline announced it on wine-devel: <quote who="Tom Wickline"> -I see Google is going to do there summer of code again this year :-) +I see Google is going to do their summer of code again this year :-) They plan to start accepting applications in March, so now would be the time for us to propose new projects and review the ones we have already listed on the Wiki for interested applicants? As well as line @@ -377,7 +377,7 @@ up mentors for the accepted applicants? </quote> Many of the projects on the wiki are still available to be worked on. -There's also about a bizillion other things you could take a stab at. +There's also about a bazillion other things you could take a stab at. </section> <section @@ -401,10 +401,10 @@ freedesktop.org specs: <li> add a global menu item for winecfg in System -> Preferences (seen by all users)</li></ul> - I also have what should be add to installation so .exe files + I also have what should be added to installation so .exe files are executed with wine when double-clicked (tested in ubuntu) - How could i submit those files ?? I cannot din anything + How could i submit those files ?? I cannot find anything related to this in the bugzilla :( </quote> @@ -439,16 +439,16 @@ be an understatement. Stefan Dösin patches in by the truckload. After another round of patches, someone commented: <quote who="Mirek"> -Wow, great work!!!!! 3DMark 2006 with fbo looks realy coool!! And some -Nvidia SDK demos are completly fixed!</quote> +Wow, great work!!!!! 3DMark 2006 with fbo looks really coool!! And some +Nvidia SDK demos are completely fixed!</quote> Following up on that, there were some screenshots posted: <quote who="Mirek"> -Yes, but after accept this error message i can select some test and run +Yes, but after accepting this error message i can select some test and run the benchmark, i have full version v102. I can't run any PS3 HDR test, GT1 and GT2 tests are almost perfect, but very slow (fbo is slower than backbuffer, so I am not using it in other applications), you should also -disable post procesing (very very slow) in 3DMark. Here are some +disable post processing (very very slow) in 3DMark. Here are some screenshots with latest wine and latest Stefan patches: <ul><a href="http://62.240.181.87/Mirek/3DMark2006/"> http://62.240.181.87/Mirek/3DMark2006/</a></ul></quote> @@ -487,7 +487,7 @@ Date: Mon Feb 12 16:47:56 2007 +0800</ul> -causes that IDA Pro shows black squares instead of its toolbar icons. +causes IDA Pro to show black squares instead of its toolbar icons. </quote> Apparently this regression is causing problems in other programs too. @@ -508,15 +508,15 @@ Scott Ritchie, Gerald Pfeifer, Kris Moor has excellent coverage with up to date packages. Bill Medland still had a question though: <quote who="Bill Medland"> -I'm looking to see if there are rpms being built for Red Hate Enterprise +I'm looking to see if there are rpms being built for Red Hat Enterprise Linux 3 these days. I see that the Red Hat rpms nowadays are for fc. but they aren't suitable for RHEL3 -The download page says that the RedHat/Fedora area is for RedAht 8,9 and -fedora, but I don't see any RedHat 8 or 9 there. Are they not there or +The download page says that the RedHat/Fedora area is for RedHat 8,9 and +Fedora, but I don't see any RedHat 8 or 9 there. Are they not there or am I looking in the wrong place?</quote> -Lei Zhang then spoke up and mentioned that although the RPM's aren't +Lei Zhang then spoke up and mentioned that although the RPMs aren't listed on Wine's <a href="http://www.winehq.com/site/download">Download</a> page, he maintains them: @@ -540,7 +540,7 @@ working with Wine: <quote who="Darryl Dixon"> Just a brief to let you know that it looks like Microsoft is finally -taking compatability seriously ;) - the new Beta 3 version of the IE +taking compatibility seriously ;) - the new Beta 3 version of the IE Developers Toolbar (<a href="http://www.microsoft.com/downloads/details.aspx?FamilyID=e59c3964-672d-4511…">link</a>) improves on the previous Beta release by installing and working correctly with

1 0

lostwages/wwn wn20070216_321.xml
by Jeremy Newman 10 Sep '07

10 Sep '07

ChangeSet ID: 31369 CVSROOT: /opt/cvs-commit Module name: lostwages Changes by: jnewman(a)winehq.org 2007/09/10 12:19:20 Modified files: wwn : wn20070216_321.xml Log message: Francois Gouget <fgouget(a)free.fr> WWN 321 spelling fixes Patch: http://cvs.winehq.org/patch.py?id=31369 Old revision New revision Changes Path 1.2 1.3 +18 -18 lostwages/wwn/wn20070216_321.xml Index: lostwages/wwn/wn20070216_321.xml diff -u -p lostwages/wwn/wn20070216_321.xml:1.2 lostwages/wwn/wn20070216_321.xml:1.3 --- lostwages/wwn/wn20070216_321.xml:1.2 10 Sep 2007 17:19:20 -0000 +++ lostwages/wwn/wn20070216_321.xml 10 Sep 2007 17:19:20 -0000 @@ -76,7 +76,7 @@ still need some assistance with some iss <ol> <li> I need people to test this on any window manager they can to see if the results that I get can be reproduced, especially on older GNOME -versions (I tested on GNOME 2.14) I was able to run a small test app +versions (I tested on GNOME 2.14). I was able to run a small test app that I made over 120 times, and each time it docked perfectly, no zombie systray adapter windows like before.</li> @@ -197,7 +197,7 @@ reports again. </quote> [Feb. 16 2007, ed. note: scans of the Wine codebase have been -occuring regularly and work has been done to fix the bugs] +occurring regularly and work has been done to fix the bugs] </section> <section @@ -345,7 +345,7 @@ separately, which we should do to keep p Let me illustrate my idea: <ul> <li> Move out the GL calls from Set*State. Set*State writes the values to the -update stateblock and updates the refcounts(maybe we should kick internal +update stateblock and updates the refcounts (maybe we should kick internal refcounting from wined3d altogether)</li> <li> Keep the stateblock and update stateblock structure as they are now. I think @@ -391,12 +391,12 @@ Thanks for all your work on audio!! Eric Pouech thought there might be a problem with an ASIO driver: <quote who="Eric Pouech"> -I'm afraid submission (or integration in the Wine tree) will be problematic -ASIO interface is copyrighted, and you need to sign an agreement to +I'm afraid submission (or integration in the Wine tree) will be problematic. +The ASIO interface is copyrighted, and you need to sign an agreement to Steinberg for using the API. IANAL, but including derivative work of a copyrighted API will not be possible. -But, this doesn't prevent from creating a standalone audio driver. +But, this doesn't prevent you from creating a standalone audio driver. </quote> </section> <section @@ -490,10 +490,10 @@ the .desktop files in ~/.wine). If anyon to know how it works. There is a small problem that KDE scans the ~/.kde/applnk directory (unlike Gnome that scans only the global directories /usr/share/applnk -and /etc/X11/applnk and that why the menu is not visible) and after this +and /etc/X11/applnk and that's why the menu is not visible) and after this change will display the menu items twice. This can be fixed by creating the ".desktop" in legacy directories with "OnlyShowIn=Old;". - If this sound good I can send patches to winecreateprefix and + If this sounds good I can send patches to winecreateprefix and wineshelllink with these fixes. </quote> @@ -510,7 +510,7 @@ created there will be automatically remo When the $WINEPREFIX/menu directory is present a desktop item is created there. The desktop item in legacy directories are created with "ShowOnlyIn=Old;" so there will be no duplication of icons. If -$WINEPREFIX/menu is not present (i.e. a wineprefix create with an old +$WINEPREFIX/menu is not present (i.e. a wineprefix created with an old wineprefixcreate) the files are created as they used to be (without "ShowOnlyIn=Old;").</quote> @@ -583,8 +583,8 @@ For this reason, using HeapAlloc(GetProc kernel32.dll is a possible way to go for "localspl.dll". </li><li> -To let printing in Wine work as similar as possible as printing is done -in Windows, (but without RPC and without the spooler service) we can +To let printing in Wine work as similarly as possible as printing is done +in Windows (but without RPC and without the spooler service), we can change the code path to "winspool.drv -> spoolss.dll -> localspl.dll -> CUPS/LPR" and use the exports from spoolss.dll. @@ -620,14 +620,14 @@ usually garners some comments as well.)< We used to have pretty good notes on regression testing, but things have changed now that we have git. The general idea remains the same, but the mechanics are a bit different. If you find a -regressions between releases, just bisect the release and see +regression between releases, just bisect the release and see if the regression exists there, bisect that, and so on till you find the issue. Of course, you can usually do a better job than that if you're tracking changes specific to a DLL. Anyway, Kapila De Silva asked: <quote who="Kapila De Silva"> -Im trying to track down an issue that occurred between 0.9.19 and -0.9.20, and am using git bisect to track the issue. In the process of +I'm trying to track down an issue that occurred between 0.9.19 and +0.9.20, and I am using git bisect to track the issue. In the process of trying to identify the cause of the issue, I would like to be able to get the code up till a certain patch, and then apply patches one by one as well. @@ -641,7 +641,7 @@ searches and man pages. Can anyone give What I do is to follow along with things on the shortlog: <ul><a href="http://source.winehq.org/git/?p=wine.git;a=shortlog">http://source.winehq.org/git/?p=wine.git;a=shortlog</a></ul> -Lets say you want to move your current branch to my recent patch +Let's say you want to move your current branch to my recent patch "riched20: Rewrite of scrolling and some redrawing code." - you'd click the link "commit" to the right of it. In the page that you'll be taken to, you'll see a line like this: @@ -652,10 +652,10 @@ you can then do a: and your git will be moved to the point in time right after that commit. If you then want to manually apply a patch, click "commitdiff" -to the right of it's entry in the shortlog, followed by "plain" on the +to the right of its entry in the shortlog, followed by "plain" on the top - this will take you to a plaintext diff of the patch, which you could save to a file and apply with the patch command. ("patch -p1 < -thepatch.diff" usualy works well for me)</quote> +thepatch.diff" usually works well for me)</quote> Mike McCormack followed up on the last paragraph to mention two different ways that could be managed with git: @@ -710,7 +710,7 @@ My one win app that makes me a devotee o <a href="http://www.tabledit.com/download/tabled32.exe">www.tabledit.com/download/tabled32.exe</a>) has a custom font , tef260.ttf, that has failed to display since somewhere after ver 9.6. The program installs the font into -c:\windows\font, but can not display it within the program, instead +c:\windows\font, but cannot display it within the program, instead displaying for the most part, empty squares. I tried putting/removing tef260.ttf into /usr/local/share/wine/fonts,

1 0