January 2008 - Wine-commits

Hans Leidekker : msvcrt: Implement _wexecv{, e, p, pe}.
by Alexandre Julliard 08 Jan '08

08 Jan '08

Module: wine Branch: master Commit: 8d768b7713c69d0091138984800431b84f0afaf7 URL: http://source.winehq.org/git/wine.git/?a=commit;h=8d768b7713c69d00911389848… Author: Hans Leidekker <hans(a)it.vu.nl> Date: Mon Jan 7 14:23:46 2008 +0100 msvcrt: Implement _wexecv{, e, p, pe}. --- dlls/msvcrt/msvcrt.h | 2 ++ dlls/msvcrt/msvcrt.spec | 8 ++++---- dlls/msvcrt/process.c | 45 +++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 51 insertions(+), 4 deletions(-) diff --git a/dlls/msvcrt/msvcrt.h b/dlls/msvcrt/msvcrt.h index bc94284..951f7ad 100644 --- a/dlls/msvcrt/msvcrt.h +++ b/dlls/msvcrt/msvcrt.h @@ -634,6 +634,8 @@ int MSVCRT__write(int,const void*,unsigned int); int _getch(void); int _ismbstrail(const unsigned char* start, const unsigned char* str); MSVCRT_intptr_t _spawnve(int,const char*,const char* const *,const char* const *); +MSVCRT_intptr_t _wspawnve(int,const MSVCRT_wchar_t*,const MSVCRT_wchar_t* const *,const MSVCRT_wchar_t* const *); +MSVCRT_intptr_t _wspawnvpe(int,const MSVCRT_wchar_t*,const MSVCRT_wchar_t* const *,const MSVCRT_wchar_t* const *); void _searchenv(const char*,const char*,char*); int _getdrive(void); char* _strdup(const char*); diff --git a/dlls/msvcrt/msvcrt.spec b/dlls/msvcrt/msvcrt.spec index c4113aa..0877366 100644 --- a/dlls/msvcrt/msvcrt.spec +++ b/dlls/msvcrt/msvcrt.spec @@ -522,10 +522,10 @@ @ varargs _wexecle(wstr wstr) @ varargs _wexeclp(wstr wstr) @ varargs _wexeclpe(wstr wstr) -@ stub _wexecv #(wstr ptr) -@ stub _wexecve #(wstr ptr ptr) -@ stub _wexecvp #(wstr ptr) -@ stub _wexecvpe #(wstr ptr ptr) +@ cdecl _wexecv(wstr ptr) +@ cdecl _wexecve(wstr ptr ptr) +@ cdecl _wexecvp(wstr ptr) +@ cdecl _wexecvpe(wstr ptr ptr) @ cdecl _wfdopen(long wstr) MSVCRT__wfdopen @ cdecl _wfindfirst(wstr ptr) MSVCRT__wfindfirst @ cdecl _wfindfirsti64(wstr ptr) MSVCRT__wfindfirsti64 diff --git a/dlls/msvcrt/process.c b/dlls/msvcrt/process.c index d764eaf..9be2b94 100644 --- a/dlls/msvcrt/process.c +++ b/dlls/msvcrt/process.c @@ -542,6 +542,16 @@ MSVCRT_intptr_t CDECL _execlpe(const char* name, const char* arg0, ...) } /********************************************************************* + * _wexecv (MSVCRT.@) + * + * Unicode version of _execv + */ +MSVCRT_intptr_t CDECL _wexecv(const MSVCRT_wchar_t* name, MSVCRT_wchar_t* const* argv) +{ + return _wspawnve(MSVCRT__P_OVERLAY, name, (const MSVCRT_wchar_t* const*) argv, NULL); +} + +/********************************************************************* * _execv (MSVCRT.@) * * Like on Windows, this function does not handle arguments with spaces @@ -553,6 +563,16 @@ MSVCRT_intptr_t CDECL _execv(const char* name, char* const* argv) } /********************************************************************* + * _wexecve (MSVCRT.@) + * + * Unicode version of _execve + */ +MSVCRT_intptr_t CDECL _wexecve(const MSVCRT_wchar_t* name, MSVCRT_wchar_t* const* argv, const MSVCRT_wchar_t* const* envv) +{ + return _wspawnve(MSVCRT__P_OVERLAY, name, (const MSVCRT_wchar_t* const*) argv, envv); +} + +/********************************************************************* * _execve (MSVCRT.@) * * Like on Windows, this function does not handle arguments with spaces @@ -564,6 +584,21 @@ MSVCRT_intptr_t CDECL MSVCRT__execve(const char* name, char* const* argv, const } /********************************************************************* + * _wexecvpe (MSVCRT.@) + * + * Unicode version of _execvpe + */ +MSVCRT_intptr_t CDECL _wexecvpe(const MSVCRT_wchar_t* name, MSVCRT_wchar_t* const* argv, const MSVCRT_wchar_t* const* envv) +{ + static const MSVCRT_wchar_t path[] = {'P','A','T','H',0}; + MSVCRT_wchar_t fullname[MAX_PATH]; + + _wsearchenv(name, path, fullname); + return _wspawnvpe(MSVCRT__P_OVERLAY, fullname[0] ? fullname : name, + (const MSVCRT_wchar_t* const*) argv, envv); +} + +/********************************************************************* * _execvpe (MSVCRT.@) * * Like on Windows, this function does not handle arguments with spaces @@ -579,6 +614,16 @@ MSVCRT_intptr_t CDECL _execvpe(const char* name, char* const* argv, const char* } /********************************************************************* + * _wexecvp (MSVCRT.@) + * + * Unicode version of _execvp + */ +MSVCRT_intptr_t CDECL _wexecvp(const MSVCRT_wchar_t* name, MSVCRT_wchar_t* const* argv) +{ + return _wexecvpe(name, argv, NULL); +} + +/********************************************************************* * _execvp (MSVCRT.@) * * Like on Windows, this function does not handle arguments with spaces

1 0

Hans Leidekker : msvcrt: Correct search strategy for the exec/ spawn functions.
by Alexandre Julliard 08 Jan '08

08 Jan '08

Module: wine Branch: master Commit: 41575621c8100356b31a71fea4dbd4686644a0ad URL: http://source.winehq.org/git/wine.git/?a=commit;h=41575621c8100356b31a71fea… Author: Hans Leidekker <hans(a)it.vu.nl> Date: Mon Jan 7 14:24:02 2008 +0100 msvcrt: Correct search strategy for the exec/spawn functions. --- dlls/msvcrt/msvcrt.h | 1 + dlls/msvcrt/process.c | 270 +++++++++++++++++++++++++++++-------------------- 2 files changed, 161 insertions(+), 110 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=41575621c8100356b31a7…

1 0

Hans Leidekker : msvcrt: Implement _wpopen and forward _popen to it.
by Alexandre Julliard 08 Jan '08

08 Jan '08

Module: wine Branch: master Commit: 118bee860a3108ce3ab01823dc93d4f186ecba77 URL: http://source.winehq.org/git/wine.git/?a=commit;h=118bee860a3108ce3ab01823d… Author: Hans Leidekker <hans(a)it.vu.nl> Date: Mon Jan 7 14:22:36 2008 +0100 msvcrt: Implement _wpopen and forward _popen to it. --- dlls/msvcrt/msvcrt.h | 1 + dlls/msvcrt/process.c | 69 ++++++++++++++++++++++++++++++------------------ 2 files changed, 44 insertions(+), 26 deletions(-) diff --git a/dlls/msvcrt/msvcrt.h b/dlls/msvcrt/msvcrt.h index 59c42cb..bc94284 100644 --- a/dlls/msvcrt/msvcrt.h +++ b/dlls/msvcrt/msvcrt.h @@ -623,6 +623,7 @@ MSVCRT_clock_t MSVCRT_clock(void); double MSVCRT_difftime(MSVCRT_time_t time1, MSVCRT_time_t time2); MSVCRT_time_t MSVCRT_time(MSVCRT_time_t*); MSVCRT_FILE* MSVCRT__fdopen(int, const char *); +MSVCRT_FILE* MSVCRT__wfdopen(int, const MSVCRT_wchar_t *); int MSVCRT_vsnprintf(char *str, unsigned int len, const char *format, va_list valist); int MSVCRT_vsnwprintf(MSVCRT_wchar_t *str, unsigned int len, const MSVCRT_wchar_t *format, va_list valist ); diff --git a/dlls/msvcrt/process.c b/dlls/msvcrt/process.c index 46481ef..2db9a7d 100644 --- a/dlls/msvcrt/process.c +++ b/dlls/msvcrt/process.c @@ -721,22 +721,21 @@ MSVCRT_intptr_t CDECL _wspawnvp(int flags, const MSVCRT_wchar_t* name, const MSV } /********************************************************************* - * _popen (MSVCRT.@) - * FIXME: convert to _wpopen and call that from here instead? But it - * would have to convert the command back to ANSI to call msvcrt_spawn, - * less than ideal. + * _wpopen (MSVCRT.@) + * + * Unicode version of _popen */ -MSVCRT_FILE* CDECL MSVCRT__popen(const char* command, const char* mode) +MSVCRT_FILE* CDECL MSVCRT__wpopen(const MSVCRT_wchar_t* command, const MSVCRT_wchar_t* mode) { - static const char wcmd[] = "cmd", cmdFlag[] = " /C ", comSpec[] = "COMSPEC"; MSVCRT_FILE *ret; BOOL readPipe = TRUE; int textmode, fds[2], fdToDup, fdToOpen, fdStdHandle = -1, fdStdErr = -1; - const char *p; - char *cmdcopy; - DWORD comSpecLen; + const MSVCRT_wchar_t *p; + MSVCRT_wchar_t *comspec, *fullcmd; + unsigned int len; + static const MSVCRT_wchar_t flag[] = {' ','/','c',' ',0}; - TRACE("(command=%s, mode=%s)\n", debugstr_a(command), debugstr_a(mode)); + TRACE("(command=%s, mode=%s)\n", debugstr_w(command), debugstr_w(mode)); if (!command || !mode) return NULL; @@ -782,27 +781,27 @@ MSVCRT_FILE* CDECL MSVCRT__popen(const char* command, const char* mode) MSVCRT__close(fds[fdToDup]); - comSpecLen = GetEnvironmentVariableA(comSpec, NULL, 0); - if (!comSpecLen) - comSpecLen = strlen(wcmd) + 1; - cmdcopy = HeapAlloc(GetProcessHeap(), 0, comSpecLen + strlen(cmdFlag) - + strlen(command)); - if (!GetEnvironmentVariableA(comSpec, cmdcopy, comSpecLen)) - strcpy(cmdcopy, wcmd); - strcat(cmdcopy, cmdFlag); - strcat(cmdcopy, command); - if (msvcrt_spawn(MSVCRT__P_NOWAIT, NULL, cmdcopy, NULL) == -1) + if (!(comspec = msvcrt_get_comspec())) goto error; + len = strlenW(comspec) + strlenW(flag) + strlenW(command) + 1; + + if (!(fullcmd = HeapAlloc(GetProcessHeap(), 0, len * sizeof(MSVCRT_wchar_t)))) goto error; + strcpyW(fullcmd, comspec); + strcatW(fullcmd, flag); + strcatW(fullcmd, command); + HeapFree(GetProcessHeap(), 0, comspec); + + if (msvcrt_spawn_wide(MSVCRT__P_NOWAIT, NULL, fullcmd, NULL) == -1) { MSVCRT__close(fds[fdToOpen]); ret = NULL; } else { - ret = MSVCRT__fdopen(fds[fdToOpen], mode); + ret = MSVCRT__wfdopen(fds[fdToOpen], mode); if (!ret) MSVCRT__close(fds[fdToOpen]); } - HeapFree(GetProcessHeap(), 0, cmdcopy); + HeapFree(GetProcessHeap(), 0, fullcmd); MSVCRT__dup2(fdStdHandle, fdToDup); MSVCRT__close(fdStdHandle); if (readPipe) @@ -821,12 +820,30 @@ error: } /********************************************************************* - * _wpopen (MSVCRT.@) + * _popen (MSVCRT.@) */ -MSVCRT_FILE* CDECL MSVCRT__wpopen(const MSVCRT_wchar_t* command, const MSVCRT_wchar_t* mode) +MSVCRT_FILE* CDECL MSVCRT__popen(const char* command, const char* mode) { - FIXME("(command=%s, mode=%s): stub\n", debugstr_w(command), debugstr_w(mode)); - return NULL; + MSVCRT_FILE *ret; + MSVCRT_wchar_t *cmdW, *modeW; + + TRACE("(command=%s, mode=%s)\n", debugstr_a(command), debugstr_a(mode)); + + if (!command || !mode) + return NULL; + + if (!(cmdW = msvcrt_wstrdupa(command))) return NULL; + if (!(modeW = msvcrt_wstrdupa(mode))) + { + HeapFree(GetProcessHeap(), 0, cmdW); + return NULL; + } + + ret = MSVCRT__wpopen(cmdW, modeW); + + HeapFree(GetProcessHeap(), 0, cmdW); + HeapFree(GetProcessHeap(), 0, modeW); + return ret; } /*********************************************************************

1 0

Hans Leidekker : msvcrt: Rewrite _execl/ _spawnl functions as wrappers around wide character implementations.
by Alexandre Julliard 08 Jan '08

08 Jan '08

Module: wine Branch: master Commit: 1ba54f3337df5b9d03cb939315224ae824c08886 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1ba54f3337df5b9d03cb93931… Author: Hans Leidekker <hans(a)it.vu.nl> Date: Mon Jan 7 14:22:46 2008 +0100 msvcrt: Rewrite _execl/_spawnl functions as wrappers around wide character implementations. --- dlls/msvcrt/process.c | 188 +++++++++++++++++++++++++++++++----------------- 1 files changed, 121 insertions(+), 67 deletions(-) diff --git a/dlls/msvcrt/process.c b/dlls/msvcrt/process.c index 2db9a7d..dc22fcb 100644 --- a/dlls/msvcrt/process.c +++ b/dlls/msvcrt/process.c @@ -215,16 +215,57 @@ static MSVCRT_wchar_t* msvcrt_argvtos_wide(const MSVCRT_wchar_t* const* arg, MSV return ret; } -/* INTERNAL: Convert va_list to a single 'delim'-separated string, with an - * extra '\0' to terminate it +/* INTERNAL: Convert ansi argv list to a single 'delim'-separated wide string, with an + * extra '\0' to terminate it. */ -static char* msvcrt_valisttos(const char* arg0, va_list alist, char delim) +static MSVCRT_wchar_t *msvcrt_argvtos_aw(const char * const *arg, MSVCRT_wchar_t delim) +{ + const char * const *a; + unsigned long len; + MSVCRT_wchar_t *p, *ret; + + if (!arg && !delim) + { + /* Return NULL for an empty environment list */ + return NULL; + } + + /* get length */ + a = arg; + len = 0; + while (*a) + { + len += MultiByteToWideChar(CP_ACP, 0, *a, -1, NULL, 0); + a++; + } + + ret = MSVCRT_malloc((len + 1) * sizeof(MSVCRT_wchar_t)); + if (!ret) + return NULL; + + /* fill string */ + a = arg; + p = ret; + while (*a) + { + p += MultiByteToWideChar(CP_ACP, 0, *a, strlen(*a), p, len - (p - ret)); + *p++ = delim; + a++; + } + if (delim && p > ret) p[-1] = 0; + else *p = 0; + return ret; +} + +/* INTERNAL: Convert ansi va_list to a single 'delim'-separated wide string, with an + * extra '\0' to terminate it. + */ +static MSVCRT_wchar_t *msvcrt_valisttos_aw(const char *arg0, va_list alist, MSVCRT_wchar_t delim) { va_list alist2; - long size; + unsigned long len; const char *arg; - char* p; - char *ret; + MSVCRT_wchar_t *p, *ret; #ifdef HAVE_VA_COPY va_copy(alist2,alist); @@ -244,13 +285,13 @@ static char* msvcrt_valisttos(const char* arg0, va_list alist, char delim) /* get length */ arg = arg0; - size = 0; + len = 0; do { - size += strlen(arg) + 1; + len += MultiByteToWideChar(CP_ACP, 0, arg, -1, NULL, 0); arg = va_arg(alist, char*); } while (arg != NULL); - ret = MSVCRT_malloc(size + 1); + ret = MSVCRT_malloc((len + 1) * sizeof(MSVCRT_wchar_t)); if (!ret) return NULL; @@ -258,9 +299,7 @@ static char* msvcrt_valisttos(const char* arg0, va_list alist, char delim) arg = arg0; p = ret; do { - int len = strlen(arg); - memcpy(p,arg,len); - p += len; + p += MultiByteToWideChar(CP_ACP, 0, arg, strlen(arg), p, len - (p - ret)); *p++ = delim; arg = va_arg(alist2, char*); } while (arg != NULL); @@ -327,16 +366,19 @@ MSVCRT_intptr_t CDECL _cwait(int *status, MSVCRT_intptr_t pid, int action) MSVCRT_intptr_t CDECL _execl(const char* name, const char* arg0, ...) { va_list ap; - char * args; - MSVCRT_intptr_t ret; + MSVCRT_wchar_t *nameW, *args; + MSVCRT_intptr_t ret = -1; + + if (!(nameW = msvcrt_wstrdupa(name))) return -1; va_start(ap, arg0); - args = msvcrt_valisttos(arg0, ap, ' '); + args = msvcrt_valisttos_aw(arg0, ap, ' '); va_end(ap); - ret = msvcrt_spawn(MSVCRT__P_OVERLAY, name, args, NULL); - MSVCRT_free(args); + ret = msvcrt_spawn_wide(MSVCRT__P_OVERLAY, nameW, args, NULL); + MSVCRT_free(nameW); + MSVCRT_free(args); return ret; } @@ -357,20 +399,22 @@ MSVCRT_intptr_t CDECL _execle(const char* name, const char* arg0, ...) */ MSVCRT_intptr_t CDECL _execlp(const char* name, const char* arg0, ...) { + static const MSVCRT_wchar_t path[] = {'P','A','T','H',0}; va_list ap; - char * args; + MSVCRT_wchar_t *nameW, *args, fullname[MAX_PATH]; MSVCRT_intptr_t ret; - char fullname[MAX_PATH]; - _searchenv(name, "PATH", fullname); + if (!(nameW = msvcrt_wstrdupa(name))) return -1; + _wsearchenv(nameW, path, fullname); va_start(ap, arg0); - args = msvcrt_valisttos(arg0, ap, ' '); + args = msvcrt_valisttos_aw(arg0, ap, ' '); va_end(ap); - ret = msvcrt_spawn(MSVCRT__P_OVERLAY, fullname[0] ? fullname : name, args, NULL); - MSVCRT_free(args); + ret = msvcrt_spawn_wide(MSVCRT__P_OVERLAY, fullname[0] ? fullname : nameW, args, NULL); + MSVCRT_free(nameW); + MSVCRT_free(args); return ret; } @@ -440,16 +484,19 @@ MSVCRT_intptr_t CDECL _execvp(const char* name, char* const* argv) MSVCRT_intptr_t CDECL _spawnl(int flags, const char* name, const char* arg0, ...) { va_list ap; - char * args; + MSVCRT_wchar_t *nameW, *args; MSVCRT_intptr_t ret; + if (!(nameW = msvcrt_wstrdupa(name))) return -1; + va_start(ap, arg0); - args = msvcrt_valisttos(arg0, ap, ' '); + args = msvcrt_valisttos_aw(arg0, ap, ' '); va_end(ap); - ret = msvcrt_spawn(flags, name, args, NULL); - MSVCRT_free(args); + ret = msvcrt_spawn_wide(flags, nameW, args, NULL); + MSVCRT_free(nameW); + MSVCRT_free(args); return ret; } @@ -458,26 +505,29 @@ MSVCRT_intptr_t CDECL _spawnl(int flags, const char* name, const char* arg0, ... */ MSVCRT_intptr_t CDECL _spawnle(int flags, const char* name, const char* arg0, ...) { - va_list ap; - char *args, *envs = NULL; - const char * const *envp; - MSVCRT_intptr_t ret; + va_list ap; + MSVCRT_wchar_t *nameW, *args, *envs = NULL; + const char * const *envp; + MSVCRT_intptr_t ret; - va_start(ap, arg0); - args = msvcrt_valisttos(arg0, ap, ' '); - va_end(ap); + if (!(nameW = msvcrt_wstrdupa(name))) return -1; - va_start(ap, arg0); - while (va_arg( ap, char * ) != NULL) /*nothing*/; - envp = va_arg( ap, const char * const * ); - if (envp) envs = msvcrt_argvtos(envp, 0); - va_end(ap); + va_start(ap, arg0); + args = msvcrt_valisttos_aw(arg0, ap, ' '); + va_end(ap); - ret = msvcrt_spawn(flags, name, args, envs); + va_start(ap, arg0); + while (va_arg( ap, char * ) != NULL) /*nothing*/; + envp = va_arg( ap, const char * const * ); + if (envp) envs = msvcrt_argvtos_aw(envp, 0); + va_end(ap); - MSVCRT_free(args); - MSVCRT_free(envs); - return ret; + ret = msvcrt_spawn_wide(flags, nameW, args, envs); + + MSVCRT_free(nameW); + MSVCRT_free(args); + MSVCRT_free(envs); + return ret; } @@ -489,20 +539,22 @@ MSVCRT_intptr_t CDECL _spawnle(int flags, const char* name, const char* arg0, .. */ MSVCRT_intptr_t CDECL _spawnlp(int flags, const char* name, const char* arg0, ...) { + static const MSVCRT_wchar_t path[] = {'P','A','T','H',0}; va_list ap; - char * args; + MSVCRT_wchar_t *nameW, *args, fullname[MAX_PATH]; MSVCRT_intptr_t ret; - char fullname[MAX_PATH]; - _searchenv(name, "PATH", fullname); + if (!(nameW = msvcrt_wstrdupa(name))) return -1; + _wsearchenv(nameW, path, fullname); va_start(ap, arg0); - args = msvcrt_valisttos(arg0, ap, ' '); + args = msvcrt_valisttos_aw(arg0, ap, ' '); va_end(ap); - ret = msvcrt_spawn(flags, fullname[0] ? fullname : name, args, NULL); - MSVCRT_free(args); + ret = msvcrt_spawn_wide(flags, fullname[0] ? fullname : nameW, args, NULL); + MSVCRT_free(nameW); + MSVCRT_free(args); return ret; } @@ -511,29 +563,31 @@ MSVCRT_intptr_t CDECL _spawnlp(int flags, const char* name, const char* arg0, .. */ MSVCRT_intptr_t CDECL _spawnlpe(int flags, const char* name, const char* arg0, ...) { - va_list ap; - char *args, *envs = NULL; - const char * const *envp; - MSVCRT_intptr_t ret; - char fullname[MAX_PATH]; + static const MSVCRT_wchar_t path[] = {'P','A','T','H',0}; + va_list ap; + MSVCRT_wchar_t *nameW, *args, *envs = NULL, fullname[MAX_PATH]; + const char * const *envp; + MSVCRT_intptr_t ret; - _searchenv(name, "PATH", fullname); + if (!(nameW = msvcrt_wstrdupa(name))) return -1; + _wsearchenv(nameW, path, fullname); - va_start(ap, arg0); - args = msvcrt_valisttos(arg0, ap, ' '); - va_end(ap); + va_start(ap, arg0); + args = msvcrt_valisttos_aw(arg0, ap, ' '); + va_end(ap); - va_start(ap, arg0); - while (va_arg( ap, char * ) != NULL) /*nothing*/; - envp = va_arg( ap, const char * const * ); - if (envp) envs = msvcrt_argvtos(envp, 0); - va_end(ap); + va_start(ap, arg0); + while (va_arg( ap, char * ) != NULL) /*nothing*/; + envp = va_arg( ap, const char * const * ); + if (envp) envs = msvcrt_argvtos_aw(envp, 0); + va_end(ap); - ret = msvcrt_spawn(flags, fullname[0] ? fullname : name, args, envs); + ret = msvcrt_spawn_wide(flags, fullname[0] ? fullname : nameW, args, envs); - MSVCRT_free(args); - MSVCRT_free(envs); - return ret; + MSVCRT_free(nameW); + MSVCRT_free(args); + MSVCRT_free(envs); + return ret; } /*********************************************************************

1 0

Hans Leidekker : msvcrt: Implement _execl{e, pe}.
by Alexandre Julliard 08 Jan '08

08 Jan '08

Module: wine Branch: master Commit: c91a597305c90d4ffc194c6da6e8d5a48133ebb3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c91a597305c90d4ffc194c6da… Author: Hans Leidekker <hans(a)it.vu.nl> Date: Mon Jan 7 14:22:57 2008 +0100 msvcrt: Implement _execl{e, pe}. --- dlls/msvcrt/process.c | 52 +++++++++++++++++++++++++++++++++++++++++++++--- 1 files changed, 48 insertions(+), 4 deletions(-) diff --git a/dlls/msvcrt/process.c b/dlls/msvcrt/process.c index dc22fcb..d2df7fa 100644 --- a/dlls/msvcrt/process.c +++ b/dlls/msvcrt/process.c @@ -387,8 +387,29 @@ MSVCRT_intptr_t CDECL _execl(const char* name, const char* arg0, ...) */ MSVCRT_intptr_t CDECL _execle(const char* name, const char* arg0, ...) { - FIXME("stub\n"); - return -1; + va_list ap; + MSVCRT_wchar_t *nameW, *args, *envs = NULL; + const char * const *envp; + MSVCRT_intptr_t ret; + + if (!(nameW = msvcrt_wstrdupa(name))) return -1; + + va_start(ap, arg0); + args = msvcrt_valisttos_aw(arg0, ap, ' '); + va_end(ap); + + va_start(ap, arg0); + while (va_arg( ap, char * ) != NULL) /*nothing*/; + envp = va_arg( ap, const char * const * ); + if (envp) envs = msvcrt_argvtos_aw(envp, 0); + va_end(ap); + + ret = msvcrt_spawn_wide(MSVCRT__P_OVERLAY, nameW, args, envs); + + MSVCRT_free(nameW); + MSVCRT_free(args); + MSVCRT_free(envs); + return ret; } /********************************************************************* @@ -423,8 +444,31 @@ MSVCRT_intptr_t CDECL _execlp(const char* name, const char* arg0, ...) */ MSVCRT_intptr_t CDECL _execlpe(const char* name, const char* arg0, ...) { - FIXME("stub\n"); - return -1; + static const MSVCRT_wchar_t path[] = {'P','A','T','H',0}; + va_list ap; + MSVCRT_wchar_t *nameW, *args, *envs = NULL, fullname[MAX_PATH]; + const char * const *envp; + MSVCRT_intptr_t ret; + + if (!(nameW = msvcrt_wstrdupa(name))) return -1; + _wsearchenv(nameW, path, fullname); + + va_start(ap, arg0); + args = msvcrt_valisttos_aw(arg0, ap, ' '); + va_end(ap); + + va_start(ap, arg0); + while (va_arg( ap, char * ) != NULL) /*nothing*/; + envp = va_arg( ap, const char * const * ); + if (envp) envs = msvcrt_argvtos_aw(envp, 0); + va_end(ap); + + ret = msvcrt_spawn_wide(MSVCRT__P_OVERLAY, fullname[0] ? fullname : nameW, args, envs); + + MSVCRT_free(nameW); + MSVCRT_free(args); + MSVCRT_free(envs); + return ret; } /*********************************************************************

1 0

Dmitry Timoshkov : gdi32: Add more tests for bitmap font metrics scaling.
by Alexandre Julliard 08 Jan '08

08 Jan '08

Module: wine Branch: master Commit: 3068ac9eca997f1c99dd28347e768fdee3709def URL: http://source.winehq.org/git/wine.git/?a=commit;h=3068ac9eca997f1c99dd28347… Author: Dmitry Timoshkov <dmitry(a)codeweavers.com> Date: Tue Jan 8 15:55:34 2008 +0800 gdi32: Add more tests for bitmap font metrics scaling. --- dlls/gdi32/tests/font.c | 19 +++++++++++++------ 1 files changed, 13 insertions(+), 6 deletions(-) diff --git a/dlls/gdi32/tests/font.c b/dlls/gdi32/tests/font.c index d38ec8d..b6e8327 100644 --- a/dlls/gdi32/tests/font.c +++ b/dlls/gdi32/tests/font.c @@ -158,17 +158,20 @@ static INT CALLBACK font_enum_proc(const LOGFONT *elf, const TEXTMETRIC *ntm, DW static void test_font_metrics(HDC hdc, HFONT hfont, const char *test_str, INT test_str_len, const TEXTMETRICA *tm_orig, - const SIZE *size_orig, INT width_orig, + const SIZE *size_orig, INT width_of_A_orig, INT scale_x, INT scale_y) { HFONT old_hfont; + LOGFONTA lf; TEXTMETRICA tm; SIZE size; - INT width; + INT width_of_A; if (!hfont) return; + GetObjectA(hfont, sizeof(lf), &lf); + old_hfont = SelectObject(hdc, hfont); GetTextMetricsA(hdc, &tm); @@ -177,20 +180,25 @@ static void test_font_metrics(HDC hdc, HFONT hfont, const char *test_str, ok(tm.tmAscent == tm_orig->tmAscent * scale_y, "%d != %d\n", tm.tmAscent, tm_orig->tmAscent * scale_y); ok(tm.tmDescent == tm_orig->tmDescent * scale_y, "%d != %d\n", tm.tmDescent, tm_orig->tmDescent * scale_y); ok(tm.tmAveCharWidth == tm_orig->tmAveCharWidth * scale_x, "%d != %d\n", tm.tmAveCharWidth, tm_orig->tmAveCharWidth * scale_x); + ok(tm.tmMaxCharWidth == tm_orig->tmMaxCharWidth * scale_x, "%d != %d\n", tm.tmAveCharWidth, tm_orig->tmMaxCharWidth * scale_x); + + ok(lf.lfHeight == tm.tmHeight, "lf %d != tm %d\n", lf.lfHeight, tm.tmHeight); + if (lf.lfWidth) + ok(lf.lfWidth == tm.tmAveCharWidth, "lf %d != tm %d\n", lf.lfWidth, tm.tmAveCharWidth); GetTextExtentPoint32A(hdc, test_str, test_str_len, &size); ok(size.cx == size_orig->cx * scale_x, "%d != %d\n", size.cx, size_orig->cx * scale_x); ok(size.cy == size_orig->cy * scale_y, "%d != %d\n", size.cy, size_orig->cy * scale_y); - GetCharWidthA(hdc, 'A', 'A', &width); + GetCharWidthA(hdc, 'A', 'A', &width_of_A); - ok(width == width_orig * scale_x, "%d != %d\n", width, width_orig * scale_x); + ok(width_of_A == width_of_A_orig * scale_x, "%d != %d\n", width_of_A, width_of_A_orig * scale_x); SelectObject(hdc, old_hfont); } -/* see whether GDI scales bitmap font metrics */ +/* Test how GDI scales bitmap font metrics */ static void test_bitmap_font(void) { static const char test_str[11] = "Test String"; @@ -246,7 +254,6 @@ todo_wine bitmap_lf.lfHeight = height_orig * 3; bitmap_lf.lfWidth = 0; hfont = create_font("3x3", &bitmap_lf); - todo_wine { test_font_metrics(hdc, hfont, test_str, sizeof(test_str), &tm_orig, &size_orig, width_orig, 3, 3);

1 0

Dmitry Timoshkov : comdlg32: If lpstrFile points to a valid string use it as a default value for edit control .
by Alexandre Julliard 08 Jan '08

08 Jan '08

Module: wine Branch: master Commit: 77c0fad57207dd38864eaa8a54ae0571f37e5b20 URL: http://source.winehq.org/git/wine.git/?a=commit;h=77c0fad57207dd38864eaa8a5… Author: Dmitry Timoshkov <dmitry(a)codeweavers.com> Date: Tue Jan 8 16:43:14 2008 +0800 comdlg32: If lpstrFile points to a valid string use it as a default value for edit control. --- dlls/comdlg32/filedlg31.c | 85 ++++++++++++++++++++++++-------------------- 1 files changed, 46 insertions(+), 39 deletions(-) diff --git a/dlls/comdlg32/filedlg31.c b/dlls/comdlg32/filedlg31.c index 5b76d8e..6e8cdcb 100644 --- a/dlls/comdlg32/filedlg31.c +++ b/dlls/comdlg32/filedlg31.c @@ -113,9 +113,35 @@ BOOL FD31_CallWindowProc(const FD31_DATA *lfs, UINT wMsg, WPARAM wParam, } /*********************************************************************** + * FD31_GetFileType [internal] + */ +static LPCWSTR FD31_GetFileType(LPCWSTR cfptr, LPCWSTR fptr, const WORD index) +{ + int n, i; + i = 0; + if (cfptr) + for ( ;(n = lstrlenW(cfptr)) != 0; i++) + { + cfptr += n + 1; + if (i == index) + return cfptr; + cfptr += lstrlenW(cfptr) + 1; + } + if (fptr) + for ( ;(n = lstrlenW(fptr)) != 0; i++) + { + fptr += n + 1; + if (i == index) + return fptr; + fptr += lstrlenW(fptr) + 1; + } + return FILE_star; /* FIXME */ +} + +/*********************************************************************** * FD31_ScanDir [internal] */ -static BOOL FD31_ScanDir(HWND hWnd, LPCWSTR newPath) +static BOOL FD31_ScanDir(const OPENFILENAMEW *ofn, HWND hWnd, LPCWSTR newPath) { WCHAR buffer[BUFFILE]; HWND hdlg, hdlgDir; @@ -125,10 +151,10 @@ static BOOL FD31_ScanDir(HWND hWnd, LPCWSTR newPath) TRACE("Trying to change to %s\n", debugstr_w(newPath)); if ( newPath[0] && !SetCurrentDirectoryW( newPath )) return FALSE; - lstrcpynW(buffer, newPath, sizeof(buffer)/sizeof(WCHAR)); /* get the list of spec files */ - GetDlgItemTextW(hWnd, edt1, buffer, sizeof(buffer)/sizeof(WCHAR)); + lstrcpynW(buffer, FD31_GetFileType(ofn->lpstrCustomFilter, + ofn->lpstrFilter, ofn->nFilterIndex - 1), BUFFILE); hCursorWait = LoadCursorA(0, (LPSTR)IDC_WAIT); oldCursor = SetCursor(hCursorWait); @@ -162,33 +188,6 @@ static BOOL FD31_ScanDir(HWND hWnd, LPCWSTR newPath) } /*********************************************************************** - * FD31_GetFileType [internal] - */ - -static LPCWSTR FD31_GetFileType(LPCWSTR cfptr, LPCWSTR fptr, const WORD index) -{ - int n, i; - i = 0; - if (cfptr) - for ( ;(n = lstrlenW(cfptr)) != 0; i++) - { - cfptr += n + 1; - if (i == index) - return cfptr; - cfptr += lstrlenW(cfptr) + 1; - } - if (fptr) - for ( ;(n = lstrlenW(fptr)) != 0; i++) - { - fptr += n + 1; - if (i == index) - return fptr; - fptr += lstrlenW(fptr) + 1; - } - return FILE_star; /* FIXME */ -} - -/*********************************************************************** * FD31_WMDrawItem [internal] */ LONG FD31_WMDrawItem(HWND hWnd, WPARAM wParam, LPARAM lParam, @@ -374,7 +373,7 @@ static LRESULT FD31_DirListDblClick( const FD31_DATA *lfs ) } strcatW(tmpstr, FILE_bslash); - FD31_ScanDir(hWnd, tmpstr); + FD31_ScanDir(lfs->ofnW, hWnd, tmpstr); /* notify the app */ if (lfs->hook) { @@ -449,7 +448,7 @@ static LRESULT FD31_TestPath( const FD31_DATA *lfs, LPWSTR path ) TRACE("path=%s, tmpstr2=%s\n", debugstr_w(path), debugstr_w(tmpstr2)); SetDlgItemTextW( hWnd, edt1, tmpstr2 ); - FD31_ScanDir(hWnd, path); + FD31_ScanDir(lfs->ofnW, hWnd, path); return (lfs->ofnW->Flags & OFN_NOVALIDATE) ? TRUE : FALSE; } @@ -461,7 +460,7 @@ static LRESULT FD31_TestPath( const FD31_DATA *lfs, LPWSTR path ) strcatW(path, FILE_bslash); /* if ScanDir succeeds, we have changed the directory */ - if (FD31_ScanDir(hWnd, path)) + if (FD31_ScanDir(lfs->ofnW, hWnd, path)) return FALSE; /* and path is not a valid file name */ /* if not, this must be a filename */ @@ -476,7 +475,7 @@ static LRESULT FD31_TestPath( const FD31_DATA *lfs, LPWSTR path ) lstrcpynW(tmpstr2, pBeginFileName + 1, sizeof(tmpstr2)/sizeof(WCHAR) ); /* Should we MessageBox() if this fails? */ - if (!FD31_ScanDir(hWnd, path)) + if (!FD31_ScanDir(lfs->ofnW, hWnd, path)) { return FALSE; } @@ -870,11 +869,19 @@ LONG FD31_WMInitDialog(HWND hWnd, WPARAM wParam, LPARAM lParam) if (ofn->nFilterIndex == 0 && ofn->lpstrCustomFilter == NULL) ofn->nFilterIndex = 1; SendDlgItemMessageW(hWnd, cmb1, CB_SETCURSEL, ofn->nFilterIndex - 1, 0); - lstrcpynW(tmpstr, FD31_GetFileType(ofn->lpstrCustomFilter, + if (ofn->lpstrFile && ofn->lpstrFile[0]) + { + TRACE( "SetText of edt1 to %s\n", debugstr_w(ofn->lpstrFile) ); + SetDlgItemTextW( hWnd, edt1, ofn->lpstrFile ); + } + else + { + lstrcpynW(tmpstr, FD31_GetFileType(ofn->lpstrCustomFilter, ofn->lpstrFilter, ofn->nFilterIndex - 1),BUFFILE); - TRACE("nFilterIndex = %d, SetText of edt1 to %s\n", + TRACE("nFilterIndex = %d, SetText of edt1 to %s\n", ofn->nFilterIndex, debugstr_w(tmpstr)); - SetDlgItemTextW( hWnd, edt1, tmpstr ); + SetDlgItemTextW( hWnd, edt1, tmpstr ); + } /* get drive list */ *tmpstr = 0; DlgDirListComboBoxW(hWnd, tmpstr, cmb2, 0, DDL_DRIVES | DDL_EXCLUSIVE); @@ -895,9 +902,9 @@ LONG FD31_WMInitDialog(HWND hWnd, WPARAM wParam, LPARAM lParam) } else *tmpstr = 0; - if (!FD31_ScanDir(hWnd, tmpstr)) { + if (!FD31_ScanDir(ofn, hWnd, tmpstr)) { *tmpstr = 0; - if (!FD31_ScanDir(hWnd, tmpstr)) + if (!FD31_ScanDir(ofn, hWnd, tmpstr)) WARN("Couldn't read initial directory %s!\n", debugstr_w(tmpstr)); } /* select current drive in combo 2, omit missing drives */

1 0

Paul Vriens : advapi32/tests: Don't crash on win98.
by Alexandre Julliard 08 Jan '08

08 Jan '08

Module: wine Branch: master Commit: d2e0786eb26e9dc8e1f9460ad02148bb7024fca8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d2e0786eb26e9dc8e1f9460ad… Author: Paul Vriens <paul.vriens.wine(a)gmail.com> Date: Tue Jan 8 10:18:17 2008 +0100 advapi32/tests: Don't crash on win98. --- dlls/advapi32/tests/security.c | 23 +++++++++++++++++++++-- 1 files changed, 21 insertions(+), 2 deletions(-) diff --git a/dlls/advapi32/tests/security.c b/dlls/advapi32/tests/security.c index e9f4795..217d89c 100644 --- a/dlls/advapi32/tests/security.c +++ b/dlls/advapi32/tests/security.c @@ -1627,11 +1627,18 @@ static void test_security_descriptor(void) SECURITY_DESCRIPTOR sd; char buf[8192]; DWORD size; - BOOL isDefault, isPresent; + BOOL isDefault, isPresent, ret; PACL pacl; PSID psid; - InitializeSecurityDescriptor(&sd, SECURITY_DESCRIPTOR_REVISION); + SetLastError(0xdeadbeef); + ret = InitializeSecurityDescriptor(&sd, SECURITY_DESCRIPTOR_REVISION); + if (ret && GetLastError() == ERROR_CALL_NOT_IMPLEMENTED) + { + skip("InitializeSecurityDescriptor is not implemented\n"); + return; + } + ok(GetSecurityDescriptorOwner(&sd, &psid, &isDefault), "GetSecurityDescriptorOwner failed\n"); expect_eq(psid, NULL, PSID, "%p"); expect_eq(isDefault, FALSE, BOOL, "%d"); @@ -2253,6 +2260,12 @@ static void test_PrivateObjectSecurity(void) ULONG len; PSECURITY_DESCRIPTOR buf; + if (!pConvertStringSecurityDescriptorToSecurityDescriptorA) + { + skip("ConvertStringSecurityDescriptorToSecurityDescriptor is not available\n"); + return; + } + ok(pConvertStringSecurityDescriptorToSecurityDescriptorA( "O:SY" "G:S-1-5-21-93476-23408-4576" @@ -2308,6 +2321,12 @@ static void test_acls(void) SetLastError(0xdeadbeef); ret = InitializeAcl(pAcl, sizeof(ACL) - 1, ACL_REVISION); + if (!ret && GetLastError() == ERROR_CALL_NOT_IMPLEMENTED) + { + skip("InitializeAcl is not implemented\n"); + return; + } + ok(!ret && GetLastError() == ERROR_INSUFFICIENT_BUFFER, "InitializeAcl with too small a buffer should have failed with ERROR_INSUFFICIENT_BUFFER instead of %d\n", GetLastError()); SetLastError(0xdeadbeef);

1 0

Andrey Esin : wordpad: Russian translation.
by Alexandre Julliard 08 Jan '08

08 Jan '08

Module: wine Branch: master Commit: fd78ab799b1554f3ce6528122d254b6c741d4cc3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=fd78ab799b1554f3ce6528122… Author: Andrey Esin <andrey(a)esin.name> Date: Tue Jan 8 00:26:32 2008 +0300 wordpad: Russian translation. --- programs/wordpad/Ru.rc | 158 ++++++++++++++++++++++++------------------------ 1 files changed, 79 insertions(+), 79 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=fd78ab799b1554f3ce652…

1 0

Andrey Esin : shell32: Fixed typo.
by Alexandre Julliard 08 Jan '08

08 Jan '08

Module: wine Branch: master Commit: 2adba0d7cd232704d1e369aae86ae55aac0172df URL: http://source.winehq.org/git/wine.git/?a=commit;h=2adba0d7cd232704d1e369aae… Author: Andrey Esin <andrey(a)esin.name> Date: Mon Jan 7 19:21:13 2008 +0300 shell32: Fixed typo. --- dlls/shell32/shell32_Ru.rc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/shell32/shell32_Ru.rc b/dlls/shell32/shell32_Ru.rc index 7bc7848..411c510 100644 --- a/dlls/shell32/shell32_Ru.rc +++ b/dlls/shell32/shell32_Ru.rc @@ -84,7 +84,7 @@ BEGIN MENUITEM "&��", FCIDM_SHVIEW_COPY MENUITEM SEPARATOR MENUITEM "�� &��", FCIDM_SHVIEW_CREATELINK - MENUITEM "&��", FCIDM_SHVIEW_DELETE + MENUITEM "&��", FCIDM_SHVIEW_DELETE MENUITEM "��&��", FCIDM_SHVIEW_RENAME MENUITEM SEPARATOR MENUITEM "��&��", FCIDM_SHVIEW_PROPERTIES

1 0