February 2008 - Wine-commits

James Hawkins : msi: Only convert output strings if the call succeeded.
by Alexandre Julliard 05 Feb '08

05 Feb '08

Module: wine Branch: master Commit: 5d46eeac75d6f90bd39180671c1b9865a610af5b URL: http://source.winehq.org/git/wine.git/?a=commit;h=5d46eeac75d6f90bd39180671… Author: James Hawkins <truiken(a)gmail.com> Date: Mon Feb 4 11:33:20 2008 -0600 msi: Only convert output strings if the call succeeded. --- dlls/msi/msi.c | 4 +- dlls/msi/tests/msi.c | 60 ++++++++++++++++++++------------------------------ 2 files changed, 26 insertions(+), 38 deletions(-) diff --git a/dlls/msi/msi.c b/dlls/msi/msi.c index 70a9c98..c1478b3 100644 --- a/dlls/msi/msi.c +++ b/dlls/msi/msi.c @@ -1543,10 +1543,10 @@ UINT WINAPI MsiGetFileVersionA(LPCSTR szFilePath, LPSTR lpVersionBuf, ret = MsiGetFileVersionW(szwFilePath, lpwVersionBuff, pcchVersionBuf, lpwLangBuff, pcchLangBuf); - if( lpwVersionBuff ) + if( (ret == ERROR_SUCCESS || ret == ERROR_MORE_DATA) && lpwVersionBuff ) WideCharToMultiByte(CP_ACP, 0, lpwVersionBuff, -1, lpVersionBuf, *pcchVersionBuf, NULL, NULL); - if( lpwLangBuff ) + if( (ret == ERROR_SUCCESS || ret == ERROR_MORE_DATA) && lpwLangBuff ) WideCharToMultiByte(CP_ACP, 0, lpwLangBuff, -1, lpLangBuf, *pcchLangBuf, NULL, NULL); diff --git a/dlls/msi/tests/msi.c b/dlls/msi/tests/msi.c index ca39249..57fe405 100644 --- a/dlls/msi/tests/msi.c +++ b/dlls/msi/tests/msi.c @@ -1834,15 +1834,12 @@ static void test_MsiGetFileVersion(void) r = MsiGetFileVersionA(NULL, version, &versz, lang, &langsz); ok(r == ERROR_INVALID_PARAMETER, "Expected ERROR_INVALID_PARAMETER, got %d\n", r); + ok(!lstrcmpA(version, "version"), + "Expected version to be unchanged, got %s\n", version); ok(versz == MAX_PATH, "Expected %d, got %d\n", MAX_PATH, versz); + ok(!lstrcmpA(lang, "lang"), + "Expected lang to be unchanged, got %s\n", lang); ok(langsz == MAX_PATH, "Expected %d, got %d\n", MAX_PATH, langsz); - todo_wine - { - ok(!lstrcmpA(version, "version"), - "Expected version to be unchanged, got %s\n", version); - ok(!lstrcmpA(lang, "lang"), - "Expected lang to be unchanged, got %s\n", lang); - } /* empty szFilePath */ versz = MAX_PATH; @@ -1850,16 +1847,16 @@ static void test_MsiGetFileVersion(void) lstrcpyA(version, "version"); lstrcpyA(lang, "lang"); r = MsiGetFileVersionA("", version, &versz, lang, &langsz); + ok(!lstrcmpA(version, "version"), + "Expected version to be unchanged, got %s\n", version); ok(versz == MAX_PATH, "Expected %d, got %d\n", MAX_PATH, versz); + ok(!lstrcmpA(lang, "lang"), + "Expected lang to be unchanged, got %s\n", lang); ok(langsz == MAX_PATH, "Expected %d, got %d\n", MAX_PATH, langsz); todo_wine { ok(r == ERROR_FILE_NOT_FOUND, "Expected ERROR_FILE_NOT_FOUND, got %d\n", r); - ok(!lstrcmpA(version, "version"), - "Expected version to be unchanged, got %s\n", version); - ok(!lstrcmpA(lang, "lang"), - "Expected lang to be unchanged, got %s\n", lang); } /* nonexistent szFilePath */ @@ -1870,15 +1867,12 @@ static void test_MsiGetFileVersion(void) r = MsiGetFileVersionA("nonexistent", version, &versz, lang, &langsz); ok(r == ERROR_FILE_NOT_FOUND, "Expected ERROR_FILE_NOT_FOUND, got %d\n", r); + ok(!lstrcmpA(version, "version"), + "Expected version to be unchanged, got %s\n", version); ok(versz == MAX_PATH, "Expected %d, got %d\n", MAX_PATH, versz); + ok(!lstrcmpA(lang, "lang"), + "Expected lang to be unchanged, got %s\n", lang); ok(langsz == MAX_PATH, "Expected %d, got %d\n", MAX_PATH, langsz); - todo_wine - { - ok(!lstrcmpA(version, "version"), - "Expected version to be unchanged, got %s\n", version); - ok(!lstrcmpA(lang, "lang"), - "Expected lang to be unchanged, got %s\n", lang); - } /* nonexistent szFilePath, valid lpVersionBuf, NULL pcchVersionBuf */ versz = MAX_PATH; @@ -1889,13 +1883,13 @@ static void test_MsiGetFileVersion(void) ok(!lstrcmpA(version, "version"), "Expected version to be unchanged, got %s\n", version); ok(versz == MAX_PATH, "Expected %d, got %d\n", MAX_PATH, versz); + ok(!lstrcmpA(lang, "lang"), + "Expected lang to be unchanged, got %s\n", lang); ok(langsz == MAX_PATH, "Expected %d, got %d\n", MAX_PATH, langsz); todo_wine { ok(r == ERROR_INVALID_PARAMETER, "Expected ERROR_INVALID_PARAMETER, got %d\n", r); - ok(!lstrcmpA(lang, "lang"), - "Expected lang to be unchanged, got %s\n", lang); } /* nonexistent szFilePath, valid lpLangBuf, NULL pcchLangBuf */ @@ -1904,6 +1898,8 @@ static void test_MsiGetFileVersion(void) lstrcpyA(version, "version"); lstrcpyA(lang, "lang"); r = MsiGetFileVersionA("nonexistent", version, &versz, lang, NULL); + ok(!lstrcmpA(version, "version"), + "Expected version to be unchanged, got %s\n", version); ok(versz == MAX_PATH, "Expected %d, got %d\n", MAX_PATH, versz); ok(!lstrcmpA(lang, "lang"), "Expected lang to be unchanged, got %s\n", lang); @@ -1912,8 +1908,6 @@ static void test_MsiGetFileVersion(void) { ok(r == ERROR_INVALID_PARAMETER, "Expected ERROR_INVALID_PARAMETER, got %d\n", r); - ok(!lstrcmpA(version, "version"), - "Expected version to be unchanged, got %s\n", version); } /* nonexistent szFilePath, valid lpVersionBuf, pcchVersionBuf is zero */ @@ -1927,12 +1921,9 @@ static void test_MsiGetFileVersion(void) ok(!lstrcmpA(version, "version"), "Expected version to be unchanged, got %s\n", version); ok(versz == 0, "Expected 0, got %d\n", versz); + ok(!lstrcmpA(lang, "lang"), + "Expected lang to be unchanged, got %s\n", lang); ok(langsz == MAX_PATH, "Expected %d, got %d\n", MAX_PATH, langsz); - todo_wine - { - ok(!lstrcmpA(lang, "lang"), - "Expected lang to be unchanged, got %s\n", lang); - } /* nonexistent szFilePath, valid lpLangBuf, pcchLangBuf is zero */ versz = MAX_PATH; @@ -1942,15 +1933,12 @@ static void test_MsiGetFileVersion(void) r = MsiGetFileVersionA("nonexistent", version, &versz, lang, &langsz); ok(r == ERROR_FILE_NOT_FOUND, "Expected ERROR_FILE_NOT_FOUND, got %d\n", r); + ok(!lstrcmpA(version, "version"), + "Expected version to be unchanged, got %s\n", version); ok(versz == MAX_PATH, "Expected %d, got %d\n", MAX_PATH, versz); ok(!lstrcmpA(lang, "lang"), "Expected lang to be unchanged, got %s\n", lang); ok(langsz == 0, "Expected 0, got %d\n", langsz); - todo_wine - { - ok(!lstrcmpA(version, "version"), - "Expected version to be unchanged, got %s\n", version); - } /* nonexistent szFilePath, rest NULL */ r = MsiGetFileVersionA("nonexistent", NULL, NULL, NULL, NULL); @@ -1966,15 +1954,15 @@ static void test_MsiGetFileVersion(void) lstrcpyA(lang, "lang"); r = MsiGetFileVersionA("ver.txt", version, &versz, lang, &langsz); ok(versz == MAX_PATH, "Expected %d, got %d\n", MAX_PATH, versz); + ok(!lstrcmpA(version, "version"), + "Expected version to be unchanged, got %s\n", version); ok(langsz == MAX_PATH, "Expected %d, got %d\n", MAX_PATH, langsz); + ok(!lstrcmpA(lang, "lang"), + "Expected lang to be unchanged, got %s\n", lang); todo_wine { ok(r == ERROR_FILE_INVALID, "Expected ERROR_FILE_INVALID, got %d\n", r); - ok(!lstrcmpA(version, "version"), - "Expected version to be unchanged, got %s\n", version); - ok(!lstrcmpA(lang, "lang"), - "Expected lang to be unchanged, got %s\n", lang); } DeleteFileA("ver.txt");

1 0

James Hawkins : msi: Implement the MSIMODIFY_ASSIGN action of MsiViewModify for the streams table .
by Alexandre Julliard 05 Feb '08

05 Feb '08

Module: wine Branch: master Commit: 146e34e662b299b0644ba4a3af0b58c65b5e61ac URL: http://source.winehq.org/git/wine.git/?a=commit;h=146e34e662b299b0644ba4a3a… Author: James Hawkins <truiken(a)gmail.com> Date: Mon Feb 4 11:28:36 2008 -0600 msi: Implement the MSIMODIFY_ASSIGN action of MsiViewModify for the streams table. --- dlls/msi/streams.c | 89 +++++++++++++++++++++++++++++++++++++++++++--------- 1 files changed, 74 insertions(+), 15 deletions(-) diff --git a/dlls/msi/streams.c b/dlls/msi/streams.c index 9828b7f..9950270 100644 --- a/dlls/msi/streams.c +++ b/dlls/msi/streams.c @@ -54,9 +54,9 @@ typedef struct tagMSISTREAMSVIEW UINT row_size; } MSISTREAMSVIEW; -static BOOL add_stream_to_table(MSISTREAMSVIEW *sv, STREAM *stream, int index) +static BOOL streams_set_table_size(MSISTREAMSVIEW *sv, int size) { - if (index >= sv->max_streams) + if (size >= sv->max_streams) { sv->max_streams *= 2; sv->streams = msi_realloc(sv->streams, sv->max_streams * sizeof(STREAM *)); @@ -64,7 +64,6 @@ static BOOL add_stream_to_table(MSISTREAMSVIEW *sv, STREAM *stream, int index) return FALSE; } - sv->streams[index] = stream; return TRUE; } @@ -140,12 +139,6 @@ static UINT STREAMS_get_row( struct tagMSIVIEW *view, UINT row, MSIRECORD **rec static UINT STREAMS_set_row(struct tagMSIVIEW *view, UINT row, MSIRECORD *rec, UINT mask) { - FIXME("(%p, %d, %p, %d): stub!\n", view, row, rec, mask); - return ERROR_SUCCESS; -} - -static UINT STREAMS_insert_row(struct tagMSIVIEW *view, MSIRECORD *rec, BOOL temporary) -{ MSISTREAMSVIEW *sv = (MSISTREAMSVIEW *)view; STREAM *stream; IStream *stm; @@ -156,7 +149,10 @@ static UINT STREAMS_insert_row(struct tagMSIVIEW *view, MSIRECORD *rec, BOOL tem ULONG count; UINT r = ERROR_FUNCTION_FAILED; - TRACE("(%p, %p, %d)\n", view, rec, temporary); + TRACE("(%p, %p)\n", view, rec); + + if (row > sv->num_rows) + return ERROR_FUNCTION_FAILED; r = MSI_RecordGetIStream(rec, 2, &stm); if (r != ERROR_SUCCESS) @@ -201,8 +197,7 @@ static UINT STREAMS_insert_row(struct tagMSIVIEW *view, MSIRECORD *rec, BOOL tem IStorage_OpenStream(sv->db->storage, name, 0, STGM_READ | STGM_SHARE_EXCLUSIVE, 0, &stream->stream); - if (!add_stream_to_table(sv, stream, sv->num_rows++)) - goto done; + sv->streams[row] = stream; done: msi_free(name); @@ -213,6 +208,16 @@ done: return r; } +static UINT STREAMS_insert_row(struct tagMSIVIEW *view, MSIRECORD *rec, BOOL temporary) +{ + MSISTREAMSVIEW *sv = (MSISTREAMSVIEW *)view; + + if (!streams_set_table_size(sv, ++sv->num_rows)) + return ERROR_FUNCTION_FAILED; + + return STREAMS_set_row(view, sv->num_rows - 1, rec, 0); +} + static UINT STREAMS_delete_row(struct tagMSIVIEW *view, UINT row) { FIXME("(%p %d): stub!\n", view, row); @@ -278,6 +283,52 @@ static UINT STREAMS_get_column_info(struct tagMSIVIEW *view, return ERROR_SUCCESS; } +static UINT streams_find_row(MSISTREAMSVIEW *sv, MSIRECORD *rec, UINT *row) +{ + LPCWSTR str; + UINT i, id, data; + + str = MSI_RecordGetString(rec, 1); + msi_string2idW(sv->db->strings, str, &id); + + for (i = 0; i < sv->num_rows; i++) + { + STREAMS_fetch_int(&sv->view, i, 1, &data); + + if (data == id) + { + *row = i; + return ERROR_SUCCESS; + } + } + + return ERROR_FUNCTION_FAILED; +} + +static UINT streams_modify_update(struct tagMSIVIEW *view, MSIRECORD *rec) +{ + MSISTREAMSVIEW *sv = (MSISTREAMSVIEW *)view; + UINT r, row; + + r = streams_find_row(sv, rec, &row); + if (r != ERROR_SUCCESS) + return ERROR_FUNCTION_FAILED; + + return STREAMS_set_row(view, row, rec, 0); +} + +static UINT streams_modify_assign(struct tagMSIVIEW *view, MSIRECORD *rec) +{ + MSISTREAMSVIEW *sv = (MSISTREAMSVIEW *)view; + UINT r, row; + + r = streams_find_row(sv, rec, &row); + if (r == ERROR_SUCCESS) + return streams_modify_update(view, rec); + + return STREAMS_insert_row(view, rec, FALSE); +} + static UINT STREAMS_modify(struct tagMSIVIEW *view, MSIMODIFY eModifyMode, MSIRECORD *rec, UINT row) { UINT r; @@ -286,15 +337,21 @@ static UINT STREAMS_modify(struct tagMSIVIEW *view, MSIMODIFY eModifyMode, MSIRE switch (eModifyMode) { + case MSIMODIFY_ASSIGN: + r = streams_modify_assign(view, rec); + break; + case MSIMODIFY_INSERT: r = STREAMS_insert_row(view, rec, FALSE); break; + case MSIMODIFY_UPDATE: + r = streams_modify_update(view, rec); + break; + case MSIMODIFY_VALIDATE_NEW: case MSIMODIFY_INSERT_TEMPORARY: - case MSIMODIFY_UPDATE: case MSIMODIFY_REFRESH: - case MSIMODIFY_ASSIGN: case MSIMODIFY_REPLACE: case MSIMODIFY_MERGE: case MSIMODIFY_DELETE: @@ -425,11 +482,13 @@ static UINT add_streams_to_table(MSISTREAMSVIEW *sv) STGM_READ | STGM_SHARE_EXCLUSIVE, 0, &stream->stream); CoTaskMemFree(stat.pwcsName); - if (!add_stream_to_table(sv, stream, count++)) + if (!streams_set_table_size(sv, ++count)) { count = -1; break; } + + sv->streams[count - 1] = stream; } IEnumSTATSTG_Release(stgenum);

1 0

James Hawkins : msi: Add tests for using single quotes in an INSERT query.
by Alexandre Julliard 05 Feb '08

05 Feb '08

Module: wine Branch: master Commit: 56574c7c6e3c6674d4c821919592c4c9de206aa5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=56574c7c6e3c6674d4c821919… Author: James Hawkins <truiken(a)gmail.com> Date: Mon Feb 4 11:26:58 2008 -0600 msi: Add tests for using single quotes in an INSERT query. --- dlls/msi/tests/db.c | 129 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 129 insertions(+), 0 deletions(-) diff --git a/dlls/msi/tests/db.c b/dlls/msi/tests/db.c index 85b65d7..e40e867 100644 --- a/dlls/msi/tests/db.c +++ b/dlls/msi/tests/db.c @@ -5053,6 +5053,134 @@ static void test_deleterow() DeleteFileA(msifile); } +static const CHAR import_dat[] = "A\n" + "s72\n" + "Table\tA\n" + "This is a new 'string' ok\n"; + +static void test_quotes(void) +{ + MSIHANDLE hdb, hview, hrec; + const char *query; + char buf[MAX_PATH]; + UINT r; + DWORD size; + + DeleteFile(msifile); + + r = MsiOpenDatabase(msifile, MSIDBOPEN_CREATE, &hdb); + ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", r); + + query = "CREATE TABLE `Table` ( `A` CHAR(72) NOT NULL PRIMARY KEY `A` )"; + r = run_query(hdb, 0, query); + ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", r); + + query = "INSERT INTO `Table` ( `A` ) VALUES ( 'This is a 'string' ok' )"; + r = run_query(hdb, 0, query); + ok(r == ERROR_BAD_QUERY_SYNTAX, + "Expected ERROR_BAD_QUERY_SYNTAX, got %d\n", r); + + query = "INSERT INTO `Table` ( `A` ) VALUES ( \"This is a 'string' ok\" )"; + r = run_query(hdb, 0, query); + ok(r == ERROR_BAD_QUERY_SYNTAX, + "Expected ERROR_BAD_QUERY_SYNTAX, got %d\n", r); + + query = "INSERT INTO `Table` ( `A` ) VALUES ( \"test\" )"; + r = run_query(hdb, 0, query); + ok(r == ERROR_BAD_QUERY_SYNTAX, + "Expected ERROR_BAD_QUERY_SYNTAX, got %d\n", r); + + query = "INSERT INTO `Table` ( `A` ) VALUES ( 'This is a ''string'' ok' )"; + r = run_query(hdb, 0, query); + todo_wine + { + ok(r == ERROR_BAD_QUERY_SYNTAX, "Expected ERROR_BAD_QUERY_SYNTAX, got %d\n", r); + } + + query = "INSERT INTO `Table` ( `A` ) VALUES ( 'This is a '''string''' ok' )"; + r = run_query(hdb, 0, query); + ok(r == ERROR_BAD_QUERY_SYNTAX, "Expected ERROR_BAD_QUERY_SYNTAX, got %d\n", r); + + query = "INSERT INTO `Table` ( `A` ) VALUES ( 'This is a \'string\' ok' )"; + r = run_query(hdb, 0, query); + ok(r == ERROR_BAD_QUERY_SYNTAX, "Expected ERROR_BAD_QUERY_SYNTAX, got %d\n", r); + + query = "INSERT INTO `Table` ( `A` ) VALUES ( 'This is a \"string\" ok' )"; + r = run_query(hdb, 0, query); + ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", r); + + query = "SELECT * FROM `Table`"; + r = MsiDatabaseOpenView(hdb, query, &hview); + ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", r); + + r = MsiViewExecute(hview, 0); + ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", r); + + r = MsiViewFetch(hview, &hrec); + ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", r); + + size = MAX_PATH; + r = MsiRecordGetString(hrec, 1, buf, &size); + ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", r); + todo_wine + { + ok(!lstrcmp(buf, "This is a \"string\" ok"), + "Expected \"This is a \"string\" ok\", got %s\n", buf); + } + + MsiCloseHandle(hrec); + + r = MsiViewFetch(hview, &hrec); + todo_wine + { + ok(r == ERROR_NO_MORE_ITEMS, "Expected ERROR_NO_MORE_ITEMS, got %d\n", r); + } + + MsiCloseHandle(hview); + + write_file("import.idt", import_dat, (sizeof(import_dat) - 1) * sizeof(char)); + + r = MsiDatabaseImportA(hdb, CURR_DIR, "import.idt"); + todo_wine + { + ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", r); + } + + DeleteFileA("import.idt"); + + query = "SELECT * FROM `Table`"; + r = MsiDatabaseOpenView(hdb, query, &hview); + ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", r); + + r = MsiViewExecute(hview, 0); + ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", r); + + r = MsiViewFetch(hview, &hrec); + ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", r); + + size = MAX_PATH; + r = MsiRecordGetString(hrec, 1, buf, &size); + ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", r); + todo_wine + { + ok(!lstrcmp(buf, "This is a new 'string' ok"), + "Expected \"This is a new 'string' ok\", got %s\n", buf); + } + + MsiCloseHandle(hrec); + + r = MsiViewFetch(hview, &hrec); + todo_wine + { + ok(r == ERROR_NO_MORE_ITEMS, "Expected ERROR_NO_MORE_ITEMS, got %d\n", r); + } + + MsiCloseHandle(hview); + + MsiCloseHandle(hdb); + DeleteFileA(msifile); +} + START_TEST(db) { test_msidatabase(); @@ -5084,4 +5212,5 @@ START_TEST(db) test_order(); test_viewmodify_delete_temporary(); test_deleterow(); + test_quotes(); }

1 0

James Hawkins : version: Return ERROR_RESOURCE_DATA_NOT_FOUND if the file does not have version information .
by Alexandre Julliard 05 Feb '08

05 Feb '08

Module: wine Branch: master Commit: 972c61d31146b1e7938a32fd4ed23058ecaa5b1f URL: http://source.winehq.org/git/wine.git/?a=commit;h=972c61d31146b1e7938a32fd4… Author: James Hawkins <truiken(a)gmail.com> Date: Mon Feb 4 11:21:05 2008 -0600 version: Return ERROR_RESOURCE_DATA_NOT_FOUND if the file does not have version information. --- dlls/version/info.c | 4 ++++ dlls/version/tests/info.c | 25 +++++++++++++++++++++++++ 2 files changed, 29 insertions(+), 0 deletions(-) diff --git a/dlls/version/info.c b/dlls/version/info.c index 935d0c1..2be1df7 100644 --- a/dlls/version/info.c +++ b/dlls/version/info.c @@ -252,6 +252,10 @@ static DWORD VERSION_GetFileVersionInfo_PE( LPCWSTR filename, DWORD datasize, LP if(!hModule) { WARN("Could not load %s\n", debugstr_w(filename)); + + if (GetLastError() == ERROR_BAD_EXE_FORMAT) + return 0xFFFFFFFF; + return 0; } hRsrc = FindResourceW(hModule, diff --git a/dlls/version/tests/info.c b/dlls/version/tests/info.c index be1852f..d31797a 100644 --- a/dlls/version/tests/info.c +++ b/dlls/version/tests/info.c @@ -44,6 +44,18 @@ "ERROR_PATH_NOT_FOUND (NT4)/ERROR_FILE_NOT_FOUND (2k3)" \ "expected, got %u\n", GetLastError()); +static void create_file(const CHAR *name) +{ + HANDLE file; + DWORD written; + + file = CreateFileA(name, GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, 0, NULL); + ok(file != INVALID_HANDLE_VALUE, "Failure to open file %s\n", name); + WriteFile(file, name, strlen(name), &written, NULL); + WriteFile(file, "\n", strlen("\n"), &written, NULL); + CloseHandle(file); +} + static void test_info_size(void) { DWORD hdl, retval; char mypath[MAX_PATH] = ""; @@ -153,6 +165,19 @@ static void test_info_size(void) } else trace("skipping GetModuleFileNameA(NULL,..) failed\n"); + + create_file("test.txt"); + + /* no version info */ + SetLastError(0xdeadbeef); + hdl = 0xcafe; + retval = GetFileVersionInfoSizeA("test.txt", &hdl); + ok(retval == 0, "Expected 0, got %d\n", retval); + ok(hdl == 0, "Expected 0, got %d\n", hdl); + ok(GetLastError() == ERROR_RESOURCE_DATA_NOT_FOUND, + "Expected ERROR_RESOURCE_DATA_NOT_FOUND, got %d\n", GetLastError()); + + DeleteFileA("test.txt"); } static void VersionDwordLong2String(DWORDLONG Version, LPSTR lpszVerString)

1 0

James Hawkins : kernel32: Factor out the VerifyVersionInfo tests into their own function.
by Alexandre Julliard 05 Feb '08

05 Feb '08

Module: wine Branch: master Commit: ea41e863ad0a943af15dc8a0ea86f728c8155e6b URL: http://source.winehq.org/git/wine.git/?a=commit;h=ea41e863ad0a943af15dc8a0e… Author: James Hawkins <truiken(a)gmail.com> Date: Mon Feb 4 11:18:52 2008 -0600 kernel32: Factor out the VerifyVersionInfo tests into their own function. --- dlls/kernel32/tests/version.c | 15 +++++++++------ 1 files changed, 9 insertions(+), 6 deletions(-) diff --git a/dlls/kernel32/tests/version.c b/dlls/kernel32/tests/version.c index ac4d814..8aec42a 100644 --- a/dlls/kernel32/tests/version.c +++ b/dlls/kernel32/tests/version.c @@ -89,18 +89,13 @@ static void test_GetVersionEx(void) ok(ret, "Expected GetVersionExA to succeed\n"); ok(GetLastError() == 0xdeadbeef, "Expected 0xdeadbeef, got %d\n", GetLastError()); - } -START_TEST(version) +static void test_VerifyVersionInfo(void) { OSVERSIONINFOEX info = { sizeof(info) }; BOOL ret; - init_function_pointers(); - - test_GetVersionEx(); - if(!pVerifyVersionInfoA || !pVerSetConditionMask) { skip("Needed functions not available\n"); @@ -237,3 +232,11 @@ START_TEST(version) pVerSetConditionMask(0, VER_MAJORVERSION, VER_GREATER_EQUAL)); ok(ret, "VerifyVersionInfoA failed with error %d\n", GetLastError()); } + +START_TEST(version) +{ + init_function_pointers(); + + test_GetVersionEx(); + test_VerifyVersionInfo(); +}

1 0

Reece H. Dunn : comctl32: Proper fix redrawing the trackbar background with themes enabled.
by Alexandre Julliard 05 Feb '08

05 Feb '08

Module: wine Branch: master Commit: af9c736f6bfee1edc18b98297be48417f3178057 URL: http://source.winehq.org/git/wine.git/?a=commit;h=af9c736f6bfee1edc18b98297… Author: Reece H. Dunn <msclrhd(a)hotmail.com> Date: Sun Feb 3 13:53:11 2008 +0000 comctl32: Proper fix redrawing the trackbar background with themes enabled. --- dlls/comctl32/trackbar.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/dlls/comctl32/trackbar.c b/dlls/comctl32/trackbar.c index bbb48c9..56e7cd3 100644 --- a/dlls/comctl32/trackbar.c +++ b/dlls/comctl32/trackbar.c @@ -869,10 +869,7 @@ TRACKBAR_Refresh (TRACKBAR_INFO *infoPtr, HDC hdcDst) if (gcdrf == CDRF_DODEFAULT || notify_customdraw(infoPtr, &nmcd, CDDS_PREERASE) != CDRF_SKIPDEFAULT) { if ((theme = GetWindowTheme (infoPtr->hwndSelf))) { - DrawThemeBackground (theme, hdc, - (GetWindowLongW (infoPtr->hwndSelf, GWL_STYLE) & TBS_VERT) ? - TKP_TRACKVERT : TKP_TRACK, TKS_NORMAL, &rcClient, 0); - DrawThemeParentBackground (infoPtr->hwndSelf, hdc, &rcClient); + DrawThemeParentBackground (infoPtr->hwndSelf, hdc, 0); } else FillRect (hdc, &rcClient, GetSysColorBrush(COLOR_BTNFACE));

1 0

Reece H. Dunn : gdiplus: Fix the bezier arc path test on all Windows platforms.
by Alexandre Julliard 05 Feb '08

05 Feb '08

Module: wine Branch: master Commit: 571a383d7e5cb8251be3cd6cfd85d08e8133fac8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=571a383d7e5cb8251be3cd6cf… Author: Reece H. Dunn <msclrhd(a)hotmail.com> Date: Sun Feb 3 21:13:15 2008 +0000 gdiplus: Fix the bezier arc path test on all Windows platforms. --- dlls/gdiplus/tests/graphicspath.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/gdiplus/tests/graphicspath.c b/dlls/gdiplus/tests/graphicspath.c index b2d5ef9..3860a2e 100644 --- a/dlls/gdiplus/tests/graphicspath.c +++ b/dlls/gdiplus/tests/graphicspath.c @@ -224,7 +224,7 @@ static path_test_t arc_path[] = { {187.9, 716.5, PathPointTypeBezier, 0, 0}, /*34*/ {293.1, 841.8, PathPointTypeBezier, 0, 0}, /*35*/ {450.9, 824.1, PathPointTypeBezier, 0, 0}, /*36*/ - {540.4, 676.9, PathPointTypeBezier, 0, 0} /*37*/ + {540.4, 676.9, PathPointTypeBezier | PathPointTypeCloseSubpath, 0, 1} /*37*/ }; static void test_arc(void)

1 0

Michael Stefaniuc : olecli: Remove duplicated typedefs/enums.
by Alexandre Julliard 05 Feb '08

05 Feb '08

Module: wine Branch: master Commit: 0b5ebcf2fd2d94bf84d076fa7c1f695dd183c155 URL: http://source.winehq.org/git/wine.git/?a=commit;h=0b5ebcf2fd2d94bf84d076fa7… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Fri Feb 1 23:09:18 2008 +0100 olecli: Remove duplicated typedefs/enums. Use a local header file for them. --- dlls/olecli32/olecli.h | 129 +++++++++++++++++++++++++++++++++++++++++++ dlls/olecli32/olecli16.c | 111 +------------------------------------ dlls/olecli32/olecli_main.c | 111 +------------------------------------ 3 files changed, 131 insertions(+), 220 deletions(-) diff --git a/dlls/olecli32/olecli.h b/dlls/olecli32/olecli.h new file mode 100644 index 0000000..8430a7c --- /dev/null +++ b/dlls/olecli32/olecli.h @@ -0,0 +1,129 @@ +/* + * OLECLI library + * + * Copyright 1995 Martin von Loewis + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +typedef enum +{ + OLE_OK, + OLE_WAIT_FOR_RELEASE, + OLE_BUSY, + OLE_ERROR_PROTECT_ONLY, + OLE_ERROR_MEMORY, + OLE_ERROR_STREAM, + OLE_ERROR_STATIC, + OLE_ERROR_BLANK, + OLE_ERROR_DRAW, + OLE_ERROR_METAFILE, + OLE_ERROR_ABORT, + OLE_ERROR_CLIPBOARD, + OLE_ERROR_FORMAT, + OLE_ERROR_OBJECT, + OLE_ERROR_OPTION, + OLE_ERROR_PROTOCOL, + OLE_ERROR_ADDRESS, + OLE_ERROR_NOT_EQUAL, + OLE_ERROR_HANDLE, + OLE_ERROR_GENERIC, + OLE_ERROR_CLASS, + OLE_ERROR_SYNTAX, + OLE_ERROR_DATATYPE, + OLE_ERROR_PALETTE, + OLE_ERROR_NOT_LINK, + OLE_ERROR_NOT_EMPTY, + OLE_ERROR_SIZE, + OLE_ERROR_DRIVE, + OLE_ERROR_NETWORK, + OLE_ERROR_NAME, + OLE_ERROR_TEMPLATE, + OLE_ERROR_NEW, + OLE_ERROR_EDIT, + OLE_ERROR_OPEN, + OLE_ERROR_NOT_OPEN, + OLE_ERROR_LAUNCH, + OLE_ERROR_COMM, + OLE_ERROR_TERMINATE, + OLE_ERROR_COMMAND, + OLE_ERROR_SHOW, + OLE_ERROR_DOVERB, + OLE_ERROR_ADVISE_NATIVE, + OLE_ERROR_ADVISE_PICT, + OLE_ERROR_ADVISE_RENAME, + OLE_ERROR_POKE_NATIVE, + OLE_ERROR_REQUEST_NATIVE, + OLE_ERROR_REQUEST_PICT, + OLE_ERROR_SERVER_BLOCKED, + OLE_ERROR_REGISTRATION, + OLE_ERROR_ALREADY_REGISTERED, + OLE_ERROR_TASK, + OLE_ERROR_OUTOFDATE, + OLE_ERROR_CANT_UPDATE_CLIENT, + OLE_ERROR_UPDATE, + OLE_ERROR_SETDATA_FORMAT, + OLE_ERROR_STATIC_FROM_OTHER_OS, + OLE_WARN_DELETE_DATA = 1000 +} OLESTATUS; + +typedef enum +{ + olerender_none, + olerender_draw, + olerender_format +} OLEOPT_RENDER; + +typedef enum +{ + oleupdate_always, + oleupdate_onsave, + oleupdate_oncall, + oleupdate_onclose +} OLEOPT_UPDATE; + +typedef enum { + OLE_NONE, /* none */ + OLE_DELETE, /* delete object */ + OLE_LNKPASTE, /* link paste */ + OLE_EMBPASTE, /* paste(and update) */ + OLE_SHOW, + OLE_RUN, + OLE_ACTIVATE, + OLE_UPDATE, + OLE_CLOSE, + OLE_RECONNECT, + OLE_SETUPDATEOPTIONS, + OLE_SERVERRUNLAUNCH, /* unlaunch (terminate?) server */ + OLE_LOADFROMSTREAM, /* (auto reconnect) */ + OLE_SETDATA, /* OleSetData */ + OLE_REQUESTDATA, /* OleRequestData */ + OLE_OTHER, + OLE_CREATE, + OLE_CREATEFROMTEMPLATE, + OLE_CREATELINKFROMFILE, + OLE_COPYFROMLNK, + OLE_CREATREFROMFILE, + OLE_CREATEINVISIBLE +} OLE_RELEASE_METHOD; + +typedef LONG LHCLIENTDOC; +typedef struct _OLEOBJECT *_LPOLEOBJECT; +typedef struct _OLECLIENT *LPOLECLIENT; +typedef LONG OLECLIPFORMAT;/* dunno about this type, please change/add */ +typedef OLEOPT_UPDATE *LPOLEOPT_UPDATE; +typedef LPCSTR LPCOLESTR16; + +struct _OLESTREAM; diff --git a/dlls/olecli32/olecli16.c b/dlls/olecli32/olecli16.c index a1da30a..a37254b 100644 --- a/dlls/olecli32/olecli16.c +++ b/dlls/olecli32/olecli16.c @@ -31,120 +31,11 @@ #include "wingdi.h" #include "wownt32.h" #include "objbase.h" +#include "olecli.h" #include "wine/debug.h" WINE_DEFAULT_DEBUG_CHANNEL(ole); -typedef enum -{ - OLE_OK, - OLE_WAIT_FOR_RELEASE, - OLE_BUSY, - OLE_ERROR_PROTECT_ONLY, - OLE_ERROR_MEMORY, - OLE_ERROR_STREAM, - OLE_ERROR_STATIC, - OLE_ERROR_BLANK, - OLE_ERROR_DRAW, - OLE_ERROR_METAFILE, - OLE_ERROR_ABORT, - OLE_ERROR_CLIPBOARD, - OLE_ERROR_FORMAT, - OLE_ERROR_OBJECT, - OLE_ERROR_OPTION, - OLE_ERROR_PROTOCOL, - OLE_ERROR_ADDRESS, - OLE_ERROR_NOT_EQUAL, - OLE_ERROR_HANDLE, - OLE_ERROR_GENERIC, - OLE_ERROR_CLASS, - OLE_ERROR_SYNTAX, - OLE_ERROR_DATATYPE, - OLE_ERROR_PALETTE, - OLE_ERROR_NOT_LINK, - OLE_ERROR_NOT_EMPTY, - OLE_ERROR_SIZE, - OLE_ERROR_DRIVE, - OLE_ERROR_NETWORK, - OLE_ERROR_NAME, - OLE_ERROR_TEMPLATE, - OLE_ERROR_NEW, - OLE_ERROR_EDIT, - OLE_ERROR_OPEN, - OLE_ERROR_NOT_OPEN, - OLE_ERROR_LAUNCH, - OLE_ERROR_COMM, - OLE_ERROR_TERMINATE, - OLE_ERROR_COMMAND, - OLE_ERROR_SHOW, - OLE_ERROR_DOVERB, - OLE_ERROR_ADVISE_NATIVE, - OLE_ERROR_ADVISE_PICT, - OLE_ERROR_ADVISE_RENAME, - OLE_ERROR_POKE_NATIVE, - OLE_ERROR_REQUEST_NATIVE, - OLE_ERROR_REQUEST_PICT, - OLE_ERROR_SERVER_BLOCKED, - OLE_ERROR_REGISTRATION, - OLE_ERROR_ALREADY_REGISTERED, - OLE_ERROR_TASK, - OLE_ERROR_OUTOFDATE, - OLE_ERROR_CANT_UPDATE_CLIENT, - OLE_ERROR_UPDATE, - OLE_ERROR_SETDATA_FORMAT, - OLE_ERROR_STATIC_FROM_OTHER_OS, - OLE_WARN_DELETE_DATA = 1000 -} OLESTATUS; - -typedef enum -{ - olerender_none, - olerender_draw, - olerender_format -} OLEOPT_RENDER; - -typedef enum -{ - oleupdate_always, - oleupdate_onsave, - oleupdate_oncall, - oleupdate_onclose -} OLEOPT_UPDATE; - -typedef enum { - OLE_NONE, /* none */ - OLE_DELETE, /* delete object */ - OLE_LNKPASTE, /* link paste */ - OLE_EMBPASTE, /* paste(and update) */ - OLE_SHOW, - OLE_RUN, - OLE_ACTIVATE, - OLE_UPDATE, - OLE_CLOSE, - OLE_RECONNECT, - OLE_SETUPDATEOPTIONS, - OLE_SERVERRUNLAUNCH, /* unlaunch (terminate?) server */ - OLE_LOADFROMSTREAM, /* (auto reconnect) */ - OLE_SETDATA, /* OleSetData */ - OLE_REQUESTDATA, /* OleRequestData */ - OLE_OTHER, - OLE_CREATE, - OLE_CREATEFROMTEMPLATE, - OLE_CREATELINKFROMFILE, - OLE_COPYFROMLNK, - OLE_CREATREFROMFILE, - OLE_CREATEINVISIBLE -} OLE_RELEASE_METHOD; - -typedef LONG LHCLIENTDOC; -typedef struct _OLEOBJECT *_LPOLEOBJECT; -typedef struct _OLECLIENT *LPOLECLIENT; -typedef LONG OLECLIPFORMAT;/* dunno about this type, please change/add */ -typedef OLEOPT_UPDATE *LPOLEOPT_UPDATE; -typedef LPCSTR LPCOLESTR16; - -struct _OLESTREAM; - typedef struct _OLEOBJECTVTBL16 { void CALLBACK *(*QueryProtocol)(_LPOLEOBJECT,LPCOLESTR16); OLESTATUS (CALLBACK *Release)(_LPOLEOBJECT); diff --git a/dlls/olecli32/olecli_main.c b/dlls/olecli32/olecli_main.c index a36cb72..7abd438 100644 --- a/dlls/olecli32/olecli_main.c +++ b/dlls/olecli32/olecli_main.c @@ -31,120 +31,11 @@ #include "wingdi.h" #include "wownt32.h" #include "objbase.h" +#include "olecli.h" #include "wine/debug.h" WINE_DEFAULT_DEBUG_CHANNEL(ole); -typedef enum -{ - OLE_OK, - OLE_WAIT_FOR_RELEASE, - OLE_BUSY, - OLE_ERROR_PROTECT_ONLY, - OLE_ERROR_MEMORY, - OLE_ERROR_STREAM, - OLE_ERROR_STATIC, - OLE_ERROR_BLANK, - OLE_ERROR_DRAW, - OLE_ERROR_METAFILE, - OLE_ERROR_ABORT, - OLE_ERROR_CLIPBOARD, - OLE_ERROR_FORMAT, - OLE_ERROR_OBJECT, - OLE_ERROR_OPTION, - OLE_ERROR_PROTOCOL, - OLE_ERROR_ADDRESS, - OLE_ERROR_NOT_EQUAL, - OLE_ERROR_HANDLE, - OLE_ERROR_GENERIC, - OLE_ERROR_CLASS, - OLE_ERROR_SYNTAX, - OLE_ERROR_DATATYPE, - OLE_ERROR_PALETTE, - OLE_ERROR_NOT_LINK, - OLE_ERROR_NOT_EMPTY, - OLE_ERROR_SIZE, - OLE_ERROR_DRIVE, - OLE_ERROR_NETWORK, - OLE_ERROR_NAME, - OLE_ERROR_TEMPLATE, - OLE_ERROR_NEW, - OLE_ERROR_EDIT, - OLE_ERROR_OPEN, - OLE_ERROR_NOT_OPEN, - OLE_ERROR_LAUNCH, - OLE_ERROR_COMM, - OLE_ERROR_TERMINATE, - OLE_ERROR_COMMAND, - OLE_ERROR_SHOW, - OLE_ERROR_DOVERB, - OLE_ERROR_ADVISE_NATIVE, - OLE_ERROR_ADVISE_PICT, - OLE_ERROR_ADVISE_RENAME, - OLE_ERROR_POKE_NATIVE, - OLE_ERROR_REQUEST_NATIVE, - OLE_ERROR_REQUEST_PICT, - OLE_ERROR_SERVER_BLOCKED, - OLE_ERROR_REGISTRATION, - OLE_ERROR_ALREADY_REGISTERED, - OLE_ERROR_TASK, - OLE_ERROR_OUTOFDATE, - OLE_ERROR_CANT_UPDATE_CLIENT, - OLE_ERROR_UPDATE, - OLE_ERROR_SETDATA_FORMAT, - OLE_ERROR_STATIC_FROM_OTHER_OS, - OLE_WARN_DELETE_DATA = 1000 -} OLESTATUS; - -typedef enum -{ - olerender_none, - olerender_draw, - olerender_format -} OLEOPT_RENDER; - -typedef enum -{ - oleupdate_always, - oleupdate_onsave, - oleupdate_oncall, - oleupdate_onclose -} OLEOPT_UPDATE; - -typedef enum { - OLE_NONE, /* none */ - OLE_DELETE, /* delete object */ - OLE_LNKPASTE, /* link paste */ - OLE_EMBPASTE, /* paste(and update) */ - OLE_SHOW, - OLE_RUN, - OLE_ACTIVATE, - OLE_UPDATE, - OLE_CLOSE, - OLE_RECONNECT, - OLE_SETUPDATEOPTIONS, - OLE_SERVERRUNLAUNCH, /* unlaunch (terminate?) server */ - OLE_LOADFROMSTREAM, /* (auto reconnect) */ - OLE_SETDATA, /* OleSetData */ - OLE_REQUESTDATA, /* OleRequestData */ - OLE_OTHER, - OLE_CREATE, - OLE_CREATEFROMTEMPLATE, - OLE_CREATELINKFROMFILE, - OLE_COPYFROMLNK, - OLE_CREATREFROMFILE, - OLE_CREATEINVISIBLE -} OLE_RELEASE_METHOD; - -typedef LONG LHCLIENTDOC; -typedef struct _OLEOBJECT *_LPOLEOBJECT; -typedef struct _OLECLIENT *LPOLECLIENT; -typedef LONG OLECLIPFORMAT;/* dunno about this type, please change/add */ -typedef OLEOPT_UPDATE *LPOLEOPT_UPDATE; -typedef LPCSTR LPCOLESTR16; - -struct _OLESTREAM; - typedef struct _OLEOBJECTVTBL { void * (CALLBACK *QueryProtocol)(_LPOLEOBJECT,LPCOLESTR16); OLESTATUS (CALLBACK *Release)(_LPOLEOBJECT);

1 0

Stefan Leichter : advapi32: Fix the failing QueryServiceConfig2 test on platforms win2k3 and vista.
by Alexandre Julliard 05 Feb '08

05 Feb '08

Module: wine Branch: master Commit: f3f64c79396b23ea571be819726ea551e6c5ba4c URL: http://source.winehq.org/git/wine.git/?a=commit;h=f3f64c79396b23ea571be8197… Author: Stefan Leichter <Stefan.Leichter(a)camline.com> Date: Fri Feb 1 22:24:00 2008 +0100 advapi32: Fix the failing QueryServiceConfig2 test on platforms win2k3 and vista. --- dlls/advapi32/tests/service.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/dlls/advapi32/tests/service.c b/dlls/advapi32/tests/service.c index cf5b809..8c71715 100644 --- a/dlls/advapi32/tests/service.c +++ b/dlls/advapi32/tests/service.c @@ -938,7 +938,8 @@ static void test_queryconfig2(void) SetLastError(0xdeadbeef); ret = pQueryServiceConfig2A(svc_handle, SERVICE_CONFIG_DESCRIPTION,NULL,sizeof(SERVICE_DESCRIPTIONA),&needed); ok(!ret, "expected QueryServiceConfig2A to fail\n"); - ok(ERROR_INVALID_ADDRESS == GetLastError(), "expected error ERROR_INVALID_ADDRESS, got %d\n", GetLastError()); + ok((ERROR_INVALID_ADDRESS == GetLastError()) || (ERROR_INSUFFICIENT_BUFFER == GetLastError()), + "expected error ERROR_INVALID_ADDRESS or ERROR_INSUFFICIENT_BUFFER, got %d\n", GetLastError()); SetLastError(0xdeadbeef); ret = pQueryServiceConfig2A(svc_handle, SERVICE_CONFIG_DESCRIPTION,NULL,sizeof(SERVICE_DESCRIPTIONA),NULL);

1 0

Alistair Leslie-Hughes : gdiplus: Add GdipSetPenMode stub.
by Alexandre Julliard 05 Feb '08

05 Feb '08

Module: wine Branch: master Commit: 9f0f97706dc49062f3e2afbca36bcc98f6060667 URL: http://source.winehq.org/git/wine.git/?a=commit;h=9f0f97706dc49062f3e2afbca… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Wed Jan 30 15:46:25 2008 +1100 gdiplus: Add GdipSetPenMode stub. --- dlls/gdiplus/gdiplus.spec | 2 +- dlls/gdiplus/pen.c | 10 ++++++++++ include/gdiplusenums.h | 7 +++++++ 3 files changed, 18 insertions(+), 1 deletions(-) diff --git a/dlls/gdiplus/gdiplus.spec b/dlls/gdiplus/gdiplus.spec index 1b9e427..2421b6a 100644 --- a/dlls/gdiplus/gdiplus.spec +++ b/dlls/gdiplus/gdiplus.spec @@ -575,7 +575,7 @@ @ stdcall GdipSetPenLineCap197819(ptr long long long) @ stdcall GdipSetPenLineJoin(ptr long) @ stdcall GdipSetPenMiterLimit(ptr long) -@ stub GdipSetPenMode +@ stdcall GdipSetPenMode(ptr long) @ stdcall GdipSetPenStartCap(ptr long) @ stub GdipSetPenTransform @ stub GdipSetPenUnit diff --git a/dlls/gdiplus/pen.c b/dlls/gdiplus/pen.c index 92d76d8..97fc99d 100644 --- a/dlls/gdiplus/pen.c +++ b/dlls/gdiplus/pen.c @@ -380,3 +380,13 @@ GpStatus WINGDIPAPI GdipSetPenWidth(GpPen *pen, REAL width) return Ok; } + + +GpStatus WINGDIPAPI GdipSetPenMode(GpPen *pen, GpPenAlignment penAlignment) +{ + if(!pen) return InvalidParameter; + + FIXME("stub (%d)\n", penAlignment); + + return Ok; +} diff --git a/include/gdiplusenums.h b/include/gdiplusenums.h index c625e68..7c97005 100644 --- a/include/gdiplusenums.h +++ b/include/gdiplusenums.h @@ -124,6 +124,12 @@ enum InterpolationMode InterpolationModeHighQualityBicubic }; +enum PenAlignment +{ + PenAlignmentCenter = 0, + PenAlignmentInset = 1 +}; + enum PixelOffsetMode { PixelOffsetModeInvalid = QualityModeInvalid, @@ -279,6 +285,7 @@ typedef enum StringAlignment StringAlignment; typedef enum StringTrimming StringTrimming; typedef enum StringFormatFlags StringFormatFlags; typedef enum HotkeyPrefix HotkeyPrefix; +typedef enum PenAlignment GpPenAlignment; #endif /* end of c typedefs */

1 0