March 2008 - Wine-commits - list.winehq.org

Alistair Leslie-Hughes : msxml3: Corrected double free in test.
by Alexandre Julliard 11 Mar '08

11 Mar '08

Module: wine Branch: master Commit: 17bf0d916439d310471b22ad0ca1e8b5e1afce4d URL: http://source.winehq.org/git/wine.git/?a=commit;h=17bf0d916439d310471b22ad0… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Tue Mar 11 19:33:06 2008 +1100 msxml3: Corrected double free in test. --- dlls/msxml3/tests/domdoc.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c index 5d7fc0c..c4c5b9c 100644 --- a/dlls/msxml3/tests/domdoc.c +++ b/dlls/msxml3/tests/domdoc.c @@ -2,7 +2,7 @@ * XML test * * Copyright 2005 Mike McCormack for CodeWeavers - * Copyright 2007 Alistair Leslie-Hughes + * Copyright 2007-2008 Alistair Leslie-Hughes * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -528,6 +528,7 @@ static void test_domdoc( void ) ok( r == E_INVALIDARG, "returns %08x\n", r ); r = IXMLDOMDocument_createTextNode(doc, str, &nodetext); ok( r == S_OK, "returns %08x\n", r ); + SysFreeString( str ); if(nodetext) { IXMLDOMNamedNodeMap *pAttribs; @@ -696,7 +697,6 @@ static void test_domdoc( void ) IXMLDOMText_Release( nodetext ); } - SysFreeString( str ); /* test Create Comment */ r = IXMLDOMDocument_createComment(doc, NULL, NULL);

1 0

Christopher Berner : user32: Make LoadStringW pass tests.
by Alexandre Julliard 11 Mar '08

11 Mar '08

Module: wine Branch: master Commit: 9978cc9c56f7ec09be2d2a22c2e7fb5d5d1f07be URL: http://source.winehq.org/git/wine.git/?a=commit;h=9978cc9c56f7ec09be2d2a22c… Author: Christopher Berner <raccoonone(a)procyongames.com> Date: Wed Mar 5 12:28:54 2008 -0800 user32: Make LoadStringW pass tests. --- dlls/crypt32/oid.c | 10 +++++----- dlls/hhctrl.ocx/help.c | 9 +++++---- dlls/mpr/wnet.c | 10 ++++++---- dlls/user32/resource.c | 12 +++++++++++- dlls/user32/tests/resource.c | 29 +++++++++++------------------ 5 files changed, 38 insertions(+), 32 deletions(-) diff --git a/dlls/crypt32/oid.c b/dlls/crypt32/oid.c index 5d17997..980c750 100644 --- a/dlls/crypt32/oid.c +++ b/dlls/crypt32/oid.c @@ -1402,8 +1402,9 @@ static void init_oid_info(HINSTANCE hinst) } else { + LPCWSTR stringresource; int len = LoadStringW(hinst, (UINT_PTR)oidInfoConstructors[i].pwszName, - NULL, 0); + (LPWSTR)&stringresource, 0); if (len) { @@ -1415,12 +1416,11 @@ static void init_oid_info(HINSTANCE hinst) memset(info, 0, sizeof(*info)); info->info.cbSize = sizeof(CRYPT_OID_INFO); info->info.pszOID = oidInfoConstructors[i].pszOID; - info->info.pwszName = - (LPWSTR)((LPBYTE)info + sizeof(struct OIDInfo)); + info->info.pwszName = (LPWSTR)(info + 1); info->info.dwGroupId = oidInfoConstructors[i].dwGroupId; info->info.u.Algid = oidInfoConstructors[i].Algid; - LoadStringW(hinst, (UINT_PTR)oidInfoConstructors[i].pwszName, - (LPWSTR)info->info.pwszName, len + 1); + memcpy(info + 1, stringresource, len*sizeof(WCHAR)); + ((LPWSTR)(info + 1))[len] = 0; if (oidInfoConstructors[i].blob) { info->info.ExtraInfo.cbData = diff --git a/dlls/hhctrl.ocx/help.c b/dlls/hhctrl.ocx/help.c index 3f6a080..3ee522e 100644 --- a/dlls/hhctrl.ocx/help.c +++ b/dlls/hhctrl.ocx/help.c @@ -51,13 +51,14 @@ static const WCHAR szEmpty[] = {0}; static LPWSTR HH_LoadString(DWORD dwID) { LPWSTR string = NULL; + LPCWSTR stringresource; int iSize; - iSize = LoadStringW(hhctrl_hinstance, dwID, NULL, 0); - iSize += 2; /* some strings (tab text) needs double-null termination */ + iSize = LoadStringW(hhctrl_hinstance, dwID, (LPWSTR)&stringresource, 0); - string = heap_alloc(iSize * sizeof(WCHAR)); - LoadStringW(hhctrl_hinstance, dwID, string, iSize); + string = heap_alloc((iSize + 2) * sizeof(WCHAR)); /* some strings (tab text) needs double-null termination */ + memcpy(string, stringresource, iSize*sizeof(WCHAR)); + string[iSize] = 0; return string; } diff --git a/dlls/mpr/wnet.c b/dlls/mpr/wnet.c index 17e8195..32bc255 100644 --- a/dlls/mpr/wnet.c +++ b/dlls/mpr/wnet.c @@ -279,16 +279,18 @@ void wnetInit(HINSTANCE hInstDll) { PWSTR ptrPrev; int entireNetworkLen; + LPCWSTR stringresource; entireNetworkLen = LoadStringW(hInstDll, - IDS_ENTIRENETWORK, NULL, 0); + IDS_ENTIRENETWORK, (LPWSTR)&stringresource, 0); providerTable->entireNetwork = HeapAlloc( GetProcessHeap(), 0, (entireNetworkLen + 1) * sizeof(WCHAR)); if (providerTable->entireNetwork) - LoadStringW(hInstDll, IDS_ENTIRENETWORK, - providerTable->entireNetwork, - entireNetworkLen + 1); + { + memcpy(providerTable->entireNetwork, stringresource, entireNetworkLen*sizeof(WCHAR)); + providerTable->entireNetwork[entireNetworkLen] = 0; + } providerTable->numAllocated = numToAllocate; for (ptr = providers; ptr; ) { diff --git a/dlls/user32/resource.c b/dlls/user32/resource.c index 9eed0e8..cbdb4ea 100644 --- a/dlls/user32/resource.c +++ b/dlls/user32/resource.c @@ -368,6 +368,9 @@ INT WINAPI LoadStringW( HINSTANCE instance, UINT resource_id, TRACE("instance = %p, id = %04x, buffer = %p, length = %d\n", instance, resource_id, buffer, buflen); + if(buffer == NULL) + return 0; + /* Use loword (incremented by 1) as resourceid */ hrsrc = FindResourceW( instance, MAKEINTRESOURCEW((LOWORD(resource_id) >> 4) + 1), (LPWSTR)RT_STRING ); @@ -382,7 +385,14 @@ INT WINAPI LoadStringW( HINSTANCE instance, UINT resource_id, TRACE("strlen = %d\n", (int)*p ); - if (buffer == NULL) return *p; + /*if buflen == 0, then return a read-only pointer to the resource itself in buffer + it is assumed that buffer is actually a (LPWSTR *) */ + if(buflen == 0) + { + *((LPWSTR *)buffer) = p + 1; + return *p; + } + i = min(buflen - 1, *p); if (i > 0) { memcpy(buffer, p + 1, i * sizeof (WCHAR)); diff --git a/dlls/user32/tests/resource.c b/dlls/user32/tests/resource.c index 7be82ad..99fc24f 100644 --- a/dlls/user32/tests/resource.c +++ b/dlls/user32/tests/resource.c @@ -43,13 +43,10 @@ static void test_LoadStringW(void) length1 = LoadStringW(hInst, 2, (WCHAR *) &resourcepointer, 0); /* get pointer to resource. */ length2 = LoadStringW(hInst, 2, returnedstringw, sizeof(returnedstringw) /sizeof(WCHAR)); /* get resource string */ ok(length2 > 0, "LoadStringW failed to load resource 2, ret %d, err %d\n", length2, GetLastError()); - todo_wine - { - ok(length1 == length2, "LoadStringW returned different values dependent on buflen. ret1 %d, ret2 %d\n", - length1, length2); - ok(length1 > 0 && resourcepointer != NULL, "LoadStringW failed to get pointer to resource 2, ret %d, err %d\n", - length1, GetLastError()); - } + ok(length1 == length2, "LoadStringW returned different values dependent on buflen. ret1 %d, ret2 %d\n", + length1, length2); + ok(length1 > 0 && resourcepointer != NULL, "LoadStringW failed to get pointer to resource 2, ret %d, err %d\n", + length1, GetLastError()); /* Copy the resource since it is not '\0' terminated, and add '\0' to the end */ if(resourcepointer != NULL) /* Check that the resource pointer was loaded to avoid access violation */ @@ -62,17 +59,13 @@ static void test_LoadStringW(void) ok(!memcmp(copiedstringw, returnedstringw, (length2 + 1)*sizeof(WCHAR)), "strings don't match: returnedstring = %s, copiedstring = %s\n", returnedstring, copiedstring); } - todo_wine - { - /* check that calling LoadStringW with buffer = NULL returns zero */ - retvalue = LoadStringW(hInst, 2, NULL, 0); - ok(!retvalue, "LoadStringW returned a non-zero value when called with buffer = NULL, retvalue = %d\n", - retvalue); - /* check again, with a different buflen value, that calling LoadStringW with buffer = NULL returns zero */ - retvalue = LoadStringW(hInst, 2, NULL, 128); - ok(!retvalue, "LoadStringW returned a non-zero value when called with buffer = NULL, retvalue = %d\n", - retvalue); - } + + /* check that calling LoadStringW with buffer = NULL returns zero */ + retvalue = LoadStringW(hInst, 2, NULL, 0); + ok(!retvalue, "LoadStringW returned a non-zero value when called with buffer = NULL, retvalue = %d\n", retvalue); + /* check again, with a different buflen value, that calling LoadStringW with buffer = NULL returns zero */ + retvalue = LoadStringW(hInst, 2, NULL, 128); + ok(!retvalue, "LoadStringW returned a non-zero value when called with buffer = NULL, retvalue = %d\n", retvalue); } static void test_LoadStringA (void)

1 0

Aric Stewart : wineboot: Add Japanese resources.
by Alexandre Julliard 11 Mar '08

11 Mar '08

Module: wine Branch: master Commit: da03fc5574488780f766b85e771bbcb9bafd3f20 URL: http://source.winehq.org/git/wine.git/?a=commit;h=da03fc5574488780f766b85e7… Author: Aric Stewart <aric(a)codeweavers.com> Date: Tue Mar 11 11:33:12 2008 +0900 wineboot: Add Japanese resources. --- programs/wineboot/wineboot.rc | 1 + programs/wineboot/wineboot_Ja.rc | 35 +++++++++++++++++++++++++++++++++++ 2 files changed, 36 insertions(+), 0 deletions(-) diff --git a/programs/wineboot/wineboot.rc b/programs/wineboot/wineboot.rc index 377618b..21cf724 100644 --- a/programs/wineboot/wineboot.rc +++ b/programs/wineboot/wineboot.rc @@ -30,6 +30,7 @@ #include "wineboot_En.rc" #include "wineboot_Es.rc" #include "wineboot_Fr.rc" +#include "wineboot_Ja.rc" #include "wineboot_Ko.rc" #include "wineboot_Nl.rc" #include "wineboot_No.rc" diff --git a/programs/wineboot/wineboot_Ja.rc b/programs/wineboot/wineboot_Ja.rc new file mode 100644 index 0000000..f83ef46 --- /dev/null +++ b/programs/wineboot/wineboot_Ja.rc @@ -0,0 +1,35 @@ +/* + * WineBoot resources + * + * Copyright (C) 2008 CodeWeavers + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + * + */ + +LANGUAGE LANG_JAPANESE, SUBLANG_DEFAULT + +IDD_ENDTASK DIALOG DISCARDABLE 0, 0, 276, 71 +STYLE DS_MODALFRAME | DS_NOIDLEMSG | DS_CENTER | WS_POPUP | WS_CAPTION | WS_SYSMENU +CAPTION "�ҋ@��" +FONT 8, "MS Shell Dlg" +BEGIN + DEFPUSHBUTTON "�L��Z��",IDCANCEL,129,49,50,15 + PUSHBUTTON "�v��Z�X�̏I��",IDOK,51,49,71,15 + LTEXT "��O�I�t��сA�ċN��̃v��Z�X��V�~��[�g��Ă��܂��A�v��O��͔��Ă��܂��B", + IDC_STATIC,7,7,262,19 + LTEXT "�v��Z�X��I��ƁA�ۑ��Ă��Ȃ��f�[�^�͑S�Ď��܂��B", + IDC_STATIC,7,28,262,15 +END

1 0

Paul Vriens : kernel32: Fix/change tests for systems with no ServicePack.
by Alexandre Julliard 11 Mar '08

11 Mar '08

Module: wine Branch: master Commit: 4ca754d9a996e7a1536eff1da2ac64610aca8943 URL: http://source.winehq.org/git/wine.git/?a=commit;h=4ca754d9a996e7a1536eff1da… Author: Paul Vriens <paul.vriens.wine(a)gmail.com> Date: Tue Mar 11 11:09:38 2008 +0100 kernel32: Fix/change tests for systems with no ServicePack. --- dlls/kernel32/tests/version.c | 44 +++++++++++++++++++++++++++++----------- 1 files changed, 32 insertions(+), 12 deletions(-) diff --git a/dlls/kernel32/tests/version.c b/dlls/kernel32/tests/version.c index 07d35da..5371795 100644 --- a/dlls/kernel32/tests/version.c +++ b/dlls/kernel32/tests/version.c @@ -101,6 +101,7 @@ static void test_VerifyVersionInfo(void) { OSVERSIONINFOEX info = { sizeof(info) }; BOOL ret; + DWORD servicepack; if(!pVerifyVersionInfoA || !pVerSetConditionMask) { @@ -108,6 +109,14 @@ static void test_VerifyVersionInfo(void) return; } + /* Before we start doing some tests we should check what the version of + * the ServicePack is. Tests on a box with no ServicePack will fail otherwise. + */ + GetVersionEx((OSVERSIONINFO *)&info); + servicepack = info.wServicePackMajor; + memset(&info, 0, sizeof(info)); + info.dwOSVersionInfoSize = sizeof(info); + ret = pVerifyVersionInfoA(&info, VER_MAJORVERSION | VER_MINORVERSION, pVerSetConditionMask(0, VER_MAJORVERSION, VER_GREATER_EQUAL)); ok(ret, "VerifyVersionInfoA failed with error %d\n", GetLastError()); @@ -152,7 +161,11 @@ static void test_VerifyVersionInfo(void) ret = pVerifyVersionInfoA(&info, VER_MINORVERSION | VER_SERVICEPACKMAJOR | VER_SERVICEPACKMINOR, pVerSetConditionMask(pVerSetConditionMask(0, VER_MINORVERSION, VER_GREATER_EQUAL), VER_MAJORVERSION, VER_GREATER_EQUAL)); - ok(ret, "VerifyVersionInfoA failed with error %d\n", GetLastError()); + if (servicepack == 0) + ok(!ret && (GetLastError() == ERROR_OLD_WIN_VERSION), + "VerifyVersionInfoA should have failed with ERROR_OLD_WIN_VERSION instead of %d\n", GetLastError()); + else + ok(ret, "VerifyVersionInfoA failed with error %d\n", GetLastError()); GetVersionEx((OSVERSIONINFO *)&info); info.wServicePackMinor++; @@ -161,17 +174,24 @@ static void test_VerifyVersionInfo(void) ok(!ret && (GetLastError() == ERROR_OLD_WIN_VERSION), "VerifyVersionInfoA should have failed with ERROR_OLD_WIN_VERSION instead of %d\n", GetLastError()); - GetVersionEx((OSVERSIONINFO *)&info); - info.wServicePackMajor--; - ret = pVerifyVersionInfoA(&info, VER_MINORVERSION | VER_SERVICEPACKMAJOR | VER_SERVICEPACKMINOR, - pVerSetConditionMask(0, VER_MINORVERSION, VER_GREATER)); - ok(ret, "VerifyVersionInfoA failed with error %d\n", GetLastError()); - - GetVersionEx((OSVERSIONINFO *)&info); - info.wServicePackMajor--; - ret = pVerifyVersionInfoA(&info, VER_MINORVERSION | VER_SERVICEPACKMAJOR | VER_SERVICEPACKMINOR, - pVerSetConditionMask(0, VER_MINORVERSION, VER_GREATER_EQUAL)); - ok(ret, "VerifyVersionInfoA failed with error %d\n", GetLastError()); + if (servicepack == 0) + { + skip("There is no ServicePack on this system\n"); + } + else + { + GetVersionEx((OSVERSIONINFO *)&info); + info.wServicePackMajor--; + ret = pVerifyVersionInfoA(&info, VER_MINORVERSION | VER_SERVICEPACKMAJOR | VER_SERVICEPACKMINOR, + pVerSetConditionMask(0, VER_MINORVERSION, VER_GREATER)); + ok(ret, "VerifyVersionInfoA failed with error %d\n", GetLastError()); + + GetVersionEx((OSVERSIONINFO *)&info); + info.wServicePackMajor--; + ret = pVerifyVersionInfoA(&info, VER_MINORVERSION | VER_SERVICEPACKMAJOR | VER_SERVICEPACKMINOR, + pVerSetConditionMask(0, VER_MINORVERSION, VER_GREATER_EQUAL)); + ok(ret, "VerifyVersionInfoA failed with error %d\n", GetLastError()); + } GetVersionEx((OSVERSIONINFO *)&info); info.wServicePackMajor++;

1 0

Stefan Dösinger : wined3d: Set the fullscreen flag before the display Mode.
by Alexandre Julliard 11 Mar '08

11 Mar '08

Module: wine Branch: master Commit: c5117dab68a75f6687c473424e66189f390b7591 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c5117dab68a75f6687c473424… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Mon Mar 10 22:24:13 2008 +0100 wined3d: Set the fullscreen flag before the display Mode. --- dlls/wined3d/device.c | 13 ++----------- 1 files changed, 2 insertions(+), 11 deletions(-) diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c index b4d508e..158791f 100644 --- a/dlls/wined3d/device.c +++ b/dlls/wined3d/device.c @@ -7096,18 +7096,9 @@ static HRESULT WINAPI IWineD3DDeviceImpl_Reset(IWineD3DDevice* iface, WINED3DPRE (swapchain->presentParms.Windowed && !pPresentationParameters->Windowed) || DisplayModeChanged) { - /* Switching to fullscreen? Change to fullscreen mode, THEN change the screen res */ - if(!pPresentationParameters->Windowed) { - IWineD3DDevice_SetFullscreen(iface, TRUE); - } - - IWineD3DDevice_SetDisplayMode(iface, 0, &mode); - - /* Switching out of fullscreen mode? First set the original res, then change the window */ - if(pPresentationParameters->Windowed) { - IWineD3DDevice_SetFullscreen(iface, FALSE); - } + IWineD3DDevice_SetFullscreen(iface, !pPresentationParameters->Windowed); swapchain->presentParms.Windowed = pPresentationParameters->Windowed; + IWineD3DDevice_SetDisplayMode(iface, 0, &mode); } else if(!pPresentationParameters->Windowed) { DWORD style = This->style, exStyle = This->exStyle; /* If we're in fullscreen, and the mode wasn't changed, we have to get the window back into

1 0

Stefan Dösinger : wined3d: Only restore the style and exStyle when it is untouched.
by Alexandre Julliard 11 Mar '08

11 Mar '08

Module: wine Branch: master Commit: c81b114269c2d4a5d1011ffeffebc227b1f9d7a3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c81b114269c2d4a5d1011ffef… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Mon Mar 10 22:20:50 2008 +0100 wined3d: Only restore the style and exStyle when it is untouched. --- dlls/wined3d/device.c | 46 ++++++++++++++++++++++++++++++++++++---------- 1 files changed, 36 insertions(+), 10 deletions(-) diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c index 32f6c64..b4d508e 100644 --- a/dlls/wined3d/device.c +++ b/dlls/wined3d/device.c @@ -1248,6 +1248,27 @@ static HRESULT WINAPI IWineD3DDeviceImpl_CreateQuery(IWineD3DDevice *iface, WINE * window: Window to setup * *****************************************************************************/ +static LONG fullscreen_style(LONG orig_style) { + LONG style = orig_style; + style &= ~WS_CAPTION; + style &= ~WS_THICKFRAME; + + /* Make sure the window is managed, otherwise we won't get keyboard input */ + style |= WS_POPUP | WS_SYSMENU; + + return style; +} + +static LONG fullscreen_exStyle(LONG orig_exStyle) { + LONG exStyle = orig_exStyle; + + /* Filter out window decorations */ + exStyle &= ~WS_EX_WINDOWEDGE; + exStyle &= ~WS_EX_CLIENTEDGE; + + return exStyle; +} + static void WINAPI IWineD3DDeviceImpl_SetupFullscreenWindow(IWineD3DDevice *iface, HWND window) { IWineD3DDeviceImpl *This = (IWineD3DDeviceImpl *)iface; @@ -1267,14 +1288,8 @@ static void WINAPI IWineD3DDeviceImpl_SetupFullscreenWindow(IWineD3DDevice *ifac This->style = style; This->exStyle = exStyle; - /* Filter out window decorations */ - style &= ~WS_CAPTION; - style &= ~WS_THICKFRAME; - exStyle &= ~WS_EX_WINDOWEDGE; - exStyle &= ~WS_EX_CLIENTEDGE; - - /* Make sure the window is managed, otherwise we won't get keyboard input */ - style |= WS_POPUP | WS_SYSMENU; + style = fullscreen_style(style); + exStyle = fullscreen_exStyle(exStyle); TRACE("Old style was %08x,%08x, setting to %08x,%08x\n", This->style, This->exStyle, style, exStyle); @@ -1301,6 +1316,7 @@ static void WINAPI IWineD3DDeviceImpl_SetupFullscreenWindow(IWineD3DDevice *ifac *****************************************************************************/ static void WINAPI IWineD3DDeviceImpl_RestoreWindow(IWineD3DDevice *iface, HWND window) { IWineD3DDeviceImpl *This = (IWineD3DDeviceImpl *)iface; + LONG style, exStyle; /* This could be a DDSCL_NORMAL -> DDSCL_NORMAL * switch, do nothing @@ -1310,8 +1326,18 @@ static void WINAPI IWineD3DDeviceImpl_RestoreWindow(IWineD3DDevice *iface, HWND TRACE("(%p): Restoring window settings of window %p to %08x, %08x\n", This, window, This->style, This->exStyle); - SetWindowLongW(window, GWL_STYLE, This->style); - SetWindowLongW(window, GWL_EXSTYLE, This->exStyle); + style = GetWindowLongW(window, GWL_STYLE); + exStyle = GetWindowLongW(window, GWL_EXSTYLE); + + /* Only restore the style if the application didn't modify it during the fullscreen phase. + * Some applications change it before calling Reset() when switching between windowed and + * fullscreen modes(HL2), some depend on the original style(Eve Online) + */ + if(style == fullscreen_style(This->style) && + exStyle == fullscreen_style(This->exStyle)) { + SetWindowLongW(window, GWL_STYLE, This->style); + SetWindowLongW(window, GWL_EXSTYLE, This->exStyle); + } /* Delete the old values */ This->style = 0;

1 0

Stefan Dösinger : wined3d: Only adjust windows in fullscreen mode to the screen.
by Alexandre Julliard 11 Mar '08

11 Mar '08

Module: wine Branch: master Commit: a9fb81b2edceadc58eb84ed9e920d19719a05330 URL: http://source.winehq.org/git/wine.git/?a=commit;h=a9fb81b2edceadc58eb84ed9e… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Mon Mar 10 22:15:22 2008 +0100 wined3d: Only adjust windows in fullscreen mode to the screen. --- dlls/wined3d/device.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c index 3f2d57e..32f6c64 100644 --- a/dlls/wined3d/device.c +++ b/dlls/wined3d/device.c @@ -2337,8 +2337,8 @@ static HRESULT WINAPI IWineD3DDeviceImpl_SetDisplayMode(IWineD3DDevice *iface, U This->ddraw_height = pMode->Height; This->ddraw_format = pMode->Format; - /* Only do this with a window of course */ - if(This->ddraw_window) + /* Only do this with a window of course, and only if we're fullscreened */ + if(This->ddraw_window && This->ddraw_fullscreen) MoveWindow(This->ddraw_window, 0, 0, pMode->Width, pMode->Height, TRUE); /* And finally clip mouse to our screen */

1 0

Andrew Talbot : ole32: Assign to structs instead of using memcpy.
by Alexandre Julliard 11 Mar '08

11 Mar '08

Module: wine Branch: master Commit: 4971f2f687503ee9e879965ffa1f0117be5b3fbe URL: http://source.winehq.org/git/wine.git/?a=commit;h=4971f2f687503ee9e879965ff… Author: Andrew Talbot <andrew.talbot(a)talbotville.com> Date: Mon Mar 10 21:58:39 2008 +0000 ole32: Assign to structs instead of using memcpy. --- dlls/ole32/clipboard.c | 2 +- dlls/ole32/compobj.c | 2 +- dlls/ole32/datacache.c | 4 ++-- dlls/ole32/defaulthandler.c | 4 ++-- dlls/ole32/errorinfo.c | 4 ++-- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/dlls/ole32/clipboard.c b/dlls/ole32/clipboard.c index 4e43e38..ad15219 100644 --- a/dlls/ole32/clipboard.c +++ b/dlls/ole32/clipboard.c @@ -1365,7 +1365,7 @@ static HRESULT WINAPI OLEClipbrd_IDataObject_GetCanonicalFormatEtc( if ( !pformatectIn || !pformatetcOut ) return E_INVALIDARG; - memcpy(pformatetcOut, pformatectIn, sizeof(FORMATETC)); + *pformatetcOut = *pformatectIn; return DATA_S_SAMEFORMATETC; } diff --git a/dlls/ole32/compobj.c b/dlls/ole32/compobj.c index 1cb8183..25a1629 100644 --- a/dlls/ole32/compobj.c +++ b/dlls/ole32/compobj.c @@ -2855,7 +2855,7 @@ HRESULT WINAPI CoGetTreatAsClass(REFCLSID clsidOld, LPCLSID clsidNew) LONG len = sizeof(szClsidNew); FIXME("(%s,%p)\n", debugstr_guid(clsidOld), clsidNew); - memcpy(clsidNew,clsidOld,sizeof(CLSID)); /* copy over old value */ + *clsidNew = *clsidOld; /* copy over old value */ res = COM_OpenKeyForCLSID(clsidOld, wszTreatAs, KEY_READ, &hkey); if (FAILED(res)) diff --git a/dlls/ole32/datacache.c b/dlls/ole32/datacache.c index beb6d93..8903506 100644 --- a/dlls/ole32/datacache.c +++ b/dlls/ole32/datacache.c @@ -1240,13 +1240,13 @@ static HRESULT WINAPI DataCache_GetClassID( HRESULT hr = IStorage_Stat(cache_entry->storage, &statstg, STATFLAG_NONAME); if (SUCCEEDED(hr)) { - memcpy(pClassID, &statstg.clsid, sizeof(*pClassID)); + *pClassID = statstg.clsid; return S_OK; } } } - memcpy(pClassID, &CLSID_NULL, sizeof(*pClassID)); + *pClassID = CLSID_NULL; return S_OK; } diff --git a/dlls/ole32/defaulthandler.c b/dlls/ole32/defaulthandler.c index 33e80ce..f9f676f 100644 --- a/dlls/ole32/defaulthandler.c +++ b/dlls/ole32/defaulthandler.c @@ -672,7 +672,7 @@ static HRESULT WINAPI DefaultHandler_GetUserClassID( if (!pClsid) return E_POINTER; - memcpy(pClsid, &This->clsid, sizeof(CLSID)); + *pClsid = This->clsid; return S_OK; } @@ -1744,7 +1744,7 @@ static DefaultHandler* DefaultHandler_Construct( /* * Initialize the other data members of the class. */ - memcpy(&This->clsid, clsid, sizeof(CLSID)); + This->clsid = *clsid; This->clientSite = NULL; This->oleAdviseHolder = NULL; This->dataAdviseHolder = NULL; diff --git a/dlls/ole32/errorinfo.c b/dlls/ole32/errorinfo.c index 7318a97..e4a1c47 100644 --- a/dlls/ole32/errorinfo.c +++ b/dlls/ole32/errorinfo.c @@ -250,7 +250,7 @@ static HRESULT WINAPI IErrorInfoImpl_GetGUID( ErrorInfoImpl *This = impl_from_IErrorInfo(iface); TRACE("(%p)->(count=%u)\n",This,This->ref); if(!pGUID )return E_INVALIDARG; - memcpy(pGUID, &This->m_Guid, sizeof(GUID)); + *pGUID = This->m_Guid; return S_OK; } @@ -354,7 +354,7 @@ static HRESULT WINAPI ICreateErrorInfoImpl_SetGUID( { ErrorInfoImpl *This = impl_from_ICreateErrorInfo(iface); TRACE("(%p)->(%s)\n", This, debugstr_guid(rguid)); - memcpy(&This->m_Guid, rguid, sizeof(GUID)); + This->m_Guid = *rguid; return S_OK; }

1 0

Andrew Talbot : ole32: Assign to structs instead of using memcpy.
by Alexandre Julliard 11 Mar '08

11 Mar '08

Module: wine Branch: master Commit: e7b0f07c3e00ed4bf829ff8beb61948565834aca URL: http://source.winehq.org/git/wine.git/?a=commit;h=e7b0f07c3e00ed4bf829ff8be… Author: Andrew Talbot <andrew.talbot(a)talbotville.com> Date: Mon Mar 10 21:58:43 2008 +0000 ole32: Assign to structs instead of using memcpy. --- dlls/ole32/ftmarshal.c | 4 ++-- dlls/ole32/oleobj.c | 2 +- dlls/ole32/rpc.c | 10 +++++----- dlls/ole32/stg_prop.c | 20 ++++++++++---------- dlls/ole32/storage32.c | 2 +- 5 files changed, 19 insertions(+), 19 deletions(-) diff --git a/dlls/ole32/ftmarshal.c b/dlls/ole32/ftmarshal.c index 9f6ad8c..d71c29a 100644 --- a/dlls/ole32/ftmarshal.c +++ b/dlls/ole32/ftmarshal.c @@ -141,9 +141,9 @@ FTMarshalImpl_GetUnmarshalClass (LPMARSHAL iface, REFIID riid, void *pv, DWORD d TRACE("(%s, %p, 0x%x, %p, 0x%x, %p)\n", debugstr_guid(riid), pv, dwDestContext, pvDestContext, mshlflags, pCid); if (dwDestContext == MSHCTX_INPROC || dwDestContext == MSHCTX_CROSSCTX) - memcpy(pCid, &CLSID_InProcFreeMarshaler, sizeof(CLSID_InProcFreeMarshaler)); + *pCid = CLSID_InProcFreeMarshaler; else - memcpy(pCid, &CLSID_DfMarshal, sizeof(CLSID_InProcFreeMarshaler)); + *pCid = CLSID_DfMarshal; return S_OK; } diff --git a/dlls/ole32/oleobj.c b/dlls/ole32/oleobj.c index 1c88797..217e01d 100644 --- a/dlls/ole32/oleobj.c +++ b/dlls/ole32/oleobj.c @@ -724,7 +724,7 @@ static HRESULT WINAPI DataAdviseHolder_Advise( */ This->Connections[index].sink = pAdvise; This->Connections[index].advf = advf & ~WINE_ADVF_REMOTE; - memcpy(&(This->Connections[index].fmat), pFetc, sizeof(FORMATETC)); + This->Connections[index].fmat = *pFetc; if (pFetc->ptd) { This->Connections[index].fmat.ptd = CoTaskMemAlloc(pFetc->ptd->tdSize); diff --git a/dlls/ole32/rpc.c b/dlls/ole32/rpc.c index 256ec04..7af0b29 100644 --- a/dlls/ole32/rpc.c +++ b/dlls/ole32/rpc.c @@ -242,7 +242,7 @@ static unsigned char * ChannelHooks_ClientFillBuffer(SChannelHookCallInfo *info, wire_orpc_extent->conformance = (extension_size+7)&~7; wire_orpc_extent->size = extension_size; - memcpy(&wire_orpc_extent->id, &entry->id, sizeof(wire_orpc_extent->id)); + wire_orpc_extent->id = entry->id; buffer += FIELD_OFFSET(WIRE_ORPC_EXTENT, data[wire_orpc_extent->conformance]); } @@ -362,7 +362,7 @@ static unsigned char * ChannelHooks_ServerFillBuffer(SChannelHookCallInfo *info, wire_orpc_extent->conformance = (extension_size+7)&~7; wire_orpc_extent->size = extension_size; - memcpy(&wire_orpc_extent->id, &entry->id, sizeof(wire_orpc_extent->id)); + wire_orpc_extent->id = entry->id; buffer += FIELD_OFFSET(WIRE_ORPC_EXTENT, data[wire_orpc_extent->conformance]); } @@ -411,7 +411,7 @@ HRESULT RPC_RegisterChannelHook(REFGUID rguid, IChannelHook *hook) if (!entry) return E_OUTOFMEMORY; - memcpy(&entry->id, rguid, sizeof(entry->id)); + entry->id = *rguid; entry->hook = hook; IChannelHook_AddRef(hook); @@ -553,7 +553,7 @@ static HRESULT WINAPI ServerRpcChannelBuffer_GetBuffer(LPRPCCHANNELBUFFER iface, { WIRE_ORPC_EXTENT *wire_orpc_extent = msg->Buffer; wire_orpc_extent->conformance = 0; - memcpy(&wire_orpc_extent->id, &GUID_NULL, sizeof(wire_orpc_extent->id)); + wire_orpc_extent->id = GUID_NULL; wire_orpc_extent->size = 0; msg->Buffer = (char *)msg->Buffer + FIELD_OFFSET(WIRE_ORPC_EXTENT, data[0]); } @@ -737,7 +737,7 @@ static HRESULT WINAPI ClientRpcChannelBuffer_GetBuffer(LPRPCCHANNELBUFFER iface, { WIRE_ORPC_EXTENT *wire_orpc_extent = msg->Buffer; wire_orpc_extent->conformance = 0; - memcpy(&wire_orpc_extent->id, &GUID_NULL, sizeof(wire_orpc_extent->id)); + wire_orpc_extent->id = GUID_NULL; wire_orpc_extent->size = 0; msg->Buffer = (char *)msg->Buffer + FIELD_OFFSET(WIRE_ORPC_EXTENT, data[0]); } diff --git a/dlls/ole32/stg_prop.c b/dlls/ole32/stg_prop.c index b688855..20d9ec3 100644 --- a/dlls/ole32/stg_prop.c +++ b/dlls/ole32/stg_prop.c @@ -913,12 +913,12 @@ static HRESULT WINAPI IPropertyStorage_fnStat( hr = IStream_Stat(This->stm, &stat, STATFLAG_NONAME); if (SUCCEEDED(hr)) { - memcpy(&statpsstg->fmtid, &This->fmtid, sizeof(statpsstg->fmtid)); - memcpy(&statpsstg->clsid, &This->clsid, sizeof(statpsstg->clsid)); + statpsstg->fmtid = This->fmtid; + statpsstg->clsid = This->clsid; statpsstg->grfFlags = This->grfFlags; - memcpy(&statpsstg->mtime, &stat.mtime, sizeof(statpsstg->mtime)); - memcpy(&statpsstg->ctime, &stat.ctime, sizeof(statpsstg->ctime)); - memcpy(&statpsstg->atime, &stat.atime, sizeof(statpsstg->atime)); + statpsstg->mtime = stat.mtime; + statpsstg->ctime = stat.ctime; + statpsstg->atime = stat.atime; statpsstg->dwOSVersion = This->originatorOS; } return hr; @@ -1309,7 +1309,7 @@ static HRESULT PropertyStorage_ReadFromStream(PropertyStorage_impl *This) goto end; } This->format = hdr.wFormat; - memcpy(&This->clsid, &hdr.clsid, sizeof(This->clsid)); + This->clsid = hdr.clsid; This->originatorOS = hdr.dwOSVer; if (PROPSETHDR_OSVER_KIND(hdr.dwOSVer) == PROPSETHDR_OSVER_KIND_MAC) WARN("File comes from a Mac, strings will probably be screwed up\n"); @@ -1969,7 +1969,7 @@ static HRESULT PropertyStorage_BaseConstruct(IStream *stm, InitializeCriticalSection(&(*pps)->cs); (*pps)->cs.DebugInfo->Spare[0] = (DWORD_PTR)(__FILE__ ": PropertyStorage_impl.cs"); (*pps)->stm = stm; - memcpy(&(*pps)->fmtid, rfmtid, sizeof((*pps)->fmtid)); + (*pps)->fmtid = *rfmtid; (*pps)->grfMode = grfMode; hr = PropertyStorage_CreateDictionaries(*pps); @@ -2314,7 +2314,7 @@ static HRESULT create_EnumSTATPROPSETSTG( statpss.atime = stat.atime; statpss.ctime = stat.ctime; statpss.grfFlags = stat.grfMode; - memcpy(&statpss.clsid, &stat.clsid, sizeof stat.clsid); + statpss.clsid = stat.clsid; enumx_add_element(enumx, &statpss); } CoTaskMemFree(stat.pwcsName); @@ -2570,12 +2570,12 @@ HRESULT WINAPI PropStgNameToFmtId(const LPOLESTR str, FMTID *rfmtid) if (!lstrcmpiW(str, szDocSummaryInfo)) { - memcpy(rfmtid, &FMTID_DocSummaryInformation, sizeof(*rfmtid)); + *rfmtid = FMTID_DocSummaryInformation; hr = S_OK; } else if (!lstrcmpiW(str, szSummaryInfo)) { - memcpy(rfmtid, &FMTID_SummaryInformation, sizeof(*rfmtid)); + *rfmtid = FMTID_SummaryInformation; hr = S_OK; } else diff --git a/dlls/ole32/storage32.c b/dlls/ole32/storage32.c index 389b047..2bdad45 100644 --- a/dlls/ole32/storage32.c +++ b/dlls/ole32/storage32.c @@ -7908,7 +7908,7 @@ HRESULT WINAPI ReadClassStm(IStream *pStm,CLSID *pclsid) return E_INVALIDARG; /* clear the output args */ - memcpy(pclsid, &CLSID_NULL, sizeof(*pclsid)); + *pclsid = CLSID_NULL; res = IStream_Read(pStm,(void*)pclsid,sizeof(CLSID),&nbByte);

1 0

Mikołaj Zalewski : shell32: Remove DISCARDABLE from STRINGTABLE resources.
by Alexandre Julliard 11 Mar '08

11 Mar '08

Module: wine Branch: master Commit: 1fd3797397d608d99e4c57528f3133be8e8c96aa URL: http://source.winehq.org/git/wine.git/?a=commit;h=1fd3797397d608d99e4c57528… Author: Mikołaj Zalewski <mikolaj(a)zalewski.pl> Date: Sun Mar 2 22:37:26 2008 +0100 shell32: Remove DISCARDABLE from STRINGTABLE resources. --- dlls/shell32/shell32_Bg.rc | 2 +- dlls/shell32/shell32_Cn.rc | 2 +- dlls/shell32/shell32_Cs.rc | 2 +- dlls/shell32/shell32_De.rc | 2 +- dlls/shell32/shell32_En.rc | 2 +- dlls/shell32/shell32_Eo.rc | 10 +++++----- dlls/shell32/shell32_Es.rc | 2 +- dlls/shell32/shell32_Fi.rc | 2 +- dlls/shell32/shell32_Fr.rc | 2 +- dlls/shell32/shell32_It.rc | 2 +- dlls/shell32/shell32_Ja.rc | 6 +++--- dlls/shell32/shell32_Ko.rc | 2 +- dlls/shell32/shell32_Nl.rc | 2 +- dlls/shell32/shell32_No.rc | 2 +- dlls/shell32/shell32_Pl.rc | 2 +- dlls/shell32/shell32_Pt.rc | 4 ++-- dlls/shell32/shell32_Ru.rc | 2 +- dlls/shell32/shell32_Si.rc | 2 +- dlls/shell32/shell32_Sk.rc | 2 +- dlls/shell32/shell32_Tr.rc | 2 +- dlls/shell32/shell32_Uk.rc | 2 +- dlls/shell32/shell32_Zh.rc | 2 +- 22 files changed, 29 insertions(+), 29 deletions(-) diff --git a/dlls/shell32/shell32_Bg.rc b/dlls/shell32/shell32_Bg.rc index ff91778..6f153f5 100644 --- a/dlls/shell32/shell32_Bg.rc +++ b/dlls/shell32/shell32_Bg.rc @@ -132,7 +132,7 @@ FONT 8, "MS Shell Dlg" PUSHBUTTON "&��...", 12288, 170, 63, 50, 14, WS_TABSTOP } -STRINGTABLE DISCARDABLE +STRINGTABLE { /* columns in the shellview */ IDS_SHV_COLUMN1 "��" diff --git a/dlls/shell32/shell32_Cn.rc b/dlls/shell32/shell32_Cn.rc index f88a1ea..3416546 100644 --- a/dlls/shell32/shell32_Cn.rc +++ b/dlls/shell32/shell32_Cn.rc @@ -69,7 +69,7 @@ FONT 8, "MS Shell Dlg" } /* columns in the shellview */ -STRINGTABLE LANGUAGE LANG_CHINESE, SUBLANG_CHINESE_SIMPLIFIED +STRINGTABLE BEGIN IDS_SHV_COLUMN1 "�ļ�" IDS_SHV_COLUMN2 "��С" diff --git a/dlls/shell32/shell32_Cs.rc b/dlls/shell32/shell32_Cs.rc index bf1b349..5d77357 100644 --- a/dlls/shell32/shell32_Cs.rc +++ b/dlls/shell32/shell32_Cs.rc @@ -139,7 +139,7 @@ FONT 8, "MS Shell Dlg" /* special folders */ -STRINGTABLE DISCARDABLE +STRINGTABLE { IDS_DESKTOP "Plocha" IDS_MYCOMPUTER "Tento po��ta�" diff --git a/dlls/shell32/shell32_De.rc b/dlls/shell32/shell32_De.rc index aa5fa6c..8f45cc6 100644 --- a/dlls/shell32/shell32_De.rc +++ b/dlls/shell32/shell32_De.rc @@ -146,7 +146,7 @@ FONT 8, "MS Shell Dlg" PUSHBUTTON "&Durchsuchen...", 12288, 170, 63, 50, 14, WS_TABSTOP } -STRINGTABLE DISCARDABLE +STRINGTABLE { /* columns in the shellview */ IDS_SHV_COLUMN1 "Datei" diff --git a/dlls/shell32/shell32_En.rc b/dlls/shell32/shell32_En.rc index ca063b8..c214daf 100644 --- a/dlls/shell32/shell32_En.rc +++ b/dlls/shell32/shell32_En.rc @@ -163,7 +163,7 @@ FONT 8, "MS Shell Dlg" PUSHBUTTON "&Browse...", 12288, 170, 63, 50, 14, WS_TABSTOP } -STRINGTABLE DISCARDABLE +STRINGTABLE { /* columns in the shellview */ IDS_SHV_COLUMN1 "File" diff --git a/dlls/shell32/shell32_Eo.rc b/dlls/shell32/shell32_Eo.rc index eb40240..b406672 100644 --- a/dlls/shell32/shell32_Eo.rc +++ b/dlls/shell32/shell32_Eo.rc @@ -137,7 +137,7 @@ FONT 8, "MS Shell Dlg" /* special folders */ -STRINGTABLE DISCARDABLE +STRINGTABLE { IDS_DESKTOP "Desktop" IDS_MYCOMPUTER "Mea Komputero" @@ -146,7 +146,7 @@ STRINGTABLE DISCARDABLE /* context menus */ -STRINGTABLE DISCARDABLE +STRINGTABLE { IDS_VIEW_LARGE "&Grandaj Ikonoj" IDS_VIEW_SMALL "Malgrandaj Ikonoj" @@ -156,7 +156,7 @@ STRINGTABLE DISCARDABLE IDS_OPEN "Malfermu" } -STRINGTABLE DISCARDABLE +STRINGTABLE { IDS_CREATEFOLDER_DENIED "Mi ne povas crei novan Dosierujon: Aliro rifuzita." IDS_CREATEFOLDER_CAPTION "Eraro dum krei�o de dosierujo" @@ -188,7 +188,7 @@ END /* message box strings */ -STRINGTABLE DISCARDABLE +STRINGTABLE { IDS_RESTART_TITLE "Restartigu" IDS_RESTART_PROMPT "�u vi volas simuli Vindozan restartigon?" @@ -197,7 +197,7 @@ STRINGTABLE DISCARDABLE } /* shell folder path default values */ -STRINGTABLE DISCARDABLE +STRINGTABLE { IDS_PROGRAMS "Start Menu\\Programs" IDS_PERSONAL "Miaj Dokumentoj" diff --git a/dlls/shell32/shell32_Es.rc b/dlls/shell32/shell32_Es.rc index 1feb8d2..0b3a2e0 100644 --- a/dlls/shell32/shell32_Es.rc +++ b/dlls/shell32/shell32_Es.rc @@ -146,7 +146,7 @@ FONT 8, "MS Shell Dlg" PUSHBUTTON "&Examinar...", 12288, 170, 63, 50, 14, WS_TABSTOP } -STRINGTABLE DISCARDABLE +STRINGTABLE { /* columns in the shellview */ IDS_SHV_COLUMN1 "Archivo" diff --git a/dlls/shell32/shell32_Fi.rc b/dlls/shell32/shell32_Fi.rc index dc019f5..885b399 100644 --- a/dlls/shell32/shell32_Fi.rc +++ b/dlls/shell32/shell32_Fi.rc @@ -132,7 +132,7 @@ FONT 8, "MS Shell Dlg" PUSHBUTTON "&Selaa...", 12288, 170, 63, 50, 14, WS_TABSTOP } -STRINGTABLE DISCARDABLE +STRINGTABLE { /* columns in the shellview */ IDS_SHV_COLUMN1 "Tiedosto" diff --git a/dlls/shell32/shell32_Fr.rc b/dlls/shell32/shell32_Fr.rc index 2c8c838..a006ec9 100644 --- a/dlls/shell32/shell32_Fr.rc +++ b/dlls/shell32/shell32_Fr.rc @@ -167,7 +167,7 @@ FONT 8, "MS Shell Dlg" PUSHBUTTON "&Parcourir...", 12288, 170, 63, 50, 14, WS_TABSTOP } -STRINGTABLE DISCARDABLE +STRINGTABLE { /* columns in the shellview */ IDS_SHV_COLUMN1 "Fichier" diff --git a/dlls/shell32/shell32_It.rc b/dlls/shell32/shell32_It.rc index b8f4ef1..3685f53 100644 --- a/dlls/shell32/shell32_It.rc +++ b/dlls/shell32/shell32_It.rc @@ -134,7 +134,7 @@ FONT 8, "MS Shell Dlg" PUSHBUTTON "E&splora...", 12288, 170, 63, 50, 14, WS_TABSTOP } -STRINGTABLE DISCARDABLE +STRINGTABLE { /* columns in the shellview */ IDS_SHV_COLUMN1 "File" diff --git a/dlls/shell32/shell32_Ja.rc b/dlls/shell32/shell32_Ja.rc index d38b00d..2023c32 100644 --- a/dlls/shell32/shell32_Ja.rc +++ b/dlls/shell32/shell32_Ja.rc @@ -80,7 +80,7 @@ END /* special folders */ -STRINGTABLE DISCARDABLE +STRINGTABLE { IDS_DESKTOP "�޽�į��" IDS_MYCOMPUTER "ϲ��߭��" @@ -89,7 +89,7 @@ STRINGTABLE DISCARDABLE /* context menus */ -STRINGTABLE DISCARDABLE +STRINGTABLE { IDS_VIEW_LARGE "�傫��A�C�R��(&G)" IDS_VIEW_SMALL "��A�C�R��(&M)" @@ -127,7 +127,7 @@ FONT 8, "MS Shell Dlg" } /* columns in the shellview */ -STRINGTABLE DISCARDABLE +STRINGTABLE BEGIN IDS_SHV_COLUMN1 "��O" IDS_SHV_COLUMN2 "�T�C�Y" diff --git a/dlls/shell32/shell32_Ko.rc b/dlls/shell32/shell32_Ko.rc index 56d27ce..c5a7f52 100644 --- a/dlls/shell32/shell32_Ko.rc +++ b/dlls/shell32/shell32_Ko.rc @@ -166,7 +166,7 @@ PUSHBUTTON " PUSHBUTTON "ã��(&B)...", 12288, 170, 63, 50, 14, WS_TABSTOP } -STRINGTABLE DISCARDABLE +STRINGTABLE { /* columns in the shellview */ IDS_SHV_COLUMN1 "��" diff --git a/dlls/shell32/shell32_Nl.rc b/dlls/shell32/shell32_Nl.rc index 98f529c..d1ab5be 100644 --- a/dlls/shell32/shell32_Nl.rc +++ b/dlls/shell32/shell32_Nl.rc @@ -164,7 +164,7 @@ FONT 8, "MS Shell Dlg" PUSHBUTTON "&Bladeren...", 12288, 170, 63, 50, 14, WS_TABSTOP } -STRINGTABLE DISCARDABLE +STRINGTABLE { /* columns in the shellview */ IDS_SHV_COLUMN1 "Bestand" diff --git a/dlls/shell32/shell32_No.rc b/dlls/shell32/shell32_No.rc index 63174ad..be2b4a8 100644 --- a/dlls/shell32/shell32_No.rc +++ b/dlls/shell32/shell32_No.rc @@ -163,7 +163,7 @@ FONT 8, "MS Shell Dlg" PUSHBUTTON "&Bla . . .", 12288, 170, 63, 50, 14, WS_TABSTOP } -STRINGTABLE DISCARDABLE +STRINGTABLE { /* columns in the shellview */ IDS_SHV_COLUMN1 "Fil" diff --git a/dlls/shell32/shell32_Pl.rc b/dlls/shell32/shell32_Pl.rc index 0994ed1..619db0a 100644 --- a/dlls/shell32/shell32_Pl.rc +++ b/dlls/shell32/shell32_Pl.rc @@ -146,7 +146,7 @@ FONT 8, "MS Shell Dlg" PUSHBUTTON "&Przegl�daj...", 12288, 170, 63, 50, 14, WS_TABSTOP } -STRINGTABLE DISCARDABLE +STRINGTABLE { /* columns in the shellview */ IDS_SHV_COLUMN1 "Plik" diff --git a/dlls/shell32/shell32_Pt.rc b/dlls/shell32/shell32_Pt.rc index 8c2ed7f..38fa0f9 100644 --- a/dlls/shell32/shell32_Pt.rc +++ b/dlls/shell32/shell32_Pt.rc @@ -224,7 +224,7 @@ FONT 8, "MS Shell Dlg" LANGUAGE LANG_PORTUGUESE, SUBLANG_PORTUGUESE_BRAZILIAN -STRINGTABLE DISCARDABLE +STRINGTABLE { /* columns in the shellview */ IDS_SHV_COLUMN1 "Arquivo" @@ -302,7 +302,7 @@ STRINGTABLE DISCARDABLE LANGUAGE LANG_PORTUGUESE, SUBLANG_PORTUGUESE -STRINGTABLE DISCARDABLE +STRINGTABLE { /* columns in the shellview */ IDS_SHV_COLUMN1 "Ficheiro" diff --git a/dlls/shell32/shell32_Ru.rc b/dlls/shell32/shell32_Ru.rc index d03b5d0..fb1a137 100644 --- a/dlls/shell32/shell32_Ru.rc +++ b/dlls/shell32/shell32_Ru.rc @@ -133,7 +133,7 @@ FONT 8, "MS Shell Dlg" PUSHBUTTON "��&��...", 12288, 170, 63, 50, 14, WS_TABSTOP } -STRINGTABLE DISCARDABLE +STRINGTABLE { /* columns in the shellview */ IDS_SHV_COLUMN1 "��" diff --git a/dlls/shell32/shell32_Si.rc b/dlls/shell32/shell32_Si.rc index 1d84d09..cd2ce27 100644 --- a/dlls/shell32/shell32_Si.rc +++ b/dlls/shell32/shell32_Si.rc @@ -68,7 +68,7 @@ FONT 8, "MS Shell Dlg" } /* columns in the shellview */ -STRINGTABLE LANGUAGE LANG_SLOVENIAN, SUBLANG_NEUTRAL +STRINGTABLE BEGIN IDS_SHV_COLUMN1 "Datoteka" IDS_SHV_COLUMN2 "Velikost" diff --git a/dlls/shell32/shell32_Sk.rc b/dlls/shell32/shell32_Sk.rc index 644ef32..6e90cc2 100644 --- a/dlls/shell32/shell32_Sk.rc +++ b/dlls/shell32/shell32_Sk.rc @@ -68,7 +68,7 @@ FONT 8, "MS Shell Dlg" } /* columns in the shellview */ -STRINGTABLE LANGUAGE LANG_SLOVAK, SUBLANG_NEUTRAL +STRINGTABLE BEGIN IDS_SHV_COLUMN1 "S�bor" IDS_SHV_COLUMN2 "Ve�kos�" diff --git a/dlls/shell32/shell32_Tr.rc b/dlls/shell32/shell32_Tr.rc index b7cae6e..d9c2d22 100644 --- a/dlls/shell32/shell32_Tr.rc +++ b/dlls/shell32/shell32_Tr.rc @@ -132,7 +132,7 @@ FONT 8, "MS Shell Dlg" PUSHBUTTON "&G�zat...", 12288, 170, 63, 50, 14, WS_TABSTOP } -STRINGTABLE DISCARDABLE +STRINGTABLE { /* columns in the shellview */ IDS_SHV_COLUMN1 "Dosya" diff --git a/dlls/shell32/shell32_Uk.rc b/dlls/shell32/shell32_Uk.rc index 2ffaf31..8b2a02a 100644 --- a/dlls/shell32/shell32_Uk.rc +++ b/dlls/shell32/shell32_Uk.rc @@ -135,7 +135,7 @@ FONT 8, "MS Shell Dlg" /* special folders */ -STRINGTABLE DISCARDABLE +STRINGTABLE { IDS_DESKTOP "��" IDS_MYCOMPUTER "̳� ��'��" diff --git a/dlls/shell32/shell32_Zh.rc b/dlls/shell32/shell32_Zh.rc index 0691ea7..edf0233 100644 --- a/dlls/shell32/shell32_Zh.rc +++ b/dlls/shell32/shell32_Zh.rc @@ -68,7 +68,7 @@ FONT 8, "MS Shell Dlg" } /* columns in the shellview */ -STRINGTABLE LANGUAGE LANG_CHINESE, SUBLANG_CHINESE_TRADITIONAL +STRINGTABLE BEGIN IDS_SHV_COLUMN1 "�n��" IDS_SHV_COLUMN2 "��С"

1 0