June 2008 - Wine-commits - list.winehq.org

Huw Davies : netapi32: Free the correct pointers.
by Alexandre Julliard 20 Jun '08

20 Jun '08

Module: wine Branch: master Commit: 09c0bf20a1b8850f5b5ebfaa2ba4637ef8bce7b2 URL: http://source.winehq.org/git/wine.git/?a=commit;h=09c0bf20a1b8850f5b5ebfaa2… Author: Huw Davies <huw(a)codeweavers.com> Date: Thu Jun 19 14:13:51 2008 +0100 netapi32: Free the correct pointers. --- dlls/netapi32/ds.c | 1 + dlls/netapi32/tests/ds.c | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/dlls/netapi32/ds.c b/dlls/netapi32/ds.c index 740ef5d..386e222 100644 --- a/dlls/netapi32/ds.c +++ b/dlls/netapi32/ds.c @@ -99,6 +99,7 @@ DWORD WINAPI DsRoleGetPrimaryDomainInformation( if (!Buffer) return ERROR_INVALID_PARAMETER; if ((InfoLevel < DsRolePrimaryDomainInfoBasic) || (InfoLevel > DsRoleOperationState)) return ERROR_INVALID_PARAMETER; + *Buffer = NULL; switch (InfoLevel) { case DsRolePrimaryDomainInfoBasic: diff --git a/dlls/netapi32/tests/ds.c b/dlls/netapi32/tests/ds.c index 9111915..277a589 100644 --- a/dlls/netapi32/tests/ds.c +++ b/dlls/netapi32/tests/ds.c @@ -60,17 +60,17 @@ static void test_get(void) SetLastError(0xdeadbeef); ret = pDsRoleGetPrimaryDomainInformation(NULL, DsRolePrimaryDomainInfoBasic, (PBYTE *)&dpdi); ok( ret == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got (%d)\n", ret); - pDsRoleFreeMemory(&dpdi); + pDsRoleFreeMemory(dpdi); SetLastError(0xdeadbeef); ret = pDsRoleGetPrimaryDomainInformation(NULL, DsRoleUpgradeStatus, (PBYTE *)&dusi); todo_wine { ok( ret == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got (%d)\n", ret); } - pDsRoleFreeMemory(&dusi); + pDsRoleFreeMemory(dusi); SetLastError(0xdeadbeef); ret = pDsRoleGetPrimaryDomainInformation(NULL, DsRoleOperationState, (PBYTE *)&dosi); todo_wine { ok( ret == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got (%d)\n", ret); } - pDsRoleFreeMemory(&dosi); + pDsRoleFreeMemory(dosi); }

1 0

Louis Lenders : kernel32: Fix typo in SetProcessAffinityMask.
by Alexandre Julliard 20 Jun '08

20 Jun '08

Module: wine Branch: master Commit: d9fa87382ebca362747fcd1fb0fb61f07207b224 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d9fa87382ebca362747fcd1fb… Author: Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> Date: Thu Jun 19 09:44:41 2008 +0000 kernel32: Fix typo in SetProcessAffinityMask. --- dlls/kernel32/process.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c index 868cc04..3a97c16 100644 --- a/dlls/kernel32/process.c +++ b/dlls/kernel32/process.c @@ -2751,7 +2751,7 @@ BOOL WINAPI SetProcessAffinityMask( HANDLE hProcess, DWORD_PTR affmask ) status = NtSetInformationProcess(hProcess, ProcessAffinityMask, &affmask, sizeof(DWORD_PTR)); - if (!status) + if (status) { SetLastError( RtlNtStatusToDosError(status) ); return FALSE;

1 0

Huw Davies : gdiplus: GdipCreatePen2 should make a copy of the brush.
by Alexandre Julliard 20 Jun '08

20 Jun '08

Module: wine Branch: master Commit: f1fae5ea487a84e5d841cdfc7204a29c1c1f1b31 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f1fae5ea487a84e5d841cdfc7… Author: Huw Davies <huw(a)codeweavers.com> Date: Thu Jun 19 12:16:20 2008 +0100 gdiplus: GdipCreatePen2 should make a copy of the brush. --- dlls/gdiplus/pen.c | 11 +++++++++-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/dlls/gdiplus/pen.c b/dlls/gdiplus/pen.c index 9ef1482..f6214f1 100644 --- a/dlls/gdiplus/pen.c +++ b/dlls/gdiplus/pen.c @@ -88,14 +88,19 @@ GpStatus WINGDIPAPI GdipCreatePen1(ARGB color, REAL width, GpUnit unit, GpPen **pen) { GpBrush *brush; + GpStatus status; + GdipCreateSolidFill(color, (GpSolidFill **)(&brush)); - return GdipCreatePen2(brush, width, unit, pen); + status = GdipCreatePen2(brush, width, unit, pen); + GdipDeleteBrush(brush); + return status; } GpStatus WINGDIPAPI GdipCreatePen2(GpBrush *brush, REAL width, GpUnit unit, GpPen **pen) { GpPen *gp_pen; + GpBrush *clone_brush; if(!pen || !brush) return InvalidParameter; @@ -111,7 +116,6 @@ GpStatus WINGDIPAPI GdipCreatePen2(GpBrush *brush, REAL width, GpUnit unit, gp_pen->miterlimit = 10.0; gp_pen->dash = DashStyleSolid; gp_pen->offset = 0.0; - gp_pen->brush = brush; if(!((gp_pen->unit == UnitWorld) || (gp_pen->unit == UnitPixel))) { FIXME("UnitWorld, UnitPixel only supported units\n"); @@ -119,6 +123,9 @@ GpStatus WINGDIPAPI GdipCreatePen2(GpBrush *brush, REAL width, GpUnit unit, return NotImplemented; } + GdipCloneBrush(brush, &clone_brush); + gp_pen->brush = clone_brush; + *pen = gp_pen; return Ok;

1 0

Alexandre Julliard : kernel32: The first argument of GetBinaryType is a string.
by Alexandre Julliard 20 Jun '08

20 Jun '08

Module: wine Branch: master Commit: 122055effd33f54b467e5f4e1aeb01410a8e02b2 URL: http://source.winehq.org/git/wine.git/?a=commit;h=122055effd33f54b467e5f4e1… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Jun 20 09:38:33 2008 +0200 kernel32: The first argument of GetBinaryType is a string. --- dlls/kernel32/kernel32.spec | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/kernel32/kernel32.spec b/dlls/kernel32/kernel32.spec index 2f591c2..1a18899 100644 --- a/dlls/kernel32/kernel32.spec +++ b/dlls/kernel32/kernel32.spec @@ -415,9 +415,9 @@ @ stdcall GetACP() @ stdcall GetAtomNameA(long ptr long) @ stdcall GetAtomNameW(long ptr long) -@ stdcall GetBinaryType(ptr ptr) GetBinaryTypeA -@ stdcall GetBinaryTypeA(ptr ptr) -@ stdcall GetBinaryTypeW(ptr ptr) +@ stdcall GetBinaryType(str ptr) GetBinaryTypeA +@ stdcall GetBinaryTypeA(str ptr) +@ stdcall GetBinaryTypeW(wstr ptr) # @ stub GetCPFileNameFromRegistry @ stdcall GetCPInfo(long ptr) @ stdcall GetCPInfoExA(long long ptr)

1 0

Francois Gouget : Assorted spelling fixes.
by Jeremy Newman 19 Jun '08

19 Jun '08

Module: website Branch: master Commit: 9c437a28b8b9b534d1a60dbd93e66152b6b9c838 URL: http://source.winehq.org/git/website.git/?a=commit;h=9c437a28b8b9b534d1a60d… Author: Francois Gouget <fgouget(a)free.fr> Date: Thu Jun 19 17:16:15 2008 +0200 Assorted spelling fixes. --- wwn/en/wn19990627_2.xml | 4 ++-- wwn/en/wn19990718_4.xml | 4 ++-- wwn/en/wn20000605_46.xml | 2 +- wwn/en/wn20001106_68.xml | 2 +- wwn/en/wn20010718_100.xml | 2 +- wwn/en/wn20011021_106.xml | 2 +- wwn/en/wn20020308_117.xml | 2 +- wwn/en/wn20030103_151.xml | 6 +++--- wwn/en/wn20030228_159.xml | 2 +- wwn/en/wn20030725_180.xml | 2 +- wwn/en/wn20030829_185.xml | 4 ++-- wwn/en/wn20041022_245.xml | 4 ++-- wwn/en/wn20041126_250.xml | 2 +- wwn/en/wn20050415_270.xml | 2 +- wwn/en/wn20050819_288.xml | 2 +- wwn/en/wn20051014_294.xml | 2 +- wwn/en/wn20051125_299.xml | 2 +- wwn/en/wn20060226_306.xml | 2 +- wwn/en/wn20060410_311.xml | 2 +- wwn/en/wn20060428_312.xml | 4 ++-- wwn/en/wn20070416_329.xml | 2 +- 21 files changed, 28 insertions(+), 28 deletions(-) Diff: http://source.winehq.org/git/website.git/?a=commitdiff;h=9c437a28b8b9b534d1…

1 0

Francois Gouget : index: Fix the Wine-Reviews link
by Jeremy Newman 19 Jun '08

19 Jun '08

Module: appdb Branch: master Commit: 0373d15ce396a988819668b767341109e3fc2b6d URL: http://source.winehq.org/git/appdb.git/?a=commit;h=0373d15ce396a988819668b7… Author: Francois Gouget <fgouget(a)free.fr> Date: Thu Jun 19 10:33:44 2008 -0500 index: Fix the Wine-Reviews link --- index.php | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/index.php b/index.php index e5b75f9..27c0e9d 100644 --- a/index.php +++ b/index.php @@ -149,7 +149,7 @@ if(!$_SESSION['current']->isLoggedIn()) <h2>Other Wine Application Compatibility Sites</h2> -<a href="http://wine-review.blogspot.com/">Wine-Review</a>: Is a Wine application and game +<a href="http://www.wine-reviews.net/">Wine-Reviews</a>: Is a Wine application and game Blog, with tips and how-to's on getting listed applications and games to run. </div>

1 0

Zachary Goldberg : WWN 348
by Jeremy Newman 19 Jun '08

19 Jun '08

Module: website Branch: master Commit: ac562257115cd20e66b3730ef23e6679f69e2540 URL: http://source.winehq.org/git/website.git/?a=commit;h=ac562257115cd20e66b373… Author: Zachary Goldberg <zgold(a)bluesata.com> Date: Wed Jun 18 20:02:03 2008 -0400 WWN 348 Wine 1.0 Edition --Zach >From 7ad40058ad55d7631f912e9b0cf74e35110826c2 Mon Sep 17 00:00:00 2001 From: Zachary Goldberg <zgs(a)seas.upenn.edu> Date: Wed, 18 Jun 2008 20:00:50 -0400 Subject: [WineHQ][WWN] WWN 348 To: wine-patches <wine-patches(a)winehq.org>, Jeremy Newman <jnewman(a)codeweavers.com> Wine 1.0 Edition --- news/en/2008061801.xml | 7 + wwn/en/wn20080618_348.xml | 7189 +++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 7196 insertions(+), 0 deletions(-) Diff: http://source.winehq.org/git/website.git/?a=commitdiff;h=ac562257115cd20e66…

1 0

Francois Gouget : Assorted spelling fixes.
by Jeremy Newman 19 Jun '08

19 Jun '08

Module: website Branch: master Commit: 5f19dab21b6f2e93e5854e1a8630b162e50cc1c7 URL: http://source.winehq.org/git/website.git/?a=commit;h=5f19dab21b6f2e93e5854e… Author: Francois Gouget <fgouget(a)free.fr> Date: Thu Jun 19 11:16:53 2008 +0200 Assorted spelling fixes. --- wwn/en/wn20010319_87.xml | 2 +- wwn/en/wn20010816_102.xml | 2 +- wwn/en/wn20011212_110.xml | 2 +- wwn/en/wn20021011_139.xml | 2 +- wwn/en/wn20030117_153.xml | 2 +- wwn/en/wn20050506_273.xml | 4 ++-- 6 files changed, 7 insertions(+), 7 deletions(-) diff --git a/wwn/en/wn20010319_87.xml b/wwn/en/wn20010319_87.xml index b068ae3..cd89182 100644 --- a/wwn/en/wn20010319_87.xml +++ b/wwn/en/wn20010319_87.xml @@ -165,7 +165,7 @@ interest. It was something quick and dirty to solve a specific problem, so I did not submit it for inclusion into wine. I originally did use a keyboard interface, but needed something extensible allowing for more than just dumping a window list, hence went to more of a -programatic interface. +programmatic interface. diff --git a/wwn/en/wn20010816_102.xml b/wwn/en/wn20010816_102.xml index 1d7e2a8..641fd15 100644 --- a/wwn/en/wn20010816_102.xml +++ b/wwn/en/wn20010816_102.xml @@ -208,7 +208,7 @@ of the code. He wrote: <quote who="Phillip Schmitz"> I've read most of the developer docs and some relevant source but I'm still having problems grokking the interrelationships between different parts of wine and the role(s) of wineserver. -I have a general understanding of Win32 from a programatic point of view rather than wine's +I have a general understanding of Win32 from a programmatic point of view rather than wine's implementation details. While I'm quite willing to "read the source" there's rather a lot of it :) and rather deep dependencies (even with tags one jumps around for a while trying to understand what does what). diff --git a/wwn/en/wn20011212_110.xml b/wwn/en/wn20011212_110.xml index c8e18c3..42e1ee9 100644 --- a/wwn/en/wn20011212_110.xml +++ b/wwn/en/wn20011212_110.xml @@ -613,7 +613,7 @@ now. Actually, I just download from cvs randomly, and see what happens. It's been a while, but I decided to try again in October. At that time, there was an OLE error, but the only other strange -occurance was a 'locking' of the screen on a print preview. +occurence was a 'locking' of the screen on a print preview. Since then, this 'locking' is the only issue (though I haven't yet attempted to print). diff --git a/wwn/en/wn20021011_139.xml b/wwn/en/wn20021011_139.xml index 7b62516..5db8b67 100644 --- a/wwn/en/wn20021011_139.xml +++ b/wwn/en/wn20021011_139.xml @@ -322,7 +322,7 @@ for the new framework with some actual tests. <topic>Internationalization</topic> Steve Lustbader posted a patch to implement <code>GetUserDefaultUILanguage</code> and -<code>GetSytemDefaultUILanguage</code> but wasn't +<code>GetSystemDefaultUILanguage</code> but wasn't sure of the details of using them: <quote who="Steve Lustbader"> I implemented these functions in codepage.c since similar functions diff --git a/wwn/en/wn20030117_153.xml b/wwn/en/wn20030117_153.xml index 1083013..b8901b3 100644 --- a/wwn/en/wn20030117_153.xml +++ b/wwn/en/wn20030117_153.xml @@ -766,7 +766,7 @@ not to use that as a guide. Ever. <section title="NTFS Filesystem Type" - subject="Add filesytem type NTFS to config" + subject="Add filesystem type NTFS to config" archive="http://www.winehq.org/hypermail/wine-patches/2003/01/0217.html" posts="14" startdate="13 Jan 2003 00:00:00 -0800" diff --git a/wwn/en/wn20050506_273.xml b/wwn/en/wn20050506_273.xml index 00bc0c1..70b7197 100644 --- a/wwn/en/wn20050506_273.xml +++ b/wwn/en/wn20050506_273.xml @@ -354,14 +354,14 @@ window initialization code, etc that goes on inside DialogBoxParam, and I'd need to handle all of that, I think. There even appears to be issues with 16 vs 32 bit handler addresses, etc. Looks really ugly. -Is there a simpler way to programatically click "Ok" on a dialog box? +Is there a simpler way to programmatically click "Ok" on a dialog box? (The dialog box coming from code that I don't have source for...) </quote> Shachar Shemesh suggested: <quote who="Shachar Shemesh"> For simple things, merely sending the dialog a WM_COMMAND with the right -parameters will do it for you. You can programatically find the dialog +parameters will do it for you. You can programmatically find the dialog using "FindWindow". I've done such things before. For simple things, this works very well.

1 0

Francois Gouget : Fix the link to Wine-Reviews
by Jeremy Newman 19 Jun '08

19 Jun '08

Module: website Branch: master Commit: a566330f95863dbab92f860dcf580a7c5d206126 URL: http://source.winehq.org/git/website.git/?a=commit;h=a566330f95863dbab92f86… Author: Francois Gouget <fgouget(a)free.fr> Date: Thu Jun 19 10:11:34 2008 +0200 Fix the link to Wine-Reviews --- templates/en/screenshots.template | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/templates/en/screenshots.template b/templates/en/screenshots.template index e8fd662..8c7fd9d 100644 --- a/templates/en/screenshots.template +++ b/templates/en/screenshots.template @@ -57,7 +57,7 @@ Links to other Screenshots <ul> <li> Browse the <a href="http://appdb.winehq.org">Wine Application Database</a> - <li> Wine-Review <a href="http://wine-review.blogspot.com/">Wine Screenshots and Screencast</a> + <li> Wine-Reviews <a href="http://www.wine-reviews.net/">Wine Screenshots and Screencast</a> <li> Nathan Lineback's <a href="http://toastytech.com/guis/wine.html">Wine Screen Shots</a> <li> Thomas Elger's <a href="http://www.nek.lu.se/nektel/gif/wine.htm">Wine Screenshots</a> <li> Andreas Mohr's <a href="http://home.nexgo.de/andi.mohr/wineshots/">miscellaneous screenshots</a>

1 0

Andrew Talbot : advpack: Constify some variables.
by Alexandre Julliard 19 Jun '08

19 Jun '08

Module: wine Branch: master Commit: 84ee90dcb547f3ecc85df6c60a92c11b97abc761 URL: http://source.winehq.org/git/wine.git/?a=commit;h=84ee90dcb547f3ecc85df6c60… Author: Andrew Talbot <andrew.talbot(a)talbotville.com> Date: Wed Jun 18 23:32:00 2008 +0100 advpack: Constify some variables. --- dlls/advpack/files.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/advpack/files.c b/dlls/advpack/files.c index 5003239..5e9ce30 100644 --- a/dlls/advpack/files.c +++ b/dlls/advpack/files.c @@ -996,8 +996,8 @@ HRESULT WINAPI GetVersionFromFileExW(LPCWSTR lpszFilename, LPDWORD pdwMSVer, BOOL bFileCopied = FALSE; UINT uValueLen; - static WCHAR backslash[] = {'\\',0}; - static WCHAR translation[] = { + static const WCHAR backslash[] = {'\\',0}; + static const WCHAR translation[] = { '\\','V','a','r','F','i','l','e','I','n','f','o', '\\','T','r','a','n','s','l','a','t','i','o','n',0 };

1 0