September 2008 - Wine-commits

Jacek Caban : jscript: Added string to object conversion implementation.
by Alexandre Julliard 16 Sep '08

16 Sep '08

Module: wine Branch: master Commit: 9a752be1a799563e0790d2203917434c6d5ecea1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=9a752be1a799563e0790d2203… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Sep 15 20:40:34 2008 +0200 jscript: Added string to object conversion implementation. --- dlls/jscript/jscript.h | 1 + dlls/jscript/jsutils.c | 11 +++++++++++ dlls/jscript/string.c | 43 ++++++++++++++++++++++++++++++++++++++----- dlls/jscript/tests/lang.js | 3 +++ 4 files changed, 53 insertions(+), 5 deletions(-) diff --git a/dlls/jscript/jscript.h b/dlls/jscript/jscript.h index 8e6fe3c..c4e61d6 100644 --- a/dlls/jscript/jscript.h +++ b/dlls/jscript/jscript.h @@ -133,6 +133,7 @@ HRESULT create_object(script_ctx_t*,DispatchEx*,DispatchEx**); HRESULT create_math(script_ctx_t*,DispatchEx**); HRESULT create_array(script_ctx_t*,DWORD,DispatchEx**); HRESULT create_regexp_str(script_ctx_t*,const WCHAR*,DWORD,const WCHAR*,DWORD,DispatchEx**); +HRESULT create_string(script_ctx_t*,const WCHAR*,DWORD,DispatchEx**); HRESULT to_primitive(script_ctx_t*,VARIANT*,jsexcept_t*,VARIANT*); HRESULT to_boolean(VARIANT*,VARIANT_BOOL*); diff --git a/dlls/jscript/jsutils.c b/dlls/jscript/jsutils.c index ae39218..2b0c31e 100644 --- a/dlls/jscript/jsutils.c +++ b/dlls/jscript/jsutils.c @@ -17,6 +17,7 @@ */ #include "jscript.h" +#include "engine.h" #include "wine/debug.h" @@ -248,7 +249,17 @@ HRESULT to_string(script_ctx_t *ctx, VARIANT *v, jsexcept_t *ei, BSTR *str) /* ECMA-262 3rd Edition 9.9 */ HRESULT to_object(exec_ctx_t *ctx, VARIANT *v, IDispatch **disp) { + DispatchEx *dispex; + HRESULT hres; + switch(V_VT(v)) { + case VT_BSTR: + hres = create_string(ctx->parser->script, V_BSTR(v), SysStringLen(V_BSTR(v)), &dispex); + if(FAILED(hres)) + return hres; + + *disp = (IDispatch*)_IDispatchEx_(dispex); + break; case VT_DISPATCH: IDispatch_AddRef(V_DISPATCH(v)); *disp = V_DISPATCH(v); diff --git a/dlls/jscript/string.c b/dlls/jscript/string.c index 26623ca..033e906 100644 --- a/dlls/jscript/string.c +++ b/dlls/jscript/string.c @@ -24,6 +24,9 @@ WINE_DEFAULT_DEBUG_CHANNEL(jscript); typedef struct { DispatchEx dispex; + + WCHAR *str; + DWORD length; } StringInstance; static const WCHAR lengthW[] = {'l','e','n','g','t','h',0}; @@ -64,11 +67,6 @@ static const WCHAR propertyIsEnumerableW[] = {'p','r','o','p','e','r','t','y','I','s','E','n','u','m','e','r','a','b','l','e',0}; static const WCHAR isPrototypeOfW[] = {'i','s','P','r','o','t','o','t','y','p','e','O','f',0}; -static void String_destructor(DispatchEx *dispex) -{ - FIXME("\n"); -} - static HRESULT String_length(DispatchEx *dispex, LCID lcid, WORD flags, DISPPARAMS *dp, VARIANT *retv, jsexcept_t *ei, IServiceProvider *sp) { @@ -328,6 +326,14 @@ static HRESULT String_value(DispatchEx *dispex, LCID lcid, WORD flags, DISPPARAM return E_NOTIMPL; } +static void String_destructor(DispatchEx *dispex) +{ + StringInstance *This = (StringInstance*)dispex; + + heap_free(This->str); + heap_free(This); +} + static const builtin_prop_t String_props[] = { {anchorW, String_anchor, PROPF_METHOD}, {bigW, String_big, PROPF_METHOD}, @@ -419,3 +425,30 @@ HRESULT create_string_constr(script_ctx_t *ctx, DispatchEx **ret) jsdisp_release(&string->dispex); return hres; } + +HRESULT create_string(script_ctx_t *ctx, const WCHAR *str, DWORD len, DispatchEx **ret) +{ + StringInstance *string; + HRESULT hres; + + hres = string_alloc(ctx, TRUE, &string); + if(FAILED(hres)) + return hres; + + if(len == -1) + len = strlenW(str); + + string->length = len; + string->str = heap_alloc((len+1)*sizeof(WCHAR)); + if(!string->str) { + jsdisp_release(&string->dispex); + return E_OUTOFMEMORY; + } + + memcpy(string->str, str, len*sizeof(WCHAR)); + string->str[len] = 0; + + *ret = &string->dispex; + return S_OK; + +} diff --git a/dlls/jscript/tests/lang.js b/dlls/jscript/tests/lang.js index fef8403..7a4e4cd 100644 --- a/dlls/jscript/tests/lang.js +++ b/dlls/jscript/tests/lang.js @@ -233,4 +233,7 @@ ok(tmp === 2, "incremented tmp(1) is not 2"); ok(tmp-- === 2, "tmp-- (2) is not 2"); ok(tmp === 1, "decremented tmp is not 1"); +String.prototype.test = true; +ok("".test === true, "\"\",test is not true"); + reportSuccess();

1 0

Jacek Caban : jscript: Added String.match implementation.
by Alexandre Julliard 16 Sep '08

16 Sep '08

Module: wine Branch: master Commit: db69b121ac6e3306d95911c00b18fc1c7c4f5b67 URL: http://source.winehq.org/git/wine.git/?a=commit;h=db69b121ac6e3306d95911c00… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Sep 15 20:41:04 2008 +0200 jscript: Added String.match implementation. RegExp part of patch is based on Mozilla regexp implementation. --- dlls/jscript/jscript.h | 7 ++ dlls/jscript/regexp.c | 151 ++++++++++++++++++++++++++++++++++++++++++++++++ dlls/jscript/string.c | 73 ++++++++++++++++++++++- 3 files changed, 229 insertions(+), 2 deletions(-) diff --git a/dlls/jscript/jscript.h b/dlls/jscript/jscript.h index c4e61d6..a098b82 100644 --- a/dlls/jscript/jscript.h +++ b/dlls/jscript/jscript.h @@ -184,6 +184,13 @@ HRESULT create_object_constr(script_ctx_t*,DispatchEx**); HRESULT create_regexp_constr(script_ctx_t*,DispatchEx**); HRESULT create_string_constr(script_ctx_t*,DispatchEx**); +typedef struct { + const WCHAR *str; + DWORD len; +} match_result_t; + +HRESULT regexp_match(DispatchEx*,const WCHAR*,DWORD,BOOL,match_result_t**,DWORD*); + static inline VARIANT *get_arg(DISPPARAMS *dp, DWORD i) { return dp->rgvarg + dp->cArgs-i-1; diff --git a/dlls/jscript/regexp.c b/dlls/jscript/regexp.c index f6fbec3..e8e9bea 100644 --- a/dlls/jscript/regexp.c +++ b/dlls/jscript/regexp.c @@ -3116,6 +3116,79 @@ good: return x; } +static REMatchState *MatchRegExp(REGlobalData *gData, REMatchState *x) +{ + REMatchState *result; + const WCHAR *cp = x->cp; + const WCHAR *cp2; + UINT j; + + /* + * Have to include the position beyond the last character + * in order to detect end-of-input/line condition. + */ + for (cp2 = cp; cp2 <= gData->cpend; cp2++) { + gData->skipped = cp2 - cp; + x->cp = cp2; + for (j = 0; j < gData->regexp->parenCount; j++) + x->parens[j].index = -1; + result = ExecuteREBytecode(gData, x); + if (!gData->ok || result || (gData->regexp->flags & JSREG_STICKY)) + return result; + gData->backTrackSP = gData->backTrackStack; + gData->cursz = 0; + gData->stateStackTop = 0; + cp2 = cp + gData->skipped; + } + return NULL; +} + +#define MIN_BACKTRACK_LIMIT 400000 + +static REMatchState *InitMatch(script_ctx_t *cx, REGlobalData *gData, JSRegExp *re, size_t length) +{ + REMatchState *result; + UINT i; + + gData->backTrackStackSize = INITIAL_BACKTRACK; + gData->backTrackStack = jsheap_alloc(gData->pool, INITIAL_BACKTRACK); + if (!gData->backTrackStack) + goto bad; + + gData->backTrackSP = gData->backTrackStack; + gData->cursz = 0; + gData->backTrackCount = 0; + gData->backTrackLimit = 0; + + gData->stateStackLimit = INITIAL_STATESTACK; + gData->stateStack = jsheap_alloc(gData->pool, sizeof(REProgState) * INITIAL_STATESTACK); + if (!gData->stateStack) + goto bad; + + gData->stateStackTop = 0; + gData->cx = cx; + gData->regexp = re; + gData->ok = TRUE; + + result = jsheap_alloc(gData->pool, offsetof(REMatchState, parens) + re->parenCount * sizeof(RECapture)); + if (!result) + goto bad; + + for (i = 0; i < re->classCount; i++) { + if (!re->classList[i].converted && + !ProcessCharSet(gData, &re->classList[i])) { + return NULL; + } + } + + return result; + +bad: + js_ReportOutOfScriptQuota(cx); + gData->ok = FALSE; + return NULL; +} + static void js_DestroyRegExp(JSRegExp *re) { @@ -3224,6 +3297,84 @@ out: return re; } +HRESULT regexp_match(DispatchEx *dispex, const WCHAR *str, DWORD len, BOOL gflag, match_result_t **match_result, + DWORD *result_cnt) +{ + RegExpInstance *This = (RegExpInstance*)dispex; + match_result_t *ret = NULL; + const WCHAR *cp = str; + REGlobalData gData; + REMatchState *x, *result; + DWORD matchlen; + DWORD i=0, ret_size = 0; + jsheap_t *mark; + size_t length; + HRESULT hres = E_FAIL; + + length = len; + + mark = jsheap_mark(&This->dispex.ctx->tmp_heap); + gData.pool = &This->dispex.ctx->tmp_heap; + + while(1) { + gData.cpbegin = cp; + gData.cpend = str + len; + gData.start = cp-str; + gData.skipped = 0; + + x = InitMatch(NULL, &gData, This->jsregexp, length); + if(!x) { + WARN("InitMatch failed\n"); + break; + } + + x->cp = cp; + result = MatchRegExp(&gData, x); + if(!gData.ok) { + WARN("MatchRegExp failed\n"); + break; + } + + if(!result) { + hres = S_OK; + break; + } + + matchlen = (result->cp-cp) - gData.skipped; + + if(ret) + ret = heap_realloc(ret, (ret_size <<= 1) * sizeof(match_result_t)); + else if(ret_size == i) + ret = heap_alloc((ret_size=4) * sizeof(match_result_t)); + if(!ret) { + hres = E_OUTOFMEMORY; + break; + } + + ret[i].str = result->cp-matchlen; + ret[i].len = matchlen; + + length -= result->cp-cp; + cp = result->cp; + i++; + + if(!gflag && !(This->jsregexp->flags & JSREG_GLOB)) { + hres = S_OK; + break; + } + } + + jsheap_clear(mark); + if(FAILED(hres)) { + heap_free(ret); + return hres; + } + + *match_result = ret; + *result_cnt = i; + return S_OK; +} + static HRESULT RegExp_source(DispatchEx *dispex, LCID lcid, WORD flags, DISPPARAMS *dp, VARIANT *retv, jsexcept_t *ei, IServiceProvider *sp) { diff --git a/dlls/jscript/string.c b/dlls/jscript/string.c index 033e906..b310cab 100644 --- a/dlls/jscript/string.c +++ b/dlls/jscript/string.c @@ -189,8 +189,77 @@ static HRESULT String_link(DispatchEx *dispex, LCID lcid, WORD flags, DISPPARAMS static HRESULT String_match(DispatchEx *dispex, LCID lcid, WORD flags, DISPPARAMS *dp, VARIANT *retv, jsexcept_t *ei, IServiceProvider *sp) { - FIXME("\n"); - return E_NOTIMPL; + StringInstance *This = (StringInstance*)dispex; + match_result_t *match_result; + DispatchEx *array; + VARIANT var, *arg_var; + DWORD match_cnt, i; + HRESULT hres = S_OK; + + TRACE("\n"); + + if(dp->cArgs - dp->cNamedArgs != 1) { + FIXME("unsupported args\n"); + return E_NOTIMPL; + } + + arg_var = get_arg(dp, 0); + switch(V_VT(arg_var)) { + case VT_DISPATCH: { + DispatchEx *regexp; + + regexp = iface_to_jsdisp((IUnknown*)V_DISPATCH(arg_var)); + if(regexp) { + if(regexp->builtin_info->class == JSCLASS_REGEXP) { + hres = regexp_match(regexp, This->str, This->length, FALSE, &match_result, &match_cnt); + jsdisp_release(regexp); + if(FAILED(hres)) + return hres; + break; + } + jsdisp_release(regexp); + } + } + default: + FIXME("implemented only for regexp args\n"); + return E_NOTIMPL; + } + + if(!match_cnt) { + TRACE("no match\n"); + + if(retv) + V_VT(retv) = VT_NULL; + return S_OK; + } + + hres = create_array(dispex->ctx, match_cnt, &array); + if(FAILED(hres)) + return hres; + + V_VT(&var) = VT_BSTR; + + for(i=0; i < match_cnt; i++) { + V_BSTR(&var) = SysAllocStringLen(match_result[i].str, match_result[i].len); + if(!V_BSTR(&var)) { + hres = E_OUTOFMEMORY; + break; + } + + hres = jsdisp_propput_idx(array, i, lcid, &var, ei, NULL/*FIXME*/); + SysFreeString(V_BSTR(&var)); + if(FAILED(hres)) + break; + } + + if(FAILED(hres)) { + jsdisp_release(array); + return hres; + } + + V_VT(retv) = VT_DISPATCH; + V_DISPATCH(retv) = (IDispatch*)_IDispatchEx_(array); + return S_OK; } static HRESULT String_replace(DispatchEx *dispex, LCID lcid, WORD flags, DISPPARAMS *dp,

1 0

Jacek Caban : jscript: Added RegExp tests.
by Alexandre Julliard 16 Sep '08

16 Sep '08

Module: wine Branch: master Commit: 4b9bc9816b268f855fa25524f0b20a94062385b0 URL: http://source.winehq.org/git/wine.git/?a=commit;h=4b9bc9816b268f855fa25524f… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Sep 15 20:41:23 2008 +0200 jscript: Added RegExp tests. --- dlls/jscript/tests/regexp.js | 54 ++++++++++++++++++++++++++++++++++++++++++ dlls/jscript/tests/rsrc.rc | 3 ++ dlls/jscript/tests/run.c | 1 + 3 files changed, 58 insertions(+), 0 deletions(-) diff --git a/dlls/jscript/tests/regexp.js b/dlls/jscript/tests/regexp.js new file mode 100644 index 0000000..209ee22 --- /dev/null +++ b/dlls/jscript/tests/regexp.js @@ -0,0 +1,54 @@ +/* + * Copyright 2008 Jacek Caban for CodeWeavers + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + + +var m; + +m = "abcabc".match(/ca/); +ok(typeof(m) === "object", "typeof m is not object"); +ok(m.length === 1, "m.length is not 1"); +ok(m["0"] === "ca", "m[0] is not \"ca\""); + +m = "abcabc".match(/ab/); +ok(typeof(m) === "object", "typeof m is not object"); +ok(m.length === 1, "m.length is not 1"); +ok(m["0"] === "ab", "m[0] is not \"ab\""); + +m = "abcabc".match(/ab/g); +ok(typeof(m) === "object", "typeof m is not object"); +ok(m.length === 2, "m.length is not 1"); +ok(m["0"] === "ab", "m[0] is not \"ab\""); +ok(m["1"] === "ab", "m[1] is not \"ab\""); + +m = "abcabc".match(/Ab/g); +ok(typeof(m) === "object", "typeof m is not object"); +ok(m === null, "m is not null"); + +m = "abcabc".match(/Ab/gi); +ok(typeof(m) === "object", "typeof m is not object"); +ok(m.length === 2, "m.length is not 1"); +ok(m["0"] === "ab", "m[0] is not \"ab\""); +ok(m["1"] === "ab", "m[1] is not \"ab\""); + +m = "aaabcabc".match(/a+b/g); +ok(typeof(m) === "object", "typeof m is not object"); +ok(m.length === 2, "m.length is not 1"); +ok(m["0"] === "aaab", "m[0] is not \"ab\""); +ok(m["1"] === "ab", "m[1] is not \"ab\""); + +reportSuccess(); diff --git a/dlls/jscript/tests/rsrc.rc b/dlls/jscript/tests/rsrc.rc index 407ef2c..ecb4212 100644 --- a/dlls/jscript/tests/rsrc.rc +++ b/dlls/jscript/tests/rsrc.rc @@ -21,3 +21,6 @@ api.js 40 "api.js" /* @makedep: lang.js */ lang.js 40 "lang.js" + +/* @makedep: regexp.js */ +regexp.js 40 "regexp.js" diff --git a/dlls/jscript/tests/run.c b/dlls/jscript/tests/run.c index e4ecbd7..29947fe 100644 --- a/dlls/jscript/tests/run.c +++ b/dlls/jscript/tests/run.c @@ -583,6 +583,7 @@ static void run_tests(void) run_from_res("lang.js"); run_from_res("api.js"); + run_from_res("regexp.js"); } START_TEST(run)

1 0

Jacek Caban : jscript: Reuse temporary heap.
by Alexandre Julliard 16 Sep '08

16 Sep '08

Module: wine Branch: master Commit: 4ac24dc2bf9dc6cf783405968162461867a36aeb URL: http://source.winehq.org/git/wine.git/?a=commit;h=4ac24dc2bf9dc6cf783405968… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Sep 15 20:38:46 2008 +0200 jscript: Reuse temporary heap. --- dlls/jscript/engine.h | 3 +-- dlls/jscript/jscript.c | 2 ++ dlls/jscript/jscript.h | 31 ++++++++++++++++++------------- dlls/jscript/jsutils.c | 25 +++++++++++++++++++++++++ dlls/jscript/parser.y | 5 +++-- 5 files changed, 49 insertions(+), 17 deletions(-) diff --git a/dlls/jscript/engine.h b/dlls/jscript/engine.h index 0d75716..c37bc24 100644 --- a/dlls/jscript/engine.h +++ b/dlls/jscript/engine.h @@ -35,7 +35,6 @@ typedef struct _parser_ctx_t { BOOL nl; HRESULT hres; - jsheap_t tmp_heap; jsheap_t heap; obj_literal_t *obj_literals; @@ -60,7 +59,7 @@ static inline void *parser_alloc(parser_ctx_t *ctx, DWORD size) static inline void *parser_alloc_tmp(parser_ctx_t *ctx, DWORD size) { - return jsheap_alloc(&ctx->tmp_heap, size); + return jsheap_alloc(&ctx->script->tmp_heap, size); } typedef struct _scope_chain_t { diff --git a/dlls/jscript/jscript.c b/dlls/jscript/jscript.c index 899f59d..7c7def0 100644 --- a/dlls/jscript/jscript.c +++ b/dlls/jscript/jscript.c @@ -54,6 +54,7 @@ void script_release(script_ctx_t *ctx) if(--ctx->ref) return; + jsheap_free(&ctx->tmp_heap); heap_free(ctx); } @@ -507,6 +508,7 @@ static HRESULT WINAPI JScriptParse_InitNew(IActiveScriptParse *iface) ctx->ref = 1; ctx->state = SCRIPTSTATE_UNINITIALIZED; + jsheap_init(&ctx->tmp_heap); ctx = InterlockedCompareExchangePointer((void**)&This->ctx, ctx, NULL); if(ctx) { diff --git a/dlls/jscript/jscript.h b/dlls/jscript/jscript.h index ec42011..8e6fe3c 100644 --- a/dlls/jscript/jscript.h +++ b/dlls/jscript/jscript.h @@ -40,6 +40,22 @@ typedef struct { VARIANT var; } jsexcept_t; +typedef struct { + void **blocks; + DWORD block_cnt; + DWORD last_block; + DWORD offset; + BOOL mark; + struct list custom_blocks; +} jsheap_t; + +void jsheap_init(jsheap_t*); +void *jsheap_alloc(jsheap_t*,DWORD); +void *jsheap_grow(jsheap_t*,void*,DWORD,DWORD); +void jsheap_clear(jsheap_t*); +void jsheap_free(jsheap_t*); +jsheap_t *jsheap_mark(jsheap_t*); + typedef struct DispatchEx DispatchEx; #define PROPF_ARGMASK 0x00ff @@ -139,6 +155,8 @@ struct _script_ctx_t { named_item_t *named_items; LCID lcid; + jsheap_t tmp_heap; + DispatchEx *script_disp; DispatchEx *global; DispatchEx *array_constr; @@ -179,19 +197,6 @@ const char *debugstr_variant(const VARIANT*); HRESULT WINAPI JScriptFactory_CreateInstance(IClassFactory*,IUnknown*,REFIID,void**); -typedef struct { - void **blocks; - DWORD block_cnt; - DWORD last_block; - DWORD offset; - struct list custom_blocks; -} jsheap_t; - -void jsheap_init(jsheap_t*); -void *jsheap_alloc(jsheap_t*,DWORD); -void jsheap_clear(jsheap_t*); -void jsheap_free(jsheap_t*); - extern LONG module_ref; static inline void lock_module(void) diff --git a/dlls/jscript/jsutils.c b/dlls/jscript/jsutils.c index a193b9e..ae39218 100644 --- a/dlls/jscript/jsutils.c +++ b/dlls/jscript/jsutils.c @@ -110,14 +110,30 @@ void *jsheap_alloc(jsheap_t *heap, DWORD size) return list+1; } +void *jsheap_grow(jsheap_t *heap, void *mem, DWORD size, DWORD inc) +{ + if(mem == (BYTE*)heap->blocks[heap->last_block] + heap->offset-size + && heap->offset+inc < block_size(heap->last_block)) { + heap->offset += inc; + return mem; + } + + return jsheap_alloc(heap, size+inc); +} + void jsheap_clear(jsheap_t *heap) { struct list *tmp; + if(!heap) + return; + while((tmp = list_next(&heap->custom_blocks, &heap->custom_blocks))) { list_remove(tmp); heap_free(tmp); } + + heap->last_block = heap->offset = 0; } void jsheap_free(jsheap_t *heap) @@ -133,6 +149,15 @@ void jsheap_free(jsheap_t *heap) jsheap_init(heap); } +jsheap_t *jsheap_mark(jsheap_t *heap) +{ + if(heap->mark) + return NULL; + + heap->mark = TRUE; + return heap; +} + /* ECMA-262 3rd Edition 9.1 */ HRESULT to_primitive(script_ctx_t *ctx, VARIANT *v, jsexcept_t *ei, VARIANT *ret) { diff --git a/dlls/jscript/parser.y b/dlls/jscript/parser.y index ec5f4bd..f721a8e 100644 --- a/dlls/jscript/parser.y +++ b/dlls/jscript/parser.y @@ -1525,6 +1525,7 @@ void parser_release(parser_ctx_t *ctx) HRESULT script_parse(script_ctx_t *ctx, const WCHAR *code, parser_ctx_t **ret) { parser_ctx_t *parser_ctx; + jsheap_t *mark; HRESULT hres; parser_ctx = heap_alloc_zero(sizeof(parser_ctx_t)); @@ -1540,11 +1541,11 @@ HRESULT script_parse(script_ctx_t *ctx, const WCHAR *code, parser_ctx_t **ret) script_addref(ctx); parser_ctx->script = ctx; - jsheap_init(&parser_ctx->tmp_heap); + mark = jsheap_mark(&ctx->tmp_heap); jsheap_init(&parser_ctx->heap); parser_parse(parser_ctx); - jsheap_free(&parser_ctx->tmp_heap); + jsheap_clear(mark); if(FAILED(parser_ctx->hres)) { hres = parser_ctx->hres; parser_release(parser_ctx);

1 0

Jacek Caban : jscript: Added parser support for regular expressions.
by Alexandre Julliard 16 Sep '08

16 Sep '08

Module: wine Branch: master Commit: cf1863ed09d2e2930b873f75c9aa696883a48237 URL: http://source.winehq.org/git/wine.git/?a=commit;h=cf1863ed09d2e2930b873f75c… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Sep 15 20:38:18 2008 +0200 jscript: Added parser support for regular expressions. --- dlls/jscript/engine.h | 9 +++++++++ dlls/jscript/jscript.h | 1 + dlls/jscript/lex.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++ dlls/jscript/parser.y | 8 +++++++- dlls/jscript/regexp.c | 42 ++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 105 insertions(+), 1 deletions(-) diff --git a/dlls/jscript/engine.h b/dlls/jscript/engine.h index 57a68c2..0d75716 100644 --- a/dlls/jscript/engine.h +++ b/dlls/jscript/engine.h @@ -18,6 +18,11 @@ typedef struct _source_elements_t source_elements_t; +typedef struct _obj_literal_t { + DispatchEx *obj; + struct _obj_literal_t *next; +} obj_literal_t; + typedef struct _parser_ctx_t { LONG ref; @@ -33,6 +38,8 @@ typedef struct _parser_ctx_t { jsheap_t tmp_heap; jsheap_t heap; + obj_literal_t *obj_literals; + struct _parser_ctx_t *next; } parser_ctx_t; @@ -105,6 +112,8 @@ typedef struct { } u; } literal_t; +literal_t *parse_regexp(parser_ctx_t*); + typedef struct _variable_declaration_t { const WCHAR *identifier; expression_t *expr; diff --git a/dlls/jscript/jscript.h b/dlls/jscript/jscript.h index a3c5c0a..ec42011 100644 --- a/dlls/jscript/jscript.h +++ b/dlls/jscript/jscript.h @@ -116,6 +116,7 @@ HRESULT create_builtin_function(script_ctx_t*,builtin_invoke_t,DWORD,DispatchEx* HRESULT create_object(script_ctx_t*,DispatchEx*,DispatchEx**); HRESULT create_math(script_ctx_t*,DispatchEx**); HRESULT create_array(script_ctx_t*,DWORD,DispatchEx**); +HRESULT create_regexp_str(script_ctx_t*,const WCHAR*,DWORD,const WCHAR*,DWORD,DispatchEx**); HRESULT to_primitive(script_ctx_t*,VARIANT*,jsexcept_t*,VARIANT*); HRESULT to_boolean(VARIANT*,VARIANT_BOOL*); diff --git a/dlls/jscript/lex.c b/dlls/jscript/lex.c index 8ae15d3..0aea118 100644 --- a/dlls/jscript/lex.c +++ b/dlls/jscript/lex.c @@ -684,3 +684,49 @@ int parser_lex(void *lval, parser_ctx_t *ctx) WARN("unexpected char '%c' %d\n", *ctx->ptr, *ctx->ptr); return 0; } + +static void add_object_literal(parser_ctx_t *ctx, DispatchEx *obj) +{ + obj_literal_t *literal = parser_alloc(ctx, sizeof(obj_literal_t)); + + literal->obj = obj; + literal->next = ctx->obj_literals; + ctx->obj_literals = literal; +} + +literal_t *parse_regexp(parser_ctx_t *ctx) +{ + const WCHAR *re, *flags; + DispatchEx *regexp; + literal_t *ret; + DWORD re_len; + HRESULT hres; + + TRACE("\n"); + + re = ctx->ptr; + while(ctx->ptr < ctx->end && (*ctx->ptr != '/' || *(ctx->ptr-1) == '\\')) + ctx->ptr++; + + if(ctx->ptr == ctx->end) { + WARN("unexpected end of file\n"); + return NULL; + } + + re_len = ctx->ptr-re; + + flags = ++ctx->ptr; + while(ctx->ptr < ctx->end && isalnumW(*ctx->ptr)) + ctx->ptr++; + + hres = create_regexp_str(ctx->script, re, re_len, flags, ctx->ptr-flags, &regexp); + if(FAILED(hres)) + return NULL; + + add_object_literal(ctx, regexp); + + ret = parser_alloc(ctx, sizeof(literal_t)); + ret->vt = VT_DISPATCH; + ret->u.disp = (IDispatch*)_IDispatchEx_(regexp); + return ret; +} diff --git a/dlls/jscript/parser.y b/dlls/jscript/parser.y index cc4ee7b..ec5f4bd 100644 --- a/dlls/jscript/parser.y +++ b/dlls/jscript/parser.y @@ -775,7 +775,8 @@ Literal | BooleanLiteral { $$ = $1; } | tNumericLiteral { $$ = $1; } | tStringLiteral { $$ = new_string_literal(ctx, $1); } - | '/' { FIXME("RegExp literal\n"); YYABORT; } + | '/' { $$ = parse_regexp(ctx); + if(!$$) YYABORT; } /* ECMA-262 3rd Edition 7.8.2 */ BooleanLiteral @@ -1509,9 +1510,14 @@ static void program_parsed(parser_ctx_t *ctx, source_elements_t *source) void parser_release(parser_ctx_t *ctx) { + obj_literal_t *iter; + if(--ctx->ref) return; + for(iter = ctx->obj_literals; iter; iter = iter->next) + jsdisp_release(iter->obj); + jsheap_free(&ctx->heap); heap_free(ctx); } diff --git a/dlls/jscript/regexp.c b/dlls/jscript/regexp.c index 88f7c3b..7c352ef 100644 --- a/dlls/jscript/regexp.c +++ b/dlls/jscript/regexp.c @@ -22,6 +22,11 @@ WINE_DEFAULT_DEBUG_CHANNEL(jscript); +#define JSREG_FOLD 0x01 /* fold uppercase to lowercase */ +#define JSREG_GLOB 0x02 /* global exec, creates array of matches */ +#define JSREG_MULTILINE 0x04 /* treat ^ and $ as begin and end of line */ +#define JSREG_STICKY 0x08 /* only match starting at lastIndex */ + typedef struct { DispatchEx dispex; } RegExpInstance; @@ -174,6 +179,12 @@ static HRESULT alloc_regexp(script_ctx_t *ctx, BOOL use_constr, RegExpInstance * return S_OK; } +static HRESULT create_regexp(script_ctx_t *ctx, const WCHAR *exp, int len, DWORD flags, DispatchEx **ret) +{ + FIXME("\n"); + return E_NOTIMPL; +} + static HRESULT RegExpConstr_value(DispatchEx *dispex, LCID lcid, WORD flags, DISPPARAMS *dp, VARIANT *retv, jsexcept_t *ei, IServiceProvider *sp) { @@ -195,3 +206,34 @@ HRESULT create_regexp_constr(script_ctx_t *ctx, DispatchEx **ret) jsdisp_release(&regexp->dispex); return hres; } + +HRESULT create_regexp_str(script_ctx_t *ctx, const WCHAR *exp, DWORD exp_len, const WCHAR *opt, + DWORD opt_len, DispatchEx **ret) +{ + const WCHAR *p; + DWORD flags = 0; + + if(opt) { + for (p = opt; p < opt+opt_len; p++) { + switch (*p) { + case 'g': + flags |= JSREG_GLOB; + break; + case 'i': + flags |= JSREG_FOLD; + break; + case 'm': + flags |= JSREG_MULTILINE; + break; + case 'y': + flags |= JSREG_STICKY; + break; + default: + WARN("wrong flag %c\n", *p); + return E_FAIL; + } + } + } + + return create_regexp(ctx, exp, exp_len, flags, ret); +}

1 0

Jacek Caban : jscript: Added ArrayInstance::on_put implementation.
by Alexandre Julliard 16 Sep '08

16 Sep '08

Module: wine Branch: master Commit: f2e7626c7a24c1c927b9469fa29cef55689ef894 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f2e7626c7a24c1c927b9469fa… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Sep 15 20:37:46 2008 +0200 jscript: Added ArrayInstance::on_put implementation. --- dlls/jscript/array.c | 18 +++++++++++++++++- dlls/jscript/tests/api.js | 3 +++ 2 files changed, 20 insertions(+), 1 deletions(-) diff --git a/dlls/jscript/array.c b/dlls/jscript/array.c index 65097be..c131865 100644 --- a/dlls/jscript/array.c +++ b/dlls/jscript/array.c @@ -194,7 +194,23 @@ static void Array_destructor(DispatchEx *dispex) static void Array_on_put(DispatchEx *dispex, const WCHAR *name) { - FIXME("\n"); + ArrayInstance *array = (ArrayInstance*)dispex; + const WCHAR *ptr = name; + DWORD id = 0; + + if(!isdigitW(*ptr)) + return; + + while(*ptr && isdigitW(*ptr)) { + id = id*10 + (*ptr-'0'); + ptr++; + } + + if(*ptr) + return; + + if(id >= array->length) + array->length = id+1; } static const builtin_prop_t Array_props[] = { diff --git a/dlls/jscript/tests/api.js b/dlls/jscript/tests/api.js index e874027..eed48dc 100644 --- a/dlls/jscript/tests/api.js +++ b/dlls/jscript/tests/api.js @@ -28,6 +28,9 @@ ok(arr["0"] === 1, "arr[0] is not 1"); ok(arr["1"] === 2, "arr[1] is not 2"); ok(arr["2"] === "test", "arr[2] is not \"test\""); +arr["7"] = true; +ok((arr.length === 8), "arr.length is not 8"); + var arr = new Array(6); ok(typeof(arr) === "object", "arr (6) is not object"); ok((arr.length === 6), "arr.length is not 6");

1 0

Jacek Caban : jscript: Added missing RegExp properties.
by Alexandre Julliard 16 Sep '08

16 Sep '08

Module: wine Branch: master Commit: 199952bf5590d1acff24445d6f9479aa8aa8b432 URL: http://source.winehq.org/git/wine.git/?a=commit;h=199952bf5590d1acff24445d6… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Sep 15 20:36:48 2008 +0200 jscript: Added missing RegExp properties. --- dlls/jscript/regexp.c | 54 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 54 insertions(+), 0 deletions(-) diff --git a/dlls/jscript/regexp.c b/dlls/jscript/regexp.c index 8bbaa6c..88f7c3b 100644 --- a/dlls/jscript/regexp.c +++ b/dlls/jscript/regexp.c @@ -26,12 +26,53 @@ typedef struct { DispatchEx dispex; } RegExpInstance; +static const WCHAR sourceW[] = {'s','o','u','r','c','e',0}; +static const WCHAR globalW[] = {'g','l','o','b','a','l',0}; +static const WCHAR ignoreCaseW[] = {'i','g','n','o','r','e','C','a','s','e',0}; +static const WCHAR multilineW[] = {'m','u','l','t','i','l','i','n','e',0}; +static const WCHAR lastIndexW[] = {'l','a','s','t','I','n','d','e','x',0}; static const WCHAR toStringW[] = {'t','o','S','t','r','i','n','g',0}; static const WCHAR toLocaleStringW[] = {'t','o','L','o','c','a','l','e','S','t','r','i','n','g',0}; static const WCHAR hasOwnPropertyW[] = {'h','a','s','O','w','n','P','r','o','p','e','r','t','y',0}; static const WCHAR propertyIsEnumerableW[] = {'p','r','o','p','e','r','t','y','I','s','E','n','u','m','e','r','a','b','l','e',0}; static const WCHAR isPrototypeOfW[] = {'i','s','P','r','o','t','o','t','y','p','e','O','f',0}; +static const WCHAR execW[] = {'e','x','e','c',0}; + +static HRESULT RegExp_source(DispatchEx *dispex, LCID lcid, WORD flags, DISPPARAMS *dp, + VARIANT *retv, jsexcept_t *ei, IServiceProvider *sp) +{ + FIXME("\n"); + return E_NOTIMPL; +} + +static HRESULT RegExp_global(DispatchEx *dispex, LCID lcid, WORD flags, DISPPARAMS *dp, + VARIANT *retv, jsexcept_t *ei, IServiceProvider *sp) +{ + FIXME("\n"); + return E_NOTIMPL; +} + +static HRESULT RegExp_ignoreCase(DispatchEx *dispex, LCID lcid, WORD flags, DISPPARAMS *dp, + VARIANT *retv, jsexcept_t *ei, IServiceProvider *sp) +{ + FIXME("\n"); + return E_NOTIMPL; +} + +static HRESULT RegExp_multiline(DispatchEx *dispex, LCID lcid, WORD flags, DISPPARAMS *dp, + VARIANT *retv, jsexcept_t *ei, IServiceProvider *sp) +{ + FIXME("\n"); + return E_NOTIMPL; +} + +static HRESULT RegExp_lastIndex(DispatchEx *dispex, LCID lcid, WORD flags, DISPPARAMS *dp, + VARIANT *retv, jsexcept_t *ei, IServiceProvider *sp) +{ + FIXME("\n"); + return E_NOTIMPL; +} static HRESULT RegExp_toString(DispatchEx *dispex, LCID lcid, WORD flags, DISPPARAMS *dp, VARIANT *retv, jsexcept_t *ei, IServiceProvider *sp) @@ -68,6 +109,13 @@ static HRESULT RegExp_isPrototypeOf(DispatchEx *dispex, LCID lcid, WORD flags, D return E_NOTIMPL; } +static HRESULT RegExp_exec(DispatchEx *dispex, LCID lcid, WORD flags, DISPPARAMS *dp, + VARIANT *retv, jsexcept_t *ei, IServiceProvider *sp) +{ + FIXME("\n"); + return E_NOTIMPL; +} + static HRESULT RegExp_value(DispatchEx *dispex, LCID lcid, WORD flags, DISPPARAMS *dp, VARIANT *retv, jsexcept_t *ei, IServiceProvider *sp) { @@ -81,9 +129,15 @@ static void RegExp_destructor(DispatchEx *dispex) } static const builtin_prop_t RegExp_props[] = { + {execW, RegExp_exec, PROPF_METHOD}, + {globalW, RegExp_global, 0}, {hasOwnPropertyW, RegExp_hasOwnProperty, PROPF_METHOD}, + {ignoreCaseW, RegExp_ignoreCase, 0}, {isPrototypeOfW, RegExp_isPrototypeOf, PROPF_METHOD}, + {lastIndexW, RegExp_lastIndex, 0}, + {multilineW, RegExp_multiline, 0}, {propertyIsEnumerableW, RegExp_propertyIsEnumerable, PROPF_METHOD}, + {sourceW, RegExp_source, 0}, {toLocaleStringW, RegExp_toLocaleString, PROPF_METHOD}, {toStringW, RegExp_toString, PROPF_METHOD} };

1 0

Nicolas Le Cam : comctl32/tests: Fix a failing test for some platforms.
by Alexandre Julliard 16 Sep '08

16 Sep '08

Module: wine Branch: master Commit: 47bcdc32a430e9940634b05a78c2c6af5f593026 URL: http://source.winehq.org/git/wine.git/?a=commit;h=47bcdc32a430e9940634b05a7… Author: Nicolas Le Cam <niko.lecam(a)gmail.com> Date: Mon Sep 15 20:24:46 2008 +0200 comctl32/tests: Fix a failing test for some platforms. --- dlls/comctl32/tests/trackbar.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/dlls/comctl32/tests/trackbar.c b/dlls/comctl32/tests/trackbar.c index d82cd98..00f7024 100644 --- a/dlls/comctl32/tests/trackbar.c +++ b/dlls/comctl32/tests/trackbar.c @@ -38,9 +38,9 @@ static const struct message create_parent_wnd_seq[] = { { WM_NCCREATE, sent }, { WM_NCCALCSIZE, sent|wparam, 0 }, { WM_CREATE, sent }, - { WM_QUERYNEWPALETTE, sent|optional }, { WM_SHOWWINDOW, sent|wparam, 1 }, { WM_WINDOWPOSCHANGING, sent|wparam, 0 }, + { WM_QUERYNEWPALETTE, sent|optional }, { WM_WINDOWPOSCHANGING, sent|wparam, 0 }, { WM_ACTIVATEAPP, sent|wparam, 1 }, { WM_NCACTIVATE, sent|wparam, 1 }, @@ -394,8 +394,9 @@ static LRESULT WINAPI parent_wnd_proc(HWND hwnd, UINT message, WPARAM wParam, LP LRESULT ret; struct message msg; - /* do not log painting messages */ - if (message != WM_PAINT && + /* log system messages, except for painting */ + if (message < WM_USER && + message != WM_PAINT && message != WM_ERASEBKGND && message != WM_NCPAINT && message != WM_NCHITTEST &&

1 0

Jacek Caban : jscript: Added Array constructor implementation.
by Alexandre Julliard 16 Sep '08

16 Sep '08

Module: wine Branch: master Commit: 9c25917e5d94fd89a192d23a42032ce3d0354be5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=9c25917e5d94fd89a192d23a4… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Sep 15 20:37:10 2008 +0200 jscript: Added Array constructor implementation. --- dlls/jscript/array.c | 69 ++++++++++++++++++++++++++++++++++++++++++-- dlls/jscript/jscript.h | 11 +++++++ dlls/jscript/tests/api.js | 33 +++++++++++++++++++++ dlls/jscript/tests/rsrc.rc | 3 ++ dlls/jscript/tests/run.c | 1 + 5 files changed, 114 insertions(+), 3 deletions(-) diff --git a/dlls/jscript/array.c b/dlls/jscript/array.c index 31249f0..764633d 100644 --- a/dlls/jscript/array.c +++ b/dlls/jscript/array.c @@ -24,6 +24,8 @@ WINE_DEFAULT_DEBUG_CHANNEL(jscript); typedef struct { DispatchEx dispex; + + DWORD length; } ArrayInstance; static const WCHAR lengthW[] = {'l','e','n','g','t','h',0}; @@ -212,10 +214,56 @@ static const builtin_info_t Array_info = { }; static HRESULT ArrayConstr_value(DispatchEx *dispex, LCID lcid, WORD flags, DISPPARAMS *dp, - VARIANT *retv, jsexcept_t *ei, IServiceProvider *sp) + VARIANT *retv, jsexcept_t *ei, IServiceProvider *caller) { - FIXME("\n"); - return E_NOTIMPL; + DispatchEx *obj; + VARIANT *arg_var; + DWORD i; + HRESULT hres; + + TRACE("\n"); + + switch(flags) { + case DISPATCH_CONSTRUCT: { + if(arg_cnt(dp) == 1 && V_VT((arg_var = get_arg(dp, 0))) == VT_I4) { + if(V_I4(arg_var) < 0) { + FIXME("throw RangeError\n"); + return E_FAIL; + } + + hres = create_array(dispex->ctx, V_I4(arg_var), &obj); + if(FAILED(hres)) + return hres; + + V_VT(retv) = VT_DISPATCH; + V_DISPATCH(retv) = (IDispatch*)_IDispatchEx_(obj); + return S_OK; + } + + hres = create_array(dispex->ctx, arg_cnt(dp), &obj); + if(FAILED(hres)) + return hres; + + for(i=0; i < arg_cnt(dp); i++) { + hres = jsdisp_propput_idx(obj, i, lcid, get_arg(dp, i), ei, caller); + if(FAILED(hres)) + break; + } + if(FAILED(hres)) { + jsdisp_release(obj); + return hres; + } + + V_VT(retv) = VT_DISPATCH; + V_DISPATCH(retv) = (IDispatch*)_IDispatchEx_(obj); + break; + } + default: + FIXME("unimplemented flags: %x\n", flags); + return E_NOTIMPL; + } + + return S_OK; } static HRESULT alloc_array(script_ctx_t *ctx, BOOL use_constr, ArrayInstance **ret) @@ -251,3 +299,18 @@ HRESULT create_array_constr(script_ctx_t *ctx, DispatchEx **ret) IDispatchEx_Release(_IDispatchEx_(&array->dispex)); return hres; } + +HRESULT create_array(script_ctx_t *ctx, DWORD length, DispatchEx **ret) +{ + ArrayInstance *array; + HRESULT hres; + + hres = alloc_array(ctx, TRUE, &array); + if(FAILED(hres)) + return hres; + + array->length = length; + + *ret = &array->dispex; + return S_OK; +} diff --git a/dlls/jscript/jscript.h b/dlls/jscript/jscript.h index ee1215e..a3c5c0a 100644 --- a/dlls/jscript/jscript.h +++ b/dlls/jscript/jscript.h @@ -115,6 +115,7 @@ HRESULT create_builtin_function(script_ctx_t*,builtin_invoke_t,DWORD,DispatchEx* HRESULT create_object(script_ctx_t*,DispatchEx*,DispatchEx**); HRESULT create_math(script_ctx_t*,DispatchEx**); +HRESULT create_array(script_ctx_t*,DWORD,DispatchEx**); HRESULT to_primitive(script_ctx_t*,VARIANT*,jsexcept_t*,VARIANT*); HRESULT to_boolean(VARIANT*,VARIANT_BOOL*); @@ -163,6 +164,16 @@ HRESULT create_object_constr(script_ctx_t*,DispatchEx**); HRESULT create_regexp_constr(script_ctx_t*,DispatchEx**); HRESULT create_string_constr(script_ctx_t*,DispatchEx**); +static inline VARIANT *get_arg(DISPPARAMS *dp, DWORD i) +{ + return dp->rgvarg + dp->cArgs-i-1; +} + +static inline DWORD arg_cnt(const DISPPARAMS *dp) +{ + return dp->cArgs - dp->cNamedArgs; +} + const char *debugstr_variant(const VARIANT*); HRESULT WINAPI JScriptFactory_CreateInstance(IClassFactory*,IUnknown*,REFIID,void**); diff --git a/dlls/jscript/tests/api.js b/dlls/jscript/tests/api.js new file mode 100644 index 0000000..7a7b48f --- /dev/null +++ b/dlls/jscript/tests/api.js @@ -0,0 +1,33 @@ +/* + * Copyright 2008 Jacek Caban for CodeWeavers + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +var arr = new Array(); +ok(typeof(arr) === "object", "arr () is not object"); +ok(arr["0"] === undefined, "arr[0] is not undefined"); + +var arr = new Array(1, 2, "test"); +ok(typeof(arr) === "object", "arr (1,2,test) is not object"); +ok(arr["0"] === 1, "arr[0] is not 1"); +ok(arr["1"] === 2, "arr[1] is not 2"); +ok(arr["2"] === "test", "arr[2] is not \"test\""); + +var arr = new Array(6); +ok(typeof(arr) === "object", "arr (6) is not object"); +ok(arr["0"] === undefined, "arr[0] is not undefined"); + +reportSuccess(); diff --git a/dlls/jscript/tests/rsrc.rc b/dlls/jscript/tests/rsrc.rc index ba7a460..407ef2c 100644 --- a/dlls/jscript/tests/rsrc.rc +++ b/dlls/jscript/tests/rsrc.rc @@ -16,5 +16,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ +/* @makedep: api.js */ +api.js 40 "api.js" + /* @makedep: lang.js */ lang.js 40 "lang.js" diff --git a/dlls/jscript/tests/run.c b/dlls/jscript/tests/run.c index 3409b7e..e4ecbd7 100644 --- a/dlls/jscript/tests/run.c +++ b/dlls/jscript/tests/run.c @@ -582,6 +582,7 @@ static void run_tests(void) CHECK_CALLED(global_success_i); run_from_res("lang.js"); + run_from_res("api.js"); } START_TEST(run)

1 0

Jacek Caban : jscript: Added Array.length implementation.
by Alexandre Julliard 16 Sep '08

16 Sep '08

Module: wine Branch: master Commit: 06d19171be21fde7bff7b7551c1b56baba301cdb URL: http://source.winehq.org/git/wine.git/?a=commit;h=06d19171be21fde7bff7b7551… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Sep 15 20:37:29 2008 +0200 jscript: Added Array.length implementation. --- dlls/jscript/array.c | 17 +++++++++++++++-- dlls/jscript/tests/api.js | 3 +++ 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/dlls/jscript/array.c b/dlls/jscript/array.c index 764633d..65097be 100644 --- a/dlls/jscript/array.c +++ b/dlls/jscript/array.c @@ -51,8 +51,21 @@ static const WCHAR isPrototypeOfW[] = {'i','s','P','r','o','t','o','t','y','p',' static HRESULT Array_length(DispatchEx *dispex, LCID lcid, WORD flags, DISPPARAMS *dp, VARIANT *retv, jsexcept_t *ei, IServiceProvider *sp) { - FIXME("\n"); - return E_NOTIMPL; + ArrayInstance *This = (ArrayInstance*)dispex; + + TRACE("%p %d\n", This, This->length); + + switch(flags) { + case DISPATCH_PROPERTYGET: + V_VT(retv) = VT_I4; + V_I4(retv) = This->length; + break; + default: + FIXME("unimplemented flags %x\n", flags); + return E_NOTIMPL; + } + + return S_OK; } static HRESULT Array_concat(DispatchEx *dispex, LCID lcid, WORD flags, DISPPARAMS *dp, diff --git a/dlls/jscript/tests/api.js b/dlls/jscript/tests/api.js index 7a7b48f..e874027 100644 --- a/dlls/jscript/tests/api.js +++ b/dlls/jscript/tests/api.js @@ -18,16 +18,19 @@ var arr = new Array(); ok(typeof(arr) === "object", "arr () is not object"); +ok((arr.length === 0), "arr.length is not 0"); ok(arr["0"] === undefined, "arr[0] is not undefined"); var arr = new Array(1, 2, "test"); ok(typeof(arr) === "object", "arr (1,2,test) is not object"); +ok((arr.length === 3), "arr.length is not 3"); ok(arr["0"] === 1, "arr[0] is not 1"); ok(arr["1"] === 2, "arr[1] is not 2"); ok(arr["2"] === "test", "arr[2] is not \"test\""); var arr = new Array(6); ok(typeof(arr) === "object", "arr (6) is not object"); +ok((arr.length === 6), "arr.length is not 6"); ok(arr["0"] === undefined, "arr[0] is not undefined"); reportSuccess();

1 0