January 2009 - Wine-commits

Juan Lang : cryptui: Show names of stores certificate manager dialog.
by Alexandre Julliard 09 Jan '09

09 Jan '09

Module: wine Branch: master Commit: 1d59060152b0797ed80ff4aab2f30b5df26f063a URL: http://source.winehq.org/git/wine.git/?a=commit;h=1d59060152b0797ed80ff4aab… Author: Juan Lang <juan.lang(a)gmail.com> Date: Wed Jan 7 16:18:46 2009 -0800 cryptui: Show names of stores certificate manager dialog. --- dlls/cryptui/main.c | 76 ++++++++++++++++++++++++++++++++++++++++++++++----- 1 files changed, 69 insertions(+), 7 deletions(-) diff --git a/dlls/cryptui/main.c b/dlls/cryptui/main.c index acf438b..52d1bda 100644 --- a/dlls/cryptui/main.c +++ b/dlls/cryptui/main.c @@ -109,6 +109,71 @@ static void initialize_purpose_selection(HWND hwnd) SendMessageW(cb, CB_SETCURSEL, 0, 0); } +static const WCHAR my[] = { 'M','y',0 }; +static const WCHAR addressBook[] = { + 'A','d','d','r','e','s','s','B','o','o','k',0 }; +static const WCHAR ca[] = { 'C','A',0 }; +static const WCHAR root[] = { 'R','o','o','t',0 }; +static const WCHAR trustedPublisher[] = { + 'T','r','u','s','t','e','d','P','u','b','l','i','s','h','e','r',0 }; +static const WCHAR disallowed[] = { 'D','i','s','a','l','l','o','w','e','d',0 }; + +static LPCWSTR defaultStoreList[] = { + my, addressBook, ca, root, trustedPublisher, disallowed }; +static LPCWSTR publisherStoreList[] = { root, trustedPublisher, disallowed }; + +static void show_cert_stores(HWND hwnd, DWORD dwFlags) +{ + LPCWSTR *storeList; + int cStores, i; + HWND tab = GetDlgItem(hwnd, IDC_MGR_STORES); + + if (dwFlags & CRYPTUI_CERT_MGR_PUBLISHER_TAB) + { + storeList = publisherStoreList; + cStores = sizeof(publisherStoreList) / sizeof(publisherStoreList[0]); + } + else + { + storeList = defaultStoreList; + cStores = sizeof(defaultStoreList) / sizeof(defaultStoreList[0]); + } + if (dwFlags & CRYPTUI_CERT_MGR_SINGLE_TAB_FLAG) + cStores = 1; + for (i = 0; i < cStores; i++) + { + LPCWSTR name; + TCITEMW item; + HCERTSTORE store; + + if (!(name = CryptFindLocalizedName(storeList[i]))) + name = storeList[i]; + store = CertOpenStore(CERT_STORE_PROV_SYSTEM_W, 0, 0, + CERT_SYSTEM_STORE_CURRENT_USER, storeList[i]); + item.mask = TCIF_TEXT | TCIF_PARAM; + item.pszText = (LPWSTR)name; + item.lParam = (LPARAM)store; + SendMessageW(tab, TCM_INSERTITEMW, i, (LPARAM)&item); + } +} + +static HCERTSTORE cert_mgr_index_to_store(HWND tab, int index) +{ + TCITEMW item; + + item.mask = TCIF_PARAM; + SendMessageW(tab, TCM_GETITEMW, index, (LPARAM)&item); + return (HCERTSTORE)item.lParam; +} + +static void close_stores(HWND tab) +{ + int i, tabs = SendMessageW(tab, TCM_GETITEMCOUNT, 0, 0); + + for (i = 0; i < tabs; i++) + CertCloseStore(cert_mgr_index_to_store(tab, i), 0); +} + static LRESULT CALLBACK cert_mgr_dlg_proc(HWND hwnd, UINT msg, WPARAM wp, LPARAM lp) { @@ -124,12 +189,14 @@ static LRESULT CALLBACK cert_mgr_dlg_proc(HWND hwnd, UINT msg, WPARAM wp, if (pCryptUICertMgr->pwszTitle) SendMessageW(hwnd, WM_SETTEXT, 0, (LPARAM)pCryptUICertMgr->pwszTitle); + show_cert_stores(hwnd, pCryptUICertMgr->dwFlags); break; } case WM_COMMAND: switch (wp) { case IDCANCEL: + close_stores(GetDlgItem(hwnd, IDC_MGR_STORES)); EndDialog(hwnd, IDCANCEL); break; } @@ -3471,15 +3538,12 @@ static BOOL is_ca_cert(PCCERT_CONTEXT cert, BOOL defaultIfNotSpecified) static HCERTSTORE choose_store_for_cert(PCCERT_CONTEXT cert) { - static const WCHAR AddressBook[] = { 'A','d','d','r','e','s','s', - 'B','o','o','k',0 }; - static const WCHAR CA[] = { 'C','A',0 }; LPCWSTR storeName; if (is_ca_cert(cert, TRUE)) - storeName = CA; + storeName = ca; else - storeName = AddressBook; + storeName = addressBook; return CertOpenStore(CERT_STORE_PROV_SYSTEM_W, 0, 0, CERT_SYSTEM_STORE_CURRENT_USER, storeName); } @@ -3522,8 +3586,6 @@ static BOOL import_crl(PCCRL_CONTEXT crl, HCERTSTORE hDestCertStore) if (hDestCertStore) store = hDestCertStore; else { - static const WCHAR ca[] = { 'C','A',0 }; - if (!(store = CertOpenStore(CERT_STORE_PROV_SYSTEM_W, 0, 0, CERT_SYSTEM_STORE_CURRENT_USER, ca))) {

1 0

Juan Lang : cryptui: Display contents of certificate store in certificate manager dialog.
by Alexandre Julliard 09 Jan '09

09 Jan '09

Module: wine Branch: master Commit: 29dcd605870bbe26bac277999b436191cd8222a4 URL: http://source.winehq.org/git/wine.git/?a=commit;h=29dcd605870bbe26bac277999… Author: Juan Lang <juan.lang(a)gmail.com> Date: Wed Jan 7 16:20:25 2009 -0800 cryptui: Display contents of certificate store in certificate manager dialog. --- dlls/cryptui/main.c | 127 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 127 insertions(+), 0 deletions(-) diff --git a/dlls/cryptui/main.c b/dlls/cryptui/main.c index 52d1bda..8a84c34 100644 --- a/dlls/cryptui/main.c +++ b/dlls/cryptui/main.c @@ -109,6 +109,99 @@ static void initialize_purpose_selection(HWND hwnd) SendMessageW(cb, CB_SETCURSEL, 0, 0); } +static void add_cert_to_view(HWND lv, PCCERT_CONTEXT cert, DWORD *allocatedLen, + LPWSTR *str) +{ + DWORD len; + LVITEMW item; + WCHAR dateFmt[80]; /* sufficient for LOCALE_SSHORTDATE */ + WCHAR date[80]; + SYSTEMTIME sysTime; + + item.mask = LVIF_IMAGE | LVIF_PARAM | LVIF_TEXT; + item.iItem = SendMessageW(lv, LVM_GETITEMCOUNT, 0, 0); + item.iSubItem = 0; + item.iImage = 0; + item.lParam = (LPARAM)CertDuplicateCertificateContext(cert); + len = CertGetNameStringW(cert, CERT_NAME_SIMPLE_DISPLAY_TYPE, 0, NULL, + NULL, 0); + if (len > *allocatedLen) + { + HeapFree(GetProcessHeap(), 0, *str); + *str = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); + if (*str) + *allocatedLen = len; + } + if (*str) + { + CertGetNameStringW(cert, CERT_NAME_SIMPLE_DISPLAY_TYPE, 0, NULL, + *str, len); + item.pszText = *str; + SendMessageW(lv, LVM_INSERTITEMW, 0, (LPARAM)&item); + } + + item.mask = LVIF_TEXT; + len = CertGetNameStringW(cert, CERT_NAME_SIMPLE_DISPLAY_TYPE, + CERT_NAME_ISSUER_FLAG, NULL, NULL, 0); + if (len > *allocatedLen) + { + HeapFree(GetProcessHeap(), 0, *str); + *str = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); + if (*str) + *allocatedLen = len; + } + if (*str) + { + CertGetNameStringW(cert, CERT_NAME_SIMPLE_DISPLAY_TYPE, + CERT_NAME_ISSUER_FLAG, NULL, *str, len); + item.pszText = *str; + item.iSubItem = 1; + SendMessageW(lv, LVM_SETITEMTEXTW, item.iItem, (LPARAM)&item); + } + + GetLocaleInfoW(LOCALE_SYSTEM_DEFAULT, LOCALE_SSHORTDATE, dateFmt, + sizeof(dateFmt) / sizeof(dateFmt[0])); + FileTimeToSystemTime(&cert->pCertInfo->NotAfter, &sysTime); + GetDateFormatW(LOCALE_SYSTEM_DEFAULT, 0, &sysTime, dateFmt, date, + sizeof(date) / sizeof(date[0])); + item.pszText = date; + item.iSubItem = 2; + SendMessageW(lv, LVM_SETITEMTEXTW, item.iItem, (LPARAM)&item); + + len = CertGetNameStringW(cert, CERT_NAME_FRIENDLY_DISPLAY_TYPE, 0, NULL, + NULL, 0); + if (len > *allocatedLen) + { + HeapFree(GetProcessHeap(), 0, *str); + *str = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); + if (*str) + *allocatedLen = len; + } + if (*str) + { + CertGetNameStringW(cert, CERT_NAME_FRIENDLY_DISPLAY_TYPE, 0, NULL, + *str, len); + item.pszText = *str; + item.iSubItem = 3; + SendMessageW(lv, LVM_SETITEMTEXTW, item.iItem, (LPARAM)&item); + } +} + +static void show_store_certs(HWND hwnd, HCERTSTORE store) +{ + HWND lv = GetDlgItem(hwnd, IDC_MGR_CERTS); + PCCERT_CONTEXT cert = NULL; + DWORD allocatedLen = 0; + LPWSTR str = NULL; + + do { + cert = CertEnumCertificatesInStore(store, cert); + if (cert) + add_cert_to_view(lv, cert, &allocatedLen, &str); + } while (cert); + HeapFree(GetProcessHeap(), 0, str); +} + static const WCHAR my[] = { 'M','y',0 }; static const WCHAR addressBook[] = { 'A','d','d','r','e','s','s','B','o','o','k',0 }; @@ -157,6 +250,21 @@ static void show_cert_stores(HWND hwnd, DWORD dwFlags) } } +static void free_certs(HWND lv) +{ + LVITEMW item; + int items = SendMessageW(lv, LVM_GETITEMCOUNT, 0, 0), i; + + for (i = 0; i < items; i++) + { + item.mask = LVIF_PARAM; + item.iItem = i; + item.iSubItem = 0; + SendMessageW(lv, LVM_GETITEMW, 0, (LPARAM)&item); + CertFreeCertificateContext((PCCERT_CONTEXT)item.lParam); + } +} + static HCERTSTORE cert_mgr_index_to_store(HWND tab, int index) { TCITEMW item; @@ -183,20 +291,39 @@ static LRESULT CALLBACK cert_mgr_dlg_proc(HWND hwnd, UINT msg, WPARAM wp, { PCCRYPTUI_CERT_MGR_STRUCT pCryptUICertMgr = (PCCRYPTUI_CERT_MGR_STRUCT)lp; + HIMAGELIST imageList; + HWND tab = GetDlgItem(hwnd, IDC_MGR_STORES); + imageList = ImageList_Create(16, 16, ILC_COLOR4 | ILC_MASK, 2, 0); + if (imageList) + { + HBITMAP bmp; + COLORREF backColor = RGB(255, 0, 255); + + bmp = LoadBitmapW(hInstance, MAKEINTRESOURCEW(IDB_SMALL_ICONS)); + ImageList_AddMasked(imageList, bmp, backColor); + DeleteObject(bmp); + ImageList_SetBkColor(imageList, CLR_NONE); + SendMessageW(GetDlgItem(hwnd, IDC_MGR_CERTS), LVM_SETIMAGELIST, + LVSIL_SMALL, (LPARAM)imageList); + SetWindowLongPtrW(hwnd, DWLP_USER, (LPARAM)imageList); + } initialize_purpose_selection(hwnd); add_cert_columns(hwnd); if (pCryptUICertMgr->pwszTitle) SendMessageW(hwnd, WM_SETTEXT, 0, (LPARAM)pCryptUICertMgr->pwszTitle); show_cert_stores(hwnd, pCryptUICertMgr->dwFlags); + show_store_certs(hwnd, cert_mgr_index_to_store(tab, 0)); break; } case WM_COMMAND: switch (wp) { case IDCANCEL: + free_certs(GetDlgItem(hwnd, IDC_MGR_CERTS)); close_stores(GetDlgItem(hwnd, IDC_MGR_STORES)); + ImageList_Destroy((HIMAGELIST)GetWindowLongPtrW(hwnd, DWLP_USER)); EndDialog(hwnd, IDCANCEL); break; }

1 0

Juan Lang : cryptui: Refresh store display when a tab is switched or the purpose selection is changed in the certificate manager dialog .
by Alexandre Julliard 09 Jan '09

09 Jan '09

Module: wine Branch: master Commit: be1587ca50a70a163e0a3207123693965a782b0f URL: http://source.winehq.org/git/wine.git/?a=commit;h=be1587ca50a70a163e0a32071… Author: Juan Lang <juan.lang(a)gmail.com> Date: Wed Jan 7 16:29:19 2009 -0800 cryptui: Refresh store display when a tab is switched or the purpose selection is changed in the certificate manager dialog. --- dlls/cryptui/main.c | 31 +++++++++++++++++++++++++++++++ 1 files changed, 31 insertions(+), 0 deletions(-) diff --git a/dlls/cryptui/main.c b/dlls/cryptui/main.c index 8a84c34..9f156c4 100644 --- a/dlls/cryptui/main.c +++ b/dlls/cryptui/main.c @@ -274,6 +274,13 @@ static HCERTSTORE cert_mgr_index_to_store(HWND tab, int index) return (HCERTSTORE)item.lParam; } +static HCERTSTORE cert_mgr_current_store(HWND hwnd) +{ + HWND tab = GetDlgItem(hwnd, IDC_MGR_STORES); + + return cert_mgr_index_to_store(tab, SendMessageW(tab, TCM_GETCURSEL, 0, 0)); +} + static void close_stores(HWND tab) { int i, tabs = SendMessageW(tab, TCM_GETITEMCOUNT, 0, 0); @@ -282,6 +289,15 @@ static void close_stores(HWND tab) CertCloseStore(cert_mgr_index_to_store(tab, i), 0); } +static void refresh_store_certs(HWND hwnd) +{ + HWND lv = GetDlgItem(hwnd, IDC_MGR_CERTS); + + free_certs(lv); + SendMessageW(lv, LVM_DELETEALLITEMS, 0, 0); + show_store_certs(hwnd, cert_mgr_current_store(hwnd)); +} + static LRESULT CALLBACK cert_mgr_dlg_proc(HWND hwnd, UINT msg, WPARAM wp, LPARAM lp) { @@ -317,9 +333,24 @@ static LRESULT CALLBACK cert_mgr_dlg_proc(HWND hwnd, UINT msg, WPARAM wp, show_store_certs(hwnd, cert_mgr_index_to_store(tab, 0)); break; } + case WM_NOTIFY: + { + NMHDR *hdr = (NMHDR *)lp; + + switch (hdr->code) + { + case TCN_SELCHANGE: + refresh_store_certs(hwnd); + break; + } + break; + } case WM_COMMAND: switch (wp) { + case ((CBN_SELCHANGE << 16) | IDC_MGR_PURPOSE_SELECTION): + refresh_store_certs(hwnd); + break; case IDCANCEL: free_certs(GetDlgItem(hwnd, IDC_MGR_CERTS)); close_stores(GetDlgItem(hwnd, IDC_MGR_STORES));

1 0

Andrew Talbot : mshtml: Declare a function static.
by Alexandre Julliard 09 Jan '09

09 Jan '09

Module: wine Branch: master Commit: 3b26d50d17045fb41b690755f5bec8de7c1a6386 URL: http://source.winehq.org/git/wine.git/?a=commit;h=3b26d50d17045fb41b690755f… Author: Andrew Talbot <andrew.talbot(a)talbotville.com> Date: Thu Jan 8 21:30:57 2009 +0000 mshtml: Declare a function static. --- dlls/mshtml/htmlelemcol.c | 5 ++++- dlls/mshtml/mshtml_private.h | 1 - 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/dlls/mshtml/htmlelemcol.c b/dlls/mshtml/htmlelemcol.c index f0ca6d7..2dbbaca 100644 --- a/dlls/mshtml/htmlelemcol.c +++ b/dlls/mshtml/htmlelemcol.c @@ -50,6 +50,9 @@ typedef struct { DWORD size; } elem_vector_t; +static IHTMLElementCollection *HTMLElementCollection_Create(IUnknown *ref_unk, + HTMLElement **elems, DWORD len); + static void elem_vector_add(elem_vector_t *buf, HTMLElement *elem) { if(buf->len == buf->size) { @@ -534,7 +537,7 @@ IHTMLElementCollection *create_collection_from_htmlcol(HTMLDocument *doc, IUnkno return HTMLElementCollection_Create(unk, buf.buf, buf.len); } -IHTMLElementCollection *HTMLElementCollection_Create(IUnknown *ref_unk, +static IHTMLElementCollection *HTMLElementCollection_Create(IUnknown *ref_unk, HTMLElement **elems, DWORD len) { HTMLElementCollection *ret = heap_alloc_zero(sizeof(HTMLElementCollection)); diff --git a/dlls/mshtml/mshtml_private.h b/dlls/mshtml/mshtml_private.h index a7e364e..148c997 100644 --- a/dlls/mshtml/mshtml_private.h +++ b/dlls/mshtml/mshtml_private.h @@ -614,7 +614,6 @@ void doc_insert_script(HTMLDocument*,nsIDOMHTMLScriptElement*); IDispatch *script_parse_event(HTMLDocument*,LPCWSTR); void set_script_mode(HTMLDocument*,SCRIPTMODE); -IHTMLElementCollection *HTMLElementCollection_Create(IUnknown*,HTMLElement**,DWORD); IHTMLElementCollection *create_all_collection(HTMLDOMNode*,BOOL); IHTMLElementCollection *create_collection_from_nodelist(HTMLDocument*,IUnknown*,nsIDOMNodeList*); IHTMLElementCollection *create_collection_from_htmlcol(HTMLDocument*,IUnknown*,nsIDOMHTMLCollection*);

1 0

Juan Lang : cryptui: Add a (empty) certificate manager dialog.
by Alexandre Julliard 09 Jan '09

09 Jan '09

Module: wine Branch: master Commit: 1f183ea2893c24180f92a496c3b299d2b7cd1393 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1f183ea2893c24180f92a496c… Author: Juan Lang <juan.lang(a)gmail.com> Date: Wed Jan 7 16:15:05 2009 -0800 cryptui: Add a (empty) certificate manager dialog. --- dlls/cryptui/cryptui_En.rc | 21 +++++++++++++++++++++ dlls/cryptui/cryptuires.h | 11 +++++++++++ dlls/cryptui/main.c | 40 ++++++++++++++++++++++++++++++++++++++-- 3 files changed, 70 insertions(+), 2 deletions(-) diff --git a/dlls/cryptui/cryptui_En.rc b/dlls/cryptui/cryptui_En.rc index 0609229..251bf01 100644 --- a/dlls/cryptui/cryptui_En.rc +++ b/dlls/cryptui/cryptui_En.rc @@ -287,3 +287,24 @@ BEGIN LVS_REPORT|LVS_NOCOLUMNHEADER|LVS_SINGLESEL|WS_CHILD|WS_VISIBLE|WS_TABSTOP|WS_BORDER, 115,67,174,100 END + +IDD_CERT_MGR DIALOG DISCARDABLE 0,0,335,270 +CAPTION "Certificates" +FONT 8, "MS Shell Dlg" +BEGIN + LTEXT "I&ntended purpose:", IDC_STATIC, 7,9,100,12 + COMBOBOX IDC_MGR_PURPOSE_SELECTION, 83,7,245,14, + CBS_DROPDOWNLIST|WS_BORDER|WS_VSCROLL|WS_TABSTOP + CONTROL "", IDC_MGR_STORES, "SysTabControl32", + WS_CLIPSIBLINGS|WS_TABSTOP, 7,25,321,140 + CONTROL "", IDC_MGR_CERTS, "SysListView32", + LVS_REPORT|WS_CHILD|WS_VISIBLE|WS_TABSTOP|WS_BORDER, 15,46,305,111 + PUSHBUTTON "&Import...", IDC_MGR_IMPORT, 7,172,51,14 + PUSHBUTTON "&Export...", IDC_MGR_EXPORT, 62,172,51,14, WS_DISABLED + PUSHBUTTON "&Remove", IDC_MGR_REMOVE, 117,172,51,14, WS_DISABLED + PUSHBUTTON "&Advanced...", IDC_MGR_ADVANCED, 277,172,51,14 + GROUPBOX "Certificate intended purposes", grp1,7,194,321,47, BS_GROUPBOX + LTEXT "", IDC_MGR_PURPOSES, 13,208,252,30 + PUSHBUTTON "&View...", IDC_MGR_VIEW, 269,218,51,14, WS_DISABLED + PUSHBUTTON "&Close", IDCANCEL, 277,249,51,14, BS_DEFPUSHBUTTON +END diff --git a/dlls/cryptui/cryptuires.h b/dlls/cryptui/cryptuires.h index 14f576e..6799d54 100644 --- a/dlls/cryptui/cryptuires.h +++ b/dlls/cryptui/cryptuires.h @@ -130,6 +130,7 @@ #define IDD_IMPORT_FILE 108 #define IDD_IMPORT_STORE 109 #define IDD_IMPORT_FINISH 110 +#define IDD_CERT_MGR 111 #define IDB_SMALL_ICONS 200 #define IDB_CERT 201 @@ -184,4 +185,14 @@ #define IDC_IMPORT_BROWSE_STORE 2706 #define IDC_IMPORT_SETTINGS 2707 +#define IDC_MGR_PURPOSE_SELECTION 2800 +#define IDC_MGR_STORES 2801 +#define IDC_MGR_CERTS 2802 +#define IDC_MGR_IMPORT 2803 +#define IDC_MGR_EXPORT 2804 +#define IDC_MGR_REMOVE 2805 +#define IDC_MGR_ADVANCED 2806 +#define IDC_MGR_PURPOSES 2807 +#define IDC_MGR_VIEW 2808 + #endif /* ndef __CRYPTUIRES_H_ */ diff --git a/dlls/cryptui/main.c b/dlls/cryptui/main.c index 987599d..1a48c6f 100644 --- a/dlls/cryptui/main.c +++ b/dlls/cryptui/main.c @@ -65,13 +65,49 @@ BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) return TRUE; } +static LRESULT CALLBACK cert_mgr_dlg_proc(HWND hwnd, UINT msg, WPARAM wp, + LPARAM lp) +{ + switch (msg) + { + case WM_INITDIALOG: + { + PCCRYPTUI_CERT_MGR_STRUCT pCryptUICertMgr = + (PCCRYPTUI_CERT_MGR_STRUCT)lp; + + if (pCryptUICertMgr->pwszTitle) + SendMessageW(hwnd, WM_SETTEXT, 0, + (LPARAM)pCryptUICertMgr->pwszTitle); + break; + } + case WM_COMMAND: + switch (wp) + { + case IDCANCEL: + EndDialog(hwnd, IDCANCEL); + break; + } + break; + } + return 0; +} + /*********************************************************************** * CryptUIDlgCertMgr (CRYPTUI.@) */ BOOL WINAPI CryptUIDlgCertMgr(PCCRYPTUI_CERT_MGR_STRUCT pCryptUICertMgr) { - FIXME("(%p): stub\n", pCryptUICertMgr); - return FALSE; + TRACE("(%p)\n", pCryptUICertMgr); + + if (pCryptUICertMgr->dwSize != sizeof(CRYPTUI_CERT_MGR_STRUCT)) + { + WARN("unexpected size %d\n", pCryptUICertMgr->dwSize); + SetLastError(E_INVALIDARG); + return FALSE; + } + DialogBoxParamW(hInstance, MAKEINTRESOURCEW(IDD_CERT_MGR), + pCryptUICertMgr->hwndParent, cert_mgr_dlg_proc, (LPARAM)pCryptUICertMgr); + return TRUE; } /* FIXME: real names are unknown, functions are undocumented */

1 0

Andrew Talbot : d3dxof: Declare a function static.
by Alexandre Julliard 09 Jan '09

09 Jan '09

Module: wine Branch: master Commit: 7a326f9405a39c2867dadd58ebe8334fc91a460e URL: http://source.winehq.org/git/wine.git/?a=commit;h=7a326f9405a39c2867dadd58e… Author: Andrew Talbot <andrew.talbot(a)talbotville.com> Date: Thu Jan 8 21:43:24 2009 +0000 d3dxof: Declare a function static. --- dlls/d3dxof/parsing.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/d3dxof/parsing.c b/dlls/d3dxof/parsing.c index d4c71d1..4167597 100644 --- a/dlls/d3dxof/parsing.c +++ b/dlls/d3dxof/parsing.c @@ -762,7 +762,7 @@ static inline BOOL is_primitive_type(WORD token) return ret; } -BOOL parse_template_option_info(parse_buffer * buf) +static BOOL parse_template_option_info(parse_buffer * buf) { xtemplate* cur_template = &buf->pdxf->xtemplates[buf->pdxf->nb_xtemplates];

1 0

Andrew Talbot : msacm32: Declare a variable static.
by Alexandre Julliard 09 Jan '09

09 Jan '09

Module: wine Branch: master Commit: d1d558429907092812fde2c7c114f46cf8d0c3f7 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d1d558429907092812fde2c7c… Author: Andrew Talbot <andrew.talbot(a)talbotville.com> Date: Thu Jan 8 21:30:53 2009 +0000 msacm32: Declare a variable static. --- dlls/msacm32/internal.c | 2 +- dlls/msacm32/wineacm.h | 1 - 2 files changed, 1 insertions(+), 2 deletions(-) diff --git a/dlls/msacm32/internal.c b/dlls/msacm32/internal.c index cfc4708..cf76a57 100644 --- a/dlls/msacm32/internal.c +++ b/dlls/msacm32/internal.c @@ -44,7 +44,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(msacm); HANDLE MSACM_hHeap = NULL; PWINE_ACMDRIVERID MSACM_pFirstACMDriverID = NULL; -PWINE_ACMDRIVERID MSACM_pLastACMDriverID = NULL; +static PWINE_ACMDRIVERID MSACM_pLastACMDriverID; static DWORD MSACM_suspendBroadcastCount = 0; static BOOL MSACM_pendingBroadcast = FALSE; diff --git a/dlls/msacm32/wineacm.h b/dlls/msacm32/wineacm.h index 3c18a57..3c00130 100644 --- a/dlls/msacm32/wineacm.h +++ b/dlls/msacm32/wineacm.h @@ -370,7 +370,6 @@ typedef struct _WINE_ACMNOTIFYWND /* From internal.c */ extern HANDLE MSACM_hHeap; extern PWINE_ACMDRIVERID MSACM_pFirstACMDriverID; -extern PWINE_ACMDRIVERID MSACM_pLastACMDriverID; extern PWINE_ACMDRIVERID MSACM_RegisterDriver(LPCWSTR pszDriverAlias, LPCWSTR pszFileName, PWINE_ACMLOCALDRIVER pLocalDriver); extern void MSACM_RegisterAllDrivers(void);

1 0

Paul Vriens : shell32/tests: Fix test failures on Vista.
by Alexandre Julliard 09 Jan '09

09 Jan '09

Module: wine Branch: master Commit: 189ea312d739887d6aca9223cc484564ba2a0c8e URL: http://source.winehq.org/git/wine.git/?a=commit;h=189ea312d739887d6aca9223c… Author: Paul Vriens <Paul.Vriens.Wine(a)gmail.com> Date: Thu Jan 8 21:44:44 2009 +0100 shell32/tests: Fix test failures on Vista. --- dlls/shell32/tests/shlfileop.c | 22 ++++++++++++++++------ 1 files changed, 16 insertions(+), 6 deletions(-) diff --git a/dlls/shell32/tests/shlfileop.c b/dlls/shell32/tests/shlfileop.c index 42deb2d..5207f01 100644 --- a/dlls/shell32/tests/shlfileop.c +++ b/dlls/shell32/tests/shlfileop.c @@ -323,7 +323,7 @@ static void test_get_file_info_iconlist(void) ok(shInfoa.dwAttributes == 0xcfcfcfcf || shInfoa.dwAttributes == 0 || /* Vista */ broken(shInfoa.dwAttributes != 0xcfcfcfcf), /* NT4 doesn't clear but sets this field */ - "SHGetFileInfoA(CSIDL_DESKTOP, SHGFI_SYSICONINDEX|SHGFI_SMALLICON|SHGFI_PIDL), unexpected dwAttributes : %08x\n",shInfoa.dwAttributes); + "SHGetFileInfoA(CSIDL_DESKTOP, SHGFI_SYSICONINDEX|SHGFI_SMALLICON|SHGFI_PIDL), unexpected dwAttributes\n"); CloseHandle(hSysImageList); if (!pSHGetFileInfoW) @@ -346,7 +346,9 @@ static void test_get_file_info_iconlist(void) todo_wine ok(shInfow.hIcon == 0, "SHGetFileInfoW(CSIDL_DESKTOP, SHGFI_SYSICONINDEX|SHGFI_SMALLICON|SHGFI_PIDL) did not clear hIcon\n"); ok(shInfow.szTypeName[0] == 0, "SHGetFileInfoW(CSIDL_DESKTOP, SHGFI_SYSICONINDEX|SHGFI_SMALLICON|SHGFI_PIDL) did not clear szTypeName[0]\n"); ok(shInfow.iIcon != 0xcfcfcfcf, "SHGetFileInfoW(CSIDL_DESKTOP, SHGFI_SYSICONINDEX|SHGFI_SMALLICON|SHGFI_PIDL) should set iIcon\n"); - ok(shInfow.dwAttributes == 0xcfcfcfcf, "SHGetFileInfoW(CSIDL_DESKTOP, SHGFI_SYSICONINDEX|SHGFI_SMALLICON|SHGFI_PIDL) should not change dwAttributes\n"); + ok(shInfow.dwAttributes == 0xcfcfcfcf || + shInfoa.dwAttributes == 0, /* Vista */ + "SHGetFileInfoW(CSIDL_DESKTOP, SHGFI_SYSICONINDEX|SHGFI_SMALLICON|SHGFI_PIDL) unexpected dwAttributes\n"); CloseHandle(hSysImageList); /* Various suposidly invalid flag testing */ @@ -355,7 +357,9 @@ static void test_get_file_info_iconlist(void) SHGFI_SYSICONINDEX|SHGFI_USEFILEATTRIBUTES|SHGFI_PIDL|SHGFI_SMALLICON); ok(hr != 0, "SHGFI_SYSICONINDEX|SHGFI_USEFILEATTRIBUTES|SHGFI_PIDL|SHGFI_SMALLICON Failed\n"); ok(shInfow.iIcon!=0xcfcfcfcf, "Icon Index Missing\n"); - ok(shInfow.dwAttributes==0xcfcfcfcf,"dwAttributes modified\n"); + ok(shInfow.dwAttributes==0xcfcfcfcf || + shInfoa.dwAttributes==0, /* Vista */ + "unexpected dwAttributes\n"); memset(&shInfow, 0xcf, sizeof(shInfow)); hr = pSHGetFileInfoW((const WCHAR *)pidList, 0, &shInfow, sizeof(shInfow), @@ -380,7 +384,9 @@ static void test_get_file_info_iconlist(void) SHGFI_SYSICONINDEX|SHGFI_USEFILEATTRIBUTES|SHGFI_PIDL|SHGFI_LARGEICON); ok(hr != 0, "SHGFI_SYSICONINDEX|SHGFI_USEFILEATTRIBUTES|SHGFI_PIDL|SHGFI_LARGEICON Failed\n"); ok(shInfow.iIcon!=0xcfcfcfcf, "Icon Index Missing\n"); - ok(shInfow.dwAttributes==0xcfcfcfcf,"dwAttributes modified\n"); + ok(shInfow.dwAttributes==0xcfcfcfcf || + shInfoa.dwAttributes==0, /* Vista */ + "unexpected dwAttributes\n"); memset(&shInfow, 0xcf, sizeof(shInfow)); hr = pSHGetFileInfoW((const WCHAR *)pidList, 0, &shInfow, sizeof(shInfow), @@ -417,7 +423,9 @@ static void test_get_file_info_iconlist(void) SHGFI_EXETYPE); todo_wine ok(hr != 0, "SHGFI_SYSICONINDEX|SHGFI_USEFILEATTRIBUTES|SHGFI_PIDL|SHGFI_SMALLICON|SHGFI_EXETYPE Failed\n"); ok(shInfow.iIcon!=0xcfcfcfcf, "Icon Index Missing\n"); - ok(shInfow.dwAttributes==0xcfcfcfcf,"dwAttributes modified\n"); + ok(shInfow.dwAttributes==0xcfcfcfcf || + shInfoa.dwAttributes==0, /* Vista */ + "unexpected dwAttributes\n"); memset(&shInfow, 0xcf, sizeof(shInfow)); hr = pSHGetFileInfoW((const WCHAR *)pidList, 0, &shInfow, sizeof(shInfow), @@ -446,7 +454,9 @@ static void test_get_file_info_iconlist(void) SHGFI_SYSICONINDEX|SHGFI_USEFILEATTRIBUTES|SHGFI_PIDL|SHGFI_EXETYPE); todo_wine ok(hr != 0, "SHGFI_SYSICONINDEX|SHGFI_USEFILEATTRIBUTES|SHGFI_PIDL|SHGFI_EXETYPE Failed\n"); ok(shInfow.iIcon!=0xcfcfcfcf, "Icon Index Missing\n"); - ok(shInfow.dwAttributes==0xcfcfcfcf,"dwAttributes modified\n"); + ok(shInfow.dwAttributes==0xcfcfcfcf || + shInfoa.dwAttributes==0, /* Vista */ + "unexpected dwAttributes\n"); memset(&shInfow, 0xcf, sizeof(shInfow)); hr = pSHGetFileInfoW((const WCHAR *)pidList, 0, &shInfow, sizeof(shInfow),

1 0

Paul Vriens : shell32/tests: Skip a test on Vista.
by Alexandre Julliard 09 Jan '09

09 Jan '09

Module: wine Branch: master Commit: 30bb78f0f9c3441201f3aa31ebaf93f46b7c28ea URL: http://source.winehq.org/git/wine.git/?a=commit;h=30bb78f0f9c3441201f3aa31e… Author: Paul Vriens <Paul.Vriens.Wine(a)gmail.com> Date: Fri Jan 9 07:46:11 2009 +0100 shell32/tests: Skip a test on Vista. --- dlls/shell32/tests/shlfileop.c | 35 ++++++++++++++++++++++++----------- 1 files changed, 24 insertions(+), 11 deletions(-) diff --git a/dlls/shell32/tests/shlfileop.c b/dlls/shell32/tests/shlfileop.c index 5207f01..48e89fa 100644 --- a/dlls/shell32/tests/shlfileop.c +++ b/dlls/shell32/tests/shlfileop.c @@ -601,20 +601,33 @@ static void test_delete(void) ok(file_exists("test1.txt"), "Expected test1.txt to exist\n"); } - /* delete a dir, and then a file inside the dir, same as - * deleting a nonexistent file - * - * FIXME: Vista throws up a dialog window to ask if one.txt should be created - */ - init_shfo_tests(); - shfo.pFrom = "testdir2\0testdir2\\one.txt\0"; + /* delete a nonexistent file */ + shfo.pFrom = "nonexistent.txt\0"; shfo.wFunc = FO_DELETE; ret = SHFileOperation(&shfo); - ok(ret == ERROR_PATH_NOT_FOUND || + todo_wine + ok(ret == 1026 || + ret == ERROR_FILE_NOT_FOUND || /* Vista */ broken(ret == ERROR_SUCCESS), /* NT4 */ - "Expected ERROR_PATH_NOT_FOUND, got %d\n", ret); - ok(!dir_exists("testdir2"), "Expected testdir2 to not exist\n"); - ok(!file_exists("testdir2\\one.txt"), "Expected testdir2\\one.txt to not exist\n"); + "Expected 1026 or ERROR_FILE_NOT_FOUND, got %d\n", ret); + + /* delete a dir, and then a file inside the dir, same as + * deleting a nonexistent file + */ + if (ret != ERROR_FILE_NOT_FOUND) + { + /* Vista would throw up a dialog box that we can't suppress */ + init_shfo_tests(); + shfo.pFrom = "testdir2\0testdir2\\one.txt\0"; + ret = SHFileOperation(&shfo); + ok(ret == ERROR_PATH_NOT_FOUND || + broken(ret == ERROR_SUCCESS), /* NT4 */ + "Expected ERROR_PATH_NOT_FOUND, got %d\n", ret); + ok(!dir_exists("testdir2"), "Expected testdir2 to not exist\n"); + ok(!file_exists("testdir2\\one.txt"), "Expected testdir2\\one.txt to not exist\n"); + } + else + skip("Test would show a dialog box\n"); /* try the FOF_NORECURSION flag, continues deleting subdirs */ init_shfo_tests();

1 0

Paul Vriens : shell32/tests: Fix some errors on NT4 (FO_DELETE).
by Alexandre Julliard 09 Jan '09

09 Jan '09

Module: wine Branch: master Commit: faf2f8e682edea6de3ab952e1dab8730d4273251 URL: http://source.winehq.org/git/wine.git/?a=commit;h=faf2f8e682edea6de3ab952e1… Author: Paul Vriens <Paul.Vriens.Wine(a)gmail.com> Date: Thu Jan 8 17:38:56 2009 +0100 shell32/tests: Fix some errors on NT4 (FO_DELETE). --- dlls/shell32/tests/shlfileop.c | 28 +++++++++++++++++----------- 1 files changed, 17 insertions(+), 11 deletions(-) diff --git a/dlls/shell32/tests/shlfileop.c b/dlls/shell32/tests/shlfileop.c index d3e81a8..3aacd0c 100644 --- a/dlls/shell32/tests/shlfileop.c +++ b/dlls/shell32/tests/shlfileop.c @@ -497,17 +497,19 @@ static void test_delete(void) shfo.lpszProgressTitle = NULL; ok(!SHFileOperationA(&shfo), "Deletion was not successful\n"); - ok(file_exists("test4.txt"), "Directory should not have been removed\n"); + ok(dir_exists("test4.txt"), "Directory should not have been removed\n"); ok(!file_exists("test1.txt"), "File should have been removed\n"); + ok(!file_exists("test2.txt"), "File should have been removed\n"); + ok(!file_exists("test3.txt"), "File should have been removed\n"); ret = SHFileOperationA(&shfo); - ok(!ret, "Directory exists, but is not removed, ret=%d\n", ret); - ok(file_exists("test4.txt"), "Directory should not have been removed\n"); + ok(ret == ERROR_SUCCESS, "Directory exists, but is not removed, ret=%d\n", ret); + ok(dir_exists("test4.txt"), "Directory should not have been removed\n"); shfo.fFlags = FOF_NOCONFIRMATION | FOF_SILENT | FOF_NOERRORUI; ok(!SHFileOperationA(&shfo), "Directory is not removed\n"); - ok(!file_exists("test4.txt"), "Directory should have been removed\n"); + ok(!dir_exists("test4.txt"), "Directory should have been removed\n"); ret = SHFileOperationA(&shfo); ok(!ret, "The requested file does not exist, ret=%d\n", ret); @@ -517,13 +519,13 @@ static void test_delete(void) buf[strlen(buf) + 1] = '\0'; ok(MoveFileA("test1.txt", "test4.txt\\test1.txt"), "Filling the subdirectory failed\n"); ok(!SHFileOperationA(&shfo), "Directory is not removed\n"); - ok(!file_exists("test4.txt"), "Directory is not removed\n"); + ok(!dir_exists("test4.txt"), "Directory is not removed\n"); init_shfo_tests(); shfo.pFrom = "test1.txt\0test4.txt\0"; ok(!SHFileOperationA(&shfo), "Directory and a file are not removed\n"); ok(!file_exists("test1.txt"), "The file should have been removed\n"); - ok(!file_exists("test4.txt"), "Directory should have been removed\n"); + ok(!dir_exists("test4.txt"), "Directory should have been removed\n"); ok(file_exists("test2.txt"), "This file should not have been removed\n"); /* FOF_FILESONLY does not delete a dir matching a wildcard */ @@ -533,13 +535,15 @@ static void test_delete(void) ok(!SHFileOperation(&shfo), "Failed to delete files\n"); ok(!file_exists("test1.txt"), "test1.txt should have been removed\n"); ok(!file_exists("test_5.txt"), "test_5.txt should have been removed\n"); - ok(file_exists("test4.txt"), "test4.txt should not have been removed\n"); + ok(dir_exists("test4.txt"), "test4.txt should not have been removed\n"); /* FOF_FILESONLY only deletes a dir if explicitly specified */ init_shfo_tests(); shfo.pFrom = "test_?.txt\0test4.txt\0"; ok(!SHFileOperation(&shfo), "Failed to delete files and directory\n"); - ok(!file_exists("test4.txt"), "test4.txt should have been removed\n"); + ok(!dir_exists("test4.txt") || + broken(dir_exists("test4.txt")), /* NT4 */ + "test4.txt should have been removed\n"); ok(!file_exists("test_5.txt"), "test_5.txt should have been removed\n"); ok(file_exists("test1.txt"), "test1.txt should not have been removed\n"); @@ -586,8 +590,10 @@ static void test_delete(void) shfo.pFrom = "testdir2\0testdir2\\one.txt\0"; shfo.wFunc = FO_DELETE; ret = SHFileOperation(&shfo); - ok(ret == ERROR_PATH_NOT_FOUND, "Expected ERROR_PATH_NOT_FOUND, got %d\n", ret); - ok(!file_exists("testdir2"), "Expected testdir2 to not exist\n"); + ok(ret == ERROR_PATH_NOT_FOUND || + broken(ret == ERROR_SUCCESS), /* NT4 */ + "Expected ERROR_PATH_NOT_FOUND, got %d\n", ret); + ok(!dir_exists("testdir2"), "Expected testdir2 to not exist\n"); ok(!file_exists("testdir2\\one.txt"), "Expected testdir2\\one.txt to not exist\n"); /* try the FOF_NORECURSION flag, continues deleting subdirs */ @@ -597,7 +603,7 @@ static void test_delete(void) ret = SHFileOperation(&shfo); ok(ret == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", ret); ok(!file_exists("testdir2\\one.txt"), "Expected testdir2\\one.txt to not exist\n"); - ok(!file_exists("testdir2\\nested"), "Expected testdir2\\nested to exist\n"); + ok(!dir_exists("testdir2\\nested"), "Expected testdir2\\nested to not exist\n"); } /* tests the FO_RENAME action */

1 0