October 2009 - Wine-commits

Jacek Caban : mshtml: Use HTMLWindow in AsyncOpen implementation.
by Alexandre Julliard 27 Oct '09

27 Oct '09

Module: wine Branch: master Commit: 50588739e367a8c18cf4213b12521910a91cc0a7 URL: http://source.winehq.org/git/wine.git/?a=commit;h=50588739e367a8c18cf4213b1… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Oct 26 23:03:29 2009 +0100 mshtml: Use HTMLWindow in AsyncOpen implementation. --- dlls/mshtml/nsio.c | 121 +++++++++++++++++++++++++-------------------------- 1 files changed, 59 insertions(+), 62 deletions(-) diff --git a/dlls/mshtml/nsio.c b/dlls/mshtml/nsio.c index 5025670..070d79e 100644 --- a/dlls/mshtml/nsio.c +++ b/dlls/mshtml/nsio.c @@ -636,9 +636,9 @@ static HRESULT create_mon_for_nschannel(nsChannel *channel, IMoniker **mon) return hres; } -static NSContainer *get_nscontainer_from_load_group(nsChannel *This) +static HTMLWindow *get_window_from_load_group(nsChannel *This) { - NSContainer *container; + HTMLWindow *window; nsIChannel *channel; nsIRequest *req; nsIWineURI *wine_uri; @@ -675,10 +675,10 @@ static NSContainer *get_nscontainer_from_load_group(nsChannel *This) return NULL; } - nsIWineURI_GetNSContainer(wine_uri, &container); + nsIWineURI_GetWindow(wine_uri, &window); nsIWineURI_Release(wine_uri); - return container; + return window; } static HTMLWindow *get_channel_window(nsChannel *This) @@ -724,49 +724,7 @@ static HTMLWindow *get_channel_window(nsChannel *This) return window; } -static nsresult async_open_doc_uri(nsChannel *This, NSContainer *container, - nsIStreamListener *listener, nsISupports *context, BOOL *open) -{ - IMoniker *mon; - HRESULT hres; - - *open = FALSE; - - if(container->bscallback) { - channelbsc_set_channel(container->bscallback, This, listener, context); - - if(container->doc && container->doc->mime) { - heap_free(This->content_type); - This->content_type = heap_strdupWtoA(container->doc->mime); - } - - return NS_OK; - }else { - BOOL cont = before_async_open(This, container); - - if(!cont) { - TRACE("canceled\n"); - return NS_ERROR_UNEXPECTED; - } - - if(!container->doc) { - return This->channel - ? nsIChannel_AsyncOpen(This->channel, listener, context) - : NS_ERROR_UNEXPECTED; - } - - hres = create_mon_for_nschannel(This, &mon); - if(FAILED(hres)) { - return NS_ERROR_UNEXPECTED; - } - set_current_mon(&container->doc->basedoc, mon); - } - - *open = TRUE; - return NS_OK; -} - -static nsresult async_open(nsChannel *This, NSContainer *container, nsIStreamListener *listener, +static nsresult async_open(nsChannel *This, HTMLWindow *window, BOOL is_doc_channel, nsIStreamListener *listener, nsISupports *context) { nsChannelBSC *bscallback; @@ -778,6 +736,9 @@ static nsresult async_open(nsChannel *This, NSContainer *container, nsIStreamLis if(FAILED(hres)) return NS_ERROR_UNEXPECTED; + if(is_doc_channel) + set_current_mon(&window->doc_obj->basedoc, mon); + bscallback = create_channelbsc(mon); IMoniker_Release(mon); @@ -785,7 +746,7 @@ static nsresult async_open(nsChannel *This, NSContainer *container, nsIStreamLis task = heap_alloc(sizeof(task_t)); - task->doc = &container->doc->basedoc; + task->doc = &window->doc_obj->basedoc; task->task_id = TASK_START_BINDING; task->next = NULL; task->bscallback = bscallback; @@ -799,8 +760,7 @@ static nsresult NSAPI nsChannel_AsyncOpen(nsIHttpChannel *iface, nsIStreamListen nsISupports *aContext) { nsChannel *This = NSCHANNEL_THIS(iface); - NSContainer *container; - HTMLWindow *window; + HTMLWindow *window = NULL; PRBool is_doc_uri; BOOL open = TRUE; nsresult nsres = NS_OK; @@ -819,32 +779,69 @@ static nsresult NSAPI nsChannel_AsyncOpen(nsIHttpChannel *iface, nsIStreamListen window = get_channel_window(This); if(window) { nsIWineURI_SetWindow(This->uri, window); - IHTMLWindow2_Release(HTMLWINDOW2(window)); + }else { + NSContainer *nscontainer; + + nsIWineURI_GetNSContainer(This->uri, &nscontainer); + if(nscontainer) { + BOOL b; + + /* nscontainer->doc should be NULL which means navigation to a new window */ + if(nscontainer->doc) + FIXME("nscontainer->doc = %p\n", nscontainer->doc); + + b = before_async_open(This, nscontainer); + nsIWebBrowserChrome_Release(NSWBCHROME(nscontainer)); + if(b) + FIXME("Navigation not cancelled\n"); + return NS_ERROR_UNEXPECTED; + } } } - nsIWineURI_GetNSContainer(This->uri, &container); + if(!window) { + nsIWineURI_GetWindow(This->uri, &window); - if(!container && This->load_group) { - container = get_nscontainer_from_load_group(This); - if(container) - nsIWineURI_SetNSContainer(This->uri, container); + if(!window && This->load_group) { + window = get_window_from_load_group(This); + if(window) + nsIWineURI_SetWindow(This->uri, window); + } } - if(!container) { - TRACE("container = NULL\n"); + if(!window) { + TRACE("window = NULL\n"); return This->channel ? nsIChannel_AsyncOpen(This->channel, aListener, aContext) : NS_ERROR_UNEXPECTED; } - if(is_doc_uri && (This->load_flags & LOAD_INITIAL_DOCUMENT_URI)) - nsres = async_open_doc_uri(This, container, aListener, aContext, &open); + if(is_doc_uri && (This->load_flags & LOAD_INITIAL_DOCUMENT_URI)) { + if(window->doc_obj->nscontainer->bscallback) { + NSContainer *nscontainer = window->doc_obj->nscontainer; + + channelbsc_set_channel(nscontainer->bscallback, This, aListener, aContext); + + if(nscontainer->doc->mime) { + heap_free(This->content_type); + This->content_type = heap_strdupWtoA(nscontainer->doc->mime); + } + + open = FALSE; + }else { + open = before_async_open(This, window->doc_obj->nscontainer); + if(!open) { + TRACE("canceled\n"); + nsres = NS_ERROR_UNEXPECTED; + } + } + } if(open) - nsres = async_open(This, container, aListener, aContext); + nsres = async_open(This, window, is_doc_uri, aListener, aContext); - nsIWebBrowserChrome_Release(NSWBCHROME(container)); + if(window) + IHTMLWindow2_Release(HTMLWINDOW2(window)); return nsres; }

1 0

Łukasz Wojniłowicz : Polish translation for release 1.1.32
by Jeremy Newman 27 Oct '09

27 Oct '09

Module: website Branch: master Commit: 60856c4a7540216878ca2a3b6fdc52183d02b62d URL: http://source.winehq.org/git/website.git/?a=commit;h=60856c4a7540216878ca2a… Author: Łukasz Wojniłowicz <lukasz.wojnilowicz(a)gmail.com> Date: Mon Oct 26 08:36:24 2009 +0100 Polish translation for release 1.1.32 --- news/pl/2009102301.xml | 17 +++++++++++++++++ 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/news/pl/2009102301.xml b/news/pl/2009102301.xml new file mode 100644 index 0000000..d5eaad2 --- /dev/null +++ b/news/pl/2009102301.xml @@ -0,0 +1,17 @@ +<news> +<date>Październik 23, 2009</date> +<title>Wydano Wine 1.1.32</title> +<body> +<p> Wydanie rozwojowe Wine 1.1.32 jest już dostępne.</p> +<p> <a href="{$root}/announce/1.1.32">Co nowego</a> w tym wydaniu: +<ul> + <li>Wiele poprawek crypto, szczególnie na 64-bitach.</li> + <li>Ulepszono dostęp do DVD na Mac OS.</li> + <li>Kilka ulepszeń w powszechnych kontrolkach (ang. common controls).</li> + <li>Rozmaite ulepszenia we wsparciu HTML.</li> + <li>Więcej optymalizacji DIB.</li> + <li>Rozmaite poprawki błędów.</li> +</ul></p> +<p><p>Źródło jest <a href="http://prdownloads.sourceforge.net/wine/wine-1.1.32.tar.bz2">już dostępne</a>. +Paczki binarne są w trakcie budowy i ukażą się wkróce w przeznaczonych dla nich <a href="{$root}/download">pobieralniach</a>. +</p></body></news>

1 0

Alexander Nicolaysen Sørnes : util: Don' t require default value in make_bugzilla_version_list()
by Alexander Nicolaysen Sørnes 27 Oct '09

27 Oct '09

Module: appdb Branch: master Commit: cfad26fc5afcdaadfa459f8d4a4b4db94f853040 URL: http://source.winehq.org/git/appdb.git/?a=commit;h=cfad26fc5afcdaadfa459f8d… Author: Alexander Nicolaysen Sørnes <alexander(a)linux-xqqm.(none)> Date: Mon Oct 26 17:08:36 2009 +0100 util: Don't require default value in make_bugzilla_version_list() --- include/util.php | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/util.php b/include/util.php index a8bce6c..7eba466 100644 --- a/include/util.php +++ b/include/util.php @@ -207,7 +207,7 @@ function get_bugzilla_version_ids() // this is the name to use to retrieve the selection on the form postback // $sSelectedValue - the currently selected entry // returns a string that contains the version list output -function make_bugzilla_version_list($sVarname, $sSelectedValue) +function make_bugzilla_version_list($sVarname, $sSelectedValue = '') { $sStr = "";

1 0

Alexander Nicolaysen Sørnes : screenshot : Add ability to specify Wine version
by Alexander Nicolaysen Sørnes 27 Oct '09

27 Oct '09

Module: appdb Branch: master Commit: 73d682044bad60b85734c7e6ee47dc3503d8daf8 URL: http://source.winehq.org/git/appdb.git/?a=commit;h=73d682044bad60b85734c7e6… Author: Alexander Nicolaysen Sørnes <alexander(a)linux-xqqm.(none)> Date: Mon Oct 26 17:25:22 2009 +0100 screenshot: Add ability to specify Wine version --- include/screenshot.php | 8 +++++--- screenshots.php | 2 ++ tables/appdb_tables.sql | 1 + 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/include/screenshot.php b/include/screenshot.php index a48b375..886682a 100644 --- a/include/screenshot.php +++ b/include/screenshot.php @@ -21,6 +21,7 @@ class screenshot var $iVersionId; var $hFile; var $sDescription; + var $sTestedVersion; var $oScreenshotImage; var $oThumbnailImage; @@ -54,6 +55,7 @@ class screenshot { $this->iScreenshotId = $oRow->id; $this->sDescription = $oRow->description; + $this->sTestedVersion = $oRow->testedVersion; $this->iAppId = $oRow->appId; $this->iVersionId = $oRow->versionId; $this->sUrl = $oRow->url; @@ -71,10 +73,10 @@ class screenshot function create() { $hResult = query_parameters("INSERT INTO appData - (versionId, type, description, state, submitTime, submitterId) - VALUES('?', '?', '?', '?', ?, '?')", + (versionId, type, description, testedVersion, state, submitTime, submitterId) + VALUES('?', '?', '?', '?', '?', ?, '?')", $this->iVersionId, "screenshot", - $this->sDescription, + $this->sDescription, $this->sTestedVersion, $this->mustBeQueued() ? 'queued' : 'accepted', "NOW()", $_SESSION['current']->iUserId); diff --git a/screenshots.php b/screenshots.php index fdb1d0b..920c50e 100644 --- a/screenshots.php +++ b/screenshots.php @@ -40,6 +40,7 @@ if($aClean['sCmd']) $oScreenshot = new Screenshot(); $oScreenshot->iVersionId = $aClean['iVersionId']; $oScreenshot->sDescription = $aClean['sScreenshotDesc']; + $oScreenshot->sTestedVersion = $aClean['sTestedVersion']; $oScreenshot->hFile = $_FILES['sImageFile']; $oScreenshot->create(); $oScreenshot->free(); @@ -149,6 +150,7 @@ if($aClean['iVersionId'] && $_SESSION['current']->isLoggedIn()) echo '<tr><td class=color1>Image</td><td class=color0><input name="sImageFile" type="file" size="24"></td></tr>',"\n"; echo '<tr><td class="color1">Description</td><td class="color0"><input type="text" name="sScreenshotDesc" maxlength="20" size="24"></td></tr>',"\n"; + echo '<tr><td class="color1">Wine version</td><td class="color0">'.make_bugzilla_version_list('sTestedVersion').'</td></tr>',"\n"; echo '<tr><td colspan=2 align=center class=color3><input type="submit" value="Send File"></td></tr>',"\n"; echo '</table>',"\n"; diff --git a/tables/appdb_tables.sql b/tables/appdb_tables.sql index 701fb62..f41c5fd 100644 --- a/tables/appdb_tables.sql +++ b/tables/appdb_tables.sql @@ -140,6 +140,7 @@ create table appData ( submitTime datetime NOT NULL, submitterId int(11) NOT NULL default '0', state enum('accepted','queued','rejected') NOT NULL default 'accepted', + testedVersion text NOT NULL KEY id (id), KEY versionId (versionId) );

1 0

Alexander Nicolaysen Sørnes : screenshot : Show Wine version
by Alexander Nicolaysen Sørnes 27 Oct '09

27 Oct '09

Module: appdb Branch: master Commit: c74053c75af34f2627bba6cd0fa2a3e9e31c1524 URL: http://source.winehq.org/git/appdb.git/?a=commit;h=c74053c75af34f2627bba6cd… Author: Alexander Nicolaysen Sørnes <alexander(a)linux-xqqm.(none)> Date: Mon Oct 26 17:36:43 2009 +0100 screenshot: Show Wine version --- screenshots.php | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/screenshots.php b/screenshots.php index 920c50e..d8ae285 100644 --- a/screenshots.php +++ b/screenshots.php @@ -102,7 +102,8 @@ if($hResult && query_num_rows($hResult)) echo "<td>\n"; echo $img; echo "<div align=center>". substr($oRow->description,0,20). "\n"; - + echo '<br />Wine version: '; + echo $oScreenshot->sTestedVersion ? $oScreenshot->sTestedVersion : 'N/A'; //show admin delete link if($_SESSION['current']->isLoggedIn() && (

1 0

Huw Davies : include: Add access.idl.
by Alexandre Julliard 26 Oct '09

26 Oct '09

Module: wine Branch: master Commit: adedd8191ee822f8725e9f3acc7a3b9cbaaa7103 URL: http://source.winehq.org/git/wine.git/?a=commit;h=adedd8191ee822f8725e9f3ac… Author: Huw Davies <huw(a)codeweavers.com> Date: Mon Oct 26 13:32:55 2009 +0000 include: Add access.idl. --- dlls/msdaps/usrmarshal.c | 67 +++++++++++++++++++++++++++++++++++++++ include/Makefile.in | 1 + include/access.idl | 79 ++++++++++++++++++++++++++++++++++++++++++++++ include/oledb.idl | 1 + tools/make_makefiles | 1 + 5 files changed, 149 insertions(+), 0 deletions(-) diff --git a/dlls/msdaps/usrmarshal.c b/dlls/msdaps/usrmarshal.c index 94a5ec5..b900a7f 100644 --- a/dlls/msdaps/usrmarshal.c +++ b/dlls/msdaps/usrmarshal.c @@ -492,3 +492,70 @@ HRESULT __RPC_STUB ICreateRow_CreateRow_Stub(ICreateRow* This, IUnknown *pUnkOut if(ppSession) *ppSession = impl_session.pSession; return hr; } + +HRESULT CALLBACK IAccessor_AddRefAccessor_Proxy(IAccessor* This, HACCESSOR hAccessor, DBREFCOUNT *pcRefCount) +{ + FIXME("(%p)->(%08lx, %p): stub\n", This, hAccessor, pcRefCount); + return E_NOTIMPL; +} + +HRESULT __RPC_STUB IAccessor_AddRefAccessor_Stub(IAccessor* This, HACCESSOR hAccessor, DBREFCOUNT *pcRefCount, + IErrorInfo **ppErrorInfoRem) +{ + FIXME("(%p)->(%08lx, %p, %p): stub\n", This, hAccessor, pcRefCount, ppErrorInfoRem); + return E_NOTIMPL; +} + +HRESULT CALLBACK IAccessor_CreateAccessor_Proxy(IAccessor* This, DBACCESSORFLAGS dwAccessorFlags, DBCOUNTITEM cBindings, + const DBBINDING rgBindings[], DBLENGTH cbRowSize, HACCESSOR *phAccessor, + DBBINDSTATUS rgStatus[]) +{ + DBCOUNTITEM i; + FIXME("(%p)->(%08x, %d, %p, %d, %p, %p): stub\n", This, dwAccessorFlags, cBindings, rgBindings, + cbRowSize, phAccessor, rgStatus); + + for(i = 0; i < cBindings; i++) + { + TRACE("%d: ord %d val off %d len off %d stat off %d part %04x mem_owner %d max_len %d type %04x\n", + i, rgBindings[i].iOrdinal, rgBindings[i].obValue, rgBindings[i].obLength, rgBindings[i].obStatus, + rgBindings[i].dwPart, rgBindings[i].dwMemOwner, rgBindings[i].cbMaxLen, rgBindings[i].wType); + } + + return E_NOTIMPL; +} + +HRESULT __RPC_STUB IAccessor_CreateAccessor_Stub(IAccessor* This, DBACCESSORFLAGS dwAccessorFlags, DBCOUNTITEM cBindings, + DBBINDING *rgBindings, DBLENGTH cbRowSize, HACCESSOR *phAccessor, + DBBINDSTATUS *rgStatus, IErrorInfo **ppErrorInfoRem) +{ + FIXME("(%p)->(%08x, %d, %p, %d, %p, %p, %p): stub\n", This, dwAccessorFlags, cBindings, rgBindings, + cbRowSize, phAccessor, rgStatus, ppErrorInfoRem); + return E_NOTIMPL; +} + +HRESULT CALLBACK IAccessor_GetBindings_Proxy(IAccessor* This, HACCESSOR hAccessor, DBACCESSORFLAGS *pdwAccessorFlags, + DBCOUNTITEM *pcBindings, DBBINDING **prgBindings) +{ + FIXME("(%p): stub\n", This); + return E_NOTIMPL; +} + +HRESULT __RPC_STUB IAccessor_GetBindings_Stub(IAccessor* This, HACCESSOR hAccessor, DBACCESSORFLAGS *pdwAccessorFlags, + DBCOUNTITEM *pcBindings, DBBINDING **prgBindings, IErrorInfo **ppErrorInfoRem) +{ + FIXME("(%p): stub\n", This); + return E_NOTIMPL; +} + +HRESULT CALLBACK IAccessor_ReleaseAccessor_Proxy(IAccessor* This, HACCESSOR hAccessor, DBREFCOUNT *pcRefCount) +{ + FIXME("(%p)->(%lx, %p): stub\n", This, hAccessor, pcRefCount); + return E_NOTIMPL; +} + +HRESULT __RPC_STUB IAccessor_ReleaseAccessor_Stub(IAccessor* This, HACCESSOR hAccessor, DBREFCOUNT *pcRefCount, + IErrorInfo **ppErrorInfoRem) +{ + FIXME("(%p)->(%lx, %p, %p): stub\n", This, hAccessor, pcRefCount, ppErrorInfoRem); + return E_NOTIMPL; +} diff --git a/include/Makefile.in b/include/Makefile.in index 6ea2210..f5b2dfd 100644 --- a/include/Makefile.in +++ b/include/Makefile.in @@ -96,6 +96,7 @@ SRCDIR_INCLUDES = \ $(IDL_TLB_SRCS) \ $(PUBLIC_IDL_H_SRCS) \ accctrl.h \ + access.idl \ aclapi.h \ aclui.h \ adshlp.h \ diff --git a/include/access.idl b/include/access.idl new file mode 100644 index 0000000..f3515af --- /dev/null +++ b/include/access.idl @@ -0,0 +1,79 @@ +/* + * Copyright (C) 2009 Huw Davies + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +[ + object, + uuid(0c733a8c-2a1c-11ce-ade5-00aa0044773d), + pointer_default(unique) +] +interface IAccessor : IUnknown +{ + + typedef DWORD DBACCESSORFLAGS; + + typedef DWORD DBBINDSTATUS; + + [local] + HRESULT AddRefAccessor([in] HACCESSOR hAccessor, + [in, out, unique, annotation("__out_opt")] DBREFCOUNT *pcRefCount); + + [call_as(AddRefAccessor)] + HRESULT RemoteAddRefAccessor([in] HACCESSOR hAccessor, + [in, out, unique, annotation("__out_opt")] DBREFCOUNT *pcRefCount, + [out] IErrorInfo **ppErrorInfoRem); + + [local] + HRESULT CreateAccessor([in] DBACCESSORFLAGS dwAccessorFlags, + [in] DBCOUNTITEM cBindings, + [in, size_is(cBindings), annotation("__in_ecount(cBindings)")] const DBBINDING rgBindings[], + [in] DBLENGTH cbRowSize, + [out, annotation("__out")] HACCESSOR *phAccessor, + [out, size_is(cBindings), annotation("__out_ecount_opt(cBindings)")] DBBINDSTATUS rgStatus[]); + + [call_as(CreateAccessor)] + HRESULT RemoteCreateAccessor([in] DBACCESSORFLAGS dwAccessorFlags, + [in] DBCOUNTITEM cBindings, + [in, unique, size_is(cBindings)] DBBINDING *rgBindings, + [in] DBLENGTH cbRowSize, + [out] HACCESSOR *phAccessor, + [in, out, unique, size_is(cBindings)] DBBINDSTATUS *rgStatus, + [out] IErrorInfo **ppErrorInfoRem); + + [local] + HRESULT GetBindings([in] HACCESSOR hAccessor, + [out, annotation("__out")] DBACCESSORFLAGS *pdwAccessorFlags, + [in, out, annotation("__out_opt")] DBCOUNTITEM *pcBindings, + [out, size_is(,*pcBindings), annotation("__deref_out_ecount_opt(*pcBindings)")] DBBINDING **prgBindings); + + [call_as(GetBindings)] + HRESULT RemoteGetBindings([in] HACCESSOR hAccessor, + [out] DBACCESSORFLAGS *pdwAccessorFlags, + [in, out] DBCOUNTITEM *pcBindings, + [out, size_is(,*pcBindings)] DBBINDING **prgBindings, + [out] IErrorInfo **ppErrorInfoRem); + + [local] + HRESULT ReleaseAccessor([in] HACCESSOR hAccessor, + [in, out, unique, annotation("__out_opt")] DBREFCOUNT *pcRefCount); + + [call_as(ReleaseAccessor)] + HRESULT RemoteReleaseAccessor([in] HACCESSOR hAccessor, + [in, out, unique] DBREFCOUNT *pcRefCount, + [out] IErrorInfo **ppErrorInfoRem); + +}; diff --git a/include/oledb.idl b/include/oledb.idl index 030f049..a488c47 100644 --- a/include/oledb.idl +++ b/include/oledb.idl @@ -39,6 +39,7 @@ typedef LONG DB_LPARAMS; #include "dbs.idl" +#include "access.idl" #include "dbccmd.idl" #include "dbcses.idl" #include "dbprop.idl" diff --git a/tools/make_makefiles b/tools/make_makefiles index 3883333..5e724ff 100755 --- a/tools/make_makefiles +++ b/tools/make_makefiles @@ -109,6 +109,7 @@ my %exported_wine_headers = ( ); my %private_idl_headers = ( + "access.idl" => 1, "axcore.idl" => 1, "axextend.idl" => 1, "binres.idl" => 1,

1 0

Huw Davies : msdaps: Implement CreateAccessor Proxy and Stub.
by Alexandre Julliard 26 Oct '09

26 Oct '09

Module: wine Branch: master Commit: 18323f0ba5d80f59b5ca294fde73f2a43ba33166 URL: http://source.winehq.org/git/wine.git/?a=commit;h=18323f0ba5d80f59b5ca294fd… Author: Huw Davies <huw(a)codeweavers.com> Date: Mon Oct 26 13:40:40 2009 +0000 msdaps: Implement CreateAccessor Proxy and Stub. --- dlls/msdaps/usrmarshal.c | 28 ++++++++++++++++++++++++---- 1 files changed, 24 insertions(+), 4 deletions(-) diff --git a/dlls/msdaps/usrmarshal.c b/dlls/msdaps/usrmarshal.c index b900a7f..01dcfc6 100644 --- a/dlls/msdaps/usrmarshal.c +++ b/dlls/msdaps/usrmarshal.c @@ -510,8 +510,11 @@ HRESULT CALLBACK IAccessor_CreateAccessor_Proxy(IAccessor* This, DBACCESSORFLAGS const DBBINDING rgBindings[], DBLENGTH cbRowSize, HACCESSOR *phAccessor, DBBINDSTATUS rgStatus[]) { + HRESULT hr; + IErrorInfo *error; DBCOUNTITEM i; - FIXME("(%p)->(%08x, %d, %p, %d, %p, %p): stub\n", This, dwAccessorFlags, cBindings, rgBindings, + + TRACE("(%p)->(%08x, %d, %p, %d, %p, %p)\n", This, dwAccessorFlags, cBindings, rgBindings, cbRowSize, phAccessor, rgStatus); for(i = 0; i < cBindings; i++) @@ -521,16 +524,33 @@ HRESULT CALLBACK IAccessor_CreateAccessor_Proxy(IAccessor* This, DBACCESSORFLAGS rgBindings[i].dwPart, rgBindings[i].dwMemOwner, rgBindings[i].cbMaxLen, rgBindings[i].wType); } - return E_NOTIMPL; + hr = IAccessor_RemoteCreateAccessor_Proxy(This, dwAccessorFlags, cBindings, (DBBINDING *)rgBindings, + cbRowSize, phAccessor, rgStatus, &error); + if(error) + { + SetErrorInfo(0, error); + IErrorInfo_Release(error); + } + + TRACE("returning %08x accessor %lx\n", hr, *phAccessor); + return hr; } HRESULT __RPC_STUB IAccessor_CreateAccessor_Stub(IAccessor* This, DBACCESSORFLAGS dwAccessorFlags, DBCOUNTITEM cBindings, DBBINDING *rgBindings, DBLENGTH cbRowSize, HACCESSOR *phAccessor, DBBINDSTATUS *rgStatus, IErrorInfo **ppErrorInfoRem) { - FIXME("(%p)->(%08x, %d, %p, %d, %p, %p, %p): stub\n", This, dwAccessorFlags, cBindings, rgBindings, + HRESULT hr; + + TRACE("(%p)->(%08x, %d, %p, %d, %p, %p, %p)\n", This, dwAccessorFlags, cBindings, rgBindings, cbRowSize, phAccessor, rgStatus, ppErrorInfoRem); - return E_NOTIMPL; + + *ppErrorInfoRem = NULL; + hr = IAccessor_CreateAccessor(This, dwAccessorFlags, cBindings, rgBindings, + cbRowSize, phAccessor, rgStatus); + if(FAILED(hr)) GetErrorInfo(0, ppErrorInfoRem); + + return hr; } HRESULT CALLBACK IAccessor_GetBindings_Proxy(IAccessor* This, HACCESSOR hAccessor, DBACCESSORFLAGS *pdwAccessorFlags,

1 0

Huw Davies : msdaps: Implement ReleaseAccessor Proxy and Stub.
by Alexandre Julliard 26 Oct '09

26 Oct '09

Module: wine Branch: master Commit: d1472e2af21618070005b46c904fee835da4a169 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d1472e2af21618070005b46c9… Author: Huw Davies <huw(a)codeweavers.com> Date: Mon Oct 26 13:48:09 2009 +0000 msdaps: Implement ReleaseAccessor Proxy and Stub. --- dlls/msdaps/usrmarshal.c | 29 +++++++++++++++++++++++++---- 1 files changed, 25 insertions(+), 4 deletions(-) diff --git a/dlls/msdaps/usrmarshal.c b/dlls/msdaps/usrmarshal.c index 01dcfc6..ae812ad 100644 --- a/dlls/msdaps/usrmarshal.c +++ b/dlls/msdaps/usrmarshal.c @@ -569,13 +569,34 @@ HRESULT __RPC_STUB IAccessor_GetBindings_Stub(IAccessor* This, HACCESSOR hAccess HRESULT CALLBACK IAccessor_ReleaseAccessor_Proxy(IAccessor* This, HACCESSOR hAccessor, DBREFCOUNT *pcRefCount) { - FIXME("(%p)->(%lx, %p): stub\n", This, hAccessor, pcRefCount); - return E_NOTIMPL; + HRESULT hr; + IErrorInfo *error; + DBREFCOUNT ref; + + TRACE("(%p)->(%lx, %p)\n", This, hAccessor, pcRefCount); + + hr = IAccessor_RemoteReleaseAccessor_Proxy(This, hAccessor, &ref, &error); + + if(pcRefCount) *pcRefCount = ref; + if(error) + { + SetErrorInfo(0, error); + IErrorInfo_Release(error); + } + return hr; } HRESULT __RPC_STUB IAccessor_ReleaseAccessor_Stub(IAccessor* This, HACCESSOR hAccessor, DBREFCOUNT *pcRefCount, IErrorInfo **ppErrorInfoRem) { - FIXME("(%p)->(%lx, %p, %p): stub\n", This, hAccessor, pcRefCount, ppErrorInfoRem); - return E_NOTIMPL; + HRESULT hr; + + TRACE("(%p)->(%lx, %p, %p)\n", This, hAccessor, pcRefCount, ppErrorInfoRem); + + *ppErrorInfoRem = NULL; + + hr = IAccessor_ReleaseAccessor(This, hAccessor, pcRefCount); + + if(FAILED(hr)) GetErrorInfo(0, ppErrorInfoRem); + return hr; }

1 0

Huw Davies : include: Flesh out dbs.idl a bit.
by Alexandre Julliard 26 Oct '09

26 Oct '09

Module: wine Branch: master Commit: 44967f0609a9b731ca831e095dc8328b4b901929 URL: http://source.winehq.org/git/wine.git/?a=commit;h=44967f0609a9b731ca831e095… Author: Huw Davies <huw(a)codeweavers.com> Date: Mon Oct 26 13:29:41 2009 +0000 include: Flesh out dbs.idl a bit. --- include/dbs.idl | 134 +++++++++++++++++++++++++++++++++++++++++++++++++++++ include/oledb.idl | 5 ++ 2 files changed, 139 insertions(+), 0 deletions(-) diff --git a/include/dbs.idl b/include/dbs.idl index e39ee97..dd12628 100644 --- a/include/dbs.idl +++ b/include/dbs.idl @@ -151,6 +151,18 @@ enum DBTYPEENUM DBTYPE_RESERVED = 0x8000 }; +enum DBTYPEENUM15 +{ + DBTYPE_HCHAPTER = 136 +}; + +enum DBTYPEENUM20 +{ + DBTYPE_FILETIME = 64, + DBTYPE_PROPVARIANT = 138, + DBTYPE_VARNUMERIC = 139 +}; + typedef DWORD DBSTATUS; enum DBSTATUSENUM @@ -170,3 +182,125 @@ enum DBSTATUSENUM DBSTATUS_E_BADSTATUS = 12, DBSTATUS_S_DEFAULT = 13 }; + +typedef struct tagDBCOLUMNACCESS +{ + void *pData; + DBID columnid; + DBLENGTH cbDataLen; + DBSTATUS dwStatus; + DBLENGTH cbMaxLen; + DB_DWRESERVE dwReserved; + DBTYPE wType; + BYTE bPrecision; + BYTE bScale; +} DBCOLUMNACCESS; + +typedef DWORD DBROWSTATUS; + +enum DBROWSTATUSENUM +{ + DBROWSTATUS_S_OK = 0, + /* FIXME */ + DBROWSTATUS_E_FAIL = 19, + +}; + +typedef DWORD DBPART; + +enum DBPARTENUM +{ + DBPART_INVALID = 0, + DBPART_VALUE = 1, + DBPART_LENGTH = 2, + DBPART_STATUS = 4, +}; + +typedef DWORD DBPARAMIO; + +enum DBPARAMIOENUM +{ + DBPARAMIO_NOTPARAM = 0, + DBPARAMIO_INPUT = 1, + DBPARAMIO_OUTPUT = 2, +}; + +typedef DWORD DBMEMOWNER; + +enum DBMEMOWNERENUM +{ + DBMEMOWNER_CLIENTOWNED = 0, + DBMEMOWNER_PROVIDEROWNED = 1, +}; + +typedef struct tagDBOBJECT +{ + DWORD dwFlags; + IID iid; +} DBOBJECT; + +typedef struct tagDBBINDEXT +{ + [size_is((ULONG)ulExtension)] BYTE *pExtension; + DBCOUNTITEM ulExtension; +} DBBINDEXT; + +typedef struct tagDBBINDING +{ + DBORDINAL iOrdinal; + DBBYTEOFFSET obValue; + DBBYTEOFFSET obLength; + DBBYTEOFFSET obStatus; + ITypeInfo *pTypeInfo; + DBOBJECT *pObject; + DBBINDEXT *pBindExt; + DBPART dwPart; + DBMEMOWNER dwMemOwner; + DBPARAMIO eParamIO; + DBLENGTH cbMaxLen; + DWORD dwFlags; + DBTYPE wType; + BYTE bPrecision; + BYTE bScale; +} DBBINDING; + +typedef ULONG_PTR HACCESSOR; + +cpp_quote("#define DB_INVALID_HACCESSOR 0x00") + +typedef ULONG_PTR HROW; + +cpp_quote("#define DB_NULL_HROW 0x00") + +typedef ULONG_PTR HWATCHREGION; + +cpp_quote("#define DBWATCHREGION_NULL NULL") + +typedef ULONG_PTR HCHAPTER; + +cpp_quote("#define DB_NULL_HCHAPTER 0x00") + +typedef struct tagDBPARAMS +{ + void *pData; + DB_UPARAMS cParamSets; + HACCESSOR hAccessor; +} DBPARAMS; + +typedef struct tagRMTPACK +{ + ISequentialStream *pISeqStream; + ULONG cbData; + ULONG cBSTR; + [size_is(cBSTR)] BSTR *rgBSTR; + ULONG cVARIANT; + [size_is(cVARIANT)] VARIANT *rgVARIANT; + ULONG cIDISPATCH; + [size_is(cIDISPATCH)] IDispatch **rgIDISPATCH; + ULONG cIUNKNOWN; + [size_is(cIUNKNOWN)] IUnknown **rgIUNKNOWN; + ULONG cPROPVARIANT; + [size_is(cPROPVARIANT)] PROPVARIANT *rgPROPVARIANT; + ULONG cArray; + [size_is(cArray)] VARIANT *rgArray; +} RMTPACK; diff --git a/include/oledb.idl b/include/oledb.idl index 5c66912..030f049 100644 --- a/include/oledb.idl +++ b/include/oledb.idl @@ -31,6 +31,11 @@ import "urlmon.idl"; typedef ULONG DBBYTEOFFSET; typedef ULONG DBCOUNTITEM; typedef ULONG DBLENGTH; +typedef ULONG DBORDINAL; +typedef DWORD DB_DWRESERVE; +typedef ULONG DBREFCOUNT; +typedef ULONG DB_UPARAMS; +typedef LONG DB_LPARAMS; #include "dbs.idl"

1 0

André Hentschel : appwiz: Ignore apps without title in the list.
by Alexandre Julliard 26 Oct '09

26 Oct '09

Module: wine Branch: master Commit: a5107da440d9933f69bc298ce86b1f0a51464129 URL: http://source.winehq.org/git/wine.git/?a=commit;h=a5107da440d9933f69bc298ce… Author: André Hentschel <nerv(a)dawncrow.de> Date: Mon Oct 26 13:16:54 2009 +0100 appwiz: Ignore apps without title in the list. --- dlls/appwiz.cpl/appwiz.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dlls/appwiz.cpl/appwiz.c b/dlls/appwiz.cpl/appwiz.c index 0d9e555..bafd319 100644 --- a/dlls/appwiz.cpl/appwiz.c +++ b/dlls/appwiz.cpl/appwiz.c @@ -340,13 +340,15 @@ end: */ static void AddApplicationsToList(HWND hWnd, HIMAGELIST hList) { - APPINFO *iter = AppInfo; + APPINFO *iter; LVITEMW lvItem; HICON hIcon; int index; - while (iter) + for (iter = AppInfo; iter; iter = iter->next) { + if (!iter->title[0]) continue; + /* get the icon */ index = 0; @@ -371,8 +373,6 @@ static void AddApplicationsToList(HWND hWnd, HIMAGELIST hList) /* now add the subitems (columns) */ ListView_SetItemTextW(hWnd, index, 1, iter->publisher); ListView_SetItemTextW(hWnd, index, 2, iter->version); - - iter = iter->next; } }

1 0