November 2009 - Wine-commits

Piotr Caban : msxml3: Implemented xmlnode_get_nodeTypedValue date related data types handling.
by Alexandre Julliard 18 Nov '09

18 Nov '09

Module: wine Branch: master Commit: 0d78a883c00f60010db254d14c82e7ac26f92d08 URL: http://source.winehq.org/git/wine.git/?a=commit;h=0d78a883c00f60010db254d14… Author: Piotr Caban <piotr.caban(a)gmail.com> Date: Wed Nov 18 00:51:40 2009 +0100 msxml3: Implemented xmlnode_get_nodeTypedValue date related data types handling. --- dlls/msxml3/node.c | 67 ++++++++++++++++++++++++++++++++++++++++ dlls/msxml3/tests/domdoc.c | 72 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 139 insertions(+), 0 deletions(-) diff --git a/dlls/msxml3/node.c b/dlls/msxml3/node.c index f293154..4910605 100644 --- a/dlls/msxml3/node.c +++ b/dlls/msxml3/node.c @@ -957,6 +957,73 @@ inline HRESULT VARIANT_from_xmlChar(xmlChar *str, VARIANT *v, BSTR type) if(!V_BSTR(v)) return E_OUTOFMEMORY; } + else if(!lstrcmpiW(type, szDateTime) || !lstrcmpiW(type, szDateTimeTZ) || + !lstrcmpiW(type, szDate) || !lstrcmpiW(type, szTime) || + !lstrcmpiW(type, szTimeTZ)) + { + VARIANT src; + WCHAR *p, *e; + SYSTEMTIME st; + DOUBLE date = 0.0; + + st.wYear = 1899; + st.wMonth = 12; + st.wDay = 30; + st.wDayOfWeek = st.wHour = st.wMinute = st.wSecond = st.wMilliseconds = 0; + + V_VT(&src) = VT_BSTR; + V_BSTR(&src) = bstr_from_xmlChar(str); + + if(!V_BSTR(&src)) + return E_OUTOFMEMORY; + + p = V_BSTR(&src); + e = p + SysStringLen(V_BSTR(&src)); + + if(p+4<e && *(p+4)=='-') /* parse date (yyyy-mm-dd) */ + { + st.wYear = atoiW(p); + st.wMonth = atoiW(p+5); + st.wDay = atoiW(p+8); + p += 10; + + if(*p == 'T') p++; + } + + if(p+2<e && *(p+2)==':') /* parse time (hh:mm:ss.?) */ + { + st.wHour = atoiW(p); + st.wMinute = atoiW(p+3); + st.wSecond = atoiW(p+6); + p += 8; + + if(*p == '.') + { + int ms; + + p++; + ms = (*(p++) - '0') * 10; + if(isdigitW(*p)) ms += *(p++) - '0'; + ms *= 10; + if(isdigitW(*p)) ms += *(p++) - '0'; + + st.wMilliseconds = ms; + + while(isdigitW(*p)) p++; + } + } + + SystemTimeToVariantTime(&st, &date); + V_VT(v) = VT_DATE; + V_DATE(v) = date; + + if(*p == '+') /* parse timezone offset (+hh:mm) */ + V_DATE(v) += (DOUBLE)atoiW(p+1)/24 + (DOUBLE)atoiW(p+4)/1440; + else if(*p == '-') /* parse timezone offset (-hh:mm) */ + V_DATE(v) -= (DOUBLE)atoiW(p+1)/24 + (DOUBLE)atoiW(p+4)/1440; + + VariantClear(&src); + } else { VARIANT src; diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c index 8efbddd..7c8fddf 100644 --- a/dlls/msxml3/tests/domdoc.c +++ b/dlls/msxml3/tests/domdoc.c @@ -156,6 +156,11 @@ static const CHAR szTypeValueXML[] = " <int dt:dt=\"int\">-13</int>\n" " <fixed dt:dt=\"fixed.14.4\">7322.9371</fixed>\n" " <bool dt:dt=\"boolean\">1</bool>\n" +" <datetime dt:dt=\"datetime\">2009-11-18T03:21:33.12</datetime>\n" +" <datetimetz dt:dt=\"datetime.tz\">2003-07-11T11:13:57+03:00</datetimetz>\n" +" <date dt:dt=\"date\">3721-11-01</date>\n" +" <time dt:dt=\"time\">13:57:12.31321</time>\n" +" <timetz dt:dt=\"time.tz\">23:21:01.13+03:21</timetz>\n" "</root>"; static const CHAR szBasicTransformSSXMLPart1[] = @@ -252,6 +257,8 @@ static WCHAR szStrangeChars[] = {'&','x',' ',0x2103, 0}; ok(r == (expect), #expr " returned %x, expected %x\n", r, expect); \ } +#define double_eq(x, y) ok((x)-(y)<=1e-14*(x) && (x)-(y)>=-1e-14*(x), "expected %.16g, got %.16g\n", x, y) + static BSTR alloc_str_from_narrow(const char *str) { int len = MultiByteToWideChar(CP_ACP, 0, str, -1, NULL, 0); @@ -4087,6 +4094,71 @@ static void test_NodeTypeValue(void) IXMLDOMNode_Release(pNode); } + + hr = IXMLDOMDocument2_selectSingleNode(doc, _bstr_("root/datetime"), &pNode); + ok(hr == S_OK, "ret %08x\n", hr ); + if(hr == S_OK) + { + hr = IXMLDOMNode_get_nodeTypedValue(pNode, &v); + ok(hr == S_OK, "ret %08x\n", hr ); + ok(V_VT(&v) == VT_DATE, "incorrect type\n"); + double_eq(40135.13996666666, V_DATE(&v)); + VariantClear( &v ); + + IXMLDOMNode_Release(pNode); + } + + hr = IXMLDOMDocument2_selectSingleNode(doc, _bstr_("root/datetimetz"), &pNode); + ok(hr == S_OK, "ret %08x\n", hr ); + if(hr == S_OK) + { + hr = IXMLDOMNode_get_nodeTypedValue(pNode, &v); + ok(hr == S_OK, "ret %08x\n", hr ); + ok(V_VT(&v) == VT_DATE, "incorrect type\n"); + double_eq(37813.59302083334, V_DATE(&v)); + VariantClear( &v ); + + IXMLDOMNode_Release(pNode); + } + + hr = IXMLDOMDocument2_selectSingleNode(doc, _bstr_("root/date"), &pNode); + ok(hr == S_OK, "ret %08x\n", hr ); + if(hr == S_OK) + { + hr = IXMLDOMNode_get_nodeTypedValue(pNode, &v); + ok(hr == S_OK, "ret %08x\n", hr ); + ok(V_VT(&v) == VT_DATE, "incorrect type\n"); + double_eq(665413.0, V_DATE(&v)); + VariantClear( &v ); + + IXMLDOMNode_Release(pNode); + } + + hr = IXMLDOMDocument2_selectSingleNode(doc, _bstr_("root/time"), &pNode); + ok(hr == S_OK, "ret %08x\n", hr ); + if(hr == S_OK) + { + hr = IXMLDOMNode_get_nodeTypedValue(pNode, &v); + ok(hr == S_OK, "ret %08x\n", hr ); + ok(V_VT(&v) == VT_DATE, "incorrect type\n"); + double_eq(0.581392511574074, V_DATE(&v)); + VariantClear( &v ); + + IXMLDOMNode_Release(pNode); + } + + hr = IXMLDOMDocument2_selectSingleNode(doc, _bstr_("root/timetz"), &pNode); + ok(hr == S_OK, "ret %08x\n", hr ); + if(hr == S_OK) + { + hr = IXMLDOMNode_get_nodeTypedValue(pNode, &v); + ok(hr == S_OK, "ret %08x\n", hr ); + ok(V_VT(&v) == VT_DATE, "incorrect type\n"); + double_eq(1.112513078703703, V_DATE(&v)); + VariantClear( &v ); + + IXMLDOMNode_Release(pNode); + } } IXMLDOMDocument2_Release(doc);

1 0

Rob Shearman : rpcrt4: Add test for calling NdrFullPointerQueryRefId with a 0 pointer ID.
by Alexandre Julliard 18 Nov '09

18 Nov '09

Module: wine Branch: master Commit: d6f293f7be7a8d4093e9233b841d94eb8d729ff3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d6f293f7be7a8d4093e9233b8… Author: Rob Shearman <robertshearman(a)gmail.com> Date: Wed Nov 18 11:40:44 2009 +0000 rpcrt4: Add test for calling NdrFullPointerQueryRefId with a 0 pointer ID. --- dlls/rpcrt4/tests/ndr_marshall.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/dlls/rpcrt4/tests/ndr_marshall.c b/dlls/rpcrt4/tests/ndr_marshall.c index 9781115..dbf29a5 100644 --- a/dlls/rpcrt4/tests/ndr_marshall.c +++ b/dlls/rpcrt4/tests/ndr_marshall.c @@ -1046,6 +1046,10 @@ static void test_fullpointer_xlat(void) /* "unmarshaling" phase */ + ret = NdrFullPointerQueryRefId(pXlatTables, 0x0, 0, &Pointer); + todo_wine + ok(ret == 1, "ret should be 1 instead of 0x%x\n", ret); + ret = NdrFullPointerQueryRefId(pXlatTables, 0x2, 0, &Pointer); ok(ret == 0, "ret should be 0 instead of 0x%x\n", ret); ok(Pointer == (void *)0xcafebabe, "Pointer should be 0xcafebabe instead of %p\n", Pointer);

1 0

Henri Verbeet : wined3d: Move the various backend selection utility functions to utils.c.
by Alexandre Julliard 18 Nov '09

18 Nov '09

Module: wine Branch: master Commit: e4d8a3f309375ec4b749ac26487f566bb1f3bd29 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e4d8a3f309375ec4b749ac264… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed Nov 18 10:45:52 2009 +0100 wined3d: Move the various backend selection utility functions to utils.c. --- dlls/wined3d/directx.c | 103 ---------------------------------------- dlls/wined3d/utils.c | 60 +++++++++++++++++++++++ dlls/wined3d/wined3d_private.h | 8 +++ 3 files changed, 68 insertions(+), 103 deletions(-) diff --git a/dlls/wined3d/directx.c b/dlls/wined3d/directx.c index f9cec29..774dfec 100644 --- a/dlls/wined3d/directx.c +++ b/dlls/wined3d/directx.c @@ -155,10 +155,6 @@ static const struct { **********************************************************/ static HRESULT WINAPI IWineD3DImpl_CheckDeviceFormat(IWineD3D *iface, UINT Adapter, WINED3DDEVTYPE DeviceType, WINED3DFORMAT AdapterFormat, DWORD Usage, WINED3DRESOURCETYPE RType, WINED3DFORMAT CheckFormat, WINED3DSURFTYPE SurfaceType); -static const struct fragment_pipeline *select_fragment_implementation(struct wined3d_adapter *adapter, - WINED3DDEVTYPE DeviceType); -static const shader_backend_t *select_shader_backend(struct wined3d_adapter *adapter, WINED3DDEVTYPE DeviceType); -static const struct blit_shader *select_blit_implementation(struct wined3d_adapter *adapter, WINED3DDEVTYPE DeviceType); GLint wrap_lookup[WINED3DTADDRESS_MIRRORONCE - WINED3DTADDRESS_WRAP + 1]; @@ -389,39 +385,6 @@ static ULONG WINAPI IWineD3DImpl_Release(IWineD3D *iface) { return ref; } -/* Set the shader type for this device, depending on the given capabilities - * and the user preferences in wined3d_settings. */ -static void select_shader_mode(const struct wined3d_gl_info *gl_info, int *ps_selected, int *vs_selected) -{ - if (wined3d_settings.vs_mode == VS_NONE) { - *vs_selected = SHADER_NONE; - } else if (gl_info->supported[ARB_VERTEX_SHADER] && wined3d_settings.glslRequested) { - /* Geforce4 cards support GLSL but for vertex shaders only. Further its reported GLSL caps are - * wrong. This combined with the fact that glsl won't offer more features or performance, use ARB - * shaders only on this card. */ - if (gl_info->supported[NV_VERTEX_PROGRAM] && !gl_info->supported[NV_VERTEX_PROGRAM2]) - *vs_selected = SHADER_ARB; - else - *vs_selected = SHADER_GLSL; - } else if (gl_info->supported[ARB_VERTEX_PROGRAM]) { - *vs_selected = SHADER_ARB; - } else { - *vs_selected = SHADER_NONE; - } - - if (wined3d_settings.ps_mode == PS_NONE) { - *ps_selected = SHADER_NONE; - } else if (gl_info->supported[ARB_FRAGMENT_SHADER] && wined3d_settings.glslRequested) { - *ps_selected = SHADER_GLSL; - } else if (gl_info->supported[ARB_FRAGMENT_PROGRAM]) { - *ps_selected = SHADER_ARB; - } else if (gl_info->supported[ATI_FRAGMENT_SHADER]) { - *ps_selected = SHADER_ATI; - } else { - *ps_selected = SHADER_NONE; - } -} - /********************************************************** * IWineD3D parts follows **********************************************************/ @@ -3810,72 +3773,6 @@ static HRESULT WINAPI IWineD3DImpl_CheckDeviceFormatConversion(IWineD3D *iface, return WINED3D_OK; } -static const shader_backend_t *select_shader_backend(struct wined3d_adapter *adapter, WINED3DDEVTYPE DeviceType) -{ - const shader_backend_t *ret; - int vs_selected_mode; - int ps_selected_mode; - - select_shader_mode(&adapter->gl_info, &ps_selected_mode, &vs_selected_mode); - if (vs_selected_mode == SHADER_GLSL || ps_selected_mode == SHADER_GLSL) { - ret = &glsl_shader_backend; - } else if (vs_selected_mode == SHADER_ARB || ps_selected_mode == SHADER_ARB) { - ret = &arb_program_shader_backend; - } else { - ret = &none_shader_backend; - } - return ret; -} - -static const struct fragment_pipeline *select_fragment_implementation(struct wined3d_adapter *adapter, - WINED3DDEVTYPE DeviceType) -{ - const struct wined3d_gl_info *gl_info = &adapter->gl_info; - int vs_selected_mode; - int ps_selected_mode; - - select_shader_mode(&adapter->gl_info, &ps_selected_mode, &vs_selected_mode); - if ((ps_selected_mode == SHADER_ARB || ps_selected_mode == SHADER_GLSL) - && gl_info->supported[ARB_FRAGMENT_PROGRAM]) - { - return &arbfp_fragment_pipeline; - } - else if (ps_selected_mode == SHADER_ATI) - { - return &atifs_fragment_pipeline; - } - else if (gl_info->supported[NV_REGISTER_COMBINERS] && gl_info->supported[NV_TEXTURE_SHADER2]) - { - return &nvts_fragment_pipeline; - } - else if (gl_info->supported[NV_REGISTER_COMBINERS]) - { - return &nvrc_fragment_pipeline; - } - else - { - return &ffp_fragment_pipeline; - } -} - -static const struct blit_shader *select_blit_implementation(struct wined3d_adapter *adapter, WINED3DDEVTYPE DeviceType) -{ - const struct wined3d_gl_info *gl_info = &adapter->gl_info; - int vs_selected_mode; - int ps_selected_mode; - - select_shader_mode(&adapter->gl_info, &ps_selected_mode, &vs_selected_mode); - if ((ps_selected_mode == SHADER_ARB || ps_selected_mode == SHADER_GLSL) - && gl_info->supported[ARB_FRAGMENT_PROGRAM]) - { - return &arbfp_blit; - } - else - { - return &ffp_blit; - } -} - /* Note: d3d8 passes in a pointer to a D3DCAPS8 structure, which is a true subset of a D3DCAPS9 structure. However, it has to come via a void * as the d3d8 interface cannot import the d3d9 header */ diff --git a/dlls/wined3d/utils.c b/dlls/wined3d/utils.c index 54b0fb7..1b4516a 100644 --- a/dlls/wined3d/utils.c +++ b/dlls/wined3d/utils.c @@ -2772,3 +2772,63 @@ UINT wined3d_log2i(UINT32 x) return (i = x >> 16) ? (x = i >> 8) ? l[x] + 24 : l[i] + 16 : (i = x >> 8) ? l[i] + 8 : l[x]; } + +/* Set the shader type for this device, depending on the given capabilities + * and the user preferences in wined3d_settings. */ +void select_shader_mode(const struct wined3d_gl_info *gl_info, int *ps_selected, int *vs_selected) +{ + if (wined3d_settings.vs_mode == VS_NONE) *vs_selected = SHADER_NONE; + else if (gl_info->supported[ARB_VERTEX_SHADER] && wined3d_settings.glslRequested) + { + /* Geforce4 cards support GLSL but for vertex shaders only. Further its reported GLSL caps are + * wrong. This combined with the fact that glsl won't offer more features or performance, use ARB + * shaders only on this card. */ + if (gl_info->supported[NV_VERTEX_PROGRAM] && !gl_info->supported[NV_VERTEX_PROGRAM2]) *vs_selected = SHADER_ARB; + else *vs_selected = SHADER_GLSL; + } + else if (gl_info->supported[ARB_VERTEX_PROGRAM]) *vs_selected = SHADER_ARB; + else *vs_selected = SHADER_NONE; + + if (wined3d_settings.ps_mode == PS_NONE) *ps_selected = SHADER_NONE; + else if (gl_info->supported[ARB_FRAGMENT_SHADER] && wined3d_settings.glslRequested) *ps_selected = SHADER_GLSL; + else if (gl_info->supported[ARB_FRAGMENT_PROGRAM]) *ps_selected = SHADER_ARB; + else if (gl_info->supported[ATI_FRAGMENT_SHADER]) *ps_selected = SHADER_ATI; + else *ps_selected = SHADER_NONE; +} + +const shader_backend_t *select_shader_backend(struct wined3d_adapter *adapter, WINED3DDEVTYPE device_type) +{ + int vs_selected_mode, ps_selected_mode; + + select_shader_mode(&adapter->gl_info, &ps_selected_mode, &vs_selected_mode); + if (vs_selected_mode == SHADER_GLSL || ps_selected_mode == SHADER_GLSL) return &glsl_shader_backend; + if (vs_selected_mode == SHADER_ARB || ps_selected_mode == SHADER_ARB) return &arb_program_shader_backend; + return &none_shader_backend; +} + +const struct fragment_pipeline *select_fragment_implementation(struct wined3d_adapter *adapter, + WINED3DDEVTYPE device_type) +{ + const struct wined3d_gl_info *gl_info = &adapter->gl_info; + int vs_selected_mode, ps_selected_mode; + + select_shader_mode(gl_info, &ps_selected_mode, &vs_selected_mode); + if ((ps_selected_mode == SHADER_ARB || ps_selected_mode == SHADER_GLSL) + && gl_info->supported[ARB_FRAGMENT_PROGRAM]) return &arbfp_fragment_pipeline; + else if (ps_selected_mode == SHADER_ATI) return &atifs_fragment_pipeline; + else if (gl_info->supported[NV_REGISTER_COMBINERS] + && gl_info->supported[NV_TEXTURE_SHADER2]) return &nvts_fragment_pipeline; + else if (gl_info->supported[NV_REGISTER_COMBINERS]) return &nvrc_fragment_pipeline; + else return &ffp_fragment_pipeline; +} + +const struct blit_shader *select_blit_implementation(struct wined3d_adapter *adapter, WINED3DDEVTYPE device_type) +{ + const struct wined3d_gl_info *gl_info = &adapter->gl_info; + int vs_selected_mode, ps_selected_mode; + + select_shader_mode(gl_info, &ps_selected_mode, &vs_selected_mode); + if ((ps_selected_mode == SHADER_ARB || ps_selected_mode == SHADER_GLSL) + && gl_info->supported[ARB_FRAGMENT_PROGRAM]) return &arbfp_blit; + else return &ffp_blit; +} diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h index f423733..1c8c539 100644 --- a/dlls/wined3d/wined3d_private.h +++ b/dlls/wined3d/wined3d_private.h @@ -2525,6 +2525,14 @@ void multiply_matrix(WINED3DMATRIX *dest, const WINED3DMATRIX *src1, const WINED UINT wined3d_log2i(UINT32 x) DECLSPEC_HIDDEN; unsigned int count_bits(unsigned int mask) DECLSPEC_HIDDEN; +const struct blit_shader *select_blit_implementation(struct wined3d_adapter *adapter, + WINED3DDEVTYPE device_type) DECLSPEC_HIDDEN; +const struct fragment_pipeline *select_fragment_implementation(struct wined3d_adapter *adapter, + WINED3DDEVTYPE device_type) DECLSPEC_HIDDEN; +const shader_backend_t *select_shader_backend(struct wined3d_adapter *adapter, + WINED3DDEVTYPE device_type) DECLSPEC_HIDDEN; +void select_shader_mode(const struct wined3d_gl_info *gl_info, int *ps_selected, int *vs_selected) DECLSPEC_HIDDEN; + typedef struct local_constant { struct list entry; unsigned int idx;

1 0

Henri Verbeet : wined3d: Add a separate function for device initialization.
by Alexandre Julliard 18 Nov '09

18 Nov '09

Module: wine Branch: master Commit: 135e6cea7b607e5806304434b8f05e37c179bceb URL: http://source.winehq.org/git/wine.git/?a=commit;h=135e6cea7b607e5806304434b… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed Nov 18 10:45:53 2009 +0100 wined3d: Add a separate function for device initialization. --- dlls/wined3d/device.c | 86 +++++++++++++++++++++++++++++- dlls/wined3d/directx.c | 118 +++++++++------------------------------- dlls/wined3d/wined3d_private.h | 5 +- 3 files changed, 113 insertions(+), 96 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=135e6cea7b607e5806304…

1 0

Henri Verbeet : wined3d: Remove the effetively unused "state" field from the device.
by Alexandre Julliard 18 Nov '09

18 Nov '09

Module: wine Branch: master Commit: 55f3c576d9f9c48075eb46d9c26878495b5fb5e1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=55f3c576d9f9c48075eb46d9c… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed Nov 18 10:45:54 2009 +0100 wined3d: Remove the effetively unused "state" field from the device. --- dlls/d3d8/device.c | 12 ++------- dlls/d3d9/device.c | 17 ++++++-------- dlls/ddraw/ddraw.c | 47 +--------------------------------------- dlls/wined3d/device.c | 32 --------------------------- dlls/wined3d/wined3d_private.h | 3 -- include/wine/wined3d.idl | 2 - 6 files changed, 11 insertions(+), 102 deletions(-) diff --git a/dlls/d3d8/device.c b/dlls/d3d8/device.c index eb26d73..450a5ff 100644 --- a/dlls/d3d8/device.c +++ b/dlls/d3d8/device.c @@ -334,17 +334,11 @@ static ULONG WINAPI IDirect3DDevice8Impl_Release(LPDIRECT3DDEVICE8 iface) { } /* IDirect3DDevice Interface follow: */ -static HRESULT WINAPI IDirect3DDevice8Impl_TestCooperativeLevel(LPDIRECT3DDEVICE8 iface) { - IDirect3DDevice8Impl *This = (IDirect3DDevice8Impl *)iface; - HRESULT hr; - +static HRESULT WINAPI IDirect3DDevice8Impl_TestCooperativeLevel(IDirect3DDevice8 *iface) +{ TRACE("iface %p.\n", iface); - wined3d_mutex_lock(); - hr = IWineD3DDevice_TestCooperativeLevel(This->WineD3DDevice); - wined3d_mutex_unlock(); - - return hr; + return D3D_OK; } static UINT WINAPI IDirect3DDevice8Impl_GetAvailableTextureMem(LPDIRECT3DDEVICE8 iface) { diff --git a/dlls/d3d9/device.c b/dlls/d3d9/device.c index 1151d99..dfb6b26 100644 --- a/dlls/d3d9/device.c +++ b/dlls/d3d9/device.c @@ -280,22 +280,19 @@ static ULONG WINAPI DECLSPEC_HOTPATCH IDirect3DDevice9Impl_Release(LPDIRECT3DDEV } /* IDirect3DDevice Interface follow: */ -static HRESULT WINAPI IDirect3DDevice9Impl_TestCooperativeLevel(LPDIRECT3DDEVICE9EX iface) { +static HRESULT WINAPI IDirect3DDevice9Impl_TestCooperativeLevel(IDirect3DDevice9Ex *iface) +{ IDirect3DDevice9Impl *This = (IDirect3DDevice9Impl *)iface; - HRESULT hr; TRACE("iface %p.\n", iface); - wined3d_mutex_lock(); - hr = IWineD3DDevice_TestCooperativeLevel(This->WineD3DDevice); - wined3d_mutex_unlock(); - - if(hr == WINED3D_OK && This->notreset) { - TRACE("D3D9 Device is marked not reset\n"); - hr = D3DERR_DEVICENOTRESET; + if (This->notreset) + { + TRACE("D3D9 device is marked not reset.\n"); + return D3DERR_DEVICENOTRESET; } - return hr; + return D3D_OK; } static UINT WINAPI IDirect3DDevice9Impl_GetAvailableTextureMem(LPDIRECT3DDEVICE9EX iface) { diff --git a/dlls/ddraw/ddraw.c b/dlls/ddraw/ddraw.c index 351ebda..aeaffbd 100644 --- a/dlls/ddraw/ddraw.c +++ b/dlls/ddraw/ddraw.c @@ -1187,53 +1187,8 @@ static HRESULT WINAPI IDirectDrawImpl_GetScanLine(IDirectDraw7 *iface, DWORD *Sc static HRESULT WINAPI IDirectDrawImpl_TestCooperativeLevel(IDirectDraw7 *iface) { - IDirectDrawImpl *This = (IDirectDrawImpl *)iface; - HRESULT hr; - TRACE("(%p)\n", This); - - EnterCriticalSection(&ddraw_cs); - /* Description from MSDN: - * For fullscreen apps return DDERR_NOEXCLUSIVEMODE if the user switched - * away from the app with e.g. alt-tab. Windowed apps receive - * DDERR_EXCLUSIVEMODEALREADYSET if another application created a - * DirectDraw object in exclusive mode. DDERR_WRONGMODE is returned, - * when the video mode has changed - */ - - hr = IWineD3DDevice_TestCooperativeLevel(This->wineD3DDevice); + TRACE("iface %p.\n", iface); - /* Fix the result value. These values are mapped from their - * d3d9 counterpart. - */ - switch(hr) - { - case WINED3DERR_DEVICELOST: - if(This->cooperative_level & DDSCL_EXCLUSIVE) - { - LeaveCriticalSection(&ddraw_cs); - return DDERR_NOEXCLUSIVEMODE; - } - else - { - LeaveCriticalSection(&ddraw_cs); - return DDERR_EXCLUSIVEMODEALREADYSET; - } - - case WINED3DERR_DEVICENOTRESET: - LeaveCriticalSection(&ddraw_cs); - return DD_OK; - - case WINED3D_OK: - LeaveCriticalSection(&ddraw_cs); - return DD_OK; - - case WINED3DERR_DRIVERINTERNALERROR: - default: - ERR("(%p) Unexpected return value %08x from wineD3D, " - " returning DD_OK\n", This, hr); - } - - LeaveCriticalSection(&ddraw_cs); return DD_OK; } diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c index c48424e..136f396 100644 --- a/dlls/wined3d/device.c +++ b/dlls/wined3d/device.c @@ -6494,31 +6494,6 @@ static BOOL WINAPI IWineD3DDeviceImpl_ShowCursor(IWineD3DDevice* iface, BOO return oldVisible; } -static HRESULT WINAPI IWineD3DDeviceImpl_TestCooperativeLevel(IWineD3DDevice* iface) { - IWineD3DDeviceImpl *This = (IWineD3DDeviceImpl *) iface; - IWineD3DResourceImpl *resource; - TRACE("(%p) : state (%u)\n", This, This->state); - - /* TODO: Implement wrapping of the WndProc so that mimimize and maximize can be monitored and the states adjusted. */ - switch (This->state) { - case WINED3D_OK: - return WINED3D_OK; - case WINED3DERR_DEVICELOST: - { - LIST_FOR_EACH_ENTRY(resource, &This->resources, IWineD3DResourceImpl, resource.resource_list_entry) { - if (resource->resource.pool == WINED3DPOOL_DEFAULT) - return WINED3DERR_DEVICENOTRESET; - } - return WINED3DERR_DEVICELOST; - } - case WINED3DERR_DRIVERINTERNALERROR: - return WINED3DERR_DRIVERINTERNALERROR; - } - - /* Unknown state */ - return WINED3DERR_DRIVERINTERNALERROR; -} - static HRESULT WINAPI evict_managed_resource(IWineD3DResource *resource, void *data) { TRACE("checking resource %p for eviction\n", resource); if(((IWineD3DResourceImpl *) resource)->resource.pool == WINED3DPOOL_MANAGED) { @@ -7154,7 +7129,6 @@ static const IWineD3DDeviceVtbl IWineD3DDevice_Vtbl = IWineD3DDeviceImpl_SetCursorProperties, IWineD3DDeviceImpl_SetCursorPosition, IWineD3DDeviceImpl_ShowCursor, - IWineD3DDeviceImpl_TestCooperativeLevel, /*** Getters and setters **/ IWineD3DDeviceImpl_SetClipPlane, IWineD3DDeviceImpl_GetClipPlane, @@ -7278,9 +7252,6 @@ HRESULT device_init(IWineD3DDeviceImpl *device, IWineD3DImpl *wined3d, device->surface_alignment = wined3d->dxVersion == 7 ? DDRAW_PITCH_ALIGNMENT : D3D8_PITCH_ALIGNMENT; device->posFixup[0] = 1.0f; /* This is needed to get the x coord unmodified through a MAD. */ - /* Set the state up as invalid until the device is fully created. */ - device->state = WINED3DERR_DRIVERINTERNALERROR; - /* Get the initial screen setup for ddraw. */ hr = IWineD3D_GetAdapterDisplayMode((IWineD3D *)wined3d, adapter_idx, &mode); if (FAILED(hr)) @@ -7330,9 +7301,6 @@ HRESULT device_init(IWineD3DDeviceImpl *device, IWineD3DImpl *wined3d, device->blitter = select_blit_implementation(adapter, device_type); - /* Set the state of the device to valid. */ - device->state = WINED3D_OK; - return WINED3D_OK; } diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h index 9299a6e..12685d2 100644 --- a/dlls/wined3d/wined3d_private.h +++ b/dlls/wined3d/wined3d_private.h @@ -1555,9 +1555,6 @@ struct IWineD3DDeviceImpl /* Textures for when no other textures are mapped */ UINT dummyTextureName[MAX_TEXTURES]; - /* Device state management */ - HRESULT state; - /* DirectDraw stuff */ DWORD ddraw_width, ddraw_height; WINED3DFORMAT ddraw_format; diff --git a/include/wine/wined3d.idl b/include/wine/wined3d.idl index 2534fbb..176e602 100644 --- a/include/wine/wined3d.idl +++ b/include/wine/wined3d.idl @@ -3076,8 +3076,6 @@ interface IWineD3DDevice : IWineD3DBase BOOL ShowCursor( [in] BOOL show ); - HRESULT TestCooperativeLevel( - ); HRESULT SetClipPlane( [in] DWORD plane_idx, [in] const float *plane

1 0

Paul Vriens : rsaenh/tests: Fix some test failures on Wow64.
by Alexandre Julliard 18 Nov '09

18 Nov '09

Module: wine Branch: master Commit: 3323ae9dd63e8b5c85d8907d867a51a457efb787 URL: http://source.winehq.org/git/wine.git/?a=commit;h=3323ae9dd63e8b5c85d8907d8… Author: Paul Vriens <Paul.Vriens.Wine(a)gmail.com> Date: Wed Nov 18 09:10:44 2009 +0100 rsaenh/tests: Fix some test failures on Wow64. --- dlls/rsaenh/tests/rsaenh.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/rsaenh/tests/rsaenh.c b/dlls/rsaenh/tests/rsaenh.c index 4d57b25..bf6ed0f 100644 --- a/dlls/rsaenh/tests/rsaenh.c +++ b/dlls/rsaenh/tests/rsaenh.c @@ -74,7 +74,7 @@ static void uniquecontainer(char *unique) DWORD size = MAX_PATH; /* Get the MachineGUID */ - RegOpenKeyA(HKEY_LOCAL_MACHINE, szCryptography, &hkey); + RegOpenKeyExA(HKEY_LOCAL_MACHINE, szCryptography, 0, KEY_READ | KEY_WOW64_64KEY, &hkey); RegQueryValueExA(hkey, szMachineGuid, NULL, NULL, (LPBYTE)guid, &size); RegCloseKey(hkey);

1 0

Roderick Colenbrander : wgl: Add initial WGL_ARB_create_context support.
by Alexandre Julliard 18 Nov '09

18 Nov '09

Module: wine Branch: master Commit: 41f061ea1bf8c6394ed858bf28b9c74fd45c40f1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=41f061ea1bf8c6394ed858bf2… Author: Roderick Colenbrander <thunderbird2k(a)gmail.com> Date: Mon Nov 16 23:24:24 2009 +0100 wgl: Add initial WGL_ARB_create_context support. --- dlls/gdi32/driver.c | 1 + dlls/gdi32/gdi_private.h | 1 + dlls/gdi32/opengl.c | 23 ++++++- dlls/opengl32/tests/opengl.c | 2 +- dlls/winex11.drv/opengl.c | 133 ++++++++++++++++++++++++++++++++++++- dlls/winex11.drv/winex11.drv.spec | 1 + 6 files changed, 158 insertions(+), 3 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=41f061ea1bf8c6394ed85…

1 0

Piotr Caban : msxml3: Implemented xmlnode_get_nodeTypedValue 'string' data type handling.
by Alexandre Julliard 18 Nov '09

18 Nov '09

Module: wine Branch: master Commit: b56031c3a671b158a74da95684cbc84681266f2a URL: http://source.winehq.org/git/wine.git/?a=commit;h=b56031c3a671b158a74da9568… Author: Piotr Caban <piotr.caban(a)gmail.com> Date: Wed Nov 18 00:51:03 2009 +0100 msxml3: Implemented xmlnode_get_nodeTypedValue 'string' data type handling. --- dlls/msxml3/node.c | 60 +++++++++++++++++++++++++++++++------------ dlls/msxml3/tests/domdoc.c | 23 ++++++++++++++-- 2 files changed, 63 insertions(+), 20 deletions(-) diff --git a/dlls/msxml3/node.c b/dlls/msxml3/node.c index 93d8032..1f4dc32 100644 --- a/dlls/msxml3/node.c +++ b/dlls/msxml3/node.c @@ -944,36 +944,62 @@ static HRESULT WINAPI xmlnode_get_definition( return E_NOTIMPL; } +static HRESULT WINAPI xmlnode_get_dataType(IXMLDOMNode*, VARIANT*); + +inline HRESULT VARIANT_from_xmlChar(xmlChar *str, VARIANT *v, BSTR type) +{ + if(!type || !lstrcmpiW(type, szString)) + { + V_VT(v) = VT_BSTR; + V_BSTR(v) = bstr_from_xmlChar(str); + + if(!V_BSTR(v)) + return E_OUTOFMEMORY; + } + else + { + FIXME("Type handling not yet implemented\n"); + V_VT(v) = VT_BSTR; + V_BSTR(v) = bstr_from_xmlChar(str); + + if(!V_BSTR(v)) + return E_OUTOFMEMORY; + } + + return S_OK; +} + static HRESULT WINAPI xmlnode_get_nodeTypedValue( IXMLDOMNode *iface, VARIANT* typedValue) { xmlnode *This = impl_from_IXMLDOMNode( iface ); - HRESULT r = S_FALSE; + VARIANT type; + xmlChar *content; + HRESULT hres = S_FALSE; - FIXME("ignoring data type %p %p\n", This, typedValue); + TRACE("iface %p\n", iface); if(!typedValue) return E_INVALIDARG; V_VT(typedValue) = VT_NULL; - switch ( This->node->type ) - { - case XML_ELEMENT_NODE: - { - xmlChar *content = xmlNodeGetContent(This->node); - V_VT(typedValue) = VT_BSTR; - V_BSTR(typedValue) = bstr_from_xmlChar( content ); - xmlFree(content); - r = S_OK; - break; - } - default: - r = xmlnode_get_nodeValue(iface, typedValue); - } + if(This->node->type == XML_ELEMENT_NODE || + This->node->type == XML_TEXT_NODE || + This->node->type == XML_ENTITY_REF_NODE) + hres = xmlnode_get_dataType(iface, &type); - return r; + if(hres != S_OK && This->node->type != XML_ELEMENT_NODE) + return xmlnode_get_nodeValue(iface, typedValue); + + content = xmlNodeGetContent(This->node); + hres = VARIANT_from_xmlChar(content, typedValue, + hres==S_OK ? V_BSTR(&type) : NULL); + xmlFree(content); + VariantClear(&type); + + return hres; } static HRESULT WINAPI xmlnode_put_nodeTypedValue( diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c index 469a4f9..b946970 100644 --- a/dlls/msxml3/tests/domdoc.c +++ b/dlls/msxml3/tests/domdoc.c @@ -147,8 +147,11 @@ static const CHAR szTransformOutput[] = "</h1></body></html>"; static const CHAR szTypeValueXML[] = -"<?xml version=\"1.0\" encoding=\"utf-8\"?>" -"<string>Wine</string>"; +"<?xml version=\"1.0\" encoding=\"utf-8\"?>\n" +"<root xmlns:dt=\"urn:schemas-microsoft-com:datatypes\">\n" +" <string>Wine</string>\n" +" <string2 dt:dt=\"string\">String</string2>\n" +"</root>"; static const CHAR szBasicTransformSSXMLPart1[] = "<?xml version=\"1.0\"?>" @@ -3972,7 +3975,7 @@ static void test_NodeTypeValue(void) hr = IXMLDOMDocument2_get_nodeTypedValue(doc, &v); ok(hr == S_FALSE, "ret %08x\n", hr ); - hr = IXMLDOMDocument2_selectSingleNode(doc, _bstr_("string"), &pNode); + hr = IXMLDOMDocument2_selectSingleNode(doc, _bstr_("root/string"), &pNode); ok(hr == S_OK, "ret %08x\n", hr ); if(hr == S_OK) { @@ -3987,11 +3990,25 @@ static void test_NodeTypeValue(void) hr = IXMLDOMNode_get_nodeTypedValue(pNode, &v); ok(hr == S_OK, "ret %08x\n", hr ); + ok(V_VT(&v) == VT_BSTR, "incorrect type\n"); ok(!lstrcmpW( V_BSTR(&v), _bstr_("Wine") ), "incorrect value\n"); VariantClear( &v ); IXMLDOMNode_Release(pNode); } + + hr = IXMLDOMDocument2_selectSingleNode(doc, _bstr_("root/string2"), &pNode); + ok(hr == S_OK, "ret %08x\n", hr ); + if(hr == S_OK) + { + hr = IXMLDOMNode_get_nodeTypedValue(pNode, &v); + ok(hr == S_OK, "ret %08x\n", hr ); + ok(V_VT(&v) == VT_BSTR, "incorrect type\n"); + ok(!lstrcmpW( V_BSTR(&v), _bstr_("String") ), "incorrect value\n"); + VariantClear( &v ); + + IXMLDOMNode_Release(pNode); + } } IXMLDOMDocument2_Release(doc);

1 0

Eric Pouech : mscvrt: Fix some undname quirks ( space at the end of multi-level templates).
by Alexandre Julliard 18 Nov '09

18 Nov '09

Module: wine Branch: master Commit: d568c2ac5612d204184cfe3099964ef4e07b48c6 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d568c2ac5612d204184cfe309… Author: Eric Pouech <eric.pouech(a)orange.fr> Date: Tue Nov 17 21:43:13 2009 +0100 mscvrt: Fix some undname quirks (space at the end of multi-level templates). --- dlls/msvcrt/tests/cpp.c | 2 +- dlls/msvcrt/undname.c | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/dlls/msvcrt/tests/cpp.c b/dlls/msvcrt/tests/cpp.c index 3b98423..106ef73 100644 --- a/dlls/msvcrt/tests/cpp.c +++ b/dlls/msvcrt/tests/cpp.c @@ -1033,7 +1033,7 @@ static void test_demangle(void) /* 112 */ {"?f(a)T@@QAEHQAY2BE(a)BO@CI(a)D@Z", "public: int __thiscall T::f(char (* const)[20][30][40])"}, /* 113 */ {"?f(a)T@@QAEHQAY1BE(a)BO@$$CBD(a)Z", "public: int __thiscall T::f(char const (* const)[20][30])"}, /* 114 */ {"??0?$Foo(a)U?$vector_c(a)H$00$01$0?1$0A@$0A@$0HPPPPPPP@$0HPPPPPPP@$0HPPPPPPP@$0HPPPPPPP@$0HPPPPPPP@$0HPPPPPPP@$0HPPPPPPP@$0HPPPPPPP@$0HPPPPPPP@$0HPPPPPPP@$0HPPPPPPP@$0HPPPPPPP@$0HPPPPPPP@$0HPPPPPPP@$0HPPPPPPP@@mpl(a)boost@@@@QAE(a)XZ", - "public: __thiscall Foo<struct boost::mpl::vector_c<int,1,2,-2,0,0,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647>>::Foo<struct boost::mpl::vector_c<int,1,2,-2,0,0,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647>>(void)"}, + "public: __thiscall Foo<struct boost::mpl::vector_c<int,1,2,-2,0,0,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647> >::Foo<struct boost::mpl::vector_c<int,1,2,-2,0,0,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647> >(void)"}, }; int i, num_test = (sizeof(test)/sizeof(test[0])); diff --git a/dlls/msvcrt/undname.c b/dlls/msvcrt/undname.c index cb07905..670873d 100644 --- a/dlls/msvcrt/undname.c +++ b/dlls/msvcrt/undname.c @@ -367,6 +367,7 @@ static char* get_args(struct parsed_symbol* sym, struct array* pmt_ref, BOOL z_t struct datatype_t ct; struct array arg_collect; char* args_str = NULL; + char* last; unsigned int i; str_array_init(&arg_collect); @@ -402,7 +403,8 @@ static char* get_args(struct parsed_symbol* sym, struct array* pmt_ref, BOOL z_t args_str = str_printf(sym, "%s,%s", args_str, arg_collect.elts[i]); } - if (close_char == '>' && args_str && args_str[strlen(args_str) - 1] == '>') + last = args_str ? args_str : arg_collect.elts[0]; + if (close_char == '>' && last[strlen(last) - 1] == '>') args_str = str_printf(sym, "%c%s%s %c", open_char, arg_collect.elts[0], args_str, close_char); else

1 0

André Hentschel : gdi32/tests: Simplify testcase.
by Alexandre Julliard 18 Nov '09

18 Nov '09

Module: wine Branch: master Commit: 762280eab0eb5426040bf27932648ec055e1949c URL: http://source.winehq.org/git/wine.git/?a=commit;h=762280eab0eb5426040bf2793… Author: André Hentschel <nerv(a)dawncrow.de> Date: Tue Nov 17 17:43:54 2009 +0100 gdi32/tests: Simplify testcase. --- dlls/gdi32/tests/font.c | 61 +++++++++++++--------------------------------- 1 files changed, 17 insertions(+), 44 deletions(-) diff --git a/dlls/gdi32/tests/font.c b/dlls/gdi32/tests/font.c index 4ad418f..08ceb85 100644 --- a/dlls/gdi32/tests/font.c +++ b/dlls/gdi32/tests/font.c @@ -2980,61 +2980,34 @@ static void test_GetTextMetrics2(const char *fontname, int font_height) void test_CreateFontIndirect(void) { LOGFONTA lf, getobj_lf; - int ret; + int ret, i; HFONT hfont; + char TestName[][16] = {"Arial", "Arial Bold", "Arial Italic"}; memset(&lf, 0, sizeof(lf)); - lf.lfCharSet = ANSI_CHARSET; lf.lfClipPrecision = CLIP_DEFAULT_PRECIS; lf.lfHeight = 16; lf.lfWidth = 16; lf.lfQuality = DEFAULT_QUALITY; - lf.lfItalic = FALSE; lf.lfWeight = FW_DONTCARE; - lstrcpyA(lf.lfFaceName, "Arial"); - hfont = CreateFontIndirectA(&lf); - ok(hfont != 0, "CreateFontIndirectA failed\n"); - ret = GetObject(hfont, sizeof(getobj_lf), &getobj_lf); - ok(lf.lfWeight == getobj_lf.lfWeight || - broken((SHORT)lf.lfWeight == getobj_lf.lfWeight), /* win9x */ - "lfWeight: expect %08x got %08x\n", lf.lfWeight, getobj_lf.lfWeight); - ok(lf.lfItalic == getobj_lf.lfItalic, "lfItalic: expect %02x got %02x\n", lf.lfItalic, getobj_lf.lfItalic); - ok(!lstrcmpA(lf.lfFaceName, getobj_lf.lfFaceName) || - broken(!memcmp(lf.lfFaceName, getobj_lf.lfFaceName, LF_FACESIZE-1)), /* win9x doesn't ensure '\0' termination */ - "font names don't match: %s != %s\n", lf.lfFaceName, getobj_lf.lfFaceName); - DeleteObject(hfont); - lf.lfItalic = FALSE; - lf.lfWeight = FW_DONTCARE; - lstrcpyA(lf.lfFaceName, "Arial Bold"); - hfont = CreateFontIndirectA(&lf); - ok(hfont != 0, "CreateFontIndirectA failed\n"); - ret = GetObject(hfont, sizeof(getobj_lf), &getobj_lf); - ok(lf.lfItalic == getobj_lf.lfItalic, "lfItalic: expect %02x got %02x\n", lf.lfItalic, getobj_lf.lfItalic); - ok(lf.lfWeight == getobj_lf.lfWeight || - broken((SHORT)lf.lfWeight == getobj_lf.lfWeight), /* win9x */ - "lfWeight: expect %08x got %08x\n", lf.lfWeight, getobj_lf.lfWeight); - ok(!lstrcmpA(lf.lfFaceName, getobj_lf.lfFaceName) || - broken(!memcmp(lf.lfFaceName, getobj_lf.lfFaceName, LF_FACESIZE-1)), /* win9x doesn't ensure '\0' termination */ - "font names don't match: %s != %s\n", lf.lfFaceName, getobj_lf.lfFaceName); - DeleteObject(hfont); - - lf.lfItalic = FALSE; - lf.lfWeight = FW_DONTCARE; - lstrcpyA(lf.lfFaceName, "Arial Italic"); - hfont = CreateFontIndirectA(&lf); - ok(hfont != 0, "CreateFontIndirectA failed\n"); - ret = GetObject(hfont, sizeof(getobj_lf), &getobj_lf); - ok(lf.lfWeight == getobj_lf.lfWeight || - broken((SHORT)lf.lfWeight == getobj_lf.lfWeight), /* win9x */ - "lfWeight: expect %08x got %08x\n", lf.lfWeight, getobj_lf.lfWeight); - ok(lf.lfItalic == getobj_lf.lfItalic, "lfItalic: expect %02x got %02x\n", lf.lfItalic, getobj_lf.lfItalic); - ok(!lstrcmpA(lf.lfFaceName, getobj_lf.lfFaceName) || - broken(!memcmp(lf.lfFaceName, getobj_lf.lfFaceName, LF_FACESIZE-1)), /* win9x doesn't ensure '\0' termination */ - "font names don't match: %s != %s\n", lf.lfFaceName, getobj_lf.lfFaceName); - DeleteObject(hfont); + for (i = 0; i < sizeof(TestName)/sizeof(TestName[0]); i++) + { + lstrcpyA(lf.lfFaceName, TestName[i]); + hfont = CreateFontIndirectA(&lf); + ok(hfont != 0, "CreateFontIndirectA failed\n"); + ret = GetObject(hfont, sizeof(getobj_lf), &getobj_lf); + ok(lf.lfItalic == getobj_lf.lfItalic, "lfItalic: expect %02x got %02x\n", lf.lfItalic, getobj_lf.lfItalic); + ok(lf.lfWeight == getobj_lf.lfWeight || + broken((SHORT)lf.lfWeight == getobj_lf.lfWeight), /* win9x */ + "lfWeight: expect %08x got %08x\n", lf.lfWeight, getobj_lf.lfWeight); + ok(!lstrcmpA(lf.lfFaceName, getobj_lf.lfFaceName) || + broken(!memcmp(lf.lfFaceName, getobj_lf.lfFaceName, LF_FACESIZE-1)), /* win9x doesn't ensure '\0' termination */ + "font names don't match: %s != %s\n", lf.lfFaceName, getobj_lf.lfFaceName); + DeleteObject(hfont); + } } START_TEST(font)

1 0