November 2009 - Wine-commits

Rob Shearman : Revert "widl: A structure that contains an embedded interface ptr in an array is a BOGUS_STRUCT .".
by Alexandre Julliard 09 Nov '09

09 Nov '09

Module: wine Branch: master Commit: d59ff2007d67e150eb85511c2c522b9bb39d51e0 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d59ff2007d67e150eb85511c2… Author: Rob Shearman <robertshearman(a)gmail.com> Date: Sat Nov 7 13:29:19 2009 +0100 Revert "widl: A structure that contains an embedded interface ptr in an array is a BOGUS_STRUCT.". This reverts commit e4e21193c049085dffe9475c9c9bdf9ae6807401. The IDBProperties test shows that this special case is not needed to for these types to be marshalled correctly. --- tools/widl/typegen.c | 62 +------------------------------------------------- 1 files changed, 1 insertions(+), 61 deletions(-) diff --git a/tools/widl/typegen.c b/tools/widl/typegen.c index b41dcbe..1f8e4fe 100644 --- a/tools/widl/typegen.c +++ b/tools/widl/typegen.c @@ -229,64 +229,6 @@ enum typegen_type typegen_detect_type(const type_t *type, const attr_list_t *att return TGT_INVALID; } -static type_t *get_user_type(const type_t *t, const char **pname); - -static int type_contains_iface(const type_t *type) -{ - enum typegen_type typegen_type; - var_list_t *fields; - const var_t *field; - - typegen_type = typegen_detect_type(type, type->attrs, TDT_IGNORE_STRINGS); - - switch(typegen_type) - { - case TGT_USER_TYPE: - return type_contains_iface(get_user_type(type, NULL)); - - case TGT_BASIC: - case TGT_ENUM: - return FALSE; - - case TGT_POINTER: - return type_contains_iface(type_pointer_get_ref(type)); - - case TGT_ARRAY: - return type_contains_iface(type_array_get_element(type)); - - case TGT_IFACE_POINTER: - return TRUE; - - case TGT_STRUCT: - fields = type_struct_get_fields(type); - if (fields) LIST_FOR_EACH_ENTRY( field, fields, const var_t, entry ) - { - if(type_contains_iface(field->type)) - return TRUE; - } - return FALSE; - - case TGT_UNION: - fields = type_union_get_cases(type); - if (fields) LIST_FOR_EACH_ENTRY( field, fields, const var_t, entry ) - { - if(field->type && type_contains_iface(field->type)) - return TRUE; - } - return FALSE; - - case TGT_STRING: - /* shouldn't get here because of TDT_IGNORE_STRINGS above. fall through */ - case TGT_INVALID: - case TGT_CTXT_HANDLE: - case TGT_CTXT_HANDLE_POINTER: - /* checking after parsing should mean that we don't get here. if we do, - * it's a checker bug */ - assert(0); - } - return FALSE; -} - unsigned char get_struct_fc(const type_t *type) { int has_pointer = 0; @@ -345,10 +287,8 @@ unsigned char get_struct_fc(const type_t *type) if (get_enum_fc(t) == RPC_FC_ENUM16) return RPC_FC_BOGUS_STRUCT; break; - case TGT_ARRAY: - if(type_contains_iface(type_array_get_element(t))) - return RPC_FC_BOGUS_STRUCT; case TGT_POINTER: + case TGT_ARRAY: if (get_pointer_fc(t, field->attrs, FALSE) == RPC_FC_RP || pointer_size != 4) return RPC_FC_BOGUS_STRUCT; has_pointer = 1;

1 0

Rob Shearman : widl: Enhance the IDL grammar to support unnamed arguments to functions.
by Alexandre Julliard 09 Nov '09

09 Nov '09

Module: wine Branch: master Commit: c3676245348b0222b1c2b61dc24b26ad35a23b07 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c3676245348b0222b1c2b61dc… Author: Rob Shearman <robertshearman(a)gmail.com> Date: Sat Nov 7 15:54:24 2009 +0100 widl: Enhance the IDL grammar to support unnamed arguments to functions. --- tools/widl/parser.y | 64 ++++++++++++++++++++++++++++++++++++------------ tools/widl/typetree.c | 56 ++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 103 insertions(+), 17 deletions(-) diff --git a/tools/widl/parser.y b/tools/widl/parser.y index b12741c..64f92b0 100644 --- a/tools/widl/parser.y +++ b/tools/widl/parser.y @@ -121,7 +121,7 @@ static type_t *find_type_or_error2(char *name, int t); static var_t *reg_const(var_t *var); static char *gen_name(void); -static void check_arg(var_t *arg); +static void check_arg_attrs(const var_t *arg); static void check_statements(const statement_list_t *stmts, int is_inside_library); static void check_all_user_types(const statement_list_t *stmts); static attr_list_t *check_iface_attrs(const char *name, attr_list_t *attrs); @@ -292,9 +292,10 @@ static statement_list_t *append_statement(statement_list_t *list, statement_t *s %type <ifref> coclass_int %type <ifref_list> coclass_ints %type <var> arg ne_union_field union_field s_field case enum declaration -%type <var_list> m_args no_args args fields ne_union_fields cases enums enum_list dispint_props field +%type <var_list> m_args args fields ne_union_fields cases enums enum_list dispint_props field %type <var> m_ident ident %type <declarator> declarator direct_declarator init_declarator +%type <declarator> m_any_declarator any_declarator any_declarator_no_ident any_direct_declarator %type <declarator_list> declarator_list %type <func> funcdef %type <type> coclass coclasshdr coclassdef @@ -425,23 +426,19 @@ m_args: { $$ = NULL; } | args ; -no_args: tVOID { $$ = NULL; } - ; - -args: arg { check_arg($1); $$ = append_var( NULL, $1 ); } - | args ',' arg { check_arg($3); $$ = append_var( $1, $3); } - | no_args +args: arg { check_arg_attrs($1); $$ = append_var( NULL, $1 ); } + | args ',' arg { check_arg_attrs($3); $$ = append_var( $1, $3); } ; /* split into two rules to get bison to resolve a tVOID conflict */ -arg: attributes decl_spec declarator { $$ = $3->var; +arg: attributes decl_spec m_any_declarator { $$ = $3->var; $$->attrs = $1; if ($2->stgclass != STG_NONE && $2->stgclass != STG_REGISTER) error_loc("invalid storage class for function parameter\n"); set_type($$, $2, $3, TRUE); free($3); } - | decl_spec declarator { $$ = $2->var; + | decl_spec m_any_declarator { $$ = $2->var; if ($1->stgclass != STG_NONE && $1->stgclass != STG_REGISTER) error_loc("invalid storage class for function parameter\n"); set_type($$, $1, $2, TRUE); @@ -945,6 +942,45 @@ direct_declarator: } ; +/* abstract or non-abstract declarator */ +any_declarator: + '*' m_type_qual_list m_any_declarator %prec PPTR + { $$ = $3; $$->type = append_ptrchain_type($$->type, type_new_pointer(pointer_default, NULL, $2)); } + | callconv m_any_declarator { $$ = $2; $$->type->attrs = append_attr($$->type->attrs, make_attrp(ATTR_CALLCONV, $1)); } + | any_direct_declarator + ; + +/* abstract or non-abstract declarator without accepting idents */ +any_declarator_no_ident: + '*' m_type_qual_list m_any_declarator %prec PPTR + { $$ = $3; $$->type = append_ptrchain_type($$->type, type_new_pointer(pointer_default, NULL, $2)); } + | callconv m_any_declarator { $$ = $2; $$->type->attrs = append_attr($$->type->attrs, make_attrp(ATTR_CALLCONV, $1)); } + ; + +/* abstract or non-abstract declarator or empty */ +m_any_declarator: { $$ = make_declarator(NULL); } + | any_declarator + ; + +/* abstract or non-abstract direct declarator. note: idents aren't accepted + * inside brackets to avoid ambiguity with the rule for function arguments */ +any_direct_declarator: + ident { $$ = make_declarator($1); } + | '(' any_declarator_no_ident ')' { $$ = $2; } + | any_direct_declarator array { $$ = $1; $$->array = append_array($$->array, $2); } + | array { $$ = make_declarator(NULL); $$->array = append_array($$->array, $1); } + | '(' m_args ')' + { $$ = make_declarator(NULL); + $$->func_type = append_ptrchain_type($$->type, type_new_function($2)); + $$->type = NULL; + } + | any_direct_declarator '(' m_args ')' + { $$ = $1; + $$->func_type = append_ptrchain_type($$->type, type_new_function($3)); + $$->type = NULL; + } + ; + declarator_list: declarator { $$ = append_declarator( NULL, $1 ); } | declarator_list ',' declarator { $$ = append_declarator( $1, $3 ); } @@ -1532,7 +1568,7 @@ static declarator_list_t *append_declarator(declarator_list_t *list, declarator_ static declarator_t *make_declarator(var_t *var) { declarator_t *d = xmalloc(sizeof(*d)); - d->var = var; + d->var = var ? var : make_var(NULL); d->type = NULL; d->func_type = NULL; d->array = NULL; @@ -1979,14 +2015,10 @@ static attr_list_t *check_function_attrs(const char *name, attr_list_t *attrs) return attrs; } -static void check_arg(var_t *arg) +static void check_arg_attrs(const var_t *arg) { - const type_t *t = arg->type; const attr_t *attr; - if (type_get_type(t) == TYPE_VOID) - error_loc("argument '%s' has void type\n", arg->name); - if (arg->attrs) { LIST_FOR_EACH_ENTRY(attr, arg->attrs, const attr_t, entry) diff --git a/tools/widl/typetree.c b/tools/widl/typetree.c index 4359d92..07393f4 100644 --- a/tools/widl/typetree.c +++ b/tools/widl/typetree.c @@ -63,9 +63,63 @@ type_t *make_type(enum type_type type) return t; } +static const var_t *find_arg(const var_list_t *args, const char *name) +{ + const var_t *arg; + + if (args) LIST_FOR_EACH_ENTRY(arg, args, const var_t, entry) + { + if (arg->name && !strcmp(name, arg->name)) + return arg; + } + + return NULL; +} + type_t *type_new_function(var_list_t *args) { - type_t *t = make_type(TYPE_FUNCTION); + var_t *arg; + type_t *t; + unsigned int i = 0; + + if (args) + { + arg = LIST_ENTRY(list_head(args), var_t, entry); + if (list_count(args) == 1 && !arg->name && arg->type && type_get_type(arg->type) == TYPE_VOID) + { + list_remove(&arg->entry); + free(arg); + free(args); + args = NULL; + } + } + if (args) LIST_FOR_EACH_ENTRY(arg, args, var_t, entry) + { + if (arg->type && type_get_type(arg->type) == TYPE_VOID) + error_loc("argument '%s' has void type\n", arg->name); + if (!arg->name) + { + if (i > 26 * 26) + error_loc("too many unnamed arguments\n"); + else + { + int unique; + do + { + char name[3]; + name[0] = i > 26 ? 'a' + i / 26 : 'a' + i; + name[1] = i > 26 ? 'a' + i % 26 : 0; + name[2] = 0; + unique = !find_arg(args, name); + if (unique) + arg->name = xstrdup(name); + i++; + } while (!unique); + } + } + } + + t = make_type(TYPE_FUNCTION); t->details.function = xmalloc(sizeof(*t->details.function)); t->details.function->args = args; t->details.function->idx = -1;

1 0

Marcus Meissner : crypt32: Pass the correct pointer into CertificateFindStore.
by Alexandre Julliard 09 Nov '09

09 Nov '09

Module: wine Branch: master Commit: c25753ece29f8b65fa49a80f983735ddf0a9c3b6 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c25753ece29f8b65fa49a80f9… Author: Marcus Meissner <meissner(a)suse.de> Date: Mon Nov 9 13:44:22 2009 +0100 crypt32: Pass the correct pointer into CertificateFindStore. --- dlls/crypt32/tests/cert.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/crypt32/tests/cert.c b/dlls/crypt32/tests/cert.c index 4dc8846..e1c8262 100644 --- a/dlls/crypt32/tests/cert.c +++ b/dlls/crypt32/tests/cert.c @@ -1089,7 +1089,7 @@ static void testFindCert(void) * the issuer, not the subject */ context = CertFindCertificateInStore(store, X509_ASN_ENCODING, 0, - CERT_FIND_SUBJECT_CERT, &certInfo.Subject, NULL); + CERT_FIND_SUBJECT_CERT, &certInfo, NULL); ok(context == NULL, "Expected no certificate\n"); certInfo.Subject.pbData = NULL; certInfo.Subject.cbData = 0; @@ -1102,7 +1102,7 @@ static void testFindCert(void) if (context) { context = CertFindCertificateInStore(store, X509_ASN_ENCODING, 0, - CERT_FIND_SUBJECT_CERT, &certInfo.Subject, context); + CERT_FIND_SUBJECT_CERT, &certInfo, context); ok(context == NULL, "Expected one cert only\n"); } /* A non-matching serial number will not match. */

1 0

Rob Shearman : msdaps: Implement IDBProperties_GetProperties_Proxy and IDBProperties_GetProperties_Stub .
by Alexandre Julliard 09 Nov '09

09 Nov '09

Module: wine Branch: master Commit: da4f7a5dc128dfa55c6f4e038c7e6c2bd3d4196f URL: http://source.winehq.org/git/wine.git/?a=commit;h=da4f7a5dc128dfa55c6f4e038… Author: Rob Shearman <robertshearman(a)gmail.com> Date: Sat Nov 7 13:29:04 2009 +0100 msdaps: Implement IDBProperties_GetProperties_Proxy and IDBProperties_GetProperties_Stub. --- dlls/msdaps/usrmarshal.c | 25 +++++++++++++++++++++---- 1 files changed, 21 insertions(+), 4 deletions(-) diff --git a/dlls/msdaps/usrmarshal.c b/dlls/msdaps/usrmarshal.c index 5752404..2337b5e 100644 --- a/dlls/msdaps/usrmarshal.c +++ b/dlls/msdaps/usrmarshal.c @@ -100,17 +100,34 @@ HRESULT __RPC_STUB IDBCreateSession_CreateSession_Stub(IDBCreateSession* This, I HRESULT CALLBACK IDBProperties_GetProperties_Proxy(IDBProperties* This, ULONG cPropertyIDSets, const DBPROPIDSET rgPropertyIDSets[], ULONG *pcPropertySets, DBPROPSET **prgPropertySets) { - FIXME("(%p, %d, %p, %p, %p): stub\n", This, cPropertyIDSets, rgPropertyIDSets, pcPropertySets, + HRESULT hr; + IErrorInfo *error; + + TRACE("(%p, %d, %p, %p, %p)\n", This, cPropertyIDSets, rgPropertyIDSets, pcPropertySets, prgPropertySets); - return E_NOTIMPL; + hr = IDBProperties_RemoteGetProperties_Proxy(This, cPropertyIDSets, rgPropertyIDSets, + pcPropertySets, prgPropertySets, &error); + if(error) + { + SetErrorInfo(0, error); + IErrorInfo_Release(error); + } + return hr; } HRESULT __RPC_STUB IDBProperties_GetProperties_Stub(IDBProperties* This, ULONG cPropertyIDSets, const DBPROPIDSET *rgPropertyIDSets, ULONG *pcPropertySets, DBPROPSET **prgPropertySets, IErrorInfo **ppErrorInfoRem) { - FIXME("(%p, %d, %p, %p, %p, %p): stub\n", This, cPropertyIDSets, rgPropertyIDSets, pcPropertySets, + HRESULT hr; + + TRACE("(%p, %d, %p, %p, %p, %p)\n", This, cPropertyIDSets, rgPropertyIDSets, pcPropertySets, prgPropertySets, ppErrorInfoRem); - return E_NOTIMPL; + *ppErrorInfoRem = NULL; + hr = IDBProperties_GetProperties(This, cPropertyIDSets, rgPropertyIDSets, + pcPropertySets, prgPropertySets); + if(FAILED(hr)) GetErrorInfo(0, ppErrorInfoRem); + + return hr; } HRESULT CALLBACK IDBProperties_GetPropertyInfo_Proxy(IDBProperties* This, ULONG cPropertyIDSets, const DBPROPIDSET rgPropertyIDSets[],

1 0

Stefan Dösinger : d3d9: Make the visual test read the backbuffer.
by Alexandre Julliard 09 Nov '09

09 Nov '09

Module: wine Branch: master Commit: 69612bb24191a9bfe858284624daecb2eb7e2e0a URL: http://source.winehq.org/git/wine.git/?a=commit;h=69612bb24191a9bfe85828462… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Sat Nov 7 15:53:42 2009 +0100 d3d9: Make the visual test read the backbuffer. --- dlls/d3d9/tests/visual.c | 417 +++++++++++++++++++++++++--------------------- 1 files changed, 226 insertions(+), 191 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=69612bb24191a9bfe8582…

1 0

Stefan Dösinger : d3d9: Run the visual tests in a window.
by Alexandre Julliard 09 Nov '09

09 Nov '09

Module: wine Branch: master Commit: b49a9cbfd218faade32f3bd1675d5e001975ba64 URL: http://source.winehq.org/git/wine.git/?a=commit;h=b49a9cbfd218faade32f3bd16… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Sat Nov 7 15:54:11 2009 +0100 d3d9: Run the visual tests in a window. --- dlls/d3d9/tests/visual.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/dlls/d3d9/tests/visual.c b/dlls/d3d9/tests/visual.c index bf0503c..55de959 100644 --- a/dlls/d3d9/tests/visual.c +++ b/dlls/d3d9/tests/visual.c @@ -43,7 +43,8 @@ static HWND create_window(void) RegisterClass(&wc); ret = CreateWindow("d3d9_test_wc", "d3d9_test", - WS_MAXIMIZE | WS_VISIBLE | WS_CAPTION , 0, 0, 640, 480, 0, 0, 0, 0); + WS_SYSMENU | WS_POPUP , 0, 0, 640, 480, 0, 0, 0, 0); + ShowWindow(ret, SW_SHOW); return ret; } @@ -177,7 +178,7 @@ static IDirect3DDevice9 *init_d3d9(void) } ZeroMemory(&present_parameters, sizeof(present_parameters)); - present_parameters.Windowed = FALSE; + present_parameters.Windowed = TRUE; present_parameters.hDeviceWindow = create_window(); present_parameters.SwapEffect = D3DSWAPEFFECT_DISCARD; present_parameters.BackBufferWidth = 640;

1 0

Marcus Meissner : d3d8: Removed superflous NULL checks (Coverity).
by Alexandre Julliard 09 Nov '09

09 Nov '09

Module: wine Branch: master Commit: 6bb2d5d242d6385697a6be75a200e5d7d9f1c6c5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=6bb2d5d242d6385697a6be75a… Author: Marcus Meissner <meissner(a)suse.de> Date: Sun Nov 8 09:16:22 2009 +0100 d3d8: Removed superflous NULL checks (Coverity). --- dlls/d3d8/directx.c | 12 ++++-------- 1 files changed, 4 insertions(+), 8 deletions(-) diff --git a/dlls/d3d8/directx.c b/dlls/d3d8/directx.c index efcdbd6..e5ecc75 100644 --- a/dlls/d3d8/directx.c +++ b/dlls/d3d8/directx.c @@ -450,16 +450,12 @@ static HRESULT WINAPI IDirect3D8Impl_CreateDevice(LPDIRECT3D8 iface, UINT Adapte err: *ppReturnedDeviceInterface = NULL; - if(!object) return hr; HeapFree(GetProcessHeap(), 0, object->decls); - if(object->WineD3DDevice) { - wined3d_mutex_lock(); - IWineD3DDevice_Uninit3D(object->WineD3DDevice, D3D8CB_DestroySwapChain); - IWineD3DDevice_Release(object->WineD3DDevice); - wined3d_mutex_unlock(); - } + wined3d_mutex_lock(); + IWineD3DDevice_Uninit3D(object->WineD3DDevice, D3D8CB_DestroySwapChain); + IWineD3DDevice_Release(object->WineD3DDevice); + wined3d_mutex_unlock(); HeapFree(GetProcessHeap(), 0, object); - return hr; }

1 0

Louis Lenders : d3d9: Quiet a few noisy fixme's.
by Alexandre Julliard 09 Nov '09

09 Nov '09

Module: wine Branch: master Commit: cdb2ccd2d8d00153de065c5f0ce5504b5bc4a8dd URL: http://source.winehq.org/git/wine.git/?a=commit;h=cdb2ccd2d8d00153de065c5f0… Author: Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> Date: Sun Nov 8 14:45:57 2009 +0100 d3d9: Quiet a few noisy fixme's. --- dlls/d3d9/d3d9_main.c | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/dlls/d3d9/d3d9_main.c b/dlls/d3d9/d3d9_main.c index e8b4a97..c405a57 100644 --- a/dlls/d3d9/d3d9_main.c +++ b/dlls/d3d9/d3d9_main.c @@ -78,7 +78,9 @@ HRESULT WINAPI DECLSPEC_HOTPATCH Direct3DCreate9Ex(UINT SDKVersion, IDirect3D9Ex */ void* WINAPI Direct3DShaderValidatorCreate9(void) { - FIXME("stub\n"); + static int once; + + if (!once++) FIXME("stub\n"); return NULL; } @@ -99,7 +101,7 @@ BOOL WINAPI DllMain(HINSTANCE hInstDLL, DWORD fdwReason, LPVOID lpv) * D3DPERF_BeginEvent (D3D9.@) */ int WINAPI D3DPERF_BeginEvent(D3DCOLOR color, LPCWSTR name) { - FIXME("(color %#x, name %s) : stub\n", color, debugstr_w(name)); + TRACE("(color %#x, name %s) : stub\n", color, debugstr_w(name)); return D3DPERF_event_level++; } @@ -108,7 +110,7 @@ int WINAPI D3DPERF_BeginEvent(D3DCOLOR color, LPCWSTR name) { * D3DPERF_EndEvent (D3D9.@) */ int WINAPI D3DPERF_EndEvent(void) { - FIXME("(void) : stub\n"); + TRACE("(void) : stub\n"); return --D3DPERF_event_level; }

1 0

Eric Pouech : richedit: Only increment objects' reference by one when inserting an OLE object.
by Alexandre Julliard 09 Nov '09

09 Nov '09

Module: wine Branch: master Commit: ab9c51dd6ad9ae455ce43987ec794ad18c69a7e8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ab9c51dd6ad9ae455ce43987e… Author: Eric Pouech <eric.pouech(a)orange.fr> Date: Sun Nov 8 15:04:47 2009 +0100 richedit: Only increment objects' reference by one when inserting an OLE object. --- dlls/riched20/richole.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/dlls/riched20/richole.c b/dlls/riched20/richole.c index 2a9dc01..c7eb5ff 100644 --- a/dlls/riched20/richole.c +++ b/dlls/riched20/richole.c @@ -388,9 +388,6 @@ IRichEditOle_fnInsertObject(IRichEditOle *me, REOBJECT *reo) TRACE("(%p,%p)\n", This, reo); if (reo->cbStruct < sizeof(*reo)) return STG_E_INVALIDPARAMETER; - if (reo->poleobj) IOleObject_AddRef(reo->poleobj); - if (reo->pstg) IStorage_AddRef(reo->pstg); - if (reo->polesite) IOleClientSite_AddRef(reo->polesite); ME_InsertOLEFromCursor(This->editor, reo, 0); ME_CommitUndo(This->editor);

1 0

Eric Pouech : richedit: When inserting an OLE object from an RTF stream, don't force update as the stream is not fully read.
by Alexandre Julliard 09 Nov '09

09 Nov '09

Module: wine Branch: master Commit: 38df8cfb048c55fe6545ec278f0fe3ff4c0b4c72 URL: http://source.winehq.org/git/wine.git/?a=commit;h=38df8cfb048c55fe6545ec278… Author: Eric Pouech <eric.pouech(a)orange.fr> Date: Sun Nov 8 15:04:53 2009 +0100 richedit: When inserting an OLE object from an RTF stream, don't force update as the stream is not fully read. --- dlls/riched20/editor.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/riched20/editor.c b/dlls/riched20/editor.c index b5ad21c..4bc901e 100644 --- a/dlls/riched20/editor.c +++ b/dlls/riched20/editor.c @@ -1149,8 +1149,8 @@ static BOOL ME_RTFInsertOleObject(RTF_Info *info, HENHMETAFILE hemf, HBITMAP hbm reobject.dwFlags = 0; /* FIXME */ reobject.dwUser = 0; - /* FIXME: could be simpler */ - ret = IRichEditOle_InsertObject(info->lpRichEditOle, &reobject) == S_OK; + ME_InsertOLEFromCursor(info->editor, &reobject, 0); + ret = TRUE; } if (lpObject) IOleObject_Release(lpObject);

1 0