March 2009 - Wine-commits - list.winehq.org

Aric Stewart : msi: Verify the existence of fusion. dll before reporting the .Net version.
by Alexandre Julliard 25 Mar '09

25 Mar '09

Module: wine Branch: master Commit: 28bc76b5d3487a7a3cf26f5edea1e59472ea6916 URL: http://source.winehq.org/git/wine.git/?a=commit;h=28bc76b5d3487a7a3cf26f5ed… Author: Aric Stewart <aric(a)codeweavers.com> Date: Wed Mar 18 14:31:14 2009 -0500 msi: Verify the existence of fusion.dll before reporting the .Net version. Fixes an issue with .Net 3.0 where it does not install a new fusion.dll but does add a key to the registery. The fact that a new dll is not installed has been verified on windows. --- dlls/msi/package.c | 52 ++++++++++++++++++++++++++++++++-------------------- 1 files changed, 32 insertions(+), 20 deletions(-) diff --git a/dlls/msi/package.c b/dlls/msi/package.c index b2c46a2..ec8495f 100644 --- a/dlls/msi/package.c +++ b/dlls/msi/package.c @@ -220,7 +220,7 @@ static LPWSTR get_fusion_filename(MSIPACKAGE *package) { HKEY netsetup; LONG res; - LPWSTR file; + LPWSTR file = NULL; DWORD index = 0, size; WCHAR ver[MAX_PATH]; WCHAR name[MAX_PATH]; @@ -243,34 +243,46 @@ static LPWSTR get_fusion_filename(MSIPACKAGE *package) if (res != ERROR_SUCCESS) return NULL; + GetWindowsDirectoryW(windir, MAX_PATH); + ver[0] = '\0'; size = MAX_PATH; while (RegEnumKeyExW(netsetup, index, name, &size, NULL, NULL, NULL, NULL) == ERROR_SUCCESS) { index++; - if (lstrcmpW(ver, name) < 0) - lstrcpyW(ver, name); - } - RegCloseKey(netsetup); - - if (!index) - return NULL; + /* verify existence of fusion.dll .Net 3.0 does not install a new one */ + if (lstrcmpW(ver, name) < 0) + { + LPWSTR check; + size = lstrlenW(windir) + lstrlenW(subdir) + lstrlenW(name) +lstrlenW(fusion) + 3; + check = msi_alloc(size * sizeof(WCHAR)); - GetWindowsDirectoryW(windir, MAX_PATH); + if (!check) + { + if (file) msi_free(file); + return NULL; + } - size = lstrlenW(windir) + lstrlenW(subdir) + lstrlenW(ver) +lstrlenW(fusion) + 3; - file = msi_alloc(size * sizeof(WCHAR)); - if (!file) - return NULL; + lstrcpyW(check, windir); + lstrcatW(check, backslash); + lstrcatW(check, subdir); + lstrcatW(check, name); + lstrcatW(check, backslash); + lstrcatW(check, fusion); - lstrcpyW(file, windir); - lstrcatW(file, backslash); - lstrcatW(file, subdir); - lstrcatW(file, ver); - lstrcatW(file, backslash); - lstrcatW(file, fusion); + if(GetFileAttributesW(check) != INVALID_FILE_ATTRIBUTES) + { + msi_free(file); + file = check; + lstrcpyW(ver, name); + } + else + msi_free(check); + } + } + RegCloseKey(netsetup); return file; }

1 0

Patrick Gauthier : user32/tests: Check effect of magic font height value 0x7fff in dialog template.
by Alexandre Julliard 25 Mar '09

25 Mar '09

Module: wine Branch: master Commit: 08c0ddec80f557bba109c908389e25bf9cddab39 URL: http://source.winehq.org/git/wine.git/?a=commit;h=08c0ddec80f557bba109c9083… Author: Patrick Gauthier <webmaster(a)korosoft.net> Date: Fri Mar 20 19:23:39 2009 -0400 user32/tests: Check effect of magic font height value 0x7fff in dialog template. --- dlls/user32/tests/dialog.c | 95 ++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 95 insertions(+), 0 deletions(-) diff --git a/dlls/user32/tests/dialog.c b/dlls/user32/tests/dialog.c index 84929e3..7f8dfae 100644 --- a/dlls/user32/tests/dialog.c +++ b/dlls/user32/tests/dialog.c @@ -36,6 +36,7 @@ #include "wine/test.h" #include "windef.h" #include "winbase.h" +#include "wingdi.h" #include "winuser.h" #define MAXHWNDS 1024 @@ -926,6 +927,99 @@ static void test_DisabledDialogTest(void) ok(FALSE == g_terminated, "dialog with disabled ok button has been terminated\n"); } +static INT_PTR CALLBACK messageBoxFontDlgWinProc (HWND hDlg, UINT uiMsg, WPARAM wParam, + LPARAM lParam) +{ + return (uiMsg == WM_INITDIALOG); +} + +static void test_MessageBoxFontTest(void) +{ + /* This dialog template defines a dialog template which got 0x7fff as its + * font size and omits the other font members. On WinNT, passing such a + * dialog template to CreateDialogIndirectParamW will result in a dialog + * being created which uses the message box font. We test that here. + */ + + static unsigned char dlgTemplate[] = + { + /* Dialog header */ + 0x01,0x00, /* Version */ + 0xff,0xff, /* Extended template marker */ + 0x00,0x00,0x00,0x00, /* Context Help ID */ + 0x00,0x00,0x00,0x00, /* Extended style */ + 0xc0,0x00,0xc8,0x80, /* Style (WS_SYSMENU|WS_CAPTION|WS_POPUP|DS_SETFONT|DS_MODALFRAME) */ + 0x01,0x00, /* Control count */ + 0x00,0x00, /* X */ + 0x00,0x00, /* Y */ + 0x80,0x00, /* Width */ + 0x80,0x00, /* Height */ + 0x00,0x00, /* Menu name */ + 0x00,0x00, /* Class name */ + 'T',0x00,'e',0x00, /* Caption (unicode) */ + 's',0x00,'t',0x00, + 0x00,0x00, + 0xff,0x7f, /* Font height (0x7fff = message box font) */ + + /* Control #1 */ + 0x00,0x00, /* Align to DWORD (header is 42 bytes) */ + 0x00,0x00,0x00,0x00, /* Context Help ID */ + 0x00,0x00,0x00,0x00, /* Extended style */ + 0x00,0x00,0x00,0x50, /* Style (WS_CHILD|WS_VISIBLE) */ + 0x00,0x00, /* X */ + 0x00,0x00, /* Y */ + 0x80,0x00, /* Width */ + 0x80,0x00, /* Height */ + 0x00,0x01,0x00,0x00, /* Control ID (256) */ + 0xff,0xff,0x82,0x00, /* Class (Static) */ + 'W',0x00,'I',0x00, /* Caption (unicode) */ + 'N',0x00,'E',0x00, + ' ',0x00,'d',0x00, + 'i',0x00,'a',0x00, + 'l',0x00,'o',0x00, + 'g',0x00,' ',0x00, + 't',0x00,'e',0x00, + 's',0x00,'t',0x00, + '.',0x00,0x00,0x00, + 0x00,0x00, /* Size of extended data */ + + 0x00,0x00 /* Align to DWORD */ + }; + + HWND hDlg; + HFONT hFont; + LOGFONTW lfStaticFont; + NONCLIENTMETRICSW ncMetrics; + + /* Check if the dialog can be created from the template. On Win9x, this should fail + * because we are calling the W function which is not implemented, but that's what + * we want, because passing such a template to CreateDialogIndirectParamA would crash + * anyway. + */ + hDlg = CreateDialogIndirectParamW(g_hinst, (LPCDLGTEMPLATE)dlgTemplate, NULL, messageBoxFontDlgWinProc, 0); + if (!hDlg) + { + todo_wine win_skip("dialog wasn't created\n"); + return; + } + + hFont = (HFONT) SendDlgItemMessageW(hDlg, 256, WM_GETFONT, 0, 0); + if (!hFont) + { + skip("dialog uses system font\n"); + DestroyWindow(hDlg); + return; + } + GetObjectW(hFont, sizeof(LOGFONTW), &lfStaticFont); + + ncMetrics.cbSize = sizeof(NONCLIENTMETRICSW); + SystemParametersInfoW(SPI_GETNONCLIENTMETRICS, 0, &ncMetrics, 0); + ok( !memcmp(&lfStaticFont, &ncMetrics.lfMessageFont, FIELD_OFFSET(LOGFONTW, lfFaceName)) && + !lstrcmpW(lfStaticFont.lfFaceName, ncMetrics.lfMessageFont.lfFaceName), + "dialog doesn't use message box font\n"); + DestroyWindow(hDlg); +} + START_TEST(dialog) { g_hinst = GetModuleHandleA (0); @@ -939,4 +1033,5 @@ START_TEST(dialog) test_GetDlgItemText(); test_DialogBoxParamA(); test_DisabledDialogTest(); + test_MessageBoxFontTest(); }

1 0

Aric Stewart : msctf: Define ITfTextInputProcessor. Implemented by the Text Services.
by Alexandre Julliard 25 Mar '09

25 Mar '09

Module: wine Branch: master Commit: 3cf4284309809424c6933b4b3cd391bca0e8f3c8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=3cf4284309809424c6933b4b3… Author: Aric Stewart <aric(a)codeweavers.com> Date: Tue Mar 24 08:45:06 2009 -0500 msctf: Define ITfTextInputProcessor. Implemented by the Text Services. --- include/msctf.idl | 15 +++++++++++++++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/include/msctf.idl b/include/msctf.idl index 8411e5b..d9c9710 100644 --- a/include/msctf.idl +++ b/include/msctf.idl @@ -471,3 +471,18 @@ interface IEnumTfLanguageProfiles : IUnknown HRESULT Skip( [in] ULONG ulCount); }; + +[ + object, + local, + uuid(aa80e7f7-2021-11d2-93e0-0060b067b86e), + pointer_default(unique) +] +interface ITfTextInputProcessor : IUnknown +{ + HRESULT Activate( + [in] ITfThreadMgr *ptim, + [in] TfClientId tid); + + HRESULT Deactivate(); +};

1 0

Aric Stewart : msctf: Add ITfThreadMgrEventSink to ThreadMgr.
by Alexandre Julliard 25 Mar '09

25 Mar '09

Module: wine Branch: master Commit: 1f21795f93131a8b06004fffff44bd937f5ec59f URL: http://source.winehq.org/git/wine.git/?a=commit;h=1f21795f93131a8b06004ffff… Author: Aric Stewart <aric(a)codeweavers.com> Date: Tue Mar 24 08:21:39 2009 -0500 msctf: Add ITfThreadMgrEventSink to ThreadMgr. --- dlls/msctf/threadmgr.c | 34 +++++++++++++++++++++++++++++++--- include/msctf.idl | 24 ++++++++++++++++++++++++ 2 files changed, 55 insertions(+), 3 deletions(-) diff --git a/dlls/msctf/threadmgr.c b/dlls/msctf/threadmgr.c index eb5918e..080c023 100644 --- a/dlls/msctf/threadmgr.c +++ b/dlls/msctf/threadmgr.c @@ -32,6 +32,7 @@ #include "shlwapi.h" #include "winerror.h" #include "objbase.h" +#include "olectl.h" #include "wine/unicode.h" #include "wine/list.h" @@ -51,7 +52,7 @@ typedef struct tagThreadMgrSink { /* ITfKeyTraceEventSink *pITfKeyTraceEventSink; */ /* ITfPreservedKeyNotifySink *pITfPreservedKeyNotifySink; */ /* ITfThreadFocusSink *pITfThreadFocusSink; */ - /* ITfThreadMgrEventSink *pITfThreadMgrEventSink; */ + ITfThreadMgrEventSink *pITfThreadMgrEventSink; } interfaces; } ThreadMgrSink; @@ -327,9 +328,36 @@ static ULONG WINAPI Source_Release(ITfSource *iface) static WINAPI HRESULT ThreadMgrSource_AdviseSink(ITfSource *iface, REFIID riid, IUnknown *punk, DWORD *pdwCookie) { + ThreadMgrSink *tms; ThreadMgr *This = impl_from_ITfSourceVtbl(iface); - FIXME("STUB:(%p)\n",This); - return E_NOTIMPL; + + TRACE("(%p) %s %p %p\n",This,debugstr_guid(riid),punk,pdwCookie); + + if (!riid || !punk || !pdwCookie) + return E_INVALIDARG; + + if (IsEqualIID(riid, &IID_ITfThreadMgrEventSink)) + { + tms = HeapAlloc(GetProcessHeap(),0,sizeof(ThreadMgrSink)); + if (!tms) + return E_OUTOFMEMORY; + if (!SUCCEEDED(IUnknown_QueryInterface(punk, riid, (LPVOID*)&tms->interfaces.pITfThreadMgrEventSink))) + { + HeapFree(GetProcessHeap(),0,tms); + return CONNECT_E_CANNOTCONNECT; + } + list_add_head(&This->ThreadMgrEventSink,&tms->entry); + *pdwCookie = (DWORD)tms; + } + else + { + FIXME("(%p) Unhandled Sink: %s\n",This,debugstr_guid(riid)); + return E_NOTIMPL; + } + + TRACE("cookie %x\n",*pdwCookie); + + return S_OK; } static WINAPI HRESULT ThreadMgrSource_UnadviseSink(ITfSource *iface, DWORD pdwCookie) diff --git a/include/msctf.idl b/include/msctf.idl index d9c9710..c81c0da 100644 --- a/include/msctf.idl +++ b/include/msctf.idl @@ -486,3 +486,27 @@ interface ITfTextInputProcessor : IUnknown HRESULT Deactivate(); }; + +[ + object, + uuid(aa80e80e-2021-11d2-93e0-0060b067b86e), + pointer_default(unique) +] +interface ITfThreadMgrEventSink : IUnknown +{ + HRESULT OnInitDocumentMgr( + [in] ITfDocumentMgr *pdim); + + HRESULT OnUninitDocumentMgr( + [in] ITfDocumentMgr *pdim); + + HRESULT OnSetFocus( + [in] ITfDocumentMgr *pdimFocus, + [in] ITfDocumentMgr *pdimPrevFocus); + + HRESULT OnPushContext( + [in] ITfContext *pic); + + HRESULT OnPopContext( + [in] ITfContext *pic); +};

1 0

Aric Stewart : msctf: Hook up the DocumentMgr to be able to forward ITfThreadMgrEventSink events to sinks advised to the ThreadMgr .
by Alexandre Julliard 25 Mar '09

25 Mar '09

Module: wine Branch: master Commit: db37679b4e8e3e25729ec2364027d78cd8de60f0 URL: http://source.winehq.org/git/wine.git/?a=commit;h=db37679b4e8e3e25729ec2364… Author: Aric Stewart <aric(a)codeweavers.com> Date: Tue Mar 24 08:21:47 2009 -0500 msctf: Hook up the DocumentMgr to be able to forward ITfThreadMgrEventSink events to sinks advised to the ThreadMgr. --- dlls/msctf/documentmgr.c | 20 ++++++- dlls/msctf/msctf_internal.h | 2 +- dlls/msctf/threadmgr.c | 134 ++++++++++++++++++++++++++++++++++++++++++- 3 files changed, 153 insertions(+), 3 deletions(-) diff --git a/dlls/msctf/documentmgr.c b/dlls/msctf/documentmgr.c index c875145..ab250cb 100644 --- a/dlls/msctf/documentmgr.c +++ b/dlls/msctf/documentmgr.c @@ -46,6 +46,7 @@ typedef struct tagDocumentMgr { LONG refCount; ITfContext* contextStack[2]; /* limit of 2 contexts */ + ITfThreadMgrEventSink* ThreadMgrSink; } DocumentMgr; static inline DocumentMgr *impl_from_ITfSourceVtbl(ITfSource *iface) @@ -130,9 +131,14 @@ static HRESULT WINAPI DocumentMgr_Push(ITfDocumentMgr *iface, ITfContext *pic) if (!pic || FAILED(IUnknown_QueryInterface(pic,&IID_ITfContext,(LPVOID*) &check))) return E_INVALIDARG; + if (This->contextStack[0] == NULL) + ITfThreadMgrEventSink_OnInitDocumentMgr(This->ThreadMgrSink,iface); + This->contextStack[1] = This->contextStack[0]; This->contextStack[0] = check; + ITfThreadMgrEventSink_OnPushContext(This->ThreadMgrSink,check); + return S_OK; } @@ -144,10 +150,17 @@ static HRESULT WINAPI DocumentMgr_Pop(ITfDocumentMgr *iface, DWORD dwFlags) if (dwFlags == TF_POPF_ALL) { if (This->contextStack[0]) + { + ITfThreadMgrEventSink_OnPopContext(This->ThreadMgrSink,This->contextStack[0]); ITfContext_Release(This->contextStack[0]); + } if (This->contextStack[1]) + { + ITfThreadMgrEventSink_OnPopContext(This->ThreadMgrSink,This->contextStack[1]); ITfContext_Release(This->contextStack[1]); + } This->contextStack[0] = This->contextStack[1] = NULL; + ITfThreadMgrEventSink_OnUninitDocumentMgr(This->ThreadMgrSink, iface); return S_OK; } @@ -157,10 +170,14 @@ static HRESULT WINAPI DocumentMgr_Pop(ITfDocumentMgr *iface, DWORD dwFlags) if (This->contextStack[0] == NULL) /* Cannot pop last context */ return E_FAIL; + ITfThreadMgrEventSink_OnPopContext(This->ThreadMgrSink,This->contextStack[0]); ITfContext_Release(This->contextStack[0]); This->contextStack[0] = This->contextStack[1]; This->contextStack[1] = NULL; + if (This->contextStack[0] == NULL) + ITfThreadMgrEventSink_OnUninitDocumentMgr(This->ThreadMgrSink, iface); + return S_OK; } @@ -262,7 +279,7 @@ static const ITfSourceVtbl DocumentMgr_SourceVtbl = DocumentMgrSource_UnadviseSink, }; -HRESULT DocumentMgr_Constructor(ITfDocumentMgr **ppOut) +HRESULT DocumentMgr_Constructor(ITfThreadMgrEventSink *ThreadMgrSink, ITfDocumentMgr **ppOut) { DocumentMgr *This; @@ -273,6 +290,7 @@ HRESULT DocumentMgr_Constructor(ITfDocumentMgr **ppOut) This->DocumentMgrVtbl= &DocumentMgr_DocumentMgrVtbl; This->SourceVtbl = &DocumentMgr_SourceVtbl; This->refCount = 1; + This->ThreadMgrSink = ThreadMgrSink; TRACE("returning %p\n", This); *ppOut = (ITfDocumentMgr*)This; diff --git a/dlls/msctf/msctf_internal.h b/dlls/msctf/msctf_internal.h index 4d83aa3..7a05b7b 100644 --- a/dlls/msctf/msctf_internal.h +++ b/dlls/msctf/msctf_internal.h @@ -23,7 +23,7 @@ extern DWORD tlsIndex; extern HRESULT ThreadMgr_Constructor(IUnknown *pUnkOuter, IUnknown **ppOut); -extern HRESULT DocumentMgr_Constructor(ITfDocumentMgr **ppOut); +extern HRESULT DocumentMgr_Constructor(ITfThreadMgrEventSink*, ITfDocumentMgr **ppOut); extern HRESULT Context_Constructor(TfClientId tidOwner, IUnknown *punk, ITfContext **ppOut, TfEditCookie *pecTextStore); extern HRESULT InputProcessorProfiles_Constructor(IUnknown *pUnkOuter, IUnknown **ppOut); extern HRESULT CategoryMgr_Constructor(IUnknown *pUnkOuter, IUnknown **ppOut); diff --git a/dlls/msctf/threadmgr.c b/dlls/msctf/threadmgr.c index 080c023..b2ec069 100644 --- a/dlls/msctf/threadmgr.c +++ b/dlls/msctf/threadmgr.c @@ -61,6 +61,8 @@ typedef struct tagACLMulti { const ITfSourceVtbl *SourceVtbl; LONG refCount; + const ITfThreadMgrEventSinkVtbl *ThreadMgrEventSinkVtbl; /* internal */ + ITfDocumentMgr *focus; /* kept as separate lists to reduce unnecessary iterations */ @@ -77,6 +79,11 @@ static inline ThreadMgr *impl_from_ITfSourceVtbl(ITfSource *iface) return (ThreadMgr *)((char *)iface - FIELD_OFFSET(ThreadMgr,SourceVtbl)); } +static inline ThreadMgr *impl_from_ITfThreadMgrEventSink(ITfThreadMgrEventSink *iface) +{ + return (ThreadMgr *)((char *)iface - FIELD_OFFSET(ThreadMgr,ThreadMgrEventSinkVtbl)); +} + static void free_sink(ThreadMgrSink *sink) { IUnknown_Release(sink->interfaces.pIUnknown); @@ -195,8 +202,9 @@ static HRESULT WINAPI ThreadMgr_fnDeactivate( ITfThreadMgr* iface) static HRESULT WINAPI ThreadMgr_CreateDocumentMgr( ITfThreadMgr* iface, ITfDocumentMgr **ppdim) { + ThreadMgr *This = (ThreadMgr *)iface; TRACE("(%p)\n",iface); - return DocumentMgr_Constructor(ppdim); + return DocumentMgr_Constructor((ITfThreadMgrEventSink*)&This->ThreadMgrEventSinkVtbl, ppdim); } static HRESULT WINAPI ThreadMgr_EnumDocumentMgrs( ITfThreadMgr* iface, IEnumTfDocumentMgrs @@ -238,6 +246,8 @@ static HRESULT WINAPI ThreadMgr_SetFocus( ITfThreadMgr* iface, ITfDocumentMgr *p if (!pdimFocus || FAILED(IUnknown_QueryInterface(pdimFocus,&IID_ITfDocumentMgr,(LPVOID*) &check))) return E_INVALIDARG; + ITfThreadMgrEventSink_OnSetFocus((ITfThreadMgrEventSink*)&This->ThreadMgrEventSinkVtbl, This->focus, check); + if (This->focus) ITfDocumentMgr_Release(This->focus); @@ -377,6 +387,127 @@ static const ITfSourceVtbl ThreadMgr_SourceVtbl = ThreadMgrSource_UnadviseSink, }; +/***************************************************** + * ITfThreadMgrEventSink functions (internal) + *****************************************************/ +static HRESULT WINAPI ThreadMgrEventSink_QueryInterface(ITfThreadMgrEventSink *iface, REFIID iid, LPVOID *ppvOut) +{ + ThreadMgr *This = impl_from_ITfThreadMgrEventSink(iface); + return ThreadMgr_QueryInterface((ITfThreadMgr *)This, iid, *ppvOut); +} + +static ULONG WINAPI ThreadMgrEventSink_AddRef(ITfThreadMgrEventSink *iface) +{ + ThreadMgr *This = impl_from_ITfThreadMgrEventSink(iface); + return ThreadMgr_AddRef((ITfThreadMgr*)This); +} + +static ULONG WINAPI ThreadMgrEventSink_Release(ITfThreadMgrEventSink *iface) +{ + ThreadMgr *This = impl_from_ITfThreadMgrEventSink(iface); + return ThreadMgr_Release((ITfThreadMgr *)This); +} + + +static WINAPI HRESULT ThreadMgrEventSink_OnInitDocumentMgr( + ITfThreadMgrEventSink *iface,ITfDocumentMgr *pdim) +{ + struct list *cursor; + ThreadMgr *This = impl_from_ITfThreadMgrEventSink(iface); + + TRACE("(%p) %p\n",This,pdim); + + LIST_FOR_EACH(cursor, &This->ThreadMgrEventSink) + { + ThreadMgrSink* sink = LIST_ENTRY(cursor,ThreadMgrSink,entry); + ITfThreadMgrEventSink_OnInitDocumentMgr(sink->interfaces.pITfThreadMgrEventSink,pdim); + } + + return S_OK; +} + +static WINAPI HRESULT ThreadMgrEventSink_OnUninitDocumentMgr( + ITfThreadMgrEventSink *iface, ITfDocumentMgr *pdim) +{ + struct list *cursor; + ThreadMgr *This = impl_from_ITfThreadMgrEventSink(iface); + + TRACE("(%p) %p\n",This,pdim); + + LIST_FOR_EACH(cursor, &This->ThreadMgrEventSink) + { + ThreadMgrSink* sink = LIST_ENTRY(cursor,ThreadMgrSink,entry); + ITfThreadMgrEventSink_OnUninitDocumentMgr(sink->interfaces.pITfThreadMgrEventSink,pdim); + } + + return S_OK; +} + +static WINAPI HRESULT ThreadMgrEventSink_OnSetFocus( + ITfThreadMgrEventSink *iface, ITfDocumentMgr *pdimFocus, + ITfDocumentMgr *pdimPrevFocus) +{ + struct list *cursor; + ThreadMgr *This = impl_from_ITfThreadMgrEventSink(iface); + + TRACE("(%p) %p %p\n",This,pdimFocus, pdimPrevFocus); + + LIST_FOR_EACH(cursor, &This->ThreadMgrEventSink) + { + ThreadMgrSink* sink = LIST_ENTRY(cursor,ThreadMgrSink,entry); + ITfThreadMgrEventSink_OnSetFocus(sink->interfaces.pITfThreadMgrEventSink, pdimFocus, pdimPrevFocus); + } + + return S_OK; +} + +static WINAPI HRESULT ThreadMgrEventSink_OnPushContext( + ITfThreadMgrEventSink *iface, ITfContext *pic) +{ + struct list *cursor; + ThreadMgr *This = impl_from_ITfThreadMgrEventSink(iface); + + TRACE("(%p) %p\n",This,pic); + + LIST_FOR_EACH(cursor, &This->ThreadMgrEventSink) + { + ThreadMgrSink* sink = LIST_ENTRY(cursor,ThreadMgrSink,entry); + ITfThreadMgrEventSink_OnPushContext(sink->interfaces.pITfThreadMgrEventSink,pic); + } + + return S_OK; +} + +static WINAPI HRESULT ThreadMgrEventSink_OnPopContext( + ITfThreadMgrEventSink *iface, ITfContext *pic) +{ + struct list *cursor; + ThreadMgr *This = impl_from_ITfThreadMgrEventSink(iface); + + TRACE("(%p) %p\n",This,pic); + + LIST_FOR_EACH(cursor, &This->ThreadMgrEventSink) + { + ThreadMgrSink* sink = LIST_ENTRY(cursor,ThreadMgrSink,entry); + ITfThreadMgrEventSink_OnPopContext(sink->interfaces.pITfThreadMgrEventSink,pic); + } + + return S_OK; +} + +static const ITfThreadMgrEventSinkVtbl ThreadMgr_ThreadMgrEventSinkVtbl = +{ + ThreadMgrEventSink_QueryInterface, + ThreadMgrEventSink_AddRef, + ThreadMgrEventSink_Release, + + ThreadMgrEventSink_OnInitDocumentMgr, + ThreadMgrEventSink_OnUninitDocumentMgr, + ThreadMgrEventSink_OnSetFocus, + ThreadMgrEventSink_OnPushContext, + ThreadMgrEventSink_OnPopContext +}; + HRESULT ThreadMgr_Constructor(IUnknown *pUnkOuter, IUnknown **ppOut) { ThreadMgr *This; @@ -398,6 +529,7 @@ HRESULT ThreadMgr_Constructor(IUnknown *pUnkOuter, IUnknown **ppOut) This->ThreadMgrVtbl= &ThreadMgr_ThreadMgrVtbl; This->SourceVtbl = &ThreadMgr_SourceVtbl; + This->ThreadMgrEventSinkVtbl = &ThreadMgr_ThreadMgrEventSinkVtbl; This->refCount = 1; TlsSetValue(tlsIndex,This);

1 0

Ken Thomases : dbghelp: Add support for debugging Mach-O modules.
by Alexandre Julliard 25 Mar '09

25 Mar '09

Module: wine Branch: master Commit: d7466e0c4e8202d1713d7f50c8029ff4f6d74fee URL: http://source.winehq.org/git/wine.git/?a=commit;h=d7466e0c4e8202d1713d7f50c… Author: Ken Thomases <ken(a)codeweavers.com> Date: Fri Mar 13 11:48:00 2009 -0500 dbghelp: Add support for debugging Mach-O modules. --- dlls/dbghelp/Makefile.in | 1 + dlls/dbghelp/dbghelp.c | 4 +- dlls/dbghelp/dbghelp_private.h | 16 +- dlls/dbghelp/macho_module.c | 1438 ++++++++++++++++++++++++++++++++++++++++ dlls/dbghelp/module.c | 51 ++- dlls/dbghelp/path.c | 15 + dlls/dbghelp/symbol.c | 5 +- 7 files changed, 1515 insertions(+), 15 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=d7466e0c4e8202d1713d7…

1 0

Ken Thomases : dbghelp: Recognize .dylib files as Mach-O modules.
by Alexandre Julliard 25 Mar '09

25 Mar '09

Module: wine Branch: master Commit: feedbb1630ad5136eccd37487603f169dd89e4ad URL: http://source.winehq.org/git/wine.git/?a=commit;h=feedbb1630ad5136eccd37487… Author: Ken Thomases <ken(a)codeweavers.com> Date: Fri Mar 13 11:48:07 2009 -0500 dbghelp: Recognize .dylib files as Mach-O modules. --- dlls/dbghelp/module.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/dlls/dbghelp/module.c b/dlls/dbghelp/module.c index 3e32a82..1a3d94e 100644 --- a/dlls/dbghelp/module.c +++ b/dlls/dbghelp/module.c @@ -35,6 +35,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(dbghelp); const WCHAR S_ElfW[] = {'<','e','l','f','>','\0'}; const WCHAR S_WineLoaderW[] = {'<','w','i','n','e','-','l','o','a','d','e','r','>','\0'}; static const WCHAR S_DotSoW[] = {'.','s','o','\0'}; +static const WCHAR S_DotDylibW[] = {'.','d','y','l','i','b','\0'}; static const WCHAR S_DotPdbW[] = {'.','p','d','b','\0'}; static const WCHAR S_DotDbgW[] = {'.','d','b','g','\0'}; const WCHAR S_WineW[] = {'w','i','n','e',0}; @@ -430,6 +431,9 @@ enum module_type module_get_type_by_name(const WCHAR* name) return DMT_ELF; #endif + if (len > 6 && !strncmpiW(name + len - 6, S_DotDylibW, 6)) + return DMT_MACHO; + if (len > 4 && !strncmpiW(name + len - 4, S_DotPdbW, 4)) return DMT_PDB;

1 0

Ken Thomases : dbghelp/stabs: For Mach-O, line numbers use absolute address , not offset.
by Alexandre Julliard 25 Mar '09

25 Mar '09

Module: wine Branch: master Commit: 3a96219d5784d7a924b2dab8f7eac842ad3a120f URL: http://source.winehq.org/git/wine.git/?a=commit;h=3a96219d5784d7a924b2dab8f… Author: Ken Thomases <ken(a)codeweavers.com> Date: Fri Mar 13 11:48:21 2009 -0500 dbghelp/stabs: For Mach-O, line numbers use absolute address, not offset. So, compute the offset by subtracting the function address. --- dlls/dbghelp/stabs.c | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/dlls/dbghelp/stabs.c b/dlls/dbghelp/stabs.c index fd88722..b2df46a 100644 --- a/dlls/dbghelp/stabs.c +++ b/dlls/dbghelp/stabs.c @@ -1202,6 +1202,8 @@ static void pending_flush(struct pending_list* pending, struct module* module, block, pending->objs[i].u.var.type, pending->objs[i].u.var.name); break; case PENDING_LINE: + if (module->type == DMT_MACHO) + pending->objs[i].u.line.offset -= func->address; symt_add_func_line(module, func, pending->objs[i].u.line.source_idx, pending->objs[i].u.line.line_num, pending->objs[i].u.line.offset); break; @@ -1485,8 +1487,11 @@ BOOL stabs_parse(struct module* module, unsigned long load_offset, assert(source_idx >= 0); if (curr_func != NULL) { + unsigned long offset = stab_ptr->n_value; + if (module->type == DMT_MACHO) + offset -= curr_func->address; symt_add_func_line(module, curr_func, source_idx, - stab_ptr->n_desc, stab_ptr->n_value); + stab_ptr->n_desc, offset); } else pending_add_line(&pending_func, source_idx, stab_ptr->n_desc, stab_ptr->n_value);

1 0

Ken Thomases : dbghelp: Include Mach-O modules in minidumps.
by Alexandre Julliard 25 Mar '09

25 Mar '09

Module: wine Branch: master Commit: 31fd8dd763519cfcfd84bb09c4974668e85e20b0 URL: http://source.winehq.org/git/wine.git/?a=commit;h=31fd8dd763519cfcfd84bb09c… Author: Ken Thomases <ken(a)codeweavers.com> Date: Fri Mar 13 11:48:27 2009 -0500 dbghelp: Include Mach-O modules in minidumps. --- dlls/dbghelp/minidump.c | 22 ++++++++++++++++++++++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/dlls/dbghelp/minidump.c b/dlls/dbghelp/minidump.c index da0632a..78e754f 100644 --- a/dlls/dbghelp/minidump.c +++ b/dlls/dbghelp/minidump.c @@ -316,6 +316,27 @@ static BOOL fetch_elf_module_info_cb(const WCHAR* name, unsigned long base, return TRUE; } +/****************************************************************** + * fetch_macho_module_info_cb + * + * Callback for accumulating in dump_context a Mach-O modules set + */ +static BOOL fetch_macho_module_info_cb(const WCHAR* name, unsigned long base, + void* user) +{ + struct dump_context* dc = (struct dump_context*)user; + DWORD rbase, size, checksum; + + /* FIXME: there's no relevant timestamp on Mach-O modules */ + /* NB: if we have a non-null base from the live-target use it. If we have + * a null base, then grab its base address from Mach-O file. + */ + if (!macho_fetch_file_info(name, &rbase, &size, &checksum)) + size = checksum = 0; + add_module(dc, name, base ? base : rbase, size, 0 /* FIXME */, checksum, TRUE); + return TRUE; +} + static void fetch_modules_info(struct dump_context* dc) { EnumerateLoadedModulesW64(dc->hProcess, fetch_pe_module_info_cb, dc); @@ -325,6 +346,7 @@ static void fetch_modules_info(struct dump_context* dc) * a given application in a post mortem debugging condition. */ elf_enum_modules(dc->hProcess, fetch_elf_module_info_cb, dc); + macho_enum_modules(dc->hProcess, fetch_macho_module_info_cb, dc); } static void fetch_module_versioninfo(LPCWSTR filename, VS_FIXEDFILEINFO* ffi)

1 0

Henri Verbeet : wined3d: Print a FIXME in tex_coordindex() when NV_TEXGEN_REFLECTION isn't supported.
by Alexandre Julliard 25 Mar '09

25 Mar '09

Module: wine Branch: master Commit: 61cd872fa76b2ac6dcd54e50e427ae0e2ca8dc50 URL: http://source.winehq.org/git/wine.git/?a=commit;h=61cd872fa76b2ac6dcd54e50e… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed Mar 25 10:12:26 2009 +0100 wined3d: Print a FIXME in tex_coordindex() when NV_TEXGEN_REFLECTION isn't supported. --- dlls/wined3d/state.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/dlls/wined3d/state.c b/dlls/wined3d/state.c index 5f07452..2757c64 100644 --- a/dlls/wined3d/state.c +++ b/dlls/wined3d/state.c @@ -3161,8 +3161,11 @@ static void tex_coordindex(DWORD state, IWineD3DStateBlockImpl *stateblock, Wine break; case WINED3DTSS_TCI_CAMERASPACENORMAL: + /* Note that NV_TEXGEN_REFLECTION support is implied when + * ARB_TEXTURE_CUBE_MAP is supported */ if (!GL_SUPPORT(NV_TEXGEN_REFLECTION)) { + FIXME("WINED3DTSS_TCI_CAMERASPACENORMAL not supported.\n"); break; } @@ -3193,8 +3196,11 @@ static void tex_coordindex(DWORD state, IWineD3DStateBlockImpl *stateblock, Wine break; case WINED3DTSS_TCI_CAMERASPACEREFLECTIONVECTOR: + /* Note that NV_TEXGEN_REFLECTION support is implied when + * ARB_TEXTURE_CUBE_MAP is supported */ if (!GL_SUPPORT(NV_TEXGEN_REFLECTION)) { + FIXME("WINED3DTSS_TCI_CAMERASPACEREFLECTIONVECTOR not supported.\n"); break; }

1 0