July 2009 - Wine-commits - list.winehq.org

Alexander Nicolaysen Sørnes : commentview.php: Don't allow unset or 0 versionId
by Alexander Nicolaysen Sørnes 30 Jul '09

30 Jul '09

Module: appdb Branch: master Commit: b8be6a22ce6e76489a745877fcc8c160143ac776 URL: http://source.winehq.org/git/appdb.git/?a=commit;h=b8be6a22ce6e76489a745877… Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Date: Thu Jul 30 21:53:49 2009 +0200 commentview.php: Don't allow unset or 0 versionId --- commentview.php | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/commentview.php b/commentview.php index 7f2e87f..e25774d 100644 --- a/commentview.php +++ b/commentview.php @@ -12,9 +12,15 @@ require("path.php"); require(BASE."include/incl.php"); require_once(BASE."include/comment.php"); +$iVersionId = getInput('iVersionId', $aClean); +$iThreadId = getInput('iThreadId', $aClean); + +if(!$iVersionId) + util_show_error_page_and_exit('No versionId defined'); + apidb_header("Comments"); -Comment::view_app_comments($aClean['iVersionId'], $aClean['iThreadId']); +Comment::view_app_comments($iVersionId, $iThreadId); apidb_footer(); ?>

1 0

Alexander Nicolaysen Sørnes : objectManager: Prevent accessing an undefined variable
by Alexander Nicolaysen Sørnes 30 Jul '09

30 Jul '09

Module: appdb Branch: master Commit: b8ac180e11b97701d3976401cc85f043255802cb URL: http://source.winehq.org/git/appdb.git/?a=commit;h=b8ac180e11b97701d3976401… Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Date: Thu Jul 30 18:28:50 2009 +0200 objectManager: Prevent accessing an undefined variable --- include/objectManager.php | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/include/objectManager.php b/include/objectManager.php index 3af090c..6b324f7 100644 --- a/include/objectManager.php +++ b/include/objectManager.php @@ -104,13 +104,12 @@ class ObjectManager public function setSortInfo($aClean = null) { + $this->oSortInfo = new TableSortInfo($this->makeUrl().'&'); + /* No use to continue if there are no sortable fields */ if(!$this->getOptionalSetting("objectGetSortableFields", FALSE)) return; - $this->oSortInfo = null; - $this->oSortInfo = new TableSortInfo($this->makeUrl().'&'); - if($aClean) $this->oSortInfo->ParseArray($aClean, $this->getObject()->objectGetSortableFields()); }

1 0

Alexander Nicolaysen Sørnes : bug: Correct casing for an SQL column
by Alexander Nicolaysen Sørnes 30 Jul '09

30 Jul '09

Module: appdb Branch: master Commit: 5cce3b1c5f5252209c5707d66785928a1a6be372 URL: http://source.winehq.org/git/appdb.git/?a=commit;h=5cce3b1c5f5252209c5707d6… Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Date: Thu Jul 30 18:22:10 2009 +0200 bug: Correct casing for an SQL column --- include/bugs.php | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/bugs.php b/include/bugs.php index 45a3887..4318c46 100644 --- a/include/bugs.php +++ b/include/bugs.php @@ -36,7 +36,7 @@ class Bug if(!$oRow) { $sQuery = "SELECT * FROM buglinks - WHERE linkid = '?'"; + WHERE linkId = '?'"; if($hResult = query_parameters($sQuery, $iLinkId)) { $oRow = query_fetch_object($hResult);

1 0

Alexander Nicolaysen Sørnes : bug: Prevent duplicates when moving bug links
by Alexander Nicolaysen Sørnes 30 Jul '09

30 Jul '09

Module: appdb Branch: master Commit: 68d43b73d24f51839efd3d3d97323507e11ff3ea URL: http://source.winehq.org/git/appdb.git/?a=commit;h=68d43b73d24f51839efd3d3d… Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Date: Thu Jul 30 16:58:53 2009 +0200 bug: Prevent duplicates when moving bug links --- include/bugs.php | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/include/bugs.php b/include/bugs.php index 9c38fa8..45a3887 100644 --- a/include/bugs.php +++ b/include/bugs.php @@ -181,6 +181,11 @@ class Bug { $oBug = new bug($this->iLinkId); + // There is no need to have two links to a bug. The update is still + // considered successful + if($this->isDuplicate()) + return $this->delete(); + if($this->iVersionId && $this->iVersionId != $oBug->iVersionId) { $hResult = query_parameters("UPDATE buglinks SET versionId = '?'

1 0

Alexander Nicolaysen Sørnes : bug: Move duplicate detection to a separate function
by Alexander Nicolaysen Sørnes 30 Jul '09

30 Jul '09

Module: appdb Branch: master Commit: 8e9122b6f5ae4cb35359b0569fdf96ae674e0692 URL: http://source.winehq.org/git/appdb.git/?a=commit;h=8e9122b6f5ae4cb35359b056… Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Date: Thu Jul 30 16:52:42 2009 +0200 bug: Move duplicate detection to a separate function --- include/bugs.php | 35 +++++++++++++++++++++-------------- 1 files changed, 21 insertions(+), 14 deletions(-) diff --git a/include/bugs.php b/include/bugs.php index ed22aaf..9c38fa8 100644 --- a/include/bugs.php +++ b/include/bugs.php @@ -106,21 +106,11 @@ class Bug return false; } - /* Check for Duplicates */ - - $sQuery = "SELECT * - FROM buglinks - WHERE versionId = '?'"; - if($hResult = query_parameters($sQuery, $this->iVersionId)) + /* Check for duplicates */ + if($this->isDuplicate()) { - while($oRow = query_fetch_object($hResult)) - { - if($oRow->bug_id == $this->iBug_id) - { - addmsg("The Bug link has already been submitted.", "red"); - return false; - } - } + addmsg("The Bug link has already been submitted.", "red"); + return false; } /* passed the checks so lets insert the puppy! */ @@ -204,6 +194,23 @@ class Bug return true; } + /* Checks whether the version already has a link for this bug */ + public function isDuplicate() + { + $sQuery = "SELECT COUNT(linkId) as count + FROM buglinks + WHERE versionId = '?' + AND bug_id = '?'"; + if($hResult = query_parameters($sQuery, $this->iVersionId, $this->iBug_id)) + { + if(($oRow = query_fetch_object($hResult))) + { + return $oRow->count > 0; + } + } + return false; + } + function mailSubmitter($bRejected=false) { global $aClean;

1 0

Alexander Nicolaysen Sørnes : testData: Remove the 'test data modified' screen message
by Alexander Nicolaysen Sørnes 30 Jul '09

30 Jul '09

Module: appdb Branch: master Commit: a083c9eb0e576fb0a5330b0894891e0e134afd5e URL: http://source.winehq.org/git/appdb.git/?a=commit;h=a083c9eb0e576fb0a5330b08… Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Date: Thu Jul 30 16:44:45 2009 +0200 testData: Remove the 'test data modified' screen message --- include/testData.php | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/include/testData.php b/include/testData.php index d2d4b36..33661b1 100644 --- a/include/testData.php +++ b/include/testData.php @@ -501,7 +501,6 @@ class testData{ case "edit": $sSubject = "Test Results modified for version ".$oVersion->sName." of ".$oApp->sName." by ".$_SESSION['current']->sRealname; $sMsg .= $sBacklink; - addmsg("test data modified.", "green"); break; case "reject": $sSubject = "Test Results rejected for version ".$oVersion->sName." of ".$oApp->sName." by ".$_SESSION['current']->sRealname;

1 0

Alexander Nicolaysen Sørnes : Only show 'create new parent' link for applications
by Alexander Nicolaysen Sørnes 30 Jul '09

30 Jul '09

Module: appdb Branch: master Commit: 8fbe27e679793f29c99bd581d10f7562fb65c74b URL: http://source.winehq.org/git/appdb.git/?a=commit;h=8fbe27e679793f29c99bd581… Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Date: Thu Jul 30 16:06:15 2009 +0200 Only show 'create new parent' link for applications --- include/application.php | 5 +++++ include/objectManager.php | 3 ++- 2 files changed, 7 insertions(+), 1 deletions(-) diff --git a/include/application.php b/include/application.php index 4112c0b..2a1a704 100644 --- a/include/application.php +++ b/include/application.php @@ -1439,6 +1439,11 @@ class Application { return $iCount; } + public static function objectAllowMovingToNewParent() + { + return TRUE; + } + public static function allowAnonymousSubmissions() { return FALSE; diff --git a/include/objectManager.php b/include/objectManager.php index 4235279..3af090c 100644 --- a/include/objectManager.php +++ b/include/objectManager.php @@ -921,7 +921,8 @@ class ObjectManager $sClassDisplayName = $oParentOM->GetOptionalSetting('objectGetClassDisplayName', 'parent entry'); - echo '<p><a href="'.$this->makeUrl('moveToNewParent', $this->iId)."\">Create and move to a new $sClassDisplayName</a></p>\n"; + if($this->GetOptionalSetting('objectAllowMovingToNewParent', false)) + echo '<p><a href="'.$this->makeUrl('moveToNewParent', $this->iId)."\">Create and move to a new $sClassDisplayName</a></p>\n"; /* Display some help text */ echo "<p>Move ".$oObject->objectMakeLink()." to the $sClassDisplayName ";

1 0

Alexander Nicolaysen Sørnes : note: Allow moving from app to version, fix some mail texts
by Alexander Nicolaysen Sørnes 30 Jul '09

30 Jul '09

Module: appdb Branch: master Commit: 6f1de3983796ec23dcc29e79b77aab26c2bdc5b3 URL: http://source.winehq.org/git/appdb.git/?a=commit;h=6f1de3983796ec23dcc29e79… Author: Alexander Nicolaysen Sørnes <alexander(a)linux-xqqm.(none)> Date: Thu Jul 30 00:51:52 2009 +0200 note: Allow moving from app to version, fix some mail texts --- include/note.php | 68 +++++++++++++++++++++++++++++++++++++++++++++-------- 1 files changed, 57 insertions(+), 11 deletions(-) diff --git a/include/note.php b/include/note.php index 3be1b94..57f92a4 100644 --- a/include/note.php +++ b/include/note.php @@ -10,6 +10,7 @@ require_once(BASE."include/version.php"); define('APPNOTE_SHOW_FOR_ALL', -1); define('APPNOTE_SHOW_FOR_VERSIONS', -2); define('APPNOTE_SHOW_FOR_APP', -3); +define('DISPLAYMODE_COUNT', 3); /** * Note class for handling notes @@ -121,17 +122,28 @@ class Note { $this->iVersionId, $this->iNoteId)) return false; - if(!$this->iAppId) + if(!$this->iAppId && !$oNote->iAppId) // Changed version only { $sVersionBefore = Version::lookup_name($oNote->iVersionId); $sVersionAfter = Version::lookup_name($this->iVersionId); $sWhatChanged .= "Version was changed from ".$sVersionBefore." to ".$sVersionAfter.".\n\n"; - } else + } else if(!$this->iAppId) // Moved from app to version + { + $sVersionAfter = Version::fullName($this->iVersionId); + $oApp = new application($oNote->iAppId); + $sOldApp = $oApp->sName; + $sWhatChanged .= "Moved from application $sOldApp to version $sVersionAfter.\n\n"; + } else if($oNote->hasRealVersionId()) // Moved from version to app { $oApp = new application($this->iAppId); $sNewApp = $oApp->sName; $sVersionBefore = version::fullName($oNote->iVersionId); $sWhatChanged .= "Moved from version $sVersionBefore to application $sNewApp.\n\n"; + } else // Change display mode for app note + { + $sOldMode = $oNote->getDisplayModeName(); + $sNewMode = $this->getDisplayModeName(); + $sWhatChanged .= "Display mode was changed from '$sOldMode' to '$sNewMode'.\n\n"; } } if (($this->iAppId || $this->iVersionId) && $this->iAppId!=$oNote->iAppId) @@ -336,6 +348,34 @@ class Note { return note::isRealVersionId($this->iVersionId); } + public static function getDisplayModeIds() + { + return array(APPNOTE_SHOW_FOR_ALL, APPNOTE_SHOW_FOR_VERSIONS, APPNOTE_SHOW_FOR_APP); + } + + public static function getDisplayModeNames() + { + return array('Show on both application and version pages', 'Show on all version pages only', 'Show on application page only'); + } + + public function getDisplayModeName($iModeId = null) + { + if(!$iModeId) + $iModeId = $this->iVersionId; + + $aNames = note::getDisplayModeNames(); + $iIndex = 0; + + foreach(note::getDisplayModeIds() as $iId) + { + if($iId == $iModeId) + return $aNames[$iIndex]; + $iIndex++; + } + + return ''; + } + function outputEditor($aValues = null) { if($aValues) @@ -377,21 +417,27 @@ class Note { echo '</p>'; echo '</td></tr>'."\n"; - if($this->iAppId); - $oApp = new application($this->iAppId); if($this->iAppId || $oApp->canEdit()) { + $oApp = new application($this->iAppId); + $aIds = $this->getDisplayModeIds(); + $aOptions = $this->getDisplayModeNames(); + + echo '<tr><td class="color1">Display mode</td>'."\n"; + echo '<td class="color0">'.html_radiobuttons($aIds, $aOptions, 'iVersionId', $this->iVersionId); + + /* Allow the note to be moved to a single version */ $aIds = array(); $aOptions = array(); - if($this->isRealVersionId($this->iVersionId)) + echo 'Show on one of the following version pages only:<br />'; + foreach($oApp->getVersions(true) as $oAppVersion) // Only accepted versions { - $aIds[] = $this->iVersionId; - $aOptions[] = 'Show for this version only'; + + $aIds[] = $oAppVersion->objectGetId(); + $aOptions[] = $oAppVersion->objectMakeLink(); } - $aIds = array_merge($aIds, array(APPNOTE_SHOW_FOR_ALL, APPNOTE_SHOW_FOR_VERSIONS, APPNOTE_SHOW_FOR_APP)); - $aOptions = array_merge($aOptions, array('Show on both application and version pages', 'Show on all version pages only', 'Show on application page only'));; - echo '<tr><td class="color1">Display mode</td>'."\n"; - echo '<td class="color0">'.html_radiobuttons($aIds, $aOptions, 'iVersionId', $this->iVersionId); + echo html_radiobuttons($aIds, $aOptions, 'iVersionId', $this->iVersionId); + echo '</td></tr>'; } else if(!$this->iAppId) {

1 0

Alexander Nicolaysen Sørnes : Misc. capitalization changes
by Alexander Nicolaysen Sørnes 29 Jul '09

29 Jul '09

Module: appdb Branch: master Commit: 295ff345ba456dc0a7b92fe4aad9752e13521fcc URL: http://source.winehq.org/git/appdb.git/?a=commit;h=295ff345ba456dc0a7b92fe4… Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Date: Wed Jul 29 21:21:11 2009 +0200 Misc. capitalization changes --- include/bugs.php | 10 +++++----- include/comment.php | 4 ++-- include/note.php | 2 +- include/testData.php | 4 ++-- include/version.php | 2 +- 5 files changed, 11 insertions(+), 11 deletions(-) diff --git a/include/bugs.php b/include/bugs.php index 48fbb4e..ed22aaf 100644 --- a/include/bugs.php +++ b/include/bugs.php @@ -587,12 +587,12 @@ function view_version_bugs($iVersionId = null, $aBuglinkIds) echo " <td>Description</td>\n"; echo " <td align=center width=\"80\">Status</td>\n"; echo " <td align=center width=\"80\">Resolution</td>\n"; - echo " <td align=center width=\"80\">Other Apps affected</td>\n"; + echo " <td align=center width=\"80\">Other apps affected</td>\n"; if($bCanEdit == true) { - echo " <td align=center width=\"80\">delete</td>\n"; - echo " <td align=center width=\"80\">checked</td>\n"; + echo " <td align=center width=\"80\">Delete</td>\n"; + echo " <td align=center width=\"80\">Checked</td>\n"; } echo "</tr>\n\n"; @@ -658,13 +658,13 @@ function view_version_bugs($iVersionId = null, $aBuglinkIds) if ( isset( $aClean['sAllBugs'] ) ) { $sURL = str_replace( '&sAllBugs', '', $_SERVER['REQUEST_URI'] ); - $sLink = '<a href="' . htmlentities($sURL) . '">Show Open Bugs</a>'; + $sLink = '<a href="' . htmlentities($sURL) . '">Show open bugs</a>'; } // show all link else { $sURL = $_SERVER['REQUEST_URI'] . '&sAllBugs'; - $sLink = '<a href="' . htmlentities($sURL) . '">Show All Bugs</a>'; + $sLink = '<a href="' . htmlentities($sURL) . '">Show all bugs</a>'; } echo '<div style="text-align:right;">' . $sLink .'</div>'; diff --git a/include/comment.php b/include/comment.php index 6a1716a..a999e41 100644 --- a/include/comment.php +++ b/include/comment.php @@ -617,8 +617,8 @@ class Comment { $sel[$_SESSION['current']->getPref("comments:mode", "threaded")] = 'selected'; echo '<td><form method="post" name="sMode" action="'. $oVersion->objectMakeUrl().'">',"\n"; - echo "<b>Application Comments</b> $messageCount total comments "; - echo '<b>Mode</b> <select name="sCmode" onchange="document.sMode.submit();">',"\n"; + echo "<b>Application comments:</b> $messageCount total comments "; + echo '<b>Mode:</b> <select name="sCmode" onchange="document.sMode.submit();">',"\n"; echo ' <option value="flat" '.$sel['flat'].'>Flat</option>',"\n"; echo ' <option value="threaded" '.$sel['threaded'].'>Threaded</option>',"\n"; echo ' <option value="nested" '.$sel['nested'].'>Nested</option>',"\n"; diff --git a/include/note.php b/include/note.php index 4233ac3..3be1b94 100644 --- a/include/note.php +++ b/include/note.php @@ -270,7 +270,7 @@ class Note { { $shOutput .= "<tr class=\"color1\" align=\"center\" valign=\"top\"><td>"; $shOutput .= "<form method=\"post\" name=\"message\" action=\"objectManager.php?sClass=note&sAction=edit&iId=".$this->iNoteId."&sReturnTo=".urlencode($shReturnTo)."\">"; - $shOutput .= '<input type="submit" value="Edit Note" class="button">'; + $shOutput .= '<input type="submit" value="Edit note" class="button">'; $shOutput .= '</form></td></tr>'; } diff --git a/include/testData.php b/include/testData.php index 23aff30..d2d4b36 100644 --- a/include/testData.php +++ b/include/testData.php @@ -696,10 +696,10 @@ class testData{ if($rowsUsed >= $iDisplayLimit && $bShowAll) { - $sShowButtonText = "Limit to $iDisplayLimit Tests"; + $sShowButtonText = "Limit to $iDisplayLimit tests"; } else { - $sShowButtonText = "Show All Tests"; + $sShowButtonText = "Show all tests"; echo '<input type="hidden" name="bShowAll" value="true">'; } diff --git a/include/version.php b/include/version.php index 4e3ecd2..5afa0b5 100644 --- a/include/version.php +++ b/include/version.php @@ -1111,7 +1111,7 @@ class version { echo "<div class='info_container'>\n"; echo "\t<div class='title_class'>\n"; - echo "\t\tSelected test results <small><small>(selected in 'Test Results' table below)</small></small>\n"; + echo "\t\tSelected Test Results <small><small>(selected in 'Test Results' table below)</small></small>\n"; echo "\t</div>\n"; echo "<div class='info_contents'>\n";

1 0

Alexander Nicolaysen Sørnes : version: Use consistent capitalizatin of button texxts
by Alexander Nicolaysen Sørnes 29 Jul '09

29 Jul '09

Module: appdb Branch: master Commit: 6c1f52c7644699fc6c16570f1901f4fcfcbefbd9 URL: http://source.winehq.org/git/appdb.git/?a=commit;h=6c1f52c7644699fc6c16570f… Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Date: Wed Jul 29 21:10:37 2009 +0200 version: Use consistent capitalizatin of button texxts --- include/version.php | 20 ++++++++++---------- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/include/version.php b/include/version.php index f54eeb2..4e3ecd2 100644 --- a/include/version.php +++ b/include/version.php @@ -958,8 +958,8 @@ class version { echo "</form>\n"; } else /* nope */ { - echo '<form method="post" name="sMessage" action="objectManager.php?sClass=maintainer&sAction=add&iVersionId='.$this->iVersionId.'&sTitle='.urlencode("Be a Maintainer of ".version::fullName($this->iVersionId)).'&sReturnTo='.urlencode($this->objectMakeUrl()).'">'."\n"; - echo "\t".'<input type="submit" value="Be a Maintainer of This Version" class="button" title="Click here to know more about maintainers.">'."\n"; + echo '<form method="post" name="sMessage" action="objectManager.php?sClass=maintainer&sAction=add&iVersionId='.$this->iVersionId.'&sTitle='.urlencode("Be a maintainer of ".version::fullName($this->iVersionId)).'&sReturnTo='.urlencode($this->objectMakeUrl()).'">'."\n"; + echo "\t".'<input type="submit" value="Be a maintainer of this version" class="button" title="Click here to know more about maintainers.">'."\n"; echo "\t"."<input type=hidden name=\"iAppId\" value=\"".$oApp->iAppId."\">\n"; echo "\t"."<input type=hidden name=\"iVersionId\" value=\"".$this->iVersionId."\">\n"; echo "</form>\n"; @@ -977,7 +977,7 @@ class version { echo "\t<input type=\"hidden\" name=\"sClass\" value=\"monitor\" >\n"; echo "\t<input type=\"hidden\" name=\"sReturnTo\" value=\"". $this->objectMakeUrl()."\" >\n"; - echo "\t".'<input type=submit value="Monitor Changes" class="button">'."\n"; + echo "\t".'<input type=submit value="Monitor changes" class="button">'."\n"; echo "</form>\n"; } } @@ -1000,20 +1000,20 @@ class version { echo '<form method="post" name="sMessage" action="admin/editAppVersion.php">'."\n"; echo "\t".'<input type="hidden" name="iAppId" value="'.$oApp->iAppId.'">'."\n"; echo "\t".'<input type="hidden" name="iVersionId" value="'.$this->iVersionId.'">'."\n"; - echo "\t".'<input type=submit value="Edit Version" class="button">'."\n"; + echo "\t".'<input type=submit value="Edit version" class="button">'."\n"; echo '</form>'."\n"; $url = BASE."objectManager.php?sClass=version&sAction=delete&bQueued=false&iId=".$this->iVersionId; echo "<form method=\"post\" name=\"sDelete\" action=\"javascript:self.location = '".$url."'\">\n"; - echo "\t".'<input type=submit value="Delete Version" class="button">'."\n"; + echo "\t".'<input type=submit value="Delete version" class="button">'."\n"; echo '</form>'."\n"; echo $shAdd.'" />'; - echo "\t".'<input type="submit" value="Add Note" class="button">'."\n"; + echo "\t".'<input type="submit" value="Add note" class="button">'."\n"; echo '</form>'."\n"; echo $shAdd.'&sNoteTitle=HOWTO" />'; - echo "\t".'<input type=submit value="Add How To" class="button">'."\n"; + echo "\t".'<input type=submit value="Add how-to" class="button">'."\n"; echo '</form>'."\n"; echo $shAdd.'&sNoteTitle=WARNING" />'; - echo "\t".'<input type=submit value="Add Warning" class="button">'."\n"; + echo "\t".'<input type=submit value="Add warning" class="button">'."\n"; echo '</form>'; echo "</td></tr>"; } @@ -1031,7 +1031,7 @@ class version { echo "\t<input type=\"hidden\" name=\"sClass\" value=\"monitor\">\n"; echo "\t<input type=\"hidden\" name=\"sReturnTo\" value=\"". $this->objectMakeUrl()."\">\n"; - echo '<input type=submit value="Stop Monitoring Version" class="button" >'."\n"; + echo '<input type=submit value="Stop monitoring version" class="button" >'."\n"; echo "</form>\n"; echo "</td></tr>\n"; } @@ -1158,7 +1158,7 @@ class version { 'sClass=testData_queue&sAction=add&iVersionId='.$this->iVersionId. '&sTitle=Add+Test+Data&sReturnTo='. urlencode($this->objectMakeUrl()).'>'."\n"; - echo "\t".'<input type=submit value="Add Test Data" class="button" >'."\n"; + echo "\t".'<input type=submit value="Add test data" class="button" >'."\n"; echo '</form>'."\n"; } else {

1 0