October 2010 - Wine-commits

Hans Leidekker : msi/tests: Determine Wow64 mode just once.
by Alexandre Julliard 11 Oct '10

11 Oct '10

Module: wine Branch: master Commit: 3d33fb93cc8508b494604a13dd77a8ffa30025d3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=3d33fb93cc8508b494604a13d… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Mon Oct 11 12:09:11 2010 +0200 msi/tests: Determine Wow64 mode just once. --- dlls/msi/tests/automation.c | 9 ++++- dlls/msi/tests/install.c | 74 ++++++++++++++++++------------------------- dlls/msi/tests/msi.c | 58 +++++++++++++--------------------- dlls/msi/tests/package.c | 18 +++++----- dlls/msi/tests/source.c | 23 ++++++------- 5 files changed, 80 insertions(+), 102 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=3d33fb93cc8508b494604…

1 0

Hans Leidekker : msi/tests: Use a different product code in the automation tests.
by Alexandre Julliard 11 Oct '10

11 Oct '10

Module: wine Branch: master Commit: b719338433d737569c56eb02e5c0e315eb32d9c8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=b719338433d737569c56eb02e… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Mon Oct 11 12:09:24 2010 +0200 msi/tests: Use a different product code in the automation tests. --- dlls/msi/tests/automation.c | 16 ++++++++-------- 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/dlls/msi/tests/automation.c b/dlls/msi/tests/automation.c index 3100906..0ad51ea 100644 --- a/dlls/msi/tests/automation.c +++ b/dlls/msi/tests/automation.c @@ -42,7 +42,7 @@ DEFINE_GUID(GUID_NULL,0,0,0,0,0,0,0,0,0,0,0); static const char *msifile = "winetest-automation.msi"; static const WCHAR szMsifile[] = {'w','i','n','e','t','e','s','t','-','a','u','t','o','m','a','t','i','o','n','.','m','s','i',0}; static const WCHAR szMSITEST[] = { 'M','S','I','T','E','S','T',0 }; -static const WCHAR szProductCode[] = { '{','F','1','C','3','A','F','5','0','-','8','B','5','6','-','4','A','6','9','-','A','0','0','C','-','0','0','7','7','3','F','E','4','2','F','3','0','}',0 }; +static const WCHAR szProductCode[] = { '{','8','3','7','4','5','0','f','a','-','a','3','9','b','-','4','b','c','8','-','b','3','2','1','-','0','8','b','3','9','3','f','7','8','4','b','3','}',0 }; static const WCHAR szUpgradeCode[] = { '{','C','E','0','6','7','E','8','D','-','2','E','1','A','-','4','3','6','7','-','B','7','3','4','-','4','E','B','2','B','D','A','D','6','5','6','5','}',0 }; static const WCHAR szProductInfoException[] = { 'P','r','o','d','u','c','t','I','n','f','o',',','P','r','o','d','u','c','t',',','A','t','t','r','i','b','u','t','e',0 }; static const WCHAR WINE_INSTALLPROPERTY_PACKAGENAMEW[] = {'P','a','c','k','a','g','e','N','a','m','e',0}; @@ -141,7 +141,7 @@ static const CHAR property_dat[] = "Property\tValue\n" "InstallMode\tTypical\n" "Manufacturer\tWine\n" "PIDTemplate\t12345<###-%%%%%%%>@@@@@\n" - "ProductCode\t{F1C3AF50-8B56-4A69-A00C-00773FE42F30}\n" + "ProductCode\t{837450fa-a39b-4bc8-b321-08b393f784b3}\n" "ProductID\tnone\n" "ProductLanguage\t1033\n" "ProductName\tMSITEST\n" @@ -2548,7 +2548,7 @@ static void test_Installer_InstallProduct(void) /* Remove registry keys written by RegisterProduct standard action */ res = delete_key_portable(HKEY_LOCAL_MACHINE, - "SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\{F1C3AF50-8B56-4A69-A00C-00773FE42F30}", + "SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\{837450fa-a39b-4bc8-b321-08b393f784b3}", KEY_WOW64_32KEY); ok(res == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", res); @@ -2557,32 +2557,32 @@ static void test_Installer_InstallProduct(void) ok(res == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", res); res = find_registry_key(HKEY_LOCAL_MACHINE, - "SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Installer\\UserData", "05FA3C1F65B896A40AC00077F34EF203", access, &hkey); + "SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Installer\\UserData", "af054738b93a8cb43b12803b397f483b", access, &hkey); ok(res == ERROR_SUCCESS || broken(res == ERROR_FILE_NOT_FOUND), /* win9x */ "Expected ERROR_SUCCESS, got %d\n", res); if (res == ERROR_SUCCESS) { - res = delete_registry_key(hkey, "05FA3C1F65B896A40AC00077F34EF203", access); + res = delete_registry_key(hkey, "af054738b93a8cb43b12803b397f483b", access); ok(res == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", res); RegCloseKey(hkey); res = delete_key_portable(HKEY_LOCAL_MACHINE, - "SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Installer\\Products\\05FA3C1F65B896A40AC00077F34EF203", access); + "SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Installer\\Products\\af054738b93a8cb43b12803b397f483b", access); ok(res == ERROR_FILE_NOT_FOUND, "Expected ERROR_FILE_NOT_FOUND, got %d\n", res); } else { /* win9x defaults to a per-machine install. */ delete_key_portable(HKEY_LOCAL_MACHINE, - "SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Installer\\Products\\05FA3C1F65B896A40AC00077F34EF203", access); + "SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Installer\\Products\\af054738b93a8cb43b12803b397f483b", access); } /* Remove registry keys written by PublishProduct standard action */ res = RegOpenKey(HKEY_CURRENT_USER, "SOFTWARE\\Microsoft\\Installer", &hkey); ok(res == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", res); - res = delete_registry_key(hkey, "Products\\05FA3C1F65B896A40AC00077F34EF203", KEY_ALL_ACCESS); + res = delete_registry_key(hkey, "Products\\af054738b93a8cb43b12803b397f483b", KEY_ALL_ACCESS); ok(res == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", res); res = RegDeleteKeyA(hkey, "UpgradeCodes\\D8E760ECA1E276347B43E42BDBDA5656");

1 0

Hans Leidekker : msi: Allocate 3 bytes instead of 2 for in-memory string references.
by Alexandre Julliard 11 Oct '10

11 Oct '10

Module: wine Branch: master Commit: cf6e820106456307226849964e41efde5463c0a1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=cf6e820106456307226849964… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Mon Oct 11 12:09:45 2010 +0200 msi: Allocate 3 bytes instead of 2 for in-memory string references. Fixes an installer that stores string references as 2 byte integers and grows the number of strings beyond the limit of 64k during installation. --- dlls/msi/msipriv.h | 3 +- dlls/msi/string.c | 17 ++++-- dlls/msi/table.c | 178 ++++++++++++++++++++++++++++++++------------------- dlls/msi/tests/db.c | 18 ++---- 4 files changed, 132 insertions(+), 84 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=cf6e82010645630722684…

1 0

Hans Leidekker : msi/tests: Fix some test failures on 64-bit.
by Alexandre Julliard 11 Oct '10

11 Oct '10

Module: wine Branch: master Commit: 5709fab04ccbb4bb587c43cde0ee20da6cdcfbf4 URL: http://source.winehq.org/git/wine.git/?a=commit;h=5709fab04ccbb4bb587c43cde… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Mon Oct 11 12:09:54 2010 +0200 msi/tests: Fix some test failures on 64-bit. --- dlls/msi/tests/install.c | 21 ++++++++++++++------- 1 files changed, 14 insertions(+), 7 deletions(-) diff --git a/dlls/msi/tests/install.c b/dlls/msi/tests/install.c index 8875bb8..07a2dcf 100644 --- a/dlls/msi/tests/install.c +++ b/dlls/msi/tests/install.c @@ -7537,7 +7537,6 @@ static void test_writeregistryvalues(void) HKEY hkey; DWORD type, size; CHAR path[MAX_PATH]; - REGSAM access = KEY_ALL_ACCESS; if (is_process_limited()) { @@ -7550,9 +7549,6 @@ static void test_writeregistryvalues(void) create_database(msifile, wrv_tables, sizeof(wrv_tables) / sizeof(msi_table)); - if (is_wow64) - access |= KEY_WOW64_64KEY; - MsiSetInternalUI(INSTALLUILEVEL_NONE, NULL); r = MsiInstallProductA(msifile, NULL); @@ -7565,7 +7561,10 @@ static void test_writeregistryvalues(void) ok(delete_pf("msitest\\augustus", TRUE), "File installed\n"); ok(delete_pf("msitest", FALSE), "File installed\n"); - res = RegOpenKeyA(HKEY_LOCAL_MACHINE, "SOFTWARE\\Wine\\msitest", &hkey); + if (is_64bit && !is_wow64) + res = RegOpenKeyExA(HKEY_LOCAL_MACHINE, "SOFTWARE\\Wow6432Node\\Wine\\msitest", 0, KEY_ALL_ACCESS, &hkey); + else + res = RegOpenKeyExA(HKEY_LOCAL_MACHINE, "SOFTWARE\\Wine\\msitest", 0, KEY_ALL_ACCESS, &hkey); ok(res == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", res); size = MAX_PATH; @@ -7577,6 +7576,8 @@ static void test_writeregistryvalues(void) ok(size == 15, "Expected 15, got %d\n", size); ok(type == REG_MULTI_SZ, "Expected REG_MULTI_SZ, got %d\n", type); + RegDeleteValueA(hkey, "Value"); + RegCloseKey(hkey); RegDeleteKeyA(HKEY_CURRENT_USER, "SOFTWARE\\Wine\\msitest"); error: @@ -10485,7 +10486,10 @@ static void test_register_class_info(void) } ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %u\n", r); - res = RegOpenKeyA(HKEY_CLASSES_ROOT, "CLSID\\{110913E7-86D1-4BF3-9922-BA103FCDDDFA}", &hkey); + if (is_64bit && !is_wow64) + res = RegOpenKeyA(HKEY_CLASSES_ROOT, "Wow6432Node\\CLSID\\{110913E7-86D1-4BF3-9922-BA103FCDDDFA}", &hkey); + else + res = RegOpenKeyA(HKEY_CLASSES_ROOT, "CLSID\\{110913E7-86D1-4BF3-9922-BA103FCDDDFA}", &hkey); ok(res == ERROR_SUCCESS, "key not created\n"); RegCloseKey(hkey); @@ -10500,7 +10504,10 @@ static void test_register_class_info(void) r = MsiInstallProductA(msifile, "REMOVE=ALL"); ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %u\n", r); - res = RegOpenKeyA(HKEY_CLASSES_ROOT, "CLSID\\{110913E7-86D1-4BF3-9922-BA103FCDDDFA}", &hkey); + if (is_64bit && !is_wow64) + res = RegOpenKeyA(HKEY_CLASSES_ROOT, "Wow6432Node\\CLSID\\{110913E7-86D1-4BF3-9922-BA103FCDDDFA}", &hkey); + else + res = RegOpenKeyA(HKEY_CLASSES_ROOT, "CLSID\\{110913E7-86D1-4BF3-9922-BA103FCDDDFA}", &hkey); ok(res == ERROR_FILE_NOT_FOUND, "key not removed\n"); res = RegOpenKeyA(HKEY_CLASSES_ROOT, "FileType\\{110913E7-86D1-4BF3-9922-BA103FCDDDFA}", &hkey);

1 0

Eric Pouech : dbghelp: Ensure the stab_nlist structure is usable on 64bit systems.
by Alexandre Julliard 11 Oct '10

11 Oct '10

Module: wine Branch: master Commit: fac5abc551c58f7c16a5caea801eafe26a404099 URL: http://source.winehq.org/git/wine.git/?a=commit;h=fac5abc551c58f7c16a5caea8… Author: Eric Pouech <eric.pouech(a)orange.fr> Date: Sat Oct 9 08:51:41 2010 +0200 dbghelp: Ensure the stab_nlist structure is usable on 64bit systems. --- dlls/dbghelp/stabs.c | 21 ++++++++------------- 1 files changed, 8 insertions(+), 13 deletions(-) diff --git a/dlls/dbghelp/stabs.c b/dlls/dbghelp/stabs.c index 837e213..8ef177c 100644 --- a/dlls/dbghelp/stabs.c +++ b/dlls/dbghelp/stabs.c @@ -110,16 +110,11 @@ WINE_DEFAULT_DEBUG_CHANNEL(dbghelp_stabs); struct stab_nlist { - union - { - char* n_name; - struct stab_nlist* n_next; - long n_strx; - } n_un; + unsigned n_strx; unsigned char n_type; char n_other; short n_desc; - unsigned long n_value; + unsigned n_value; }; static void stab_strcpy(char* dest, int sz, const char* source) @@ -1315,7 +1310,7 @@ BOOL stabs_parse(struct module* module, unsigned long load_offset, stabbuff[0] = '\0'; for (i = 0; i < nstab; i++, stab_ptr++) { - ptr = strs + stab_ptr->n_un.n_strx; + ptr = strs + stab_ptr->n_strx; if ((ptr > strs_end) || (ptr + strlen(ptr) > strs_end)) { WARN("Bad stabs string %p\n", ptr); @@ -1421,7 +1416,7 @@ BOOL stabs_parse(struct module* module, unsigned long load_offset, loc.reg = 0; /* FIXME */ loc.offset = stab_ptr->n_value; symt_add_func_local(module, curr_func, - (long)stab_ptr->n_value >= 0 ? DataIsParam : DataIsLocal, + (int)stab_ptr->n_value >= 0 ? DataIsParam : DataIsLocal, &loc, NULL, param_type, symname); symt_add_function_signature_parameter(module, (struct symt_function_signature*)curr_func->type, @@ -1471,7 +1466,7 @@ BOOL stabs_parse(struct module* module, unsigned long load_offset, case 35: case 36: loc.reg = CV_REG_MM0 + stab_ptr->n_value - 29; break; default: - FIXME("Unknown register value (%lu)\n", stab_ptr->n_value); + FIXME("Unknown register value (%u)\n", stab_ptr->n_value); loc.reg = CV_REG_NONE; break; } @@ -1617,7 +1612,7 @@ BOOL stabs_parse(struct module* module, unsigned long load_offset, case N_EXCL: if (stabs_add_include(stabs_find_include(ptr, stab_ptr->n_value)) < 0) { - ERR("Excluded header not found (%s,%ld)\n", ptr, stab_ptr->n_value); + ERR("Excluded header not found (%s,%d)\n", ptr, stab_ptr->n_value); module_reset_debug_info(module); ret = FALSE; goto done; @@ -1663,8 +1658,8 @@ BOOL stabs_parse(struct module* module, unsigned long load_offset, break; } stabbuff[0] = '\0'; - TRACE("0x%02x %lx %s\n", - stab_ptr->n_type, stab_ptr->n_value, debugstr_a(strs + stab_ptr->n_un.n_strx)); + TRACE("0x%02x %x %s\n", + stab_ptr->n_type, stab_ptr->n_value, debugstr_a(strs + stab_ptr->n_strx)); } module->module.SymType = SymDia; module->module.CVSig = 'S' | ('T' << 8) | ('A' << 16) | ('B' << 24);

1 0

Eric Pouech : dbghelp: Proper support and definition for S_REGREL_V3.
by Alexandre Julliard 11 Oct '10

11 Oct '10

Module: wine Branch: master Commit: 8d981b87f18cb53de2639d0ca32e544d6c09d4fd URL: http://source.winehq.org/git/wine.git/?a=commit;h=8d981b87f18cb53de2639d0ca… Author: Eric Pouech <eric.pouech(a)orange.fr> Date: Sat Oct 9 08:51:47 2010 +0200 dbghelp: Proper support and definition for S_REGREL_V3. --- dlls/dbghelp/msc.c | 14 +++++++------- include/wine/mscvpdb.h | 6 +++--- tools/winedump/msc.c | 8 ++++---- 3 files changed, 14 insertions(+), 14 deletions(-) diff --git a/dlls/dbghelp/msc.c b/dlls/dbghelp/msc.c index baab45d..90e832c 100644 --- a/dlls/dbghelp/msc.c +++ b/dlls/dbghelp/msc.c @@ -1669,16 +1669,16 @@ static int codeview_snarf(const struct msc_debug_info* msc_dbg, const BYTE* root codeview_get_type(sym->stack_v3.symtype, FALSE), sym->stack_v3.name); break; - case S_BPREL_XXXX_V3: + case S_REGREL_V3: loc.kind = loc_regrel; - loc.reg = 0; /* FIXME */ - loc.offset = sym->stack_xxxx_v3.offset; - WARN("Supposed stack variable %s (%d)\n", sym->stack_xxxx_v3.name, sym->stack_xxxx_v3.unknown); + loc.reg = sym->regrel_v3.reg; + loc.offset = sym->regrel_v3.offset; symt_add_func_local(msc_dbg->module, curr_func, - sym->stack_xxxx_v3.offset > 0 ? DataIsParam : DataIsLocal, + /* FIXME this is wrong !!! */ + sym->regrel_v3.offset > 0 ? DataIsParam : DataIsLocal, &loc, block, - codeview_get_type(sym->stack_xxxx_v3.symtype, FALSE), - sym->stack_xxxx_v3.name); + codeview_get_type(sym->regrel_v3.symtype, FALSE), + sym->regrel_v3.name); break; case S_REGISTER_V1: diff --git a/include/wine/mscvpdb.h b/include/wine/mscvpdb.h index c9bdb4f..2d5b9c9 100644 --- a/include/wine/mscvpdb.h +++ b/include/wine/mscvpdb.h @@ -1380,9 +1380,9 @@ union codeview_symbol short int id; /* Always S_BPREL_V3 */ int offset; /* Stack offset relative to BP */ unsigned int symtype; - unsigned short unknown; + unsigned short reg; char name[1]; - } stack_xxxx_v3; + } regrel_v3; struct { @@ -1646,7 +1646,7 @@ union codeview_symbol #define S_PUB_V3 0x110E #define S_LPROC_V3 0x110F #define S_GPROC_V3 0x1110 -#define S_BPREL_XXXX_V3 0x1111 /* not really understood, but looks like bprel... */ +#define S_REGREL_V3 0x1111 #define S_MSTOOL_V3 0x1116 /* compiler command line options and build information */ #define S_PUB_FUNC1_V3 0x1125 /* didn't get the difference between the two */ #define S_PUB_FUNC2_V3 0x1127 diff --git a/tools/winedump/msc.c b/tools/winedump/msc.c index ccd4664..c917309 100644 --- a/tools/winedump/msc.c +++ b/tools/winedump/msc.c @@ -1059,10 +1059,10 @@ int codeview_dump_symbols(const void* root, unsigned long size) sym->stack_v3.symtype, curr_func); break; - case S_BPREL_XXXX_V3: - printf("\tS-BP-relative XXXX V3: '%s' @%d type:%x unkn:%x (in %s)\n", - sym->stack_xxxx_v3.name, sym->stack_xxxx_v3.offset, - sym->stack_xxxx_v3.symtype, sym->stack_xxxx_v3.unknown, curr_func); + case S_REGREL_V3: + printf("\tS-Reg-relative V3: '%s' @%d type:%x reg:%x (in %s)\n", + sym->regrel_v3.name, sym->regrel_v3.offset, + sym->regrel_v3.symtype, sym->regrel_v3.reg, curr_func); break; case S_REGISTER_V1:

1 0

Louis Lenders : user32/tests: Test FindWindowEx for empty window title.
by Alexandre Julliard 11 Oct '10

11 Oct '10

Module: wine Branch: master Commit: 62b9df9031b08b17fb0e8fe4569da7137b4d4c1b URL: http://source.winehq.org/git/wine.git/?a=commit;h=62b9df9031b08b17fb0e8fe45… Author: Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> Date: Sun Oct 10 21:07:53 2010 +0200 user32/tests: Test FindWindowEx for empty window title. --- dlls/user32/tests/win.c | 20 ++++++++++++++++++++ 1 files changed, 20 insertions(+), 0 deletions(-) diff --git a/dlls/user32/tests/win.c b/dlls/user32/tests/win.c index 50c5be5..12f2e1c 100644 --- a/dlls/user32/tests/win.c +++ b/dlls/user32/tests/win.c @@ -6237,6 +6237,25 @@ static void test_rtl_layout(void) DestroyWindow( parent ); } +static void test_FindWindowEx(void) +{ + HWND found; + CHAR title[1]; + + title[0] = 0; + + found = FindWindowExA( 0, 0, "MainWindowClass", title ); + ok( found == NULL, "expected a NULL hwnd\n" ); + found = FindWindowExA( 0, 0, "MainWindowClass", NULL ); + ok( found != NULL, "found is NULL, expected a valid hwnd\n" ); + /* test behaviour with a window title that is an empty character */ + found = FindWindowExA( 0, 0, "Shell_TrayWnd", title ); +todo_wine + ok( found != NULL, "found is NULL, expected a valid hwnd\n" ); + found = FindWindowExA( 0, 0, "Shell_TrayWnd", NULL ); + ok( found != NULL, "found is NULL, expected a valid hwnd\n" ); +} + START_TEST(win) { HMODULE user32 = GetModuleHandleA( "user32.dll" ); @@ -6332,6 +6351,7 @@ START_TEST(win) test_Expose(); test_layered_window(); + test_FindWindowEx(); test_SetForegroundWindow(hwndMain); test_shell_window(); test_handles( hwndMain );

1 0

Louis Lenders : advapi32: Add stub for QueryTraceW.
by Alexandre Julliard 11 Oct '10

11 Oct '10

Module: wine Branch: master Commit: 2ecb586005c0f57fce6948d99b0e1fbb01ed231f URL: http://source.winehq.org/git/wine.git/?a=commit;h=2ecb586005c0f57fce6948d99… Author: Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> Date: Sun Oct 10 21:22:29 2010 +0200 advapi32: Add stub for QueryTraceW. --- dlls/advapi32/advapi32.spec | 2 +- dlls/advapi32/eventlog.c | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletions(-) diff --git a/dlls/advapi32/advapi32.spec b/dlls/advapi32/advapi32.spec index 7521294..0e27e74 100644 --- a/dlls/advapi32/advapi32.spec +++ b/dlls/advapi32/advapi32.spec @@ -459,7 +459,7 @@ @ stdcall QueryServiceStatus(long ptr) @ stdcall QueryServiceStatusEx (long long ptr long ptr) # @ stub QueryTraceA -# @ stub QueryTraceW +@ stdcall QueryTraceW(int64 wstr ptr) # @ stub QueryUsersOnEncryptedFile @ stdcall QueryWindows31FilesMigration(long) # @ stub ReadEncryptedFileRaw diff --git a/dlls/advapi32/eventlog.c b/dlls/advapi32/eventlog.c index d048eed..26be42e 100644 --- a/dlls/advapi32/eventlog.c +++ b/dlls/advapi32/eventlog.c @@ -817,3 +817,12 @@ ULONG WINAPI EventRegister( LPCGUID provider, PENABLECALLBACK callback, PVOID co FIXME("%s, %p, %p, %p\n", debugstr_guid(provider), callback, context, handle); return ERROR_CALL_NOT_IMPLEMENTED; } + +/****************************************************************************** + * QueryTraceW [ADVAPI32.@] + */ +ULONG WINAPI QueryTraceW( TRACEHANDLE handle, LPCWSTR sessionname, PEVENT_TRACE_PROPERTIES properties ) +{ + FIXME("%s %s %p: stub\n", wine_dbgstr_longlong(handle), debugstr_w(sessionname), properties); + return ERROR_CALL_NOT_IMPLEMENTED; +}

1 0

James McKenzie : gdi32: Correct typo in comment.
by Alexandre Julliard 11 Oct '10

11 Oct '10

Module: wine Branch: master Commit: c3dfc7b834b0167415455ecebf76919a8476221b URL: http://source.winehq.org/git/wine.git/?a=commit;h=c3dfc7b834b0167415455eceb… Author: James McKenzie <jjmckenzie51(a)earthlink.net> Date: Sun Oct 10 18:44:36 2010 -0700 gdi32: Correct typo in comment. --- dlls/gdi32/font.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/gdi32/font.c b/dlls/gdi32/font.c index 133681c..b247722 100644 --- a/dlls/gdi32/font.c +++ b/dlls/gdi32/font.c @@ -318,7 +318,7 @@ HFONT WINAPI CreateFontIndirectExA( const ENUMLOGFONTEXDVA *penumexA ) } /*********************************************************************** - * CreateFontIndirectExA (GDI32.@) + * CreateFontIndirectExW (GDI32.@) */ HFONT WINAPI CreateFontIndirectExW( const ENUMLOGFONTEXDVW *penumex ) {

1 0

Eric Pouech : dbghelp: Allow loading PE module with 64bit addresses.
by Alexandre Julliard 11 Oct '10

11 Oct '10

Module: wine Branch: master Commit: 1e141eee4fa68dc0c3ef934f03878f72d202654a URL: http://source.winehq.org/git/wine.git/?a=commit;h=1e141eee4fa68dc0c3ef934f0… Author: Eric Pouech <eric.pouech(a)orange.fr> Date: Sat Oct 9 08:50:50 2010 +0200 dbghelp: Allow loading PE module with 64bit addresses. --- dlls/dbghelp/dbghelp_private.h | 2 +- dlls/dbghelp/pe_module.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/dbghelp/dbghelp_private.h b/dlls/dbghelp/dbghelp_private.h index 531a740..aec5bdd 100644 --- a/dlls/dbghelp/dbghelp_private.h +++ b/dlls/dbghelp/dbghelp_private.h @@ -578,7 +578,7 @@ extern BOOL path_find_symbol_file(const struct process* pcs, PCSTR full_ extern BOOL pe_load_nt_header(HANDLE hProc, DWORD64 base, IMAGE_NT_HEADERS* nth); extern struct module* pe_load_native_module(struct process* pcs, const WCHAR* name, - HANDLE hFile, DWORD base, DWORD size); + HANDLE hFile, DWORD64 base, DWORD size); extern struct module* pe_load_builtin_module(struct process* pcs, const WCHAR* name, DWORD64 base, DWORD64 size); diff --git a/dlls/dbghelp/pe_module.c b/dlls/dbghelp/pe_module.c index 1a41f94..2d8d16c 100644 --- a/dlls/dbghelp/pe_module.c +++ b/dlls/dbghelp/pe_module.c @@ -733,7 +733,7 @@ BOOL pe_load_debug_info(const struct process* pcs, struct module* module) * */ struct module* pe_load_native_module(struct process* pcs, const WCHAR* name, - HANDLE hFile, DWORD base, DWORD size) + HANDLE hFile, DWORD64 base, DWORD size) { struct module* module = NULL; BOOL opened = FALSE;

1 0