November 2010 - Wine-commits

Vincas Miliūnas : msvcp90: Added basic_string<char>:: swap implementation.
by Alexandre Julliard 17 Nov '10

17 Nov '10

Module: wine Branch: master Commit: 676d0d41f5662538478fa80312dde49bf923e3ef URL: http://source.winehq.org/git/wine.git/?a=commit;h=676d0d41f5662538478fa8031… Author: Vincas Miliūnas <vincas.miliunas(a)gmail.com> Date: Tue Nov 16 20:58:15 2010 +0200 msvcp90: Added basic_string<char>::swap implementation. --- dlls/msvcp80/msvcp80.spec | 4 ++-- dlls/msvcp90/msvcp90.spec | 4 ++-- dlls/msvcp90/string.c | 22 ++++++++++++++++++++++ 3 files changed, 26 insertions(+), 4 deletions(-) diff --git a/dlls/msvcp80/msvcp80.spec b/dlls/msvcp80/msvcp80.spec index f05b53d..ec1458f 100644 --- a/dlls/msvcp80/msvcp80.spec +++ b/dlls/msvcp80/msvcp80.spec @@ -5477,8 +5477,8 @@ @ stub -arch=win64 ?sungetc@?$basic_streambuf(a)GU?$char_traits(a)G@std@@@std@@QEAAGXZ @ stub -arch=win32 ?sungetc@?$basic_streambuf(a)_WU?$char_traits(a)_W@std@@@std@@QAEGXZ @ stub -arch=win64 ?sungetc@?$basic_streambuf(a)_WU?$char_traits(a)_W@std@@@std@@QEAAGXZ -@ stub -arch=win32 ?swap@?$basic_string(a)DU?$char_traits(a)D@std@@V?$allocator(a)D@2@@std@@QAEXAAV12@@Z -@ stub -arch=win64 ?swap@?$basic_string(a)DU?$char_traits(a)D@std@@V?$allocator(a)D@2@@std@@QEAAXAEAV12@@Z +@ thiscall -arch=win32 ?swap@?$basic_string(a)DU?$char_traits(a)D@std@@V?$allocator(a)D@2@@std@@QAEXAAV12@@Z(ptr ptr) msvcp90.?swap@?$basic_string(a)DU?$char_traits(a)D@std@@V?$allocator(a)D@2@@std@@QAEXAAV12@@Z +@ cdecl -arch=win64 ?swap@?$basic_string(a)DU?$char_traits(a)D@std@@V?$allocator(a)D@2@@std@@QEAAXAEAV12@@Z (ptr ptr) msvcp90.?swap@?$basic_string(a)DU?$char_traits(a)D@std@@V?$allocator(a)D@2@@std@@QEAAXAEAV12@@Z @ stub -arch=win32 ?swap@?$basic_string(a)GU?$char_traits(a)G@std@@V?$allocator(a)G@2@@std@@QAEXAAV12@@Z @ stub -arch=win64 ?swap@?$basic_string(a)GU?$char_traits(a)G@std@@V?$allocator(a)G@2@@std@@QEAAXAEAV12@@Z @ stub -arch=win32 ?swap@?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QAEXAAV12@@Z diff --git a/dlls/msvcp90/msvcp90.spec b/dlls/msvcp90/msvcp90.spec index 9ed37ec..2520ab3 100644 --- a/dlls/msvcp90/msvcp90.spec +++ b/dlls/msvcp90/msvcp90.spec @@ -5508,8 +5508,8 @@ @ stub -arch=win64 ?sungetc@?$basic_streambuf(a)GU?$char_traits(a)G@std@@@std@@QEAAGXZ @ stub -arch=win32 ?sungetc@?$basic_streambuf(a)_WU?$char_traits(a)_W@std@@@std@@QAEGXZ @ stub -arch=win64 ?sungetc@?$basic_streambuf(a)_WU?$char_traits(a)_W@std@@@std@@QEAAGXZ -@ stub -arch=win32 ?swap@?$basic_string(a)DU?$char_traits(a)D@std@@V?$allocator(a)D@2@@std@@QAEXAAV12@@Z -@ stub -arch=win64 ?swap@?$basic_string(a)DU?$char_traits(a)D@std@@V?$allocator(a)D@2@@std@@QEAAXAEAV12@@Z +@ thiscall -arch=win32 ?swap@?$basic_string(a)DU?$char_traits(a)D@std@@V?$allocator(a)D@2@@std@@QAEXAAV12@@Z(ptr ptr) MSVCP_basic_string_char_swap +@ cdecl -arch=win64 ?swap@?$basic_string(a)DU?$char_traits(a)D@std@@V?$allocator(a)D@2@@std@@QEAAXAEAV12@@Z(ptr ptr) MSVCP_basic_string_char_swap @ stub -arch=win32 ?swap@?$basic_string(a)GU?$char_traits(a)G@std@@V?$allocator(a)G@2@@std@@QAEXAAV12@@Z @ stub -arch=win64 ?swap@?$basic_string(a)GU?$char_traits(a)G@std@@V?$allocator(a)G@2@@std@@QEAAXAEAV12@@Z @ stub -arch=win32 ?swap@?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QAEXAAV12@@Z diff --git a/dlls/msvcp90/string.c b/dlls/msvcp90/string.c index cc4ff1b..68eb921 100644 --- a/dlls/msvcp90/string.c +++ b/dlls/msvcp90/string.c @@ -1017,3 +1017,25 @@ size_t __thiscall MSVCP_basic_string_wchar_length(basic_string_wchar *this) TRACE("%p\n", this); return this->size; } + +/* ?swap@?$basic_string(a)DU?$char_traits(a)D@std@@V?$allocator(a)D@2@@std@@QAEXAAV12@@Z */ +/* ?swap@?$basic_string(a)DU?$char_traits(a)D@std@@V?$allocator(a)D@2@@std@@QEAAXAEAV12@@Z */ +DEFINE_THISCALL_WRAPPER(MSVCP_basic_string_char_swap, 8) +void __thiscall MSVCP_basic_string_char_swap(basic_string_char *this, basic_string_char *str) +{ + if(this != str) { + char tmp[sizeof(this->data)]; + const size_t size = this->size; + const size_t res = this->res; + + memcpy(tmp, this->data.buf, sizeof(this->data)); + memcpy(this->data.buf, str->data.buf, sizeof(this->data)); + memcpy(str->data.buf, tmp, sizeof(this->data)); + + this->size = str->size; + this->res = str->res; + + str->size = size; + str->res = res; + } +}

1 0

Vincas Miliūnas : msvcp90/tests: Added basic_string< char>::swap tests.
by Alexandre Julliard 17 Nov '10

17 Nov '10

Module: wine Branch: master Commit: af780d888fe8c22bd70948bbffa80cb1f193c72b URL: http://source.winehq.org/git/wine.git/?a=commit;h=af780d888fe8c22bd70948bbf… Author: Vincas Miliūnas <vincas.miliunas(a)gmail.com> Date: Tue Nov 16 20:58:29 2010 +0200 msvcp90/tests: Added basic_string<char>::swap tests. --- dlls/msvcp90/tests/string.c | 41 +++++++++++++++++++++++++++++++++++++++++ 1 files changed, 41 insertions(+), 0 deletions(-) diff --git a/dlls/msvcp90/tests/string.c b/dlls/msvcp90/tests/string.c index cb0b74b..73bc881 100644 --- a/dlls/msvcp90/tests/string.c +++ b/dlls/msvcp90/tests/string.c @@ -60,6 +60,7 @@ static basic_string_char* (WINAPI *p_basic_string_char_assign_cstr_len)(const ch static const char* (WINAPI *p_basic_string_char_cstr)(void); static const char* (WINAPI *p_basic_string_char_data)(void); static size_t (WINAPI *p_basic_string_char_size)(void); +static void (WINAPI *p_basic_string_char_swap)(basic_string_char*); static basic_string_wchar* (WINAPI *p_basic_string_wchar_ctor)(void); static basic_string_wchar* (WINAPI *p_basic_string_wchar_copy_ctor)(basic_string_wchar*); @@ -80,6 +81,7 @@ static basic_string_char* (__cdecl *p_basic_string_char_assign_cstr_len)(basic_s static const char* (__cdecl *p_basic_string_char_cstr)(basic_string_char*); static const char* (__cdecl *p_basic_string_char_data)(basic_string_char*); static size_t (__cdecl *p_basic_string_char_size)(basic_string_char*); +static void (__cdecl *p_basic_string_char_swap)(basic_string_char*, basic_string_char*); static basic_string_wchar* (__cdecl *p_basic_string_wchar_ctor)(basic_string_wchar*); static basic_string_wchar* (__cdecl *p_basic_string_wchar_copy_ctor)(basic_string_wchar*, basic_string_wchar*); @@ -240,6 +242,8 @@ static BOOL init(void) "?data@?$basic_string(a)DU?$char_traits(a)D@std@@V?$allocator(a)D@2@@std@@QEBAPEBDXZ"); p_basic_string_char_size = (void*)GetProcAddress(msvcp, "?size@?$basic_string(a)DU?$char_traits(a)D@std@@V?$allocator(a)D@2@@std@@QEBA_KXZ"); + p_basic_string_char_swap = (void*)GetProcAddress(msvcp, + "?swap@?$basic_string(a)DU?$char_traits(a)D@std@@V?$allocator(a)D@2@@std@@QEAAXAEAV12@@Z"); p_basic_string_wchar_ctor = (void*)GetProcAddress(msvcp, "??0?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QEAA(a)XZ"); @@ -279,6 +283,8 @@ static BOOL init(void) "?data@?$basic_string(a)DU?$char_traits(a)D@std@@V?$allocator(a)D@2@@std@@QBEPBDXZ"); p_basic_string_char_size = (void*)GetProcAddress(msvcp, "?size@?$basic_string(a)DU?$char_traits(a)D@std@@V?$allocator(a)D@2@@std@@QBEIXZ"); + p_basic_string_char_swap = (void*)GetProcAddress(msvcp, + "?swap@?$basic_string(a)DU?$char_traits(a)D@std@@V?$allocator(a)D@2@@std@@QAEXAAV12@@Z"); p_basic_string_wchar_ctor = (void*)GetProcAddress(msvcp, "??0?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QAE(a)XZ"); @@ -375,6 +381,40 @@ static void test_basic_string_char(void) { call_func1(p_basic_string_char_dtor, &str2); } +static void test_basic_string_char_swap(void) { + basic_string_char str1, str2; + char atmp1[32], atmp2[32]; + + if(!p_basic_string_char_ctor_cstr || !p_basic_string_char_dtor || + !p_basic_string_char_swap || !p_basic_string_char_cstr) { + win_skip("basic_string<char> unavailable\n"); + return; + } + + /* Swap self, local */ + strcpy(atmp1, "qwerty"); + call_func2(p_basic_string_char_ctor_cstr, &str1, atmp1); + call_func2(p_basic_string_char_swap, &str1, &str1); + ok(strcmp(atmp1, (const char *) call_func1(p_basic_string_char_cstr, &str1)) == 0, "Invalid value of str1\n"); + call_func2(p_basic_string_char_swap, &str1, &str1); + ok(strcmp(atmp1, (const char *) call_func1(p_basic_string_char_cstr, &str1)) == 0, "Invalid value of str1\n"); + call_func1(p_basic_string_char_dtor, &str1); + + /* str1 allocated, str2 local */ + strcpy(atmp1, "qwerty12345678901234567890"); + strcpy(atmp2, "asd"); + call_func2(p_basic_string_char_ctor_cstr, &str1, atmp1); + call_func2(p_basic_string_char_ctor_cstr, &str2, atmp2); + call_func2(p_basic_string_char_swap, &str1, &str2); + ok(strcmp(atmp2, (const char *) call_func1(p_basic_string_char_cstr, &str1)) == 0, "Invalid value of str1\n"); + ok(strcmp(atmp1, (const char *) call_func1(p_basic_string_char_cstr, &str2)) == 0, "Invalid value of str2\n"); + call_func2(p_basic_string_char_swap, &str1, &str2); + ok(strcmp(atmp1, (const char *) call_func1(p_basic_string_char_cstr, &str1)) == 0, "Invalid value of str1\n"); + ok(strcmp(atmp2, (const char *) call_func1(p_basic_string_char_cstr, &str2)) == 0, "Invalid value of str2\n"); + call_func1(p_basic_string_char_dtor, &str1); + call_func1(p_basic_string_char_dtor, &str2); +} + static void test_basic_string_wchar(void) { static const wchar_t test[] = { 't','e','s','t',0 }; @@ -456,6 +496,7 @@ START_TEST(string) return; test_basic_string_char(); + test_basic_string_char_swap(); test_basic_string_wchar(); ok(!invalid_parameter, "invalid_parameter_handler was invoked too many times\n");

1 0

Vincas Miliūnas : msvcp90: Added basic_string<wchar_t> ::swap implementation.
by Alexandre Julliard 17 Nov '10

17 Nov '10

Module: wine Branch: master Commit: 96e4e219971143fbfafa6e35d4c918d9c5667db2 URL: http://source.winehq.org/git/wine.git/?a=commit;h=96e4e219971143fbfafa6e35d… Author: Vincas Miliūnas <vincas.miliunas(a)gmail.com> Date: Tue Nov 16 20:58:44 2010 +0200 msvcp90: Added basic_string<wchar_t>::swap implementation. --- dlls/msvcp80/msvcp80.spec | 4 ++-- dlls/msvcp90/msvcp90.spec | 4 ++-- dlls/msvcp90/string.c | 22 ++++++++++++++++++++++ 3 files changed, 26 insertions(+), 4 deletions(-) diff --git a/dlls/msvcp80/msvcp80.spec b/dlls/msvcp80/msvcp80.spec index ec1458f..79dc7e4 100644 --- a/dlls/msvcp80/msvcp80.spec +++ b/dlls/msvcp80/msvcp80.spec @@ -5481,8 +5481,8 @@ @ cdecl -arch=win64 ?swap@?$basic_string(a)DU?$char_traits(a)D@std@@V?$allocator(a)D@2@@std@@QEAAXAEAV12@@Z (ptr ptr) msvcp90.?swap@?$basic_string(a)DU?$char_traits(a)D@std@@V?$allocator(a)D@2@@std@@QEAAXAEAV12@@Z @ stub -arch=win32 ?swap@?$basic_string(a)GU?$char_traits(a)G@std@@V?$allocator(a)G@2@@std@@QAEXAAV12@@Z @ stub -arch=win64 ?swap@?$basic_string(a)GU?$char_traits(a)G@std@@V?$allocator(a)G@2@@std@@QEAAXAEAV12@@Z -@ stub -arch=win32 ?swap@?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QAEXAAV12@@Z -@ stub -arch=win64 ?swap@?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QEAAXAEAV12@@Z +@ thiscall -arch=win32 ?swap@?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QAEXAAV12@@Z(ptr ptr) msvcp90.?swap@?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QAEXAAV12@@Z +@ cdecl -arch=win64 ?swap@?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QEAAXAEAV12@@Z(ptr ptr) msvcp90.?swap@?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QEAAXAEAV12@@Z @ stub -arch=win32 ?sync@?$basic_filebuf(a)DU?$char_traits(a)D@std@@@std@@MAEHXZ @ stub -arch=win64 ?sync@?$basic_filebuf(a)DU?$char_traits(a)D@std@@@std@@MEAAHXZ @ stub -arch=win32 ?sync@?$basic_filebuf(a)GU?$char_traits(a)G@std@@@std@@MAEHXZ diff --git a/dlls/msvcp90/msvcp90.spec b/dlls/msvcp90/msvcp90.spec index 2520ab3..dbbf0b5 100644 --- a/dlls/msvcp90/msvcp90.spec +++ b/dlls/msvcp90/msvcp90.spec @@ -5512,8 +5512,8 @@ @ cdecl -arch=win64 ?swap@?$basic_string(a)DU?$char_traits(a)D@std@@V?$allocator(a)D@2@@std@@QEAAXAEAV12@@Z(ptr ptr) MSVCP_basic_string_char_swap @ stub -arch=win32 ?swap@?$basic_string(a)GU?$char_traits(a)G@std@@V?$allocator(a)G@2@@std@@QAEXAAV12@@Z @ stub -arch=win64 ?swap@?$basic_string(a)GU?$char_traits(a)G@std@@V?$allocator(a)G@2@@std@@QEAAXAEAV12@@Z -@ stub -arch=win32 ?swap@?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QAEXAAV12@@Z -@ stub -arch=win64 ?swap@?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QEAAXAEAV12@@Z +@ thiscall -arch=win32 ?swap@?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QAEXAAV12@@Z(ptr ptr) MSVCP_basic_string_wchar_swap +@ cdecl -arch=win64 ?swap@?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QEAAXAEAV12@@Z(ptr ptr) MSVCP_basic_string_wchar_swap @ stub -arch=win32 ?sync@?$basic_filebuf(a)DU?$char_traits(a)D@std@@@std@@MAEHXZ @ stub -arch=win64 ?sync@?$basic_filebuf(a)DU?$char_traits(a)D@std@@@std@@MEAAHXZ @ stub -arch=win32 ?sync@?$basic_filebuf(a)GU?$char_traits(a)G@std@@@std@@MAEHXZ diff --git a/dlls/msvcp90/string.c b/dlls/msvcp90/string.c index 68eb921..fb51ae4 100644 --- a/dlls/msvcp90/string.c +++ b/dlls/msvcp90/string.c @@ -1039,3 +1039,25 @@ void __thiscall MSVCP_basic_string_char_swap(basic_string_char *this, basic_stri str->res = res; } } + +/* ?swap@?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QAEXAAV12@@Z */ +/* ?swap@?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QEAAXAEAV12@@Z */ +DEFINE_THISCALL_WRAPPER(MSVCP_basic_string_wchar_swap, 8) +void __thiscall MSVCP_basic_string_wchar_swap(basic_string_wchar *this, basic_string_wchar *str) +{ + if(this != str) { + char tmp[sizeof(this->data)]; + const size_t size = this->size; + const size_t res = this->res; + + memcpy(tmp, this->data.buf, sizeof(this->data)); + memcpy(this->data.buf, str->data.buf, sizeof(this->data)); + memcpy(str->data.buf, tmp, sizeof(this->data)); + + this->size = str->size; + this->res = str->res; + + str->size = size; + str->res = res; + } +}

1 0

Vincas Miliūnas : msvcp90/tests: Added basic_string< wchar_t>::swap tests.
by Alexandre Julliard 17 Nov '10

17 Nov '10

Module: wine Branch: master Commit: 0de373beff1c031a88de913a477e5c144b7d3dff URL: http://source.winehq.org/git/wine.git/?a=commit;h=0de373beff1c031a88de913a4… Author: Vincas Miliūnas <vincas.miliunas(a)gmail.com> Date: Tue Nov 16 20:58:57 2010 +0200 msvcp90/tests: Added basic_string<wchar_t>::swap tests. --- dlls/msvcp90/tests/string.c | 42 +++++++++++++++++++++++++++++++++++++++++- 1 files changed, 41 insertions(+), 1 deletions(-) diff --git a/dlls/msvcp90/tests/string.c b/dlls/msvcp90/tests/string.c index 73bc881..5d31289 100644 --- a/dlls/msvcp90/tests/string.c +++ b/dlls/msvcp90/tests/string.c @@ -71,6 +71,7 @@ static basic_string_wchar* (WINAPI *p_basic_string_wchar_assign_cstr_len)(const static const wchar_t* (WINAPI *p_basic_string_wchar_cstr)(void); static const wchar_t* (WINAPI *p_basic_string_wchar_data)(void); static size_t (WINAPI *p_basic_string_wchar_size)(void); +static void (WINAPI *p_basic_string_wchar_swap)(basic_string_wchar*); #else static basic_string_char* (__cdecl *p_basic_string_char_ctor)(basic_string_char*); static basic_string_char* (__cdecl *p_basic_string_char_copy_ctor)(basic_string_char*, basic_string_char*); @@ -92,6 +93,7 @@ static basic_string_wchar* (__cdecl *p_basic_string_wchar_assign_cstr_len)(basic static const wchar_t* (__cdecl *p_basic_string_wchar_cstr)(basic_string_wchar*); static const wchar_t* (__cdecl *p_basic_string_wchar_data)(basic_string_wchar*); static size_t (__cdecl *p_basic_string_wchar_size)(basic_string_wchar*); +static void (__cdecl *p_basic_string_wchar_swap)(basic_string_wchar*, basic_string_wchar*); #endif static int invalid_parameter = 0; @@ -263,7 +265,8 @@ static BOOL init(void) "?data@?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QEBAPEB_WXZ"); p_basic_string_wchar_size = (void*)GetProcAddress(msvcp, "?size@?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QEBA_KXZ"); - + p_basic_string_wchar_swap = (void*)GetProcAddress(msvcp, + "?swap@?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QEAAXAEAV12@@Z"); } else { p_basic_string_char_ctor = (void*)GetProcAddress(msvcp, "??0?$basic_string(a)DU?$char_traits(a)D@std@@V?$allocator(a)D@2@@std@@QAE(a)XZ"); @@ -304,6 +307,8 @@ static BOOL init(void) "?data@?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QBEPB_WXZ"); p_basic_string_wchar_size = (void*)GetProcAddress(msvcp, "?size@?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QBEIXZ"); + p_basic_string_wchar_swap = (void*)GetProcAddress(msvcp, + "?swap@?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QAEXAAV12@@Z"); } return TRUE; @@ -490,6 +495,40 @@ static void test_basic_string_wchar(void) { call_func1(p_basic_string_wchar_dtor, &str2); } +static void test_basic_string_wchar_swap(void) { + basic_string_wchar str1, str2; + wchar_t wtmp1[32], wtmp2[32]; + + if(!p_basic_string_wchar_ctor_cstr || !p_basic_string_wchar_dtor || + !p_basic_string_wchar_swap || !p_basic_string_wchar_cstr) { + win_skip("basic_string<wchar_t> unavailable\n"); + return; + } + + /* Swap self, local */ + mbstowcs(wtmp1, "qwerty", 32); + call_func2(p_basic_string_wchar_ctor_cstr, &str1, wtmp1); + call_func2(p_basic_string_wchar_swap, &str1, &str1); + ok(wcscmp(wtmp1, (const wchar_t *) call_func1(p_basic_string_wchar_cstr, &str1)) == 0, "Invalid value of str1\n"); + call_func2(p_basic_string_wchar_swap, &str1, &str1); + ok(wcscmp(wtmp1, (const wchar_t *) call_func1(p_basic_string_wchar_cstr, &str1)) == 0, "Invalid value of str1\n"); + call_func1(p_basic_string_wchar_dtor, &str1); + + /* str1 allocated, str2 local */ + mbstowcs(wtmp1, "qwerty12345678901234567890", 32); + mbstowcs(wtmp2, "asd", 32); + call_func2(p_basic_string_wchar_ctor_cstr, &str1, wtmp1); + call_func2(p_basic_string_wchar_ctor_cstr, &str2, wtmp2); + call_func2(p_basic_string_wchar_swap, &str1, &str2); + ok(wcscmp(wtmp2, (const wchar_t *) call_func1(p_basic_string_wchar_cstr, &str1)) == 0, "Invalid value of str1\n"); + ok(wcscmp(wtmp1, (const wchar_t *) call_func1(p_basic_string_wchar_cstr, &str2)) == 0, "Invalid value of str2\n"); + call_func2(p_basic_string_wchar_swap, &str1, &str2); + ok(wcscmp(wtmp1, (const wchar_t *) call_func1(p_basic_string_wchar_cstr, &str1)) == 0, "Invalid value of str1\n"); + ok(wcscmp(wtmp2, (const wchar_t *) call_func1(p_basic_string_wchar_cstr, &str2)) == 0, "Invalid value of str2\n"); + call_func1(p_basic_string_wchar_dtor, &str1); + call_func1(p_basic_string_wchar_dtor, &str2); +} + START_TEST(string) { if(!init()) @@ -498,6 +537,7 @@ START_TEST(string) test_basic_string_char(); test_basic_string_char_swap(); test_basic_string_wchar(); + test_basic_string_wchar_swap(); ok(!invalid_parameter, "invalid_parameter_handler was invoked too many times\n"); }

1 0

Hans Leidekker : msi: Trace the reinstall mode in hex in MsiReinstallFeatureW.
by Alexandre Julliard 17 Nov '10

17 Nov '10

Module: wine Branch: master Commit: b07ea863d22e9a21f71e4bc4027f67b2c9d2d5ee URL: http://source.winehq.org/git/wine.git/?a=commit;h=b07ea863d22e9a21f71e4bc40… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Wed Nov 17 10:57:21 2010 +0100 msi: Trace the reinstall mode in hex in MsiReinstallFeatureW. --- dlls/msi/msi.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/msi/msi.c b/dlls/msi/msi.c index dcd8e8e..b4a4142 100644 --- a/dlls/msi/msi.c +++ b/dlls/msi/msi.c @@ -3541,8 +3541,8 @@ UINT WINAPI MsiReinstallFeatureW( LPCWSTR szProduct, LPCWSTR szFeature, LPWSTR ptr; DWORD sz; - FIXME("%s %s %i\n", debugstr_w(szProduct), debugstr_w(szFeature), - dwReinstallMode); + FIXME("%s %s 0x%08x\n", + debugstr_w(szProduct), debugstr_w(szFeature), dwReinstallMode); ptr = reinstallmode;

1 0

Hans Leidekker : msi: Fix handling of an empty language id list in msi_parse_summary.
by Alexandre Julliard 17 Nov '10

17 Nov '10

Module: wine Branch: master Commit: a74e025335b107926bf9062ef6ac0fa120613261 URL: http://source.winehq.org/git/wine.git/?a=commit;h=a74e025335b107926bf9062ef… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Wed Nov 17 10:57:40 2010 +0100 msi: Fix handling of an empty language id list in msi_parse_summary. --- dlls/msi/package.c | 9 +++++++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/dlls/msi/package.c b/dlls/msi/package.c index 50a7dbb..72f3392 100644 --- a/dlls/msi/package.c +++ b/dlls/msi/package.c @@ -1336,9 +1336,14 @@ static UINT msi_parse_summary( MSISUMMARYINFO *si, MSIPACKAGE *package ) msi_free( template ); return ERROR_INSTALL_PLATFORM_UNSUPPORTED; } - + p++; + if (!*p) + { + msi_free( template ); + return ERROR_SUCCESS; + } count = 1; - for (q = ++p; (q = strchrW( q, ',' )); q++) count++; + for (q = p; (q = strchrW( q, ',' )); q++) count++; package->langids = msi_alloc( count * sizeof(LANGID) ); if (!package->langids)

1 0

Alexandre Julliard : user32: Check structure size in GetGUIThreadInfo.
by Alexandre Julliard 17 Nov '10

17 Nov '10

Module: wine Branch: master Commit: 30554d4ef12038e07961b16013c5dacb0fca3503 URL: http://source.winehq.org/git/wine.git/?a=commit;h=30554d4ef12038e07961b1601… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Nov 16 20:57:27 2010 +0100 user32: Check structure size in GetGUIThreadInfo. --- dlls/user32/focus.c | 1 + dlls/user32/message.c | 7 +++++++ dlls/user32/painting.c | 1 + dlls/user32/tests/win.c | 16 ++++++++++++++++ dlls/user32/win.c | 1 + dlls/winex11.drv/event.c | 1 + 6 files changed, 27 insertions(+), 0 deletions(-) diff --git a/dlls/user32/focus.c b/dlls/user32/focus.c index f086584..70a2a8a 100644 --- a/dlls/user32/focus.c +++ b/dlls/user32/focus.c @@ -160,6 +160,7 @@ static BOOL set_active_window( HWND hwnd, HWND *prev, BOOL mouse, BOOL focus ) { GUITHREADINFO info; + info.cbSize = sizeof(info); GetGUIThreadInfo( GetCurrentThreadId(), &info ); /* Do not change focus if the window is no more active */ if (hwnd == info.hwndActive) diff --git a/dlls/user32/message.c b/dlls/user32/message.c index b073e1c..c6daf31 100644 --- a/dlls/user32/message.c +++ b/dlls/user32/message.c @@ -2359,6 +2359,7 @@ static BOOL process_mouse_message( MSG *msg, UINT hw_id, ULONG_PTR extra_info, H /* find the window to dispatch this mouse message to */ + info.cbSize = sizeof(info); GetGUIThreadInfo( GetCurrentThreadId(), &info ); if (info.hwndCapture) { @@ -4235,6 +4236,12 @@ BOOL WINAPI GetGUIThreadInfo( DWORD id, GUITHREADINFO *info ) { BOOL ret; + if (info->cbSize != sizeof(*info)) + { + SetLastError( ERROR_INVALID_PARAMETER ); + return FALSE; + } + SERVER_START_REQ( get_thread_input ) { req->tid = id; diff --git a/dlls/user32/painting.c b/dlls/user32/painting.c index e7ce2ec..c3a25fb 100644 --- a/dlls/user32/painting.c +++ b/dlls/user32/painting.c @@ -801,6 +801,7 @@ static HWND fix_caret(HWND hWnd, const RECT *scroll_rect, INT dx, INT dy, RECT rect, mapped_rcCaret; BOOL hide_caret = FALSE; + info.cbSize = sizeof(info); if (!GetGUIThreadInfo( GetCurrentThreadId(), &info )) return 0; if (!info.hwndCaret) return 0; diff --git a/dlls/user32/tests/win.c b/dlls/user32/tests/win.c index 5a378de..ab06687 100644 --- a/dlls/user32/tests/win.c +++ b/dlls/user32/tests/win.c @@ -611,6 +611,22 @@ static DWORD CALLBACK enum_thread( void *arg ) BOOL ret; MSG msg; + if (pGetGUIThreadInfo) + { + GUITHREADINFO info; + info.cbSize = sizeof(info); + ret = pGetGUIThreadInfo( GetCurrentThreadId(), &info ); + ok( ret || broken(!ret), /* win9x */ + "GetGUIThreadInfo failed without message queue\n" ); + SetLastError( 0xdeadbeef ); + info.cbSize = sizeof(info) + 1; + ret = pGetGUIThreadInfo( GetCurrentThreadId(), &info ); + ok( !ret, "GetGUIThreadInfo succeeded with wrong size\n" ); + ok( GetLastError() == ERROR_INVALID_PARAMETER || + broken(GetLastError() == 0xdeadbeef), /* win9x */ + "wrong error %u\n", GetLastError() ); + } + PeekMessage( &msg, 0, 0, 0, PM_NOREMOVE ); /* make sure we have a message queue */ count = 0; diff --git a/dlls/user32/win.c b/dlls/user32/win.c index f9b6be2..f1da48b 100644 --- a/dlls/user32/win.c +++ b/dlls/user32/win.c @@ -1587,6 +1587,7 @@ static void WIN_SendDestroyMsg( HWND hwnd ) { GUITHREADINFO info; + info.cbSize = sizeof(info); if (GetGUIThreadInfo( GetCurrentThreadId(), &info )) { if (hwnd == info.hwndCaret) DestroyCaret(); diff --git a/dlls/winex11.drv/event.c b/dlls/winex11.drv/event.c index ae0875b..5447a40 100644 --- a/dlls/winex11.drv/event.c +++ b/dlls/winex11.drv/event.c @@ -497,6 +497,7 @@ static void set_focus( Display *display, HWND hwnd, Time time ) TRACE( "setting foreground window to %p\n", hwnd ); SetForegroundWindow( hwnd ); + threadinfo.cbSize = sizeof(threadinfo); GetGUIThreadInfo(0, &threadinfo); focus = threadinfo.hwndFocus; if (!focus) focus = threadinfo.hwndActive;

1 0

Alexandre Julliard : user32: Add a stub for IsGUIThread().
by Alexandre Julliard 17 Nov '10

17 Nov '10

Module: wine Branch: master Commit: 14a77db43f242c2acacc910a868fcc23bee49911 URL: http://source.winehq.org/git/wine.git/?a=commit;h=14a77db43f242c2acacc910a8… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Nov 16 21:01:08 2010 +0100 user32: Add a stub for IsGUIThread(). --- dlls/user32/message.c | 10 ++++++++++ dlls/user32/user32.spec | 2 +- include/winuser.h | 1 + 3 files changed, 12 insertions(+), 1 deletions(-) diff --git a/dlls/user32/message.c b/dlls/user32/message.c index c6daf31..93a90ea 100644 --- a/dlls/user32/message.c +++ b/dlls/user32/message.c @@ -4230,6 +4230,16 @@ BOOL WINAPI KillSystemTimer( HWND hwnd, UINT_PTR id ) /********************************************************************** + * IsGUIThread (USER32.@) + */ +BOOL WINAPI IsGUIThread( BOOL convert ) +{ + FIXME( "%u: stub\n", convert ); + return TRUE; +} + + +/********************************************************************** * GetGUIThreadInfo (USER32.@) */ BOOL WINAPI GetGUIThreadInfo( DWORD id, GUITHREADINFO *info ) diff --git a/dlls/user32/user32.spec b/dlls/user32/user32.spec index 072fed4..5eb7154 100644 --- a/dlls/user32/user32.spec +++ b/dlls/user32/user32.spec @@ -436,7 +436,7 @@ @ stdcall IsDialogMessageA(long ptr) @ stdcall IsDialogMessageW(long ptr) @ stdcall IsDlgButtonChecked(long long) -# @ stub IsGUIThread +@ stdcall IsGUIThread(long) @ stdcall IsHungAppWindow(long) # @ stub IsHungThread @ stdcall IsIconic(long) diff --git a/include/winuser.h b/include/winuser.h index 154c8da..83c99cb 100644 --- a/include/winuser.h +++ b/include/winuser.h @@ -4814,6 +4814,7 @@ WINUSERAPI BOOL WINAPI IsDialogMessageA(HWND,LPMSG); WINUSERAPI BOOL WINAPI IsDialogMessageW(HWND,LPMSG); #define IsDialogMessage WINELIB_NAME_AW(IsDialogMessage) WINUSERAPI UINT WINAPI IsDlgButtonChecked(HWND,int); +WINUSERAPI BOOL WINAPI IsGUIThread(BOOL); WINUSERAPI BOOL WINAPI IsHungAppWindow(HWND); WINUSERAPI BOOL WINAPI IsIconic(HWND); WINUSERAPI BOOL WINAPI IsMenu(HMENU);

1 0

Vincent Povirk : ole32: Cache the contents of one extended big block depot block.
by Alexandre Julliard 17 Nov '10

17 Nov '10

Module: wine Branch: master Commit: e883aeb3943ccf8b25b19ca582ea1d8b06561ed1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e883aeb3943ccf8b25b19ca58… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Mon Apr 19 16:55:49 2010 -0500 ole32: Cache the contents of one extended big block depot block. --- dlls/ole32/storage32.c | 29 +++++++++++++++++++++++++---- dlls/ole32/storage32.h | 3 +++ 2 files changed, 28 insertions(+), 4 deletions(-) diff --git a/dlls/ole32/storage32.c b/dlls/ole32/storage32.c index 311f2ae..b58e445 100644 --- a/dlls/ole32/storage32.c +++ b/dlls/ole32/storage32.c @@ -2760,6 +2760,7 @@ static HRESULT StorageImpl_Construct( * There is no block depot cached yet. */ This->indexBlockDepotCached = 0xFFFFFFFF; + This->indexExtBlockDepotCached = 0xFFFFFFFF; /* * Start searching for free blocks with block 0. @@ -3134,17 +3135,32 @@ static ULONG Storage32Impl_GetExtDepotBlock(StorageImpl* This, ULONG depotIndex) ULONG extBlockOffset = numExtBlocks % depotBlocksPerExtBlock; ULONG blockIndex = BLOCK_UNUSED; ULONG extBlockIndex; + BYTE depotBuffer[MAX_BIG_BLOCK_SIZE]; + int index, num_blocks; assert(depotIndex >= COUNT_BBDEPOTINHEADER); if (extBlockCount >= This->extBigBlockDepotCount) return BLOCK_UNUSED; - extBlockIndex = This->extBigBlockDepotLocations[extBlockCount]; + if (This->indexExtBlockDepotCached != extBlockCount) + { + extBlockIndex = This->extBigBlockDepotLocations[extBlockCount]; - if (extBlockIndex != BLOCK_UNUSED) - StorageImpl_ReadDWordFromBigBlock(This, extBlockIndex, - extBlockOffset * sizeof(ULONG), &blockIndex); + StorageImpl_ReadBigBlock(This, extBlockIndex, depotBuffer); + + num_blocks = This->bigBlockSize / 4; + + for (index = 0; index < num_blocks; index++) + { + StorageUtl_ReadDWord(depotBuffer, index*sizeof(ULONG), &blockIndex); + This->extBlockDepotCached[index] = blockIndex; + } + + This->indexExtBlockDepotCached = extBlockCount; + } + + blockIndex = This->extBlockDepotCached[extBlockOffset]; return blockIndex; } @@ -3176,6 +3192,11 @@ static void Storage32Impl_SetExtDepotBlock(StorageImpl* This, ULONG depotIndex, extBlockOffset * sizeof(ULONG), blockIndex); } + + if (This->indexExtBlockDepotCached == extBlockCount) + { + This->extBlockDepotCached[extBlockOffset] = blockIndex; + } } /****************************************************************************** diff --git a/dlls/ole32/storage32.h b/dlls/ole32/storage32.h index 72a5fe7..0f8b3b4 100644 --- a/dlls/ole32/storage32.h +++ b/dlls/ole32/storage32.h @@ -358,6 +358,9 @@ struct StorageImpl ULONG extBigBlockDepotCount; ULONG bigBlockDepotStart[COUNT_BBDEPOTINHEADER]; + ULONG extBlockDepotCached[MAX_BIG_BLOCK_SIZE / 4]; + ULONG indexExtBlockDepotCached; + ULONG blockDepotCached[MAX_BIG_BLOCK_SIZE / 4]; ULONG indexBlockDepotCached; ULONG prevFreeBlock;

1 0

André Hentschel : winemaker: Catch special case in Workspace file.
by Alexandre Julliard 17 Nov '10

17 Nov '10

Module: wine Branch: master Commit: c9ff0c5382cf25ca101ce21c22e9420ccf69fb78 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c9ff0c5382cf25ca101ce21c2… Author: André Hentschel <nerv(a)dawncrow.de> Date: Tue Nov 16 19:59:32 2010 +0100 winemaker: Catch special case in Workspace file. Some sln files use that as a section to keep things like changelogs, which we are not interested in. --- tools/winemaker | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/tools/winemaker b/tools/winemaker index 317b07a..bd46380 100755 --- a/tools/winemaker +++ b/tools/winemaker @@ -1186,6 +1186,7 @@ sub source_scan_workspace_file($) if (/^Project(.*)=\s*"(.*)",\s*"(.*)",\s*"(.*)"/) { $prj_name=$2; $prj_path=$3; + if ($prj_path eq "Solution Items") { next; } @components=split /[\/\\]+/, $3; $prj_path=search_from($path, \@components); print "Name: $prj_name\nPath: $prj_path\n";

1 0