February 2010 - Wine-commits

Alexandre Julliard : makefiles: Use AS_MKDIR_P to create the extra directories.
by Alexandre Julliard 12 Feb '10

12 Feb '10

Module: wine Branch: master Commit: a1c253e0568c5ea343af47507e77eadaef192a4f URL: http://source.winehq.org/git/wine.git/?a=commit;h=a1c253e0568c5ea343af47507… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Feb 11 20:26:35 2010 +0100 makefiles: Use AS_MKDIR_P to create the extra directories. --- aclocal.m4 | 2 +- configure | 24 ++++++++++++------------ 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/aclocal.m4 b/aclocal.m4 index dba0ab3..a70fd30 100644 --- a/aclocal.m4 +++ b/aclocal.m4 @@ -140,7 +140,7 @@ dnl dnl Usage: WINE_CONFIG_EXTRA_DIR(dirname) dnl AC_DEFUN([WINE_CONFIG_EXTRA_DIR], -[AC_CONFIG_COMMANDS([$1],[test -d "$1" || (AC_MSG_NOTICE([creating $1]) && mkdir "$1")])]) +[AC_CONFIG_COMMANDS([$1],[test -d "$1" || { AC_MSG_NOTICE([creating $1]); AS_MKDIR_P("$1"); }])]) dnl **** Create symlinks from config.status **** dnl diff --git a/configure b/configure index ec2199d..3bbc4a7 100755 --- a/configure +++ b/configure @@ -23319,18 +23319,18 @@ $as_echo "$as_me: executing $ac_file commands" >&6;} case $ac_file$ac_mode in "include/stamp-h":C) echo timestamp > include/stamp-h ;; - "dlls/gdi32/enhmfdrv":C) test -d "dlls/gdi32/enhmfdrv" || ({ $as_echo "$as_me:${as_lineno-$LINENO}: creating dlls/gdi32/enhmfdrv" >&5 -$as_echo "$as_me: creating dlls/gdi32/enhmfdrv" >&6;} && mkdir "dlls/gdi32/enhmfdrv") ;; - "dlls/gdi32/mfdrv":C) test -d "dlls/gdi32/mfdrv" || ({ $as_echo "$as_me:${as_lineno-$LINENO}: creating dlls/gdi32/mfdrv" >&5 -$as_echo "$as_me: creating dlls/gdi32/mfdrv" >&6;} && mkdir "dlls/gdi32/mfdrv") ;; - "dlls/kernel32/nls":C) test -d "dlls/kernel32/nls" || ({ $as_echo "$as_me:${as_lineno-$LINENO}: creating dlls/kernel32/nls" >&5 -$as_echo "$as_me: creating dlls/kernel32/nls" >&6;} && mkdir "dlls/kernel32/nls") ;; - "dlls/user32/resources":C) test -d "dlls/user32/resources" || ({ $as_echo "$as_me:${as_lineno-$LINENO}: creating dlls/user32/resources" >&5 -$as_echo "$as_me: creating dlls/user32/resources" >&6;} && mkdir "dlls/user32/resources") ;; - "dlls/wineps.drv/data":C) test -d "dlls/wineps.drv/data" || ({ $as_echo "$as_me:${as_lineno-$LINENO}: creating dlls/wineps.drv/data" >&5 -$as_echo "$as_me: creating dlls/wineps.drv/data" >&6;} && mkdir "dlls/wineps.drv/data") ;; - "include/wine":C) test -d "include/wine" || ({ $as_echo "$as_me:${as_lineno-$LINENO}: creating include/wine" >&5 -$as_echo "$as_me: creating include/wine" >&6;} && mkdir "include/wine") ;; + "dlls/gdi32/enhmfdrv":C) test -d "dlls/gdi32/enhmfdrv" || { { $as_echo "$as_me:${as_lineno-$LINENO}: creating dlls/gdi32/enhmfdrv" >&5 +$as_echo "$as_me: creating dlls/gdi32/enhmfdrv" >&6;}; as_dir="dlls/gdi32/enhmfdrv"; as_fn_mkdir_p; } ;; + "dlls/gdi32/mfdrv":C) test -d "dlls/gdi32/mfdrv" || { { $as_echo "$as_me:${as_lineno-$LINENO}: creating dlls/gdi32/mfdrv" >&5 +$as_echo "$as_me: creating dlls/gdi32/mfdrv" >&6;}; as_dir="dlls/gdi32/mfdrv"; as_fn_mkdir_p; } ;; + "dlls/kernel32/nls":C) test -d "dlls/kernel32/nls" || { { $as_echo "$as_me:${as_lineno-$LINENO}: creating dlls/kernel32/nls" >&5 +$as_echo "$as_me: creating dlls/kernel32/nls" >&6;}; as_dir="dlls/kernel32/nls"; as_fn_mkdir_p; } ;; + "dlls/user32/resources":C) test -d "dlls/user32/resources" || { { $as_echo "$as_me:${as_lineno-$LINENO}: creating dlls/user32/resources" >&5 +$as_echo "$as_me: creating dlls/user32/resources" >&6;}; as_dir="dlls/user32/resources"; as_fn_mkdir_p; } ;; + "dlls/wineps.drv/data":C) test -d "dlls/wineps.drv/data" || { { $as_echo "$as_me:${as_lineno-$LINENO}: creating dlls/wineps.drv/data" >&5 +$as_echo "$as_me: creating dlls/wineps.drv/data" >&6;}; as_dir="dlls/wineps.drv/data"; as_fn_mkdir_p; } ;; + "include/wine":C) test -d "include/wine" || { { $as_echo "$as_me:${as_lineno-$LINENO}: creating include/wine" >&5 +$as_echo "$as_me: creating include/wine" >&6;}; as_dir="include/wine"; as_fn_mkdir_p; } ;; esac done # for ac_tag

1 0

Alexandre Julliard : makefiles: Add helper functions to build the various make lists more efficiently.
by Alexandre Julliard 12 Feb '10

12 Feb '10

Module: wine Branch: master Commit: 2de10c4a4244c612674d7f9cad9b608799a9790e URL: http://source.winehq.org/git/wine.git/?a=commit;h=2de10c4a4244c612674d7f9ca… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Feb 11 23:23:45 2010 +0100 makefiles: Add helper functions to build the various make lists more efficiently. --- aclocal.m4 | 89 +- configure | 7614 ++++++++++++++++++++---------------------------------------- 2 files changed, 2572 insertions(+), 5131 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=2de10c4a4244c612674d7…

1 0

Jacek Caban : urlmon: Added CreateUri stub implementation.
by Alexandre Julliard 12 Feb '10

12 Feb '10

Module: wine Branch: master Commit: 141e61468ea274804e64b885293e39a9da8299d9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=141e61468ea274804e64b8852… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu Feb 11 18:33:48 2010 +0100 urlmon: Added CreateUri stub implementation. --- dlls/urlmon/Makefile.in | 1 + dlls/urlmon/uri.c | 302 +++++++++++++++++++++++++++++++++++++++++++++++ dlls/urlmon/urlmon.spec | 1 + 3 files changed, 304 insertions(+), 0 deletions(-) diff --git a/dlls/urlmon/Makefile.in b/dlls/urlmon/Makefile.in index f0dd490..6a9182c 100644 --- a/dlls/urlmon/Makefile.in +++ b/dlls/urlmon/Makefile.in @@ -28,6 +28,7 @@ C_SRCS = \ session.c \ umon.c \ umstream.c \ + uri.c \ urlmon_main.c \ usrmarshal.c diff --git a/dlls/urlmon/uri.c b/dlls/urlmon/uri.c new file mode 100644 index 0000000..d4d6b47 --- /dev/null +++ b/dlls/urlmon/uri.c @@ -0,0 +1,302 @@ +/* + * Copyright 2010 Jacek Caban for CodeWeavers + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +#include "urlmon_main.h" +#include "wine/debug.h" + +WINE_DEFAULT_DEBUG_CHANNEL(urlmon); + +typedef struct { + const IUriVtbl *lpIUriVtbl; + LONG ref; +} Uri; + +#define URI(x) ((IUri*) &(x)->lpIUriVtbl) + +#define URI_THIS(iface) DEFINE_THIS(Uri, IUri, iface) + +static HRESULT WINAPI Uri_QueryInterface(IUri *iface, REFIID riid, void **ppv) +{ + Uri *This = URI_THIS(iface); + + if(IsEqualGUID(&IID_IUnknown, riid)) { + TRACE("(%p)->(IID_IUnknown %p)\n", This, ppv); + *ppv = URI(This); + }else if(IsEqualGUID(&IID_IUri, riid)) { + TRACE("(%p)->(IID_IUri %p)\n", This, ppv); + *ppv = URI(This); + }else { + TRACE("(%p)->(%s %p)\n", This, debugstr_guid(riid), ppv); + *ppv = NULL; + return E_NOINTERFACE; + } + + IUnknown_AddRef((IUnknown*)*ppv); + return S_OK; +} + +static ULONG WINAPI Uri_AddRef(IUri *iface) +{ + Uri *This = URI_THIS(iface); + LONG ref = InterlockedIncrement(&This->ref); + + TRACE("(%p) ref=%d\n", This, ref); + + return ref; +} + +static ULONG WINAPI Uri_Release(IUri *iface) +{ + Uri *This = URI_THIS(iface); + LONG ref = InterlockedDecrement(&This->ref); + + TRACE("(%p) ref=%d\n", This, ref); + + if(!ref) + heap_free(This); + + return ref; +} + +static HRESULT WINAPI Uri_GetPropertyBSTR(IUri *iface, Uri_PROPERTY uriProp, BSTR *pbstrProperty, DWORD dwFlags) +{ + Uri *This = URI_THIS(iface); + FIXME("(%p)->(%d %p %x)\n", This, uriProp, pbstrProperty, dwFlags); + return E_NOTIMPL; +} + +static HRESULT WINAPI Uri_GetPropertyLength(IUri *iface, Uri_PROPERTY uriProp, DWORD *pcchProperty, DWORD dwFlags) +{ + Uri *This = URI_THIS(iface); + FIXME("(%p)->(%d %p %x)\n", This, uriProp, pcchProperty, dwFlags); + return E_NOTIMPL; +} + +static HRESULT WINAPI Uri_GetPropertyDWORD(IUri *iface, Uri_PROPERTY uriProp, DWORD *pcchProperty, DWORD dwFlags) +{ + Uri *This = URI_THIS(iface); + FIXME("(%p)->(%d %p %x)\n", This, uriProp, pcchProperty, dwFlags); + return E_NOTIMPL; +} + +static HRESULT WINAPI Uri_HasProperty(IUri *iface, Uri_PROPERTY uriProp, BOOL *pfHasProperty) +{ + Uri *This = URI_THIS(iface); + FIXME("(%p)->()\n", This); + return E_NOTIMPL; +} + +static HRESULT WINAPI Uri_GetAbsoluteUri(IUri *iface, BSTR *pstrAbsoluteUri) +{ + Uri *This = URI_THIS(iface); + FIXME("(%p)->(%p)\n", This, pstrAbsoluteUri); + return E_NOTIMPL; +} + +static HRESULT WINAPI Uri_GetAuthority(IUri *iface, BSTR *pstrAuthority) +{ + Uri *This = URI_THIS(iface); + FIXME("(%p)->(%p)\n", This, pstrAuthority); + return E_NOTIMPL; +} + +static HRESULT WINAPI Uri_GetDisplayUri(IUri *iface, BSTR *pstrDisplayUri) +{ + Uri *This = URI_THIS(iface); + FIXME("(%p)->(%p)\n", This, pstrDisplayUri); + return E_NOTIMPL; +} + +static HRESULT WINAPI Uri_GetDomain(IUri *iface, BSTR *pstrDomain) +{ + Uri *This = URI_THIS(iface); + FIXME("(%p)->(%p)\n", This, pstrDomain); + return E_NOTIMPL; +} + +static HRESULT WINAPI Uri_GetExtension(IUri *iface, BSTR *pstrExtension) +{ + Uri *This = URI_THIS(iface); + FIXME("(%p)->(%p)\n", This, pstrExtension); + return E_NOTIMPL; +} + +static HRESULT WINAPI Uri_GetFragment(IUri *iface, BSTR *pstrFragment) +{ + Uri *This = URI_THIS(iface); + FIXME("(%p)->(%p)\n", This, pstrFragment); + return E_NOTIMPL; +} + +static HRESULT WINAPI Uri_GetHost(IUri *iface, BSTR *pstrHost) +{ + Uri *This = URI_THIS(iface); + FIXME("(%p)->(%p)\n", This, pstrHost); + return E_NOTIMPL; +} + +static HRESULT WINAPI Uri_GetPassword(IUri *iface, BSTR *pstrPassword) +{ + Uri *This = URI_THIS(iface); + FIXME("(%p)->(%p)\n", This, pstrPassword); + return E_NOTIMPL; +} + +static HRESULT WINAPI Uri_GetPath(IUri *iface, BSTR *pstrPath) +{ + Uri *This = URI_THIS(iface); + FIXME("(%p)->(%p)\n", This, pstrPath); + return E_NOTIMPL; +} + +static HRESULT WINAPI Uri_GetPathAndQuery(IUri *iface, BSTR *pstrPathAndQuery) +{ + Uri *This = URI_THIS(iface); + FIXME("(%p)->(%p)\n", This, pstrPathAndQuery); + return E_NOTIMPL; +} + +static HRESULT WINAPI Uri_GetQuery(IUri *iface, BSTR *pstrQuery) +{ + Uri *This = URI_THIS(iface); + FIXME("(%p)->(%p)\n", This, pstrQuery); + return E_NOTIMPL; +} + +static HRESULT WINAPI Uri_GetRawUri(IUri *iface, BSTR *pstrRawUri) +{ + Uri *This = URI_THIS(iface); + FIXME("(%p)->(%p)\n", This, pstrRawUri); + return E_NOTIMPL; +} + +static HRESULT WINAPI Uri_GetSchemeName(IUri *iface, BSTR *pstrSchemeName) +{ + Uri *This = URI_THIS(iface); + FIXME("(%p)->(%p)\n", This, pstrSchemeName); + return E_NOTIMPL; +} + +static HRESULT WINAPI Uri_GetUserInfo(IUri *iface, BSTR *pstrUserInfo) +{ + Uri *This = URI_THIS(iface); + FIXME("(%p)->(%p)\n", This, pstrUserInfo); + return E_NOTIMPL; +} + +static HRESULT WINAPI Uri_GetUserName(IUri *iface, BSTR *pstrUserName) +{ + Uri *This = URI_THIS(iface); + FIXME("(%p)->(%p)\n", This, pstrUserName); + return E_NOTIMPL; +} + +static HRESULT WINAPI Uri_GetHostType(IUri *iface, DWORD *pdwHostType) +{ + Uri *This = URI_THIS(iface); + FIXME("(%p)->(%p)\n", This, pdwHostType); + return E_NOTIMPL; +} + +static HRESULT WINAPI Uri_GetPort(IUri *iface, DWORD *pdwPort) +{ + Uri *This = URI_THIS(iface); + FIXME("(%p)->(%p)\n", This, pdwPort); + return E_NOTIMPL; +} + +static HRESULT WINAPI Uri_GetScheme(IUri *iface, DWORD *pdwScheme) +{ + Uri *This = URI_THIS(iface); + FIXME("(%p)->(%p)\n", This, pdwScheme); + return E_NOTIMPL; +} + +static HRESULT WINAPI Uri_GetZone(IUri *iface, DWORD *pdwZone) +{ + Uri *This = URI_THIS(iface); + FIXME("(%p)->(%p)\n", This, pdwZone); + return E_NOTIMPL; +} + +static HRESULT WINAPI Uri_GetProperties(IUri *iface, DWORD *pdwProperties) +{ + Uri *This = URI_THIS(iface); + FIXME("(%p)->(%p)\n", This, pdwProperties); + return E_NOTIMPL; +} + +static HRESULT WINAPI Uri_IsEqual(IUri *iface, IUri *pUri, BOOL *pfEqual) +{ + Uri *This = URI_THIS(iface); + FIXME("(%p)->(%p %p)\n", This, pUri, pfEqual); + return E_NOTIMPL; +} + +#undef URI_THIS + +static const IUriVtbl UriVtbl = { + Uri_QueryInterface, + Uri_AddRef, + Uri_Release, + Uri_GetPropertyBSTR, + Uri_GetPropertyLength, + Uri_GetPropertyDWORD, + Uri_HasProperty, + Uri_GetAbsoluteUri, + Uri_GetAuthority, + Uri_GetDisplayUri, + Uri_GetDomain, + Uri_GetExtension, + Uri_GetFragment, + Uri_GetHost, + Uri_GetPassword, + Uri_GetPath, + Uri_GetPathAndQuery, + Uri_GetQuery, + Uri_GetRawUri, + Uri_GetSchemeName, + Uri_GetUserInfo, + Uri_GetUserName, + Uri_GetHostType, + Uri_GetPort, + Uri_GetScheme, + Uri_GetZone, + Uri_GetProperties, + Uri_IsEqual +}; + +/*********************************************************************** + * CreateUri (urlmon.@) + */ +HRESULT WINAPI CreateUri(LPCWSTR pwzURI, DWORD dwFlags, DWORD_PTR dwReserved, IUri **ppURI) +{ + Uri *ret; + + TRACE("(%s %x %x %p)\n", debugstr_w(pwzURI), dwFlags, (DWORD)dwReserved, ppURI); + + ret = heap_alloc(sizeof(Uri)); + if(!ret) + return E_OUTOFMEMORY; + + ret->lpIUriVtbl = &UriVtbl; + ret->ref = 1; + + *ppURI = URI(ret); + return S_OK; +} diff --git a/dlls/urlmon/urlmon.spec b/dlls/urlmon/urlmon.spec index cc40c36..dbb8fa9 100644 --- a/dlls/urlmon/urlmon.spec +++ b/dlls/urlmon/urlmon.spec @@ -26,6 +26,7 @@ @ stdcall CreateAsyncBindCtx(long ptr ptr ptr) @ stdcall CreateAsyncBindCtxEx(ptr long ptr ptr ptr long) @ stdcall CreateFormatEnumerator(long ptr ptr) +@ stdcall CreateUri(wstr long long ptr) @ stdcall CreateURLMoniker(ptr wstr ptr) @ stdcall CreateURLMonikerEx(ptr wstr ptr long) @ stdcall -private DllCanUnloadNow()

1 0

Nikolay Sivov : comctl32/rebar: Don't try to access band data before it' s needed.
by Alexandre Julliard 12 Feb '10

12 Feb '10

Module: wine Branch: master Commit: 70890031a336c053b39dfeb0ec428742a300bea6 URL: http://source.winehq.org/git/wine.git/?a=commit;h=70890031a336c053b39dfeb0e… Author: Nikolay Sivov <bunglehead(a)gmail.com> Date: Thu Feb 11 22:40:15 2010 +0300 comctl32/rebar: Don't try to access band data before it's needed. --- dlls/comctl32/rebar.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/dlls/comctl32/rebar.c b/dlls/comctl32/rebar.c index 21aabfa..cc06425 100644 --- a/dlls/comctl32/rebar.c +++ b/dlls/comctl32/rebar.c @@ -2919,7 +2919,6 @@ REBAR_PushChevron(const REBAR_INFO *infoPtr, UINT uBand, LPARAM lParam) static LRESULT REBAR_LButtonDown (REBAR_INFO *infoPtr, LPARAM lParam) { - REBAR_BAND *lpBand; UINT htFlags; INT iHitBand; POINT ptMouseDown; @@ -2927,7 +2926,6 @@ REBAR_LButtonDown (REBAR_INFO *infoPtr, LPARAM lParam) ptMouseDown.y = (short)HIWORD(lParam); REBAR_InternalHitTest(infoPtr, &ptMouseDown, &htFlags, &iHitBand); - lpBand = REBAR_GetBand(infoPtr, iHitBand); if (htFlags == RBHT_CHEVRON) { @@ -2935,8 +2933,12 @@ REBAR_LButtonDown (REBAR_INFO *infoPtr, LPARAM lParam) } else if (htFlags == RBHT_GRABBER || htFlags == RBHT_CAPTION) { + REBAR_BAND *lpBand; + TRACE("Starting drag\n"); + lpBand = REBAR_GetBand(infoPtr, iHitBand); + SetCapture (infoPtr->hwndSelf); infoPtr->iGrabbedBand = iHitBand;

1 0

Alexandre Julliard : patches: Improve filtering of non-git patches that only add new files.
by Alexandre Julliard 12 Feb '10

12 Feb '10

Module: tools Branch: master Commit: 68935fce5551c6e75b2839afb2c8ddbd3da66afa URL: http://source.winehq.org/git/tools.git/?a=commit;h=68935fce5551c6e75b2839af… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Feb 12 17:15:14 2010 +0100 patches: Improve filtering of non-git patches that only add new files. --- patches/filter | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/patches/filter b/patches/filter index 747f719..8a9bf9c 100755 --- a/patches/filter +++ b/patches/filter @@ -40,6 +40,7 @@ sub find_p_option(@) while ($a[$ret] ne $b[$ret]) { $ret++; } return $ret; } + return 0; } sub add_prefix($$$) @@ -66,6 +67,7 @@ sub filter_patch(@) if (/^Index: (\S*)/) { $use_index = 1; } elsif (/^\+\+\+ b\//) { $p_option = 1; } elsif (/^diff --git/) { $p_option = 1; } + elsif (/ (\/dev\/null)/) { push @diff_lines, $1; } elsif (/^--- (\S*)\//) { push @diff_lines, $1; } elsif (/^\+\+\+ (\S*)\//) { push @diff_lines, $1; } }

1 0

Alexandre Julliard : winetest: Fix building of the tests for the new makefiles architecture.
by Alexandre Julliard 11 Feb '10

11 Feb '10

Module: tools Branch: master Commit: c2f5792fae30cb14105f51b3d44af2c7a6d76e9a URL: http://source.winehq.org/git/tools.git/?a=commit;h=c2f5792fae30cb14105f51b3… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Feb 10 18:03:12 2010 +0100 winetest: Fix building of the tests for the new makefiles architecture. --- winetest/make-winetest | 8 +++----- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/winetest/make-winetest b/winetest/make-winetest index 6e4b24c..813cfb5 100755 --- a/winetest/make-winetest +++ b/winetest/make-winetest @@ -79,7 +79,7 @@ umask 022 cd build-native && ../wine/configure --enable-win64 --without-x --without-freetype) || exit - (cd build-native && make depend && make tools) || exit + (cd build-native && make depend && make __tooldeps__) || exit # then cross-compile the tests @@ -90,8 +90,7 @@ umask 022 (cd build-mingw && make depend && - make include && - make -C dlls testsubdirs && + make programs/winetest && cd programs/winetest && $mingw32-gcc -v 2> build.nfo && make dist) || exit @@ -116,8 +115,7 @@ umask 022 (cd build-mingw64 && make depend && - make include && - make -C dlls testsubdirs && + make programs/winetest && cd programs/winetest && $mingw64-gcc -v 2> build.nfo && make dist) || exit

1 0

Michael Stefaniuc : user32: Don't use HIWORD() on a HINSTANCE.
by Alexandre Julliard 11 Feb '10

11 Feb '10

Module: wine Branch: master Commit: 7442a7f9311b7d0adb5737d6676a6be94e41bf5b URL: http://source.winehq.org/git/wine.git/?a=commit;h=7442a7f9311b7d0adb5737d66… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Thu Feb 11 15:26:23 2010 +0100 user32: Don't use HIWORD() on a HINSTANCE. --- dlls/user32/cursoricon.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/user32/cursoricon.c b/dlls/user32/cursoricon.c index d4cdde4..a003cb0 100644 --- a/dlls/user32/cursoricon.c +++ b/dlls/user32/cursoricon.c @@ -1258,7 +1258,7 @@ static HICON CURSORICON_Load(HINSTANCE hInstance, LPCWSTR name, if (!hInstance) hInstance = user32_module; /* Load OEM cursor/icon */ /* don't cache 16-bit instances (FIXME: should never get 16-bit instances in the first place) */ - if (!HIWORD( hInstance )) loadflags &= ~LR_SHARED; + if ((ULONG_PTR)hInstance >> 16 == 0) loadflags &= ~LR_SHARED; /* Get directory resource ID */

1 0

Huw Davies : rpcrt4: Add tests for multi-dimensional conformant arrays.
by Alexandre Julliard 11 Feb '10

11 Feb '10

Module: wine Branch: master Commit: 6805045b05c80a76efa5f0aad0b6aafd6adf92ec URL: http://source.winehq.org/git/wine.git/?a=commit;h=6805045b05c80a76efa5f0aad… Author: Huw Davies <huw(a)codeweavers.com> Date: Thu Feb 11 16:18:55 2010 +0000 rpcrt4: Add tests for multi-dimensional conformant arrays. --- dlls/rpcrt4/tests/ndr_marshall.c | 156 ++++++++++++++++++++++++++++++++++++++ 1 files changed, 156 insertions(+), 0 deletions(-) diff --git a/dlls/rpcrt4/tests/ndr_marshall.c b/dlls/rpcrt4/tests/ndr_marshall.c index 15ccbef..be8e638 100644 --- a/dlls/rpcrt4/tests/ndr_marshall.c +++ b/dlls/rpcrt4/tests/ndr_marshall.c @@ -1882,6 +1882,161 @@ static void test_conf_complex_struct(void) HeapFree(GetProcessHeap(), 0, memsrc); } + +static void test_conf_complex_array(void) +{ + RPC_MESSAGE RpcMessage; + MIDL_STUB_MESSAGE StubMsg; + MIDL_STUB_DESC StubDesc; + void *ptr; + unsigned int i, j; + struct conf_complex + { + unsigned int dim1, dim2; + DWORD **array; + }; + struct conf_complex memsrc; + struct conf_complex *mem; + DWORD *buf, expected_length; + + static const unsigned char fmtstr_complex_array[] = + { + +/* 0 */ 0x21, /* FC_BOGUS_ARRAY */ + 0x3, /* 3 */ +/* 2 */ NdrFcShort( 0x0 ), /* 0 */ +/* 4 */ 0x19, 0x0, /* Corr desc: field pointer, FC_ULONG */ +/* 6 */ NdrFcShort( 0x4 ), /* 4 */ +/* 8 */ NdrFcLong( 0xffffffff ), /* -1 */ +/* 12 */ 0x8, /* FC_LONG */ + 0x5b, /* FC_END */ +/* 14 */ + 0x21, /* FC_BOGUS_ARRAY */ + 0x3, /* 3 */ +/* 16 */ NdrFcShort( 0x0 ), /* 0 */ +/* 18 */ 0x19, /* Corr desc: field pointer, FC_ULONG */ + 0x0, /* */ +/* 20 */ NdrFcShort( 0x0 ), /* 0 */ +/* 22 */ NdrFcLong( 0xffffffff ), /* -1 */ +/* 26 */ 0x12, 0x0, /* FC_UP */ +/* 28 */ NdrFcShort( 0xffe4 ), /* Offset= -28 (0) */ +/* 30 */ 0x5c, /* FC_PAD */ + 0x5b, /* FC_END */ +/* 32 */ + 0x16, /* FC_PSTRUCT */ + 0x3, /* 3 */ +/* 34 */ NdrFcShort( 0xc ), /* 12 */ +/* 36 */ 0x4b, /* FC_PP */ + 0x5c, /* FC_PAD */ +/* 38 */ 0x46, /* FC_NO_REPEAT */ + 0x5c, /* FC_PAD */ +/* 40 */ NdrFcShort( 0x8 ), /* 8 */ +/* 42 */ NdrFcShort( 0x8 ), /* 8 */ +/* 44 */ 0x12, 0x0, /* FC_UP */ +/* 46 */ NdrFcShort( 0xffe0 ), /* Offset= -32 (14) */ +/* 48 */ 0x5b, /* FC_END */ + 0x8, /* FC_LONG */ +/* 50 */ 0x8, /* FC_LONG */ + 0x8, /* FC_LONG */ +/* 52 */ 0x5c, /* FC_PAD */ + 0x5b, /* FC_END */ + }; + + memsrc.dim1 = 5; + memsrc.dim2 = 3; + + memsrc.array = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, memsrc.dim1 * sizeof(DWORD*)); + + for(i = 0; i < memsrc.dim1; i++) + { + memsrc.array[i] = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, memsrc.dim2 * sizeof(DWORD)); + for(j = 0; j < memsrc.dim2; j++) + memsrc.array[i][j] = i * memsrc.dim2 + j; + } + + StubDesc = Object_StubDesc; + StubDesc.pFormatTypes = fmtstr_complex_array; + + NdrClientInitializeNew( + &RpcMessage, + &StubMsg, + &StubDesc, + 0); + + StubMsg.BufferLength = 0; + NdrSimpleStructBufferSize( &StubMsg, + (unsigned char *)&memsrc, + &fmtstr_complex_array[32] ); + + expected_length = (4 + memsrc.dim1 * (2 + memsrc.dim2)) * 4; +todo_wine + ok(StubMsg.BufferLength >= expected_length, "length %d\n", StubMsg.BufferLength); + + /*NdrGetBuffer(&_StubMsg, _StubMsg.BufferLength, NULL);*/ + StubMsg.RpcMsg->Buffer = StubMsg.BufferStart = StubMsg.Buffer = HeapAlloc(GetProcessHeap(), 0, StubMsg.BufferLength); + StubMsg.BufferEnd = StubMsg.BufferStart + StubMsg.BufferLength; + + ptr = NdrSimpleStructMarshall( &StubMsg, (unsigned char *)&memsrc, + &fmtstr_complex_array[32] ); + ok(ptr == NULL, "ret %p\n", ptr); + +todo_wine + ok((char*)StubMsg.Buffer == (char*)StubMsg.BufferStart + expected_length, "not at expected length\n"); + + /* Skip tests on Wine until the todo_wine is removed */ + if((char*)StubMsg.Buffer == (char*)StubMsg.BufferStart + expected_length) + { + + buf = (DWORD *)StubMsg.BufferStart; + + ok(*buf == memsrc.dim1, "dim1 should have been %d instead of %08x\n", memsrc.dim1, *buf); + buf++; + ok(*buf == memsrc.dim2, "dim2 should have been %d instead of %08x\n", memsrc.dim2, *buf); + buf++; + ok(*buf != 0, "pointer id should be non-zero\n"); + buf++; + ok(*buf == memsrc.dim1, "Conformance should have been %d instead of %08x\n", memsrc.dim1, *buf); + buf++; + for(i = 0; i < memsrc.dim1; i++) + { + ok(*buf != 0, "pointer id[%d] should be non-zero\n", i); + buf++; + } + for(i = 0; i < memsrc.dim1; i++) + { + ok(*buf == memsrc.dim2, "Conformance should have been %d instead of %08x\n", memsrc.dim2, *buf); + buf++; + for(j = 0; j < memsrc.dim2; j++) + { + ok(*buf == i * memsrc.dim2 + j, "got %08x\n", *buf); + buf++; + } + } + + ok((void*)buf == StubMsg.Buffer, "not at end of buffer\n"); + + /* Server */ + my_alloc_called = 0; + StubMsg.IsClient = 0; + mem = NULL; + StubMsg.Buffer = StubMsg.BufferStart; + ptr = NdrSimpleStructUnmarshall( &StubMsg, (unsigned char **)&mem, &fmtstr_complex_array[32], 0); + ok(ptr == NULL, "ret %p\n", ptr); + ok(mem->dim1 == memsrc.dim1, "mem->dim1 wasn't unmarshalled correctly (%d)\n", mem->dim1); + ok(mem->dim2 == memsrc.dim2, "mem->dim2 wasn't unmarshalled correctly (%d)\n", mem->dim2); + ok(mem->array[1][0] == memsrc.dim2, "mem->array[1][0] wasn't unmarshalled correctly (%d)\n", mem->array[1][0]); + + StubMsg.Buffer = StubMsg.BufferStart; + NdrSimpleStructFree( &StubMsg, (unsigned char*)mem, &fmtstr_complex_array[32]); + } + + HeapFree(GetProcessHeap(), 0, StubMsg.RpcMsg->Buffer); + + for(i = 0; i < memsrc.dim1; i++) + HeapFree(GetProcessHeap(), 0, memsrc.array[i]); + HeapFree(GetProcessHeap(), 0, memsrc.array); +} + static void test_ndr_buffer(void) { static unsigned char ncalrpc[] = "ncalrpc"; @@ -2226,6 +2381,7 @@ START_TEST( ndr_marshall ) test_conformant_string(); test_nonconformant_string(); test_conf_complex_struct(); + test_conf_complex_array(); test_ndr_buffer(); test_NdrMapCommAndFaultStatus(); test_NdrGetUserMarshalInfo();

1 0

Jacek Caban : mshtml: Added tests showing that we should return E_NOTIMPL in DeleteMemberByName.
by Alexandre Julliard 11 Feb '10

11 Feb '10

Module: wine Branch: master Commit: 0216974a1b0086211125e1b7787bc2c98252c61f URL: http://source.winehq.org/git/wine.git/?a=commit;h=0216974a1b0086211125e1b77… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu Feb 11 01:20:26 2010 +0100 mshtml: Added tests showing that we should return E_NOTIMPL in DeleteMemberByName. --- dlls/mshtml/dispex.c | 5 ++++- dlls/mshtml/tests/script.c | 9 +++++++++ 2 files changed, 13 insertions(+), 1 deletions(-) diff --git a/dlls/mshtml/dispex.c b/dlls/mshtml/dispex.c index 52d8d41..4b1bd88 100644 --- a/dlls/mshtml/dispex.c +++ b/dlls/mshtml/dispex.c @@ -983,7 +983,10 @@ static HRESULT WINAPI DispatchEx_InvokeEx(IDispatchEx *iface, DISPID id, LCID lc static HRESULT WINAPI DispatchEx_DeleteMemberByName(IDispatchEx *iface, BSTR bstrName, DWORD grfdex) { DispatchEx *This = DISPATCHEX_THIS(iface); - FIXME("(%p)->(%s %x)\n", This, debugstr_w(bstrName), grfdex); + + TRACE("(%p)->(%s %x)\n", This, debugstr_w(bstrName), grfdex); + + /* Not implemented by IE */ return E_NOTIMPL; } diff --git a/dlls/mshtml/tests/script.c b/dlls/mshtml/tests/script.c index fae49c8..6a0cbe3 100644 --- a/dlls/mshtml/tests/script.c +++ b/dlls/mshtml/tests/script.c @@ -1803,6 +1803,11 @@ static HRESULT WINAPI ActiveScriptParse_ParseScriptText(IActiveScriptParse *ifac test_func(dispex); test_nextdispid(dispex); + + tmp = a2bstr("test"); + hres = IDispatchEx_DeleteMemberByName(dispex, tmp, fdexNameCaseSensitive); + ok(hres == E_NOTIMPL, "DeleteMemberByName failed: %08x\n", hres); + IDispatchEx_Release(dispex); script_disp = (IDispatch*)&scriptDisp; @@ -1843,6 +1848,10 @@ static HRESULT WINAPI ActiveScriptParse_ParseScriptText(IActiveScriptParse *ifac CHECK_CALLED(script_testprop2_d); SysFreeString(tmp); + tmp = a2bstr("test"); + hres = IDispatchEx_DeleteMemberByName(window_dispex, tmp, fdexNameCaseSensitive); + ok(hres == E_NOTIMPL, "DeleteMemberByName failed: %08x\n", hres); + test_global_id(); test_security();

1 0

Jacek Caban : mshtml: Ensure that gecko event listener is attached in attach_event.
by Alexandre Julliard 11 Feb '10

11 Feb '10

Module: wine Branch: master Commit: ca9dbd736f61c272507f4053e479f6942658562c URL: http://source.winehq.org/git/wine.git/?a=commit;h=ca9dbd736f61c272507f4053e… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu Feb 11 01:20:53 2010 +0100 mshtml: Ensure that gecko event listener is attached in attach_event. --- dlls/mshtml/htmlevent.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/mshtml/htmlevent.c b/dlls/mshtml/htmlevent.c index 129f7dd..54429c3 100644 --- a/dlls/mshtml/htmlevent.c +++ b/dlls/mshtml/htmlevent.c @@ -1128,7 +1128,7 @@ HRESULT attach_event(event_target_t **event_target_ptr, HTMLDocument *doc, BSTR event_target->event_table[eid]->handlers[i] = disp; *res = VARIANT_TRUE; - return S_OK; + return ensure_nsevent_handler(doc->doc_node, eid); } HRESULT detach_event(event_target_t *event_target, HTMLDocument *doc, BSTR name, IDispatch *disp)

1 0