April 2010 - Wine-commits - list.winehq.org

Andrew Nguyen : shell32/tests: Release the test desktop interface on all appropriate exit paths in ParseDisplayName tests .
by Alexandre Julliard 19 Apr '10

19 Apr '10

Module: wine Branch: master Commit: 7a7ece786cfb94ee83c6ef51d8321c0487b586a1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7a7ece786cfb94ee83c6ef51d… Author: Andrew Nguyen <anguyen(a)codeweavers.com> Date: Sun Apr 18 15:10:43 2010 -0500 shell32/tests: Release the test desktop interface on all appropriate exit paths in ParseDisplayName tests. --- dlls/shell32/tests/shlfolder.c | 21 +++++++++++++++++---- 1 files changed, 17 insertions(+), 4 deletions(-) diff --git a/dlls/shell32/tests/shlfolder.c b/dlls/shell32/tests/shlfolder.c index 6e9f764..f63bf6e 100644 --- a/dlls/shell32/tests/shlfolder.c +++ b/dlls/shell32/tests/shlfolder.c @@ -102,6 +102,7 @@ static void test_ParseDisplayName(void) BOOL bRes; hr = SHGetDesktopFolder(&IDesktopFolder); + ok(hr == S_OK, "Expected SHGetDesktopFolder to return S_OK, got 0x%08x\n", hr); if(hr != S_OK) return; /* Tests crash on W2K and below (SHCreateShellItem available as of XP) */ @@ -147,7 +148,11 @@ static void test_ParseDisplayName(void) } res = GetFileAttributesA(cNonExistDir1A); - if(res != INVALID_FILE_ATTRIBUTES) return; + if(res != INVALID_FILE_ATTRIBUTES) + { + skip("Test directory unexpectedly exists\n"); + goto finished; + } MultiByteToWideChar(CP_ACP, 0, cNonExistDir1A, -1, cTestDirW, MAX_PATH); hr = IShellFolder_ParseDisplayName(IDesktopFolder, @@ -156,7 +161,11 @@ static void test_ParseDisplayName(void) "ParseDisplayName returned %08x, expected 80070002 or E_FAIL\n", hr); res = GetFileAttributesA(cNonExistDir2A); - if(res != INVALID_FILE_ATTRIBUTES) return; + if(res != INVALID_FILE_ATTRIBUTES) + { + skip("Test directory unexpectedly exists\n"); + goto finished; + } MultiByteToWideChar(CP_ACP, 0, cNonExistDir2A, -1, cTestDirW, MAX_PATH); hr = IShellFolder_ParseDisplayName(IDesktopFolder, @@ -167,8 +176,12 @@ static void test_ParseDisplayName(void) /* I thought that perhaps the DesktopFolder's ParseDisplayName would recognize the * path corresponding to CSIDL_PERSONAL and return a CLSID_MyDocuments PIDL. Turns * out it doesn't. The magic seems to happen in the file dialogs, then. */ - if (!pSHGetSpecialFolderPathW || !pILFindLastID) goto finished; - + if (!pSHGetSpecialFolderPathW || !pILFindLastID) + { + win_skip("SHGetSpecialFolderPathW and/or ILFindLastID are not available\n"); + goto finished; + } + bRes = pSHGetSpecialFolderPathW(NULL, cTestDirW, CSIDL_PERSONAL, FALSE); ok(bRes, "SHGetSpecialFolderPath(CSIDL_PERSONAL) failed! %u\n", GetLastError()); if (!bRes) goto finished;

1 0

Detlef Riekenberg : shlwapi/tests: Add initial test for SHGetThreadRef.
by Alexandre Julliard 19 Apr '10

19 Apr '10

Module: wine Branch: master Commit: 261bc3859ff9b0747dda592a1f8722264371677b URL: http://source.winehq.org/git/wine.git/?a=commit;h=261bc3859ff9b0747dda592a1… Author: Detlef Riekenberg <wine.dev(a)web.de> Date: Mon Apr 19 00:45:17 2010 +0200 shlwapi/tests: Add initial test for SHGetThreadRef. --- dlls/shlwapi/tests/Makefile.in | 1 + dlls/shlwapi/tests/thread.c | 66 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 67 insertions(+), 0 deletions(-) diff --git a/dlls/shlwapi/tests/Makefile.in b/dlls/shlwapi/tests/Makefile.in index 585607c..038d76c 100644 --- a/dlls/shlwapi/tests/Makefile.in +++ b/dlls/shlwapi/tests/Makefile.in @@ -15,6 +15,7 @@ C_SRCS = \ path.c \ shreg.c \ string.c \ + thread.c \ url.c @MAKE_TEST_RULES@ diff --git a/dlls/shlwapi/tests/thread.c b/dlls/shlwapi/tests/thread.c new file mode 100644 index 0000000..b345604 --- /dev/null +++ b/dlls/shlwapi/tests/thread.c @@ -0,0 +1,66 @@ +/* Tests for Thread and SHGlobalCounter functions + * + * Copyright 2010 Detlef Riekenberg + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +#include <stdio.h> +#include <stdarg.h> + +#define COBJMACROS +#include "windef.h" +#include "winbase.h" +#include "winerror.h" +#include "ole2.h" +#include "shlwapi.h" + +#include "wine/test.h" + +static HRESULT (WINAPI *pSHGetThreadRef)(IUnknown**); + +/* ##### */ + +static void test_SHGetThreadRef(void) +{ + IUnknown *punk; + HRESULT hr; + + /* Not present before IE 5 */ + if (!pSHGetThreadRef) { + win_skip("SHGetThreadRef not found\n"); + return; + } + + punk = NULL; + hr = pSHGetThreadRef(&punk); + ok( (hr == E_NOINTERFACE) && (punk == NULL), + "got 0x%x and %p (expected E_NOINTERFACE and NULL)\n", hr, punk); + + if (0) { + /* this crash on Windows */ + hr = pSHGetThreadRef(NULL); + } +} + +START_TEST(thread) +{ + HMODULE hshlwapi = GetModuleHandleA("shlwapi.dll"); + + pSHGetThreadRef = (void *) GetProcAddress(hshlwapi, "SHGetThreadRef"); + + test_SHGetThreadRef(); + +}

1 0

Detlef Riekenberg : shlwapi/tests: Add tests for SHSetThreadRef.
by Alexandre Julliard 19 Apr '10

19 Apr '10

Module: wine Branch: master Commit: 324783ad09bf766097f8602c09b74f33113fb780 URL: http://source.winehq.org/git/wine.git/?a=commit;h=324783ad09bf766097f8602c0… Author: Detlef Riekenberg <wine.dev(a)web.de> Date: Mon Apr 19 00:45:18 2010 +0200 shlwapi/tests: Add tests for SHSetThreadRef. --- dlls/shlwapi/tests/thread.c | 76 +++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 76 insertions(+), 0 deletions(-) diff --git a/dlls/shlwapi/tests/thread.c b/dlls/shlwapi/tests/thread.c index b345604..90e87f5 100644 --- a/dlls/shlwapi/tests/thread.c +++ b/dlls/shlwapi/tests/thread.c @@ -30,6 +30,48 @@ #include "wine/test.h" static HRESULT (WINAPI *pSHGetThreadRef)(IUnknown**); +static HRESULT (WINAPI *pSHSetThreadRef)(IUnknown*); + +static DWORD AddRef_called; + +typedef struct +{ + void* lpVtbl; + LONG *ref; +} threadref; + +static HRESULT WINAPI threadref_QueryInterface(threadref *This, REFIID riid, LPVOID *ppvObj) +{ + trace("unexpected QueryInterface(%p, %p, %p) called\n", This, riid, ppvObj); + *ppvObj = NULL; + return E_NOINTERFACE; +} + +static ULONG WINAPI threadref_AddRef(threadref *This) +{ + AddRef_called++; + return InterlockedIncrement(This->ref); +} + +static ULONG WINAPI threadref_Release(threadref *This) +{ + trace("unexpected Release(%p) called\n", This); + return InterlockedDecrement(This->ref); +} + +/* VTable */ +static void* threadref_vt[] = +{ + threadref_QueryInterface, + threadref_AddRef, + threadref_Release +}; + +static void init_threadref(threadref* iface, LONG *refcount) +{ + iface->lpVtbl = (void*)threadref_vt; + iface->ref = refcount; +} /* ##### */ @@ -55,12 +97,46 @@ static void test_SHGetThreadRef(void) } } +static void test_SHSetThreadRef(void) +{ + threadref ref; + IUnknown *punk; + HRESULT hr; + LONG refcount; + + /* Not present before IE 5 */ + if (!pSHSetThreadRef) { + win_skip("SHSetThreadRef not found\n"); + return; + } + + init_threadref(&ref, &refcount); + AddRef_called = 0; + refcount = 1; + hr = pSHSetThreadRef( (IUnknown *)&ref); + ok( (hr == S_OK) && (refcount == 1) && (!AddRef_called), + "got 0x%x with %d, %d (expected S_OK with 1, 0)\n", + hr, refcount, AddRef_called); + + /* Read back IUnkonwn */ + AddRef_called = 0; + refcount = 1; + punk = NULL; + hr = pSHGetThreadRef(&punk); + ok( (hr == S_OK) && (punk == (IUnknown *)&ref) && (refcount == 2) && (AddRef_called == 1), + "got 0x%x and %p with %d, %d (expected S_OK and %p with 2, 1)\n", + hr, punk, refcount, AddRef_called, &ref); + +} + START_TEST(thread) { HMODULE hshlwapi = GetModuleHandleA("shlwapi.dll"); pSHGetThreadRef = (void *) GetProcAddress(hshlwapi, "SHGetThreadRef"); + pSHSetThreadRef = (void *) GetProcAddress(hshlwapi, "SHSetThreadRef"); test_SHGetThreadRef(); + test_SHSetThreadRef(); }

1 0

Detlef Riekenberg : shlwapi: Fix broken NULL checks (with tests).
by Alexandre Julliard 19 Apr '10

19 Apr '10

Module: wine Branch: master Commit: a9ac4a119a5ee94896298532c602713389b7a5c9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=a9ac4a119a5ee94896298532c… Author: Detlef Riekenberg <wine.dev(a)web.de> Date: Mon Apr 19 00:45:19 2010 +0200 shlwapi: Fix broken NULL checks (with tests). --- dlls/shlwapi/tests/thread.c | 16 +++++++++++++++- dlls/shlwapi/thread.c | 8 ++++---- 2 files changed, 19 insertions(+), 5 deletions(-) diff --git a/dlls/shlwapi/tests/thread.c b/dlls/shlwapi/tests/thread.c index 90e87f5..ea89424 100644 --- a/dlls/shlwapi/tests/thread.c +++ b/dlls/shlwapi/tests/thread.c @@ -110,6 +110,11 @@ static void test_SHSetThreadRef(void) return; } + /* start with a clean state */ + hr = pSHSetThreadRef(NULL); + ok(hr == S_OK, "got 0x%x (expected S_OK)\n", hr); + + /* build and set out object */ init_threadref(&ref, &refcount); AddRef_called = 0; refcount = 1; @@ -118,7 +123,7 @@ static void test_SHSetThreadRef(void) "got 0x%x with %d, %d (expected S_OK with 1, 0)\n", hr, refcount, AddRef_called); - /* Read back IUnkonwn */ + /* read back our object */ AddRef_called = 0; refcount = 1; punk = NULL; @@ -127,6 +132,15 @@ static void test_SHSetThreadRef(void) "got 0x%x and %p with %d, %d (expected S_OK and %p with 2, 1)\n", hr, punk, refcount, AddRef_called, &ref); + /* clear the onject pointer */ + hr = pSHSetThreadRef(NULL); + ok(hr == S_OK, "got 0x%x (expected S_OK)\n", hr); + + /* verify, that our object is no longer known as ThreadRef */ + hr = pSHGetThreadRef(&punk); + ok( (hr == E_NOINTERFACE) && (punk == NULL), + "got 0x%x and %p (expected E_NOINTERFACE and NULL)\n", hr, punk); + } START_TEST(thread) diff --git a/dlls/shlwapi/thread.c b/dlls/shlwapi/thread.c index cfe6615..fd9e4ba 100644 --- a/dlls/shlwapi/thread.c +++ b/dlls/shlwapi/thread.c @@ -131,13 +131,13 @@ typedef struct tagSHLWAPI_THREAD_INFO * * RETURNS * Success: S_OK. lppUnknown is set to the object reference. - * Failure: E_NOINTERFACE, if an error occurs or lppUnknown is NULL. + * Failure: E_NOINTERFACE, if an error occurs or no object is set */ HRESULT WINAPI SHGetThreadRef(IUnknown **lppUnknown) { TRACE("(%p)\n", lppUnknown); - if (!lppUnknown || SHLWAPI_ThreadRef_index == TLS_OUT_OF_INDEXES) + if (SHLWAPI_ThreadRef_index == TLS_OUT_OF_INDEXES) return E_NOINTERFACE; *lppUnknown = TlsGetValue(SHLWAPI_ThreadRef_index); @@ -159,13 +159,13 @@ HRESULT WINAPI SHGetThreadRef(IUnknown **lppUnknown) * * RETURNS * Success: S_OK. lpUnknown is stored and can be retrieved by SHGetThreadRef() - * Failure: E_NOINTERFACE, if an error occurs or lpUnknown is NULL. + * Failure: E_NOINTERFACE, if an error occurs */ HRESULT WINAPI SHSetThreadRef(IUnknown *lpUnknown) { TRACE("(%p)\n", lpUnknown); - if (!lpUnknown || SHLWAPI_ThreadRef_index == TLS_OUT_OF_INDEXES) + if (SHLWAPI_ThreadRef_index == TLS_OUT_OF_INDEXES) return E_NOINTERFACE; TlsSetValue(SHLWAPI_ThreadRef_index, lpUnknown);

1 0

Nikolay Sivov : shell32: Add ::GetDefaultColumnState() and partial :: GetDetailsOf() for printers folder.
by Alexandre Julliard 19 Apr '10

19 Apr '10

Module: wine Branch: master Commit: 506264becd71041ef96a9d26b56ae8ebd107f7e2 URL: http://source.winehq.org/git/wine.git/?a=commit;h=506264becd71041ef96a9d26b… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Sun Apr 18 18:00:31 2010 +0400 shell32: Add ::GetDefaultColumnState() and partial ::GetDetailsOf() for printers folder. --- dlls/shell32/regsvr.c | 7 ++++ dlls/shell32/shell32_En.rc | 4 ++ dlls/shell32/shfldr_printers.c | 51 ++++++++++++++++++++++++++--- dlls/shell32/shresdef.h | 4 ++ dlls/shell32/tests/shfldr_special.c | 59 +++++++++++++++++++++++++++++++++++ 5 files changed, 119 insertions(+), 6 deletions(-) diff --git a/dlls/shell32/regsvr.c b/dlls/shell32/regsvr.c index 8ae513f..b02c2ce 100644 --- a/dlls/shell32/regsvr.c +++ b/dlls/shell32/regsvr.c @@ -674,6 +674,13 @@ static struct regsvr_coclass const coclass_list[] = { SHELLFOLDER_WANTSFORDISPLAY|SHELLFOLDER_ATTRIBUTES|SHELLFOLDER_HIDEASDELETE, SFGAO_FOLDER|SFGAO_HASSUBFOLDER, }, + { &CLSID_Printers, + "Printers and Faxes", + 0, + NULL, + "shell32.dll", + "Apartment" + }, { NULL } /* list terminator */ }; diff --git a/dlls/shell32/shell32_En.rc b/dlls/shell32/shell32_En.rc index 6d68083..5ec5191 100644 --- a/dlls/shell32/shell32_En.rc +++ b/dlls/shell32/shell32_En.rc @@ -205,6 +205,10 @@ STRINGTABLE IDS_SHV_COLUMN11 "Group" IDS_SHV_COLUMN_DELFROM "Original location" IDS_SHV_COLUMN_DELDATE "Date deleted" + IDS_SHV_COL_DOCS "Documents" + IDS_SHV_COL_STATUS "Status" + IDS_SHV_COL_LOCATION "Location" + IDS_SHV_COL_MODEL "Model" /* special folders */ IDS_DESKTOP "Desktop" diff --git a/dlls/shell32/shfldr_printers.c b/dlls/shell32/shfldr_printers.c index 77e2439..b1d5939 100644 --- a/dlls/shell32/shfldr_printers.c +++ b/dlls/shell32/shfldr_printers.c @@ -19,6 +19,7 @@ */ #include <stdarg.h> +#include <stdio.h> #define COBJMACROS #define NONAMELESSUNION @@ -32,6 +33,9 @@ #include "wine/debug.h" #include "debughlp.h" +#include "shresdef.h" +#include "shfldr.h" + WINE_DEFAULT_DEBUG_CHANNEL (shell); typedef struct { @@ -45,6 +49,17 @@ static inline IPrintersFolderImpl *impl_from_IPersistFolder2(IPersistFolder2 *if return (IPrintersFolderImpl *)((char*)iface - FIELD_OFFSET(IPrintersFolderImpl, lpvtblPersistFolder2)); } +static const shvheader printers_header[] = { + { IDS_SHV_COLUMN8, SHCOLSTATE_TYPE_STR | SHCOLSTATE_ONBYDEFAULT, LVCFMT_LEFT, 20 }, + { IDS_SHV_COL_DOCS, SHCOLSTATE_TYPE_INT | SHCOLSTATE_ONBYDEFAULT, LVCFMT_LEFT, 12 }, + { IDS_SHV_COL_STATUS, SHCOLSTATE_TYPE_STR | SHCOLSTATE_ONBYDEFAULT, LVCFMT_LEFT, 12 }, + { IDS_SHV_COLUMN9, SHCOLSTATE_TYPE_STR | SHCOLSTATE_ONBYDEFAULT, LVCFMT_LEFT, 30 }, + { IDS_SHV_COL_LOCATION, SHCOLSTATE_TYPE_STR | SHCOLSTATE_ONBYDEFAULT, LVCFMT_LEFT, 20 }, + { IDS_SHV_COL_MODEL, SHCOLSTATE_TYPE_STR | SHCOLSTATE_ONBYDEFAULT, LVCFMT_LEFT, 20 } +}; + +#define PRINTERS_FOLDER_COL_NUM sizeof(printers_header)/sizeof(shvheader) + static HRESULT WINAPI IShellFolder_Printers_fnQueryInterface(IShellFolder2 *iface, REFIID riid, LPVOID *ppvObj) { @@ -255,11 +270,18 @@ static HRESULT WINAPI IShellFolder_Printers_fnGetDefaultColumn ( } static HRESULT WINAPI IShellFolder_Printers_fnGetDefaultColumnState ( - IShellFolder2 * iface, UINT iColumn, DWORD * pcsFlags) + IShellFolder2 *iface, UINT iColumn, DWORD *pcsFlags) { IPrintersFolderImpl *This = (IPrintersFolderImpl *)iface; - FIXME("(%p) stub\n", This); - return E_NOTIMPL; + + TRACE("(%p)->(%d %p)\n", This, iColumn, pcsFlags); + + if (iColumn >= PRINTERS_FOLDER_COL_NUM) + return E_INVALIDARG; + + *pcsFlags = printers_header[iColumn].pcsFlags; + + return S_OK; } static HRESULT WINAPI IShellFolder_Printers_fnGetDetailsEx (IShellFolder2 * iface, @@ -270,11 +292,28 @@ static HRESULT WINAPI IShellFolder_Printers_fnGetDetailsEx (IShellFolder2 * ifac return E_NOTIMPL; } -static HRESULT WINAPI IShellFolder_Printers_fnGetDetailsOf (IShellFolder2 * iface, - LPCITEMIDLIST pidl, UINT iColumn, SHELLDETAILS * psd) +static HRESULT WINAPI IShellFolder_Printers_fnGetDetailsOf (IShellFolder2 *iface, + LPCITEMIDLIST pidl, UINT iColumn, SHELLDETAILS *psd) { IPrintersFolderImpl *This = (IPrintersFolderImpl *)iface; - FIXME("(%p)->(%p %i %p) stub\n", This, pidl, iColumn, psd); + + TRACE("(%p)->(%p %i %p)\n", This, pidl, iColumn, psd); + + if (iColumn >= PRINTERS_FOLDER_COL_NUM) + return E_NOTIMPL; + + if (!pidl) + { + psd->fmt = printers_header[iColumn].fmt; + psd->cxChar = printers_header[iColumn].cxChar; + psd->str.uType = STRRET_CSTR; + LoadStringA (shell32_hInstance, printers_header[iColumn].colnameid, + psd->str.u.cStr, MAX_PATH); + return S_OK; + } + + FIXME("unimplemented for supplied pidl\n"); + return E_NOTIMPL; } diff --git a/dlls/shell32/shresdef.h b/dlls/shell32/shresdef.h index 2880135..88c93c8 100644 --- a/dlls/shell32/shresdef.h +++ b/dlls/shell32/shresdef.h @@ -42,6 +42,10 @@ #define IDS_SHV_COLUMN11 17 #define IDS_SHV_COLUMN_DELFROM 18 #define IDS_SHV_COLUMN_DELDATE 19 +#define IDS_SHV_COL_DOCS 80 +#define IDS_SHV_COL_STATUS 81 +#define IDS_SHV_COL_LOCATION 82 +#define IDS_SHV_COL_MODEL 83 #define IDS_DESKTOP 20 #define IDS_MYCOMPUTER 21 diff --git a/dlls/shell32/tests/shfldr_special.c b/dlls/shell32/tests/shfldr_special.c index 06533ba..e971270 100644 --- a/dlls/shell32/tests/shfldr_special.c +++ b/dlls/shell32/tests/shfldr_special.c @@ -23,6 +23,9 @@ #include <stdio.h> #define COBJMACROS +#define NONAMELESSUNION +#define NONAMELESSSTRUCT + #define WIN32_LEAN_AND_MEAN #include <windows.h> #include "shellapi.h" @@ -119,9 +122,65 @@ static void test_parse_for_control_panel(void) ILFree(pidl); } +static void test_printers_folder(void) +{ + IShellFolder2 *folder; + SHELLDETAILS details; + SHCOLSTATEF state; + INT i; + HRESULT hr; + + CoInitialize( NULL ); + + hr = CoCreateInstance(&CLSID_Printers, NULL, CLSCTX_INPROC_SERVER, &IID_IShellFolder2, (void**)&folder); + if (hr != S_OK) + { + win_skip("Failed to created IShellFolder2 for Printers folder\n"); + CoUninitialize(); + return; + } + +if (0) +{ + /* crashes on XP */ + hr = IShellFolder2_GetDetailsOf(folder, NULL, 0, NULL); + hr = IShellFolder2_GetDefaultColumnState(folder, 0, NULL); +} + + /* 5 columns defined */ + hr = IShellFolder2_GetDetailsOf(folder, NULL, 6, &details); + ok(hr == E_NOTIMPL, "got 0x%08x\n", hr); + + hr = IShellFolder2_GetDefaultColumnState(folder, 6, &state); + ok(broken(hr == E_NOTIMPL) || hr == E_INVALIDARG /* Win7 */, "got 0x%08x\n", hr); + + for(i = 0; i < 6; i++) + { + hr = IShellFolder2_GetDetailsOf(folder, NULL, i, &details); + /* doesn't work on W2K */ + if (hr == E_NOTIMPL) break; + + ok(hr == S_OK, "got 0x%08x\n", hr); + /* all columns are left-aligned */ + ok(details.fmt == LVCFMT_LEFT, "got 0x%x\n", details.fmt); + + hr = IShellFolder2_GetDefaultColumnState(folder, i, &state); + ok(hr == S_OK, "got 0x%08x\n", hr); + /* all columns are string except document count */ + if (i == 1) + ok(state == (SHCOLSTATE_TYPE_INT | SHCOLSTATE_ONBYDEFAULT), "got 0x%x\n", state); + else + ok(state == (SHCOLSTATE_TYPE_STR | SHCOLSTATE_ONBYDEFAULT), "got 0x%x\n", state); + } + + IShellFolder2_Release(folder); + + CoUninitialize(); +} START_TEST(shfldr_special) { test_parse_for_entire_network(); test_parse_for_control_panel(); + test_printers_folder(); }

1 0

Nikolay Sivov : shell32: Use shared code to return column details from IShellFolder2::GetDetailsOf( ).
by Alexandre Julliard 19 Apr '10

19 Apr '10

Module: wine Branch: master Commit: e51fe8e070b1a4c464c5a8dccb977aa132f070e7 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e51fe8e070b1a4c464c5a8dcc… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Sun Apr 18 18:04:25 2010 +0400 shell32: Use shared code to return column details from IShellFolder2::GetDetailsOf(). --- dlls/shell32/shfldr.h | 3 +- dlls/shell32/shfldr_desktop.c | 15 ++---- dlls/shell32/shfldr_mycomp.c | 42 ++++++--------- dlls/shell32/shfldr_netplaces.c | 29 ++++++----- dlls/shell32/shfldr_printers.c | 9 +--- dlls/shell32/shfldr_unixfs.c | 106 +++++++++++++++++++-------------------- dlls/shell32/shlfolder.c | 12 ++++ 7 files changed, 104 insertions(+), 112 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=e51fe8e070b1a4c464c5a…

1 0

Nikolay Sivov : shell32: Add ::Initialize() and ::GetCurFolder() for printers folder IPersistFolder2 interface.
by Alexandre Julliard 19 Apr '10

19 Apr '10

Module: wine Branch: master Commit: 90a5529de8aa7f376945df620bd604e6696a4b69 URL: http://source.winehq.org/git/wine.git/?a=commit;h=90a5529de8aa7f376945df620… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Sun Apr 18 18:14:47 2010 +0400 shell32: Add ::Initialize() and ::GetCurFolder() for printers folder IPersistFolder2 interface. --- dlls/shell32/shfldr_printers.c | 21 +++++++++++++++++---- dlls/shell32/tests/shfldr_special.c | 27 +++++++++++++++++++++++++++ 2 files changed, 44 insertions(+), 4 deletions(-) diff --git a/dlls/shell32/shfldr_printers.c b/dlls/shell32/shfldr_printers.c index 7bb954e..66fa571 100644 --- a/dlls/shell32/shfldr_printers.c +++ b/dlls/shell32/shfldr_printers.c @@ -42,6 +42,8 @@ typedef struct { const IShellFolder2Vtbl *lpVtbl; const IPersistFolder2Vtbl *lpvtblPersistFolder2; LONG ref; + + LPITEMIDLIST pidl; } IPrintersFolderImpl; static inline IPrintersFolderImpl *impl_from_IPersistFolder2(IPersistFolder2 *iface) @@ -111,6 +113,7 @@ static ULONG WINAPI IShellFolder_Printers_fnRelease (IShellFolder2 * iface) if (!refCount) { TRACE ("-- destroying IShellFolder(%p)\n", This); + SHFree(This->pidl); LocalFree (This); } return refCount; @@ -380,15 +383,24 @@ static HRESULT WINAPI IPersistFolder2_Printers_fnGetClassID(IPersistFolder2 *ifa static HRESULT WINAPI IPersistFolder2_Printers_fnInitialize(IPersistFolder2 *iface, LPCITEMIDLIST pidl) { IPrintersFolderImpl *This = impl_from_IPersistFolder2(iface); - FIXME("(%p) stub\n", This); - return E_NOTIMPL; + + TRACE("(%p)->(%p)\n", This, pidl); + + SHFree(This->pidl); + This->pidl = ILClone(pidl); + + return S_OK; } static HRESULT WINAPI IPersistFolder2_Printers_fnGetCurFolder(IPersistFolder2 *iface, LPITEMIDLIST *pidl) { IPrintersFolderImpl *This = impl_from_IPersistFolder2(iface); - FIXME("(%p) stub\n", This); - return E_NOTIMPL; + + TRACE("(%p)->(%p)\n", This, pidl); + + *pidl = ILClone(This->pidl); + + return *pidl ? S_OK : S_FALSE; } static const IPersistFolder2Vtbl vtbl_PersistFolder2 = @@ -417,6 +429,7 @@ HRESULT WINAPI Printers_Constructor(IUnknown * pUnkOuter, REFIID riid, LPVOID * return E_OUTOFMEMORY; sf->ref = 0; + sf->pidl = NULL; sf->lpVtbl = &vtbl_ShellFolder2; sf->lpvtblPersistFolder2 = &vtbl_PersistFolder2; diff --git a/dlls/shell32/tests/shfldr_special.c b/dlls/shell32/tests/shfldr_special.c index e971270..3320130 100644 --- a/dlls/shell32/tests/shfldr_special.c +++ b/dlls/shell32/tests/shfldr_special.c @@ -125,8 +125,10 @@ static void test_parse_for_control_panel(void) static void test_printers_folder(void) { IShellFolder2 *folder; + IPersistFolder2 *pf; SHELLDETAILS details; SHCOLSTATEF state; + LPITEMIDLIST pidl1, pidl2; INT i; HRESULT hr; @@ -145,6 +147,7 @@ if (0) /* crashes on XP */ hr = IShellFolder2_GetDetailsOf(folder, NULL, 0, NULL); hr = IShellFolder2_GetDefaultColumnState(folder, 0, NULL); + hr = IPersistFolder2_GetCurFolder(pf, NULL); } /* 5 columns defined */ @@ -173,6 +176,30 @@ if (0) ok(state == (SHCOLSTATE_TYPE_STR | SHCOLSTATE_ONBYDEFAULT), "got 0x%x\n", state); } + /* default pidl */ + hr = IShellFolder2_QueryInterface(folder, &IID_IPersistFolder2, (void**)&pf); + ok(hr == S_OK, "got 0x%08x\n", hr); + + /* not initialized */ + pidl1 = (void*)0xdeadbeef; + hr = IPersistFolder2_GetCurFolder(pf, &pidl1); + ok(hr == S_FALSE, "got 0x%08x\n", hr); + ok(pidl1 == NULL, "got %p\n", pidl1); + + hr = SHGetSpecialFolderLocation(NULL, CSIDL_PRINTERS, &pidl2); + ok(hr == S_OK, "got 0x%08x\n", hr); + + hr = IPersistFolder2_Initialize(pf, pidl2); + ok(hr == S_OK, "got 0x%08x\n", hr); + + hr = IPersistFolder2_GetCurFolder(pf, &pidl1); + ok(hr == S_OK, "got 0x%08x\n", hr); + + ok(ILIsEqual(pidl1, pidl2), "expected same PIDL\n"); + IPersistFolder2_Release(pf); + + ILFree(pidl1); + ILFree(pidl2); IShellFolder2_Release(folder); CoUninitialize();

1 0

Nikolay Sivov : shell32: Add printers CLSID to test, clean up a bit.
by Alexandre Julliard 19 Apr '10

19 Apr '10

Module: wine Branch: master Commit: c51b248b48b528c05ba51f6efb0123cb397b8638 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c51b248b48b528c05ba51f6ef… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Sun Apr 18 18:31:52 2010 +0400 shell32: Add printers CLSID to test, clean up a bit. --- dlls/shell32/tests/shellpath.c | 297 +++++++++++++++++----------------------- 1 files changed, 126 insertions(+), 171 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=c51b248b48b528c05ba51…

1 0

Piotr Caban : msvcrt/tests: Added __crtGetStringTypeW tests.
by Alexandre Julliard 19 Apr '10

19 Apr '10

Module: wine Branch: master Commit: 0d79b4b6539a1e162a24c00e727e8a3cbc11391a URL: http://source.winehq.org/git/wine.git/?a=commit;h=0d79b4b6539a1e162a24c00e7… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Mon Apr 19 10:58:40 2010 +0200 msvcrt/tests: Added __crtGetStringTypeW tests. --- dlls/msvcrt/tests/locale.c | 61 ++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 61 insertions(+), 0 deletions(-) diff --git a/dlls/msvcrt/tests/locale.c b/dlls/msvcrt/tests/locale.c index ce44347..45ab9b7 100644 --- a/dlls/msvcrt/tests/locale.c +++ b/dlls/msvcrt/tests/locale.c @@ -19,7 +19,20 @@ */ #include <locale.h> + #include "wine/test.h" +#include "winnls.h" + +static BOOL (__cdecl *p__crtGetStringTypeW)(DWORD, DWORD, const wchar_t*, int, WORD*); +static int (__cdecl *pmemcpy_s)(void *, size_t, void*, size_t); + +static void init(void) +{ + HMODULE hmod = GetModuleHandleA("msvcrt.dll"); + + p__crtGetStringTypeW = (void*)GetProcAddress(hmod, "__crtGetStringTypeW"); + pmemcpy_s = (void*)GetProcAddress(hmod, "memcpy_s"); +} static void test_setlocale(void) { @@ -75,7 +88,55 @@ static void test_setlocale(void) ok(!strcmp(ret, "English_United States.1252"), "ret = %s\n", ret); } +static void test_crtGetStringTypeW(void) +{ + static const wchar_t str0[] = { '0', '\0' }; + static const wchar_t strA[] = { 'A', '\0' }; + static const wchar_t str_space[] = { ' ', '\0' }; + static const wchar_t str_null[] = { '\0', '\0' }; + static const wchar_t str_rand[] = { 1234, '\0' }; + + const wchar_t *str[] = { str0, strA, str_space, str_null, str_rand }; + + WORD out_crt, out; + BOOL ret_crt, ret; + int i; + + if(!p__crtGetStringTypeW) { + win_skip("Skipping __crtGetStringTypeW tests\n"); + return; + } + + if(!pmemcpy_s) { + win_skip("To old version of msvcrt.dll\n"); + return; + } + + for(i=0; i<sizeof(str)/sizeof(*str); i++) { + ret_crt = p__crtGetStringTypeW(0, CT_CTYPE1, str[i], 1, &out_crt); + ret = GetStringTypeW(CT_CTYPE1, str[i], 1, &out); + ok(ret == ret_crt, "%d) ret_crt = %d\n", i, (int)ret_crt); + ok(out == out_crt, "%d) out_crt = %x, expected %x\n", i, (int)out_crt, (int)out); + + ret_crt = p__crtGetStringTypeW(0, CT_CTYPE2, str[i], 1, &out_crt); + ret = GetStringTypeW(CT_CTYPE2, str[i], 1, &out); + ok(ret == ret_crt, "%d) ret_crt = %d\n", i, (int)ret_crt); + ok(out == out_crt, "%d) out_crt = %x, expected %x\n", i, (int)out_crt, (int)out); + + ret_crt = p__crtGetStringTypeW(0, CT_CTYPE3, str[i], 1, &out_crt); + ret = GetStringTypeW(CT_CTYPE3, str[i], 1, &out); + ok(ret == ret_crt, "%d) ret_crt = %d\n", i, (int)ret_crt); + ok(out == out_crt, "%d) out_crt = %x, expected %x\n", i, (int)out_crt, (int)out); + } + + ret = p__crtGetStringTypeW(0, 3, str[0], 1, &out); + ok(!ret, "ret == TRUE\n"); +} + START_TEST(locale) { + init(); + + test_crtGetStringTypeW(); test_setlocale(); }

1 0

Piotr Caban : msvcrt: Return correct strings in setlocale.
by Alexandre Julliard 19 Apr '10

19 Apr '10

Module: wine Branch: master Commit: 8adfd63c2156a95bf5eddb2b283cfd14ff195da3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=8adfd63c2156a95bf5eddb2b2… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Mon Apr 19 10:58:51 2010 +0200 msvcrt: Return correct strings in setlocale. --- dlls/msvcrt/locale.c | 52 ++++++++++++++++++++++++++++++------------- dlls/msvcrt/tests/locale.c | 4 +- 2 files changed, 38 insertions(+), 18 deletions(-) diff --git a/dlls/msvcrt/locale.c b/dlls/msvcrt/locale.c index fe77b83..84bd73b 100644 --- a/dlls/msvcrt/locale.c +++ b/dlls/msvcrt/locale.c @@ -348,6 +348,32 @@ MSVCRT__locale_t get_locale(void) { return data->locale; } +/* INTERNAL: constructs string returned by setlocale */ +static inline char* construct_lc_all(MSVCRT__locale_t cur) { + static char current_lc_all[MAX_LOCALE_LENGTH]; + + int i; + + for(i=MSVCRT_LC_MIN+1; i<MSVCRT_LC_MAX; i++) { + if(strcmp(cur->locinfo->lc_category[i].locale, + cur->locinfo->lc_category[i+1].locale)) + break; + } + + if(i==MSVCRT_LC_MAX) + return cur->locinfo->lc_category[MSVCRT_LC_COLLATE].locale; + + sprintf(current_lc_all, + "LC_COLLATE=%s;LC_CTYPE=%s;LC_MONETARY=%s;LC_NUMERIC=%s;LC_TIME=%s", + cur->locinfo->lc_category[MSVCRT_LC_COLLATE].locale, + cur->locinfo->lc_category[MSVCRT_LC_CTYPE].locale, + cur->locinfo->lc_category[MSVCRT_LC_MONETARY].locale, + cur->locinfo->lc_category[MSVCRT_LC_NUMERIC].locale, + cur->locinfo->lc_category[MSVCRT_LC_TIME].locale); + + return current_lc_all; +} + /********************************************************************* * wsetlocale (MSVCRT.@) @@ -1020,31 +1046,25 @@ int CDECL _configthreadlocale(int type) */ char* CDECL MSVCRT_setlocale(int category, const char* locale) { - static char current_lc_all[MAX_LOCALE_LENGTH]; - MSVCRT__locale_t loc, cur; cur = get_locale(); - if(locale == NULL) { - if(category == MSVCRT_LC_ALL) { - sprintf(current_lc_all, - "LC_COLLATE=%s;LC_CTYPE=%s;LC_MONETARY=%s;LC_NUMERIC=%s;LC_TIME=%s", - cur->locinfo->lc_category[MSVCRT_LC_COLLATE].locale, - cur->locinfo->lc_category[MSVCRT_LC_CTYPE].locale, - cur->locinfo->lc_category[MSVCRT_LC_MONETARY].locale, - cur->locinfo->lc_category[MSVCRT_LC_NUMERIC].locale, - cur->locinfo->lc_category[MSVCRT_LC_TIME].locale); - - return current_lc_all; - } + if(category<MSVCRT_LC_MIN || category>MSVCRT_LC_MAX) + return NULL; + + if(!locale) { + if(category == MSVCRT_LC_ALL) + return construct_lc_all(cur); return cur->locinfo->lc_category[category].locale; } loc = _create_locale(category, locale); - if(!loc) + if(!loc) { + WARN("%d %s failed\n", category, locale); return NULL; + } LOCK_LOCALE; @@ -1163,7 +1183,7 @@ char* CDECL MSVCRT_setlocale(int category, const char* locale) } if(category == MSVCRT_LC_ALL) - return cur->locinfo->lc_category[MSVCRT_LC_COLLATE].locale; + return construct_lc_all(cur); return cur->locinfo->lc_category[category].locale; } diff --git a/dlls/msvcrt/tests/locale.c b/dlls/msvcrt/tests/locale.c index 45ab9b7..4c4b7a9 100644 --- a/dlls/msvcrt/tests/locale.c +++ b/dlls/msvcrt/tests/locale.c @@ -51,7 +51,7 @@ static void test_setlocale(void) ok(!strcmp(ret, "C"), "ret = %s\n", ret); ret = setlocale(LC_ALL, NULL); - todo_wine ok(!strcmp(ret, "C"), "ret = %s\n", ret); + ok(!strcmp(ret, "C"), "ret = %s\n", ret); if(!setlocale(LC_NUMERIC, "Polish") || !setlocale(LC_NUMERIC, "Greek") @@ -72,7 +72,7 @@ static void test_setlocale(void) strcpy(buf, ret); ret = setlocale(LC_ALL, buf); - todo_wine ok(!strcmp(ret, lc_all), "ret = %s\n", ret); + ok(!strcmp(ret, lc_all), "ret = %s\n", ret); ret = setlocale(LC_ALL, "German"); todo_wine ok(!strcmp(ret, "German_Germany.1252"), "ret = %s\n", ret);

1 0