April 2010 - Wine-commits - list.winehq.org

Vincent Povirk : gdiplus: Implement color remapping.
by Alexandre Julliard 16 Apr '10

16 Apr '10

Module: wine Branch: master Commit: 424724778705069fd85d207518317cb2f778f275 URL: http://source.winehq.org/git/wine.git/?a=commit;h=424724778705069fd85d20751… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Thu Apr 15 15:24:25 2010 -0500 gdiplus: Implement color remapping. --- dlls/gdiplus/graphics.c | 32 +++++++++++++++++++++++++++++++- dlls/gdiplus/tests/image.c | 2 +- 2 files changed, 32 insertions(+), 2 deletions(-) diff --git a/dlls/gdiplus/graphics.c b/dlls/gdiplus/graphics.c index b0cba47..8efa128 100644 --- a/dlls/gdiplus/graphics.c +++ b/dlls/gdiplus/graphics.c @@ -1995,7 +1995,8 @@ GpStatus WINGDIPAPI GdipDrawImagePointsRect(GpGraphics *graphics, GpImage *image else return NotImplemented; - if (ptf[1].Y != ptf[0].Y || ptf[2].X != ptf[0].X) + if (imageAttributes || + ptf[1].Y != ptf[0].Y || ptf[2].X != ptf[0].X) use_software = 1; else if (graphics->image && graphics->image->type == ImageTypeBitmap) { @@ -2084,6 +2085,35 @@ GpStatus WINGDIPAPI GdipDrawImagePointsRect(GpGraphics *graphics, GpImage *image GdipDeleteMatrix(dst_to_src); + if (imageAttributes) + { + if (imageAttributes->colorremaptables[ColorAdjustTypeBitmap].enabled || + imageAttributes->colorremaptables[ColorAdjustTypeDefault].enabled) + { + const struct color_remap_table *table; + + if (imageAttributes->colorremaptables[ColorAdjustTypeBitmap].enabled) + table = &imageAttributes->colorremaptables[ColorAdjustTypeBitmap]; + else + table = &imageAttributes->colorremaptables[ColorAdjustTypeDefault]; + + for (x=dst_area.left; x<dst_area.right; x++) + for (y=dst_area.top; y<dst_area.bottom; y++) + { + ARGB *src_color; + src_color = (ARGB*)(data + stride * (y - dst_area.top) + sizeof(ARGB) * (x - dst_area.left)); + for (i=0; i<table->mapsize; i++) + { + if (*src_color == table->colormap[i].oldColor.Argb) + { + *src_color = table->colormap[i].newColor.Argb; + break; + } + } + } + } + } + stat = alpha_blend_pixels(graphics, dst_area.left, dst_area.top, data, dst_area.right - dst_area.left, dst_area.bottom - dst_area.top, stride); diff --git a/dlls/gdiplus/tests/image.c b/dlls/gdiplus/tests/image.c index fdfd2b2..74e6ee1 100644 --- a/dlls/gdiplus/tests/image.c +++ b/dlls/gdiplus/tests/image.c @@ -1879,7 +1879,7 @@ static void test_remaptable(void) stat = GdipBitmapGetPixel(bitmap2, 0, 0, &color); expect(Ok, stat); - todo_wine ok(color_match(0xffff00ff, color, 1), "Expected ffff00ff, got %.8x\n", color); + ok(color_match(0xffff00ff, color, 1), "Expected ffff00ff, got %.8x\n", color); GdipDeleteGraphics(graphics); GdipDisposeImage((GpImage*)bitmap1);

1 0

Vincent Povirk : gdiplus: Always use software to draw bitmaps to bitmaps.
by Alexandre Julliard 16 Apr '10

16 Apr '10

Module: wine Branch: master Commit: 8b2543b7503e7bb1b7db1d3a32cad88d70cf3e6e URL: http://source.winehq.org/git/wine.git/?a=commit;h=8b2543b7503e7bb1b7db1d3a3… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Thu Apr 15 15:26:15 2010 -0500 gdiplus: Always use software to draw bitmaps to bitmaps. --- dlls/gdiplus/graphics.c | 9 +-------- 1 files changed, 1 insertions(+), 8 deletions(-) diff --git a/dlls/gdiplus/graphics.c b/dlls/gdiplus/graphics.c index 8efa128..94623db 100644 --- a/dlls/gdiplus/graphics.c +++ b/dlls/gdiplus/graphics.c @@ -1996,16 +1996,9 @@ GpStatus WINGDIPAPI GdipDrawImagePointsRect(GpGraphics *graphics, GpImage *image return NotImplemented; if (imageAttributes || + (graphics->image && graphics->image->type == ImageTypeBitmap) || ptf[1].Y != ptf[0].Y || ptf[2].X != ptf[0].X) use_software = 1; - else if (graphics->image && graphics->image->type == ImageTypeBitmap) - { - GpBitmap *dst_bitmap = (GpBitmap*)graphics->image; - if (!(dst_bitmap->format == PixelFormat16bppRGB555 || - dst_bitmap->format == PixelFormat24bppRGB || - dst_bitmap->format == PixelFormat32bppRGB)) - use_software = 1; - } if (use_software) {

1 0

Vincent Povirk : gdiplus: Add fixmes for unimplemented imageattributes features.
by Alexandre Julliard 16 Apr '10

16 Apr '10

Module: wine Branch: master Commit: ede103c699726b6480212a9bdc7e9dc16927f28b URL: http://source.winehq.org/git/wine.git/?a=commit;h=ede103c699726b6480212a9bd… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Thu Apr 15 15:31:45 2010 -0500 gdiplus: Add fixmes for unimplemented imageattributes features. --- dlls/gdiplus/graphics.c | 24 ++++++++++++++++++++++++ 1 files changed, 24 insertions(+), 0 deletions(-) diff --git a/dlls/gdiplus/graphics.c b/dlls/gdiplus/graphics.c index 94623db..7a6fad3 100644 --- a/dlls/gdiplus/graphics.c +++ b/dlls/gdiplus/graphics.c @@ -2080,6 +2080,14 @@ GpStatus WINGDIPAPI GdipDrawImagePointsRect(GpGraphics *graphics, GpImage *image if (imageAttributes) { + if (imageAttributes->colorkeys[ColorAdjustTypeBitmap].enabled || + imageAttributes->colorkeys[ColorAdjustTypeDefault].enabled) + { + static int fixme; + if (!fixme++) + FIXME("Color keying not implemented\n"); + } + if (imageAttributes->colorremaptables[ColorAdjustTypeBitmap].enabled || imageAttributes->colorremaptables[ColorAdjustTypeDefault].enabled) { @@ -2105,6 +2113,22 @@ GpStatus WINGDIPAPI GdipDrawImagePointsRect(GpGraphics *graphics, GpImage *image } } } + + if (imageAttributes->colormatrices[ColorAdjustTypeBitmap].enabled || + imageAttributes->colormatrices[ColorAdjustTypeDefault].enabled) + { + static int fixme; + if (!fixme++) + FIXME("Color transforms not implemented\n"); + } + + if (imageAttributes->gamma_enabled[ColorAdjustTypeBitmap] || + imageAttributes->gamma_enabled[ColorAdjustTypeDefault]) + { + static int fixme; + if (!fixme++) + FIXME("Gamma adjustment not implemented\n"); + } } stat = alpha_blend_pixels(graphics, dst_area.left, dst_area.top,

1 0

Piotr Caban : msvcrt: Change localeconv implementation.
by Alexandre Julliard 16 Apr '10

16 Apr '10

Module: wine Branch: master Commit: f2f56d563f68c71b709b829a84806895b6c7d4cd URL: http://source.winehq.org/git/wine.git/?a=commit;h=f2f56d563f68c71b709b829a8… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Thu Apr 15 23:13:18 2010 +0200 msvcrt: Change localeconv implementation. --- dlls/msvcrt/locale.c | 33 +-------------------------------- 1 files changed, 1 insertions(+), 32 deletions(-) diff --git a/dlls/msvcrt/locale.c b/dlls/msvcrt/locale.c index 59d94ae..e8af46b 100644 --- a/dlls/msvcrt/locale.c +++ b/dlls/msvcrt/locale.c @@ -462,38 +462,7 @@ int CDECL __crtGetLocaleInfoW( LCID lcid, LCTYPE type, MSVCRT_wchar_t *buffer, i */ struct MSVCRT_lconv * CDECL MSVCRT_localeconv(void) { - static struct MSVCRT_lconv xlconv; - struct lconv *ylconv = localeconv(); - - xlconv.decimal_point = ylconv->decimal_point; - xlconv.thousands_sep = ylconv->thousands_sep; - xlconv.grouping = ylconv->grouping; /* FIXME: fixup charmax here too */ - xlconv.int_curr_symbol = ylconv->int_curr_symbol; - xlconv.currency_symbol = ylconv->currency_symbol; - xlconv.mon_decimal_point = ylconv->mon_decimal_point; - xlconv.mon_thousands_sep = ylconv->mon_thousands_sep; - xlconv.mon_grouping = ylconv->mon_grouping; - xlconv.positive_sign = ylconv->positive_sign; - xlconv.negative_sign = ylconv->negative_sign; - xlconv.int_frac_digits = ylconv->int_frac_digits; - xlconv.frac_digits = ylconv->frac_digits; - xlconv.p_cs_precedes = ylconv->p_cs_precedes; - xlconv.p_sep_by_space = ylconv->p_sep_by_space; - xlconv.n_cs_precedes = ylconv->n_cs_precedes; - xlconv.n_sep_by_space = ylconv->n_sep_by_space; - xlconv.p_sign_posn = ylconv->p_sign_posn; - xlconv.n_sign_posn = ylconv->n_sign_posn; - - if (ylconv->int_frac_digits == CHAR_MAX) xlconv.int_frac_digits = charmax; - if (ylconv->frac_digits == CHAR_MAX) xlconv.frac_digits = charmax; - if (ylconv->p_cs_precedes == CHAR_MAX) xlconv.p_cs_precedes = charmax; - if (ylconv->p_sep_by_space == CHAR_MAX) xlconv.p_sep_by_space = charmax; - if (ylconv->n_cs_precedes == CHAR_MAX) xlconv.n_cs_precedes = charmax; - if (ylconv->n_sep_by_space == CHAR_MAX) xlconv.n_sep_by_space = charmax; - if (ylconv->p_sign_posn == CHAR_MAX) xlconv.p_sign_posn = charmax; - if (ylconv->n_sign_posn == CHAR_MAX) xlconv.n_sign_posn = charmax; - - return &xlconv; + return get_locale()->locinfo->lconv; } /*********************************************************************

1 0

Piotr Caban : msvcrt: Fix locale initialization.
by Alexandre Julliard 16 Apr '10

16 Apr '10

Module: wine Branch: master Commit: 2548742bb49812aaa6c24dea2d51d092bd3d62e6 URL: http://source.winehq.org/git/wine.git/?a=commit;h=2548742bb49812aaa6c24dea2… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Thu Apr 15 23:13:59 2010 +0200 msvcrt: Fix locale initialization. --- dlls/msvcrt/main.c | 8 +++----- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/dlls/msvcrt/main.c b/dlls/msvcrt/main.c index e2184b3..272ba71 100644 --- a/dlls/msvcrt/main.c +++ b/dlls/msvcrt/main.c @@ -87,16 +87,14 @@ BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) switch (fdwReason) { case DLL_PROCESS_ATTACH: + if (!msvcrt_init_tls()) + return FALSE; msvcrt_init_mt_locks(); if(!MSVCRT_setlocale(0, "C")) { msvcrt_free_mt_locks(); + msvcrt_free_tls_mem(); return FALSE; } - if (!msvcrt_init_tls()) { - _free_locale(MSVCRT_locale); - msvcrt_free_mt_locks(); - return FALSE; - } msvcrt_init_io(); msvcrt_init_console(); msvcrt_init_args();

1 0

Roderick Colenbrander : wined3d: Separate AMD Radeon HD2300 from other HD2xxx/ HD3xxx GPUs since it is D3D9 instead of D3D10.
by Alexandre Julliard 16 Apr '10

16 Apr '10

Module: wine Branch: master Commit: 057c64c5b08d726340f41d5270abe8ab3d493609 URL: http://source.winehq.org/git/wine.git/?a=commit;h=057c64c5b08d726340f41d527… Author: Roderick Colenbrander <thunderbird2k(a)gmail.com> Date: Fri Apr 16 08:49:40 2010 +0200 wined3d: Separate AMD Radeon HD2300 from other HD2xxx/HD3xxx GPUs since it is D3D9 instead of D3D10. --- dlls/wined3d/directx.c | 30 ++++++++++++++++++------------ dlls/wined3d/wined3d_private.h | 2 +- 2 files changed, 19 insertions(+), 13 deletions(-) diff --git a/dlls/wined3d/directx.c b/dlls/wined3d/directx.c index 6498859..7e22dbc 100644 --- a/dlls/wined3d/directx.c +++ b/dlls/wined3d/directx.c @@ -1021,7 +1021,7 @@ static const struct driver_version_information driver_version_table[] = {HW_VENDOR_ATI, CARD_ATI_RADEON_9500, "ATI Radeon 9500", 14, 10, 6764 }, {HW_VENDOR_ATI, CARD_ATI_RADEON_X700, "ATI Radeon X700 SE", 14, 10, 6764 }, {HW_VENDOR_ATI, CARD_ATI_RADEON_X1600, "ATI Radeon X1600 Series", 14, 10, 6764 }, - {HW_VENDOR_ATI, CARD_ATI_RADEON_HD2300, "ATI Mobility Radeon HD 2300", 14, 10, 6764 }, + {HW_VENDOR_ATI, CARD_ATI_RADEON_HD2350, "ATI Mobility Radeon HD 2350", 14, 10, 6764 }, {HW_VENDOR_ATI, CARD_ATI_RADEON_HD2600, "ATI Mobility Radeon HD 2600", 14, 10, 6764 }, {HW_VENDOR_ATI, CARD_ATI_RADEON_HD2900, "ATI Radeon HD 2900 XT", 14, 10, 6764 }, {HW_VENDOR_ATI, CARD_ATI_RADEON_HD4350, "ATI Radeon HD 4350", 14, 10, 6764 }, @@ -1581,16 +1581,17 @@ static enum wined3d_pci_device select_card_ati_binary(const struct wined3d_gl_in return CARD_ATI_RADEON_HD2600; } - /* Radeon R6xx HD2300/HD2400/HD3400 - lowend */ - if (strstr(gl_renderer, "HD 2300") + /* Radeon R6xx HD2350/HD2400/HD3400 - lowend + * Note HD2300=DX9, HD2350=DX10 */ + if (strstr(gl_renderer, "HD 2350") || strstr(gl_renderer, "HD 2400") || strstr(gl_renderer, "HD 3470") || strstr(gl_renderer, "HD 3450") || strstr(gl_renderer, "HD 3430") || strstr(gl_renderer, "HD 3400")) { - *vidmem = 128; /* HD2300 uses at least 128MB, HD2400 uses 256MB */ - return CARD_ATI_RADEON_HD2300; + *vidmem = 256; /* HD2350/2400 use 256MB, HD34xx use 256-512MB */ + return CARD_ATI_RADEON_HD2350; } /* Radeon R6xx/R7xx integrated */ @@ -1613,14 +1614,19 @@ static enum wined3d_pci_device select_card_ati_binary(const struct wined3d_gl_in return CARD_ATI_RADEON_X1600; } - /* Radeon R4xx + X1300/X1400/X1450/X1550/X2300 (lowend R5xx) */ + /* Radeon R4xx + X1300/X1400/X1450/X1550/X2300/X2500/HD2300 (lowend R5xx) + * Note X2300/X2500/HD2300 are R5xx GPUs with a 2xxx naming but they are still DX9-only */ if (strstr(gl_renderer, "X700") || strstr(gl_renderer, "X800") || strstr(gl_renderer, "X850") || strstr(gl_renderer, "X1300") || strstr(gl_renderer, "X1400") || strstr(gl_renderer, "X1450") - || strstr(gl_renderer, "X1550")) + || strstr(gl_renderer, "X1550") + || strstr(gl_renderer, "X2300") + || strstr(gl_renderer, "X2500") + || strstr(gl_renderer, "HD 2300") + ) { *vidmem = 128; /* x700/x8*0 use 128-256MB, >=x1300 128-512MB */ return CARD_ATI_RADEON_X700; @@ -1737,12 +1743,12 @@ static enum wined3d_pci_device select_card_ati_mesa(const struct wined3d_gl_info return CARD_ATI_RADEON_HD2600; } - /* Radeon R6xx HD2300/HD2400/HD3400 - lowend */ + /* Radeon R6xx HD2350/HD2400/HD3400 - lowend */ if (strstr(gl_renderer, "RV610") || strstr(gl_renderer, "RV620")) { - *vidmem = 128; /* HD2300 uses at least 128MB, HD2400 uses 256MB */ - return CARD_ATI_RADEON_HD2300; + *vidmem = 256; /* HD2350/2400 use 256MB, HD34xx use 256-512MB */ + return CARD_ATI_RADEON_HD2350; } /* Radeon R6xx/R7xx integrated */ @@ -1860,8 +1866,8 @@ static enum wined3d_pci_device select_card_ati_mesa(const struct wined3d_gl_info if (strstr(gl_renderer, "(RV610") || strstr(gl_renderer, "(RV620")) { - *vidmem = 128; /* HD2300 uses at least 128MB, HD2400 uses 256MB */ - return CARD_ATI_RADEON_HD2300; + *vidmem = 256; /* HD2350/2400 use 256MB, HD34xx use 256-512MB */ + return CARD_ATI_RADEON_HD2350; } /* Radeon R6xx/R7xx integrated */ diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h index 31ed565..460c2b3 100644 --- a/dlls/wined3d/wined3d_private.h +++ b/dlls/wined3d/wined3d_private.h @@ -1301,7 +1301,7 @@ enum wined3d_pci_device CARD_ATI_RADEON_XPRESS_200M = 0x5955, CARD_ATI_RADEON_X700 = 0x5e4c, CARD_ATI_RADEON_X1600 = 0x71c2, - CARD_ATI_RADEON_HD2300 = 0x7210, + CARD_ATI_RADEON_HD2350 = 0x94c7, CARD_ATI_RADEON_HD2600 = 0x9581, CARD_ATI_RADEON_HD2900 = 0x9400, CARD_ATI_RADEON_HD3200 = 0x9620,

1 0

Roderick Colenbrander : wined3d: Separate AMD GPUs in D3D9 and D3D10 models , this allows for a more correct fall back when the GPU table isn' t up to date.
by Alexandre Julliard 16 Apr '10

16 Apr '10

Module: wine Branch: master Commit: 3b993117c3d60edd033ee2494082a12c5d3c131c URL: http://source.winehq.org/git/wine.git/?a=commit;h=3b993117c3d60edd033ee2494… Author: Roderick Colenbrander <thunderbird2k(a)gmail.com> Date: Fri Apr 16 08:49:41 2010 +0200 wined3d: Separate AMD GPUs in D3D9 and D3D10 models, this allows for a more correct fall back when the GPU table isn't up to date. D3D10_CAPABLE should work on any AMD OpenGL 3.0 driver (those came out in september 2008) and on OSX 10.5 and up. --- dlls/wined3d/directx.c | 9 ++++++++- 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/dlls/wined3d/directx.c b/dlls/wined3d/directx.c index 7e22dbc..8fb0f21 100644 --- a/dlls/wined3d/directx.c +++ b/dlls/wined3d/directx.c @@ -1506,7 +1506,7 @@ static enum wined3d_pci_device select_card_ati_binary(const struct wined3d_gl_in * * Beware: renderer string do not match exact card model, * eg HD 4800 is returned for multiple cards, even for RV790 based ones. */ - if (WINE_D3D9_CAPABLE(gl_info)) + if (WINE_D3D10_CAPABLE(gl_info)) { /* Radeon EG CYPRESS XT / PRO HD5800 - highend */ if (strstr(gl_renderer, "HD 5800") /* Radeon EG CYPRESS HD58xx generic renderer string */ @@ -1603,6 +1603,13 @@ static enum wined3d_pci_device select_card_ati_binary(const struct wined3d_gl_in return CARD_ATI_RADEON_HD3200; } + /* Default for when no GPU has been found */ + *vidmem = 128; /* 128MB */ + return CARD_ATI_RADEON_HD3200; + } + + if (WINE_D3D8_CAPABLE(gl_info)) + { /* Radeon R5xx */ if (strstr(gl_renderer, "X1600") || strstr(gl_renderer, "X1650")

1 0

Henri Verbeet : wined3d: Store render target attachments as IWineD3DSurfaceImpl pointers in struct fbo_entry .
by Alexandre Julliard 16 Apr '10

16 Apr '10

Module: wine Branch: master Commit: be993fc49fb739dfb7154e065e177d058392d514 URL: http://source.winehq.org/git/wine.git/?a=commit;h=be993fc49fb739dfb7154e065… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Thu Apr 15 19:21:27 2010 +0200 wined3d: Store render target attachments as IWineD3DSurfaceImpl pointers in struct fbo_entry. --- dlls/wined3d/context.c | 6 +++--- dlls/wined3d/wined3d_private.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dlls/wined3d/context.c b/dlls/wined3d/context.c index 43a6d8a..d7f6b40 100644 --- a/dlls/wined3d/context.c +++ b/dlls/wined3d/context.c @@ -300,7 +300,7 @@ static void context_check_fbo_status(struct wined3d_context *context) /* Dump the FBO attachments */ for (i = 0; i < gl_info->limits.buffers; ++i) { - attachment = (IWineD3DSurfaceImpl *)context->current_fbo->render_targets[i]; + attachment = context->current_fbo->render_targets[i]; if (attachment) { FIXME("\tColor attachment %d: (%p) %s %ux%u\n", @@ -638,7 +638,7 @@ void context_resource_released(IWineD3DDevice *iface, IWineD3DResource *resource for (j = 0; j < gl_info->limits.buffers; ++j) { - if (entry->render_targets[j] == (IWineD3DSurface *)resource) + if (entry->render_targets[j] == (IWineD3DSurfaceImpl *)resource) { list_remove(&entry->entry); list_add_head(&context->fbo_destroy_list, &entry->entry); @@ -666,7 +666,7 @@ void context_surface_update(struct wined3d_context *context, IWineD3DSurfaceImpl for (i = 0; i < gl_info->limits.buffers; ++i) { - if (surface == (IWineD3DSurfaceImpl *)entry->render_targets[i]) + if (surface == entry->render_targets[i]) { TRACE("Updated surface %p is bound as color attachment %u to the current FBO.\n", surface, i); context->rebind_fbo = TRUE; diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h index 95445a1..2a6e3ee 100644 --- a/dlls/wined3d/wined3d_private.h +++ b/dlls/wined3d/wined3d_private.h @@ -2022,7 +2022,7 @@ typedef struct { struct fbo_entry { struct list entry; - IWineD3DSurface **render_targets; + IWineD3DSurfaceImpl **render_targets; IWineD3DSurface *depth_stencil; BOOL attached; GLuint id;

1 0

Henri Verbeet : wined3d: Store the depth/ stencil attachment as IWineD3DSurfaceImpl pointer in struct fbo_entry.
by Alexandre Julliard 16 Apr '10

16 Apr '10

Module: wine Branch: master Commit: da1b459754d1c90442e884648cac39cb03cd81b6 URL: http://source.winehq.org/git/wine.git/?a=commit;h=da1b459754d1c90442e884648… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Thu Apr 15 19:21:28 2010 +0200 wined3d: Store the depth/stencil attachment as IWineD3DSurfaceImpl pointer in struct fbo_entry. --- dlls/wined3d/context.c | 12 ++++++------ dlls/wined3d/wined3d_private.h | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/dlls/wined3d/context.c b/dlls/wined3d/context.c index d7f6b40..ffb2a8c 100644 --- a/dlls/wined3d/context.c +++ b/dlls/wined3d/context.c @@ -308,7 +308,7 @@ static void context_check_fbo_status(struct wined3d_context *context) attachment->pow2Width, attachment->pow2Height); } } - attachment = (IWineD3DSurfaceImpl *)context->current_fbo->depth_stencil; + attachment = context->current_fbo->depth_stencil; if (attachment) { FIXME("\tDepth attachment: (%p) %s %ux%u\n", @@ -327,7 +327,7 @@ static struct fbo_entry *context_create_fbo_entry(struct wined3d_context *contex entry = HeapAlloc(GetProcessHeap(), 0, sizeof(*entry)); entry->render_targets = HeapAlloc(GetProcessHeap(), 0, gl_info->limits.buffers * sizeof(*entry->render_targets)); memcpy(entry->render_targets, device->render_targets, gl_info->limits.buffers * sizeof(*entry->render_targets)); - entry->depth_stencil = device->stencilBufferTarget; + entry->depth_stencil = (IWineD3DSurfaceImpl *)device->stencilBufferTarget; entry->attached = FALSE; entry->id = 0; @@ -344,7 +344,7 @@ static void context_reuse_fbo_entry(struct wined3d_context *context, struct fbo_ context_clean_fbo_attachments(gl_info); memcpy(entry->render_targets, device->render_targets, gl_info->limits.buffers * sizeof(*entry->render_targets)); - entry->depth_stencil = device->stencilBufferTarget; + entry->depth_stencil = (IWineD3DSurfaceImpl *)device->stencilBufferTarget; entry->attached = FALSE; } @@ -374,7 +374,7 @@ static struct fbo_entry *context_find_fbo_entry(struct wined3d_context *context) { if (!memcmp(entry->render_targets, device->render_targets, gl_info->limits.buffers * sizeof(*entry->render_targets)) - && entry->depth_stencil == device->stencilBufferTarget) + && entry->depth_stencil == (IWineD3DSurfaceImpl *)device->stencilBufferTarget) { list_remove(&entry->entry); list_add_head(&context->fbo_list, &entry->entry); @@ -629,7 +629,7 @@ void context_resource_released(IWineD3DDevice *iface, IWineD3DResource *resource { UINT j; - if (entry->depth_stencil == (IWineD3DSurface *)resource) + if (entry->depth_stencil == (IWineD3DSurfaceImpl *)resource) { list_remove(&entry->entry); list_add_head(&context->fbo_destroy_list, &entry->entry); @@ -674,7 +674,7 @@ void context_surface_update(struct wined3d_context *context, IWineD3DSurfaceImpl } } - if (surface == (IWineD3DSurfaceImpl *)entry->depth_stencil) + if (surface == entry->depth_stencil) { TRACE("Updated surface %p is bound as depth attachment to the current FBO.\n", surface); context->rebind_fbo = TRUE; diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h index 2a6e3ee..31ed565 100644 --- a/dlls/wined3d/wined3d_private.h +++ b/dlls/wined3d/wined3d_private.h @@ -2023,7 +2023,7 @@ struct fbo_entry { struct list entry; IWineD3DSurfaceImpl **render_targets; - IWineD3DSurface *depth_stencil; + IWineD3DSurfaceImpl *depth_stencil; BOOL attached; GLuint id; };

1 0

Henri Verbeet : wined3d: Remove some dead code from IWineD3DDeviceImpl_Uninit3D().
by Alexandre Julliard 16 Apr '10

16 Apr '10

Module: wine Branch: master Commit: f6e923b55d63dd5f8c14238668378884c713fdd9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f6e923b55d63dd5f8c1423866… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Thu Apr 15 19:21:29 2010 +0200 wined3d: Remove some dead code from IWineD3DDeviceImpl_Uninit3D(). --- dlls/wined3d/device.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c index c3d6a6e..2b4e526 100644 --- a/dlls/wined3d/device.c +++ b/dlls/wined3d/device.c @@ -1862,9 +1862,8 @@ static HRESULT WINAPI IWineD3DDeviceImpl_Uninit3D(IWineD3DDevice *iface, This->stencilBufferTarget = NULL; TRACE("Releasing the render target at %p\n", This->render_targets[0]); - if(IWineD3DSurface_Release(This->render_targets[0]) >0){ - /* This check is a bit silly, it should be in swapchain_release FIXME("(%p) Something's still holding the renderTarget\n",This); */ - } + IWineD3DSurface_Release(This->render_targets[0]); + TRACE("Setting rendertarget to NULL\n"); This->render_targets[0] = NULL;

1 0