April 2010 - Wine-commits - list.winehq.org

Roderick Colenbrander : wined3d: Disable paletted texture support. It was only offered on a few cards, so can be missed.
by Alexandre Julliard 06 Apr '10

06 Apr '10

Module: wine Branch: master Commit: 9fec1a02b9e13969f929a3eed249e67773286033 URL: http://source.winehq.org/git/wine.git/?a=commit;h=9fec1a02b9e13969f929a3eed… Author: Roderick Colenbrander <thunderbird2k(a)gmail.com> Date: Mon Apr 5 20:05:15 2010 +0200 wined3d: Disable paletted texture support. It was only offered on a few cards, so can be missed. --- dlls/wined3d/directx.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dlls/wined3d/directx.c b/dlls/wined3d/directx.c index 581d6c7..5501899 100644 --- a/dlls/wined3d/directx.c +++ b/dlls/wined3d/directx.c @@ -3404,12 +3404,12 @@ static BOOL CheckTextureCapability(struct wined3d_adapter *adapter, return FALSE; /***** - * supported: Palettized + * Not supported: Palettized + * Only some Geforce/Voodoo3/G400 cards offer 8-bit textures in case of <=Direct3D7. + * Since it is not widely available, don't offer it. Further no Windows driver offers + * WINED3DFMT_P8_UINT_A8_NORM, so don't offer it either. */ case WINED3DFMT_P8_UINT: - TRACE_(d3d_caps)("[OK]\n"); - return TRUE; - /* No Windows driver offers WINED3DFMT_P8_UINT_A8_UNORM, so don't offer it either */ case WINED3DFMT_P8_UINT_A8_UNORM: return FALSE;

1 0

Roderick Colenbrander : wined3d: Disable framebuffer to texture blitting.
by Alexandre Julliard 06 Apr '10

06 Apr '10

Module: wine Branch: master Commit: a5a4be4fc54bb4bfb860bdfd98cd241785027797 URL: http://source.winehq.org/git/wine.git/?a=commit;h=a5a4be4fc54bb4bfb860bdfd9… Author: Roderick Colenbrander <thunderbird2k(a)gmail.com> Date: Mon Apr 5 20:05:16 2010 +0200 wined3d: Disable framebuffer to texture blitting. The current code doesn't work for this at all and causes major rendering issues in e.g. C&C. I don't think we should fix this code either since it isn't worth the effort and requires evil things like paletteOverride. --- dlls/wined3d/surface.c | 22 ++++++++-------------- 1 files changed, 8 insertions(+), 14 deletions(-) diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c index 95889e4..a863372 100644 --- a/dlls/wined3d/surface.c +++ b/dlls/wined3d/surface.c @@ -3894,7 +3894,14 @@ static HRESULT IWineD3DSurfaceImpl_BltOverride(IWineD3DSurfaceImpl *This, const if((srcSwapchain || SrcSurface == myDevice->render_targets[0]) && !dstSwapchain) { /* Blit from render target to texture */ BOOL stretchx; - BOOL paletteOverride = FALSE; + + /* P8 read back is not implemented */ + if (Src->resource.format_desc->format == WINED3DFMT_P8_UINT || + This->resource.format_desc->format == WINED3DFMT_P8_UINT) + { + TRACE("P8 read back not supported by frame buffer to texture blit\n"); + return WINED3DERR_INVALIDCALL; + } if(Flags & (WINEDDBLT_KEYSRC | WINEDDBLT_KEYSRCOVERRIDE)) { TRACE("Color keying not supported by frame buffer to texture blit\n"); @@ -3908,15 +3915,6 @@ static HRESULT IWineD3DSurfaceImpl_BltOverride(IWineD3DSurfaceImpl *This, const stretchx = FALSE; } - /* When blitting from a render target a texture, the texture isn't required to have a palette. - * In this case grab the palette from the render target. */ - if (This->resource.format_desc->format == WINED3DFMT_P8_UINT && !This->palette) - { - paletteOverride = TRUE; - TRACE("Source surface (%p) lacks palette, overriding palette with palette %p of destination surface (%p)\n", Src, This->palette, This); - This->palette = Src->palette; - } - /* Blt is a pretty powerful call, while glCopyTexSubImage2D is not. glCopyTexSubImage cannot * flip the image nor scale it. * @@ -3947,10 +3945,6 @@ static HRESULT IWineD3DSurfaceImpl_BltOverride(IWineD3DSurfaceImpl *This, const fb_copy_to_texture_hwstretch(This, SrcSurface, &src_rect, &dst_rect, Filter); } - /* Clear the palette as the surface didn't have a palette attached, it would confuse GetPalette and other calls */ - if(paletteOverride) - This->palette = NULL; - if(!(This->Flags & SFLAG_DONOTFREE)) { HeapFree(GetProcessHeap(), 0, This->resource.heapMemory); This->resource.allocatedMemory = NULL;

1 0

Roderick Colenbrander : wined3d: Move the arbfp p8 fixup to the format table and get rid of the d3dfmt_get_conv override .
by Alexandre Julliard 06 Apr '10

06 Apr '10

Module: wine Branch: master Commit: 1f2976a302336eda5cb0782946d0444cbded8d84 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1f2976a302336eda5cb078294… Author: Roderick Colenbrander <thunderbird2k(a)gmail.com> Date: Mon Apr 5 20:05:17 2010 +0200 wined3d: Move the arbfp p8 fixup to the format table and get rid of the d3dfmt_get_conv override. --- dlls/wined3d/surface.c | 8 -------- dlls/wined3d/utils.c | 2 +- 2 files changed, 1 insertions(+), 9 deletions(-) diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c index a863372..6ced082 100644 --- a/dlls/wined3d/surface.c +++ b/dlls/wined3d/surface.c @@ -2166,14 +2166,6 @@ HRESULT d3dfmt_get_conv(IWineD3DSurfaceImpl *This, BOOL need_alpha_ck, BOOL use_ *convert = CONVERT_PALETTED; } } - /* TODO: this check is evil and should die (it basically checks which blitter backend is used) */ - else if (!gl_info->supported[EXT_PALETTED_TEXTURE] && device->blitter->color_fixup_supported(gl_info, This->resource.format_desc->color_fixup)) - { - *format = GL_ALPHA; - *type = GL_UNSIGNED_BYTE; - *target_bpp = 1; - } - break; case WINED3DFMT_B2G3R3_UNORM: diff --git a/dlls/wined3d/utils.c b/dlls/wined3d/utils.c index 65f4761..45d4760 100644 --- a/dlls/wined3d/utils.c +++ b/dlls/wined3d/utils.c @@ -336,7 +336,7 @@ static const struct wined3d_format_texture_info format_texture_info[] = ARB_TEXTURE_FLOAT}, /* Palettized formats */ {WINED3DFMT_P8_UINT, GL_RGBA, GL_RGBA, 0, - GL_RGBA, GL_UNSIGNED_BYTE, + GL_ALPHA, GL_UNSIGNED_BYTE, 0, ARB_FRAGMENT_PROGRAM}, {WINED3DFMT_P8_UINT, GL_COLOR_INDEX8_EXT, GL_COLOR_INDEX8_EXT, 0,

1 0

Roderick Colenbrander : wined3d: Due to code rewrites is_color_fixup_supported is not needed anymore in RealizePalette .
by Alexandre Julliard 06 Apr '10

06 Apr '10

Module: wine Branch: master Commit: e6ae272efee51dffa62ca75d4f909c8855edf950 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e6ae272efee51dffa62ca75d4… Author: Roderick Colenbrander <thunderbird2k(a)gmail.com> Date: Mon Apr 5 20:05:18 2010 +0200 wined3d: Due to code rewrites is_color_fixup_supported is not needed anymore in RealizePalette. The code in question should be executed in all cases. This also fixes palette refresh issues when shaders / paletted textures aren't around. --- dlls/wined3d/surface.c | 7 +------ 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c index 6ced082..f0bd431 100644 --- a/dlls/wined3d/surface.c +++ b/dlls/wined3d/surface.c @@ -4276,18 +4276,13 @@ static HRESULT WINAPI IWineD3DSurfaceImpl_RealizePalette(IWineD3DSurface *iface) if (This->resource.format_desc->format == WINED3DFMT_P8_UINT || This->resource.format_desc->format == WINED3DFMT_P8_UINT_A8_UNORM) { - IWineD3DDeviceImpl *device = This->resource.device; - if((This->resource.usage & WINED3DUSAGE_RENDERTARGET) && - device->blitter->color_fixup_supported(&device->adapter->gl_info, This->resource.format_desc->color_fixup)) + if(This->resource.usage & WINED3DUSAGE_RENDERTARGET) { /* Make sure the texture is up to date. This call doesn't do anything if the texture is already up to date. */ IWineD3DSurface_LoadLocation(iface, SFLAG_INTEXTURE, NULL); /* We want to force a palette refresh, so mark the drawable as not being up to date */ IWineD3DSurface_ModifyLocation(iface, SFLAG_INDRAWABLE, FALSE); - - /* Force a palette refresh by re-uploading to the drawable */ - IWineD3DSurface_LoadLocation(iface, SFLAG_INDRAWABLE, NULL); } else { if(!(This->Flags & SFLAG_INSYSMEM)) { TRACE("Palette changed with surface that does not have an up to date system memory copy\n");

1 0

Qingchuan Wang : amstream: Expose also IMultiMediaStream which is the base interface of IAMMultiMediaStream .
by Alexandre Julliard 06 Apr '10

06 Apr '10

Module: wine Branch: master Commit: 33f41d15382d3c3102a153d4bbb342d4de20aab1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=33f41d15382d3c3102a153d4b… Author: Qingchuan Wang <rainy6144(a)gmail.com> Date: Mon Apr 5 20:30:09 2010 +0200 amstream: Expose also IMultiMediaStream which is the base interface of IAMMultiMediaStream. --- dlls/amstream/amstream.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/dlls/amstream/amstream.c b/dlls/amstream/amstream.c index f8ae2a6..6bf515b 100644 --- a/dlls/amstream/amstream.c +++ b/dlls/amstream/amstream.c @@ -79,6 +79,7 @@ static HRESULT WINAPI IAMMultiMediaStreamImpl_QueryInterface(IAMMultiMediaStream TRACE("(%p/%p)->(%s,%p)\n", iface, This, debugstr_guid(riid), ppvObject); if (IsEqualGUID(riid, &IID_IUnknown) || + IsEqualGUID(riid, &IID_IMultiMediaStream) || IsEqualGUID(riid, &IID_IAMMultiMediaStream)) { IClassFactory_AddRef(iface);

1 0

Christian Costa : amstream: Fix AddRef calls.
by Alexandre Julliard 06 Apr '10

06 Apr '10

Module: wine Branch: master Commit: 01624ea6c203cebca51c471391e9649fb2dae14f URL: http://source.winehq.org/git/wine.git/?a=commit;h=01624ea6c203cebca51c47139… Author: Christian Costa <titan.costa(a)wanadoo.fr> Date: Mon Apr 5 20:30:15 2010 +0200 amstream: Fix AddRef calls. --- dlls/amstream/amstream.c | 2 +- dlls/amstream/mediastream.c | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/dlls/amstream/amstream.c b/dlls/amstream/amstream.c index 6bf515b..50a29c6 100644 --- a/dlls/amstream/amstream.c +++ b/dlls/amstream/amstream.c @@ -82,7 +82,7 @@ static HRESULT WINAPI IAMMultiMediaStreamImpl_QueryInterface(IAMMultiMediaStream IsEqualGUID(riid, &IID_IMultiMediaStream) || IsEqualGUID(riid, &IID_IAMMultiMediaStream)) { - IClassFactory_AddRef(iface); + IUnknown_AddRef(iface); *ppvObject = This; return S_OK; } diff --git a/dlls/amstream/mediastream.c b/dlls/amstream/mediastream.c index dc4ec64..39c28c9 100644 --- a/dlls/amstream/mediastream.c +++ b/dlls/amstream/mediastream.c @@ -89,9 +89,9 @@ static HRESULT WINAPI IMediaStreamImpl_QueryInterface(IMediaStream* iface, REFII if (IsEqualGUID(riid, &IID_IUnknown) || IsEqualGUID(riid, &IID_IMediaStream)) { - IClassFactory_AddRef(iface); - *ppvObject = This; - return S_OK; + IUnknown_AddRef(iface); + *ppvObject = This; + return S_OK; } ERR("(%p)->(%s,%p),not found\n",This,debugstr_guid(riid),ppvObject); @@ -229,9 +229,9 @@ static HRESULT WINAPI IDirectDrawMediaStreamImpl_QueryInterface(IDirectDrawMedia IsEqualGUID(riid, &IID_IMediaStream) || IsEqualGUID(riid, &IID_IDirectDrawMediaStream)) { - IClassFactory_AddRef(iface); - *ppvObject = This; - return S_OK; + IUnknown_AddRef(iface); + *ppvObject = This; + return S_OK; } ERR("(%p)->(%s,%p),not found\n",This,debugstr_guid(riid),ppvObject);

1 0

Christian Costa : d3dx9_36: Add definitions for ID3DXBaseMesh and ID3DXMesh interfaces.
by Alexandre Julliard 06 Apr '10

06 Apr '10

Module: wine Branch: master Commit: 1db6ce130950711d902dc7f81f96d70c26895e6e URL: http://source.winehq.org/git/wine.git/?a=commit;h=1db6ce130950711d902dc7f81… Author: Christian Costa <titan.costa(a)wanadoo.fr> Date: Tue Apr 6 00:31:40 2010 +0200 d3dx9_36: Add definitions for ID3DXBaseMesh and ID3DXMesh interfaces. --- include/d3dx9mesh.h | 98 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 98 insertions(+), 0 deletions(-) diff --git a/include/d3dx9mesh.h b/include/d3dx9mesh.h index 9e0b333..84db95f 100644 --- a/include/d3dx9mesh.h +++ b/include/d3dx9mesh.h @@ -21,6 +21,104 @@ #ifndef __WINE_D3DX9MESH_H #define __WINE_D3DX9MESH_H +DEFINE_GUID(IID_ID3DXBaseMesh, 0x7ed943dd, 0x52e8, 0x40b5, 0xa8, 0xd8, 0x76, 0x68, 0x5c, 0x40, 0x63, 0x30); +DEFINE_GUID(IID_ID3DXMesh, 0x4020e5c2, 0x1403, 0x4929, 0x88, 0x3f, 0xe2, 0xe8, 0x49, 0xfa, 0xc1, 0x95); + +enum _MAX_FVF_DECL_SIZE +{ + MAX_FVF_DECL_SIZE = MAXD3DDECLLENGTH + 1 +}; + +typedef struct ID3DXBaseMesh* LPD3DXBASEMESH; +typedef struct ID3DXMesh* LPD3DXMESH; + +typedef struct _D3DXATTRIBUTERANGE { + DWORD AttribId; + DWORD FaceStart; + DWORD FaceCount; + DWORD VertexStart; + DWORD VertexCount; +} D3DXATTRIBUTERANGE; + +typedef D3DXATTRIBUTERANGE* LPD3DXATTRIBUTERANGE; + +#undef INTERFACE +#define INTERFACE ID3DXBaseMesh + +DECLARE_INTERFACE_(ID3DXBaseMesh, IUnknown) +{ + /*** IUnknown methods ***/ + STDMETHOD(QueryInterface)(THIS_ REFIID riid, LPVOID* object) PURE; + STDMETHOD_(ULONG, AddRef)(THIS) PURE; + STDMETHOD_(ULONG, Release)(THIS) PURE; + /*** ID3DXBaseMesh ***/ + STDMETHOD(DrawSubset)(THIS_ DWORD attrib_id) PURE; + STDMETHOD_(DWORD, GetNumFaces)(THIS) PURE; + STDMETHOD_(DWORD, GetNumVertices)(THIS) PURE; + STDMETHOD_(DWORD, GetFVF)(THIS) PURE; + STDMETHOD(GetDeclaration)(THIS_ D3DVERTEXELEMENT9 declaration[MAX_FVF_DECL_SIZE]) PURE; + STDMETHOD_(DWORD, GetNumBytesPerVertex)(THIS) PURE; + STDMETHOD_(DWORD, GetOptions)(THIS) PURE; + STDMETHOD(GetDevice)(THIS_ LPDIRECT3DDEVICE9* device) PURE; + STDMETHOD(CloneMeshFVF)(THIS_ DWORD options, DWORD fvf, LPDIRECT3DDEVICE9 device, LPD3DXMESH* clone_mesh) PURE; + STDMETHOD(CloneMesh)(THIS_ DWORD options, CONST D3DVERTEXELEMENT9* declaration, LPDIRECT3DDEVICE9 device, + LPD3DXMESH* clone_mesh) PURE; + STDMETHOD(GetVertexBuffer)(THIS_ LPDIRECT3DVERTEXBUFFER9* vertex_buffer) PURE; + STDMETHOD(GetIndexBuffer)(THIS_ LPDIRECT3DINDEXBUFFER9* index_buffer) PURE; + STDMETHOD(LockVertexBuffer)(THIS_ DWORD flags, LPVOID* data) PURE; + STDMETHOD(UnlockVertexBuffer)(THIS) PURE; + STDMETHOD(LockIndexBuffer)(THIS_ DWORD flags, LPVOID* data) PURE; + STDMETHOD(UnlockIndexBuffer)(THIS) PURE; + STDMETHOD(GetAttributeTable)(THIS_ D3DXATTRIBUTERANGE* attrib_table, DWORD* attrib_table_size) PURE; + STDMETHOD(ConvertPointRepsToAdjacency)(THIS_ CONST DWORD* point_reps, DWORD* adjacency) PURE; + STDMETHOD(ConvertAdjacencyToPointReps)(THIS_ CONST DWORD* adjacency, DWORD* point_reps) PURE; + STDMETHOD(GenerateAdjacency)(THIS_ FLOAT epsilon, DWORD* adjacency) PURE; + STDMETHOD(UpdateSemantics)(THIS_ D3DVERTEXELEMENT9 declaration[MAX_FVF_DECL_SIZE]) PURE; +}; + + +#undef INTERFACE +#define INTERFACE ID3DXMesh + +DECLARE_INTERFACE_(ID3DXMesh, ID3DXBaseMesh) +{ + /*** IUnknown methods ***/ + STDMETHOD(QueryInterface)(THIS_ REFIID riid, LPVOID* object) PURE; + STDMETHOD_(ULONG, AddRef)(THIS) PURE; + STDMETHOD_(ULONG, Release)(THIS) PURE; + /*** ID3DXBaseMesh ***/ + STDMETHOD(DrawSubset)(THIS_ DWORD attrib_id) PURE; + STDMETHOD_(DWORD, GetNumFaces)(THIS) PURE; + STDMETHOD_(DWORD, GetNumVertices)(THIS) PURE; + STDMETHOD_(DWORD, GetFVF)(THIS) PURE; + STDMETHOD(GetDeclaration)(THIS_ D3DVERTEXELEMENT9 declaration[MAX_FVF_DECL_SIZE]) PURE; + STDMETHOD_(DWORD, GetNumBytesPerVertex)(THIS) PURE; + STDMETHOD_(DWORD, GetOptions)(THIS) PURE; + STDMETHOD(GetDevice)(THIS_ LPDIRECT3DDEVICE9* device) PURE; + STDMETHOD(CloneMeshFVF)(THIS_ DWORD options, DWORD fvf, LPDIRECT3DDEVICE9 device, LPD3DXMESH* clone_mesh) PURE; + STDMETHOD(CloneMesh)(THIS_ DWORD options, CONST D3DVERTEXELEMENT9* declaration, LPDIRECT3DDEVICE9 device, + LPD3DXMESH* clone_mesh) PURE; + STDMETHOD(GetVertexBuffer)(THIS_ LPDIRECT3DVERTEXBUFFER9* vertex_buffer) PURE; + STDMETHOD(GetIndexBuffer)(THIS_ LPDIRECT3DINDEXBUFFER9* index_buffer) PURE; + STDMETHOD(LockVertexBuffer)(THIS_ DWORD flags, LPVOID* data) PURE; + STDMETHOD(UnlockVertexBuffer)(THIS) PURE; + STDMETHOD(LockIndexBuffer)(THIS_ DWORD flags, LPVOID* data) PURE; + STDMETHOD(UnlockIndexBuffer)(THIS) PURE; + STDMETHOD(GetAttributeTable)(THIS_ D3DXATTRIBUTERANGE* attrib_table, DWORD* attrib_table_size) PURE; + STDMETHOD(ConvertPointRepsToAdjacency)(THIS_ CONST DWORD* point_reps, DWORD* adjacency) PURE; + STDMETHOD(ConvertAdjacencyToPointReps)(THIS_ CONST DWORD* adjacency, DWORD* point_reps) PURE; + STDMETHOD(GenerateAdjacency)(THIS_ FLOAT epsilon, DWORD* adjacency) PURE; + STDMETHOD(UpdateSemantics)(THIS_ D3DVERTEXELEMENT9 declaration[MAX_FVF_DECL_SIZE]) PURE; + /*** ID3DXMesh ***/ + STDMETHOD(LockAttributeBuffer)(THIS_ DWORD flags, DWORD** data) PURE; + STDMETHOD(UnlockAttributeBuffer)(THIS) PURE; + STDMETHOD(Optimize)(THIS_ DWORD flags, CONST DWORD* adjacency_in, DWORD* adjacency_out, + DWORD* face_remap, LPD3DXBUFFER* vertex_remap, LPD3DXMESH* opt_mesh) PURE; + STDMETHOD(OptimizeInplace)(THIS_ DWORD flags, CONST DWORD* adjacency_in, DWORD* adjacency_out, + DWORD* face_remap, LPD3DXBUFFER* vertex_remap) PURE; + STDMETHOD(SetAttributeTable)(THIS_ CONST D3DXATTRIBUTERANGE* attrib_table, DWORD attrib_table_size) PURE; +}; + #ifdef __cplusplus extern "C" { #endif

1 0

Vincent Povirk : mscoree: Use the mono embedding api instead of invoking mono.exe.
by Alexandre Julliard 06 Apr '10

06 Apr '10

Module: wine Branch: master Commit: f8ecefe6bf8485f6dc79fab9f7a5adad73dd4404 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f8ecefe6bf8485f6dc79fab9f… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Fri Apr 2 15:33:12 2010 -0500 mscoree: Use the mono embedding api instead of invoking mono.exe. --- dlls/mscoree/Makefile.in | 2 +- dlls/mscoree/mscoree_main.c | 230 +++++++++++++++++++++++++++++----------- dlls/mscoree/mscoree_private.h | 13 +++ 3 files changed, 183 insertions(+), 62 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=f8ecefe6bf8485f6dc79f…

1 0

Nikolay Sivov : shell32: Add stub shell folder for CLSID_Printers.
by Alexandre Julliard 06 Apr '10

06 Apr '10

Module: wine Branch: master Commit: da32b078b7843b340ee9334038ed211c1289d4a6 URL: http://source.winehq.org/git/wine.git/?a=commit;h=da32b078b7843b340ee933403… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue Apr 6 11:55:10 2010 +0400 shell32: Add stub shell folder for CLSID_Printers. --- dlls/shell32/Makefile.in | 1 + dlls/shell32/shell32_main.h | 1 + dlls/shell32/shellole.c | 24 ++-- dlls/shell32/shfldr_printers.c | 317 ++++++++++++++++++++++++++++++++++++++++ 4 files changed, 331 insertions(+), 12 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=da32b078b7843b340ee93…

1 0

Alexandre Julliard : user32/tests: Fix a test that was incorrectly skipped on non-Win9x platforms.
by Alexandre Julliard 06 Apr '10

06 Apr '10

Module: wine Branch: master Commit: c4dec77064ac3b471fb59d40c6f5ab20bc3989b1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c4dec77064ac3b471fb59d40c… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Apr 6 12:07:48 2010 +0200 user32/tests: Fix a test that was incorrectly skipped on non-Win9x platforms. --- dlls/user32/tests/win.c | 44 ++++++++++++++++++++++++++++++++------------ 1 files changed, 32 insertions(+), 12 deletions(-) diff --git a/dlls/user32/tests/win.c b/dlls/user32/tests/win.c index 96033a2..e3bebe7 100644 --- a/dlls/user32/tests/win.c +++ b/dlls/user32/tests/win.c @@ -3295,8 +3295,6 @@ static void test_SetParent(void) BOOL ret; HWND desktop = GetDesktopWindow(); HMENU hMenu; - /* FIXME: This detection is not correct as it also covers (all?) XP+ */ - BOOL is_win9x = GetWindowLongPtrW(desktop, GWLP_WNDPROC) == 0; HWND parent, child1, child2, child3, child4, sibling; parent = CreateWindowExA(0, "static", NULL, WS_OVERLAPPEDWINDOW, @@ -3342,19 +3340,41 @@ static void test_SetParent(void) if (!is_win9x) /* Win9x doesn't survive this test */ { + HWND ret; + ok(!SetParent(parent, child1), "SetParent should fail\n"); ok(!SetParent(child2, child3), "SetParent should fail\n"); ok(SetParent(child1, parent) != 0, "SetParent should not fail\n"); - ok(SetParent(parent, child2) != 0, "SetParent should not fail\n"); - ok(SetParent(parent, child3) != 0, "SetParent should not fail\n"); - ok(!SetParent(child2, parent), "SetParent should fail\n"); - ok(SetParent(parent, child4) != 0, "SetParent should not fail\n"); - - check_parents(parent, child4, child4, 0, 0, child4, parent); - check_parents(child1, parent, parent, parent, 0, child4, parent); - check_parents(child2, desktop, parent, parent, parent, child2, parent); - check_parents(child3, child2, child2, child2, 0, child2, parent); - check_parents(child4, desktop, child2, child2, child2, child4, parent); + ret = SetParent(parent, child2); + todo_wine ok( !ret || broken( ret != 0 ), "SetParent should fail\n"); + if (ret) /* nt4, win2k */ + { + ret = SetParent(parent, child3); + ok(ret != 0, "SetParent should not fail\n"); + ret = SetParent(child2, parent); + ok(!ret, "SetParent should fail\n"); + ret = SetParent(parent, child4); + ok(ret != 0, "SetParent should not fail\n"); + check_parents(parent, child4, child4, 0, 0, child4, parent); + check_parents(child1, parent, parent, parent, 0, child4, parent); + check_parents(child2, desktop, parent, parent, parent, child2, parent); + check_parents(child3, child2, child2, child2, 0, child2, parent); + check_parents(child4, desktop, child2, child2, child2, child4, parent); + } + else + { + ret = SetParent(parent, child3); + ok(ret != 0, "SetParent should not fail\n"); + ret = SetParent(child2, parent); + ok(!ret, "SetParent should fail\n"); + ret = SetParent(parent, child4); + ok(!ret, "SetParent should fail\n"); + check_parents(parent, child3, child3, 0, 0, child2, parent); + check_parents(child1, parent, parent, parent, 0, child2, parent); + check_parents(child2, desktop, parent, parent, parent, child2, parent); + check_parents(child3, child2, child2, child2, 0, child2, parent); + check_parents(child4, desktop, child2, child2, child2, child4, parent); + } } else skip("Win9x/WinMe crash\n");

1 0