June 2010 - Wine-commits - list.winehq.org

Alexandre Julliard : configure: Disable clean and depend rules for disabled top-level directories.
by Alexandre Julliard 30 Jun '10

30 Jun '10

Module: wine Branch: master Commit: 9bdd0272ce45b7d720b1b7d0cf90c744a967cc4a URL: http://source.winehq.org/git/wine.git/?a=commit;h=9bdd0272ce45b7d720b1b7d0c… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Jun 30 17:34:20 2010 +0200 configure: Disable clean and depend rules for disabled top-level directories. --- aclocal.m4 | 7 ++++--- configure | 9 ++++----- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/aclocal.m4 b/aclocal.m4 index 69d0e1a..a77f15e 100644 --- a/aclocal.m4 +++ b/aclocal.m4 @@ -183,9 +183,10 @@ wine_fn_config_makefile () { ac_dir=$[1] ac_enable=$[2] - wine_fn_all_dir_rules $ac_dir "Make.rules \$(MAKEDEP)" + AS_VAR_IF([$ac_enable],[no],[return 0]) - AS_VAR_IF([$ac_enable],[no],,[wine_fn_append_rule ALL_MAKEFILE_DEPENDS \ + wine_fn_all_dir_rules $ac_dir "Make.rules \$(MAKEDEP)" + wine_fn_append_rule ALL_MAKEFILE_DEPENDS \ "all: $ac_dir .PHONY: $ac_dir $ac_dir: $ac_dir/Makefile dummy @@ -197,7 +198,7 @@ install-lib:: $ac_dir install-dev:: $ac_dir @cd $ac_dir && \$(MAKE) install-dev uninstall:: $ac_dir/Makefile - @cd $ac_dir && \$(MAKE) uninstall"]) + @cd $ac_dir && \$(MAKE) uninstall" } wine_fn_config_lib () diff --git a/configure b/configure index 530c551..4847297 100755 --- a/configure +++ b/configure @@ -13989,13 +13989,13 @@ wine_fn_config_makefile () { ac_dir=$1 ac_enable=$2 - wine_fn_all_dir_rules $ac_dir "Make.rules \$(MAKEDEP)" - eval as_val=\$$ac_enable if test "x$as_val" = x""no; then : + return 0 +fi -else - wine_fn_append_rule ALL_MAKEFILE_DEPENDS \ + wine_fn_all_dir_rules $ac_dir "Make.rules \$(MAKEDEP)" + wine_fn_append_rule ALL_MAKEFILE_DEPENDS \ "all: $ac_dir .PHONY: $ac_dir $ac_dir: $ac_dir/Makefile dummy @@ -14008,7 +14008,6 @@ install-dev:: $ac_dir @cd $ac_dir && \$(MAKE) install-dev uninstall:: $ac_dir/Makefile @cd $ac_dir && \$(MAKE) uninstall" -fi } wine_fn_config_lib ()

1 0

Jacek Caban : shdocvw: Store DocHost url on a regular heap.
by Alexandre Julliard 30 Jun '10

30 Jun '10

Module: wine Branch: master Commit: aed47627f6e1db38b52874acb12b76ad701fe0ef URL: http://source.winehq.org/git/wine.git/?a=commit;h=aed47627f6e1db38b52874acb… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Jun 29 21:03:22 2010 +0200 shdocvw: Store DocHost url on a regular heap. --- dlls/shdocvw/dochost.c | 2 +- dlls/shdocvw/navigate.c | 40 +++++++++++++++++++++++++++++----------- 2 files changed, 30 insertions(+), 12 deletions(-) diff --git a/dlls/shdocvw/dochost.c b/dlls/shdocvw/dochost.c index 2196eb9..b3db012 100644 --- a/dlls/shdocvw/dochost.c +++ b/dlls/shdocvw/dochost.c @@ -820,5 +820,5 @@ void DocHost_Release(DocHost *This) ConnectionPointContainer_Destroy(&This->cps); - CoTaskMemFree(This->url); + heap_free(This->url); } diff --git a/dlls/shdocvw/navigate.c b/dlls/shdocvw/navigate.c index 3310cba..5166e97 100644 --- a/dlls/shdocvw/navigate.c +++ b/dlls/shdocvw/navigate.c @@ -111,6 +111,23 @@ static void set_status_text(BindStatusCallback *This, LPCWSTR str) IOleInPlaceFrame_SetStatusText(This->doc_host->frame, str); } +static HRESULT set_dochost_url(DocHost *This, const WCHAR *url) +{ + WCHAR *new_url; + + if(url) { + new_url = heap_strdupW(url); + if(!new_url) + return E_OUTOFMEMORY; + }else { + new_url = NULL; + } + + heap_free(This->url); + This->url = new_url; + return S_OK; +} + #define BINDSC_THIS(iface) DEFINE_THIS(BindStatusCallback, BindStatusCallback, iface) static HRESULT WINAPI BindStatusCallback_QueryInterface(IBindStatusCallback *iface, @@ -502,6 +519,7 @@ static HRESULT bind_to_object(DocHost *This, IMoniker *mon, LPCWSTR url, IBindCt IBindStatusCallback *callback) { IUnknown *unk = NULL; + WCHAR *display_name; HRESULT hres; if(mon) { @@ -512,10 +530,16 @@ static HRESULT bind_to_object(DocHost *This, IMoniker *mon, LPCWSTR url, IBindCt return hres; } - CoTaskMemFree(This->url); - hres = IMoniker_GetDisplayName(mon, 0, NULL, &This->url); - if(FAILED(hres)) + hres = IMoniker_GetDisplayName(mon, 0, NULL, &display_name); + if(FAILED(hres)) { FIXME("GetDisplayName failed: %08x\n", hres); + return hres; + } + + hres = set_dochost_url(This, display_name); + CoTaskMemFree(display_name); + if(FAILED(hres)) + return hres; IBindCtx_RegisterObjectParam(bindctx, (LPOLESTR)SZ_HTML_CLIENTSITE_OBJECTPARAM, (IUnknown*)CLIENTSITE(This)); @@ -538,18 +562,12 @@ static HRESULT bind_to_object(DocHost *This, IMoniker *mon, LPCWSTR url, IBindCt static void html_window_navigate(DocHost *This, IHTMLPrivateWindow *window, BSTR url, BSTR headers, SAFEARRAY *post_data) { VARIANT headers_var, post_data_var; - WCHAR *new_url; BSTR empty_str; - DWORD size; HRESULT hres; - size = (strlenW(url)+1)*sizeof(WCHAR); - new_url = CoTaskMemAlloc(size); - if(!new_url) + hres = set_dochost_url(This, url); + if(FAILED(hres)) return; - memcpy(new_url, url, size); - CoTaskMemFree(This->url); - This->url = new_url; empty_str = SysAllocStringLen(NULL, 0);

1 0

Jacek Caban : shdocvw: Added IBindStatusCallback::OnProgress( BINDSTATUS_REDIRECTING) implementation.
by Alexandre Julliard 30 Jun '10

30 Jun '10

Module: wine Branch: master Commit: df8f393b59823f646f4e53322ca82009d5146090 URL: http://source.winehq.org/git/wine.git/?a=commit;h=df8f393b59823f646f4e53322… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Jun 29 21:03:47 2010 +0200 shdocvw: Added IBindStatusCallback::OnProgress(BINDSTATUS_REDIRECTING) implementation. --- dlls/shdocvw/navigate.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/shdocvw/navigate.c b/dlls/shdocvw/navigate.c index 5166e97..6f05cf2 100644 --- a/dlls/shdocvw/navigate.c +++ b/dlls/shdocvw/navigate.c @@ -222,6 +222,8 @@ static HRESULT WINAPI BindStatusCallback_OnProgress(IBindStatusCallback *iface, debugstr_w(szStatusText)); switch(ulStatusCode) { + case BINDSTATUS_REDIRECTING: + return set_dochost_url(This->doc_host, szStatusText); case BINDSTATUS_BEGINDOWNLOADDATA: set_status_text(This, szStatusText); /* FIXME: "Start downloading from site: %s" */ return S_OK;

1 0

André Hentschel : user32/tests: Use if(0) instead of a comment to make sure code still compiles.
by Alexandre Julliard 30 Jun '10

30 Jun '10

Module: wine Branch: master Commit: 50c94bf054f10ac879934ae1419ae60af9a1799e URL: http://source.winehq.org/git/wine.git/?a=commit;h=50c94bf054f10ac879934ae14… Author: André Hentschel <nerv(a)dawncrow.de> Date: Tue Jun 29 21:56:45 2010 +0200 user32/tests: Use if(0) instead of a comment to make sure code still compiles. --- dlls/user32/tests/msg.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/user32/tests/msg.c b/dlls/user32/tests/msg.c index eb27800..e0494ef 100644 --- a/dlls/user32/tests/msg.c +++ b/dlls/user32/tests/msg.c @@ -4717,10 +4717,10 @@ static void test_messages(void) ok(hwnd != 0, "Failed to create custom dialog window\n"); ok_sequence(WmCreateCustomDialogSeq, "CreateCustomDialog", TRUE); - /* + if(0) { trace("testing scroll APIs on a visible dialog %p\n", hwnd); test_scroll_messages(hwnd); - */ + } flush_sequence();

1 0

Marko Nikolic : advapi32/tests: Removed sign comparison warning in test_LookupAccountName.
by Alexandre Julliard 30 Jun '10

30 Jun '10

Module: wine Branch: master Commit: 29dd5235057bde5beba2807bb6876a7aa56d62b0 URL: http://source.winehq.org/git/wine.git/?a=commit;h=29dd5235057bde5beba2807bb… Author: Marko Nikolic <grkoma(a)gmail.com> Date: Tue Jun 29 23:23:37 2010 +0200 advapi32/tests: Removed sign comparison warning in test_LookupAccountName. --- dlls/advapi32/tests/security.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/advapi32/tests/security.c b/dlls/advapi32/tests/security.c index 1f1b697..cd4624a 100644 --- a/dlls/advapi32/tests/security.c +++ b/dlls/advapi32/tests/security.c @@ -1931,7 +1931,7 @@ static void test_LookupAccountName(void) ok(!lstrcmp(domain, sid_dom), "Expected %s, got %s\n", sid_dom, domain); } ok(domain_size == domain_save - 1, "Expected %d, got %d\n", domain_save - 1, domain_size); - ok(lstrlen(domain) == domain_size, "Expected %d, got %d\n", lstrlen(domain), domain_size); + ok(strlen(domain) == domain_size, "Expected %d, got %d\n", lstrlen(domain), domain_size); ok(sid_use == SidTypeUser, "Expected SidTypeUser (%d), got %d\n", SidTypeUser, sid_use); domain_size = domain_save; sid_size = sid_save; @@ -1949,7 +1949,7 @@ static void test_LookupAccountName(void) ok(!lstrcmp(account, "Everyone"), "Expected Everyone, got %s\n", account); ok(!lstrcmp(domain, sid_dom), "Expected %s, got %s\n", sid_dom, domain); ok(domain_size == 0, "Expected 0, got %d\n", domain_size); - ok(lstrlen(domain) == domain_size, "Expected %d, got %d\n", lstrlen(domain), domain_size); + ok(strlen(domain) == domain_size, "Expected %d, got %d\n", lstrlen(domain), domain_size); ok(sid_use == SidTypeWellKnownGroup, "Expected SidTypeWellKnownGroup (%d), got %d\n", SidTypeWellKnownGroup, sid_use); domain_size = domain_save; }

1 0

Andrew Nguyen : atl: Accept a NULL output container pointer in AtlAxAttachControl.
by Alexandre Julliard 30 Jun '10

30 Jun '10

Module: wine Branch: master Commit: e01794d4f7b3097b51d558452618f04175f672fc URL: http://source.winehq.org/git/wine.git/?a=commit;h=e01794d4f7b3097b51d558452… Author: Andrew Nguyen <anguyen(a)codeweavers.com> Date: Tue Jun 29 09:06:35 2010 -0500 atl: Accept a NULL output container pointer in AtlAxAttachControl. --- dlls/atl/atl_ax.c | 5 +- dlls/atl/tests/Makefile.in | 3 +- dlls/atl/tests/atl_ax.c | 122 ++++++++++++++++++++++++++++++++++++++++++++ dlls/atl/tests/module.c | 1 - 4 files changed, 127 insertions(+), 4 deletions(-) diff --git a/dlls/atl/atl_ax.c b/dlls/atl/atl_ax.c index cf654e1..d9d60a5 100644 --- a/dlls/atl/atl_ax.c +++ b/dlls/atl/atl_ax.c @@ -1044,10 +1044,11 @@ HRESULT WINAPI AtlAxAttachControl(IUnknown* pControl, HWND hWnd, IUnknown** ppUn TRACE( "%p %p %p\n", pControl, hWnd, ppUnkContainer ); - *ppUnkContainer = NULL; + if (!pControl) + return E_INVALIDARG; hr = IOCS_Create( hWnd, pControl, &pUnkContainer ); - if ( SUCCEEDED( hr ) ) + if ( SUCCEEDED( hr ) && ppUnkContainer) { *ppUnkContainer = (IUnknown*) pUnkContainer; } diff --git a/dlls/atl/tests/Makefile.in b/dlls/atl/tests/Makefile.in index b9752d4..98d9b03 100644 --- a/dlls/atl/tests/Makefile.in +++ b/dlls/atl/tests/Makefile.in @@ -3,9 +3,10 @@ TOPOBJDIR = ../../.. SRCDIR = @srcdir@ VPATH = @srcdir@ TESTDLL = atl.dll -IMPORTS = atl oleaut32 ole32 rpcrt4 user32 gdi32 advapi32 kernel32 +IMPORTS = uuid atl oleaut32 ole32 rpcrt4 user32 gdi32 advapi32 kernel32 C_SRCS = \ + atl_ax.c \ module.c @MAKE_TEST_RULES@ diff --git a/dlls/atl/tests/atl_ax.c b/dlls/atl/tests/atl_ax.c new file mode 100644 index 0000000..8b9966c --- /dev/null +++ b/dlls/atl/tests/atl_ax.c @@ -0,0 +1,122 @@ +/* + * Unit tests for Active Template Library ActiveX functions + * + * Copyright 2010 Andrew Nguyen + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +#include <stdarg.h> +#include <stdio.h> + +#define COBJMACROS + +#include <wine/test.h> +#include <windef.h> +#include <winbase.h> +#include <winuser.h> +#include <wingdi.h> +#include <winnls.h> +#include <winerror.h> +#include <winnt.h> +#include <wtypes.h> +#include <olectl.h> +#include <ocidl.h> +#include <exdisp.h> + +HRESULT WINAPI AtlAxAttachControl(IUnknown *, HWND, IUnknown **); + +static ATOM register_class(void) +{ + WNDCLASSA wndclassA; + + wndclassA.style = 0; + wndclassA.lpfnWndProc = DefWindowProc; + wndclassA.cbClsExtra = 0; + wndclassA.cbWndExtra = 0; + wndclassA.hInstance = GetModuleHandleA(NULL); + wndclassA.hIcon = NULL; + wndclassA.hCursor = LoadCursorA(NULL, IDC_ARROW); + wndclassA.hbrBackground = (HBRUSH)(COLOR_BTNFACE+1); + wndclassA.lpszMenuName = NULL; + wndclassA.lpszClassName = "WineAtlTestClass"; + + return RegisterClassA(&wndclassA); +} + +static void test_AtlAxAttachControl(void) +{ + HWND hwnd = CreateWindowA("WineAtlTestClass", "Wine ATL Test Window", 0, + CW_USEDEFAULT, CW_USEDEFAULT, CW_USEDEFAULT, + CW_USEDEFAULT, NULL, NULL, NULL, NULL); + HRESULT hr; + IUnknown *pObj, *pContainer; + + hr = AtlAxAttachControl(NULL, NULL, NULL); + ok(hr == E_INVALIDARG, "Expected AtlAxAttachControl to return E_INVALIDARG, got 0x%08x\n", hr); + + pContainer = (IUnknown *)0xdeadbeef; + hr = AtlAxAttachControl(NULL, NULL, &pContainer); + ok(hr == E_INVALIDARG, "Expected AtlAxAttachControl to return E_INVALIDARG, got 0x%08x\n", hr); + ok(pContainer == (IUnknown *)0xdeadbeef, + "Expected the output container pointer to be untouched, got %p\n", pContainer); + + hr = AtlAxAttachControl(NULL, hwnd, NULL); + ok(hr == E_INVALIDARG, "Expected AtlAxAttachControl to return E_INVALIDARG, got 0x%08x\n", hr); + + hr = CoCreateInstance(&CLSID_WebBrowser, NULL, CLSCTX_INPROC_SERVER | CLSCTX_INPROC_HANDLER, + &IID_IOleObject, (void **)&pObj); + ok(hr == S_OK, "Expected CoCreateInstance to return S_OK, got 0x%08x\n", hr); + + if (FAILED(hr)) + { + skip("Couldn't obtain a test IOleObject instance\n"); + return; + } + + hr = AtlAxAttachControl(pObj, NULL, NULL); + todo_wine + ok(hr == S_FALSE, "Expected AtlAxAttachControl to return S_FALSE, got 0x%08x\n", hr); + + pContainer = (IUnknown *)0xdeadbeef; + hr = AtlAxAttachControl(pObj, NULL, &pContainer); + todo_wine + ok(hr == S_FALSE, "Expected AtlAxAttachControl to return S_FALSE, got 0x%08x\n", hr); + ok(pContainer != (IUnknown *)0xdeadbeef && + pContainer != NULL, + "Expected the output container pointer to be initialized to non-NULL, got %p\n", pContainer); + + if (pContainer != (IUnknown *)0xdeadbeef && pContainer != NULL) + IUnknown_Release(pContainer); + + hr = AtlAxAttachControl(pObj, hwnd, NULL); + ok(hr == S_OK, "Expected AtlAxAttachControl to return S_OK, got 0x%08x\n", hr); + + IUnknown_Release(pObj); + + DestroyWindow(hwnd); +} + +START_TEST(atl_ax) +{ + if (!register_class()) + return; + + CoInitialize(NULL); + + test_AtlAxAttachControl(); + + CoUninitialize(); +} diff --git a/dlls/atl/tests/module.c b/dlls/atl/tests/module.c index 294d87b..1b21f6e 100644 --- a/dlls/atl/tests/module.c +++ b/dlls/atl/tests/module.c @@ -32,7 +32,6 @@ #include <winnls.h> #include <winerror.h> #include <winnt.h> -#include <initguid.h> #include <wtypes.h> #include <olectl.h> #include <ocidl.h>

1 0

Alexandre Julliard : ntdll/tests: Add a test for the exception resulting from an icebp instruction.
by Alexandre Julliard 30 Jun '10

30 Jun '10

Module: wine Branch: master Commit: f712af41f5b82315e0966d8a8b1405a649f2c63f URL: http://source.winehq.org/git/wine.git/?a=commit;h=f712af41f5b82315e0966d8a8… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Jun 30 11:55:32 2010 +0200 ntdll/tests: Add a test for the exception resulting from an icebp instruction. --- dlls/ntdll/tests/exception.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/dlls/ntdll/tests/exception.c b/dlls/ntdll/tests/exception.c index 598544e..701b6bb 100644 --- a/dlls/ntdll/tests/exception.c +++ b/dlls/ntdll/tests/exception.c @@ -203,6 +203,9 @@ static const struct exception { { 0x1e, 0x06, 0x31, 0xc0, 0x8e, 0xd8, 0x8e, 0xc0, 0xfa, 0x07, 0x1f, 0xc3 }, /* push %ds; push %es; xorl %eax,%eax; mov %ax,%ds; mov %ax,%es; cli; pop %es; pop %ds; ret */ 8, 1, TRUE, STATUS_PRIVILEGED_INSTRUCTION, 0 }, + + { { 0xf1, 0x90, 0xc3 }, /* icebp; nop; ret */ + 1, 1, FALSE, STATUS_SINGLE_STEP, 0 }, }; static int got_exception;

1 0

Alexandre Julliard : gdiplus/tests: Comment out a test that corrupts the stack on Vista.
by Alexandre Julliard 30 Jun '10

30 Jun '10

Module: wine Branch: master Commit: 4b9258d165d0a7c745814d24bf404b477cee829e URL: http://source.winehq.org/git/wine.git/?a=commit;h=4b9258d165d0a7c745814d24b… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Jun 30 14:17:13 2010 +0200 gdiplus/tests: Comment out a test that corrupts the stack on Vista. --- dlls/gdiplus/tests/pen.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/dlls/gdiplus/tests/pen.c b/dlls/gdiplus/tests/pen.c index 0bdf280..b742118 100644 --- a/dlls/gdiplus/tests/pen.c +++ b/dlls/gdiplus/tests/pen.c @@ -225,9 +225,15 @@ static void test_dasharray(void) /* Try to set with count = 0. */ GdipSetPenDashStyle(pen, DashStyleDot); + if (0) /* corrupts stack on 64-bit Vista */ + { status = GdipSetPenDashArray(pen, dashes, 0); ok(status == OutOfMemory || status == InvalidParameter, "Expected OutOfMemory or InvalidParameter, got %.8x\n", status); + } + status = GdipSetPenDashArray(pen, dashes, -1); + ok(status == OutOfMemory || status == InvalidParameter, + "Expected OutOfMemory or InvalidParameter, got %.8x\n", status); GdipGetPenDashStyle(pen, &style); expect(DashStyleDot, style);

1 0

Alexandre Julliard : server: Return the total length of the target in query_symlink.
by Alexandre Julliard 30 Jun '10

30 Jun '10

Module: wine Branch: master Commit: 4c1f36cb68d744fe5ed3d52a4ea531b72b1dcac3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=4c1f36cb68d744fe5ed3d52a4… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Jun 30 16:11:03 2010 +0200 server: Return the total length of the target in query_symlink. --- include/wine/server_protocol.h | 4 +++- server/protocol.def | 1 + server/request.h | 3 ++- server/symlink.c | 1 + server/trace.c | 4 +++- 5 files changed, 10 insertions(+), 3 deletions(-) diff --git a/include/wine/server_protocol.h b/include/wine/server_protocol.h index 20bb4a2..1a78bc2 100644 --- a/include/wine/server_protocol.h +++ b/include/wine/server_protocol.h @@ -4395,7 +4395,9 @@ struct query_symlink_request struct query_symlink_reply { struct reply_header __header; + data_size_t total; /* VARARG(target_name,unicode_str); */ + char __pad_12[4]; }; @@ -5485,6 +5487,6 @@ union generic_reply struct set_cursor_reply set_cursor_reply; }; -#define SERVER_PROTOCOL_VERSION 401 +#define SERVER_PROTOCOL_VERSION 402 #endif /* __WINE_WINE_SERVER_PROTOCOL_H */ diff --git a/server/protocol.def b/server/protocol.def index e4e8ec3..e41cd18 100644 --- a/server/protocol.def +++ b/server/protocol.def @@ -3057,6 +3057,7 @@ enum message_type @REQ(query_symlink) obj_handle_t handle; /* handle to the symlink */ @REPLY + data_size_t total; /* total needed size for name */ VARARG(target_name,unicode_str); /* target name */ @END diff --git a/server/request.h b/server/request.h index ef6adea..722fc25 100644 --- a/server/request.h +++ b/server/request.h @@ -1980,7 +1980,8 @@ C_ASSERT( FIELD_OFFSET(struct open_symlink_reply, handle) == 8 ); C_ASSERT( sizeof(struct open_symlink_reply) == 16 ); C_ASSERT( FIELD_OFFSET(struct query_symlink_request, handle) == 12 ); C_ASSERT( sizeof(struct query_symlink_request) == 16 ); -C_ASSERT( sizeof(struct query_symlink_reply) == 8 ); +C_ASSERT( FIELD_OFFSET(struct query_symlink_reply, total) == 8 ); +C_ASSERT( sizeof(struct query_symlink_reply) == 16 ); C_ASSERT( FIELD_OFFSET(struct get_object_info_request, handle) == 12 ); C_ASSERT( sizeof(struct get_object_info_request) == 16 ); C_ASSERT( FIELD_OFFSET(struct get_object_info_reply, access) == 8 ); diff --git a/server/symlink.c b/server/symlink.c index 2ec7ed5..2330fde 100644 --- a/server/symlink.c +++ b/server/symlink.c @@ -214,6 +214,7 @@ DECL_HANDLER(query_symlink) SYMBOLIC_LINK_QUERY, &symlink_ops ); if (!symlink) return; + reply->total = symlink->len; if (get_reply_max_size() < symlink->len) set_error( STATUS_BUFFER_TOO_SMALL ); else diff --git a/server/trace.c b/server/trace.c index ec87dab..fd2318e 100644 --- a/server/trace.c +++ b/server/trace.c @@ -3594,7 +3594,8 @@ static void dump_query_symlink_request( const struct query_symlink_request *req static void dump_query_symlink_reply( const struct query_symlink_reply *req ) { - dump_varargs_unicode_str( " target_name=", cur_size ); + fprintf( stderr, " total=%u", req->total ); + dump_varargs_unicode_str( ", target_name=", cur_size ); } static void dump_get_object_info_request( const struct get_object_info_request *req ) @@ -4607,6 +4608,7 @@ static const struct { "GENERIC_NOT_MAPPED", STATUS_GENERIC_NOT_MAPPED }, { "HANDLES_CLOSED", STATUS_HANDLES_CLOSED }, { "HANDLE_NOT_CLOSABLE", STATUS_HANDLE_NOT_CLOSABLE }, + { "HOST_UNREACHABLE", STATUS_HOST_UNREACHABLE }, { "ILLEGAL_FUNCTION", STATUS_ILLEGAL_FUNCTION }, { "INSTANCE_NOT_AVAILABLE", STATUS_INSTANCE_NOT_AVAILABLE }, { "INSUFFICIENT_RESOURCES", STATUS_INSUFFICIENT_RESOURCES },

1 0

Alexandre Julliard : ntdll: Append a terminating null and return the correct length in NtQuerySymbolicLinkObject .
by Alexandre Julliard 30 Jun '10

30 Jun '10

Module: wine Branch: master Commit: 6df7e7b94362f874a5b5a46cda0eead8f517c651 URL: http://source.winehq.org/git/wine.git/?a=commit;h=6df7e7b94362f874a5b5a46cd… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Jun 30 16:11:42 2010 +0200 ntdll: Append a terminating null and return the correct length in NtQuerySymbolicLinkObject. --- dlls/ntdll/om.c | 27 +++++++++++++++------------ 1 files changed, 15 insertions(+), 12 deletions(-) diff --git a/dlls/ntdll/om.c b/dlls/ntdll/om.c index c5d9b84..0e64ddd 100644 --- a/dlls/ntdll/om.c +++ b/dlls/ntdll/om.c @@ -634,33 +634,36 @@ NTSTATUS WINAPI NtCreateSymbolicLinkObject(OUT PHANDLE SymbolicLinkHandle,IN ACC * ZwQuerySymbolicLinkObject [NTDLL.@] * * Query a namespace symbolic link object target name. - * + * * PARAMS - * LinkHandle [I] Handle to a symbolic link object - * LinkTarget [O] Destination for the symbolic link target - * ReturnedLength [O] Size of returned data + * handle [I] Handle to a symbolic link object + * target [O] Destination for the symbolic link target + * length [O] Size of returned data * * RETURNS * Success: ERROR_SUCCESS. * Failure: An NTSTATUS error code. */ -NTSTATUS WINAPI NtQuerySymbolicLinkObject(IN HANDLE LinkHandle, IN OUT PUNICODE_STRING LinkTarget, - OUT PULONG ReturnedLength OPTIONAL) +NTSTATUS WINAPI NtQuerySymbolicLinkObject( HANDLE handle, PUNICODE_STRING target, PULONG length ) { NTSTATUS ret; - TRACE("(%p,%p,%p)\n", LinkHandle, LinkTarget, ReturnedLength); - if (!LinkTarget) return STATUS_ACCESS_VIOLATION; + TRACE("(%p,%p,%p)\n", handle, target, length ); + + if (!target) return STATUS_ACCESS_VIOLATION; SERVER_START_REQ(query_symlink) { - req->handle = wine_server_obj_handle( LinkHandle ); - wine_server_set_reply( req, LinkTarget->Buffer, LinkTarget->MaximumLength ); + req->handle = wine_server_obj_handle( handle ); + if (target->MaximumLength >= sizeof(WCHAR)) + wine_server_set_reply( req, target->Buffer, target->MaximumLength - sizeof(WCHAR) ); if (!(ret = wine_server_call( req ))) { - LinkTarget->Length = wine_server_reply_size(reply); - if (ReturnedLength) *ReturnedLength = LinkTarget->Length; + target->Length = wine_server_reply_size(reply); + target->Buffer[target->Length / sizeof(WCHAR)] = 0; + if (length) *length = reply->total + sizeof(WCHAR); } + else if (length && ret == STATUS_BUFFER_TOO_SMALL) *length = reply->total + sizeof(WCHAR); } SERVER_END_REQ; return ret;

1 0