June 2010 - Wine-commits - list.winehq.org

Nikolay Sivov : msxml3: Properly free namespace structure pointer.
by Alexandre Julliard 22 Jun '10

22 Jun '10

Module: wine Branch: master Commit: ea9a6a4b4e33cc8f56bc7835f7f05146487fb5d2 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ea9a6a4b4e33cc8f56bc7835f… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Mon Jun 21 22:06:29 2010 +0400 msxml3: Properly free namespace structure pointer. --- dlls/msxml3/xmlelem.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/msxml3/xmlelem.c b/dlls/msxml3/xmlelem.c index c067179..0327604 100644 --- a/dlls/msxml3/xmlelem.c +++ b/dlls/msxml3/xmlelem.c @@ -262,7 +262,7 @@ static HRESULT WINAPI xmlelem_getAttribute(IXMLElement *iface, BSTR name, xmlNsPtr ns; ns = xmlSearchNs(This->node->doc, This->node, (xmlChar*)"xml"); val = xmlGetNsProp(This->node, (xmlChar*)"lang", ns->href); - xmlFree(ns); + xmlFreeNs(ns); } else {

1 0

Matteo Bruni : wined3d: Check for error conditions in GL call.
by Alexandre Julliard 22 Jun '10

22 Jun '10

Module: wine Branch: master Commit: 6585bec5ac0a2793badcac8a4fc9fb267341ed2e URL: http://source.winehq.org/git/wine.git/?a=commit;h=6585bec5ac0a2793badcac8a4… Author: Matteo Bruni <matteo.mystral(a)gmail.com> Date: Mon Jun 21 22:14:58 2010 +0200 wined3d: Check for error conditions in GL call. --- dlls/wined3d/surface.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c index d363feb..73c5aff 100644 --- a/dlls/wined3d/surface.c +++ b/dlls/wined3d/surface.c @@ -848,6 +848,7 @@ static void surface_allocate_surface(IWineD3DSurfaceImpl *This, const struct win { GL_EXTCALL(glCompressedTexImage2DARB(This->texture_target, This->texture_level, internal, width, height, 0, This->resource.size, mem)); + checkGLcall("glCompressedTexImage2DARB"); } else {

1 0

Michael Stefaniuc : xcopy: Add the Romanian translation.
by Alexandre Julliard 22 Jun '10

22 Jun '10

Module: wine Branch: master Commit: a2b2d6adeb71bc7c9caf0f2cf68ef0b585e2804a URL: http://source.winehq.org/git/wine.git/?a=commit;h=a2b2d6adeb71bc7c9caf0f2cf… Author: Michael Stefaniuc <mstefani(a)redhat.com> Date: Tue Jun 22 00:43:57 2010 +0200 xcopy: Add the Romanian translation. Translation by Claudia Cotună. --- programs/xcopy/Makefile.in | 1 + programs/xcopy/Ro.rc | 80 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 81 insertions(+), 0 deletions(-) diff --git a/programs/xcopy/Makefile.in b/programs/xcopy/Makefile.in index ea98eba..8d8e9e7 100644 --- a/programs/xcopy/Makefile.in +++ b/programs/xcopy/Makefile.in @@ -25,6 +25,7 @@ RC_SRCS = \ No.rc \ Pl.rc \ Pt.rc \ + Ro.rc \ Ru.rc \ Si.rc \ Uk.rc diff --git a/programs/xcopy/Ro.rc b/programs/xcopy/Ro.rc new file mode 100644 index 0000000..3e8a655 --- /dev/null +++ b/programs/xcopy/Ro.rc @@ -0,0 +1,80 @@ +/* + * XCOPY - Wine-compatible xcopy program + * + * Copyright (C) 2007 J. Edmeades + * Copyright (C) 2010 Claudia Cotună + * Michael Stefaniuc + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +#include "xcopy.h" + +LANGUAGE LANG_ROMANIAN, SUBLANG_NEUTRAL + +#pragma code_page(65001) + +STRINGTABLE +{ + STRING_INVPARMS, "Număr de parametri nevalid - Utilizați xcopy /? pentru ajutor\n" + STRING_INVPARM, "Parametru nevalid „%s” - Utilizați xcopy /? pentru ajutor\n" + STRING_PAUSE, "Apăsați pe <enter> pentru a începe copierea\n" + STRING_SIMCOPY, "%d fișier(e) ar fi copiat(e)\n" + STRING_COPY, "%d fișier(e) copiat(e)\n" + STRING_QISDIR, "„%s” este un nume de fișier sau un director\ndin destinație?\n(F - Fișier, D - Director)\n" + STRING_SRCPROMPT,"%s? (Da|Nu)\n" + STRING_OVERWRITE,"Se suprascrie %s? (Da|Nu|Toate)\n" + STRING_COPYFAIL, "Copierea „%s” în „%s” a eșuat cu cod de retur %d\n" + STRING_OPENFAIL, "Deschiderea „%s” a eșuat\n" + STRING_READFAIL, "Citirea „%s” a eșuat\n" + STRING_YES_CHAR, "D" + STRING_NO_CHAR, "N" + STRING_ALL_CHAR, "T" + STRING_FILE_CHAR,"F" + STRING_DIR_CHAR, "D" + + STRING_HELP, +"XCOPY - Copiază fișiere sau arbori de directoare sursă într-o destinație\n\ +\n\ +Sintaxă:\n\ +XCOPY sursă [destinație] [/I] [/S] [/Q] [/F] [/L] [/W] [/T] [/N] [/U]\n\ +\ [/R] [/H] [/C] [/P] [/A] [/M] [/E] [/D] [/Y] [/-Y]\n\ +\nCu:\n\ +\n\ +[/I] Creează director dacă destinația nu există și se copiază două sau\n\ +\ mai multe fișiere\n\ +[/S] Copiază directoarele și subdirectoarele\n\ +[/E] Copiază directoarele și subdirectoarele, inclusiv pe cele goale\n\ +[/Q] Nu afișa numele în timpul copierii.\n\ +[/F] Arată numele întreg pentru sursă și destinație în timpul copierii\n\ +[/L] Simulează operațiunea, afișând numele care ar fi copiate\n\ +[/W] Solicită confirmarea înainte de a începe copierea\n\ +[/T] Creează o structură de directoare goale, dar nu copiază fișiere\n\ +[/Y] Nu solicita confirmarea la suprascrierea fișierelor\n\ +[/-Y] Solicită confirmarea la suprascrierea fișierelor\n\ +[/P] Solicită confirmarea înainte de copierea fiecărui fișier sursă \n\ +[/N] Copiază utilizând prescurtări de nume\n\ +[/U] Copiază numai fișierele care există deja în destinație\n\ +[/R] Suprascrie orice fișiere cu protecție la modificări\n\ +[/H] Include în copie fișierele ascunse și de sistem\n\ +[/C] Continuă chiar dacă apare o eroare în timpul copierii\n\ +[/A] Copiază numai fișierele cu atributul de arhivă activat\n\ +[/M] Copiază numai fișierele cu atributul de arhivă activat, dezactivează\n\ +\ apoi atributul\n\ +[/D | /D:m-d-y] Copiază fișierele noi sau pe cele modificate după data\n\ +\t\tspecificată. Dacă nu este specificată nici o dată, copiază\n\ +\t\tnumai dacă fișierul destinație este mai vechi decât fișierul\n\ +\t\tsursă\n\n" +}

1 0

Michael Stefaniuc : xcopy: Update the English resource.
by Alexandre Julliard 22 Jun '10

22 Jun '10

Module: wine Branch: master Commit: 1d7f820f17d76e71f5b8b945a07eb1ef5dd9f19f URL: http://source.winehq.org/git/wine.git/?a=commit;h=1d7f820f17d76e71f5b8b945a… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Tue Jun 22 00:44:05 2010 +0200 xcopy: Update the English resource. --- programs/xcopy/En.rc | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/programs/xcopy/En.rc b/programs/xcopy/En.rc index 83ef291..6fb299c 100644 --- a/programs/xcopy/En.rc +++ b/programs/xcopy/En.rc @@ -53,8 +53,8 @@ XCOPY source [dest] [/I] [/S] [/Q] [/F] [/L] [/W] [/T] [/N] [/U]\n\ \n\ Where:\n\ \n\ -[/I] Assume directory if destination does not exist and copying 2 or\n\ -\tmore files\n\ +[/I] Assume directory if destination does not exist and copying two or\n\ +\ more files\n\ [/S] Copy directories and subdirectories\n\ [/E] Copy directories and subdirectories, including any empty ones\n\ [/Q] Do not list names during copy, ie quiet.\n\ @@ -72,7 +72,7 @@ Where:\n\ [/C] Continue even if an error occurs during the copy\n\ [/A] Only copy files with archive attribute set\n\ [/M] Only copy files with archive attribute set, removes\n\ -\tarchive attribute\n\ +\ archive attribute\n\ [/D | /D:m-d-y] Copy new files or those modified after the supplied date.\n\ \t\tIf no date is supplied, only copy if destination is older\n\ \t\tthan source\n\n"

1 0

Michael Stefaniuc : cmd: Don't treat all command lines with '/?' as builtin commands.
by Alexandre Julliard 22 Jun '10

22 Jun '10

Module: wine Branch: master Commit: 71e647fe5188c8ab7f5e4df6cbb0f04f23ff46c0 URL: http://source.winehq.org/git/wine.git/?a=commit;h=71e647fe5188c8ab7f5e4df6c… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Tue Jun 22 00:44:15 2010 +0200 cmd: Don't treat all command lines with '/?' as builtin commands. --- programs/cmd/wcmdmain.c | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/programs/cmd/wcmdmain.c b/programs/cmd/wcmdmain.c index b86801c..b50512e 100644 --- a/programs/cmd/wcmdmain.c +++ b/programs/cmd/wcmdmain.c @@ -1405,15 +1405,14 @@ void WCMD_execute (WCHAR *command, WCHAR *redirects, } for (i=0; i<=WCMD_EXIT; i++) { if (CompareStringW(LOCALE_USER_DEFAULT, NORM_IGNORECASE | SORT_STRINGSORT, - whichcmd, count, inbuilt[i], -1) == 2) break; + whichcmd, count, inbuilt[i], -1) == CSTR_EQUAL) break; } p = WCMD_strtrim_leading_spaces (&whichcmd[count]); WCMD_parse (p, quals, param1, param2); WINE_TRACE("param1: %s, param2: %s\n", wine_dbgstr_w(param1), wine_dbgstr_w(param2)); - if((p[0] == '/') && (p[1] == '?')) { - - /*this is a help request for a program*/ + if (i <= WCMD_EXIT && (p[0] == '/') && (p[1] == '?')) { + /* this is a help request for a builtin program */ i = WCMD_HELP; memcpy(p, whichcmd, count * sizeof(WCHAR)); p[count] = '\0';

1 0

Gustavo Henrique Milaré : winecfg: Update Portuguese translation.
by Alexandre Julliard 22 Jun '10

22 Jun '10

Module: wine Branch: master Commit: cdad4e4af2fbcaad6b082abefbd98be47af6ac4c URL: http://source.winehq.org/git/wine.git/?a=commit;h=cdad4e4af2fbcaad6b082abef… Author: Gustavo Henrique Milaré <gugamilare(a)gmail.com> Date: Mon Jun 21 21:07:29 2010 -0300 winecfg: Update Portuguese translation. --- programs/winecfg/Pt.rc | 320 +++++++++++++++++++++++++++++++++++++----------- 1 files changed, 248 insertions(+), 72 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=cdad4e4af2fbcaad6b082…

1 0

Andrew Nguyen : ddraw: Validate structure pointers and sizes in IDirect3D3: :FindDevice.
by Alexandre Julliard 22 Jun '10

22 Jun '10

Module: wine Branch: master Commit: 10a076ad8d653db5d626310464033c9c1a6929e8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=10a076ad8d653db5d62631046… Author: Andrew Nguyen <anguyen(a)codeweavers.com> Date: Mon Jun 21 10:14:51 2010 -0500 ddraw: Validate structure pointers and sizes in IDirect3D3::FindDevice. --- dlls/ddraw/direct3d.c | 7 +++++++ dlls/ddraw/tests/d3d.c | 35 +++++++++++++++++++++++++++++++++++ 2 files changed, 42 insertions(+), 0 deletions(-) diff --git a/dlls/ddraw/direct3d.c b/dlls/ddraw/direct3d.c index 3f2410f..f919860 100644 --- a/dlls/ddraw/direct3d.c +++ b/dlls/ddraw/direct3d.c @@ -666,6 +666,13 @@ IDirect3DImpl_3_FindDevice(IDirect3D3 *iface, TRACE("(%p)->(%p,%p)\n", This, D3DDFS, D3DFDR); + if (!D3DDFS || !D3DFDR) + return DDERR_INVALIDPARAMS; + + if (D3DDFS->dwSize != sizeof(D3DFINDDEVICESEARCH) || + D3DFDR->dwSize != sizeof(D3DFINDDEVICERESULT)) + return DDERR_INVALIDPARAMS; + if ((D3DDFS->dwFlags & D3DFDS_COLORMODEL) && (D3DDFS->dcmColorModel != D3DCOLOR_RGB)) { diff --git a/dlls/ddraw/tests/d3d.c b/dlls/ddraw/tests/d3d.c index 26dc1cf..e74fb79 100644 --- a/dlls/ddraw/tests/d3d.c +++ b/dlls/ddraw/tests/d3d.c @@ -3391,6 +3391,40 @@ static void VertexBufferLockRest(void) IDirect3DVertexBuffer7_Release(buffer); } +static void FindDevice(void) +{ + D3DFINDDEVICESEARCH search = {0}; + D3DFINDDEVICERESULT result = {0}; + HRESULT hr; + + /* Test invalid parameters. */ + hr = IDirect3D_FindDevice(Direct3D1, NULL, NULL); + ok(hr == DDERR_INVALIDPARAMS, + "Expected IDirect3D1::FindDevice to return DDERR_INVALIDPARAMS, got 0x%08x\n", hr); + + hr = IDirect3D_FindDevice(Direct3D1, NULL, &result); + ok(hr == DDERR_INVALIDPARAMS, + "Expected IDirect3D1::FindDevice to return DDERR_INVALIDPARAMS, got 0x%08x\n", hr); + + hr = IDirect3D_FindDevice(Direct3D1, &search, NULL); + ok(hr == DDERR_INVALIDPARAMS, + "Expected IDirect3D1::FindDevice to return DDERR_INVALIDPARAMS, got 0x%08x\n", hr); + + search.dwSize = 0; + result.dwSize = 0; + + hr = IDirect3D_FindDevice(Direct3D1, &search, &result); + ok(hr == DDERR_INVALIDPARAMS, + "Expected IDirect3D1::FindDevice to return DDERR_INVALIDPARAMS, got 0x%08x\n", hr); + + search.dwSize = sizeof(search) + 1; + result.dwSize = sizeof(result) + 1; + + hr = IDirect3D_FindDevice(Direct3D1, &search, &result); + ok(hr == DDERR_INVALIDPARAMS, + "Expected IDirect3D1::FindDevice to return DDERR_INVALIDPARAMS, got 0x%08x\n", hr); +} + START_TEST(d3d) { init_function_pointers(); @@ -3425,6 +3459,7 @@ START_TEST(d3d) Direct3D1Test(); TextureLoadTest(); ViewportTest(); + FindDevice(); D3D1_releaseObjects(); }

1 0

Andrew Nguyen : ddraw: Allow the ddraw RGB device to be enumerated in IDirect3D3::FindDevice.
by Alexandre Julliard 22 Jun '10

22 Jun '10

Module: wine Branch: master Commit: eb9227015ad639a1fbdb15eeb212d25c0bdc083c URL: http://source.winehq.org/git/wine.git/?a=commit;h=eb9227015ad639a1fbdb15eeb… Author: Andrew Nguyen <anguyen(a)codeweavers.com> Date: Mon Jun 21 10:15:05 2010 -0500 ddraw: Allow the ddraw RGB device to be enumerated in IDirect3D3::FindDevice. Partially based on a patch by David Adam. --- dlls/ddraw/direct3d.c | 5 ++- dlls/ddraw/tests/d3d.c | 64 ++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 67 insertions(+), 2 deletions(-) diff --git a/dlls/ddraw/direct3d.c b/dlls/ddraw/direct3d.c index f919860..edbcc28 100644 --- a/dlls/ddraw/direct3d.c +++ b/dlls/ddraw/direct3d.c @@ -684,10 +684,11 @@ IDirect3DImpl_3_FindDevice(IDirect3D3 *iface, TRACE(" trying to match guid %s.\n", debugstr_guid(&(D3DDFS->guid))); if ((IsEqualGUID(&IID_D3DDEVICE_WineD3D, &(D3DDFS->guid)) == 0) && (IsEqualGUID(&IID_IDirect3DHALDevice, &(D3DDFS->guid)) == 0) && - (IsEqualGUID(&IID_IDirect3DRefDevice, &(D3DDFS->guid)) == 0)) + (IsEqualGUID(&IID_IDirect3DRefDevice, &(D3DDFS->guid)) == 0) && + (IsEqualGUID(&IID_IDirect3DRGBDevice, &(D3DDFS->guid)) == 0)) { TRACE(" no match for this GUID.\n"); - return DDERR_INVALIDPARAMS; + return DDERR_NOTFOUND; } } diff --git a/dlls/ddraw/tests/d3d.c b/dlls/ddraw/tests/d3d.c index e74fb79..7f47d20 100644 --- a/dlls/ddraw/tests/d3d.c +++ b/dlls/ddraw/tests/d3d.c @@ -3393,9 +3393,20 @@ static void VertexBufferLockRest(void) static void FindDevice(void) { + static const struct + { + const GUID *guid; + int todo; + } deviceGUIDs[] = + { + {&IID_IDirect3DRampDevice, 1}, + {&IID_IDirect3DRGBDevice}, + }; + D3DFINDDEVICESEARCH search = {0}; D3DFINDDEVICERESULT result = {0}; HRESULT hr; + int i; /* Test invalid parameters. */ hr = IDirect3D_FindDevice(Direct3D1, NULL, NULL); @@ -3423,6 +3434,59 @@ static void FindDevice(void) hr = IDirect3D_FindDevice(Direct3D1, &search, &result); ok(hr == DDERR_INVALIDPARAMS, "Expected IDirect3D1::FindDevice to return DDERR_INVALIDPARAMS, got 0x%08x\n", hr); + + /* Specifying no flags is permitted. */ + search.dwSize = sizeof(search); + search.dwFlags = 0; + result.dwSize = sizeof(result); + + hr = IDirect3D_FindDevice(Direct3D1, &search, &result); + ok(hr == D3D_OK, + "Expected IDirect3D1::FindDevice to return D3D_OK, got 0x%08x\n", hr); + + /* Try an arbitrary non-device GUID. */ + search.dwSize = sizeof(search); + search.dwFlags = D3DFDS_GUID; + search.guid = IID_IDirect3D; + result.dwSize = sizeof(result); + + hr = IDirect3D_FindDevice(Direct3D1, &search, &result); + ok(hr == DDERR_NOTFOUND, + "Expected IDirect3D1::FindDevice to return DDERR_NOTFOUND, got 0x%08x\n", hr); + + /* The reference device GUID can't be enumerated. */ + search.dwSize = sizeof(search); + search.dwFlags = D3DFDS_GUID; + search.guid = IID_IDirect3DRefDevice; + result.dwSize = sizeof(result); + + hr = IDirect3D_FindDevice(Direct3D1, &search, &result); + todo_wine + ok(hr == DDERR_NOTFOUND, + "Expected IDirect3D1::FindDevice to return DDERR_NOTFOUND, got 0x%08x\n", hr); + + /* These GUIDs appear to be always present. */ + for (i = 0; i < sizeof(deviceGUIDs)/sizeof(deviceGUIDs[0]); i++) + { + search.dwSize = sizeof(search); + search.dwFlags = D3DFDS_GUID; + search.guid = *deviceGUIDs[i].guid; + result.dwSize = sizeof(result); + + hr = IDirect3D_FindDevice(Direct3D1, &search, &result); + + if (deviceGUIDs[i].todo) + { + todo_wine + ok(hr == D3D_OK, + "[%d] Expected IDirect3D1::FindDevice to return D3D_OK, got 0x%08x\n", i, hr); + } + else + { + ok(hr == D3D_OK, + "[%d] Expected IDirect3D1::FindDevice to return D3D_OK, got 0x%08x\n", i, hr); + } + } } START_TEST(d3d)

1 0

Andrew Nguyen : ddraw/tests: Add an observation regarding device color model criteria for IDirect3D3:: FindDevice.
by Alexandre Julliard 22 Jun '10

22 Jun '10

Module: wine Branch: master Commit: bdc29f83bc6fcd3c550fdb710d634e48c9b1739b URL: http://source.winehq.org/git/wine.git/?a=commit;h=bdc29f83bc6fcd3c550fdb710… Author: Andrew Nguyen <anguyen(a)codeweavers.com> Date: Mon Jun 21 10:15:18 2010 -0500 ddraw/tests: Add an observation regarding device color model criteria for IDirect3D3::FindDevice. --- dlls/ddraw/tests/d3d.c | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/dlls/ddraw/tests/d3d.c b/dlls/ddraw/tests/d3d.c index 7f47d20..069bc96 100644 --- a/dlls/ddraw/tests/d3d.c +++ b/dlls/ddraw/tests/d3d.c @@ -3487,6 +3487,17 @@ static void FindDevice(void) "[%d] Expected IDirect3D1::FindDevice to return D3D_OK, got 0x%08x\n", i, hr); } } + + /* Curiously the color model criteria seem to be ignored. */ + search.dwSize = sizeof(search); + search.dwFlags = D3DFDS_COLORMODEL; + search.dcmColorModel = 0xdeadbeef; + result.dwSize = sizeof(result); + + hr = IDirect3D_FindDevice(Direct3D1, &search, &result); + todo_wine + ok(hr == D3D_OK, + "Expected IDirect3D1::FindDevice to return D3D_OK, got 0x%08x\n", hr); } START_TEST(d3d)

1 0

André Hentschel : krnl386.exe16: Update a comment.
by Alexandre Julliard 22 Jun '10

22 Jun '10

Module: wine Branch: master Commit: 8f0a0c23fa07f8360547db275146778ab45b4900 URL: http://source.winehq.org/git/wine.git/?a=commit;h=8f0a0c23fa07f8360547db275… Author: André Hentschel <nerv(a)dawncrow.de> Date: Mon Jun 21 17:46:57 2010 +0200 krnl386.exe16: Update a comment. --- dlls/krnl386.exe16/ioports.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/krnl386.exe16/ioports.c b/dlls/krnl386.exe16/ioports.c index 9ceb3ae..d802ab9 100644 --- a/dlls/krnl386.exe16/ioports.c +++ b/dlls/krnl386.exe16/ioports.c @@ -463,7 +463,7 @@ static int IO_pp_sort(const void *p1,const void *p2) /* IO_pp_init * - * Read the ppdev entries from wine.conf, open the device and check + * Read the ppdev entries from registry, open the device and check * for necessary IOCTRL * Report verbose about possible errors */

1 0