July 2010 - Wine-commits - list.winehq.org

Austin English : ws2_32: Remove unused variable.
by Alexandre Julliard 21 Jul '10

21 Jul '10

Module: wine Branch: master Commit: cdf091f2c9584994706cfea395131e4f2e8f87b7 URL: http://source.winehq.org/git/wine.git/?a=commit;h=cdf091f2c9584994706cfea39… Author: Austin English <austinenglish(a)gmail.com> Date: Tue Jul 20 23:42:48 2010 -0500 ws2_32: Remove unused variable. --- dlls/ws2_32/socket.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c index 2fde6e6..2597c8d 100644 --- a/dlls/ws2_32/socket.c +++ b/dlls/ws2_32/socket.c @@ -3120,15 +3120,13 @@ int WINAPI WS_select(int nfds, WS_fd_set *ws_readfds, static void WS_AddCompletion( SOCKET sock, ULONG_PTR CompletionValue, NTSTATUS CompletionStatus, ULONG Information ) { - NTSTATUS status; - SERVER_START_REQ( add_fd_completion ) { req->handle = wine_server_obj_handle( SOCKET2HANDLE(sock) ); req->cvalue = CompletionValue; req->status = CompletionStatus; req->information = Information; - status = wine_server_call( req ); + wine_server_call( req ); } SERVER_END_REQ; }

1 0

Austin English : setupapi/tests: Remove unused variable.
by Alexandre Julliard 21 Jul '10

21 Jul '10

Module: wine Branch: master Commit: f7f38c5def12cd36bf0107eb6a6a95a514f2cbcf URL: http://source.winehq.org/git/wine.git/?a=commit;h=f7f38c5def12cd36bf0107eb6… Author: Austin English <austinenglish(a)gmail.com> Date: Wed Jul 21 02:27:18 2010 -0500 setupapi/tests: Remove unused variable. --- dlls/setupapi/tests/parser.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/setupapi/tests/parser.c b/dlls/setupapi/tests/parser.c index 072ac97..53f7cc0 100644 --- a/dlls/setupapi/tests/parser.c +++ b/dlls/setupapi/tests/parser.c @@ -406,7 +406,7 @@ static const char *check_key( INFCONTEXT *context, const char *wanted ) static void test_key_names(void) { char buffer[MAX_INF_STRING_LENGTH+32]; - const char *key, *line; + const char *line; unsigned int i, index, count; UINT err_line; HINF hinf; @@ -426,7 +426,7 @@ static void test_key_names(void) ret = SetupFindFirstLineA( hinf, "Test", 0, &context ); assert( ret ); - key = check_key( &context, key_names[i].key ); + check_key( &context, key_names[i].key ); buffer[0] = buffer[1] = 0; /* build the full line */ for (index = 0; ; index++)

1 0

Alexandre Julliard : server: Try to use /proc/pid/ mem to read process memory since it should be faster.
by Alexandre Julliard 21 Jul '10

21 Jul '10

Module: wine Branch: master Commit: 1a79912a10a6cded54d1f1de5f746bbffec3ffee URL: http://source.winehq.org/git/wine.git/?a=commit;h=1a79912a10a6cded54d1f1de5… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Jul 21 10:50:12 2010 +0200 server: Try to use /proc/pid/mem to read process memory since it should be faster. --- server/ptrace.c | 20 ++++++++++++++++++++ 1 files changed, 20 insertions(+), 0 deletions(-) diff --git a/server/ptrace.c b/server/ptrace.c index 1118048..111368b 100644 --- a/server/ptrace.c +++ b/server/ptrace.c @@ -19,9 +19,11 @@ */ #include "config.h" +#include "wine/port.h" #include <assert.h> #include <errno.h> +#include <fcntl.h> #include <stdio.h> #include <signal.h> #include <stdarg.h> @@ -377,6 +379,24 @@ int read_process_memory( struct process *process, client_ptr_t ptr, data_size_t if (suspend_for_ptrace( thread )) { + if (len > 3) /* /proc/pid/mem should be faster for large sizes */ + { + char procmem[24]; + int fd; + + sprintf( procmem, "/proc/%u/mem", process->unix_pid ); + if ((fd = open( procmem, O_RDONLY )) != -1) + { + ssize_t ret = pread( fd, dest, size, ptr ); + close( fd ); + if (ret == size) + { + len = 0; + goto done; + } + } + } + if (len > 1) { if (read_thread_long( thread, addr++, &data ) == -1) goto done;

1 0

Thomas Mullaly : include: Updated the URL_SCHEME enum.
by Alexandre Julliard 21 Jul '10

21 Jul '10

Module: wine Branch: master Commit: 53ee717d56686fa2ca14d32ac3ea60fbd4365d5f URL: http://source.winehq.org/git/wine.git/?a=commit;h=53ee717d56686fa2ca14d32ac… Author: Thomas Mullaly <thomas.mullaly(a)gmail.com> Date: Sun Jun 6 22:19:43 2010 -0400 include: Updated the URL_SCHEME enum. --- include/shlwapi.h | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/include/shlwapi.h b/include/shlwapi.h index dd2da4f..bec8b3a 100644 --- a/include/shlwapi.h +++ b/include/shlwapi.h @@ -585,6 +585,11 @@ typedef enum { URL_SCHEME_MSSHELLROOTED, URL_SCHEME_MSSHELLIDLIST, URL_SCHEME_MSHELP, + URL_SCHEME_MSSHELLDEVICE, + URL_SCHEME_WILDCARD, + URL_SCHEME_SEARCH_MS, + URL_SCHEME_SEARCH, + URL_SCHEME_KNOWNFOLDER, URL_SCHEME_MAXVALUE } URL_SCHEME;

1 0

Thomas Mullaly : urlmon: Added a scheme name parser for the IUri interface.
by Alexandre Julliard 21 Jul '10

21 Jul '10

Module: wine Branch: master Commit: 811ed515ab8791c67bc2edc6118f550b01d163e1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=811ed515ab8791c67bc2edc61… Author: Thomas Mullaly <thomas.mullaly(a)gmail.com> Date: Sun Jun 6 23:39:46 2010 -0400 urlmon: Added a scheme name parser for the IUri interface. --- dlls/urlmon/tests/uri.c | 7 ++ dlls/urlmon/uri.c | 156 ++++++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 162 insertions(+), 1 deletions(-) diff --git a/dlls/urlmon/tests/uri.c b/dlls/urlmon/tests/uri.c index a89e5c6..ddd35d8 100644 --- a/dlls/urlmon/tests/uri.c +++ b/dlls/urlmon/tests/uri.c @@ -522,12 +522,19 @@ static void test_CreateUri_InvalidArgs(void) { HRESULT hr; IUri *uri = (void*) 0xdeadbeef; + const WCHAR invalidW[] = {'i','n','v','a','l','i','d',0}; + hr = pCreateUri(http_urlW, 0, 0, NULL); ok(hr == E_INVALIDARG, "Error: CreateUri returned 0x%08x, expected 0x%08x\n", hr, E_INVALIDARG); hr = pCreateUri(NULL, 0, 0, &uri); ok(hr == E_INVALIDARG, "Error: CreateUri returned 0x%08x, expected 0x%08x\n", hr, E_INVALIDARG); ok(uri == NULL, "Error: Expected the IUri to be NULL, but it was %p instead\n", uri); + + uri = (void*) 0xdeadbeef; + hr = pCreateUri(invalidW, 0, 0, &uri); + ok(hr == E_INVALIDARG, "Error: CreateUri returned 0x%08x, expected 0x%08x.\n", hr, E_INVALIDARG); + ok(uri == NULL, "Error: Expected the IUri to be NULL, but it was %p instead\n", uri); } static void test_IUri_GetPropertyBSTR(void) { diff --git a/dlls/urlmon/uri.c b/dlls/urlmon/uri.c index 732ec44..246eacc 100644 --- a/dlls/urlmon/uri.c +++ b/dlls/urlmon/uri.c @@ -20,6 +20,9 @@ #include "urlmon_main.h" #include "wine/debug.h" +#define NO_SHLWAPI_REG +#include "shlwapi.h" + WINE_DEFAULT_DEBUG_CHANNEL(urlmon); typedef struct { @@ -34,6 +37,146 @@ typedef struct { LONG ref; } UriBuilder; +typedef struct { + BSTR uri; + + + BOOL is_relative; + + const WCHAR *scheme; + DWORD scheme_len; +} parse_data; + +static inline BOOL is_alpha(WCHAR val) { + return ((val >= 'a' && val <= 'z') || (val >= 'A' && val <= 'Z')); +} + +static inline BOOL is_num(WCHAR val) { + return (val >= '0' && val <= '9'); +} + +/* A URI is implicitly a file path if it begins with + * a drive letter (eg X:) or starts with "\\" (UNC path). + */ +static inline BOOL is_implicit_file_path(const WCHAR *str) { + if(is_alpha(str[0]) && str[1] == ':') + return TRUE; + else if(str[0] == '\\' && str[1] == '\\') + return TRUE; + + return FALSE; +} + +/* Tries to parse the scheme name of the URI. + * + * scheme = ALPHA *(ALPHA | NUM | '+' | '-' | '.') as defined by RFC 3896. + * NOTE: Windows accepts a number as the first character of a scheme. + */ +static BOOL parse_scheme_name(const WCHAR **ptr, parse_data *data) { + const WCHAR *start = *ptr; + + data->scheme = NULL; + data->scheme_len = 0; + + while(**ptr) { + if(!is_num(**ptr) && !is_alpha(**ptr) && **ptr != '+' && + **ptr != '-' && **ptr != '.') + break; + + (*ptr)++; + } + + if(*ptr == start) + return FALSE; + + /* Schemes must end with a ':' */ + if(**ptr != ':') { + *ptr = start; + return FALSE; + } + + data->scheme = start; + data->scheme_len = *ptr - start; + + ++(*ptr); + return TRUE; +} + +/* Tries to parse (or deduce) the scheme_name of a URI. If it can't + * parse a scheme from the URI it will try to deduce the scheme_name and scheme_type + * using the flags specified in 'flags' (if any). Flags that affect how this function + * operates are the Uri_CREATE_ALLOW_* flags. + * + * All parsed/deduced information will be stored in 'data' when the function returns. + * + * Returns TRUE if it was able to successfully parse the information. + */ +static BOOL parse_scheme(const WCHAR **ptr, parse_data *data, DWORD flags) { + static const WCHAR fileW[] = {'f','i','l','e',0}; + static const WCHAR wildcardW[] = {'*',0}; + + /* First check to see if the uri could implicitly be a file path. */ + if(is_implicit_file_path(*ptr)) { + if(flags & Uri_CREATE_ALLOW_IMPLICIT_FILE_SCHEME) { + data->scheme = fileW; + data->scheme_len = lstrlenW(fileW); + TRACE("(%p %p %x): URI is an implicit file path.\n", ptr, data, flags); + } else { + /* Window's does not consider anything that can implicitly be a file + * path to be a valid URI if the ALLOW_IMPLICIT_FILE_SCHEME flag is not set... + */ + TRACE("(%p %p %x): URI is implicitly a file path, but, the ALLOW_IMPLICIT_FILE_SCHEME flag wasn't set.\n", + ptr, data, flags); + return FALSE; + } + } else if(!parse_scheme_name(ptr, data)) { + /* No Scheme was found, this means it could be: + * a) an implicit Wildcard scheme + * b) a relative URI + * c) a invalid URI. + */ + if(flags & Uri_CREATE_ALLOW_IMPLICIT_WILDCARD_SCHEME) { + data->scheme = wildcardW; + data->scheme_len = lstrlenW(wildcardW); + + TRACE("(%p %p %x): URI is an implicit wildcard scheme.\n", ptr, data, flags); + } else if (flags & Uri_CREATE_ALLOW_RELATIVE) { + data->is_relative = TRUE; + TRACE("(%p %p %x): URI is relative.\n", ptr, data, flags); + } else { + TRACE("(%p %p %x): Malformed URI found. Unable to deduce scheme name.\n", ptr, data, flags); + return FALSE; + } + } + + if(!data->is_relative) + TRACE("(%p %p %x): Found scheme=%s scheme_len=%d\n", ptr, data, flags, + debugstr_wn(data->scheme, data->scheme_len), data->scheme_len); + + return TRUE; +} + +/* Parses and validates the components of the specified by data->uri + * and stores the information it parses into 'data'. + * + * Returns TRUE if it successfully parsed the URI. False otherwise. + */ +static BOOL parse_uri(parse_data *data, DWORD flags) { + const WCHAR *ptr; + const WCHAR **pptr; + + ptr = data->uri; + pptr = &ptr; + + TRACE("(%p %x): BEGINNING TO PARSE URI %s.\n", data, flags, debugstr_w(data->uri)); + + if(!parse_scheme(pptr, data, flags)) + return FALSE; + + TRACE("(%p %x): FINISHED PARSING URI.\n", data, flags); + return TRUE; +} + #define URI(x) ((IUri*) &(x)->lpIUriVtbl) #define URIBUILDER(x) ((IUriBuilder*) &(x)->lpIUriBuilderVtbl) @@ -475,6 +618,7 @@ static const IUriVtbl UriVtbl = { HRESULT WINAPI CreateUri(LPCWSTR pwzURI, DWORD dwFlags, DWORD_PTR dwReserved, IUri **ppURI) { Uri *ret; + parse_data data; TRACE("(%s %x %x %p)\n", debugstr_w(pwzURI), dwFlags, (DWORD)dwReserved, ppURI); @@ -495,12 +639,22 @@ HRESULT WINAPI CreateUri(LPCWSTR pwzURI, DWORD dwFlags, DWORD_PTR dwReserved, IU /* Create a copy of pwzURI and store it as the raw_uri. */ ret->raw_uri = SysAllocString(pwzURI); - if(!ret->raw_uri) { heap_free(ret); return E_OUTOFMEMORY; } + memset(&data, 0, sizeof(parse_data)); + data.uri = ret->raw_uri; + + if(!parse_uri(&data, dwFlags)) { + /* Encountered an unsupported or invalid URI */ + SysFreeString(ret->raw_uri); + heap_free(ret); + *ppURI = NULL; + return E_INVALIDARG; + } + *ppURI = URI(ret); return S_OK; }

1 0

Thomas Mullaly : urlmon: Added a parser function to determine the scheme type of a URI.
by Alexandre Julliard 21 Jul '10

21 Jul '10

Module: wine Branch: master Commit: 1eca647bb37a301b9e7c5207b0c3af492c0590ab URL: http://source.winehq.org/git/wine.git/?a=commit;h=1eca647bb37a301b9e7c5207b… Author: Thomas Mullaly <thomas.mullaly(a)gmail.com> Date: Mon Jun 7 16:34:08 2010 -0400 urlmon: Added a parser function to determine the scheme type of a URI. --- dlls/urlmon/uri.c | 66 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 66 insertions(+), 0 deletions(-) diff --git a/dlls/urlmon/uri.c b/dlls/urlmon/uri.c index 246eacc..b0c6351 100644 --- a/dlls/urlmon/uri.c +++ b/dlls/urlmon/uri.c @@ -45,8 +45,38 @@ typedef struct { const WCHAR *scheme; DWORD scheme_len; + URL_SCHEME scheme_type; } parse_data; +/* List of scheme types/scheme names that are recognized by the IUri interface as of IE 7. */ +static const struct { + URL_SCHEME scheme; + WCHAR scheme_name[16]; +} recognized_schemes[] = { + {URL_SCHEME_FTP, {'f','t','p',0}}, + {URL_SCHEME_HTTP, {'h','t','t','p',0}}, + {URL_SCHEME_GOPHER, {'g','o','p','h','e','r',0}}, + {URL_SCHEME_MAILTO, {'m','a','i','l','t','o',0}}, + {URL_SCHEME_NEWS, {'n','e','w','s',0}}, + {URL_SCHEME_NNTP, {'n','n','t','p',0}}, + {URL_SCHEME_TELNET, {'t','e','l','n','e','t',0}}, + {URL_SCHEME_WAIS, {'w','a','i','s',0}}, + {URL_SCHEME_FILE, {'f','i','l','e',0}}, + {URL_SCHEME_MK, {'m','k',0}}, + {URL_SCHEME_HTTPS, {'h','t','t','p','s',0}}, + {URL_SCHEME_SHELL, {'s','h','e','l','l',0}}, + {URL_SCHEME_SNEWS, {'s','n','e','w','s',0}}, + {URL_SCHEME_LOCAL, {'l','o','c','a','l',0}}, + {URL_SCHEME_JAVASCRIPT, {'j','a','v','a','s','c','r','i','p','t',0}}, + {URL_SCHEME_VBSCRIPT, {'v','b','s','c','r','i','p','t',0}}, + {URL_SCHEME_ABOUT, {'a','b','o','u','t',0}}, + {URL_SCHEME_RES, {'r','e','s',0}}, + {URL_SCHEME_MSSHELLROOTED, {'m','s','-','s','h','e','l','l','-','r','o','o','t','e','d',0}}, + {URL_SCHEME_MSSHELLIDLIST, {'m','s','-','s','h','e','l','l','-','i','d','l','i','s','t',0}}, + {URL_SCHEME_MSHELP, {'h','c','p',0}}, + {URL_SCHEME_WILDCARD, {'*',0}} +}; + static inline BOOL is_alpha(WCHAR val) { return ((val >= 'a' && val <= 'z') || (val >= 'A' && val <= 'Z')); } @@ -102,6 +132,38 @@ static BOOL parse_scheme_name(const WCHAR **ptr, parse_data *data) { return TRUE; } +/* Tries to deduce the corresponding URL_SCHEME for the given URI. Stores + * the deduced URL_SCHEME in data->scheme_type. + */ +static BOOL parse_scheme_type(parse_data *data) { + /* If there's scheme data then see if it's a recognized scheme. */ + if(data->scheme && data->scheme_len) { + DWORD i; + + for(i = 0; i < sizeof(recognized_schemes)/sizeof(recognized_schemes[0]); ++i) { + if(lstrlenW(recognized_schemes[i].scheme_name) == data->scheme_len) { + /* Has to be a case insensitive compare. */ + if(!StrCmpNIW(recognized_schemes[i].scheme_name, data->scheme, data->scheme_len)) { + data->scheme_type = recognized_schemes[i].scheme; + return TRUE; + } + } + } + + /* If we get here it means it's not a recognized scheme. */ + data->scheme_type = URL_SCHEME_UNKNOWN; + return TRUE; + } else if(data->is_relative) { + /* Relative URI's have no scheme. */ + data->scheme_type = URL_SCHEME_UNKNOWN; + return TRUE; + } else { + /* Should never reach here! what happened... */ + FIXME("(%p): Unable to determine scheme type for URI %s\n", data, debugstr_w(data->uri)); + return FALSE; + } +} + /* Tries to parse (or deduce) the scheme_name of a URI. If it can't * parse a scheme from the URI it will try to deduce the scheme_name and scheme_type * using the flags specified in 'flags' (if any). Flags that affect how this function @@ -153,6 +215,10 @@ static BOOL parse_scheme(const WCHAR **ptr, parse_data *data, DWORD flags) { TRACE("(%p %p %x): Found scheme=%s scheme_len=%d\n", ptr, data, flags, debugstr_wn(data->scheme, data->scheme_len), data->scheme_len); + if(!parse_scheme_type(data)) + return FALSE; + + TRACE("(%p %p %x): Assigned %d as the URL_SCHEME.\n", ptr, data, flags, data->scheme_type); return TRUE; }

1 0

Thomas Mullaly : urlmon: Added a canonicalization function for the scheme of a URI.
by Alexandre Julliard 21 Jul '10

21 Jul '10

Module: wine Branch: master Commit: 4de04ce8c7695b789aee407d7204458eb12e53ea URL: http://source.winehq.org/git/wine.git/?a=commit;h=4de04ce8c7695b789aee407d7… Author: Thomas Mullaly <thomas.mullaly(a)gmail.com> Date: Mon Jun 7 17:46:43 2010 -0400 urlmon: Added a canonicalization function for the scheme of a URI. --- dlls/urlmon/uri.c | 126 ++++++++++++++++++++++++++++++++++++++++++++++++++++- 1 files changed, 124 insertions(+), 2 deletions(-) diff --git a/dlls/urlmon/uri.c b/dlls/urlmon/uri.c index b0c6351..fc46def 100644 --- a/dlls/urlmon/uri.c +++ b/dlls/urlmon/uri.c @@ -28,8 +28,16 @@ WINE_DEFAULT_DEBUG_CHANNEL(urlmon); typedef struct { const IUriVtbl *lpIUriVtbl; LONG ref; + BSTR raw_uri; - BSTR raw_uri; + /* Information about the canonicalized URI's buffer. */ + WCHAR *canon_uri; + DWORD canon_size; + DWORD canon_len; + + INT scheme_start; + DWORD scheme_len; + URL_SCHEME scheme_type; } Uri; typedef struct { @@ -40,7 +48,6 @@ typedef struct { typedef struct { BSTR uri; - BOOL is_relative; const WCHAR *scheme; @@ -243,6 +250,109 @@ static BOOL parse_uri(parse_data *data, DWORD flags) { return TRUE; } +/* Canonicalizes the scheme information specified in the parse_data using the specified flags. */ +static BOOL canonicalize_scheme(const parse_data *data, Uri *uri, DWORD flags, BOOL computeOnly) { + uri->scheme_start = -1; + uri->scheme_len = 0; + + if(!data->scheme) { + /* The only type of URI that doesn't have to have a scheme is a relative + * URI. + */ + if(!data->is_relative) { + FIXME("(%p %p %x): Unable to determine the scheme type of %s.\n", data, + uri, flags, debugstr_w(data->uri)); + return FALSE; + } + } else { + if(!computeOnly) { + DWORD i; + INT pos = uri->canon_len; + + for(i = 0; i < data->scheme_len; ++i) { + /* Scheme name must be lower case after canonicalization. */ + uri->canon_uri[i + pos] = tolowerW(data->scheme[i]); + } + + uri->canon_uri[i + pos] = ':'; + uri->scheme_start = pos; + + TRACE("(%p %p %x): Canonicalized scheme=%s, len=%d.\n", data, uri, flags, + debugstr_wn(uri->canon_uri, uri->scheme_len), data->scheme_len); + } + + /* This happens in both compute only and non-compute only. */ + uri->canon_len += data->scheme_len + 1; + uri->scheme_len = data->scheme_len; + } + return TRUE; +} + +/* Compute's what the length of the URI specified by the parse_data will be + * after canonicalization occurs using the specified flags. + * + * This function will return a non-zero value indicating the length of the canonicalized + * URI, or -1 on error. + */ +static int compute_canonicalized_length(const parse_data *data, DWORD flags) { + Uri uri; + + memset(&uri, 0, sizeof(Uri)); + + TRACE("(%p %x): Beginning to compute canonicalized length for URI %s\n", data, flags, + debugstr_w(data->uri)); + + if(!canonicalize_scheme(data, &uri, flags, TRUE)) { + ERR("(%p %x): Failed to compute URI scheme length.\n", data, flags); + return -1; + } + + TRACE("(%p %x): Finished computing canonicalized URI length. length=%d\n", data, flags, uri.canon_len); + + return uri.canon_len; +} + +/* Canonicalizes the URI data specified in the parse_data, using the given flags. If the + * canonicalization succeededs it will store all the canonicalization information + * in the pointer to the Uri. + * + * To canonicalize a URI this function first computes what the length of the URI + * specified by the parse_data will be. Once this is done it will then perfom the actual + * canonicalization of the URI. + */ +static HRESULT canonicalize_uri(const parse_data *data, Uri *uri, DWORD flags) { + INT len; + + uri->canon_uri = NULL; + len = uri->canon_size = uri->canon_len = 0; + + TRACE("(%p %p %x): beginning to canonicalize URI %s.\n", data, uri, flags, debugstr_w(data->uri)); + + /* First try to compute the length of the URI. */ + len = compute_canonicalized_length(data, flags); + if(len == -1) { + ERR("(%p %p %x): Could not compute the canonicalized length of %s.\n", data, uri, flags, + debugstr_w(data->uri)); + return E_INVALIDARG; + } + + uri->canon_uri = heap_alloc((len+1)*sizeof(WCHAR)); + if(!uri->canon_uri) + return E_OUTOFMEMORY; + + if(!canonicalize_scheme(data, uri, flags, FALSE)) { + ERR("(%p %p %x): Unable to canonicalize the scheme of the URI.\n", data, uri, flags); + heap_free(uri->canon_uri); + return E_INVALIDARG; + } + uri->scheme_type = data->scheme_type; + + uri->canon_uri[uri->canon_len] = '\0'; + TRACE("(%p %p %x): finished canonicalizing the URI.\n", data, uri, flags); + + return S_OK; +} + #define URI(x) ((IUri*) &(x)->lpIUriVtbl) #define URIBUILDER(x) ((IUriBuilder*) &(x)->lpIUriBuilderVtbl) @@ -287,6 +397,7 @@ static ULONG WINAPI Uri_Release(IUri *iface) if(!ref) { SysFreeString(This->raw_uri); + heap_free(This->canon_uri); heap_free(This); } @@ -684,6 +795,7 @@ static const IUriVtbl UriVtbl = { HRESULT WINAPI CreateUri(LPCWSTR pwzURI, DWORD dwFlags, DWORD_PTR dwReserved, IUri **ppURI) { Uri *ret; + HRESULT hr; parse_data data; TRACE("(%s %x %x %p)\n", debugstr_w(pwzURI), dwFlags, (DWORD)dwReserved, ppURI); @@ -713,6 +825,7 @@ HRESULT WINAPI CreateUri(LPCWSTR pwzURI, DWORD dwFlags, DWORD_PTR dwReserved, IU memset(&data, 0, sizeof(parse_data)); data.uri = ret->raw_uri; + /* Validate and parse the URI into it's components. */ if(!parse_uri(&data, dwFlags)) { /* Encountered an unsupported or invalid URI */ SysFreeString(ret->raw_uri); @@ -721,6 +834,15 @@ HRESULT WINAPI CreateUri(LPCWSTR pwzURI, DWORD dwFlags, DWORD_PTR dwReserved, IU return E_INVALIDARG; } + /* Canonicalize the URI. */ + hr = canonicalize_uri(&data, ret, dwFlags); + if(FAILED(hr)) { + SysFreeString(ret->raw_uri); + heap_free(ret); + *ppURI = NULL; + return hr; + } + *ppURI = URI(ret); return S_OK; }

1 0

Thomas Mullaly : urlmon: Implemented functionality for retrieving the scheme name of a IUri.
by Alexandre Julliard 21 Jul '10

21 Jul '10

Module: wine Branch: master Commit: d4e69aec61824058fb0040ee97580415e3fd4086 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d4e69aec61824058fb0040ee9… Author: Thomas Mullaly <thomas.mullaly(a)gmail.com> Date: Mon Jun 7 21:33:42 2010 -0400 urlmon: Implemented functionality for retrieving the scheme name of a IUri. --- dlls/urlmon/tests/uri.c | 24 ++++++++++++------------ dlls/urlmon/uri.c | 29 ++++++++++++++++++++++------- 2 files changed, 34 insertions(+), 19 deletions(-) diff --git a/dlls/urlmon/tests/uri.c b/dlls/urlmon/tests/uri.c index ddd35d8..80a2593 100644 --- a/dlls/urlmon/tests/uri.c +++ b/dlls/urlmon/tests/uri.c @@ -105,7 +105,7 @@ static const uri_properties uri_tests[] = { {"/",S_OK,TRUE}, /* PATH_AND_QUERY */ {"",S_FALSE,TRUE}, /* QUERY */ {"http://www.winehq.org/tests/../tests/../..",S_OK,FALSE}, /* RAW_URI */ - {"http",S_OK,TRUE}, /* SCHEME_NAME */ + {"http",S_OK,FALSE}, /* SCHEME_NAME */ {"",S_FALSE,TRUE}, /* USER_INFO */ {"",S_FALSE,TRUE} /* USER_NAME */ }, @@ -134,7 +134,7 @@ static const uri_properties uri_tests[] = { {"/tests",S_OK,TRUE}, {"",S_FALSE,TRUE}, {"http://winehq.org/tests/.././tests",S_OK,FALSE}, - {"http",S_OK,TRUE}, + {"http",S_OK,FALSE}, {"",S_FALSE,TRUE}, {"",S_FALSE,TRUE} }, @@ -163,7 +163,7 @@ static const uri_properties uri_tests[] = { {"/?query=x&return=y",S_OK,TRUE}, {"?query=x&return=y",S_OK,TRUE}, {"HtTp://www.winehq.org/tests/..?query=x&return=y",S_OK,FALSE}, - {"http",S_OK,TRUE}, + {"http",S_OK,FALSE}, {"",S_FALSE,TRUE}, {"",S_FALSE,TRUE} }, @@ -192,7 +192,7 @@ static const uri_properties uri_tests[] = { {"/path/a/Forbidden'%3C%7C%3E%20Characters",S_OK,TRUE}, {"",S_FALSE,TRUE}, {"hTTp://us%45r%3Ainfo(a)examp%4CE.com:80/path/a/b/./c/../%2E%2E/Forbidden'<|> Characters",S_OK,FALSE}, - {"http",S_OK,TRUE}, + {"http",S_OK,FALSE}, {"usEr%3Ainfo",S_OK,TRUE}, {"usEr%3Ainfo",S_OK,TRUE} }, @@ -222,7 +222,7 @@ static const uri_properties uri_tests[] = { {"/dir/foo%20bar.txt",S_OK,TRUE}, {"",S_FALSE,TRUE}, {"ftp://winepass:wine(a)ftp.winehq.org:9999/dir/foo bar.txt",S_OK,FALSE}, - {"ftp",S_OK,TRUE}, + {"ftp",S_OK,FALSE}, {"winepass:wine",S_OK,TRUE}, {"winepass",S_OK,TRUE} }, @@ -250,7 +250,7 @@ static const uri_properties uri_tests[] = { {"/c:/tests/foo%2520bar.mp3",S_OK,TRUE}, {"",S_FALSE,TRUE}, {"file://c:\\tests\\../tests/foo%20bar.mp3",S_OK,FALSE}, - {"file",S_OK,TRUE}, + {"file",S_OK,FALSE}, {"",S_FALSE,TRUE}, {"",S_FALSE,TRUE} }, @@ -278,7 +278,7 @@ static const uri_properties uri_tests[] = { {"/tests/test%20file.README.txt",S_OK,TRUE}, {"",S_FALSE,TRUE}, {"FILE://localhost/test dir\\../tests/test%20file.README.txt",S_OK,FALSE}, - {"file",S_OK,TRUE}, + {"file",S_OK,FALSE}, {"",S_FALSE,TRUE}, {"",S_FALSE,TRUE} }, @@ -306,7 +306,7 @@ static const uri_properties uri_tests[] = { {"nothing:should:happen here",S_OK,TRUE}, {"",S_FALSE,TRUE}, {"urn:nothing:should:happen here",S_OK,FALSE}, - {"urn",S_OK,TRUE}, + {"urn",S_OK,FALSE}, {"",S_FALSE,TRUE}, {"",S_FALSE,TRUE} }, @@ -335,7 +335,7 @@ static const uri_properties uri_tests[] = { {"/test%20dir/test.txt",S_OK,TRUE}, {"",S_FALSE,TRUE}, {"http://127.0.0.1/tests/../test dir/./test.txt",S_OK,FALSE}, - {"http",S_OK,TRUE}, + {"http",S_OK,FALSE}, {"",S_FALSE,TRUE}, {"",S_FALSE,TRUE} }, @@ -364,7 +364,7 @@ static const uri_properties uri_tests[] = { {"/",S_OK,TRUE}, {"",S_FALSE,TRUE}, {"http://[FEDC:BA98:7654:3210:FEDC:BA98:7654:3210]",S_OK,FALSE}, - {"http",S_OK,TRUE}, + {"http",S_OK,FALSE}, {"",S_FALSE,TRUE}, {"",S_FALSE,TRUE} }, @@ -393,7 +393,7 @@ static const uri_properties uri_tests[] = { {"/",S_OK,TRUE}, {"",S_FALSE,TRUE}, {"ftp://[::13.1.68.3]",S_OK,FALSE}, - {"ftp",S_OK,TRUE}, + {"ftp",S_OK,FALSE}, {"",S_FALSE,TRUE}, {"",S_FALSE,TRUE} }, @@ -422,7 +422,7 @@ static const uri_properties uri_tests[] = { {"/",S_OK,TRUE}, {"",S_FALSE,TRUE}, {"http://[FEDC:BA98:0:0:0:0:0:3210]",S_OK,FALSE}, - {"http",S_OK,TRUE}, + {"http",S_OK,FALSE}, {"",S_FALSE,TRUE}, {"",S_FALSE,TRUE}, }, diff --git a/dlls/urlmon/uri.c b/dlls/urlmon/uri.c index fc46def..f99061f 100644 --- a/dlls/urlmon/uri.c +++ b/dlls/urlmon/uri.c @@ -416,6 +416,8 @@ static HRESULT WINAPI Uri_GetPropertyBSTR(IUri *iface, Uri_PROPERTY uriProp, BST if(uriProp > Uri_PROPERTY_STRING_LAST) { /* Windows allocates an empty BSTR for invalid Uri_PROPERTY's. */ *pbstrProperty = SysAllocStringLen(NULL, 0); + if(!(*pbstrProperty)) + return E_OUTOFMEMORY; /* It only returns S_FALSE for the ZONE property... */ if(uriProp == Uri_PROPERTY_ZONE) @@ -438,6 +440,19 @@ static HRESULT WINAPI Uri_GetPropertyBSTR(IUri *iface, Uri_PROPERTY uriProp, BST else hres = S_OK; break; + case Uri_PROPERTY_SCHEME_NAME: + if(This->scheme_start > -1) { + *pbstrProperty = SysAllocStringLen(This->canon_uri + This->scheme_start, This->scheme_len); + hres = S_OK; + } else { + *pbstrProperty = SysAllocStringLen(NULL, 0); + hres = S_FALSE; + } + + if(!(*pbstrProperty)) + hres = E_OUTOFMEMORY; + + break; default: FIXME("(%p)->(%d %p %x)\n", This, uriProp, pbstrProperty, dwFlags); hres = E_NOTIMPL; @@ -470,6 +485,10 @@ static HRESULT WINAPI Uri_GetPropertyLength(IUri *iface, Uri_PROPERTY uriProp, D *pcchProperty = SysStringLen(This->raw_uri); hres = S_OK; break; + case Uri_PROPERTY_SCHEME_NAME: + *pcchProperty = This->scheme_len; + hres = (This->scheme_start > -1) ? S_OK : S_FALSE; + break; default: FIXME("(%p)->(%d %p %x)\n", This, uriProp, pcchProperty, dwFlags); hres = E_NOTIMPL; @@ -481,7 +500,7 @@ static HRESULT WINAPI Uri_GetPropertyLength(IUri *iface, Uri_PROPERTY uriProp, D static HRESULT WINAPI Uri_GetPropertyDWORD(IUri *iface, Uri_PROPERTY uriProp, DWORD *pcchProperty, DWORD dwFlags) { Uri *This = URI_THIS(iface); - FIXME("(%p)->(%d %p %x)\n", This, uriProp, pcchProperty, dwFlags); + TRACE("(%p)->(%d %p %x)\n", This, uriProp, pcchProperty, dwFlags); if(!pcchProperty) return E_INVALIDARG; @@ -648,12 +667,8 @@ static HRESULT WINAPI Uri_GetRawUri(IUri *iface, BSTR *pstrRawUri) static HRESULT WINAPI Uri_GetSchemeName(IUri *iface, BSTR *pstrSchemeName) { Uri *This = URI_THIS(iface); - FIXME("(%p)->(%p)\n", This, pstrSchemeName); - - if(!pstrSchemeName) - return E_POINTER; - - return E_NOTIMPL; + TRACE("(%p)->(%p)\n", This, pstrSchemeName); + return Uri_GetPropertyBSTR(iface, Uri_PROPERTY_SCHEME_NAME, pstrSchemeName, 0); } static HRESULT WINAPI Uri_GetUserInfo(IUri *iface, BSTR *pstrUserInfo)

1 0

Igor Paliychuk : notepad: Ukrainian translation fix.
by Alexandre Julliard 21 Jul '10

21 Jul '10

Module: wine Branch: master Commit: 516e8a3b601070e67d77f986af6baf8a3837677c URL: http://source.winehq.org/git/wine.git/?a=commit;h=516e8a3b601070e67d77f986a… Author: Igor Paliychuk <Igor-hkr(a)mail.ru> Date: Tue Jul 20 20:45:29 2010 +0300 notepad: Ukrainian translation fix. --- programs/notepad/Uk.rc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/programs/notepad/Uk.rc b/programs/notepad/Uk.rc index 95938e9..b0844e0 100644 --- a/programs/notepad/Uk.rc +++ b/programs/notepad/Uk.rc @@ -63,7 +63,7 @@ POPUP "&Пошук" { } POPUP "&Довідка" { MENUITEM "&Зміст", CMD_HELP_CONTENTS - MENUITEM "&Пошук...", CMD_HELP_SEARCH + MENUITEM "По&шук...", CMD_HELP_SEARCH MENUITEM "&Використання Довідки", CMD_HELP_ON_HELP MENUITEM SEPARATOR MENUITEM "&Про Notepad", CMD_HELP_ABOUT_NOTEPAD

1 0

Igor Paliychuk : browseui: Add Ukrainian translation.
by Alexandre Julliard 21 Jul '10

21 Jul '10

Module: wine Branch: master Commit: 2d5a6231c0bfe401f159e5ee7dddd43861392b93 URL: http://source.winehq.org/git/wine.git/?a=commit;h=2d5a6231c0bfe401f159e5ee7… Author: Igor Paliychuk <Igor-hkr(a)mail.ru> Date: Tue Jul 20 20:46:55 2010 +0300 browseui: Add Ukrainian translation. --- dlls/browseui/Makefile.in | 1 + dlls/browseui/rsrc_Uk.rc | 43 +++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 44 insertions(+), 0 deletions(-) diff --git a/dlls/browseui/Makefile.in b/dlls/browseui/Makefile.in index 67e5dc9..fc493d5 100644 --- a/dlls/browseui/Makefile.in +++ b/dlls/browseui/Makefile.in @@ -33,6 +33,7 @@ RC_SRCS = \ rsrc_Ru.rc \ rsrc_Si.rc \ rsrc_Sv.rc \ + rsrc_Uk.rc \ rsrc_Zh.rc \ version.rc diff --git a/dlls/browseui/rsrc_Uk.rc b/dlls/browseui/rsrc_Uk.rc new file mode 100644 index 0000000..376c7b9 --- /dev/null +++ b/dlls/browseui/rsrc_Uk.rc @@ -0,0 +1,43 @@ +/* + * Copyright 2007 Mikolaj Zalewski + * Copyright 2010 Igor Paliychuk + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +#include "resids.h" + +/* UTF-8 */ +#pragma code_page(65001) + +LANGUAGE LANG_UKRAINIAN, SUBLANG_DEFAULT + +STRINGTABLE +{ + IDS_CANCELLING "Скасування..." +} + +IDD_PROGRESS_DLG DIALOG 0, 0, 260, 85 +STYLE DS_MODALFRAME | DS_CENTER | WS_POPUP | WS_VISIBLE | WS_CLIPCHILDREN | WS_CAPTION | WS_SYSMENU +CAPTION "" +FONT 8, "MS Shell Dlg" +{ + CONTROL "", IDC_ANIMATION, ANIMATE_CLASSA, 0, 12, 10, 236, 25 /* TODO: style */ + LTEXT "", IDC_TEXT_LINE, 7, 45, 250, 10, SS_LEFT|SS_NOPREFIX + LTEXT "", IDC_TEXT_LINE + 1, 7, 55, 250, 10, SS_LEFT|SS_NOPREFIX + CONTROL "", IDC_PROGRESS_BAR, PROGRESS_CLASSA, WS_BORDER, 7, 65, 190, 8 + PUSHBUTTON "&Скасувати", IDCANCEL, 205, 65, 40, 15, WS_GROUP | WS_TABSTOP | WS_VISIBLE + LTEXT "", IDC_TEXT_LINE + 2, 7, 75, 190, 10, SS_LEFT|SS_NOPREFIX +}

1 0