August 2010 - Wine-commits - list.winehq.org

Francois Gouget : mscoree/tests: Remove spaces before '\n's in traces.
by Alexandre Julliard 31 Aug '10

31 Aug '10

Module: wine Branch: master Commit: 394b08972fc66b64d53ee0173b68dde34d2f0d75 URL: http://source.winehq.org/git/wine.git/?a=commit;h=394b08972fc66b64d53ee0173… Author: Francois Gouget <fgouget(a)free.fr> Date: Tue Aug 31 11:48:42 2010 +0200 mscoree/tests: Remove spaces before '\n's in traces. --- dlls/mscoree/tests/mscoree.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/mscoree/tests/mscoree.c b/dlls/mscoree/tests/mscoree.c index 0536ba1..a50ce97 100644 --- a/dlls/mscoree/tests/mscoree.c +++ b/dlls/mscoree/tests/mscoree.c @@ -101,12 +101,12 @@ static void test_versioninfo(void) if(hr == CLR_E_SHIM_RUNTIME) return; /* skipping rest of tests on win2k as .net 2.0 not installed */ ok(hr == S_OK, "GetRequestedRuntimeInfo returned %08x\n", hr); - trace(" installed in directory %s is .net version %s \n", wine_dbgstr_w(path), wine_dbgstr_w(version)); + trace(" installed in directory %s is .net version %s\n", wine_dbgstr_w(path), wine_dbgstr_w(version)); hr = pGetRequestedRuntimeInfo( NULL, v1_1, NULL, 0, 0, path, MAX_PATH, &path_len, version, MAX_PATH, &size); ok(hr == S_OK || CLR_E_SHIM_RUNTIME /*v1_1 not installed*/, "GetRequestedRuntimeInfo returned %08x\n", hr); if(hr == S_OK) - trace(" installed in directory %s is .net version %s \n", wine_dbgstr_w(path), wine_dbgstr_w(version)); + trace(" installed in directory %s is .net version %s\n", wine_dbgstr_w(path), wine_dbgstr_w(version)); /* version number NULL not allowed without RUNTIME_INFO_UPGRADE_VERSION flag */ hr = pGetRequestedRuntimeInfo( NULL, NULL, NULL, 0, 0, path, MAX_PATH, &path_len, version, MAX_PATH, &size); ok(hr == CLR_E_SHIM_RUNTIME, "GetRequestedRuntimeInfo returned %08x\n", hr);

1 0

Francois Gouget : kernel32/tests: Fix compilation on systems that don' t support nameless unions or structs.
by Alexandre Julliard 31 Aug '10

31 Aug '10

Module: wine Branch: master Commit: f3c092f738d356dcdf111de772e7d0a7d106ea33 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f3c092f738d356dcdf111de77… Author: Francois Gouget <fgouget(a)free.fr> Date: Tue Aug 31 11:49:00 2010 +0200 kernel32/tests: Fix compilation on systems that don't support nameless unions or structs. --- dlls/kernel32/tests/process.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/dlls/kernel32/tests/process.c b/dlls/kernel32/tests/process.c index b4a048a..77a303c 100644 --- a/dlls/kernel32/tests/process.c +++ b/dlls/kernel32/tests/process.c @@ -1810,11 +1810,11 @@ static void test_SystemInfo(void) pGetNativeSystemInfo(&nsi); if (is_wow64) { - if (si.wProcessorArchitecture == PROCESSOR_ARCHITECTURE_INTEL) + if (S(U(si)).wProcessorArchitecture == PROCESSOR_ARCHITECTURE_INTEL) { - ok(nsi.wProcessorArchitecture == PROCESSOR_ARCHITECTURE_AMD64, + ok(S(U(nsi)).wProcessorArchitecture == PROCESSOR_ARCHITECTURE_AMD64, "Expected PROCESSOR_ARCHITECTURE_AMD64, got %d\n", - nsi.wProcessorArchitecture); + S(U(nsi)).wProcessorArchitecture); ok(nsi.dwProcessorType == PROCESSOR_AMD_X8664, "Expected PROCESSOR_AMD_X8664, got %d\n", nsi.dwProcessorType); @@ -1822,9 +1822,9 @@ static void test_SystemInfo(void) } else { - ok(si.wProcessorArchitecture == nsi.wProcessorArchitecture, + ok(S(U(si)).wProcessorArchitecture == S(U(nsi)).wProcessorArchitecture, "Expected no difference for wProcessorArchitecture, got %d and %d\n", - si.wProcessorArchitecture, nsi.wProcessorArchitecture); + S(U(si)).wProcessorArchitecture, S(U(nsi)).wProcessorArchitecture); ok(si.dwProcessorType == nsi.dwProcessorType, "Expected no difference for dwProcessorType, got %d and %d\n", si.dwProcessorType, nsi.dwProcessorType);

1 0

Francois Gouget : comdlg32: Make FD31_FreeOfnW() and FD31_MapOfnStructA() static.
by Alexandre Julliard 31 Aug '10

31 Aug '10

Module: wine Branch: master Commit: b520cc1aed87d901ce506e1c240cd146dbe1bb73 URL: http://source.winehq.org/git/wine.git/?a=commit;h=b520cc1aed87d901ce506e1c2… Author: Francois Gouget <fgouget(a)free.fr> Date: Tue Aug 31 11:49:13 2010 +0200 comdlg32: Make FD31_FreeOfnW() and FD31_MapOfnStructA() static. --- dlls/comdlg32/filedlg31.c | 4 ++-- dlls/comdlg32/filedlg31.h | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/dlls/comdlg32/filedlg31.c b/dlls/comdlg32/filedlg31.c index 89ef0e3..d74b1be 100644 --- a/dlls/comdlg32/filedlg31.c +++ b/dlls/comdlg32/filedlg31.c @@ -738,7 +738,7 @@ static LPWSTR FD31_DupToW(LPCSTR str, DWORD size) * FD31_MapOfnStructA [internal] * map a 32 bits Ansi structure to a Unicode one */ -void FD31_MapOfnStructA(const OPENFILENAMEA *ofnA, LPOPENFILENAMEW ofnW, BOOL open) +static void FD31_MapOfnStructA(const OPENFILENAMEA *ofnA, LPOPENFILENAMEW ofnW, BOOL open) { UNICODE_STRING usBuffer; @@ -796,7 +796,7 @@ void FD31_MapOfnStructA(const OPENFILENAMEA *ofnA, LPOPENFILENAMEW ofnW, BOOL op * FD31_FreeOfnW [internal] * Undo all allocations done by FD31_MapOfnStructA */ -void FD31_FreeOfnW(OPENFILENAMEW *ofnW) +static void FD31_FreeOfnW(OPENFILENAMEW *ofnW) { HeapFree(GetProcessHeap(), 0, (LPWSTR) ofnW->lpstrFilter); HeapFree(GetProcessHeap(), 0, ofnW->lpstrCustomFilter); diff --git a/dlls/comdlg32/filedlg31.h b/dlls/comdlg32/filedlg31.h index 79faed7..bb22005 100644 --- a/dlls/comdlg32/filedlg31.h +++ b/dlls/comdlg32/filedlg31.h @@ -40,8 +40,6 @@ extern BOOL FD32_GetTemplate(PFD31_DATA lfs); extern BOOL FD31_Init(void); extern PFD31_DATA FD31_AllocPrivate(LPARAM lParam, UINT dlgType, BOOL IsUnicode); extern void FD31_DestroyPrivate(PFD31_DATA lfs); -extern void FD31_MapOfnStructA(const OPENFILENAMEA *ofnA, LPOPENFILENAMEW ofnW, BOOL open); -extern void FD31_FreeOfnW(OPENFILENAMEW *ofnW); extern BOOL FD31_CallWindowProc(const FD31_DATA *lfs, UINT wMsg, WPARAM wParam, LPARAM lParam); extern LONG FD31_WMInitDialog(HWND hWnd, WPARAM wParam, LPARAM lParam);

1 0

Owen Rudge : d3dx9: Implement missing D3DXCreateTextureFromFile functions.
by Alexandre Julliard 31 Aug '10

31 Aug '10

Module: wine Branch: master Commit: ae695bdfaaea2b114938ff92210a14f5748f7da7 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ae695bdfaaea2b114938ff922… Author: Owen Rudge <orudge(a)codeweavers.com> Date: Mon Aug 30 11:57:42 2010 -0500 d3dx9: Implement missing D3DXCreateTextureFromFile functions. --- dlls/d3dx9_36/d3dx9_36.spec | 10 +++--- dlls/d3dx9_36/texture.c | 64 +++++++++++++++++++++++++++++++++++++++++- 2 files changed, 67 insertions(+), 7 deletions(-) diff --git a/dlls/d3dx9_36/d3dx9_36.spec b/dlls/d3dx9_36/d3dx9_36.spec index 691f2ec..c6c57fa 100644 --- a/dlls/d3dx9_36/d3dx9_36.spec +++ b/dlls/d3dx9_36/d3dx9_36.spec @@ -93,12 +93,12 @@ @ stub D3DXCreateTextA @ stub D3DXCreateTextW @ stdcall D3DXCreateTexture(ptr long long long long long long ptr) -@ stdcall D3DXCreateTextureFromFileA(ptr ptr ptr) -@ stub D3DXCreateTextureFromFileExA -@ stdcall D3DXCreateTextureFromFileExW(ptr ptr long long long long long long long long long ptr ptr ptr) -@ stub D3DXCreateTextureFromFileInMemory +@ stdcall D3DXCreateTextureFromFileA(ptr str ptr) +@ stdcall D3DXCreateTextureFromFileExA(ptr str long long long long long long long long long ptr ptr ptr) +@ stdcall D3DXCreateTextureFromFileExW(ptr wstr long long long long long long long long long ptr ptr ptr) +@ stdcall D3DXCreateTextureFromFileInMemory(ptr ptr long ptr) @ stdcall D3DXCreateTextureFromFileInMemoryEx(ptr ptr long long long long long long long long long long ptr ptr ptr) -@ stub D3DXCreateTextureFromFileW +@ stdcall D3DXCreateTextureFromFileW(ptr wstr ptr) @ stub D3DXCreateTextureFromResourceA @ stub D3DXCreateTextureFromResourceExA @ stub D3DXCreateTextureFromResourceExW diff --git a/dlls/d3dx9_36/texture.c b/dlls/d3dx9_36/texture.c index 8895a8f..4c4bc91 100644 --- a/dlls/d3dx9_36/texture.c +++ b/dlls/d3dx9_36/texture.c @@ -18,6 +18,7 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ +#include "wine/unicode.h" #include "wine/debug.h" #include "d3dx9_36_private.h" @@ -289,6 +290,17 @@ HRESULT WINAPI D3DXCreateTextureFromFileInMemoryEx(LPDIRECT3DDEVICE9 device, return E_NOTIMPL; } +HRESULT WINAPI D3DXCreateTextureFromFileInMemory(LPDIRECT3DDEVICE9 device, + LPCVOID srcdata, + UINT srcdatasize, + LPDIRECT3DTEXTURE9 *texture) +{ + TRACE("(%p, %p, %d, %p)\n", device, srcdata, srcdatasize, texture); + + return D3DXCreateTextureFromFileInMemoryEx(device, srcdata, srcdatasize, D3DX_DEFAULT, D3DX_DEFAULT, D3DX_DEFAULT, 0, D3DFMT_UNKNOWN, + D3DPOOL_MANAGED, D3DX_DEFAULT, D3DX_DEFAULT, 0, NULL, NULL, texture); +} + HRESULT WINAPI D3DXCreateTextureFromFileExW(LPDIRECT3DDEVICE9 device, LPCWSTR srcfile, UINT width, @@ -326,11 +338,59 @@ HRESULT WINAPI D3DXCreateTextureFromFileExW(LPDIRECT3DDEVICE9 device, return hr; } +HRESULT WINAPI D3DXCreateTextureFromFileExA(LPDIRECT3DDEVICE9 device, + LPCSTR srcfile, + UINT width, + UINT height, + UINT miplevels, + DWORD usage, + D3DFORMAT format, + D3DPOOL pool, + DWORD filter, + DWORD mipfilter, + D3DCOLOR colorkey, + D3DXIMAGE_INFO *srcinfo, + PALETTEENTRY *palette, + LPDIRECT3DTEXTURE9 *texture) +{ + LPWSTR widename; + HRESULT hr; + DWORD len; + + TRACE("(%p, %p, %u, %u, %u, %x, %x, %x, %u, %u, %x, %p, %p, %p): relay\n", device, debugstr_a(srcfile), width, + height, miplevels, usage, format, pool, filter, mipfilter, colorkey, srcinfo, palette, texture); + + if (!device || !srcfile || !texture) + return D3DERR_INVALIDCALL; + + len = MultiByteToWideChar(CP_ACP, 0, srcfile, -1, NULL, 0); + widename = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, len * sizeof(WCHAR)); + MultiByteToWideChar(CP_ACP, 0, srcfile, -1, widename, len); + + hr = D3DXCreateTextureFromFileExW(device, widename, width, height, miplevels, + usage, format, pool, filter, mipfilter, + colorkey, srcinfo, palette, texture); + + HeapFree(GetProcessHeap(), 0, widename); + return hr; +} + HRESULT WINAPI D3DXCreateTextureFromFileA(LPDIRECT3DDEVICE9 device, LPCSTR srcfile, LPDIRECT3DTEXTURE9 *texture) { - FIXME("(%p, %s, %p): stub\n", device, debugstr_a(srcfile), texture); + TRACE("(%p, %s, %p)\n", device, debugstr_a(srcfile), texture); - return E_NOTIMPL; + return D3DXCreateTextureFromFileExA(device, srcfile, D3DX_DEFAULT, D3DX_DEFAULT, D3DX_DEFAULT, 0, D3DFMT_UNKNOWN, + D3DPOOL_MANAGED, D3DX_DEFAULT, D3DX_DEFAULT, 0, NULL, NULL, texture); +} + +HRESULT WINAPI D3DXCreateTextureFromFileW(LPDIRECT3DDEVICE9 device, + LPCWSTR srcfile, + LPDIRECT3DTEXTURE9 *texture) +{ + TRACE("(%p, %s, %p)\n", device, debugstr_w(srcfile), texture); + + return D3DXCreateTextureFromFileExW(device, srcfile, D3DX_DEFAULT, D3DX_DEFAULT, D3DX_DEFAULT, 0, D3DFMT_UNKNOWN, + D3DPOOL_MANAGED, D3DX_DEFAULT, D3DX_DEFAULT, 0, NULL, NULL, texture); }

1 0

Henri Verbeet : wined3d: Recognize some more Radeon cards.
by Alexandre Julliard 31 Aug '10

31 Aug '10

Module: wine Branch: master Commit: 29371bf964e7bea3007d4daff8454947212b24a8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=29371bf964e7bea3007d4daff… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Mon Aug 30 20:29:45 2010 +0200 wined3d: Recognize some more Radeon cards. --- dlls/wined3d/directx.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/dlls/wined3d/directx.c b/dlls/wined3d/directx.c index ae9667c..9c85dca 100644 --- a/dlls/wined3d/directx.c +++ b/dlls/wined3d/directx.c @@ -1245,7 +1245,11 @@ static enum wined3d_pci_vendor wined3d_guess_card_vendor(const char *gl_vendor_s if (strstr(gl_vendor_string, "ATI") || strstr(gl_vendor_string, "Advanced Micro Devices, Inc.") || strstr(gl_vendor_string, "X.Org R300 Project") - || strstr(gl_vendor_string, "DRI R300 Project")) + || strstr(gl_renderer, "R100") + || strstr(gl_renderer, "R200") + || strstr(gl_renderer, "R300") + || strstr(gl_renderer, "R600") + || strstr(gl_renderer, "R700")) return HW_VENDOR_ATI; if (strstr(gl_vendor_string, "Intel(R)")

1 0

Henri Verbeet : wined3d: Use debug_surflocation() in surface_load_location( ).
by Alexandre Julliard 31 Aug '10

31 Aug '10

Module: wine Branch: master Commit: 1bf25cfe3fa87c86a049853635d6defa5b7dd3f3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1bf25cfe3fa87c86a04985363… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Mon Aug 30 20:29:46 2010 +0200 wined3d: Use debug_surflocation() in surface_load_location(). --- dlls/wined3d/surface.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c index 9e4fc7c..0731fb8 100644 --- a/dlls/wined3d/surface.c +++ b/dlls/wined3d/surface.c @@ -4386,7 +4386,7 @@ HRESULT surface_load_location(IWineD3DSurfaceImpl *surface, DWORD flag, const RE } else { - FIXME("Unimplemented location %#x for depth/stencil buffers.\n", flag); + FIXME("Unimplemented location %s for depth/stencil buffers.\n", debug_surflocation(flag)); return WINED3DERR_INVALIDCALL; } }

1 0

Henri Verbeet : wined3d: Get rid of WINED3DRECT.
by Alexandre Julliard 31 Aug '10

31 Aug '10

Module: wine Branch: master Commit: 4005eb2a18e93d61b1bb3ea3d258e58078921f2c URL: http://source.winehq.org/git/wine.git/?a=commit;h=4005eb2a18e93d61b1bb3ea3d… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Mon Aug 30 20:29:47 2010 +0200 wined3d: Get rid of WINED3DRECT. --- dlls/d3d8/device.c | 3 +-- dlls/d3d9/device.c | 5 ++--- dlls/ddraw/device.c | 3 +-- dlls/wined3d/device.c | 25 ++++++++++++------------- dlls/wined3d/surface.c | 2 +- include/wine/wined3d.idl | 12 ++---------- 6 files changed, 19 insertions(+), 31 deletions(-) diff --git a/dlls/d3d8/device.c b/dlls/d3d8/device.c index f889564..cafe27d 100644 --- a/dlls/d3d8/device.c +++ b/dlls/d3d8/device.c @@ -1069,9 +1069,8 @@ static HRESULT WINAPI IDirect3DDevice8Impl_Clear(LPDIRECT3DDEVICE8 iface, DWORD TRACE("iface %p, rect_count %u, rects %p, flags %#x, color 0x%08x, z %.8e, stencil %u.\n", iface, Count, pRects, Flags, Color, Z, Stencil); - /* Note: D3DRECT is compatible with WINED3DRECT */ wined3d_mutex_lock(); - hr = IWineD3DDevice_Clear(This->WineD3DDevice, Count, (CONST WINED3DRECT*) pRects, Flags, Color, Z, Stencil); + hr = IWineD3DDevice_Clear(This->WineD3DDevice, Count, (const RECT *)pRects, Flags, Color, Z, Stencil); wined3d_mutex_unlock(); return hr; diff --git a/dlls/d3d9/device.c b/dlls/d3d9/device.c index f5bcbaa..6b66bb2 100644 --- a/dlls/d3d9/device.c +++ b/dlls/d3d9/device.c @@ -1044,8 +1044,7 @@ static HRESULT WINAPI IDirect3DDevice9Impl_ColorFill(IDirect3DDevice9Ex *iface, } /* Colorfill can only be used on rendertarget surfaces, or offscreen plain surfaces in D3DPOOL_DEFAULT */ - /* Note: D3DRECT is compatible with WINED3DRECT */ - hr = IWineD3DDevice_ColorFill(This->WineD3DDevice, surface->wineD3DSurface, (const WINED3DRECT *)pRect, &c); + hr = IWineD3DDevice_ColorFill(This->WineD3DDevice, surface->wineD3DSurface, pRect, &c); wined3d_mutex_unlock(); @@ -1214,7 +1213,7 @@ static HRESULT WINAPI IDirect3DDevice9Impl_Clear(LPDIRECT3DDEVICE9EX iface, DW /* Note: D3DRECT is compatible with WINED3DRECT */ wined3d_mutex_lock(); - hr = IWineD3DDevice_Clear(This->WineD3DDevice, Count, (CONST WINED3DRECT*) pRects, Flags, Color, Z, Stencil); + hr = IWineD3DDevice_Clear(This->WineD3DDevice, Count, (const RECT *)pRects, Flags, Color, Z, Stencil); wined3d_mutex_unlock(); return hr; diff --git a/dlls/ddraw/device.c b/dlls/ddraw/device.c index 4677f6e..7837dcd 100644 --- a/dlls/ddraw/device.c +++ b/dlls/ddraw/device.c @@ -5220,9 +5220,8 @@ IDirect3DDeviceImpl_7_Clear(IDirect3DDevice7 *iface, TRACE("iface %p, count %u, rects %p, flags %#x, color 0x%08x, z %.8e, stencil %#x.\n", iface, Count, Rects, Flags, Color, Z, Stencil); - /* Note; D3DRECT is compatible with WINED3DRECT */ EnterCriticalSection(&ddraw_cs); - hr = IWineD3DDevice_Clear(This->wineD3DDevice, Count, (WINED3DRECT*) Rects, Flags, Color, Z, Stencil); + hr = IWineD3DDevice_Clear(This->wineD3DDevice, Count, (RECT *)Rects, Flags, Color, Z, Stencil); LeaveCriticalSection(&ddraw_cs); return hr; } diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c index a90ad80..9b4965d 100644 --- a/dlls/wined3d/device.c +++ b/dlls/wined3d/device.c @@ -4576,28 +4576,27 @@ static HRESULT WINAPI IWineD3DDeviceImpl_Present(IWineD3DDevice *iface, return WINED3D_OK; } -static HRESULT WINAPI IWineD3DDeviceImpl_Clear(IWineD3DDevice *iface, DWORD Count, - const WINED3DRECT *pRects, DWORD Flags, WINED3DCOLOR color, float Z, DWORD Stencil) +static HRESULT WINAPI IWineD3DDeviceImpl_Clear(IWineD3DDevice *iface, DWORD rect_count, + const RECT *rects, DWORD flags, WINED3DCOLOR color, float depth, DWORD stencil) { const WINED3DCOLORVALUE c = {D3DCOLOR_R(color), D3DCOLOR_G(color), D3DCOLOR_B(color), D3DCOLOR_A(color)}; - IWineD3DDeviceImpl *This = (IWineD3DDeviceImpl *)iface; + IWineD3DDeviceImpl *device = (IWineD3DDeviceImpl *)iface; RECT draw_rect; - TRACE("(%p) Count (%d), pRects (%p), Flags (%x), color (0x%08x), Z (%f), Stencil (%d)\n", This, - Count, pRects, Flags, color, Z, Stencil); + TRACE("iface %p, rect_count %u, rects %p, flags %#x, color 0x%08x, depth %.8e, stencil %u.\n", + iface, rect_count, rects, flags, color, depth, stencil); - if (Flags & (WINED3DCLEAR_ZBUFFER | WINED3DCLEAR_STENCIL) && !This->depth_stencil) + if (flags & (WINED3DCLEAR_ZBUFFER | WINED3DCLEAR_STENCIL) && !device->depth_stencil) { WARN("Clearing depth and/or stencil without a depth stencil buffer attached, returning WINED3DERR_INVALIDCALL\n"); /* TODO: What about depth stencil buffers without stencil bits? */ return WINED3DERR_INVALIDCALL; } - device_get_draw_rect(This, &draw_rect); + device_get_draw_rect(device, &draw_rect); - return device_clear_render_targets(This, This->adapter->gl_info.limits.buffers, - This->render_targets, Count, (const RECT *)pRects, &draw_rect, Flags, - &c, Z, Stencil); + return device_clear_render_targets(device, device->adapter->gl_info.limits.buffers, + device->render_targets, rect_count, rects, &draw_rect, flags, &c, depth, stencil); } /***** @@ -5497,12 +5496,12 @@ static HRESULT WINAPI IWineD3DDeviceImpl_DeletePatch(IWineD3DDevice *iface, UINT } static HRESULT WINAPI IWineD3DDeviceImpl_ColorFill(IWineD3DDevice *iface, - IWineD3DSurface *surface, const WINED3DRECT *pRect, const WINED3DCOLORVALUE *color) + IWineD3DSurface *surface, const RECT *rect, const WINED3DCOLORVALUE *color) { IWineD3DSurfaceImpl *s = (IWineD3DSurfaceImpl *)surface; TRACE("iface %p, surface %p, rect %s, color {%.8e, %.8e, %.8e, %.8e}.\n", - iface, surface, wine_dbgstr_rect((const RECT *)pRect), + iface, surface, wine_dbgstr_rect(rect), color->r, color->g, color->b, color->a); if (s->resource.pool != WINED3DPOOL_DEFAULT && s->resource.pool != WINED3DPOOL_SYSTEMMEM) @@ -5511,7 +5510,7 @@ static HRESULT WINAPI IWineD3DDeviceImpl_ColorFill(IWineD3DDevice *iface, return WINED3DERR_INVALIDCALL; } - return surface_color_fill(s, (const RECT *)pRect, color); + return surface_color_fill(s, rect, color); } static void WINAPI IWineD3DDeviceImpl_ClearRendertargetView(IWineD3DDevice *iface, diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c index 0731fb8..1cc5dbd 100644 --- a/dlls/wined3d/surface.c +++ b/dlls/wined3d/surface.c @@ -3790,7 +3790,7 @@ static HRESULT IWineD3DSurfaceImpl_BltZ(IWineD3DSurfaceImpl *This, const RECT *D ERR("Unexpected format for depth fill: %s.\n", debug_d3dformat(This->resource.format_desc->id)); } - return IWineD3DDevice_Clear((IWineD3DDevice *)device, DestRect ? 1 : 0, (const WINED3DRECT *)DestRect, + return IWineD3DDevice_Clear((IWineD3DDevice *)device, DestRect ? 1 : 0, DestRect, WINED3DCLEAR_ZBUFFER, 0x00000000, depth, 0x00000000); } diff --git a/include/wine/wined3d.idl b/include/wine/wined3d.idl index 62810db..7f88b3a 100644 --- a/include/wine/wined3d.idl +++ b/include/wine/wined3d.idl @@ -1573,14 +1573,6 @@ typedef struct _WINED3DMATRIX } DUMMYUNIONNAME; } WINED3DMATRIX; -typedef struct _WINED3DRECT -{ - LONG x1; - LONG y1; - LONG x2; - LONG y2; -} WINED3DRECT; - typedef struct _WINED3DLIGHT { WINED3DLIGHTTYPE Type; @@ -3305,7 +3297,7 @@ interface IWineD3DDevice : IWineD3DBase ); HRESULT Clear( [in] DWORD rect_count, - [in] const WINED3DRECT *rects, + [in] const RECT *rects, [in] DWORD flags, [in] WINED3DCOLOR color, [in] float z, @@ -3367,7 +3359,7 @@ interface IWineD3DDevice : IWineD3DBase ); HRESULT ColorFill( [in] IWineD3DSurface *surface, - [in] const WINED3DRECT *rect, + [in] const RECT *rect, [in] const WINED3DCOLORVALUE *color ); HRESULT UpdateTexture(

1 0

Henri Verbeet : wined3d: Implicit depth/stencil surfaces don' t have a container.
by Alexandre Julliard 31 Aug '10

31 Aug '10

Module: wine Branch: master Commit: c568916f9e372ea7191aa55413723bdb0bb6947e URL: http://source.winehq.org/git/wine.git/?a=commit;h=c568916f9e372ea7191aa5541… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Mon Aug 30 20:29:48 2010 +0200 wined3d: Implicit depth/stencil surfaces don't have a container. They're owned by the device instead of the swapchain. --- dlls/d3d10core/device.c | 9 ++++----- dlls/d3d8/device.c | 9 ++++----- dlls/d3d9/device.c | 9 ++++----- dlls/ddraw/ddraw.c | 9 ++++----- dlls/wined3d/device.c | 1 - dlls/wined3d/swapchain.c | 2 +- include/wine/wined3d.idl | 1 - 7 files changed, 17 insertions(+), 23 deletions(-) diff --git a/dlls/d3d10core/device.c b/dlls/d3d10core/device.c index 32b8bb0..f5c4e82 100644 --- a/dlls/d3d10core/device.c +++ b/dlls/d3d10core/device.c @@ -1374,18 +1374,17 @@ static HRESULT STDMETHODCALLTYPE device_parent_CreateRenderTarget(IWineD3DDevice } static HRESULT STDMETHODCALLTYPE device_parent_CreateDepthStencilSurface(IWineD3DDeviceParent *iface, - IUnknown *superior, UINT width, UINT height, enum wined3d_format_id format, - WINED3DMULTISAMPLE_TYPE multisample_type, DWORD multisample_quality, BOOL discard, - IWineD3DSurface **surface) + UINT width, UINT height, enum wined3d_format_id format, WINED3DMULTISAMPLE_TYPE multisample_type, + DWORD multisample_quality, BOOL discard, IWineD3DSurface **surface) { struct d3d10_device *This = device_from_device_parent(iface); struct d3d10_texture2d *texture; D3D10_TEXTURE2D_DESC desc; HRESULT hr; - FIXME("iface %p, superior %p, width %u, height %u, format %#x, multisample_type %#x,\n" + FIXME("iface %p, width %u, height %u, format %#x, multisample_type %#x,\n" "\tmultisample_quality %u, discard %u, surface %p partial stub!\n", - iface, superior, width, height, format, multisample_type, multisample_quality, discard, surface); + iface, width, height, format, multisample_type, multisample_quality, discard, surface); FIXME("Implement DXGI<->wined3d usage conversion\n"); diff --git a/dlls/d3d8/device.c b/dlls/d3d8/device.c index cafe27d..6d89a48 100644 --- a/dlls/d3d8/device.c +++ b/dlls/d3d8/device.c @@ -2623,17 +2623,16 @@ static HRESULT STDMETHODCALLTYPE device_parent_CreateRenderTarget(IWineD3DDevice } static HRESULT STDMETHODCALLTYPE device_parent_CreateDepthStencilSurface(IWineD3DDeviceParent *iface, - IUnknown *superior, UINT width, UINT height, enum wined3d_format_id format, - WINED3DMULTISAMPLE_TYPE multisample_type, DWORD multisample_quality, BOOL discard, - IWineD3DSurface **surface) + UINT width, UINT height, enum wined3d_format_id format, WINED3DMULTISAMPLE_TYPE multisample_type, + DWORD multisample_quality, BOOL discard, IWineD3DSurface **surface) { struct IDirect3DDevice8Impl *This = device_from_device_parent(iface); IDirect3DSurface8Impl *d3d_surface; HRESULT hr; - TRACE("iface %p, superior %p, width %u, height %u, format %#x, multisample_type %#x,\n" + TRACE("iface %p, width %u, height %u, format %#x, multisample_type %#x,\n" "\tmultisample_quality %u, discard %u, surface %p\n", - iface, superior, width, height, format, multisample_type, multisample_quality, discard, surface); + iface, width, height, format, multisample_type, multisample_quality, discard, surface); hr = IDirect3DDevice8_CreateDepthStencilSurface((IDirect3DDevice8 *)This, width, height, d3dformat_from_wined3dformat(format), multisample_type, (IDirect3DSurface8 **)&d3d_surface); diff --git a/dlls/d3d9/device.c b/dlls/d3d9/device.c index 6b66bb2..7fab981 100644 --- a/dlls/d3d9/device.c +++ b/dlls/d3d9/device.c @@ -2688,17 +2688,16 @@ static HRESULT STDMETHODCALLTYPE device_parent_CreateRenderTarget(IWineD3DDevice } static HRESULT STDMETHODCALLTYPE device_parent_CreateDepthStencilSurface(IWineD3DDeviceParent *iface, - IUnknown *superior, UINT width, UINT height, enum wined3d_format_id format, - WINED3DMULTISAMPLE_TYPE multisample_type, DWORD multisample_quality, BOOL discard, - IWineD3DSurface **surface) + UINT width, UINT height, enum wined3d_format_id format, WINED3DMULTISAMPLE_TYPE multisample_type, + DWORD multisample_quality, BOOL discard, IWineD3DSurface **surface) { struct IDirect3DDevice9Impl *This = device_from_device_parent(iface); IDirect3DSurface9Impl *d3d_surface; HRESULT hr; - TRACE("iface %p, superior %p, width %u, height %u, format %#x, multisample_type %#x,\n" + TRACE("iface %p, width %u, height %u, format %#x, multisample_type %#x,\n" "\tmultisample_quality %u, discard %u, surface %p\n", - iface, superior, width, height, format, multisample_type, multisample_quality, discard, surface); + iface, width, height, format, multisample_type, multisample_quality, discard, surface); hr = IDirect3DDevice9Impl_CreateDepthStencilSurface((IDirect3DDevice9Ex *)This, width, height, d3dformat_from_wined3dformat(format), multisample_type, multisample_quality, discard, diff --git a/dlls/ddraw/ddraw.c b/dlls/ddraw/ddraw.c index af5eb37..d250fb5 100644 --- a/dlls/ddraw/ddraw.c +++ b/dlls/ddraw/ddraw.c @@ -5564,18 +5564,17 @@ static HRESULT STDMETHODCALLTYPE device_parent_CreateRenderTarget(IWineD3DDevice } static HRESULT STDMETHODCALLTYPE device_parent_CreateDepthStencilSurface(IWineD3DDeviceParent *iface, - IUnknown *superior, UINT width, UINT height, enum wined3d_format_id format, - WINED3DMULTISAMPLE_TYPE multisample_type, DWORD multisample_quality, BOOL discard, - IWineD3DSurface **surface) + UINT width, UINT height, enum wined3d_format_id format, WINED3DMULTISAMPLE_TYPE multisample_type, + DWORD multisample_quality, BOOL discard, IWineD3DSurface **surface) { struct IDirectDrawImpl *This = ddraw_from_device_parent(iface); IDirectDrawSurfaceImpl *ddraw_surface; DDSURFACEDESC2 ddsd; HRESULT hr; - TRACE("iface %p, superior %p, width %u, height %u, format %#x, multisample_type %#x,\n" + TRACE("iface %p, width %u, height %u, format %#x, multisample_type %#x,\n" "\tmultisample_quality %u, discard %u, surface %p\n", - iface, superior, width, height, format, multisample_type, multisample_quality, discard, surface); + iface, width, height, format, multisample_type, multisample_quality, discard, surface); *surface = NULL; diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c index 9b4965d..bf28b9c 100644 --- a/dlls/wined3d/device.c +++ b/dlls/wined3d/device.c @@ -6265,7 +6265,6 @@ static HRESULT WINAPI IWineD3DDeviceImpl_Reset(IWineD3DDevice* iface, WINED3DPRE TRACE("Creating the depth stencil buffer\n"); hrc = IWineD3DDeviceParent_CreateDepthStencilSurface(This->device_parent, - This->parent, pPresentationParameters->BackBufferWidth, pPresentationParameters->BackBufferHeight, pPresentationParameters->AutoDepthStencilFormat, diff --git a/dlls/wined3d/swapchain.c b/dlls/wined3d/swapchain.c index 538899e..4fa7e64 100644 --- a/dlls/wined3d/swapchain.c +++ b/dlls/wined3d/swapchain.c @@ -856,7 +856,7 @@ HRESULT swapchain_init(IWineD3DSwapChainImpl *swapchain, WINED3DSURFTYPE surface TRACE("Creating depth/stencil buffer.\n"); if (!device->auto_depth_stencil) { - hr = IWineD3DDeviceParent_CreateDepthStencilSurface(device->device_parent, parent, + hr = IWineD3DDeviceParent_CreateDepthStencilSurface(device->device_parent, swapchain->presentParms.BackBufferWidth, swapchain->presentParms.BackBufferHeight, swapchain->presentParms.AutoDepthStencilFormat, swapchain->presentParms.MultiSampleType, swapchain->presentParms.MultiSampleQuality, FALSE /* FIXME: Discard */, diff --git a/include/wine/wined3d.idl b/include/wine/wined3d.idl index 7f88b3a..bff4012 100644 --- a/include/wine/wined3d.idl +++ b/include/wine/wined3d.idl @@ -2143,7 +2143,6 @@ interface IWineD3DDeviceParent : IUnknown ); HRESULT CreateDepthStencilSurface( - [in] IUnknown *superior, [in] UINT width, [in] UINT height, [in] enum wined3d_format_id format_id,

1 0

Piotr Caban : msvcp90/tests: Added basic_string<wchar_t> tests.
by Alexandre Julliard 30 Aug '10

30 Aug '10

Module: wine Branch: master Commit: 39b98144c7e01a727fc1a27aaf4025012a347f19 URL: http://source.winehq.org/git/wine.git/?a=commit;h=39b98144c7e01a727fc1a27aa… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Mon Aug 30 16:36:07 2010 +0200 msvcp90/tests: Added basic_string<wchar_t> tests. --- dlls/msvcp90/tests/string.c | 114 ++++++++++++++++++++++++++++++++++++++++++- 1 files changed, 113 insertions(+), 1 deletions(-) diff --git a/dlls/msvcp90/tests/string.c b/dlls/msvcp90/tests/string.c index 1eae95d..f780779 100644 --- a/dlls/msvcp90/tests/string.c +++ b/dlls/msvcp90/tests/string.c @@ -27,7 +27,7 @@ typedef struct _basic_string_char { void *allocator; - union _data { + union { char buf[BUF_SIZE_CHAR]; char *ptr; } data; @@ -35,6 +35,19 @@ typedef struct _basic_string_char size_t res; } basic_string_char; +/* basic_string<wchar_t, char_traits<wchar_t>, allocator<wchar_t>> */ +#define BUF_SIZE_WCHAR 8 +typedef struct _basic_string_wchar +{ + void *allocator; + union { + wchar_t buf[BUF_SIZE_WCHAR]; + wchar_t *ptr; + } data; + size_t size; + size_t res; +} basic_string_wchar; + static void* (__cdecl *p_set_invalid_parameter_handler)(void*); #ifdef __i386__ @@ -45,6 +58,14 @@ static void (WINAPI *p_basic_string_char_dtor)(void); static basic_string_char* (WINAPI *p_basic_string_char_erase)(size_t, size_t); static basic_string_char* (WINAPI *p_basic_string_char_assign_cstr_len)(const char*, size_t); static const char* (WINAPI *p_basic_string_char_cstr)(void); + +static basic_string_wchar* (WINAPI *p_basic_string_wchar_ctor)(void); +static basic_string_wchar* (WINAPI *p_basic_string_wchar_copy_ctor)(basic_string_wchar*); +static basic_string_wchar* (WINAPI *p_basic_string_wchar_ctor_cstr)(const wchar_t*); +static void (WINAPI *p_basic_string_wchar_dtor)(void); +static basic_string_wchar* (WINAPI *p_basic_string_wchar_erase)(size_t, size_t); +static basic_string_wchar* (WINAPI *p_basic_string_wchar_assign_cstr_len)(const wchar_t*, size_t); +static const wchar_t* (WINAPI *p_basic_string_wchar_cstr)(void); #else static basic_string_char* (__cdecl *p_basic_string_char_ctor)(basic_string_char*); static basic_string_char* (__cdecl *p_basic_string_char_copy_ctor)(basic_string_char*, basic_string_char*); @@ -53,6 +74,14 @@ static void (__cdecl *p_basic_string_char_dtor)(basic_string_char*); static basic_string_char* (__cdecl *p_basic_string_char_erase)(basic_string_char*, size_t, size_t); static basic_string_char* (__cdecl *p_basic_string_char_assign_cstr_len)(basic_string_char*, const char*, size_t); static const char* (__cdecl *p_basic_string_char_cstr)(basic_string_char*); + +static basic_string_wchar* (__cdecl *p_basic_string_wchar_ctor)(basic_string_wchar*); +static basic_string_wchar* (__cdecl *p_basic_string_wchar_copy_ctor)(basic_string_wchar*, basic_string_wchar*); +static basic_string_wchar* (__cdecl *p_basic_string_wchar_ctor_cstr)(basic_string_wchar*, const wchar_t*); +static void (__cdecl *p_basic_string_wchar_dtor)(basic_string_wchar*); +static basic_string_wchar* (__cdecl *p_basic_string_wchar_erase)(basic_string_wchar*, size_t, size_t); +static basic_string_wchar* (__cdecl *p_basic_string_wchar_assign_cstr_len)(basic_string_wchar*, const wchar_t*, size_t); +static const wchar_t* (__cdecl *p_basic_string_wchar_cstr)(basic_string_wchar*); #endif static int invalid_parameter = 0; @@ -199,6 +228,21 @@ static BOOL init(void) "?assign@?$basic_string(a)DU?$char_traits(a)D@std@@V?$allocator(a)D@2@@std@@QEAAAEAV12(a)PEBD_K@Z"); p_basic_string_char_cstr = (void*)GetProcAddress(msvcp, "?c_str@?$basic_string(a)DU?$char_traits(a)D@std@@V?$allocator(a)D@2@@std@@QEBAPEBDXZ"); + + p_basic_string_wchar_ctor = (void*)GetProcAddress(msvcp, + "??0?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QEAA(a)XZ"); + p_basic_string_wchar_copy_ctor = (void*)GetProcAddress(msvcp, + "??0?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QEAA(a)AEBV01@@Z"); + p_basic_string_wchar_ctor_cstr = (void*)GetProcAddress(msvcp, + "??0?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QEAA(a)PEB_W@Z"); + p_basic_string_wchar_dtor = (void*)GetProcAddress(msvcp, + "??1?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QEAA(a)XZ"); + p_basic_string_wchar_erase = (void*)GetProcAddress(msvcp, + "?erase@?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QEAAAEAV12(a)_K0@Z"); + p_basic_string_wchar_assign_cstr_len = (void*)GetProcAddress(msvcp, + "?assign@?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QEAAAEAV12(a)PEB_W_K@Z"); + p_basic_string_wchar_cstr = (void*)GetProcAddress(msvcp, + "?c_str@?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QEBAPEB_WXZ"); } else { p_basic_string_char_ctor = (void*)GetProcAddress(msvcp, "??0?$basic_string(a)DU?$char_traits(a)D@std@@V?$allocator(a)D@2@@std@@QAE(a)XZ"); @@ -214,6 +258,21 @@ static BOOL init(void) "?assign@?$basic_string(a)DU?$char_traits(a)D@std@@V?$allocator(a)D@2@@std@@QAEAAV12(a)PBDI@Z"); p_basic_string_char_cstr = (void*)GetProcAddress(msvcp, "?c_str@?$basic_string(a)DU?$char_traits(a)D@std@@V?$allocator(a)D@2@@std@@QBEPBDXZ"); + + p_basic_string_wchar_ctor = (void*)GetProcAddress(msvcp, + "??0?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QAE(a)XZ"); + p_basic_string_wchar_copy_ctor = (void*)GetProcAddress(msvcp, + "??0?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QAE(a)ABV01@@Z"); + p_basic_string_wchar_ctor_cstr = (void*)GetProcAddress(msvcp, + "??0?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QAE(a)PB_W@Z"); + p_basic_string_wchar_dtor = (void*)GetProcAddress(msvcp, + "??1?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QAE(a)XZ"); + p_basic_string_wchar_erase = (void*)GetProcAddress(msvcp, + "?erase@?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QAEAAV12(a)II@Z"); + p_basic_string_wchar_assign_cstr_len = (void*)GetProcAddress(msvcp, + "?assign@?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QAEAAV12(a)PB_WI@Z"); + p_basic_string_wchar_cstr = (void*)GetProcAddress(msvcp, + "?c_str@?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QBEPB_WXZ"); } return TRUE; @@ -268,12 +327,65 @@ static void test_basic_string_char(void) { call_func1(p_basic_string_char_dtor, &str2); } +static void test_basic_string_wchar(void) { + static const wchar_t test[] = { 't','e','s','t',0 }; + + basic_string_wchar str1, str2, *pstr; + const wchar_t *str; + + if(!p_basic_string_wchar_ctor || !p_basic_string_wchar_copy_ctor + || !p_basic_string_wchar_ctor_cstr || !p_basic_string_wchar_dtor + || !p_basic_string_wchar_erase || !p_basic_string_wchar_assign_cstr_len + || !p_basic_string_wchar_cstr) { + win_skip("basic_string<wchar_t> unavailable\n"); + return; + } + + call_func1(p_basic_string_wchar_ctor, &str1); + str = NULL; + str = call_func1(p_basic_string_wchar_cstr, &str1); + ok(str != NULL, "str = NULL\n"); + ok(*str == '\0', "*str = %c\n", *str); + call_func1(p_basic_string_wchar_dtor, &str1); + + pstr = call_func2(p_basic_string_wchar_ctor_cstr, &str1, test); + ok(pstr == &str1, "pstr != &str1\n"); + str = call_func1(p_basic_string_wchar_cstr, &str1); + ok(!memcmp(str, test, 5*sizeof(wchar_t)), "str = %s\n", wine_dbgstr_w(str)); + + memset(&str2, 0, sizeof(basic_string_wchar)); + pstr = call_func2(p_basic_string_wchar_copy_ctor, &str2, &str1); + ok(pstr == &str2, "pstr != &str2\n"); + str = call_func1(p_basic_string_wchar_cstr, &str2); + ok(!memcmp(str, test, 5*sizeof(wchar_t)), "str = %s\n", wine_dbgstr_w(str)); + + call_func3(p_basic_string_wchar_erase, &str2, 1, 2); + str = call_func1(p_basic_string_wchar_cstr, &str2); + ok(str[0]=='t' && str[1]=='t' && str[2]=='\0', "str = %s\n", wine_dbgstr_w(str)); + + call_func3(p_basic_string_wchar_erase, &str2, 1, 100); + str = call_func1(p_basic_string_wchar_cstr, &str2); + ok(str[0]=='t' && str[1]=='\0', "str = %s\n", wine_dbgstr_w(str)); + + call_func3(p_basic_string_wchar_assign_cstr_len, &str2, test, 4); + str = call_func1(p_basic_string_wchar_cstr, &str2); + ok(!memcmp(str, test, 5*sizeof(wchar_t)), "str = %s\n", wine_dbgstr_w(str)); + + call_func3(p_basic_string_wchar_assign_cstr_len, &str2, (str+1), 2); + str = call_func1(p_basic_string_wchar_cstr, &str2); + ok(str[0]=='e' && str[1]=='s' && str[2]=='\0', "str = %s\n", wine_dbgstr_w(str)); + + call_func1(p_basic_string_wchar_dtor, &str1); + call_func1(p_basic_string_wchar_dtor, &str2); +} + START_TEST(string) { if(!init()) return; test_basic_string_char(); + test_basic_string_wchar(); ok(!invalid_parameter, "invalid_parameter_handler was invoked too many times\n"); }

1 0

Eric Pouech : server: Fix method name in comments for fd_ops.
by Alexandre Julliard 30 Aug '10

30 Aug '10

Module: wine Branch: master Commit: c1d35ba54073848064f06123a3c427d9f63367e7 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c1d35ba54073848064f06123a… Author: Eric Pouech <eric.pouech(a)orange.fr> Date: Sat Aug 28 13:14:37 2010 +0200 server: Fix method name in comments for fd_ops. --- server/serial.c | 2 +- server/sock.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/server/serial.c b/server/serial.c index 6fa60e5..587fee1 100644 --- a/server/serial.c +++ b/server/serial.c @@ -108,7 +108,7 @@ static const struct fd_ops serial_fd_ops = default_fd_get_poll_events, /* get_poll_events */ default_poll_event, /* poll_event */ serial_flush, /* flush */ - serial_get_fd_type, /* get_file_info */ + serial_get_fd_type, /* get_fd_type */ default_fd_ioctl, /* ioctl */ serial_queue_async, /* queue_async */ default_fd_reselect_async, /* reselect_async */ diff --git a/server/sock.c b/server/sock.c index 639421d..02f4a6d 100644 --- a/server/sock.c +++ b/server/sock.c @@ -152,7 +152,7 @@ static const struct fd_ops sock_fd_ops = sock_get_poll_events, /* get_poll_events */ sock_poll_event, /* poll_event */ no_flush, /* flush */ - sock_get_fd_type, /* get_file_info */ + sock_get_fd_type, /* get_fd_type */ default_fd_ioctl, /* ioctl */ sock_queue_async, /* queue_async */ sock_reselect_async, /* reselect_async */

1 0